From nobody Tue Feb 10 10:54:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766589904; cv=none; d=zohomail.com; s=zohoarc; b=cTR5wzqtL5Ndmmz7xZ0BZCZR2fWFb00nR1i/DQcHftneFBY4iK+XitlZU3zn2WA41lAoVHw6/RNhBmH2AzyRplhPO5Kpms++QFezErxZ/O+Hz0nmSS3DGNgqFzLZc3NZo71yk0niqVANybNVrUgT7QHoYokvEywhEj7xO/GOSNM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766589904; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=I6HMTxxs6Ve5Sks2R1l9RktCbKwSNfSiUvebbKXSoPQ=; b=MT9Ux9zuUW1SCMX14X+HRn4cfnMiJjMOlSwF0BMI2Y2nhBQDrwQUZl2l2Z8s1vQfuAf7nXsSCBdb3LCdW9O86RnRWqIYUmGWnMjljODSkckh3TzE0axQHVzADXE+VrVgu0SmeBPTZf/iru8rN7S7L8alj2AOV0RpwGvZYrA4CSw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176658990412965.81426832795285; Wed, 24 Dec 2025 07:25:04 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYQjP-0004sW-PT; Wed, 24 Dec 2025 10:24:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYQj9-0004ZD-0T for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:24:45 -0500 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYQj4-0004nC-9g for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:24:36 -0500 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-64b4f730a02so9769927a12.0 for ; Wed, 24 Dec 2025 07:24:31 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b91056726sm16630876a12.10.2025.12.24.07.24.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 07:24:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766589870; x=1767194670; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I6HMTxxs6Ve5Sks2R1l9RktCbKwSNfSiUvebbKXSoPQ=; b=Lw8IQ/pRcmKQLYge8+Yz7w0r8nHsMoWoDcrAOtmyJSRETW61udmd+11Y5zYTCkFA94 Es0K/JQUBb3v6ig6jRK8Vw1RugmKAU3kYgdpZNbqcmyK4TIX6A5spjmPEZKjTPGBRBwL GsiCj+hLEdkdksAIXOkP07tRJWkHY3kVYtuqeQKCWsG2II2PlMgoF+SPCdLSVKa1Hw+s QKoQJx9zkXprH8luaQTSuATJpOOB4aVyZZCyd3FQQ3ObqUvxiWXe1s3OPpYSB5nuKI4Z 1Dz9e0hxo8/I8zT8LgYhDYFx/1CnpVR83qsCiRrJZFheTdwVrmQE5jfgzrWExEfTHGCX QUKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766589870; x=1767194670; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=I6HMTxxs6Ve5Sks2R1l9RktCbKwSNfSiUvebbKXSoPQ=; b=OptES95VH+Gad5Bw4URrhWLemkmNL4Ue5Lz9CZFWEnyoaNhatoqzyApotdlr5IHN1s DIlH3uZggQog+06Ie71F0A1fKPH+Vwv7McCrEYCdREmx6AE/+aXrPphjrRdYX1jG+zv0 DClM8srBZnSiVJnOLRrYEYB78APZy97JY3NW6OjEnFyjFQUKzhvdK04ignS1NF/8vkoh BPgw33VuiltoaaIDvQnLjFjXsY8n69E3kMjPXT1uEjYVDuncO0UM91/A2E4nbz3j74AU Xcw15zgAZXFPcmyqMbkHg/xBNPC+gjCmxgxlaBMCGH+yF03ux1x4lFLGptn8DlEykTdT liew== X-Gm-Message-State: AOJu0YydtsVXT9XP+uw8siVjOQVLx6KaQC9jmGNL0A8BshTdB/KdWnJd Eomp4DKMrj7yOt+gP4my09qlW7fWra95iF7TP74mPQMTui8fod+p2cyPP7+WVQcXiEzCVqjeN+k edx85u58= X-Gm-Gg: AY/fxX45MhWEAaTS2EJRy2E39qaLSuBIfBnLKmIQEMAR8R65o6rrCAvLFmgo46tqf9y ZArjLXr5Xwdq3HGRY5l0A2j+WzEX4vXvSuSDOuT/wC8TXM5Ge8gqowaXnLm0Ls2WuPA9KvNaT7E pzIOi/dHILE9Cs+1vq4R6Dy1vrKvP1X+kOZiUS/w7hGPcKgI71TzFB+htGannM1vl3FQIw/01KT 4yp5ktQZIhhcY6JbavDPUgQTIaIWbPY9zIe6Mq0cCoPQAai4HpAp2kNmSaoGv9Q2ybPc68oPsyU kXgCm6QJ1aFrv5ukIhKReuBl2M8sShypLmvMqXUUwZvR8+rGG9eJCJjp5VYHdUBjdaXVFnwouC7 FlNnROnDuhzN0nZ5Toqx4eYHcusbAr3Eom6I/hWZZRcKXYhRNGSyQdLtNvPdM0I/4RHhdCz453c Fy5vRxeoVN0CqTk53YhAdKVakuP4f/5TKVb/TtNyi1JXAgIYGB2K23tAA= X-Google-Smtp-Source: AGHT+IHykvB/+tVzUX2j/nsmsWYciJgYvbhQSmiDYoaGzTUaeOfEnMinypkoyN9q7gjm8BukjHS7aw== X-Received: by 2002:a05:6402:2356:b0:64d:4f75:aa28 with SMTP id 4fb4d7f45d1cf-64d4f75adb0mr11287635a12.18.1766589870379; Wed, 24 Dec 2025 07:24:30 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Pierrick Bouvier , Peter Xu , Richard Henderson , Manos Pitsidianakis , Anton Johansson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Hildenbrand Subject: [PATCH v3 14/25] system/memory: Use explicit endianness in ram_device::read/write() Date: Wed, 24 Dec 2025 16:21:57 +0100 Message-ID: <20251224152210.87880-15-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224152210.87880-1-philmd@linaro.org> References: <20251224152210.87880-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::529; envelope-from=philmd@linaro.org; helo=mail-ed1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766589906165158501 Replace the ldn_he_p/stn_he_p() calls by their explicit endianness variants. Duplicate the MemoryRegionOps, using one entry for BIG and another for LITTLE endianness. Select the proper MemoryRegionOps in memory_region_init_ram_device_ptr(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- system/memory.c | 68 ++++++++++++++++++++++++++++++++++--------------- 1 file changed, 48 insertions(+), 20 deletions(-) diff --git a/system/memory.c b/system/memory.c index 8b84661ae36..5bcdeaf0bee 100644 --- a/system/memory.c +++ b/system/memory.c @@ -1361,41 +1361,69 @@ const MemoryRegionOps unassigned_mem_ops =3D { .endianness =3D DEVICE_NATIVE_ENDIAN, }; =20 -static uint64_t memory_region_ram_device_read(void *opaque, - hwaddr addr, unsigned size) +static uint64_t memory_region_ram_device_read_le(void *opaque, + hwaddr addr, unsigned siz= e) { MemoryRegion *mr =3D opaque; - uint64_t data =3D ldn_he_p(mr->ram_block->host + addr, size); + uint64_t data =3D ldn_le_p(mr->ram_block->host + addr, size); =20 trace_memory_region_ram_device_read(get_cpu_index(), mr, addr, data, s= ize); =20 return data; } =20 -static void memory_region_ram_device_write(void *opaque, hwaddr addr, - uint64_t data, unsigned size) +static uint64_t memory_region_ram_device_read_be(void *opaque, + hwaddr addr, unsigned siz= e) +{ + MemoryRegion *mr =3D opaque; + uint64_t data =3D ldn_be_p(mr->ram_block->host + addr, size); + + trace_memory_region_ram_device_read(get_cpu_index(), mr, addr, data, s= ize); + + return data; +} + +static void memory_region_ram_device_write_le(void *opaque, hwaddr addr, + uint64_t data, unsigned size) { MemoryRegion *mr =3D opaque; =20 trace_memory_region_ram_device_write(get_cpu_index(), mr, addr, data, = size); =20 - stn_he_p(mr->ram_block->host + addr, size, data); + stn_le_p(mr->ram_block->host + addr, size, data); } =20 -static const MemoryRegionOps ram_device_mem_ops =3D { - .read =3D memory_region_ram_device_read, - .write =3D memory_region_ram_device_write, - .endianness =3D HOST_BIG_ENDIAN ? DEVICE_BIG_ENDIAN : DEVICE_LITTLE_EN= DIAN, - .valid =3D { - .min_access_size =3D 1, - .max_access_size =3D 8, - .unaligned =3D true, - }, - .impl =3D { - .min_access_size =3D 1, - .max_access_size =3D 8, - .unaligned =3D true, +static void memory_region_ram_device_write_be(void *opaque, hwaddr addr, + uint64_t data, unsigned size) +{ + MemoryRegion *mr =3D opaque; + + trace_memory_region_ram_device_write(get_cpu_index(), mr, addr, data, = size); + + stn_be_p(mr->ram_block->host + addr, size, data); +} + +static const MemoryRegionOps ram_device_mem_ops[2] =3D { + [0 ... 1] =3D { + .valid =3D { + .min_access_size =3D 1, + .max_access_size =3D 8, + .unaligned =3D true, + }, + .impl =3D { + .min_access_size =3D 1, + .max_access_size =3D 8, + .unaligned =3D true, + }, }, + + [0].endianness =3D DEVICE_LITTLE_ENDIAN, + [0].read =3D memory_region_ram_device_read_le, + [0].write =3D memory_region_ram_device_write_le, + + [1].endianness =3D DEVICE_BIG_ENDIAN, + [1].read =3D memory_region_ram_device_read_be, + [1].write =3D memory_region_ram_device_write_be, }; =20 bool memory_region_access_valid(MemoryRegion *mr, @@ -1712,7 +1740,7 @@ void memory_region_init_ram_device_ptr(MemoryRegion *= mr, mr->ram =3D true; mr->terminates =3D true; mr->ram_device =3D true; - mr->ops =3D &ram_device_mem_ops; + mr->ops =3D &ram_device_mem_ops[HOST_BIG_ENDIAN]; mr->opaque =3D mr; mr->destructor =3D memory_region_destructor_ram; =20 --=20 2.52.0