From nobody Mon Feb 9 05:13:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766589341; cv=none; d=zohomail.com; s=zohoarc; b=F0Lcdfl+QsZqywOvYcENahzBayoTb/6rlEcO+oPkTbdE8qTx42+wL3X4CwqFipBc2d8QDapif1v5feXq3Zd4poJqJ2mY38uf0SlReg18U6nyWRgorz+jW2/jbpbIeLjFZJ5XOTzX7wpORGz71zCbQnOz0WgEu/HsxVZ3H8xv/SE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766589341; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NQzy0dLdaSF6COAicvlR6PVbfYgMujeHrja50VAAj50=; b=hPTaynPmXLnMusG5BvqqMcpaOEB18VqzAgrCc5g6Ft/i87iQcNy35zbtTRhMISqqHhAkZtDPNAjjnpGtZCyazwk8EyztKFhWmRJwMwnd/Qfcox6ow7IKzbKNWn2TFTACYjG/oy5MrfzrXNEEafvPxozJ6M14gCYOIEF42hoet1w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766589341680627.3189029145266; Wed, 24 Dec 2025 07:15:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYQZ5-00027r-Db; Wed, 24 Dec 2025 10:14:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYQZ4-00026m-KY for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:14:14 -0500 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYQZ1-0002yr-SH for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:14:14 -0500 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-b736d883ac4so1047707566b.2 for ; Wed, 24 Dec 2025 07:14:11 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f09149sm1772261266b.47.2025.12.24.07.14.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 07:14:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766589250; x=1767194050; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NQzy0dLdaSF6COAicvlR6PVbfYgMujeHrja50VAAj50=; b=E2S9SEcbko9BJUpsp/TgaPlG6jiKDpHND7Qh77WGbLTp3CyovdwK91AJ+Acx622J43 3M8muqsSLUpNAO7d9N6aKaXoMXElYJKEDKCWzO3f0WZnXg9hLFw3kYRrXaVW/1Ql+BRJ 8m0t71fCc8TNfW6U1ksDkv1iLNFSUgT0GOYvbeFjsN/1ScGkDqcfpBfq6K3MU9HfQiGS Y7/oWh9YV9ijt33x73qe2hNjMaaUo+/xl+nO9dQy3rdF227tQvfhz+GZjWGJ/yySNB18 fOAAUAR8E28VBfabjF9IhB6VmlICQmH12muBTNhZOUtuUg8Y0iKlDdrKXLYy31aR2TaA kqBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766589250; x=1767194050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NQzy0dLdaSF6COAicvlR6PVbfYgMujeHrja50VAAj50=; b=NkkGwCfvy+UKSJGZAfyXrt+Abj8w+XyfcTNTCmeO74pGMzP24XdaJHZJKktt4wn7m0 P2P/NY9P/ghHEOkgbElPpRoSYdmjpgGe/wq3t706Fesby/VPT0nzT3fdCOL3E5Kwpvz3 PFOvX92ut55OENgMXjbVUD+nzZR19g3wmv2j/AA1rok+8WJEVeZHphmnYWkIupstxSA7 KjQmJwdvAFfZXkcW3H2k2rpapaOajuJaplI5era7NsgyaGBktHU9Lvwo1TYBDR50sA0e Epwazet1qojWlOTl/Z4b1O+b86evOrWKiPNb25EnktTi/ntS2RBPGQITS+lFRzWnNb4R GibA== X-Gm-Message-State: AOJu0Yykh05hmCh6bwPSUbY0cH6qAi13SAS0dw1dPVBDqxZIiaH2J/a9 6EwQ3gvuVdi7VPXqQcBOyRpRrvU3VeMMvq0rNOFgHfPYg9bKyBBHCRyQWf2+kG0fLb+7y2Wd6bW Jdx34i5s= X-Gm-Gg: AY/fxX5WDpOb5w+hRXgr3rJgF4Zc999uMghfX+aXltqE2fkGtJzOpwmtkudT9j+e7D+ OUKhz+XXs492KWH+wfH+AJRalK0azHTRBTDfKyojGQrPMnIEw6FFvVdL9SPU3lvIxCl+jRq+h84 AbyPdA13EKL7g5iTTz7glIEnQ237xTYkwAe2i5Gs3WfWrooauEk1KrLdTEWc0ii0NpUvaDdjmPl QMhswH/6tHaGqHV+el6SvS2Mfd6UkmKhTKNoz4q2JDl+/Gz+5YnR5cqk1Q+h74P496ApOV/8k4O DVGM3b+snq8JXeTdeW2fH6y4bpzEj4EVkCuKOK8q00DMLrfoR6b8ajfzmBO5VdhrXnahR47JWBw KtMoVMGw3chRkzC0xa+AMCikj6Taf2C7uY8VNoBZ/UVPpvXhonD45TytIUrsH1uUH8g8cUD/rmU OPbIftiC6FQwe+TOdWEn/LhDH4RiZ18AnhbiWjrAJXmzv7/VbqzVMK2bo= X-Google-Smtp-Source: AGHT+IG1MXjRhMLVLkvNGpMS1CpLHWaxCRCtClGiZg8AGngYKI/lUOhGKo86qATzFu0tPR4tqcpw1g== X-Received: by 2002:a17:906:30c1:b0:b80:4101:c99 with SMTP id a640c23a62f3a-b8041010d71mr1260480566b.21.1766589249356; Wed, 24 Dec 2025 07:14:09 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Andrew Jeffery , qemu-arm@nongnu.org, Peter Xu , Jiaxun Yang , Weiwei Li , Jamin Lin , Mark Cave-Ayland , "Michael S. Tsirkin" , Pierrick Bouvier , Anton Johansson , David Hildenbrand , qemu-riscv@nongnu.org, Steven Lee , Paolo Bonzini , Daniel Henrique Barboza , Troy Lee , Palmer Dabbelt , Zhao Liu , Liu Zhiwei , Peter Maydell , Artyom Tarasenko , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Alistair Francis , Joel Stanley , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH 1/9] target/i386: Remove x86_stl_phys_notdirty() leftover Date: Wed, 24 Dec 2025 16:13:42 +0100 Message-ID: <20251224151351.86733-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224151351.86733-1-philmd@linaro.org> References: <20251224151351.86733-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=philmd@linaro.org; helo=mail-ej1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766589343696158501 Last use of x86_stl_phys_notdirty() was removed in commit 4a1e9d4d11c ("target/i386: Use atomic operations for pte updates"), let's remove. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu --- target/i386/cpu.h | 1 - target/i386/helper.c | 10 ---------- 2 files changed, 11 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index cee1f692a1c..4c0579a5678 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -2623,7 +2623,6 @@ uint32_t x86_lduw_phys(CPUState *cs, hwaddr addr); uint32_t x86_ldl_phys(CPUState *cs, hwaddr addr); uint64_t x86_ldq_phys(CPUState *cs, hwaddr addr); void x86_stb_phys(CPUState *cs, hwaddr addr, uint8_t val); -void x86_stl_phys_notdirty(CPUState *cs, hwaddr addr, uint32_t val); void x86_stw_phys(CPUState *cs, hwaddr addr, uint32_t val); void x86_stl_phys(CPUState *cs, hwaddr addr, uint32_t val); void x86_stq_phys(CPUState *cs, hwaddr addr, uint64_t val); diff --git a/target/i386/helper.c b/target/i386/helper.c index 72b2e195a31..d14f14e0d4d 100644 --- a/target/i386/helper.c +++ b/target/i386/helper.c @@ -690,16 +690,6 @@ void x86_stb_phys(CPUState *cs, hwaddr addr, uint8_t v= al) address_space_stb(as, addr, val, attrs, NULL); } =20 -void x86_stl_phys_notdirty(CPUState *cs, hwaddr addr, uint32_t val) -{ - X86CPU *cpu =3D X86_CPU(cs); - CPUX86State *env =3D &cpu->env; - MemTxAttrs attrs =3D cpu_get_mem_attrs(env); - AddressSpace *as =3D cpu_addressspace(cs, attrs); - - address_space_stl_notdirty(as, addr, val, attrs, NULL); -} - void x86_stw_phys(CPUState *cs, hwaddr addr, uint32_t val) { X86CPU *cpu =3D X86_CPU(cs); --=20 2.52.0 From nobody Mon Feb 9 05:13:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766589341; cv=none; d=zohomail.com; s=zohoarc; b=LG3v7/uFphUyaGvenzX8X2cITqx0O162ch+Ze6F7Kd/DQQoP4hnuazTYV4U3DGXWd5qiPY0CLNNQXV+yzIBn9SpwsbaisRHS5EcsRFkDbajQP58/aykNjvUcY4fbmWfuk46skAZ9NfXOysp12fmPg1/ABglkpa2t905VV0ixl6o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766589341; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PUlYIf5k+X4CyTKiZX3SNJm39SXnRKIc/98ptlkBn0w=; b=F1f+mlbc3CPJYhJ75+wcUI5AfD+fom3XQ+SIhht9vdntCJ/d89sTzZwBg6r5KZsRtmDbyYgDFCK8jxtuUoid05IS7t3/mb8WWoXh4iCAQ4wbQqAMu7hPAf/MYvT9GWLC9UKnfID2KnzMdwU3o86RVkBnOJ7FAaXPXt17mE97kdM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766589341758102.69621538331262; Wed, 24 Dec 2025 07:15:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYQZn-0002Q4-QD; Wed, 24 Dec 2025 10:15:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYQZF-0002Fx-R7 for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:14:25 -0500 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYQZD-0002zh-A2 for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:14:25 -0500 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-b734fcbf1e3so1199710966b.3 for ; Wed, 24 Dec 2025 07:14:22 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037a614acsm1801230466b.3.2025.12.24.07.14.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 07:14:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766589261; x=1767194061; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PUlYIf5k+X4CyTKiZX3SNJm39SXnRKIc/98ptlkBn0w=; b=FnpR1hK3FFLjgyuU3N4vKKD2CY7hC/8oj+TNtarHlySSz6lY+mkGaY6u8u8tk9VKpz LCLPRfnD4SbU0RFD4gRYHRoAQcpw1pLNZDUxyJWdKce42hAb4T4IhJHUVflQTUm5nnXc BA1/4+Qt9Vs4KO28sIlt1CRrQKCLuivDTL9lbE/Yb2fnzlMrH9NpR79AEbNF8WE7ePTt RoNxgElAw1LXjuc2eyDs2bTt1hfl3IzKg7SNsqgtJSqx5f0uD8qnuKp8pLFAQ6cLlder htwy7wEGRU5liBKBkPuRv3BlZtEfyu/Jc/wu8lgTxMiZOYHAC/jAcOuH1VAJ7W9JSq96 /T6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766589261; x=1767194061; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PUlYIf5k+X4CyTKiZX3SNJm39SXnRKIc/98ptlkBn0w=; b=iqD5alaux7/eY9ho0ngn+Z9sths++kbQzVCDWx5Xfbedb6QdEUYNrW8m6V7Fsy5LpP xGiF1xTJTuliIrZNBu7FQ9a55ihFE3iZOalssIl1ctjY4GDx7GQb8FmIWiLxVvMq1rmH 6LLCUQkc2D87zXFGT6stZqd+LbHGkd1fKj78mTRGeXCCr3/v3/B1JqInu9Or3dBH9Rfp POAQChxzCIiDYpjYibzqzcfv15Vq3bZzxy3nTnz4bHp11ce956/oRAoMirANnh6VIpNX zKLwdextbmArDETNTiOrD/5+8yDC7idWpbF5c82qHo/ZK6y2hY1V/hLedZNDqA79JnFv 3j+g== X-Gm-Message-State: AOJu0Yz7wXdqH79uw6IwMLDiW31FEWOv22yX3cum5FeRPaOwOYxgoH7T 4k+EBWgOrVvV+DUKg1k/rabtJAoqPnq1Im8YtXi5Lq1TersnvrupgGdWldL05pWUcWTGHUk90xM lzgySXZA= X-Gm-Gg: AY/fxX63GAjJ5ETp5Mdxb2L2G8dsdAYEudOSNlQUXBmScdbcAOD0V5VcqR9a1dIGvGV yVje9jIjxZT+OjKvJnh2bGYkk23QzjYphHNc8VSY+xbQ6t5Od+6vBItoIXpdhM75whT3GJDA05S Y+8mJ35v5ieqG6qoZ2mviZACfaZHuAUh8Bi+tHa0EFqZJdLJZXCX2cjevcufJz+qYkVeL7vqu+v WIfCjJgt2NC+8pjAPH2WAch5krMLHrtBzZxDthsxr5Rv12yhPx9DZluG25g4VhQTU7p3OwqVCJH W/39jccURrJcHWeIkaMdxPW8BzlO+D5KPVfInUuSY9Ps0du/0lkxSro0MewnoY/mdbvHvK64A9s qtbOilX/40iBNJ/Epu54Glnl2D2wU8gkh63b0KVwoKDTUcMgRuve4YbbBtNuHVZaNA4wMT7uCXJ PVdnLzNlwwwRUpRCCAz5NxR9SEUgJsf7YiSS3VpydO69FMqyiyrziUb2g= X-Google-Smtp-Source: AGHT+IFJmD60AxObGis4plUd9Q3nrU64xRwX5np768HyiWRbAhvEUFWXoneSECV77wSX9GJelPYf5Q== X-Received: by 2002:a17:906:d553:b0:b83:1433:78de with SMTP id a640c23a62f3a-b8314337b09mr217048166b.12.1766589261418; Wed, 24 Dec 2025 07:14:21 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Andrew Jeffery , qemu-arm@nongnu.org, Peter Xu , Jiaxun Yang , Weiwei Li , Jamin Lin , Mark Cave-Ayland , "Michael S. Tsirkin" , Pierrick Bouvier , Anton Johansson , David Hildenbrand , qemu-riscv@nongnu.org, Steven Lee , Paolo Bonzini , Daniel Henrique Barboza , Troy Lee , Palmer Dabbelt , Zhao Liu , Liu Zhiwei , Peter Maydell , Artyom Tarasenko , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Alistair Francis , Joel Stanley , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH 2/9] target/sparc: Update MMU page table using stl_phys() Date: Wed, 24 Dec 2025 16:13:43 +0100 Message-ID: <20251224151351.86733-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224151351.86733-1-philmd@linaro.org> References: <20251224151351.86733-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=philmd@linaro.org; helo=mail-ej1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766589343679158500 stl_phys_notdirty() is supposed to do an optimized CODE path store. Here we update the page table via the DATA path, so can use the normal stl_phys() helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson --- target/sparc/mmu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sparc/mmu_helper.c b/target/sparc/mmu_helper.c index 217580a4d8c..46bf500ea83 100644 --- a/target/sparc/mmu_helper.c +++ b/target/sparc/mmu_helper.c @@ -189,7 +189,7 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, if (is_dirty) { pde |=3D PG_MODIFIED_MASK; } - stl_phys_notdirty(cs->as, pde_ptr, pde); + stl_phys(cs->as, pde_ptr, pde); } =20 /* the page can be put in the TLB */ --=20 2.52.0 From nobody Mon Feb 9 05:13:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766589368; cv=none; d=zohomail.com; s=zohoarc; b=klJ2DrEScxogg2s4MlRFQfNwFd4DMMlfrOCzOOH3cOoDrxDzdmH7UYk7tZxumzYYTDk5uY1Dg9yMOb/x1MNMvRKWfeyswLrz8xcNMi4bx/W+nllzE/m6T9bBMwTQ4PF9v9ivdRkmtxk/aJUmSe1vD/o/5aNV2mTF6hzndJkwr4Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766589368; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6czcg4YEy9kYV7FGDATJvxic4KWfkb63MhDB1kPUCEg=; b=J2Hnhoof72zNb1/Xv/Kz+Y4sXJMnwncmXYADWgj+v/Z9N+x5+6FiMcCaeqb392O0PB1z4HyW8Lu9hLrzAtKA8a7oBecMtbO/hpeXgX+713fA84G6ELiir9u3L5u7h6Fr7rqp2LVSPJc46cDObzHTISGPyQgy+GTF3vwwmvHUDJc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766589368592937.1707084710022; Wed, 24 Dec 2025 07:16:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYQaG-0002ib-2W; Wed, 24 Dec 2025 10:15:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYQZU-0002P9-8i for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:14:47 -0500 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYQZQ-00032j-5h for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:14:38 -0500 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-64b4b35c812so8195403a12.0 for ; Wed, 24 Dec 2025 07:14:35 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b9159a6d0sm17137152a12.28.2025.12.24.07.14.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 07:14:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766589273; x=1767194073; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6czcg4YEy9kYV7FGDATJvxic4KWfkb63MhDB1kPUCEg=; b=syySrKazDNfLc2fR/wkjT9y/YOqKD8A47xANkpgS3U0ShZ/9cVK+VEAu9WqJBKIzqd 3N5xGOr918zQCKJiD3re3V4sPXHZLsDqhkNyyHk6wmFK2I3yt1Tp0AeOKRa/U0v78E4N OUKprpe+IWBdx9J/cNJCC0dhKnqDagv/i+FZVT+G1pP7Fu19sIRtlMA+Z5ylJo8u9DS3 MekdJueCLXGVLH4MY6WMlPgaRz5m20mGNwz2obVmcGSBm4XeS1qrBVt44OMcx3V4aidd bPW+MGrqPAUH0gewNZgmrpSsqQbeORe8oMPU55XoZn6DvJ4MtaK3PKrpzRfy/zZsHt2x 1MSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766589273; x=1767194073; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6czcg4YEy9kYV7FGDATJvxic4KWfkb63MhDB1kPUCEg=; b=ZLVcerVY0xdDyIBT8GKxocN13oKsZkFxN/8fxkrQ7Rpl6gZQlPBLu42IGPqeVOjY59 VZt5/EiNZzTp0EJ8QBLn/CKroqHKlZw1nL8FWUZUodisv0LQmxkFOYiCfrwnN9uTtnU+ EqoDb6Bv5adu8jyKYm6G+t3mZ26kIt19Y1fycnOT4+bsthOkN2hy8dz/Y77751j5OsSo Y06M7F6p/kwBeY9Kq4V8iZOQhgTnFZdONN9VAnAgW6NHEFM/L+LDFVR07mZcMmHq1iqT ZC5vl9Z9rlHXZGWHAFwpphlooiEVIS2sE03erhGQtDj0abd7vqvNT4yfw22t9NK/0rLu gC4A== X-Gm-Message-State: AOJu0YzOaIEg+wKCSqnXmExg4mWD3lssC1c3LnSGrbRIkYtwld/Dfvpd MaavDOMmSAgSUrXLZmZUf55kOamKNYo7fbp5KoQ7fYFrmT+0ubNlmE5YhUFcQbOXnSQxUxvzgwx wzLm1grs= X-Gm-Gg: AY/fxX5uI04pj+khsLaLOE41exhh5KdLkBy6+MRbmAVZ7XfbagQ3Sn37oWGHMdz9Fwb gz2io/V1J0WJtS9I3rA/JqB5eXCMu4uETfLTbFrrt3VFrUdp65r9PY5Fsv2hByx4jd5K4CoP4ZZ GQzchsBoJZuD8X5X3sBa5niJnpvFqNpinY49BWaOakOMvanBVFyObJo+B+2rUoGhK2Xz/yOwtAS CbBU9v54uySrs0kQ9Xog+4hlmkaVP2cPjmPyJQrEaOT+3YBM4AC4U+pbtv7jLGicLmRFHGpmiAu YhClXMkOrIIHHqyMPkrBSm0CO18gAIXul2awqUJetvUNqUeoWbMgqCODS7M5YaiQ5L0Yji7LFDJ 7tO4oNWvhUIgqr5RM33RTbrBVsXqWPcG0Qi2v/U/Pb2MbLQ8EMXVnrOz9QOHzBVzOpqoJBKvi8N YCFFn7ArkElUt0BQP4cGjXhN7iOZYgydh+3DbQQeDSeW3QFIX6dDlzZJw= X-Google-Smtp-Source: AGHT+IEZ6623R2+01ciEXyPbiMtLcHJfs6LH1TiIh6bn+03hNr67fwVO3Fd1S7EXbLpmsJkizry3ig== X-Received: by 2002:a17:907:6eac:b0:b80:333e:faf6 with SMTP id a640c23a62f3a-b8036f0d7b7mr1994176166b.14.1766589273357; Wed, 24 Dec 2025 07:14:33 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Andrew Jeffery , qemu-arm@nongnu.org, Peter Xu , Jiaxun Yang , Weiwei Li , Jamin Lin , Mark Cave-Ayland , "Michael S. Tsirkin" , Pierrick Bouvier , Anton Johansson , David Hildenbrand , qemu-riscv@nongnu.org, Steven Lee , Paolo Bonzini , Daniel Henrique Barboza , Troy Lee , Palmer Dabbelt , Zhao Liu , Liu Zhiwei , Peter Maydell , Artyom Tarasenko , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Alistair Francis , Joel Stanley , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH 3/9] hw/arm: Avoid address_space_stl_notdirty() when generating bootloader Date: Wed, 24 Dec 2025 16:13:44 +0100 Message-ID: <20251224151351.86733-4-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224151351.86733-1-philmd@linaro.org> References: <20251224151351.86733-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::530; envelope-from=philmd@linaro.org; helo=mail-ed1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766589370197158500 When using the '-kernel' command line option, a bootloader is emitted, calling address_space_stl_notdirty(). The _notdirty() variant is supposed to /not/ mark the updated CODE page as dirty, to not re-translate it. However this code is only used with the '-kernel' CLI option after the machine is created and /before/ the vCPUs run, and *only* during the first (cold) reset; not during following (hot) resets. The optimisation is totally not justified, since we haven't translated any guest code yet. Replace by the normal address_space_stl() helper. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson --- hw/arm/aspeed.c | 4 ++-- hw/arm/boot.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 3a5071a3841..e3cd1519a81 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -77,8 +77,8 @@ static void aspeed_reset_secondary(ARMCPU *cpu, CPUState *cs =3D CPU(cpu); =20 /* info->smp_bootreg_addr */ - address_space_stl_notdirty(as, AST_SMP_MBOX_FIELD_GOSIGN, 0, - MEMTXATTRS_UNSPECIFIED, NULL); + address_space_stl(as, AST_SMP_MBOX_FIELD_GOSIGN, 0, + MEMTXATTRS_UNSPECIFIED, NULL); cpu_set_pc(cs, info->smp_loader_start); } =20 diff --git a/hw/arm/boot.c b/hw/arm/boot.c index b91660208f5..de22b8adf56 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -266,8 +266,8 @@ static void default_reset_secondary(ARMCPU *cpu, AddressSpace *as =3D arm_boot_address_space(cpu, info); CPUState *cs =3D CPU(cpu); =20 - address_space_stl_notdirty(as, info->smp_bootreg_addr, - 0, MEMTXATTRS_UNSPECIFIED, NULL); + address_space_stl(as, info->smp_bootreg_addr, + 0, MEMTXATTRS_UNSPECIFIED, NULL); cpu_set_pc(cs, info->smp_loader_start); } =20 @@ -277,8 +277,8 @@ static inline bool have_dtb(const struct arm_boot_info = *info) } =20 #define WRITE_WORD(p, value) do { \ - address_space_stl_notdirty(as, p, value, \ - MEMTXATTRS_UNSPECIFIED, NULL); \ + address_space_stl(as, p, value, \ + MEMTXATTRS_UNSPECIFIED, NULL); \ p +=3D 4; \ } while (0) =20 --=20 2.52.0 From nobody Mon Feb 9 05:13:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766589382; cv=none; d=zohomail.com; s=zohoarc; b=Nixy8pyqh554J9EuxrY+7l3SJft0tuC8A2YTyiAFzbEx+CHnz+ILNdUl5FcvZqZNsQHJPa6m0QrMflKZKBcoHzRIbD0tPjIN9lyG6wuyGyyFYw+4M0oXHb08zv4sZu6Qtatqhz7SaH8j5xrmTfyS3MhymKmWvWsQYX+rse3oZvQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766589382; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=B1b6x18riFiHnFkkcqn+CtPN4j8BBN9191Tesnu/1k0=; b=hyGL1LkN5eAMSsESxPT75juASzM9Oa2OXP75uQ2y9YqLxee5vhemYXMWoKNcwLQfo1adAvS4I5b+hDyKRWTq6gO359GD6UtyR8zHdcJRxOEEwRmuYvKTrAAqUhEwABQny6D67y7+Sq/E8hF/5OYOH6U7dQM/8gHJHvaSWOqr0Pg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766589382312648.5496500966539; Wed, 24 Dec 2025 07:16:22 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYQak-0003pE-1C; Wed, 24 Dec 2025 10:15:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYQZc-0002Pp-HS for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:14:53 -0500 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYQZZ-00033x-4E for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:14:46 -0500 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-64bea6c5819so6260199a12.3 for ; Wed, 24 Dec 2025 07:14:44 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8080e2177csm782017566b.68.2025.12.24.07.14.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 07:14:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766589283; x=1767194083; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B1b6x18riFiHnFkkcqn+CtPN4j8BBN9191Tesnu/1k0=; b=spiv030viaOWA6OU7NT5FMY9cfOHxzGiyYsqM6HS/MrDgkUyKWHVm9HxVodg0m2Xm1 Z6zJOTKboOmT01s+izUb7CmXi+1rCeBiy2pfnVt/soR43I+sES+O0oEYcgug5aDZMK35 DHVvVSzj6YE0ImVwI5Di3bQQLC/6KNIJyRloMxCEAMioTyN9/kr3DsT2Ry4XvKIr5O1k S+o9VYR+bl0MFlb0QAvqNDESYS4Mqnqmtm7+X7n695cuLCYjs/aY/y1TUlk/A7fQGdZJ qddpJXTcq9WrMDd7Ke+6N3bfdVkPOjaeEeZJGMsE+88QEkj5EsBUv6l/vDzF7GVRAT3l 9YZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766589283; x=1767194083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=B1b6x18riFiHnFkkcqn+CtPN4j8BBN9191Tesnu/1k0=; b=YkrRZsn8Lgsbwn7Y+e6t1aLwxStuc88JY2JmOVBv+9m68heWBQwtbrjA5UNmWr3TN4 IfFILyum0EqNFpv1lDsvPg3Hih8SD9lhOUl+ubKcgA6NS/HXbC72Nu+iclSWy9dGssen RgvjB4ciFAxEq6anaITLIOMNKBzkTvkj6+Jf70xjKT3pqOoE7bjOeS/buZZWwWcMJ9w2 lOwZgYZ0PG4k8bLVY43TkGZpPVigUZIbfOf8d19G0AOab0ct/XFE3d9+AxZobg/vxJdB kL83/FKx3iy9j/VEOrZld+BcowjAcMJiYuyrYtlIQzBhgP0oC4ztrQIE308fYc53t3N+ w0xw== X-Gm-Message-State: AOJu0Yxw6d2zODMHC+SO3caVF2YLKvtBkhrZ+QlBgqmeKXQrwRu7sFmT AuKwF6l9V8x5RCApirSaIXQQdYcCvBXuQqGqvREgtQOSvIZ1c8K4tdFxePechE3Q1bu+6Y3co0B BLCPn/qE= X-Gm-Gg: AY/fxX7lQOQEqbqFb91t4EafEPcFBLutTHwEt7rfL9C1ggP3JhGuTxzcw8iuFxVJut/ tBCD0Q8a9TXKxpW/YEVtqssm8mUrsvT+tl7EkjnxhvefBT/o/HYAtfUIneGXF9+eY8xhR546FkL 47GWhHBCTBA3NtcNa3QCh0vSsi0LF+j22OBZu2lzd0zfdwPik0t23FeV6apIuqbNj/mtVXrnV68 0wFhqMmb610t7IZfOKfi2kgSmlW1qOtt2K8J+kHD8mBuekwB2e5qbjmMHzuZ4osNARYUKUxpgFA 69lJ4Zh6ZR7rpS7CMYXkAcfRDdT20ATxToGYvUra8duJTpPBBE2hA30PLY95Of5qAMEJqPFIFe6 /rjfgJ87K19nmKtk+mII1rJMtiT2kDfR36moYOqruWiY/pWIa/R5VawiWmtW9KOAw6KcD8wc/Zn O+GrlZfNWncIHFAR9mcFSDqq44eQUSpIJHHy3idgTBkKh0YsA67b4OwDU= X-Google-Smtp-Source: AGHT+IGTA1F9pGUvnOxUvBAxEuM5CajhpP2d4b0KJNCfBuEsjq+HRDLQvm8HHAx9wQXKy+k4QHriRw== X-Received: by 2002:a17:906:c109:b0:b80:325d:99e2 with SMTP id a640c23a62f3a-b803705ddb6mr1961657066b.33.1766589283089; Wed, 24 Dec 2025 07:14:43 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Andrew Jeffery , qemu-arm@nongnu.org, Peter Xu , Jiaxun Yang , Weiwei Li , Jamin Lin , Mark Cave-Ayland , "Michael S. Tsirkin" , Pierrick Bouvier , Anton Johansson , David Hildenbrand , qemu-riscv@nongnu.org, Steven Lee , Paolo Bonzini , Daniel Henrique Barboza , Troy Lee , Palmer Dabbelt , Zhao Liu , Liu Zhiwei , Peter Maydell , Artyom Tarasenko , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Alistair Francis , Joel Stanley , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH 4/9] system/memory: Remove address_space_stl_notdirty and stl_phys_notdirty Date: Wed, 24 Dec 2025 16:13:45 +0100 Message-ID: <20251224151351.86733-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224151351.86733-1-philmd@linaro.org> References: <20251224151351.86733-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=philmd@linaro.org; helo=mail-ed1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766589384280158500 stl_phys_notdirty() was added in commit 8df1cd076cc ("physical memory access functions") as a (premature?) optimisation for the CODE path. Meanwhile 20 years passed, we might never have understood / used it properly; the code evolved and now the recommended way to access the CODE path is via the cpu_ld/st_mmu*() API. Remove both address_space_stl_notdirty() and stl_phys_notdirty() leftovers. Suggested-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson --- include/system/memory.h | 6 ------ include/exec/memory_ldst.h.inc | 2 -- system/memory_ldst.c.inc | 39 ---------------------------------- 3 files changed, 47 deletions(-) diff --git a/include/system/memory.h b/include/system/memory.h index 3bd5ffa5e0d..e69171de05a 100644 --- a/include/system/memory.h +++ b/include/system/memory.h @@ -2850,12 +2850,6 @@ MemTxResult address_space_write_rom(AddressSpace *as= , hwaddr addr, #define ARG1_DECL AddressSpace *as #include "exec/memory_ldst.h.inc" =20 -static inline void stl_phys_notdirty(AddressSpace *as, hwaddr addr, uint32= _t val) -{ - address_space_stl_notdirty(as, addr, val, - MEMTXATTRS_UNSPECIFIED, NULL); -} - #define SUFFIX #define ARG1 as #define ARG1_DECL AddressSpace *as diff --git a/include/exec/memory_ldst.h.inc b/include/exec/memory_ldst.h.inc index 7270235c600..173164fee3a 100644 --- a/include/exec/memory_ldst.h.inc +++ b/include/exec/memory_ldst.h.inc @@ -25,8 +25,6 @@ uint32_t glue(address_space_ldl, SUFFIX)(ARG1_DECL, hwaddr addr, MemTxAttrs attrs, MemTxResult *result); uint64_t glue(address_space_ldq, SUFFIX)(ARG1_DECL, hwaddr addr, MemTxAttrs attrs, MemTxResult *result); -void glue(address_space_stl_notdirty, SUFFIX)(ARG1_DECL, - hwaddr addr, uint32_t val, MemTxAttrs attrs, MemTxResult *result); void glue(address_space_stw, SUFFIX)(ARG1_DECL, hwaddr addr, uint16_t val, MemTxAttrs attrs, MemTxResult *result); void glue(address_space_stl, SUFFIX)(ARG1_DECL, diff --git a/system/memory_ldst.c.inc b/system/memory_ldst.c.inc index 333da209d1a..b45bfecd137 100644 --- a/system/memory_ldst.c.inc +++ b/system/memory_ldst.c.inc @@ -261,45 +261,6 @@ uint16_t glue(address_space_lduw_be, SUFFIX)(ARG1_DECL, DEVICE_BIG_ENDIAN); } =20 -/* warning: addr must be aligned. The ram page is not masked as dirty - and the code inside is not invalidated. It is useful if the dirty - bits are used to track modified PTEs */ -void glue(address_space_stl_notdirty, SUFFIX)(ARG1_DECL, - hwaddr addr, uint32_t val, MemTxAttrs attrs, MemTxResult *result) -{ - uint8_t *ptr; - MemoryRegion *mr; - hwaddr l =3D 4; - hwaddr addr1; - MemTxResult r; - uint8_t dirty_log_mask; - bool release_lock =3D false; - - RCU_READ_LOCK(); - mr =3D TRANSLATE(addr, &addr1, &l, true, attrs); - if (l < 4 || !memory_access_is_direct(mr, true, attrs)) { - release_lock |=3D prepare_mmio_access(mr); - - r =3D memory_region_dispatch_write(mr, addr1, val, MO_32, attrs); - } else { - ptr =3D qemu_map_ram_ptr(mr->ram_block, addr1); - stl_p(ptr, val); - - dirty_log_mask =3D memory_region_get_dirty_log_mask(mr); - dirty_log_mask &=3D ~(1 << DIRTY_MEMORY_CODE); - physical_memory_set_dirty_range(memory_region_get_ram_addr(mr) + a= ddr, - 4, dirty_log_mask); - r =3D MEMTX_OK; - } - if (result) { - *result =3D r; - } - if (release_lock) { - bql_unlock(); - } - RCU_READ_UNLOCK(); -} - /* warning: addr must be aligned */ static inline void glue(address_space_stl_internal, SUFFIX)(ARG1_DECL, hwaddr addr, uint32_t val, MemTxAttrs attrs, --=20 2.52.0 From nobody Mon Feb 9 05:13:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766589384; cv=none; d=zohomail.com; s=zohoarc; b=dS+9c80hrt+PNrLoO409puw+AqOxYKxxNZqaitc9KixwLqJJe6+oNSlWsh0TKmejiNLDCum7mdFVHbbZQ/ayrXdYpdapSTwUKSlhlocBmaYTW2PUN5/sYfWq9RuyoWuUrtyRvB+9iyUo8D56yQNm9IgAASWrIXuWrRVaO+nbOOY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766589384; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qSSsRmh/IQkwpJa4M1tD2tu2lq9WIQnOoGphHntAkAQ=; b=doRlTbl8Fmw1MShX+loGMAtV/J8ef2xyXFRsZy/WzvzG88cH+No5XwkxzzhwDYAVlxn49MlogwZAFsOFNhbnXDY5HhRcoNjx4K5xXpZwyioDmikPh8/ouCGDI4ZxXjmFsCbDLzZ6PCluyxJJidsuOmMsy6m6GYDMGrIgbLTMY6I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766589384338220.9864178244694; Wed, 24 Dec 2025 07:16:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYQae-0003TA-O9; Wed, 24 Dec 2025 10:15:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYQZn-0002Ul-H5 for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:14:59 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYQZl-00035A-2b for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:14:59 -0500 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-42fb2314eb0so4447863f8f.2 for ; Wed, 24 Dec 2025 07:14:56 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1b1b1sm34391670f8f.3.2025.12.24.07.14.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 07:14:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766589295; x=1767194095; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qSSsRmh/IQkwpJa4M1tD2tu2lq9WIQnOoGphHntAkAQ=; b=WJ21aNVgDuJSSp3q7jCAHeYA1Er2OP3ix0rNLaORUL7TaWq9DHmYCXYCNVE2Fn51Lm 7qYvlo3dpfjg9n3SfX8jHqsO7L4zKASc8I+n/oLRXgd9Rld8caIargmZYkx+AignFmBF 4bUYRXWvpjjTMuBgRmDDW6zQw9GiBkSc5cc1tt49jlfGC9ZrotDFpah4r97v5naWxYw2 Icg10AQpybSyVMgOJgq25lClJEPzd8vyxEwJAm3l6Jh5dKs12uTQsNHdEQCbLn1OLNVb 2bzyfUs04iYSS/NZHEB7egNnwPJtJHs6zrffXaDnh5a5OGffIR89gJF/19PgGqJABt+v bPBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766589295; x=1767194095; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qSSsRmh/IQkwpJa4M1tD2tu2lq9WIQnOoGphHntAkAQ=; b=cfG3fv4bVfEDPuCOyMiS5DX/vgMhRL7+2V96uAu5htliZeFE8OGjx/GdEXudD5dzLd eov/xW2e7qZf6Vl5IoqP+dYUADGJLu3oLfa3V93UQBNQMxrka0u7gILzy8EHF5zkEARu hf3d/ton5mL+6O8Ldr4R+uLljdCSjQMrqfxdxz2m/JfLAWNDYfNoJQvXbWLCXTP3UWmT ZVuLnLswdvPj6kdtIFiglaZvB/NoBvGcIcwAqz2qANisvWxpL7YyKiFAfdCcYJZ0kQBQ v5YYGKJpnYK7adfuyLC3PNs3vRtuJRM5wnZO2ScupRzBtz2FqLYgNEg2tqCbz13Zxg/O tvAQ== X-Gm-Message-State: AOJu0Yyt5iyKrWSRKiZbA86m0v2ysL/W86Hde0kXfLYdf1w9EK85gu6o VAt18BHj65EmUQVjlcUaz+dpfAOKx+OpKWD4mhx7yESzvAHZDD/TDfTXxcUGEqhHDZc5t7cRZF3 zZ8bO8/Q= X-Gm-Gg: AY/fxX4f2ydw60aH5/cvLDINuGQeAfYLIFQw+TDhjQP7/Pb6YjIXM2FGkdSiC0VRENt oTr+V3Pana7OyTIHLRO1F1f+a8Nsi4dRKOCglvb30bY22slWp3I73UqbhuNbbbfXkKcbI15MHUS 4zF8edi5dcfQ6KaOBhYfGaNbDhHHtQggl3waYi+Ja03Lj0sLfJyFWu/UIRvXdju/8o3mS41M8Wb JYCk350jb7ZbId5wCChkC76qJLlYIcQ+AfLnkbM1ZR/CseSD6ZKq3khU7gKhX3jI32bbPh5VxPm 7/AIX5eyEDayfxH3Kwjvrkx17LF6dC7p4WKFC+kDIYVFBxT9dD3Sjhm9JfHcHNU3LgzpSWBHPXc 65vt15jXnjKEWPbhQiXfeWVWv4iNPjI4WcIJE0+/tpUWkVPEFO8Sp0vL/PXPcwsOCgTV6fmt1ET u4EVPnXkGZAcBqE8B++EYVIsa/B2M4HifLH1BorccUdD01pz29+p9qax4= X-Google-Smtp-Source: AGHT+IH/1qWHjLejlt1atDrHHy69+lHW4Qc4qS7vIzk9OOR+3COYvxQGXxooLC/KYi/aV2P/u2q0/A== X-Received: by 2002:a05:6000:22c8:b0:42f:f627:3a90 with SMTP id ffacd0b85a97d-4324e4fd938mr21508015f8f.32.1766589294877; Wed, 24 Dec 2025 07:14:54 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Andrew Jeffery , qemu-arm@nongnu.org, Peter Xu , Jiaxun Yang , Weiwei Li , Jamin Lin , Mark Cave-Ayland , "Michael S. Tsirkin" , Pierrick Bouvier , Anton Johansson , David Hildenbrand , qemu-riscv@nongnu.org, Steven Lee , Paolo Bonzini , Daniel Henrique Barboza , Troy Lee , Palmer Dabbelt , Zhao Liu , Liu Zhiwei , Peter Maydell , Artyom Tarasenko , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Alistair Francis , Joel Stanley , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 5/9] system/memory: Allow restricting legacy ldst_phys() API usage Date: Wed, 24 Dec 2025 16:13:46 +0100 Message-ID: <20251224151351.86733-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224151351.86733-1-philmd@linaro.org> References: <20251224151351.86733-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766589386110158500 Commit 500131154d6 ("exec.c: Add new address_space_ld*/st* functions") added a new API to fix a shortcoming of the ld/st*_phys() API, which does blind bus access, not reporting failure (and it also allow to provide transaction attributes). Later commit 42874d3a8c6 ("Switch non-CPU callers from ld/st*_phys to address_space_ld/st*") automatically converted the legacy uses to the new API, not precising transaction attributes (MEMTXATTRS_UNSPECIFIED) and ignoring the transation result (passing NULL pointer as MemTxResult). While this is a faithful replacement, without any logical change, we later realized better is to not use MEMTXATTRS_UNSPECIFIED or NULL MemTxResult, and adapt each call site on a pair basis, looking at the device model datasheet to do the correct behavior (which is unlikely to ignore transaction failures). Since this is quite some work, we defer that to device model maintainers. Meanwhile we introduce a definition, to allow a target which removed all legacy API call to prohibit further legacy API uses, named "TARGET_NOT_USING_LEGACY_LDST_PHYS_API". Since all targets should be able to check this definition, we take care to not poison it. Suggested-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- include/system/memory.h | 2 ++ scripts/make-config-poison.sh | 1 + 2 files changed, 3 insertions(+) diff --git a/include/system/memory.h b/include/system/memory.h index e69171de05a..d5c248f1794 100644 --- a/include/system/memory.h +++ b/include/system/memory.h @@ -2850,10 +2850,12 @@ MemTxResult address_space_write_rom(AddressSpace *a= s, hwaddr addr, #define ARG1_DECL AddressSpace *as #include "exec/memory_ldst.h.inc" =20 +#ifndef TARGET_NOT_USING_LEGACY_LDST_PHYS_API #define SUFFIX #define ARG1 as #define ARG1_DECL AddressSpace *as #include "exec/memory_ldst_phys.h.inc" +#endif =20 struct MemoryRegionCache { uint8_t *ptr; diff --git a/scripts/make-config-poison.sh b/scripts/make-config-poison.sh index 2b36907e239..937357b3531 100755 --- a/scripts/make-config-poison.sh +++ b/scripts/make-config-poison.sh @@ -10,6 +10,7 @@ exec sed -n \ -e' /CONFIG_TCG/d' \ -e '/CONFIG_USER_ONLY/d' \ -e '/CONFIG_SOFTMMU/d' \ + -e '/TARGET_NOT_USING_LEGACY_LDST_PHYS_API/d' \ -e '/^#define / {' \ -e 's///' \ -e 's/ .*//' \ --=20 2.52.0 From nobody Mon Feb 9 05:13:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766589397; cv=none; d=zohomail.com; s=zohoarc; b=JFD14eTVh5vlf2cwBn/UzfCChCnfn3cBcIlHX1B1+BhoApUKRa4AeP4mXSvRHYl8DW+EnQC+hPOUjaqQGr2GTf3etKVkwDrESyMNR1BFNtnRBAJzC+qKVv63SjmMMuMsdzmJl5KINsjT77pUqJT1UI3mqE/qBmZ9M+EfPMNAU/Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766589397; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=29OVqUMLaQsKzXt2ITIZ8V00Bi0PBc0R85gFJ4t8yz0=; b=jQcdxQJ/pMQVOdow51sGVm9xWEQfvl/d09dZ3wcCWp+ixyk03JbfTKJxfIEKojpp91vyj3nnVKRC4Zbo3oamGRZx8UbYtYFiwCzby+0dl2chp91pDTcxOYhpG6oxs0ncRQEe2zuii/oJ9T48krFJz9vTyrewaDSj6DdvW3yZcP0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766589397841654.1192541292943; Wed, 24 Dec 2025 07:16:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYQak-0003tL-FK; Wed, 24 Dec 2025 10:15:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYQZx-0002em-9K for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:15:15 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYQZu-0003HA-EA for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:15:08 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4775ae77516so54534505e9.1 for ; Wed, 24 Dec 2025 07:15:05 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be273f147sm361184265e9.7.2025.12.24.07.15.01 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 07:15:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766589304; x=1767194104; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=29OVqUMLaQsKzXt2ITIZ8V00Bi0PBc0R85gFJ4t8yz0=; b=n/K2oqf781GnI9En1ybZA0nJrnXX5j7xVHgZNEgPcNdUhdoubkJr0XN4NMyT5Wmech dFLkKl6bNt8eNhYrvBf2cVx8qHRLZDPCEAX8pphjQtTx9ot/oZtMELmqVEKGxaBDnSgC V0kFAlNyQ2SPxybflodA63Np1GN4uEqP/jpj5iilq+cJ4L/8VdxFyG+mHdwP6biQl7qh kr+JQg8kSZuFuacbdUo//NOSPMpnR5UEKARBxS0rLuKqUChwEeTYyhgHC2zTK1ZhDk6F TwbzHUO9SJFsPPwoZCuqQhVC3D8nqqZY37pf8YbS7/4SEj59KRK1qf3Ts5+lRHmi64lB Zz1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766589304; x=1767194104; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=29OVqUMLaQsKzXt2ITIZ8V00Bi0PBc0R85gFJ4t8yz0=; b=Nz9qBsry5CMMGyoiQ4jLNbqbSFuctI4j8s+M2FhpOXHRk/tf50kIWLcbeHoo6ZUqYf 7DBNFMb0JUbaFu7JEaxbjJe86CVZyA5RYFd7acV1r+vguo0uvybQ4GjKMzNo2CxA3jnC ObI0l6RH6vnuzbxOB15Gaywqi4XVifokgdYOVPZLHmxIlEb0K1X7S7Y6uOYhvYg8025U JCv+Mf1NhdKmtuIdR6Qbv07kg92//IS138bvgKBBvZjit90474xb84Rm2cKUMsZVAucl QBHKkzl+HmO8ZjRG3UbArRcQPpMw56+vU56SzDeuii8qKeyOD9v4V5673ju5tS8wIWIz bhvw== X-Gm-Message-State: AOJu0YxXp4JXpnJxm8DCfwbwejVKsb/ENZpXkz3uIHcrlYVYqs75qgag /dVbG7l/r4QkrlG13B5EVqAf4rS1UHT2k7A1bMl/aJwTpPMJrNtprNSVubTxWaWHnaUn/EdfzR5 ih5fFlYI= X-Gm-Gg: AY/fxX5cj51VITQD5UqRK8gaXdL3T0WXMF39VD6m3s8vsJ3ycbnGS2Or3DEPJs6nlpm 07gD51XhP0ZIU180C8v8QGgZ0V9aWhfTjsAEpTkA+Debb36kI5rHlN7UnjVerDZ/E7momb3UmDl J5aDon4v+tCsc+psJKfODSmGhmbVWuUZwf71OipiW7Qnytj4x/hR/oFjdv3GmQrT6/ykkIutTpG Kqc4572GVadCaW7IZFFZcUt8KiO3IqeJdZrV9X9qXlvi7XvsY9DjN6PZ03ITn//0O4rXGow8Bwx 9cAAOzPrEMjwDxdStNVIAiksjRz1qEUW9lCdffCyI5r/KcC/F7b5H2IwFRqFGChgC8aHakvuhd0 eAQha7GlAG0ukmfjG0XecuRCR8dF2+r+gfe8HMs0eX+NyeyBcKzQw3vu8JXptJXgkwZORPGENeZ hJV4lK+QUxbPTy7h9bntSVSHT8WTCzpJ9zTcUUJFpfmO2tV4qBWYkWd8k= X-Google-Smtp-Source: AGHT+IE6dxLRujWp4AZgsTWnQKJqg9gYGPiqWzsT4Gjmdxf55S4jKIE38CsLQMbJdU+x/ILiNgp65w== X-Received: by 2002:a05:600d:115:b0:46e:37fe:f0e6 with SMTP id 5b1f17b1804b1-47d1997e733mr124968935e9.30.1766589304458; Wed, 24 Dec 2025 07:15:04 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Andrew Jeffery , qemu-arm@nongnu.org, Peter Xu , Jiaxun Yang , Weiwei Li , Jamin Lin , Mark Cave-Ayland , "Michael S. Tsirkin" , Pierrick Bouvier , Anton Johansson , David Hildenbrand , qemu-riscv@nongnu.org, Steven Lee , Paolo Bonzini , Daniel Henrique Barboza , Troy Lee , Palmer Dabbelt , Zhao Liu , Liu Zhiwei , Peter Maydell , Artyom Tarasenko , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Alistair Francis , Joel Stanley , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 6/9] configs/targets: Mark targets not using legacy ldst_phys() API Date: Wed, 24 Dec 2025 16:13:47 +0100 Message-ID: <20251224151351.86733-7-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224151351.86733-1-philmd@linaro.org> References: <20251224151351.86733-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766589400147158500 Luckily these targets don't use the legacy ldst_phys() API at all. Set the TARGET_NOT_USING_LEGACY_LDST_PHYS_API variable to hide the API to them, avoiding further API uses to creep in. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- configs/targets/avr-softmmu.mak | 1 + configs/targets/microblaze-softmmu.mak | 1 + configs/targets/microblazeel-softmmu.mak | 1 + configs/targets/rx-softmmu.mak | 1 + configs/targets/tricore-softmmu.mak | 1 + 5 files changed, 5 insertions(+) diff --git a/configs/targets/avr-softmmu.mak b/configs/targets/avr-softmmu.= mak index b6157fc465d..baf20fb7f2f 100644 --- a/configs/targets/avr-softmmu.mak +++ b/configs/targets/avr-softmmu.mak @@ -1,3 +1,4 @@ TARGET_ARCH=3Davr TARGET_XML_FILES=3D gdb-xml/avr-cpu.xml TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/microblaze-softmmu.mak b/configs/targets/micro= blaze-softmmu.mak index bab7b498c24..cf635798c90 100644 --- a/configs/targets/microblaze-softmmu.mak +++ b/configs/targets/microblaze-softmmu.mak @@ -4,3 +4,4 @@ TARGET_BIG_ENDIAN=3Dy TARGET_NEED_FDT=3Dy TARGET_XML_FILES=3Dgdb-xml/microblaze-core.xml gdb-xml/microblaze-stack-pr= otect.xml TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/microblazeel-softmmu.mak b/configs/targets/mic= roblazeel-softmmu.mak index 8aee7ebc5cf..52feb957b48 100644 --- a/configs/targets/microblazeel-softmmu.mak +++ b/configs/targets/microblazeel-softmmu.mak @@ -3,3 +3,4 @@ TARGET_ARCH=3Dmicroblaze TARGET_NEED_FDT=3Dy TARGET_XML_FILES=3Dgdb-xml/microblaze-core.xml gdb-xml/microblaze-stack-pr= otect.xml TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/rx-softmmu.mak b/configs/targets/rx-softmmu.mak index 1c250a6450d..3a90f1b9977 100644 --- a/configs/targets/rx-softmmu.mak +++ b/configs/targets/rx-softmmu.mak @@ -3,3 +3,4 @@ TARGET_XML_FILES=3D gdb-xml/rx-core.xml # all boards require libfdt TARGET_NEED_FDT=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/tricore-softmmu.mak b/configs/targets/tricore-= softmmu.mak index 781ce49a62f..5e018d81068 100644 --- a/configs/targets/tricore-softmmu.mak +++ b/configs/targets/tricore-softmmu.mak @@ -1,2 +1,3 @@ TARGET_ARCH=3Dtricore TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy --=20 2.52.0 From nobody Mon Feb 9 05:13:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766589400; cv=none; d=zohomail.com; s=zohoarc; b=GGfOiTNcMDasFGb0Ht/dgatB1KlZxrHRM3/89zQHDGLcWqWsv+Ny8Fc+K0Zt6behW9Ari/Z8J25JTCxUvF2+mXp0W3vMcfqquK5nVkzI/xA1eTzGzRo+D5TW2fLLOcG7mKry4FaroqBlAvTywScgJE30sfKgcmxp2p8w+gMCIzY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766589400; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ph2pmdjoZr/k/2utUkSFXBLpUcN9Mg0Sl+yl3bcGaD8=; b=YsuUZHsflkyqZaUmpmNerfWHB0x4AgfJxchbxlRHq294bMsorv9X9H9UDHBVeEjZtjZWOJ4FQwjD7ufEd7FY1KNSKRfKpejL2t7XD+no9xAVLdSuIsmwshRD2sLzEayxfzFNCkGT4moh+W9/5SsyLnOOiVejiyRNOP7hKTPtreQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176658940092891.07324613846231; Wed, 24 Dec 2025 07:16:40 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYQal-00043k-Jm; Wed, 24 Dec 2025 10:15:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYQaA-0002q3-Kg for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:15:26 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYQa6-0003Ih-9f for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:15:20 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-47a8195e515so40069755e9.0 for ; Wed, 24 Dec 2025 07:15:15 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d19362345sm298439715e9.6.2025.12.24.07.15.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 07:15:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766589314; x=1767194114; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ph2pmdjoZr/k/2utUkSFXBLpUcN9Mg0Sl+yl3bcGaD8=; b=t7vCJH4hzNuEGKyyI6H7E0Hrluu3Csjr5bfLCAnebiFtT74k2ChIiK3bql0JgvpNXm ZhV5MQjhAH06GtMx4YlniY+SLDrAljQG4AnloX3h5h/DFToH6T2F7MudVGkoiIANpjeO GS9HyvbyT4jPcQLxCmEshmETWgMUMLrtvcAiHZ+H8g+2jm63rw7BzCBgZI2j3ynMp5EJ v/cZ6fN+NKEETbMDSMVsANNw8mdzg8XWnTBwEcFM44L/aDrOc93jGff6+9InV008lMgh NDTsnvrwIFEJ0IFaeCjmhNKnmDAKjp4zvFvtJOzIm1zjYTGw57U5TpAJAk8CebQkyEc0 MfSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766589314; x=1767194114; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ph2pmdjoZr/k/2utUkSFXBLpUcN9Mg0Sl+yl3bcGaD8=; b=YcD2vus7hjH8NdZZYgQzPabR+8x1Hl8v2YIgJWMfKEqr7jtr5KIbY/XUOGrY0fziOC Ufp7f6Pvs6vE1DNiia0/8TjYPMRIp+uMHr3i/leasUAPjAT1K34FpoI4Hz11AhVoPgEV J6goPh65nR0gIniHkSZIuHXdMwEw2w9P9luGtwpXqdyYUog6XfoCblj+ZhHEmprLqGXy AmIIJEVrBbe9QBRXqy3IpjjqnSgNksGsPSJQxQVf5HS3YvTCwQZ7SDH02TTkZYq1yLe/ T1BiYoOEBtzwmMRCcaKeIGvdsNE7zYUiK2jBdmnHlN8wKZMleVnI9JP40lIQYs1BZL7M MJiw== X-Gm-Message-State: AOJu0YyeGSUm8Gg0mqCr4rxnuQxhrqHjR7cINyfR//dc0bN8na3uISek vrGOv4nzvPci9vM2XLAlzYQBdRaiT4LXt688Jb85qW6kbm+LCiQC+WVdHwa25tN3KmqM0Khp6Ss xTA07OYI= X-Gm-Gg: AY/fxX6NwNWfEiUGIvHT5QuYN9RPcuRm/MVOYVLyrL8nMSNnh2hd+1+tk28oTv2QBF6 bVHfbWiV5udxSZ6Mxdvugnn0wBfu5+egrJmsqZtQWANxoFbPkwm620KMjvzPCgOlGBXyrW2+TkT nYPwMyN/T25ggpZgGpFqTH3qB1XzeWS1aZpd/0rT51culEeDUnGfjkooOF/H+8rtswJ9PLD4KxZ HjmSMgOsYDhkj6k1B9CkEsBEmU1G+y4JqRVXrdpgcr6tDQVK1qblBT+mzws1/N9wpa3fpIzy8Vw t0Zo0JAhsbB/gNW47lEK3VggnM/SRYXmG9jbfUZU1mR8DV97kGxisUD1ofXtwILRUYGGR+jItBk Eu8XuFwfaVYdxzEGmM+kPZGbaTGQMOQmePExYuq4imnYSoqqTg0nH/UXRjHTYxwFQKbcoO3Xhjm BgWbdzoAyrJld7dZaZGzJ9xHroAgLwD8jox6rU+NQSp8Mp+sCooiCvb58= X-Google-Smtp-Source: AGHT+IFScwoxBCRqkTeXaQCsqQxt7KS6o7llklEBeQ0REgEuL7FRa07r2QGkzCL9a3oZPernIGWBSw== X-Received: by 2002:a05:600c:4e0d:b0:46e:48fd:a1a9 with SMTP id 5b1f17b1804b1-47d1959d2b4mr168685985e9.33.1766589313650; Wed, 24 Dec 2025 07:15:13 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Andrew Jeffery , qemu-arm@nongnu.org, Peter Xu , Jiaxun Yang , Weiwei Li , Jamin Lin , Mark Cave-Ayland , "Michael S. Tsirkin" , Pierrick Bouvier , Anton Johansson , David Hildenbrand , qemu-riscv@nongnu.org, Steven Lee , Paolo Bonzini , Daniel Henrique Barboza , Troy Lee , Palmer Dabbelt , Zhao Liu , Liu Zhiwei , Peter Maydell , Artyom Tarasenko , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Alistair Francis , Joel Stanley , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 7/9] hw/virtio: Remove unused ldst_phys() helpers Date: Wed, 24 Dec 2025 16:13:48 +0100 Message-ID: <20251224151351.86733-8-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224151351.86733-1-philmd@linaro.org> References: <20251224151351.86733-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766589402491158500 None of the following virtio ldst_phys() inlined helpers are used: - virtio_lduw_phys() - virtio_ldl_phys[_cached]() - virtio_ldq_phys[_cached]() - virtio_stw_phys() - virtio_stl_phys[_cached]() Just remove them. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- include/hw/virtio/virtio-access.h | 85 ------------------------------- 1 file changed, 85 deletions(-) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-a= ccess.h index 07aae69042a..c866769cad8 100644 --- a/include/hw/virtio/virtio-access.h +++ b/include/hw/virtio/virtio-access.h @@ -39,60 +39,6 @@ static inline bool virtio_access_is_big_endian(VirtIODev= ice *vdev) #endif } =20 -static inline uint16_t virtio_lduw_phys(VirtIODevice *vdev, hwaddr pa) -{ - AddressSpace *dma_as =3D vdev->dma_as; - - if (virtio_access_is_big_endian(vdev)) { - return lduw_be_phys(dma_as, pa); - } - return lduw_le_phys(dma_as, pa); -} - -static inline uint32_t virtio_ldl_phys(VirtIODevice *vdev, hwaddr pa) -{ - AddressSpace *dma_as =3D vdev->dma_as; - - if (virtio_access_is_big_endian(vdev)) { - return ldl_be_phys(dma_as, pa); - } - return ldl_le_phys(dma_as, pa); -} - -static inline uint64_t virtio_ldq_phys(VirtIODevice *vdev, hwaddr pa) -{ - AddressSpace *dma_as =3D vdev->dma_as; - - if (virtio_access_is_big_endian(vdev)) { - return ldq_be_phys(dma_as, pa); - } - return ldq_le_phys(dma_as, pa); -} - -static inline void virtio_stw_phys(VirtIODevice *vdev, hwaddr pa, - uint16_t value) -{ - AddressSpace *dma_as =3D vdev->dma_as; - - if (virtio_access_is_big_endian(vdev)) { - stw_be_phys(dma_as, pa, value); - } else { - stw_le_phys(dma_as, pa, value); - } -} - -static inline void virtio_stl_phys(VirtIODevice *vdev, hwaddr pa, - uint32_t value) -{ - AddressSpace *dma_as =3D vdev->dma_as; - - if (virtio_access_is_big_endian(vdev)) { - stl_be_phys(dma_as, pa, value); - } else { - stl_le_phys(dma_as, pa, value); - } -} - static inline void virtio_stw_p(VirtIODevice *vdev, void *ptr, uint16_t v) { if (virtio_access_is_big_endian(vdev)) { @@ -166,26 +112,6 @@ static inline uint16_t virtio_lduw_phys_cached(VirtIOD= evice *vdev, return lduw_le_phys_cached(cache, pa); } =20 -static inline uint32_t virtio_ldl_phys_cached(VirtIODevice *vdev, - MemoryRegionCache *cache, - hwaddr pa) -{ - if (virtio_access_is_big_endian(vdev)) { - return ldl_be_phys_cached(cache, pa); - } - return ldl_le_phys_cached(cache, pa); -} - -static inline uint64_t virtio_ldq_phys_cached(VirtIODevice *vdev, - MemoryRegionCache *cache, - hwaddr pa) -{ - if (virtio_access_is_big_endian(vdev)) { - return ldq_be_phys_cached(cache, pa); - } - return ldq_le_phys_cached(cache, pa); -} - static inline void virtio_stw_phys_cached(VirtIODevice *vdev, MemoryRegionCache *cache, hwaddr pa, uint16_t value) @@ -197,17 +123,6 @@ static inline void virtio_stw_phys_cached(VirtIODevice= *vdev, } } =20 -static inline void virtio_stl_phys_cached(VirtIODevice *vdev, - MemoryRegionCache *cache, - hwaddr pa, uint32_t value) -{ - if (virtio_access_is_big_endian(vdev)) { - stl_be_phys_cached(cache, pa, value); - } else { - stl_le_phys_cached(cache, pa, value); - } -} - static inline void virtio_tswap16s(VirtIODevice *vdev, uint16_t *s) { *s =3D virtio_tswap16(vdev, *s); --=20 2.52.0 From nobody Mon Feb 9 05:13:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766589407; cv=none; d=zohomail.com; s=zohoarc; b=O3E/MwoRmmNvwQcQQptsaI1OCHxdrK0gPO6UbknHKCYVc5ify8xqcHdvKnRjyrNxoDN5e4yuNqTbn+YajClF/R776001m+r5ens7duQTjg2phl93PV7yCqfzxTFPKpfF8ZiKaXVrodFyoo01RPxt2QQsvLofG76oF3EZuX9pHFM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766589407; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gD8JU2pmVND43MkkfvpIdwWKILzGxGYkTplC6Rgxmp8=; b=XJ2XQJ9WhlBbke1olp3DG+/Y61IUvr8k/UMgNi1lrgrd5/6JGyKdIe2nZU5pqrWRxynosZLi/NwnYYIgZC8DBbXvyHOnH6XB9qIGx2EXIvxTcVqMSqJRKIP589Coo8KIRyzp8j+R6wKlyv9jU448XE5bhck5gKfNNNaSsfOKPoA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766589407552481.7072462015244; Wed, 24 Dec 2025 07:16:47 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYQal-00041h-DU; Wed, 24 Dec 2025 10:15:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYQaK-00035K-3v for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:15:33 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYQaE-0003KJ-4H for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:15:29 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-47d3ffb0f44so2328095e9.3 for ; Wed, 24 Dec 2025 07:15:24 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193d4e91sm291574785e9.13.2025.12.24.07.15.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 07:15:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766589323; x=1767194123; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gD8JU2pmVND43MkkfvpIdwWKILzGxGYkTplC6Rgxmp8=; b=CHg5V5NirHhInzglecSmX9OI0yQOe/AHl1E54yBE/wVD/9O7nYzX74X9K6xOx8fCg8 IPxlDzx1W2GKPKpdgVS0LqqiAyVoqGsubba49bdTblsYoPC70bUBxZyf0aS9Fw4/o/Uy 7hUFTk4jm3ef/01TRwtNgRHSpjSqlJqNs7vaiisQKkS31bjHML8EmRUId5/utUSN2Kpm ZL4wwUNnckNyR5FpwEVzpxRQSYE+/loX37pW6xxHbHMzCi+E21xXBLZlqeGPxsItTP0Z bDfFnT7KFnmfR9hjqO2jsj2aYNhdUiW0IiohVJRavt6vRvtr5evSq41C6w9+tmiT6x0P 05aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766589323; x=1767194123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gD8JU2pmVND43MkkfvpIdwWKILzGxGYkTplC6Rgxmp8=; b=SYtlQ9+/BOdJkqsVRInaEhk7b4C6DZ0vmVSSUs5EN4jeVsml4jRU5733CqvwK2JOPF /eC65D4XV9uYK5eMl2fIj2O8RQnJKXNMAXFnaIiV2NnLqguHfGJLGXfgLYiL2bMzF0I6 1XMLTtMQrjTsusBJ8Q0J9MJlmEVCEADe9VVoI0cGqsV0bKBQGIFozSIYO9vgc6PE6o5m tj9knN9I/DJ+XQUhkjKQS5wkqNVnsqLvVfA0WTc7RD/NJD4ySv7auaIYfUaoeJ4XC18U CqSzlQHvkFmmUCgiqBib5uOY+NWgAa1HrKFYzvGua+lsGuaw0qpd6pcxnV0w7l36FfJY AlaQ== X-Gm-Message-State: AOJu0Yygcw//TA7QW6cnQMJY1nxtrkW3y1EecE+6RVganbSYQyMru5/t TMyWESuro9f9mpIUy8Tk7qhSAnFuiElPeyCFAWhgxwvKwnb/r6p5Zlrjkqs58s0X+284oEfOqT4 TyGr94ic= X-Gm-Gg: AY/fxX4EnCDyRztUtRbkm2IOpIlaaL9AvbwqaAgLS3+BCtw8BzOwEd+rmNjEvsjiv/q YJ/AVg08ZhdvMOxYPbfQ+c63EGDkGHh92Wxnfl4NsxJoaXMrzxVQm9e0Qh+4/DIAOtqCO+eJnJa bANTrNTOYOt+4S7+4gvW75YJyZf++ySRIUbrzrdYSAfjbVhcAW6dNo8QPVALeTezqt9pJh+htQJ 5yXgSsm5Edz0FdFbE+6mZU+si6KL1p47ee1cXm1fif2ETR1dER9sbnwWoe8GbMQIqhz1luvNMKz e06iz+xmaUgj9TI5gD4gIZPXiTIC1XB+jToAzHrF5lNX1Y3OYQqoF1rsSsaI+sdIxeAX7PXxaOK 4KviS1Ceb/Im3d24PlTDk5MEp3929lsRuTAz9kvgTL9oqB9ziOXlC0aO+yZR2JAJSxVmtA5H6Vn 2CFrtvC5URdKmEoB4e9xehyB6Hmsfgq1NEPjLWZQM2zDrlgsCN0wpFF2moEXV6VTTAtg== X-Google-Smtp-Source: AGHT+IED5NTiworPy9fGAYaEAYlWnUKoxV7J9qyYBS1cQtso4club+7XuXaQ+qeAhLJvb9Xr4Cvcjg== X-Received: by 2002:a05:600c:c091:b0:477:7b9a:bb07 with SMTP id 5b1f17b1804b1-47d195a98d5mr153341105e9.35.1766589322759; Wed, 24 Dec 2025 07:15:22 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Andrew Jeffery , qemu-arm@nongnu.org, Peter Xu , Jiaxun Yang , Weiwei Li , Jamin Lin , Mark Cave-Ayland , "Michael S. Tsirkin" , Pierrick Bouvier , Anton Johansson , David Hildenbrand , qemu-riscv@nongnu.org, Steven Lee , Paolo Bonzini , Daniel Henrique Barboza , Troy Lee , Palmer Dabbelt , Zhao Liu , Liu Zhiwei , Peter Maydell , Artyom Tarasenko , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Alistair Francis , Joel Stanley , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 8/9] hw/virtio: Reduce virtio_lduw/stw_phys_cached() scope Date: Wed, 24 Dec 2025 16:13:49 +0100 Message-ID: <20251224151351.86733-9-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224151351.86733-1-philmd@linaro.org> References: <20251224151351.86733-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766589410370158500 virtio_lduw_phys_cached() and virtio_stw_phys_cached() are only used within hw/virtio/virtio.c: reduce their scope by moving their definitions there. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- include/hw/virtio/virtio-access.h | 21 --------------------- hw/virtio/virtio.c | 21 +++++++++++++++++++++ 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-a= ccess.h index c866769cad8..5b5fff5295e 100644 --- a/include/hw/virtio/virtio-access.h +++ b/include/hw/virtio/virtio-access.h @@ -102,27 +102,6 @@ static inline uint16_t virtio_tswap16(VirtIODevice *vd= ev, uint16_t s) #endif } =20 -static inline uint16_t virtio_lduw_phys_cached(VirtIODevice *vdev, - MemoryRegionCache *cache, - hwaddr pa) -{ - if (virtio_access_is_big_endian(vdev)) { - return lduw_be_phys_cached(cache, pa); - } - return lduw_le_phys_cached(cache, pa); -} - -static inline void virtio_stw_phys_cached(VirtIODevice *vdev, - MemoryRegionCache *cache, - hwaddr pa, uint16_t value) -{ - if (virtio_access_is_big_endian(vdev)) { - stw_be_phys_cached(cache, pa, value); - } else { - stw_le_phys_cached(cache, pa, value); - } -} - static inline void virtio_tswap16s(VirtIODevice *vdev, uint16_t *s) { *s =3D virtio_tswap16(vdev, *s); diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 257cda506a4..fba9d347d17 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -216,6 +216,27 @@ static void virtio_check_indirect_feature(VirtIODevice= *vdev) } } =20 +static inline uint16_t virtio_lduw_phys_cached(VirtIODevice *vdev, + MemoryRegionCache *cache, + hwaddr pa) +{ + if (virtio_access_is_big_endian(vdev)) { + return lduw_be_phys_cached(cache, pa); + } + return lduw_le_phys_cached(cache, pa); +} + +static inline void virtio_stw_phys_cached(VirtIODevice *vdev, + MemoryRegionCache *cache, + hwaddr pa, uint16_t value) +{ + if (virtio_access_is_big_endian(vdev)) { + stw_be_phys_cached(cache, pa, value); + } else { + stw_le_phys_cached(cache, pa, value); + } +} + /* Called within call_rcu(). */ static void virtio_free_region_cache(VRingMemoryRegionCaches *caches) { --=20 2.52.0 From nobody Mon Feb 9 05:13:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766589382; cv=none; d=zohomail.com; s=zohoarc; b=SGnks0Ba8b8jP7bs5JY1h/ccw/wASA6Nd3HnZNndoVCjfrMUClt4cchaoZ5vdWk3dz6VGdjBYn1NzTyCLFljlOSl5rHFxV9QTDdOQeZ+ig90to3MXQk5pq0y9dqiFAgWKKz5JH/Ba06mD/rCzGzRD0dW/HTd86EdpTz99yT8nTI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766589382; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2STsbh54189qE+1o4laR9gYQuE676566ttls3ZWds+w=; b=U+KZ1AOM0HkjgW4Dm2zB8r09KC4YQ1hvy/c5Ah+kpRRQPJ2DWbiH/WnZ7iwSNVDHSDltX0JC0YSZDMcJcthVmmOtwUsbp6cpTNzDcpTCdDztKO0GEnucRpQu4uE3YYCgZkHWPbGpo+FckOQjSgeAXb1O1O2/xvSTUh3h2BRz7Do= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766589382683425.2948044053478; Wed, 24 Dec 2025 07:16:22 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYQan-0004Es-JA; Wed, 24 Dec 2025 10:16:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYQaO-000396-Ng for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:15:38 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYQaM-0003MA-V4 for qemu-devel@nongnu.org; Wed, 24 Dec 2025 10:15:36 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-477632d9326so36770915e9.1 for ; Wed, 24 Dec 2025 07:15:33 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be3a33c1csm152422545e9.1.2025.12.24.07.15.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 07:15:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766589332; x=1767194132; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2STsbh54189qE+1o4laR9gYQuE676566ttls3ZWds+w=; b=C2i+Lu1/lY2l8ogeiQpxwXpWNImyZL5KyamCnrfqss6OcAfRGD/uaYMeFMzjPkFTIL 0XybxnQ4by1IgNOB3dAzqrK0ZLVKd97OejqAFDoa6W9hlCYGwIKng1oL1lEyUcALyC88 yaAbP7pav/6nUKfWgGA+EgyKiUIwQQl+5Z4ThyaRo1+rWekHLo1sf+yyVuJDqZsCQECl CJN8+BBwnQRIqA0+pYny+4V0QhQmbYO13rDSEoOJD5b/mJO0j1G9x3taaRngumuoWcBg KEvhYpiX9YYwY7eFhg6lXjE8Rie0F9xBUSRnm9UVG4VwUhEH70X6iGBRssX0ysMMFFb9 TC7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766589332; x=1767194132; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2STsbh54189qE+1o4laR9gYQuE676566ttls3ZWds+w=; b=ew2Pd/bCuimsHumMz0s3DVryR0mUkuOc7TtqPWv4Rf+zbPWnCbsDAwzlkTSVglmyNG /dACJ+JakR0cupnOoQL3vDBbJZrX/AYj0LemtmQm+Q7f0ZJU3PuB0OujLOttYl4EoS2Q 9v+zwzaRLCKlRI2iS45ijwQ6bVrK7Ie5xhldu+VwDcI7YFNK1PQPUuDgPkqv3WFTi2Kk X+Ur1fIxGpjac3jmUOAK4GFVQlouimKD1l4fkAzmzdtqIyynr82voz4luqZwbZ7pY95g mP5sh3PN7aN7937J5BRfWeEjW3EQNlfwT2/zBszimxyf2X7CGJFDosnMDamvJOj7MeCE Mt8Q== X-Gm-Message-State: AOJu0Yx541PZkfAS9olwbq7iXuxAuVAEh+wlVY4eF59lT/2PB6f6u6X2 LZMmiC4+FC53eYAGK1u/EyYjlNp07ooXG7CQ2u/HjAffDTdJmMU8iahMoqXsR/cCpIKMC4W/KcE DA5cGokM= X-Gm-Gg: AY/fxX5vB3h1GpRmeNvK9EYrBSEjZK/uvZb1UDtl6oDusSSAQKuOIKYHGEqWTaJGoZF fq8pZCcxHttnbqSbb5NRZJ+nSl3y5jRMeebbQzCcdCWhvdiMJ+QmxOoz62GyXxgvFh7xeESXKUU 7jdWZwwPFF0JS8RP6OqnMqlJHtvkJNuFPzE2ans9mo4syWTzbtc3z+oTO3gGZGMHSdAzwreIM/I eUGAhdwjyM1SP88tEIkwPBb6oh1KEWq7UsKVOgQgBldHL4VOa2yOKwdPbQ1aESM1PuBuTgCddzL R8xoed4XznnXGwg9/NslWmEFRP+QZ00NnUQUlt6PAk3u6w/m8JNh8Sffj2JmBI8yephlA90PzF9 2iFiFy9EY+uaEEqQn6w7A8whxVAyv5bkc+/JfD7P0Fe2NAznvlGmvs1p3iN5Uu8Di1agGazXNcA hEz/MdKkxU4YiIKqb/jRD2CCBP+PF9Hv3bRIy37gRivLczhzv7bzODZvw= X-Google-Smtp-Source: AGHT+IEvgoodsu6aqePYO/wwRACAfiF8+aQZuVYdSTZPgyXTech4Vmn7J/UyE82A49aABPsyHEOu8Q== X-Received: by 2002:a05:600c:3b0e:b0:477:b0b9:3129 with SMTP id 5b1f17b1804b1-47d1955b7d1mr180064125e9.3.1766589332150; Wed, 24 Dec 2025 07:15:32 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Andrew Jeffery , qemu-arm@nongnu.org, Peter Xu , Jiaxun Yang , Weiwei Li , Jamin Lin , Mark Cave-Ayland , "Michael S. Tsirkin" , Pierrick Bouvier , Anton Johansson , David Hildenbrand , qemu-riscv@nongnu.org, Steven Lee , Paolo Bonzini , Daniel Henrique Barboza , Troy Lee , Palmer Dabbelt , Zhao Liu , Liu Zhiwei , Peter Maydell , Artyom Tarasenko , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Alistair Francis , Joel Stanley , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 9/9] configs/targets: Mark targets not using legacy ldst_phys() API Date: Wed, 24 Dec 2025 16:13:50 +0100 Message-ID: <20251224151351.86733-10-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224151351.86733-1-philmd@linaro.org> References: <20251224151351.86733-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766589384398158500 These targets were only using the legacy ldst_phys() API via the virtio load/store helpers, which got cleaned up. Mark them not using the legacy ldst_phys() API to avoid further use, allowing to eventually remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- configs/targets/mips-softmmu.mak | 1 + configs/targets/mips64-softmmu.mak | 1 + configs/targets/mips64el-softmmu.mak | 1 + configs/targets/mipsel-softmmu.mak | 1 + configs/targets/or1k-softmmu.mak | 1 + configs/targets/riscv32-softmmu.mak | 1 + configs/targets/riscv64-softmmu.mak | 1 + configs/targets/sh4-softmmu.mak | 1 + configs/targets/sh4eb-softmmu.mak | 1 + configs/targets/sparc64-softmmu.mak | 1 + configs/targets/xtensa-softmmu.mak | 1 + configs/targets/xtensaeb-softmmu.mak | 1 + 12 files changed, 12 insertions(+) diff --git a/configs/targets/mips-softmmu.mak b/configs/targets/mips-softmm= u.mak index c9588066b8d..95397af9442 100644 --- a/configs/targets/mips-softmmu.mak +++ b/configs/targets/mips-softmmu.mak @@ -1,3 +1,4 @@ TARGET_ARCH=3Dmips TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/mips64-softmmu.mak b/configs/targets/mips64-so= ftmmu.mak index 7202655fcac..f9cc41b9ed4 100644 --- a/configs/targets/mips64-softmmu.mak +++ b/configs/targets/mips64-softmmu.mak @@ -2,3 +2,4 @@ TARGET_ARCH=3Dmips64 TARGET_BASE_ARCH=3Dmips TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D64 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/mips64el-softmmu.mak b/configs/targets/mips64e= l-softmmu.mak index 3ebeadb29ea..4e7dedc5f30 100644 --- a/configs/targets/mips64el-softmmu.mak +++ b/configs/targets/mips64el-softmmu.mak @@ -1,3 +1,4 @@ TARGET_ARCH=3Dmips64 TARGET_BASE_ARCH=3Dmips TARGET_LONG_BITS=3D64 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/mipsel-softmmu.mak b/configs/targets/mipsel-so= ftmmu.mak index 90e09bdc3e5..b0fba8a9d0a 100644 --- a/configs/targets/mipsel-softmmu.mak +++ b/configs/targets/mipsel-softmmu.mak @@ -1,2 +1,3 @@ TARGET_ARCH=3Dmips TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/or1k-softmmu.mak b/configs/targets/or1k-softmm= u.mak index 0e47d9878b0..89f81b75bf7 100644 --- a/configs/targets/or1k-softmmu.mak +++ b/configs/targets/or1k-softmmu.mak @@ -3,3 +3,4 @@ TARGET_BIG_ENDIAN=3Dy # needed by boot.c and all boards TARGET_NEED_FDT=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/riscv32-softmmu.mak b/configs/targets/riscv32-= softmmu.mak index db55275b868..7476e596082 100644 --- a/configs/targets/riscv32-softmmu.mak +++ b/configs/targets/riscv32-softmmu.mak @@ -4,3 +4,4 @@ TARGET_XML_FILES=3D gdb-xml/riscv-32bit-cpu.xml gdb-xml/ris= cv-32bit-fpu.xml gdb-xm # needed by boot.c TARGET_NEED_FDT=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/riscv64-softmmu.mak b/configs/targets/riscv64-= softmmu.mak index 2bdd4a62cd2..f836f08c5b9 100644 --- a/configs/targets/riscv64-softmmu.mak +++ b/configs/targets/riscv64-softmmu.mak @@ -5,3 +5,4 @@ TARGET_XML_FILES=3D gdb-xml/riscv-64bit-cpu.xml gdb-xml/ris= cv-32bit-fpu.xml gdb-xm # needed by boot.c TARGET_NEED_FDT=3Dy TARGET_LONG_BITS=3D64 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/sh4-softmmu.mak b/configs/targets/sh4-softmmu.= mak index 787d349b501..e0b51f8108d 100644 --- a/configs/targets/sh4-softmmu.mak +++ b/configs/targets/sh4-softmmu.mak @@ -1,2 +1,3 @@ TARGET_ARCH=3Dsh4 TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/sh4eb-softmmu.mak b/configs/targets/sh4eb-soft= mmu.mak index cdea2c61c58..7850dac8191 100644 --- a/configs/targets/sh4eb-softmmu.mak +++ b/configs/targets/sh4eb-softmmu.mak @@ -1,3 +1,4 @@ TARGET_ARCH=3Dsh4 TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/sparc64-softmmu.mak b/configs/targets/sparc64-= softmmu.mak index d9d51d21e59..8ee6d057682 100644 --- a/configs/targets/sparc64-softmmu.mak +++ b/configs/targets/sparc64-softmmu.mak @@ -3,3 +3,4 @@ TARGET_BASE_ARCH=3Dsparc TARGET_BIG_ENDIAN=3Dy TARGET_XML_FILES=3Dgdb-xml/sparc64-core.xml TARGET_LONG_BITS=3D64 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/xtensa-softmmu.mak b/configs/targets/xtensa-so= ftmmu.mak index 2a9797338a6..6aad751e2ba 100644 --- a/configs/targets/xtensa-softmmu.mak +++ b/configs/targets/xtensa-softmmu.mak @@ -1,2 +1,3 @@ TARGET_ARCH=3Dxtensa TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/xtensaeb-softmmu.mak b/configs/targets/xtensae= b-softmmu.mak index 5204729af8b..537407e11ae 100644 --- a/configs/targets/xtensaeb-softmmu.mak +++ b/configs/targets/xtensaeb-softmmu.mak @@ -1,3 +1,4 @@ TARGET_ARCH=3Dxtensa TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy --=20 2.52.0