From nobody Mon Feb 9 21:38:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766584328; cv=none; d=zohomail.com; s=zohoarc; b=lT8D1mlDOSL7iC3UYjprCYy5AgcVtX7TDtncn+PMR2cHOldTKp23Rqn4VElpjJWwv6ukeIE1v9fOIO1pAx+9PQlbCLf2Vdq1/5rtn/a+ujJOIx7XcrIO6GxnjvHkI+9NR1CJZPqvubhxYQrNjX10oRL+CQQN6TYaVZq0j3qn4jI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766584328; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=T6TtjB4UQwqwRYPVMTfmB5PB+7achhP09+w7nxCkDKI=; b=AJIPpTXF5doyVJ0uFokuKJDd9cb1AmlemwgElo2XK8YDZZEgCn0+nZwYPEpsZkqRMZVHps7ddyoMe1eBfFaoanf1RsLrfEVBkgrotLLx7ozxuJMl4jE1hdpqsaanTcCGJYG0Gxhj333+zR61YAReAOhFe4gQhySOIyjUgcM+Wtk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766584328840665.4795879374136; Wed, 24 Dec 2025 05:52:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYPGF-0008Nf-9A; Wed, 24 Dec 2025 08:50:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYPDf-0006hS-PN for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:48:07 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYPDc-0003mx-B8 for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:48:02 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-47d3ba3a4deso5409695e9.2 for ; Wed, 24 Dec 2025 05:47:55 -0800 (PST) Received: from localhost.localdomain (218.170.88.92.rev.sfr.net. [92.88.170.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be27b0d5asm352244165e9.13.2025.12.24.05.47.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 05:47:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766584074; x=1767188874; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T6TtjB4UQwqwRYPVMTfmB5PB+7achhP09+w7nxCkDKI=; b=wync6TykVjBatv8lpk39iwfBgbanM+e3A8BlCo/cxNCcZg6AkKq7+avI6XYftk9bgV TtkD3X0P5LIJ8rKcB994sJykLWcLKRuebc/6Rk8Yaqp+Zbr/1ICB7Uz3V8wSbbB+VYQV /14phIT6mGneeq3e+bVVmZiKrccc/JCnc1P+4leW8TzB7gTZbR28IGz50D9uVB0Mu98w TMC4rnG/rO2PYXYwJjymqpPkULvT/j+abcrZ+T+sj75EJ/xWGQBxbQuYq7hFpVpJNHa3 trecqj7G8L7/UFj7VBcdpGxYS5wbWfyr+vcIAsdU8vPlvA5AhrmL1EdjO3YcpfK+jv0f /5ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766584074; x=1767188874; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T6TtjB4UQwqwRYPVMTfmB5PB+7achhP09+w7nxCkDKI=; b=Z4wQMF/nXN5vJ1bIpDWlAHBcHv8eM1KXWLOuuByROLP1BpptkJnVAMYo6OoOGm/mgH UCOmgrjQn+wNseg2feVR1JxIJvctaYdQ1Qg0sJ/qrmN84ok0p1WcLaH6BtGrY2+Iz11+ /zUNR6hF8AjdEbWnuoUNqPa8UQhYLCArBMmu/a59/Q/5QvMMytkcoM95bZ94R1+tlXhF xPNhGs8oZNVoPxuRM8pemMpvhlbhkXNqplZgp2ZnMlfAYaNF6ighKnzqirHm4viaw51o Dd9VxPKhG8gpAVC47Ul0qaX4/cF3qsH71MA4i7XKyW/q2fU5biPTLLrIJWDVoQmXIYrp DcZA== X-Gm-Message-State: AOJu0Ywc3SElyE+Bxex4kdoiSyOi85MS1Boq3SBOhbUdeuK/1/ERl8ex 9MJfVia9YlAT8uV4L2FGR7FDFQKFnTmNszPasxYodsnoqSZiD4MA8oXCS1ygycC06lUlyYjtijs NdYIvl14= X-Gm-Gg: AY/fxX5T/hVD+XsOOQWF489hMVcQvF2aVGYoiTu0P5ltpKAkhRXPJC1RCGncbhWGVEG kEfN6jUy6OAn8h0jkcZwGHbckO42t1/OAEu40IiCGsdXv6sEFLf9mmLhnyFlafnaZeB9RCZ4AL1 RDJOvDGK1zNY3kZbGCUrosO3vlybfAq8Kn6rUj2a3D26WJfIO/zURVTvr68a4xrgBl1YUpgdKkV PluagKBhjBPEsl61Uu1Dt7hsuIeMB74XNwTTvXm0jOOTNwli3gIXyMgEyGYiQgBJi/ZL/rAFpwQ S6V93SXf/B+xXL1orhWR5u0VxUhuoQ0eNfsLsLYOzJPW6yUPGfYUb0ba7Fp5QpZ2EANdvWHaLJY iKlgn1KOjMU4mV6wRaGeLbilfc8EjL1sRmFa/Q1amWNJwGOpNBCBiYEfXYWeBoqEUe2UnJN+ExJ vlLj9qkDTtJ7nBRAVWQs8t04ZeEtLDgNTrwT4ry8AsNgAMPlytQ4AWnxr/xuVJ X-Google-Smtp-Source: AGHT+IEds8kkPJ6QqXB2zu5iwJshyd1rZwMcqEAQN6/5Dria6axRmI64nWzGYXLbhdl7T2C8ApkzLw== X-Received: by 2002:a05:600c:8b6d:b0:475:dd8d:2f52 with SMTP id 5b1f17b1804b1-47d1959d1d8mr188452035e9.32.1766584074039; Wed, 24 Dec 2025 05:47:54 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jason Wang , qemu-rust@nongnu.org, Peter Maydell , Anton Johansson , Max Filippov , "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Pierrick Bouvier , Brian Cain , Manos Pitsidianakis , qemu-arm@nongnu.org, Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Matheus Tavares Bernardino Subject: [PATCH v2 8/8] target/hexagon: Include missing 'cpu.h' header in 'internal.h' Date: Wed, 24 Dec 2025 14:46:44 +0100 Message-ID: <20251224134644.85582-9-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224134644.85582-1-philmd@linaro.org> References: <20251224134644.85582-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766584329892158500 Both CPUHexagonState and TOTAL_PER_THREAD_REGS are defined in "cpu.h" which is luckily indirectly included. However when refactoring unrelated files we get: In file included from target/hexagon/helper.h:18, from include/exec/helper-proto.h.inc:56, from include/exec/helper-proto.h:13, from target/hexagon/op_helper.c:22: target/hexagon/internal.h: At top level: target/hexagon/internal.h:29:25: error: unknown type name =E2=80=98CPUHex= agonState=E2=80=99; did you mean =E2=80=98CPUPluginState=E2=80=99? 29 | void hexagon_debug_vreg(CPUHexagonState *env, int regnum); | ^~~~~~~~~~~~~~~ | CPUPluginState target/hexagon/internal.h:30:25: error: unknown type name =E2=80=98CPUHex= agonState=E2=80=99; did you mean =E2=80=98CPUPluginState=E2=80=99? 30 | void hexagon_debug_qreg(CPUHexagonState *env, int regnum); | ^~~~~~~~~~~~~~~ | CPUPluginState target/hexagon/internal.h:31:20: error: unknown type name =E2=80=98CPUHex= agonState=E2=80=99; did you mean =E2=80=98CPUPluginState=E2=80=99? 31 | void hexagon_debug(CPUHexagonState *env); | ^~~~~~~~~~~~~~~ | CPUPluginState target/hexagon/internal.h:33:44: error: =E2=80=98TOTAL_PER_THREAD_REGS=E2= =80=99 undeclared here (not in a function) 33 | extern const char * const hexagon_regnames[TOTAL_PER_THREAD_REGS]; | ^~~~~~~~~~~~~~~~~~~~~ Fix that by including the missing header. We don't need the "qemu/log.h" since commit 0cb73cb5a02 ("target/hexagon: Remove HEX_DEBUG/HEX_DEBUG_LOG"): remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Matheus Tavares Bernardino Reviewed-by: Brian Cain --- target/hexagon/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hexagon/internal.h b/target/hexagon/internal.h index 32e96f00d97..5fc837ae229 100644 --- a/target/hexagon/internal.h +++ b/target/hexagon/internal.h @@ -18,7 +18,7 @@ #ifndef HEXAGON_INTERNAL_H #define HEXAGON_INTERNAL_H =20 -#include "qemu/log.h" +#include "target/hexagon/cpu.h" =20 int hexagon_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg); int hexagon_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg); --=20 2.52.0