From nobody Mon Feb 9 01:51:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766584177; cv=none; d=zohomail.com; s=zohoarc; b=D8p/3nGyIc5BlUQR2DkvbeAiWDjZyYAAVYyp4XTEv3AoPqTqs9eWvcZUYWqr3wrEr5E7oFPptLAV1+l48SdtYdFrdtiG286+zSxPny4Yk7JnWvcVofhwOEattdexExIsJnbNZq7WkWWbgkJLHTYvenzUmoYIXPn28pySNXm9l6k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766584177; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/HatAXwMGekb8ws77keU2ufaJzveuprS4Y82gBiI7wk=; b=IeF5AraXA62yCCAnbOKNPeTd6adIy1OIo/m+YVotUO2EUK4fB0jV46xthGS0DkpvureaKBQATD/Gn1q423Aa+PgIUacQT/u5WaZrrUZJSjNP9ihgSsM562/GaGhJXCFSQW4okoVrY9k+fzyB/kOsPLvjj0upGZhuSfEKv0zwryw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176658417706249.96726734526487; Wed, 24 Dec 2025 05:49:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYPCq-0006CQ-CA; Wed, 24 Dec 2025 08:47:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYPCh-00069Q-Br for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:47:04 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYPCc-0003fU-8r for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:47:01 -0500 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-42fbc544b09so4512997f8f.1 for ; Wed, 24 Dec 2025 05:46:57 -0800 (PST) Received: from localhost.localdomain (218.170.88.92.rev.sfr.net. [92.88.170.218]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4327778e27bsm1073363f8f.12.2025.12.24.05.46.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 05:46:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766584016; x=1767188816; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/HatAXwMGekb8ws77keU2ufaJzveuprS4Y82gBiI7wk=; b=uphasc+o/gWoU+YqAUTLLHUJV/ROVbxETmn/3Dqe23EjyMpNPc5UtsLhASkAsw+lYN pyGSeWAN/CM2OAWYzw0ZIP2H4ZfbcqvErYApN6nXZzYY6Z+XO/vH1k78OY3k1xZe3LC7 l/35jx0qbUVgZSw5u4srs6WvrReTyufMU6b5COyMaglyDcQCmsIv3ykWtji9fe2Y2KVn d6g6YzINnTfPKJG3AKx1kcpDFW4OfPMNTbaeVHMVdk8b7YUq6jhQKXuzzrEUNhqovsFC 7ul4r9BWugJZRJPBzGEyO0vd1hkR0lRiGFR60bxBujVh0scm3Cs+CEqGVn68vzCXlPfW IyFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766584016; x=1767188816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/HatAXwMGekb8ws77keU2ufaJzveuprS4Y82gBiI7wk=; b=BuKcOuKdN9ZWez3W7hCzLRBc8rzYN7/rGEyzeI5KM7/UdnpcTMCLC7WZGndHuNtnXi nljmHlB7J6cNTDiVy8jN1A9BRgVlJW3WA+ZNJDictceRssccVMsb2sEjUfljdPM03xXD v1DwJ6m1nRA/94j7AbItCPXbCs3I+9KoSSZw8REcfqJEr+OOebAefp0VkmD09lSs9hFb gbrZxX+Aideh+uX/i2gJcP2YAoMHTYJdUJ0c10/49Ap9o9nM9vvJEoGy9yKEqS688wuI 9WcK0i7TRkM53BWDZbcOB11NWj3+MbJa4CN+//wCnKiL5tNabRBRIsFjZj26dZ8fJerO +Qgw== X-Gm-Message-State: AOJu0Yya2AX+RvpmFUChsKSVLykX/cmFPv2OIYpQ5Lyhy9GIlputj4pQ JXzLbnVeCSvyZaP8mPpPK37Gbw+cSrsgiRqbgpgeVON4BiLQ7eR4L1YDCwauHn3jaTruUfAHM3s PGCWQEEQ= X-Gm-Gg: AY/fxX4549jUKG7HQ0Thg2P6HO390attkfcmAInstptMgwKGCdW9hmjzem1pTrZvGyQ Lqom6FGdo4wf3iMhRkqeQ1uAaCcVJuE091FLjyCmjQrSh3L/ysOJZLzS51nFc2F9ULSUB7tt6v6 QmxjlXRZcRsgi0vza+IkoRliR4KGqzy5u+2U0s3//Jpl/8ZWkrdxn8QqynxcTrsnukM9JB4TxfB tH14WyEpQzRou3+u1YdO8aR1wTqg57lULt6j2+FXVYT7e14BqhMmkjQ3W05AmevenImmKWTlNUY dlKIoXx7SkKa6KVmCsmw38lfsJUbgPkXmIh5djXcwm0fFj1JdMOQtdktw+74TiU6y6qZ91DwWiq lG6KE4nIWjDaDWFUFmGaS9mCw5TVCZ+47evBaiGxgiDE6gvsa5LHlgGvBntFCF7jo0PvhPsKt+y TvG+6+cJ+CzWltSMH+eTGFjarP7dlfC3NI06JszKdWpz2M5S9IP8BXpN+yx7Jyw5wYvwfiMhI= X-Google-Smtp-Source: AGHT+IFImcLyhNm02bS1bcJPwE+B5F0pKDwOtrfRI74UcvtYUim28G8m3NZ44HEdlcfeOhDjUMMsXw== X-Received: by 2002:a05:6000:26c3:b0:42f:b581:c69a with SMTP id ffacd0b85a97d-4324e4c3e13mr19199452f8f.5.1766584016267; Wed, 24 Dec 2025 05:46:56 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jason Wang , qemu-rust@nongnu.org, Peter Maydell , Anton Johansson , Max Filippov , "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Pierrick Bouvier , Brian Cain , Manos Pitsidianakis , qemu-arm@nongnu.org, Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth Subject: [PATCH v2 1/8] hw/arm/Kconfig: Have FSL_IMX6UL SoC select IMX_USBPHY Date: Wed, 24 Dec 2025 14:46:37 +0100 Message-ID: <20251224134644.85582-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224134644.85582-1-philmd@linaro.org> References: <20251224134644.85582-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766584178904158500 Since commit 17372bd812d, the SoC used by the mcimx6ul-evk machine requires the IMX USB PHY component. As this component is only used by 2 machines, do not select it by default (it will be automatically selected when necessary). Fixes: 17372bd812d ("hw/arm/fsl-imx6ul: Wire up USB controllers") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson --- hw/arm/Kconfig | 1 + hw/usb/Kconfig | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 78775063840..97d747e2062 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -638,6 +638,7 @@ config FSL_IMX6UL select IMX select IMX_FEC select IMX_I2C + select IMX_USBPHY select WDT_IMX2 select SDHCI select USB_CHIPIDEA diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index 69c663be52f..de95686720c 100644 --- a/hw/usb/Kconfig +++ b/hw/usb/Kconfig @@ -132,7 +132,6 @@ config USB_CANOKEY =20 config IMX_USBPHY bool - default y depends on USB =20 config USB_DWC3 --=20 2.52.0 From nobody Mon Feb 9 01:51:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766584204; cv=none; d=zohomail.com; s=zohoarc; b=n92KuLtiyMeDO8wRdJyLbOaunm8xasGvjLTenaG8IIQugb6yw9Ghg5pkwTVmj7IZjcjD8hB4UFUXwe5FLXSvR6khHFahCxd4TafegPVt/MCJBAprxLBoUJbdcjvHxBk0VvTxwbUPJY5xMCz+j4qigTNtHTStxbbkH+A3Psef0uM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766584204; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=shYbRzGh4HeszhizU55hQ7lgJiMr3GPlgmdmv3H0HN8=; b=NCx4oggLY7jIN50fMgp0go13Z9h/tetJ+lpVxYqGXnK9a2Elyv7mkU6CU3XD9jbaJmwg6AEnSotY/iwVj8WEmHdXuN9y4AD7UPVlYQZmuqgbFYvP0ufnMU8V+6KUx74Rh83TJClFte/b+lV1fb2N5JQgoOhkUVNxai2cw18S2Z8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766584204197658.0393676421304; Wed, 24 Dec 2025 05:50:04 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYPD3-0006GG-Hr; Wed, 24 Dec 2025 08:47:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYPCn-0006Bo-Pz for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:47:10 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYPCl-0003gI-2D for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:47:09 -0500 Received: by mail-wm1-x343.google.com with SMTP id 5b1f17b1804b1-47d3ba3a4deso5406665e9.2 for ; Wed, 24 Dec 2025 05:47:06 -0800 (PST) Received: from localhost.localdomain (218.170.88.92.rev.sfr.net. [92.88.170.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be3964226sm150434825e9.0.2025.12.24.05.47.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 05:47:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766584025; x=1767188825; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=shYbRzGh4HeszhizU55hQ7lgJiMr3GPlgmdmv3H0HN8=; b=b6PZUvik0LmIw6/ONyrVP+VUzAqGPz+K3sXMrBdyrzGb8A7YOmzF4/nl9DuGXFobts 5snFjeyGK2J+Adr6U8fTiXByxsPzsMJBLFgFnY/ubAvPHDO+7pFrnuwPwTrcHvcz1C9B xDiuVzPFLyMxtu++aHUpIXCMGYKCLKyEk9LKcIkdmqabDj8Nfnf9q+pJiHmgCvXEyBmj NT1YjffhEVcRt8G0qouXMPsQulhHQV4aRg6T4ONqn9P8q4V2pe/pkp0cxg3T5Yl1G3JK X+jbiElWKa4QYH6Ue41g5dSY2Ijb73zsmBDTcpCozHOfDS+2+Ot+y8TLxLoIwbMBEIkP WeBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766584025; x=1767188825; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=shYbRzGh4HeszhizU55hQ7lgJiMr3GPlgmdmv3H0HN8=; b=fYn2hddVBGz0xRLxZqS+xmLDTvz/7Dz1rtkHQs0/Cr4TwVjZPmBDW+Vgc26UhvsEi4 VGU0xJ8f0jqSMJ8CRGCwlqfPyFMuB6IJzPxfiflQeejj97Y8P9M3ecuDVQ2SM/1KlqFh j5fFD7igCH5AFyQCVWYRS5z5EEAZ0tHvS4Hs06HFdREJouF8weQYC/ZwFaDiWcVm8qiG /sOq2toy0YSuxJ8skyA+xJAsWH6yaTH7F1SKXkLgyoG5EjhBoV8fO7mxPFfNo9cik2rH BOmDFW755R4s7K39spYueXzzyqo8BWDQT0/81cSLP9ih/jaSVDuf1JLBwhTLEGNMhyHg D2Dw== X-Gm-Message-State: AOJu0Yw69aJHGQ47pvizLPa9hbNfV/V2zTx5Om9898rmrSt351+es71t XoK9c4TLcXVR7/WNxhZvShjlhiE/VczK1pct8y/ZzLqkNNIM1XCvq+sNYt3Y1qY+NbqH0ULPn4U WJUAkMXmtBg== X-Gm-Gg: AY/fxX5WgyFMhRtYD7Hajcmo21EpxlD1XWqZQMAXZ0zoTl4P+hyc/yFYlVuB9mkqCIm ionG5fvpO8+ktMEAH8IzdcsAHAZMj/j510e8BscZBycqbq65ynzBO70uz2Zn3kO9dFBEMGtXzJ5 6Z+Rct0lNm0UkXOGk13YniSCcx4lTO+Uft7Da+xR/gT3aAqfqkOmUS5/+Ufzw9CRpv1A92jU/4m 9WRoaCO3uUIo1Ig+B8zXoqWIU+j1vuyhSs1Fg+mWPKQv0OHsAabUoa0QOYe+rbo0w6nLIyx/k+v ZkPl1Mckp53W2DBVWH6SCxNQgQhH1ndUU4SxY4WvduRvIWX8okq0JXr0M+xQKECdnSNx5TtOBTh oPWFVwteUyVmmaMzHAuDoJpTwJMefsnN48spcalK7jR094GzNtmhWZ3X6BawGVjyO/hcPzbDVfP 477HQ0Z0Heaz+mWLacRCQE8XplSLGhY7UMEMbHAYHZlOMwqY1QrwrmHwQm28uOHQ2MuExiTSM= X-Google-Smtp-Source: AGHT+IG7/tDrxlL+g7K6TNhz0Uhw+nty/m6CTU7wnXp0QM+lfW92jSz33OPGh4QmDAoNuzxKGRobXw== X-Received: by 2002:a05:600c:8b6d:b0:475:dd8d:2f52 with SMTP id 5b1f17b1804b1-47d1959d1d8mr188420915e9.32.1766584024910; Wed, 24 Dec 2025 05:47:04 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jason Wang , qemu-rust@nongnu.org, Peter Maydell , Anton Johansson , Max Filippov , "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Pierrick Bouvier , Brian Cain , Manos Pitsidianakis , qemu-arm@nongnu.org, Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v2 2/8] hw/net/opencores: Clarify MMIO read/write handlers expect 32-bit access Date: Wed, 24 Dec 2025 14:46:38 +0100 Message-ID: <20251224134644.85582-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224134644.85582-1-philmd@linaro.org> References: <20251224134644.85582-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=philmd@linaro.org; helo=mail-wm1-x343.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766584204986158500 The read/write handlers access array of 32-bit register by index: 277 struct OpenEthState { .. 287 uint32_t regs[REG_MAX]; .. 291 }; 546 static uint64_t open_eth_reg_read(void *opaque, 547 hwaddr addr, unsigned int size) 548 { .. 551 OpenEthState *s =3D opaque; 552 unsigned idx =3D addr / 4; .. 559 v =3D s->regs[idx]; .. 563 return v; 564 } This is a 32-bit implementation. Make that explicit in the MemoryRegionOps structure (this doesn't change the maximum access size, which -- being unset -- is 64-bit). Move the structure just after the handlers to ease code review. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/net/opencores_eth.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.c index 7e955c01322..bc4565a9a49 100644 --- a/hw/net/opencores_eth.c +++ b/hw/net/opencores_eth.c @@ -682,6 +682,15 @@ static void open_eth_reg_write(void *opaque, } } =20 +static const MemoryRegionOps open_eth_reg_ops =3D { + .read =3D open_eth_reg_read, + .write =3D open_eth_reg_write, + .impl =3D { + .min_access_size =3D 4, + .max_access_size =3D 4, + }, +}; + static uint64_t open_eth_desc_read(void *opaque, hwaddr addr, unsigned int size) { @@ -705,12 +714,6 @@ static void open_eth_desc_write(void *opaque, open_eth_check_start_xmit(s); } =20 - -static const MemoryRegionOps open_eth_reg_ops =3D { - .read =3D open_eth_reg_read, - .write =3D open_eth_reg_write, -}; - static const MemoryRegionOps open_eth_desc_ops =3D { .read =3D open_eth_desc_read, .write =3D open_eth_desc_write, --=20 2.52.0 From nobody Mon Feb 9 01:51:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766584200; cv=none; d=zohomail.com; s=zohoarc; b=Xhv11+73wKvYRGPnksCGJM+lsQbTBmBQ0R4eAsCYEwAHGEc6vCfZNdyn+Wo3nXhYwiBPjY0dnQ9REBDwAGHCwExhVBzGvYOlWr0IlRyYxRFezWC9nLiWuVt/N/gHvHMzDPLNPAlRJpmcCKXuCuVY6qDyaZCEzE71z5pNukxBpyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766584200; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mzJWK1Pwrz6pQgzGHNT2SkE91x5BTAmZmkQLDY1djl8=; b=PrMFcZGRtguLO1VF3mWr11QnCuqy+eTWXtU1/NCMqpL+OWM2XLraMgUgfBHaFL/oZu3ZGyiifqN0ois1ofwJGcwDO89cg2VjB1qqjLLR1jnLi4/G796R+OxlvPb1BSlLYFOsuluhPnte9ZnHLweenEIks8KEAOXTaNycyqxyVJk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766584200226474.01854123412727; Wed, 24 Dec 2025 05:50:00 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYPD3-0006Ge-SP; Wed, 24 Dec 2025 08:47:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYPCv-0006Do-3k for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:47:17 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYPCt-0003hP-8N for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:47:16 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4779cb0a33fso60528285e9.0 for ; Wed, 24 Dec 2025 05:47:14 -0800 (PST) Received: from localhost.localdomain (218.170.88.92.rev.sfr.net. [92.88.170.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be2723b2bsm345661975e9.3.2025.12.24.05.47.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 05:47:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766584033; x=1767188833; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mzJWK1Pwrz6pQgzGHNT2SkE91x5BTAmZmkQLDY1djl8=; b=yuWtnNVk/QEW//KsTPyLWokD5+V1NVxlELmtPAT/RYO9KqqpM36ggK2i3nqhVwlmOp MRWi5fPINios6HrWKXeNwUTo52IfX45gFrExHqiwFCrcpXQvgd+z/nuY0XLBL65VJ7Nr GYoPXtIrHOV3f6n17UFuWHJaiMUw+FPbWExIFXlEaskmcbuqvlP+C4ryY402SJApnCz4 icl+FGJn5Ouz5aPQL7TWEbA509DUBeU77t0Jo/p1p27/vsrICzw4vU/1NZEMwoVWustW GDW1c5FDT8wLK9RKtTCRbPrPPt5gtRaePT4RWYpsTYpSSUYlMjanKLToAUCfNDEMiHuE ZgJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766584033; x=1767188833; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mzJWK1Pwrz6pQgzGHNT2SkE91x5BTAmZmkQLDY1djl8=; b=jOpKN7M4+AidXlq8tEelD+mhf2aqQv3/snAEkdXgWJKrKzDJ3JLNzeCA+7N+g6t9CQ ATXU5rnlPpvXqMT65WcMLiYXVTqg/VxFj6EiErQx4RcumLTOUJLQ1VfNHRqm6EWlq1hb A07+S2/95AazNDXUwUqwuAuInzBNfxcA6zhMT5ZHQauq6do4y+l2desIlpMHRY7FCWol LmTN0xiJzWoFyKu2FTTDkUpQPXPE5e/X66Vc7uv59AgVLdpLmVFqQ4DDx5ijcsT9EgE6 ImDsqh1ZiTs/rEB4sRBkVu1+vzCbJVA8jclY3V3nvPS+owWJj+IXXz5Ndr02iO9rI8c3 HSPA== X-Gm-Message-State: AOJu0YzABsPi5CExfwX5wTgpws23Nt+rL6qPx4uTJvb3csIw4YlOW/dD f4wiHobLvw/FH3IEew+Tgo4l74ciucvzJbw5i3xmjYBaTapEtZty3QueIuyrOewuJ/JOZCSCsvd Sg0rkHOA= X-Gm-Gg: AY/fxX5l7zNPaKoRBOXfCnGA2aCiErF6uJ2ckvviB0iRRmlSinz8YKWFXnnhjc5dNQ7 hgLTxxVEIkHGQ+iSn5uMTz7xchisj/jUEPLgEQz6o6WqTnlKXB8zrQOB8YQP+CJOm0m1kOYX8rr 3TTONJ6BwQ/pcZPVdPffd9aDxpzUiDvw7Vq/ZC50tKdETvWX1a48jC8F0AS1PeqRsMuLtxgafn/ WgHJZeKbwu+6tuww/CD+uuwwk1dXVmZQfhYfWXdJRNsNLo2wm77eTA/lYQhzAIo/RrCcHFvrsxu Tjldi9Jucr6Mnw7xFNYopnVr+0srxRL3Ev20QRkeBs46jBqfKNUreHFOhoC3VduBOWM6QoGOaPB wuHHUApflN1JElLv6El37oofoVAjQnVfMtyVfLg3yV0GgwfBQBMH39lZ2klG8DafIXVgWvrA0G3 nJce6Le6D1DGKtkODTO6JjKfDtq6Y0b7waeVm7n4+43jXfNCSkfixtMMeKJiC5 X-Google-Smtp-Source: AGHT+IE6d2LSdC6q+oqc6RwJA1fiu6p4LVLRShJBs9yHrS2whS8MUQ6qgmixDn44iQOJcXVuaAbG2Q== X-Received: by 2002:a05:600c:4e15:b0:46e:1fb7:a1b3 with SMTP id 5b1f17b1804b1-47d276f8addmr143618495e9.23.1766584033124; Wed, 24 Dec 2025 05:47:13 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jason Wang , qemu-rust@nongnu.org, Peter Maydell , Anton Johansson , Max Filippov , "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Pierrick Bouvier , Brian Cain , Manos Pitsidianakis , qemu-arm@nongnu.org, Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v2 3/8] hw/char/serial: Let compiler pick serial_mm_ops[] array length Date: Wed, 24 Dec 2025 14:46:39 +0100 Message-ID: <20251224134644.85582-4-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224134644.85582-1-philmd@linaro.org> References: <20251224134644.85582-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766584200913158500 No need to enforce the MemoryRegionOps array length. We index by device_endian enum, the compiler will easily pick the correct length. Besides, this allow further adjustments in the device_endian enum itself. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/char/serial-mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/serial-mm.c b/hw/char/serial-mm.c index 13aba780ec5..ce5b589c3fd 100644 --- a/hw/char/serial-mm.c +++ b/hw/char/serial-mm.c @@ -44,7 +44,7 @@ static void serial_mm_write(void *opaque, hwaddr addr, serial_io_ops.write(&s->serial, addr >> s->regshift, value, 1); } =20 -static const MemoryRegionOps serial_mm_ops[3] =3D { +static const MemoryRegionOps serial_mm_ops[] =3D { [DEVICE_NATIVE_ENDIAN] =3D { .read =3D serial_mm_read, .write =3D serial_mm_write, --=20 2.52.0 From nobody Mon Feb 9 01:51:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766584191; cv=none; d=zohomail.com; s=zohoarc; b=PtJ5JrJESOLbCIB995H4fMZBgZPySrZj9CtFajm4mzMyWdcuIGFxPbOAgeXeP048u0wV0QHUmWBoz1MgvdWG8q1VuJOway7f4SU+ySuuFJGsjt/Ute/aGD48hmTkdAU5TyNFGcaop+ZrCpFjXY8ncbZDF/Yo8nmhtj/GECzWbps= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766584191; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wYWAkKrgLGKLEJzBNF2mvdemi8iXnGeEWzBQwxd6OM4=; b=LLdCXP4WhDShjkHj/MJYP6lBPAHmCstDpR4hlpWONVk/ixymlsE+wq8fqIVGsgE3/HLBfh/HAHkT+BtBZJGvEgzzpJjqScYUBOoUDRuvIyvI4A7zoN1oV6DUAbM1mnIHkUgC0huUC5uA3QGS2xerPjaIrWM7P+VQwlkzB6EN0U0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176658419185344.65629755508496; Wed, 24 Dec 2025 05:49:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYPDA-0006Jx-FZ; Wed, 24 Dec 2025 08:47:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYPD3-0006Gp-PT for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:47:25 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYPD1-0003i4-F6 for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:47:25 -0500 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-42fbc3056afso3207486f8f.2 for ; Wed, 24 Dec 2025 05:47:22 -0800 (PST) Received: from localhost.localdomain (218.170.88.92.rev.sfr.net. [92.88.170.218]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab2ebfsm33933748f8f.40.2025.12.24.05.47.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 05:47:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766584041; x=1767188841; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wYWAkKrgLGKLEJzBNF2mvdemi8iXnGeEWzBQwxd6OM4=; b=qe4MMcACgyp19BAGesYEO1eojGdxgZqAA283DX/gzrLy95CU/DyisRd60j7HIIhAUh vfbcqhm9uTNlcPSWkMfW9mce7z1wM05fr8T7NGmmtfuJokVXx2LK/dsSBxe2RZ0KWb3v tbv0h9PsRNw0Msop40aSzTQbQ0Bv5qblM2nfLPiyXd68OUyq0gKey1ELEVIvXDeJIyhM 8e5+OLdrRpgTZ8Ngt/Wb7mfRRIGfN3PXYTxDoKrCxqOr6LpXchSLa5nxb55LSqedeCTa cN7XYMcWjDvV05pv9IvtdvY6eUQlQE48bil3Ku30jb6NOl8qszu6pGP3AQARybZlXFVN w3Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766584041; x=1767188841; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wYWAkKrgLGKLEJzBNF2mvdemi8iXnGeEWzBQwxd6OM4=; b=Q7c8X5AFH3WXpiAyzyBNX830M2HD5dRLMapsWCSUpH/nJB60nVqFptk40q2NlMEc8a hBGd3cd5XfhprR1FQogE+5ddMMjosz8QCU/xJpYO0MDn5m5M5FZ4+CiMG4YH3+BGlOrK v/m1NbQeqQZctHD4ulqQZMXOzwwsYeew0VpYVoVKA3X+WFY63/0F07/nZZ8PSATHfMyU 3sA913d/IYA0mV5litG02BmFValgADUghrg2VTyNFYxFj2iANkGIwuqPMlhV32XHDyCt +V9oJXzQ9yQnNWk+TFcz6fSupR5Di3yGQ8Jp4DaDHxPAwcyN8yRZyCypi2T/gaTlr5uD xYLA== X-Gm-Message-State: AOJu0Yw5MrEnWDzZB7eNKZtC+enzi891LurypisQENpJvxWh3ZZBYG20 B2dCLO9+PYfTDuOU6uilk4FN0KLOI1ZBziHoH+2tMEhiHO7DX14YsAsu/TWy/csabaIH7Io5W5/ MTSU8Egk= X-Gm-Gg: AY/fxX5nvSotF1ClNoTbykg9u0FM1W7OCNIVGQV+8WT/DZtjPrCNaz4s1UH8jGGdSgO AUmMloOSmT5KCz1jTobLGDHkgES9Rbs2VBj9Jo4tY9L8oU/dBLTzfct79Lw6vw7ZNZcZvZe59ag 0hRE9o971h3WTHJautPn9jNGlIFopIlqLjlUgAdirQRK7dlBufutuZ641UKxAruvTNLHkqqPx2P IggQ0mMGhHI0z+lsi8tBn2ZEqNRYng63FwGLPNfsDRp2Z3CADRCg9fRj/09ZBFoKVyoZQwuhQ59 ccxn39jyMvd76gpxsAl/5GgQj+6a6o0B0mWKruxw05fQXNyiEOEK/JjSWVDLgiTxv8cFseULm1N opK9pNBo++BGmndkYvUXuEoai4FEWmX1LTpzaw+9zIocR5nwDSjCvB3UfLrJKsxhij9xlMCSx1v Ghvi8TTi/2Lrjw+6s/ZIY++hR9fjC5abXieH5/kU3vzt9AwlZ4vyFPbo80pw3d X-Google-Smtp-Source: AGHT+IGpRKcg+SvCUKQRGP5OhocSibsnsK6aqxmEiszVTN8Sq1AhPQpiR+QXZPhejGYSZFJevKjHgg== X-Received: by 2002:a05:6000:2305:b0:431:316:920a with SMTP id ffacd0b85a97d-4324e4c1519mr17318370f8f.8.1766584041532; Wed, 24 Dec 2025 05:47:21 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jason Wang , qemu-rust@nongnu.org, Peter Maydell , Anton Johansson , Max Filippov , "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Pierrick Bouvier , Brian Cain , Manos Pitsidianakis , qemu-arm@nongnu.org, Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 4/8] hw/misc/pvpanic: Expose MMIO interface as little-endian Date: Wed, 24 Dec 2025 14:46:40 +0100 Message-ID: <20251224134644.85582-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224134644.85582-1-philmd@linaro.org> References: <20251224134644.85582-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766584192940158500 Make the PVPanic MMIO interface behave like the ISA and PCI variants: access it using little endianness. Fixes: a89607c4d0e ("hw/misc/pvpanic: Add MMIO interface") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis --- hw/misc/pvpanic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c index c83247c4087..3e60b226e18 100644 --- a/hw/misc/pvpanic.c +++ b/hw/misc/pvpanic.c @@ -62,6 +62,7 @@ static void pvpanic_write(void *opaque, hwaddr addr, uint= 64_t val, } =20 static const MemoryRegionOps pvpanic_ops =3D { + .endianness =3D DEVICE_LITTLE_ENDIAN, .read =3D pvpanic_read, .write =3D pvpanic_write, .impl =3D { --=20 2.52.0 From nobody Mon Feb 9 01:51:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766584100; cv=none; d=zohomail.com; s=zohoarc; b=HG3lIQFN543LOsjRewOW8NW492bdJ1REq3EUMqb3YbHM3YVw2RZpUK69D6TfeTUwOFl5UHzJ3xEs701LOvFuQuwKa8AUI855/oA2mR5FsTGagOZMoFo7XDMuCSQLQRT8Lpn0QlL6DSrUtpoHcOzTomnp7TT2lN+wZA5JlP6/Jec= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766584100; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vEDW4pEiOQF8aZTfRkTnnN7IXm4k0EgK0HcgihEUm50=; b=Pb89tc7Bun+vq/u4IPw2g/HjY/ahx+Cp3A9EyesNTGvOLTh5ofptfQRyTFek/d30cTs77mNV5BQprD+Qvglj34IKWUIfGl7obbIEFuGZvpVfGdmnnFgj7vZOm6metCx7Jc+Ng/G9WZ87fvhYN0NeMsKrcCriDzJeUYfAs9xZw2s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766584100643599.5366839750346; Wed, 24 Dec 2025 05:48:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYPDS-0006Ze-Hz; Wed, 24 Dec 2025 08:47:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYPDB-0006Kh-P4 for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:47:34 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYPD9-0003jJ-DG for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:47:33 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-477b198f4bcso38874915e9.3 for ; Wed, 24 Dec 2025 05:47:30 -0800 (PST) Received: from localhost.localdomain (218.170.88.92.rev.sfr.net. [92.88.170.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193cbc0bsm300874335e9.11.2025.12.24.05.47.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 05:47:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766584049; x=1767188849; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vEDW4pEiOQF8aZTfRkTnnN7IXm4k0EgK0HcgihEUm50=; b=XrhVX0ttzGoUcaMV8zurqxZEZ16jNyjqtSICZY9/hwZ3yvcb0ILHRhvNqNEMPc5OZn 1GQY2TIA2CbWlc2WkCf6AWKtnoVUsP/Oc8AGQTvDK0TuISCkma/sqWoHygRxWhXFCnHv MGr6Y1zeoELCsSu1+e1rex4GJuO+wEFM5YzhehTqeVeCAWhz++x9JTJMz9uQ1mbPmvGS iFSHDB6JmPyRGBw5N0XlUdIB1FR0BjkzFJGix4jxY0SqGMNgETjtdBeTU2OLi37WF4jB QtFvCHsKUtWuI58vLpiAyWJRdnKTy17MbISxQPYXBW0/v7vbmhni1xGZF9iHjpBKYA4/ HxRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766584049; x=1767188849; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vEDW4pEiOQF8aZTfRkTnnN7IXm4k0EgK0HcgihEUm50=; b=Kpde9uTCmPJ65/nkTiTdD3PgqOaxMKxVHFf48/5NZLF8XfdyasFf2fmG7vHwpkgSku /CG34FpMfsD2dDzzgx9udOTFv3X7xxpAX8AuCrDaxwiMMTx/3UZKAYH2lNwwtYqUJVSN i8646rI1TiUooBN8dssFvIr+tr8f2jer9MvTEHPSGbnsTH++oFspT3qZ5HdHVmvoNQGZ WhG+5CT7KCi/ZVQ41O4d3LOEd3XklWWfAAouKsP8/M+lTh8Xl6HZ0qRo403x59vZjaVO 8Yev+wgOy6xqkph9tnjzYM1slpiJl/EZdfrRIyz79Xnfxq0EskBJlonYjWa8eR0cJhZE yLxg== X-Gm-Message-State: AOJu0YyeysIfXjkSmgdRTnredEQ0mvJsL9iLf1+yG5IhEegaSiHhq4Gv XSO/y8DTy5ykRcXM2Bv99o9Rv4dn3x9twbsxroA37iF6RkOTnluWw0XrmtF7nzqjHTTeGHdVn86 rqoZpdmM= X-Gm-Gg: AY/fxX793iIc/AsuepSgaBDuUYJnO8xlaXcqd3bcdC7DBpwuh8a053xri6MSMv1t62G 40zWw/p76jUTR6hChVCvD11WdcXhgyjvt6IPg+xj6Rsb32GRUMBV02GC7LiwGMN7ivoZ1h061so MQV6jlOcr8TcHLesSY88vDYl3KtZskRyMUAl2hOXGfWS9DMs0OjvVWdJoqH13r3+rcIWPZc3Yit VBXl+bP0sNV/IWA60eP2QaSWUYF4dli1utvPvr+wRzJ4OS2uGeZmvt3mq1JYLEP/3qO1yX9QTpZ yflfUd+d9JAi7UBZ+t2YpTwM/0P9Tk6/A9RRc2M9/IY4gD/Nw2ZglwVjwtxvxEuVRsHoBbmWmb/ Unnb48VFOLwrW9XYdQy2S1iby/ZRMgrZ/cfMiWoghbvpwE1GkL+wSJG5/hDLR88eLXlAvyyFZVr YBk+plk6zz5VhPWS+HxvA3UCqF2+m6MhCkPxFpaDttmlRnVWXvM7dY5FR59nqP X-Google-Smtp-Source: AGHT+IHnqJsRELm10jBU2RIDVAqxKRtc3Jq/rf5twmbfPMauJFhpRv+bid2csAak0epOYGPiW2VxtQ== X-Received: by 2002:a05:600c:4ece:b0:477:6d96:b3c8 with SMTP id 5b1f17b1804b1-47d19576da2mr172053595e9.23.1766584049207; Wed, 24 Dec 2025 05:47:29 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jason Wang , qemu-rust@nongnu.org, Peter Maydell , Anton Johansson , Max Filippov , "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Pierrick Bouvier , Brian Cain , Manos Pitsidianakis , qemu-arm@nongnu.org, Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v2 5/8] hw/timer/hpet: Mark implementation as being little-endian Date: Wed, 24 Dec 2025 14:46:41 +0100 Message-ID: <20251224134644.85582-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224134644.85582-1-philmd@linaro.org> References: <20251224134644.85582-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766584102453158500 The HPET component is only built / used by X86 targets, which are only built in little endianness. Thus we only ever built as little endian, never testing the big-endian possibility of the DEVICE_NATIVE_ENDIAN definition. Simplify by only keeping the little endian variant. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu --- hw/timer/hpet.c | 2 +- rust/hw/timer/hpet/src/device.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index 1acba4fa9db..bfad626d5e1 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -648,7 +648,7 @@ static const MemoryRegionOps hpet_ram_ops =3D { .min_access_size =3D 4, .max_access_size =3D 8, }, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, }; =20 static void hpet_reset(DeviceState *d) diff --git a/rust/hw/timer/hpet/src/device.rs b/rust/hw/timer/hpet/src/devi= ce.rs index 3564aa79c6e..4f4be84115e 100644 --- a/rust/hw/timer/hpet/src/device.rs +++ b/rust/hw/timer/hpet/src/device.rs @@ -708,7 +708,7 @@ unsafe fn init(mut this: ParentInit) { MemoryRegionOpsBuilder::::new() .read(&HPETState::read) .write(&HPETState::write) - .native_endian() + .little_endian() .valid_sizes(4, 8) .impl_sizes(4, 8) .build(); --=20 2.52.0 From nobody Mon Feb 9 01:51:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766584311; cv=none; d=zohomail.com; s=zohoarc; b=fcHnP2Miqm5X9EdkSIFSL8H6ELqclgpCcgcTCaljwebWri/eZBHgHvGMPYqaQr7didUyKYvmcxUCKFxCCPsoX09aReBr4zEdIjArU/oFA5N/TyhqeGTl5RIBgPIOMRjWN9VhmcDe7huctKxTBpOp9HHZqW7m4pwqGwYQqSI0oWo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766584311; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DN3Kq8SgtAy5PtsJd1FI2a+o8ZqVooLM5lk+87PhuAI=; b=gQ/fGqmQkqGLV/PzznHxnb+Cz4WVR5bpiNEPSJTRn2S4I357oLqCGWW1hVXXiVpagnMRbyXxUDdoBpo9YDtv3I7qAGSVHJSM1XtKDu2QzYbOoiAXYjrTb6EqGaUtf1Gp3HPI26PckWiBHTRq+0//gPFwFy4dM1e3dOUWrCVWGVo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766584311140671.6024433703709; Wed, 24 Dec 2025 05:51:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYPFT-0007gW-BY; Wed, 24 Dec 2025 08:50:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYPDK-0006OE-Os for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:47:43 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYPDI-0003ke-3D for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:47:42 -0500 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-42fbad1fa90so5089333f8f.0 for ; Wed, 24 Dec 2025 05:47:38 -0800 (PST) Received: from localhost.localdomain (218.170.88.92.rev.sfr.net. [92.88.170.218]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1af20sm32276550f8f.2.2025.12.24.05.47.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 05:47:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766584057; x=1767188857; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DN3Kq8SgtAy5PtsJd1FI2a+o8ZqVooLM5lk+87PhuAI=; b=DA+BjPXdMKOuy7S0EEHP1rJ2OLvqinRgkAfDiMtQ2FhyuDfF/cK/y1twWG5qs4TaAQ 0zbimQ8PMawPVUwzAypbNyoF6bSL416rxHQozwveh8/T+KbkOx3vfx90hfBD0GULz2qB qQ+yhgsGgJJUBO8jpPHeSAgLlKPVDg/g32drmOn962Ap4AUWMbadKzSDeEczJx/7s0MU vabS9oyun8rtmRfV/AwCq7/QiZJC2CMOX03weXD2UOEzWxL1s9T/cyiAf4wkgR17KFCW /vmPJokDuaSQX0seNxGOE7DbcQjL/8yqveO0NAjjZ7SdeiWFul++HqrpwOULeAYwmIlV TPnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766584057; x=1767188857; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DN3Kq8SgtAy5PtsJd1FI2a+o8ZqVooLM5lk+87PhuAI=; b=YlDW6YFVx1McbE8L7pnCjR6tGH9g+WQWtMYn6MEiiB1ZT6nZZEqVBzuR5iUxKzlU3R 7CosBi3temFRjxdAClPB+WdD+SgV2FXL12G2lVQpFPIXbUxqh4pPjkxOn2WBpIJXvxDZ tMOtjKuPbcLlOMVD7mLKKUCa3n/cABdPHHupBkNDqvamEyfAPjP3s97gccoR6JHJIaBp AQisBPcSvYN5KzM596qtpa9hj4GCpwDy5crw6RwQ0KSTvp7eZeUxn2oUMZ3KtE3BvSaF VgytYJ8Tv2wATzzy+GuMjFYnycNxGevvH0QOyXh3LhEC81VeYrA7wCNLpoxeNSA3pPpc 2ceQ== X-Gm-Message-State: AOJu0YwcOn/YwadLkQRKDoPuvPojk/9JnnrNJGGh5pGo22geh0EwioGD uRlqtYdw9Y0WpKfm1BNdfP2yth26IU31aO7kr9CtjmGfjuv4fFILtsLyfbpaK08GwuapsKM+hyZ wgYWIwAA= X-Gm-Gg: AY/fxX5JwqAvsOETLuZqJbaw8zAFEf+hmH/+2PRhsETY9fso3T4WtZViPF1ytxAU6TH fg8JaNQd5SB4Q+MOqjLWNDcZcMGj2Gj18vG0VGrZrJQsBV88o0Ia5UlY3vwWoEBSTyeKDhSzozu o7wBEBf9zNMW0TCS02Rhin+RGpxVXehrbGnGeVjB5X3YEHE/lpRzIwafFB/JHE+cn9uBfLnXoNq XRDgMcFQ33pseiHdN8xzd8ZfCwTukT+et3ugIGbo0k/IVw7JReWYyJlokrLVlZknbLPCh/6S+rL 10TmHTiDNwZTmT0/YbuVKkdEViRfOdsmjWxk5vZRfKUlydol5Ua7gCbHSj2ClihdG64zWV04zUb 1T9BTtnHECUUSae+JpMbtJqR/k1GF8i4Ayo1Tsijee+pg0thlov/GCKLJfhVoQCGlinxjoEpYbY RwveOxBR/nQEOx0q9CqvcRTeO2IbgH/WbaF7kgW79sYjYTndgWPU7gjTg4LxmN X-Google-Smtp-Source: AGHT+IHfiJy1RzIekw7/u9Wdg8X9vE3qpfo8ZHQkIMT0x5yB0ObkCfXgkgTD+eEUQDcGw4t1lcq7jg== X-Received: by 2002:a05:6000:1868:b0:431:5ac:1fc with SMTP id ffacd0b85a97d-4324e4c9bb8mr19912581f8f.14.1766584057273; Wed, 24 Dec 2025 05:47:37 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jason Wang , qemu-rust@nongnu.org, Peter Maydell , Anton Johansson , Max Filippov , "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Pierrick Bouvier , Brian Cain , Manos Pitsidianakis , qemu-arm@nongnu.org, Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v2 6/8] hw/char/pl011: Mark implementation as being little-endian Date: Wed, 24 Dec 2025 14:46:42 +0100 Message-ID: <20251224134644.85582-7-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224134644.85582-1-philmd@linaro.org> References: <20251224134644.85582-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766584311758158501 The PL011 component is only built / used by ARM targets, which are only built in little endianness. Thus we only ever built as little endian, never testing the big-endian possibility of the DEVICE_NATIVE_ENDIAN definition. Simplify by only keeping the little endian variant. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Manos Pitsidianakis Reviewed-by: Zhao Liu --- hw/char/pl011.c | 2 +- rust/hw/char/pl011/src/device.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/pl011.c b/hw/char/pl011.c index 01335d9437d..97cd9bd4c54 100644 --- a/hw/char/pl011.c +++ b/hw/char/pl011.c @@ -538,7 +538,7 @@ static void pl011_clock_update(void *opaque, ClockEvent= event) static const MemoryRegionOps pl011_ops =3D { .read =3D pl011_read, .write =3D pl011_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .impl.min_access_size =3D 4, .impl.max_access_size =3D 4, }; diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src/devi= ce.rs index 04155dabe1a..a6227a99f30 100644 --- a/rust/hw/char/pl011/src/device.rs +++ b/rust/hw/char/pl011/src/device.rs @@ -495,7 +495,7 @@ unsafe fn init(mut this: ParentInit) { static PL011_OPS: MemoryRegionOps =3D MemoryRegionOpsB= uilder::::new() .read(&PL011State::read) .write(&PL011State::write) - .native_endian() + .little_endian() .impl_sizes(4, 4) .build(); =20 --=20 2.52.0 From nobody Mon Feb 9 01:51:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766584311; cv=none; d=zohomail.com; s=zohoarc; b=kgevCaiVZo+gkzhPxLJv6cMEZ4pL1Mm9eH1+dbSohhlQ0IFSzMnSLYZ88qRg/aqM4FoeQTK55zmQNQJncu8Dgt38OnhVYDkOFQYxDAKoU1DJltshESgEyvECl8LeokJhLb2/b4JFZf7FipzOLj15gLMU/gzDZb9Rk3zuI0mD6RQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766584311; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YVNa2eAoUvaGlMzA9uAofR7bmorBdrtqrTMlhne7wfM=; b=l2F46Mcch3eEibGez1G2FMs0WGFjaedZrov/CErGqUqi+h2b9yj36v6c9eqoAAticCCLhA7W5fXSbaUHkCq/ru/5sH4Gb1Rt2ajIkrj7CO44OdkPUOZvbXD9Su8K1Z5+rmRrBD3zLCsoVTxxNho5lu54PpVIP4HGUEghQAhP/vY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176658431185133.1072813482549; Wed, 24 Dec 2025 05:51:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYPGA-0008KX-Jp; Wed, 24 Dec 2025 08:50:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYPDT-0006b1-Al for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:47:52 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYPDQ-0003lZ-1h for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:47:50 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-477b5e0323bso35078475e9.0 for ; Wed, 24 Dec 2025 05:47:47 -0800 (PST) Received: from localhost.localdomain (218.170.88.92.rev.sfr.net. [92.88.170.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be2723d19sm376208935e9.2.2025.12.24.05.47.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 05:47:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766584066; x=1767188866; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YVNa2eAoUvaGlMzA9uAofR7bmorBdrtqrTMlhne7wfM=; b=CUTWK+RyDBM+/p5NCXnY7ncwRX72tbnATTQ9wz+++3yBY0xKbNTrlKgaoBGVm0ytmM km6eX0VKdhN6y1T95KoxacrRMxktXvBeI4wjey9Fh5HcsQcYknmJK1N9Gb84kVzxN8Uc 6bWeUmmELAQQqdSFcXqOYoGMoKvhrsMMIAAqouCY5kDzoLB5FxwDrphqNrGIXc0jL7UU DBdXkLv0UM+h04i6NmRirKGQbg7FF9vviKqzvI0Tsw9bE6opjAL9gmT7rLo0Rf9GnDsQ Vi9A/Jun6AgIGe6aHFy4X02Uk4lF//kD/5NkAWS49hg38EQQIzG5iPJyKPLciSHyVGIN HnLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766584066; x=1767188866; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YVNa2eAoUvaGlMzA9uAofR7bmorBdrtqrTMlhne7wfM=; b=XeBjDrLZEMAAMIJzX7usXMLFnMOLPx1fwJueupUn7cCkurL7FpfnxxPnA4pBTLBLSL mrAQYo5+6jxdFG5PtXEHTHGt6QRpF5u/g/r0niyhuCO2gHKlYYi4P9X3XAHh/jRdwlz7 mI74Uf4+lTrRCqRizQtp/fycP6XlOOcIOUyUIki2RDqOCBHjoFolxRNcwwSqkIB4daP4 a3ofQdTmysPh9o7KunMNZteMpbBk2zZFgHXIb/7lhMsVQSPWgbbDvt2ECCHg7xA1Q1+T oDr657l8ccAJJJWZf2UpxeEJ1ioh2kZE0Fp/lSFkSXJ6YIhh847tHhLTa6mFwaBmKsid qjeA== X-Gm-Message-State: AOJu0YyR65woJIFm6lzy5rkWdc+Y6FxoDem2bvbUJGcC85z3XGHASAHj z5tM3J1k+JZbskJHKJ8/3XOTT6zpzNK9ARJz4hbZczebd+kE1c28MQiYBSpw8FcZvn1KUy04LQe 3Sh87dec= X-Gm-Gg: AY/fxX4JZjcYkqmeuRUqLXDIFSiLKG28oMH7Rk4jMEHqdK3aRUVLb7lNQDxVnhQDRg2 izo9gCF7Yu/OhV5pK51pveUfxtuzLl1BTFGQl7cjyaSiUqkVFwyNWl7DwH9qklvdqm822llgjmP t3mYoxej5Z9ECA6vee+HZOGLinf3rtp4gJisY78QsSlJIFGvfR2NyumgIa7ZtIKUsxC9FFvMAkl YhpWuv3KCr49WVbczz5uaU1oawo1/vV3EGfG43W2NoMnKkAy/JxrPZSOoLKUjP4roIihGiJu+xi /EzEK2/XUGajTX3q/kA0lQLpXGIyTsdISB1XrBecJ4awy5aiPDQWp+ZHANtdp4zlev7yTY28X80 pXxFUJj4OJBG5DHzFcHvyHIQm20k4bh2rxItWNotJOV72Ql+jRQc7p8/bRVxySi6t6vXEqM1KNr 7CohS3SJcQAyCSJ5e9JlzbCK12mi6408tAAe0MFpJeudxnHS4DfoGrjulVZ6Tg X-Google-Smtp-Source: AGHT+IHXDwUHzpRL+TDil5DrS9Vl85n+PZugR84+0Eb1SFFlUSrkua5NwGAaCqdyd0s9porZQyyTRw== X-Received: by 2002:a05:600c:8718:b0:477:9d88:2da6 with SMTP id 5b1f17b1804b1-47d18b0ad6fmr172243755e9.0.1766584065962; Wed, 24 Dec 2025 05:47:45 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jason Wang , qemu-rust@nongnu.org, Peter Maydell , Anton Johansson , Max Filippov , "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Pierrick Bouvier , Brian Cain , Manos Pitsidianakis , qemu-arm@nongnu.org, Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v2 7/8] rust/system: Stop exposing bogus DEVICE_NATIVE_ENDIAN symbol Date: Wed, 24 Dec 2025 14:46:43 +0100 Message-ID: <20251224134644.85582-8-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224134644.85582-1-philmd@linaro.org> References: <20251224134644.85582-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766584313664158500 We want to remove the bogus DEVICE_NATIVE_ENDIAN definition (by only having it explicit, either big or little one). Stop exposing it to rust devices to avoid it spreading further. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Manos Pitsidianakis Reviewed-by: Zhao Liu --- rust/system/src/memory.rs | 6 ------ 1 file changed, 6 deletions(-) diff --git a/rust/system/src/memory.rs b/rust/system/src/memory.rs index 4b3316bf767..4e06c16a0b5 100644 --- a/rust/system/src/memory.rs +++ b/rust/system/src/memory.rs @@ -78,12 +78,6 @@ pub const fn little_endian(mut self) -> Self { self } =20 - #[must_use] - pub const fn native_endian(mut self) -> Self { - self.0.endianness =3D device_endian::DEVICE_NATIVE_ENDIAN; - self - } - #[must_use] pub const fn valid_sizes(mut self, min: u32, max: u32) -> Self { self.0.valid.min_access_size =3D min; --=20 2.52.0 From nobody Mon Feb 9 01:51:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766584328; cv=none; d=zohomail.com; s=zohoarc; b=lT8D1mlDOSL7iC3UYjprCYy5AgcVtX7TDtncn+PMR2cHOldTKp23Rqn4VElpjJWwv6ukeIE1v9fOIO1pAx+9PQlbCLf2Vdq1/5rtn/a+ujJOIx7XcrIO6GxnjvHkI+9NR1CJZPqvubhxYQrNjX10oRL+CQQN6TYaVZq0j3qn4jI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766584328; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=T6TtjB4UQwqwRYPVMTfmB5PB+7achhP09+w7nxCkDKI=; b=AJIPpTXF5doyVJ0uFokuKJDd9cb1AmlemwgElo2XK8YDZZEgCn0+nZwYPEpsZkqRMZVHps7ddyoMe1eBfFaoanf1RsLrfEVBkgrotLLx7ozxuJMl4jE1hdpqsaanTcCGJYG0Gxhj333+zR61YAReAOhFe4gQhySOIyjUgcM+Wtk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766584328840665.4795879374136; Wed, 24 Dec 2025 05:52:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYPGF-0008Nf-9A; Wed, 24 Dec 2025 08:50:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYPDf-0006hS-PN for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:48:07 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYPDc-0003mx-B8 for qemu-devel@nongnu.org; Wed, 24 Dec 2025 08:48:02 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-47d3ba3a4deso5409695e9.2 for ; Wed, 24 Dec 2025 05:47:55 -0800 (PST) Received: from localhost.localdomain (218.170.88.92.rev.sfr.net. [92.88.170.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be27b0d5asm352244165e9.13.2025.12.24.05.47.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 05:47:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766584074; x=1767188874; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T6TtjB4UQwqwRYPVMTfmB5PB+7achhP09+w7nxCkDKI=; b=wync6TykVjBatv8lpk39iwfBgbanM+e3A8BlCo/cxNCcZg6AkKq7+avI6XYftk9bgV TtkD3X0P5LIJ8rKcB994sJykLWcLKRuebc/6Rk8Yaqp+Zbr/1ICB7Uz3V8wSbbB+VYQV /14phIT6mGneeq3e+bVVmZiKrccc/JCnc1P+4leW8TzB7gTZbR28IGz50D9uVB0Mu98w TMC4rnG/rO2PYXYwJjymqpPkULvT/j+abcrZ+T+sj75EJ/xWGQBxbQuYq7hFpVpJNHa3 trecqj7G8L7/UFj7VBcdpGxYS5wbWfyr+vcIAsdU8vPlvA5AhrmL1EdjO3YcpfK+jv0f /5ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766584074; x=1767188874; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T6TtjB4UQwqwRYPVMTfmB5PB+7achhP09+w7nxCkDKI=; b=Z4wQMF/nXN5vJ1bIpDWlAHBcHv8eM1KXWLOuuByROLP1BpptkJnVAMYo6OoOGm/mgH UCOmgrjQn+wNseg2feVR1JxIJvctaYdQ1Qg0sJ/qrmN84ok0p1WcLaH6BtGrY2+Iz11+ /zUNR6hF8AjdEbWnuoUNqPa8UQhYLCArBMmu/a59/Q/5QvMMytkcoM95bZ94R1+tlXhF xPNhGs8oZNVoPxuRM8pemMpvhlbhkXNqplZgp2ZnMlfAYaNF6ighKnzqirHm4viaw51o Dd9VxPKhG8gpAVC47Ul0qaX4/cF3qsH71MA4i7XKyW/q2fU5biPTLLrIJWDVoQmXIYrp DcZA== X-Gm-Message-State: AOJu0Ywc3SElyE+Bxex4kdoiSyOi85MS1Boq3SBOhbUdeuK/1/ERl8ex 9MJfVia9YlAT8uV4L2FGR7FDFQKFnTmNszPasxYodsnoqSZiD4MA8oXCS1ygycC06lUlyYjtijs NdYIvl14= X-Gm-Gg: AY/fxX5T/hVD+XsOOQWF489hMVcQvF2aVGYoiTu0P5ltpKAkhRXPJC1RCGncbhWGVEG kEfN6jUy6OAn8h0jkcZwGHbckO42t1/OAEu40IiCGsdXv6sEFLf9mmLhnyFlafnaZeB9RCZ4AL1 RDJOvDGK1zNY3kZbGCUrosO3vlybfAq8Kn6rUj2a3D26WJfIO/zURVTvr68a4xrgBl1YUpgdKkV PluagKBhjBPEsl61Uu1Dt7hsuIeMB74XNwTTvXm0jOOTNwli3gIXyMgEyGYiQgBJi/ZL/rAFpwQ S6V93SXf/B+xXL1orhWR5u0VxUhuoQ0eNfsLsLYOzJPW6yUPGfYUb0ba7Fp5QpZ2EANdvWHaLJY iKlgn1KOjMU4mV6wRaGeLbilfc8EjL1sRmFa/Q1amWNJwGOpNBCBiYEfXYWeBoqEUe2UnJN+ExJ vlLj9qkDTtJ7nBRAVWQs8t04ZeEtLDgNTrwT4ry8AsNgAMPlytQ4AWnxr/xuVJ X-Google-Smtp-Source: AGHT+IEds8kkPJ6QqXB2zu5iwJshyd1rZwMcqEAQN6/5Dria6axRmI64nWzGYXLbhdl7T2C8ApkzLw== X-Received: by 2002:a05:600c:8b6d:b0:475:dd8d:2f52 with SMTP id 5b1f17b1804b1-47d1959d1d8mr188452035e9.32.1766584074039; Wed, 24 Dec 2025 05:47:54 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jason Wang , qemu-rust@nongnu.org, Peter Maydell , Anton Johansson , Max Filippov , "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Pierrick Bouvier , Brian Cain , Manos Pitsidianakis , qemu-arm@nongnu.org, Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Matheus Tavares Bernardino Subject: [PATCH v2 8/8] target/hexagon: Include missing 'cpu.h' header in 'internal.h' Date: Wed, 24 Dec 2025 14:46:44 +0100 Message-ID: <20251224134644.85582-9-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224134644.85582-1-philmd@linaro.org> References: <20251224134644.85582-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766584329892158500 Both CPUHexagonState and TOTAL_PER_THREAD_REGS are defined in "cpu.h" which is luckily indirectly included. However when refactoring unrelated files we get: In file included from target/hexagon/helper.h:18, from include/exec/helper-proto.h.inc:56, from include/exec/helper-proto.h:13, from target/hexagon/op_helper.c:22: target/hexagon/internal.h: At top level: target/hexagon/internal.h:29:25: error: unknown type name =E2=80=98CPUHex= agonState=E2=80=99; did you mean =E2=80=98CPUPluginState=E2=80=99? 29 | void hexagon_debug_vreg(CPUHexagonState *env, int regnum); | ^~~~~~~~~~~~~~~ | CPUPluginState target/hexagon/internal.h:30:25: error: unknown type name =E2=80=98CPUHex= agonState=E2=80=99; did you mean =E2=80=98CPUPluginState=E2=80=99? 30 | void hexagon_debug_qreg(CPUHexagonState *env, int regnum); | ^~~~~~~~~~~~~~~ | CPUPluginState target/hexagon/internal.h:31:20: error: unknown type name =E2=80=98CPUHex= agonState=E2=80=99; did you mean =E2=80=98CPUPluginState=E2=80=99? 31 | void hexagon_debug(CPUHexagonState *env); | ^~~~~~~~~~~~~~~ | CPUPluginState target/hexagon/internal.h:33:44: error: =E2=80=98TOTAL_PER_THREAD_REGS=E2= =80=99 undeclared here (not in a function) 33 | extern const char * const hexagon_regnames[TOTAL_PER_THREAD_REGS]; | ^~~~~~~~~~~~~~~~~~~~~ Fix that by including the missing header. We don't need the "qemu/log.h" since commit 0cb73cb5a02 ("target/hexagon: Remove HEX_DEBUG/HEX_DEBUG_LOG"): remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Matheus Tavares Bernardino Reviewed-by: Brian Cain --- target/hexagon/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hexagon/internal.h b/target/hexagon/internal.h index 32e96f00d97..5fc837ae229 100644 --- a/target/hexagon/internal.h +++ b/target/hexagon/internal.h @@ -18,7 +18,7 @@ #ifndef HEXAGON_INTERNAL_H #define HEXAGON_INTERNAL_H =20 -#include "qemu/log.h" +#include "target/hexagon/cpu.h" =20 int hexagon_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg); int hexagon_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg); --=20 2.52.0