From nobody Sat Feb 7 07:09:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1766505121; cv=none; d=zohomail.com; s=zohoarc; b=h/Z2nHToVcNlWw8pfBzJdv3fRNncUpppTKXHS11AQ767UJQ/6XZrqG1wdibxugMYsm8hCqhrT9Fbwvs06HMD3qrMed3AyVCNaiHRaC02U3XTVB4BizcoHYeDe3EbIr+0u8KSMDQaGfXBIq3eUqVk1ZxcxaludXOizVkQ2XkbqXE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766505121; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ld75o990EFKoVyAOP6yV/TF2nlR/x3nvUJdUjcgeLMw=; b=LsSbCQ9xSYZsAwkPnjnnJjd9rTbwmLci/j0IkSvsQai8SwA5gd1aptJmQAeN5a+3BZR9jH9pQWcaTfAo/GzLgqL6TffUGY7Qjt7KX0FCBIbtP4zx8Ss+Hg3ECBlpPvM5JeEk3F+DaQqdoKmyuOToCH+v0gBmWNoEIo4vGK3j9BM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17665051217591002.0764154451871; Tue, 23 Dec 2025 07:52:01 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vY4f6-00006W-Cp; Tue, 23 Dec 2025 10:51:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vY4ex-0008Vr-PE for qemu-devel@nongnu.org; Tue, 23 Dec 2025 10:50:52 -0500 Received: from sea.source.kernel.org ([172.234.252.31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vY4ev-0005QX-9B for qemu-devel@nongnu.org; Tue, 23 Dec 2025 10:50:51 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 3C767412ED; Tue, 23 Dec 2025 15:50:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F952C113D0; Tue, 23 Dec 2025 15:50:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766505048; bh=sCLFamuuDl92TRhJeTQHcwK22XOZ3l6BNKExuSaT7Zo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A/1fhgtrQkMdAbv+W0CSUE2BiAKtUA57+xpPd5rvFf8Kkh+kA14Of1Fuyx4J9txkq /FIrDOH/OwSWUzm5E6VQ5p8L+IUqZelT4y4sOxeqRs0Qurv6p4HYnxHicGB4j12IOK oMhrkH6xEO4KsvQ/VN7ObvhrkaOLtYQ26IABlA6z3ZqVCZE+xalLfUMovJEY2n0T/O eY0FqkYuozE+jhZkmdAQJi95EI7Y9LPki/E/fpn9ucBKfQBMQpaR8XT38jaz3e6L8K d9Ju+3SoMi6P2C9PQP/fmELHFdSQG150no5QEUXzTC48tAWM8P3/Y/EzoXwtkKydq9 Z4cKjtYwVmnCg== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Soumyajyotii Ssarkar , Paolo Bonzini , Helge Deller , Sven Schnelle , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Fam Zheng Subject: [PULL 05/12] scsi: ncr710: Fix DMA State machine and flow control Date: Tue, 23 Dec 2025 16:50:24 +0100 Message-ID: <20251223155031.7110-6-deller@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251223155031.7110-1-deller@kernel.org> References: <20251223155031.7110-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=172.234.252.31; envelope-from=deller@kernel.org; helo=sea.source.kernel.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1766505122885158500 Content-Type: text/plain; charset="utf-8" From: Soumyajyotii Ssarkar Set waiting state and return after scsi_req_continue() to prevent re entrancy when DMA transfer completes. Signed-off-by: Soumyajyotii Ssarkar Reviewed-by: Helge Deller Signed-off-by: Helge Deller --- hw/scsi/ncr53c710.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index 0b7734a129..e17d1f3fb8 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -718,7 +718,9 @@ static void ncr710_do_dma(NCR710State *s, int out) if (s->current->dma_len =3D=3D 0) { s->current->dma_buf =3D NULL; s->current->pending =3D 0; + s->waiting =3D NCR710_WAIT_DMA; scsi_req_continue(s->current->req); + return; } else { s->current->dma_buf +=3D count; s->waiting =3D NCR710_WAIT_NONE; --=20 2.52.0