From nobody Sat Feb 7 05:49:17 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1766414570; cv=none; d=zohomail.com; s=zohoarc; b=M8tg4EBRvTT/zLAjrQJqMJGu1S53dyImPuLFxA9sqLUr1RqZ1VWReZ3VG4RjvzJRnWjTf1gVQRZIqt9GQymOrHPqVlPqxfS5stdu2VSHKKLJ550zgk9II0VEPYlvMLEORNzIR3vf2dGH0uNgVInkDgUZj3ygrjD1xcOYYg8eWRQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766414570; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WzwePHdklsGGhwqqgO87iuWqFCy5GPuHXUbtL7FvFls=; b=cnbrNz12QfOPizYKX5mX4RKYMnJ4uOoWfTCmP6h86XhxnpBS7l5Ijy53e1Ok7XhXdILpn/sGS4HY5Wt2oh2ESn9iwWg4hOAqpZFnxg8lQ9Yv30kiMYZtLYGyUNnQ9jkuf5sk3EC6uXZRZbgiUC04Ik/GpoUqfLgYMCr2ubSGkMg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176641457029094.9445458358972; Mon, 22 Dec 2025 06:42:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vXh70-0000YS-Hw; Mon, 22 Dec 2025 09:42:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vXh6y-0000Y8-TJ for qemu-devel@nongnu.org; Mon, 22 Dec 2025 09:42:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vXh6w-0007l1-Pt for qemu-devel@nongnu.org; Mon, 22 Dec 2025 09:42:12 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-4LyG7fQwOs6itKxsqCflJA-1; Mon, 22 Dec 2025 09:40:58 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C6EBC19560B2 for ; Mon, 22 Dec 2025 14:40:57 +0000 (UTC) Received: from eashurov-thinkpadx1carbongen12.raanaii.csb (unknown [10.50.10.160]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6D383180035F; Mon, 22 Dec 2025 14:40:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766414529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=WzwePHdklsGGhwqqgO87iuWqFCy5GPuHXUbtL7FvFls=; b=H0AvZgb0zzb6HMLIJxg736J4LIfxGLNE5rvpHN5w0jSIM1sw76dvn4SjgiRSvVZu3iBzNz cPqSQ9TTHQq5S7TDPA9VdxuOPqZ9crauXBHShD0xcvn49ALMSG7MNMDId3SsavilyLw+1u GW9cqJB1LG6TdU5e0+wkGU2yrSQNzg4= X-MC-Unique: 4LyG7fQwOs6itKxsqCflJA-1 X-Mimecast-MFC-AGG-ID: 4LyG7fQwOs6itKxsqCflJA_1766414458 From: Elizabeth Ashurov To: qemu-devel@nongnu.org Cc: kkostiuk@redhat.com, Elizabeth Ashurov Subject: [PATCH v3] qga: implement guest-network-get-route for Windows Date: Mon, 22 Dec 2025 16:40:31 +0200 Message-ID: <20251222144031.3115317-1-eashurov@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=eashurov@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 0 X-Spam_score: -0.1 X-Spam_bar: / X-Spam_report: (-0.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URI_TRY_3LD=1.997 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1766414573223158500 Content-Type: text/plain; charset="utf-8" Add Windows implementation of guest-network-get-route command to provide network routing information on Windows guests. Features implemented: - IPv4 and IPv6 route information retrieval using GetIpForwardTable2 - Human-readable interface names via GetAdaptersAddresses - Proper route metrics combining route and interface metrics - MTU information for network interfaces - Support for destination, gateway, mask, and metric fields for IPv4 - Support for destination, nexthop, and desprefixlen fields for IPv6 Implementation uses modern Windows IP Helper API (GetIpForwardTable2, GetIfEntry2). Signed-off-by: Elizabeth Ashurov --- qga/commands-win32.c | 172 +++++++++++++++++++++++++++++++++++++++++++ qga/qapi-schema.json | 11 +-- 2 files changed, 178 insertions(+), 5 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index acc2c11589..577e00dc65 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -2592,3 +2592,175 @@ GuestLoadAverage *qmp_guest_get_load(Error **errp) ret->load15m =3D load_avg_15m; return ret; } + +/* Helper function to get interface name with fallbacks */ +static char *get_interface_name(const MIB_IPFORWARD_ROW2 *row, + IP_ADAPTER_ADDRESSES *adptr_addrs) +{ + IP_ADAPTER_ADDRESSES *adapter; + char *iface_name =3D NULL; + + if (adptr_addrs) { + for (adapter =3D adptr_addrs; adapter; adapter =3D adapter->Next) { + if (adapter->Luid.Value =3D=3D row->InterfaceLuid.Value) { + iface_name =3D guest_wctomb_dup(adapter->FriendlyName); + break; + } + } + } + + if (!iface_name) { + iface_name =3D g_strdup_printf("if%lu", row->InterfaceIndex); + } + + return iface_name; +} + +/* Helper function to fill IPv4 route information */ +static void fill_ipv4_route_info(GuestNetworkRoute *route, + const MIB_IPFORWARD_ROW2 *row) +{ + struct sockaddr_in *addr_in; + char addr_str[INET_ADDRSTRLEN]; + + addr_in =3D (struct sockaddr_in *)&row->DestinationPrefix.Prefix; + if (inet_ntop(AF_INET, &addr_in->sin_addr, addr_str, INET_ADDRSTRLEN))= { + route->destination =3D g_strdup(addr_str); + } else { + route->destination =3D g_strdup("0.0.0.0"); + } + + if (row->DestinationPrefix.PrefixLength =3D=3D 0) { + route->mask =3D g_strdup("0.0.0.0"); + } else { + uint32_t mask =3D htonl(0xFFFFFFFF << (32 - + row->DestinationPrefix.PrefixLength)); + struct in_addr mask_addr =3D { .s_addr =3D mask }; + route->mask =3D g_strdup(inet_ntoa(mask_addr)); + } + + addr_in =3D (struct sockaddr_in *)&row->NextHop; + if (inet_ntop(AF_INET, &addr_in->sin_addr, addr_str, INET_ADDRSTRLEN))= { + route->gateway =3D g_strdup(addr_str); + } else { + route->gateway =3D g_strdup("0.0.0.0"); + } + + route->version =3D 4; +} + +/* Helper function to fill IPv6 route information */ +static void fill_ipv6_route_info(GuestNetworkRoute *route, + const MIB_IPFORWARD_ROW2 *row) +{ + struct sockaddr_in6 *addr_in6; + char addr_str[INET6_ADDRSTRLEN]; + + addr_in6 =3D (struct sockaddr_in6 *)&row->DestinationPrefix.Prefix; + if (inet_ntop(AF_INET6, &addr_in6->sin6_addr, addr_str, INET6_ADDRSTRL= EN)) { + route->destination =3D g_strdup(addr_str); + } else { + route->destination =3D g_strdup("::"); + } + + addr_in6 =3D (struct sockaddr_in6 *)&row->NextHop; + if (inet_ntop(AF_INET6, &addr_in6->sin6_addr, addr_str, INET6_ADDRSTRL= EN)) { + route->nexthop =3D g_strdup(addr_str); + } else { + route->nexthop =3D g_strdup("::"); + } + + route->desprefixlen =3D g_strdup_printf("%u", + row->DestinationPrefix.PrefixLen= gth); + route->version =3D 6; +} + +GuestNetworkRouteList *qmp_guest_network_get_route(Error **errp) +{ + GuestNetworkRouteList *head =3D NULL, **tail =3D &head; + PMIB_IPFORWARD_TABLE2 pIpForwardTable2; + DWORD dwRetVal =3D 0; + DWORD i; + PMIB_IPFORWARD_ROW2 row; + GuestNetworkRoute *route; + IP_ADAPTER_ADDRESSES *adptr_addrs; + MIB_IPINTERFACE_ROW ipifrow; + MIB_IF_ROW2 ifrow2; + Error *local_err =3D NULL; + GHashTable *interface_metric_cache; + + dwRetVal =3D GetIpForwardTable2(AF_UNSPEC, &pIpForwardTable2); + if (dwRetVal !=3D NO_ERROR) { + error_setg_win32(errp, dwRetVal, "failed to get IP routes"); + return NULL; + } + + interface_metric_cache =3D g_hash_table_new_full(g_str_hash, g_str_equ= al, + g_free, NULL); + adptr_addrs =3D guest_get_adapters_addresses(&local_err); + if (local_err) { + error_free(local_err); + adptr_addrs =3D NULL; + } + + for (i =3D 0; i < pIpForwardTable2->NumEntries; i++) { + row =3D &pIpForwardTable2->Table[i]; + + if (row->DestinationPrefix.Prefix.si_family =3D=3D AF_INET) { + route =3D g_new0(GuestNetworkRoute, 1); + fill_ipv4_route_info(route, row); + } else if (row->DestinationPrefix.Prefix.si_family =3D=3D AF_INET6= ) { + route =3D g_new0(GuestNetworkRoute, 1); + fill_ipv6_route_info(route, row); + } else { + continue; + } + + route->iface =3D get_interface_name(row, adptr_addrs); + + /* + * Get interface metric for combined route metric calculation. + * Windows calculates effective route metric as route + interface = metric. + * This matches the values displayed by Windows 'route print' comm= and. + * See:=20 + * https://learn.microsoft.com/en-us/windows/win32/api/netioapi/ns= -netioapi-mib_ipforward_row2 + */ + gchar *luid_key =3D g_strdup_printf("%" G_GUINT64_FORMAT, + row->InterfaceLuid.Value); + gpointer cached_metric =3D g_hash_table_lookup(interface_metric_ca= che, + luid_key); + + if (cached_metric) { + route->metric =3D (int)row->Metric + GPOINTER_TO_INT(cached_me= tric); + g_free(luid_key); + } else { + memset(&ipifrow, 0, sizeof(ipifrow)); + InitializeIpInterfaceEntry(&ipifrow); + ipifrow.InterfaceLuid =3D row->InterfaceLuid; + ipifrow.Family =3D row->DestinationPrefix.Prefix.si_family; + if (GetIpInterfaceEntry(&ipifrow) =3D=3D NO_ERROR) { + g_hash_table_insert(interface_metric_cache, luid_key, + GINT_TO_POINTER(ipifrow.Metric)); + route->metric =3D (int)row->Metric + (int)ipifrow.Metric; + } else { + route->metric =3D (int)row->Metric; + g_free(luid_key); + } + } + + memset(&ifrow2, 0, sizeof(ifrow2)); + ifrow2.InterfaceLuid =3D row->InterfaceLuid; + if (GetIfEntry2(&ifrow2) =3D=3D NO_ERROR) { + route->has_mtu =3D true; + route->mtu =3D (int)ifrow2.Mtu; + } + + QAPI_LIST_APPEND(tail, route); + route =3D NULL; + } + + FreeMibTable(pIpForwardTable2); + g_free(adptr_addrs); + g_hash_table_destroy(interface_metric_cache); + return head; +} diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 5791b49dde..89ea5485cc 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -1879,7 +1879,8 @@ ## # @GuestNetworkRoute: # -# Route information, currently, only linux supported. +# Route information. Supported on Linux (since 9.1) and Windows +# (since 10.3). # # @iface: The destination network or host's egress network interface # in the routing table @@ -1916,7 +1917,7 @@ # # @version: IP version (4 or 6) # -# Since: 9.1 +# Since: 9.1 (Linux only); 10.3 (Windows) ## { 'struct': 'GuestNetworkRoute', 'data': {'iface': 'str', @@ -1936,7 +1937,7 @@ '*nexthop': 'str', 'version': 'int' }, - 'if': 'CONFIG_LINUX' } + 'if': { 'any': ['CONFIG_LINUX', 'CONFIG_WIN32'] } } =20 ## # @guest-network-get-route: @@ -1945,9 +1946,9 @@ # # Returns: List of route info of guest. # -# Since: 9.1 +# Since: 9.1 (Linux only); 10.3 (Windows) ## { 'command': 'guest-network-get-route', 'returns': ['GuestNetworkRoute'], - 'if': 'CONFIG_LINUX' + 'if': { 'any': ['CONFIG_LINUX', 'CONFIG_WIN32'] } } --=20 2.51.0