From nobody Tue Feb 10 13:16:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1766327065; cv=none; d=zohomail.com; s=zohoarc; b=LzpiNVVrNQoqFSj7eI2WWvWMWnrPd9tFbzyP4xINjxMTGJlyC1eISGpGDKw8Dx+OtbSHXmC9WsZ8ZvARnBraXwrPuYbL8ii6KZLTHPpBQXJVrBefUNTuHSQFQGYB6wcF1JdpnctWoNEH/kxO2ZFCz2RrTLV4Md10dO8ZuLCYKxc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766327065; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XnmBsO3QIMZqiiQB9gmAI8e116+uSWX1dZXwpIlj+EY=; b=eNMTlou2ONS3BDlca92TKSufSBF7U97fC36tneHBaT0vKHJksu2+HYGyR1qJuzrsb+o4OZ6ITgKi2dk33dvrOAgMOh6MyuoUkamFfLt1es1xGIjvyR7Vug2LiNM+4URi1z1qmIYv6Bi8pOC4e10+eg9oh6oGiQv543ozbKl8a1I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766327065798414.1514174226795; Sun, 21 Dec 2025 06:24:25 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vXKLQ-00017G-Ky; Sun, 21 Dec 2025 09:23:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vXKLP-000170-7V for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:35 -0500 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vXKLN-0001IL-OH for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:34 -0500 Received: by mail-pf1-x442.google.com with SMTP id d2e1a72fcca58-7bab7c997eeso3647690b3a.0 for ; Sun, 21 Dec 2025 06:23:33 -0800 (PST) Received: from fedora.. ([118.151.210.82]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48f258sm7590449b3a.47.2025.12.21.06.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 06:23:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766327012; x=1766931812; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XnmBsO3QIMZqiiQB9gmAI8e116+uSWX1dZXwpIlj+EY=; b=Ktje2F3jmHi8sY1G2yMYg8sH4U5hlDT+Ac3/ANX0fUIpWYIr64ZDIMJpNECnUmWR+y xwJkpgKwQMeQXIVb7Yoief7FYFe4D7KUaNsqsS4a0gXnHziS5hQgOZLMjcuRgEzlS1Bv j98DoI6kF80hPIYDQanq7/OjGz/QhApUXhGX28tB8EepHlZ9BzZLtsS06iRNdnIAKpqm eZI6jIkfek2xECmiGFWIy8sFYn5Ch7FD9vDUJSj9MXLpuIyfsVpgukd/XlA2an+P//5g WTPkI9xvH5TdUoOt8w9wJc1/n0Xv3eM1aiV9MIjkTh7CrT+KF5SF/Lem0NCBjsoDlu6J ux7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766327012; x=1766931812; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XnmBsO3QIMZqiiQB9gmAI8e116+uSWX1dZXwpIlj+EY=; b=p/6s3AzFGoVE0GxCBwhH8zhGjl6gsI8ewQ4NrO5WVPaggPPf8Li+dvPjG8GnesReaB xR9+ddOBPuZVvCU9QuLKNLgFAVompcVk6Fm0RIjpl91T04E4S4ZlyPJmKK+yFNJAzB5e wXWKNMzkym0WXi6EG36Fk9OUUJpwPfbzj/j0NLdqDs4l6G5Wu206XVx+siT54WoNVyGh jb5SI8dH1d5edmvC3CLRUjqfiUc0rg8pzL6KolnPT3e8eoBdhOBNkWsQGoGJE0eLH6Gm YyahPERTYOjJwJN0264ydiFa56q1SJ1MjiC20cU8NzkuvlMOaaDEwxrjzKUkKdAbDSaJ wzhQ== X-Gm-Message-State: AOJu0YynNzJh31ei0Zrm+oCUaMX9O9L/ELEoos2gS0TKUm6RE/xGVaui cpHNRldmz9cwfJH5pn10KhU9KIBoT2tNDhT9jJ8H4N+Da9Tc1HFWFUsqN9Pf04jej4Y= X-Gm-Gg: AY/fxX71ByxfdEWaK3n4ZKrx58P/UvaNhyn+1mRHNbzrIRcUHiLqMHsSdEXPly3yBZm Cdi/nXzGpUbFLNe/8XY/kpAV3gxwZARPbmIbfVDAO+pUHi0cSXEDaTi3ZToBUDAnACx0/MT6x1V qb0esZs2wVA6G3PnDOOLlH/t1+ZAh5XkjN8BVLviuHPtQ0ws+qUVrWUCdhHCRGw6ZwNmWb3fC43 2/b2Z6MoJzL8XIMPjDISNhh22p7+LDI3lq/8sw07zyzMeAmtcaDVyKjQ6oD5W2udJqDRkeoiz40 Ojih/sQ5kd4tbUJaHIDktkdfOFjI8QC6/UCK/NFsdO8FcW5MG0rPdMcsU84BxuVsTyS0vLAAtTv wM428twQ65FjVK4ZqdHO/8ENyxAcHqTFIqf0H4HuxgsWWjQrAiAkbcF4VmjlJJRNkOITajshzgn Dp0+ipV1UcYB0tUNj6qLM= X-Google-Smtp-Source: AGHT+IH4reJV4fDLeMGNZF8oa8bqfeu4Pv/tHSxdI9Oia7pVXvqJnWfPjQqj/euKCkZ1zm4dh+rFrA== X-Received: by 2002:a05:6a00:ab0d:b0:7ab:78be:3212 with SMTP id d2e1a72fcca58-7ff65d7e735mr6949142b3a.19.1766327011892; Sun, 21 Dec 2025 06:23:31 -0800 (PST) From: Soumyajyotii Ssarkar To: qemu-devel@nongnu.org, deller@gmx.de, sarkarsoumyajyoti23@gmail.com, mark.cave-ayland@ilande.co.uk, richard.henderson@linaro.org Cc: Soumyajyotii Ssarkar Subject: [PATCH 03/10] scsi:ncr710: Fix interrupt related register handing Date: Sun, 21 Dec 2025 19:53:10 +0530 Message-ID: <20251221142317.266293-4-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> References: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=soumyajyotisarkar23@gmail.com; helo=mail-pf1-x442.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1766327068139158501 Content-Type: text/plain; charset="utf-8" - Mask DFE bit in ncr710_update_irq() - Remove manual ISTAT_DIP clearing, let ncr710_update_irq() handle it consistently - Fix SSTAT0 read to clear unconditionally when non zero - Fix SSTAT2 read was returning DSTAT instead - Preserve DFE status bit when clearing DSTAT These fixes ensure proper interrupt signaling and status register behavior during SCSI operations. Signed-off-by: Soumyajyotii Ssarkar Tested-by: Helge Deller --- hw/scsi/ncr53c710.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index ac1ca4cef8..0b7734a129 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -593,7 +593,7 @@ static void ncr710_update_irq(NCR710State *s) { int level =3D 0; =20 - if (s->dstat) { + if (s->dstat & ~NCR710_DSTAT_DFE) { if (s->dstat & s->dien) { level =3D 1; } @@ -1785,7 +1785,6 @@ static uint8_t ncr710_reg_readb(NCR710State *s, int o= ffset) } s->dstat =3D 0; /* Clear all DMA interrupt status bits */ s->dstat |=3D NCR710_DSTAT_DFE; - s->istat &=3D ~NCR710_ISTAT_DIP; ncr710_update_irq(s); =20 if (s->waiting =3D=3D NCR710_WAIT_RESELECT && s->current && @@ -1811,7 +1810,7 @@ static uint8_t ncr710_reg_readb(NCR710State *s, int o= ffset) return ret; case NCR710_SSTAT0_REG: /* SSTAT0 */ ret =3D s->sstat0; - if (s->sstat0 !=3D 0 && !(s->sstat0 & NCR710_SSTAT0_STO)) { + if (s->sstat0 !=3D 0) { s->sstat0 =3D 0; s->istat &=3D ~NCR710_ISTAT_SIP; ncr710_update_irq(s); @@ -1824,14 +1823,7 @@ static uint8_t ncr710_reg_readb(NCR710State *s, int = offset) ret =3D s->sstat0; break; case NCR710_SSTAT2_REG: /* SSTAT2 */ - ret =3D s->dstat; - - if (s->dstat & NCR710_DSTAT_SIR) { - /* SIR bit processing */ - } - s->dstat =3D 0; - s->istat &=3D ~NCR710_ISTAT_DIP; - ncr710_update_irq(s); + ret =3D s->sstat2; break; CASE_GET_REG32(dsa, NCR710_DSA_REG) break; @@ -1902,7 +1894,6 @@ static uint8_t ncr710_reg_readb(NCR710State *s, int o= ffset) if (s->dsps =3D=3D GOOD_STATUS_AFTER_STATUS && (s->dstat & NCR710_DSTAT_SIR)) { s->dstat &=3D ~NCR710_DSTAT_SIR; - s->istat &=3D ~NCR710_ISTAT_DIP; ncr710_update_irq(s); } break; --=20 2.49.0