From nobody Tue Feb 10 11:33:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1766327060; cv=none; d=zohomail.com; s=zohoarc; b=mifdp5xJdV0qdP0SdY8MQtyWpNWfhjFQKSlKUjWgzu3ZM9e5IDCLmQLRPdlU1mKqkmEKcuUFuWAUQqKKy+0FoZcazWCg81GDe1S0Js+//vE+FpwN8fE7MnZN5ingCOB3GdNWsQgOvp7K+tD9kVaILj5Bv571BKIwNjSDZa/txGI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766327060; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BU0OmwMUtLRHOgUboEg+bahM1H9b5s2L6i2Kd1bJBh0=; b=OE8pG9XfpAsjhbNVc1I5lPNVn2QRg4qhVHdi8kouR4UHrL2OhPeiuF/6eaVK9F3JHbWV1ZIU0/asfsI9K8OV+Ry7WeqIskse96DJ/q+vXF3Jk8Pq+QMW6Q0ETQIzDjVYar7Pik6TKLyHaDj59b7G8us88Ce/9Rv0EDbQfSJYilc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766327060595879.9181662043945; Sun, 21 Dec 2025 06:24:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vXKLK-0000yQ-Oi; Sun, 21 Dec 2025 09:23:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vXKLJ-0000xu-7P for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:29 -0500 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vXKLH-0001HH-SJ for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:28 -0500 Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-7f0db5700b2so2925864b3a.0 for ; Sun, 21 Dec 2025 06:23:27 -0800 (PST) Received: from fedora.. ([118.151.210.82]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48f258sm7590449b3a.47.2025.12.21.06.23.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 06:23:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766327006; x=1766931806; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BU0OmwMUtLRHOgUboEg+bahM1H9b5s2L6i2Kd1bJBh0=; b=GfLa3FFW1jO/kJy45MnD2CFmRWIqdLoxWL+0vSuZxGvwSsVT61MPBRGSkQ23aphlu5 +10FKOVBGzZ2bUx2BHMyyC09CWf4ALF897Rd17A4XY9RyxFVrms+0kKzoQXNUnU/F5BQ M/P8xkGOxlXTcjDNkJuONAAdeEEwYpNapf8xG16rfar8L214ojuFJtZpGpkuI/7Cqt/l /aqbIhgoEjU7/nh7E3WPANnfC2EVu/LcHB+Y1jjMJVW6JalTbn95pDZn22yQDXgzh1VU NzhGBtljO5U8cjV0D9QkNkIEGFz8NlUj5XVhYku4zgQhv8lnaUj6peGXo0x0B4AulHwM eW1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766327006; x=1766931806; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BU0OmwMUtLRHOgUboEg+bahM1H9b5s2L6i2Kd1bJBh0=; b=JWnOVL9foYwfi9/UWb5XD0P9sOhy8+3dqfm/iEJ3S5FiLdCFPKsQF8ZS2KcubvQ4SI WJIj9JxLgNltyAxdjERChAVigmSNHjP31G+mnjVELmNpgfzPt7M4EL4CdUb12WYcgiBL 9CMubbKupzafOWXZwvvv9QD9lRX6T7QL90hRgYsSts2conduJPqtmSTbC2T1nrPyzdX3 jM6NNa1Heof8BkVYIBkdHl3woboiYYvfJWSmGgpKMUXcoIlVXrBtL6Bak3kvf0STMOg0 3I9YTV0px+9LJD1fADzIVbelYnaDSBsryDzoQqzYcQk/6wQU8nsSraPYiru6ilhtskT0 vX8g== X-Gm-Message-State: AOJu0Yz5yPlWZ6DfCLOnmr5HMpXcHTgxOqXvrQktCSDCrVED5FRG0G3i iU5/YDns18ARBYhTjDW/7os9/J2whKSIPsak/XE2i25w+JB8iir0r+y9OQdHz//NZ8M= X-Gm-Gg: AY/fxX5cnno5z26daFPuX/1qZU4blH1HoiMu4OODN5c32hagaW8uC/QJXdKyyyLM0jP K/2h4+8d6M/c/dqeTJxqGoKV6qKQv203loNp48uDnLccZInR6+87f+nORZneVUNjjMPxVsca9Na 3t5frmceodyWNm5tF5syfZoN/z5a6Z22aHHVf96uFhibvqxWK68cm/oJ0tdWMIU8MYVaSuuQoxm XdCPpRPhU6LwnzMcVymQqdxnLhDLiQtM5vUxfKsSszb/K1CiytBKfJRcHTNTtLwkfpX27p4ife9 g5GYbCx7huITDvD4YfQZ/s0HPfA+DOryQSRfIQiqOLsj492XnSUpq4ckeIvz7aw/+qQSusP1NB4 vNRnVMhQBO4Vy801+1jkH7BCm+FNALwff0h6+QWuaQlMfXR6iwTIi+MCNl82taYeRLSPjRr/ZTf 6SDNYfvtOV4U+oWXDYEu8= X-Google-Smtp-Source: AGHT+IEb/Mt4ckukNcGnYaloX47doF7ZK15R/8y8FTB6MtG6vJdVxRIxKLbdSH9LkstE+0nLd5tgeg== X-Received: by 2002:a05:6a00:e11:b0:7b8:8d43:fcd1 with SMTP id d2e1a72fcca58-7ff64215183mr6682163b3a.9.1766327006096; Sun, 21 Dec 2025 06:23:26 -0800 (PST) From: Soumyajyotii Ssarkar To: qemu-devel@nongnu.org, deller@gmx.de, sarkarsoumyajyoti23@gmail.com, mark.cave-ayland@ilande.co.uk, richard.henderson@linaro.org Cc: Soumyajyotii Ssarkar Subject: [PATCH 01/10] scsi:ncr710: Add null pointer checks Date: Sun, 21 Dec 2025 19:53:08 +0530 Message-ID: <20251221142317.266293-2-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> References: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=soumyajyotisarkar23@gmail.com; helo=mail-pf1-x443.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1766327061896158500 Content-Type: text/plain; charset="utf-8" Add nullpointer safety checks in ncr710_request_free() & ncr710_request_cancelled() to prevent crashed while handing invalid req structures Added to preventing memory corruption, which occured during device initialization Signed-off-by: Soumyajyotii Ssarkar Reviewed-by: Helge Deller --- hw/scsi/ncr53c710.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index 47a6983491..bab2ea7210 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -737,6 +737,12 @@ static void ncr710_add_msg_byte(NCR710State *s, uint8_= t data) =20 static void ncr710_request_free(NCR710State *s, NCR710Request *p) { + if (!p) { + return; + } + if (p->req && p->req->hba_private =3D=3D p) { + p->req->hba_private =3D NULL; + } if (p =3D=3D s->current) { s->current =3D NULL; } @@ -747,8 +753,11 @@ void ncr710_request_cancelled(SCSIRequest *req) { NCR710State *s =3D ncr710_from_scsi_bus(req->bus); NCR710Request *p =3D (NCR710Request *)req->hba_private; - req->hba_private =3D NULL; - ncr710_request_free(s, p); + if (p) { + req->hba_private =3D NULL; + p->req =3D NULL; + ncr710_request_free(s, p); + } scsi_req_unref(req); } =20 --=20 2.49.0 From nobody Tue Feb 10 11:33:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1766327034; cv=none; d=zohomail.com; s=zohoarc; b=Yn7jXZQqG2O40fjEW58xcm5XrwRlZjd4bgsYHJRQqzFgJGcuYbxdiZNMUJcOvadHvc8Tu9zaWSQTTPz0ZE+2A72QiAScmSsCB8bFiMrBz5Zk1liXBNBAKEpK/9++LHZzNG1V+Pt8UT8BFQsbDIB4bbSH/Q4oDprjDgs54zdCnYg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766327034; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/eB1+81UReGK+nNy3DtIGogDj+pIktgWVFbWnsrHTFk=; b=TTulvrrcYcTqBOKiO3RwsOZXjJoCWQHI+HIg4Agp65PXFVhnm1ezfyq0UVvYQzIPe7udGbYcFR2p5v92AdwQNyKo4XWuoCSohmo0MBVehhC6Kj9qTSTrrrIK8GaY3ju5dW9Bulw9d4foWkC6Hp2Ltcx8r43ibsDpSh4eaXH3Maw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766327034463470.17372543656666; Sun, 21 Dec 2025 06:23:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vXKLO-00015R-6U; Sun, 21 Dec 2025 09:23:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vXKLM-00014o-Cc for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:32 -0500 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vXKLK-0001HW-Sr for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:32 -0500 Received: by mail-pf1-x444.google.com with SMTP id d2e1a72fcca58-7d26a7e5639so3714969b3a.1 for ; Sun, 21 Dec 2025 06:23:30 -0800 (PST) Received: from fedora.. ([118.151.210.82]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48f258sm7590449b3a.47.2025.12.21.06.23.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 06:23:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766327009; x=1766931809; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/eB1+81UReGK+nNy3DtIGogDj+pIktgWVFbWnsrHTFk=; b=OpJDWjI+WK9dgrfYkizVtcPg1MmFMdvauTysG3up6Y20NgESdG4ldz8SyD+KThQ/HB PbK3iBu/bw7UP39aFHm6q9XeTvAAbKFO/kkq764/j56cSxBiVEeUVhKWEAXZw7OmkO6w 51dS3MEufOA49KfSW75rB5JRqMSSksV9hgAwHidLMfPO7GyCRcceNBP60nYai0MB4fDt m9XcMAwSXjooeke7gG4zQIqHmZhrWvMMA0lgRlY/VBUSA2lKnQg75Vhmry+AP9qqwsc6 xfYqMQeeA4wS6pyAoCUhA8yZ0UqnkbViHOYShy+HbDz0SqWoWEQVtc/ftSaTxCeQkjUF CsZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766327009; x=1766931809; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/eB1+81UReGK+nNy3DtIGogDj+pIktgWVFbWnsrHTFk=; b=o8d7IyePiniLrgmJskg25p+8L9NbmC5dbQlU/O1N19sr2OcPSDcIL4S+N7W9Wv4LgS 9smn1cTcwsZWlawqzc1qAkavIAwhkI/kIFjEcDs3Oz1UcI0DkWs05GAEVCq86HkHHMiA pFJy+GaLH1bTdHyd1dvIfP084ApYddtjvAaUTFMy9wSkeSj4BypDcZxnqc9YbiR5wPwa fL41wWLPfgjIYzj+jm8zEWToVzmtHrsG+gotOlUP4rtd0kgnx0OMpWnPaXDJ/ywzMCH/ iTbhNsYZhwAnY3Ckoyee0cQEpUTHCAZY3uA3iPTxDXSUUDaTZ3m7cEXN/L8JVqGFsRbC qsUg== X-Gm-Message-State: AOJu0Yzs92NvmkDUgdNn+LoF7+bU3fnCOH5mThECtL6PXYSqYYVFRcbU qb8urGrspHqc+5h3UShW7AFAs9B8Z0Fug6bdw3OMaUjxRNyM1gwcM5bM0h4I0MhN7O0= X-Gm-Gg: AY/fxX46EceYzDLgLTK7xxYSHlHOlppyYOkzwK4e6CmayxCqVT2AMGBWpeTBv1CsX1F hxr+tgUK8H/KL7TIJhaqjIUgQr021LO5vtyrGJ2saIVpaZL/mdabG8vBR2151O67Zk6//QWJ8+e UQWDVDosVmX+DISWvcJ6r9xtbp79f+h5aQq1qao5BizrkrENyEbXEFQjIiYiDArP7LogLVvbDtc cdgTVZs/WOrs0geKsHDvTAJOp970XGFZRsD45t0RhSXVBXpCbzFYtaSsM0vRk9RI9nJDo3qSt1l HAf8y0eaLDzIqLrCjmvYzwbcifQKwo9RPxEDvc8hHP4n2XMaMA7YJErYWgttz6x6WgRXYQsStFY em7mgQVfCZXCtsvibz0bnAgy9h4gkHos1JnOuiQ+Awdnezfh5+mPcmnAFHPaKlsrRPTj7Z4wjaP oPwtOLZN/Rs96QdVHU0cs= X-Google-Smtp-Source: AGHT+IHIJ4YvEiBn5LmDpQm+AqLliIJwtyflmTS9qRehiboqFUAiYm+zk5NG05kSd0rWPOEIpW2RYA== X-Received: by 2002:a05:6a00:b60c:b0:7e8:450c:61ba with SMTP id d2e1a72fcca58-7ff6607e4a5mr8823881b3a.42.1766327008973; Sun, 21 Dec 2025 06:23:28 -0800 (PST) From: Soumyajyotii Ssarkar To: qemu-devel@nongnu.org, deller@gmx.de, sarkarsoumyajyoti23@gmail.com, mark.cave-ayland@ilande.co.uk, richard.henderson@linaro.org Cc: Soumyajyotii Ssarkar Subject: [PATCH 02/10] scsi:ncr710: Fix use after free in command_complete Date: Sun, 21 Dec 2025 19:53:09 +0530 Message-ID: <20251221142317.266293-3-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> References: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::444; envelope-from=soumyajyotisarkar23@gmail.com; helo=mail-pf1-x444.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1766327035851158500 Content-Type: text/plain; charset="utf-8" Add proper hba_private pointer cleanup in ncr710_command_complete. This prevents use after free errors from occuring. This was causing memory corruption in NetBSD device initialization when commands complete and the request structures were freed while still being referenced. Signed-off-by: Soumyajyotii Ssarkar Reviewed-by: Helge Deller --- hw/scsi/ncr53c710.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index bab2ea7210..ac1ca4cef8 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -798,7 +798,13 @@ void ncr710_command_complete(SCSIRequest *req, size_t = resid) =20 ncr710_set_phase(s, PHASE_ST); =20 - if (req->hba_private =3D=3D s->current) { + if (p) { + req->hba_private =3D NULL; + if (p =3D=3D s->current) { + p->req =3D NULL; + } else { + ncr710_request_free(s, p); + } scsi_req_unref(req); } =20 --=20 2.49.0 From nobody Tue Feb 10 11:33:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1766327065; cv=none; d=zohomail.com; s=zohoarc; b=LzpiNVVrNQoqFSj7eI2WWvWMWnrPd9tFbzyP4xINjxMTGJlyC1eISGpGDKw8Dx+OtbSHXmC9WsZ8ZvARnBraXwrPuYbL8ii6KZLTHPpBQXJVrBefUNTuHSQFQGYB6wcF1JdpnctWoNEH/kxO2ZFCz2RrTLV4Md10dO8ZuLCYKxc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766327065; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XnmBsO3QIMZqiiQB9gmAI8e116+uSWX1dZXwpIlj+EY=; b=eNMTlou2ONS3BDlca92TKSufSBF7U97fC36tneHBaT0vKHJksu2+HYGyR1qJuzrsb+o4OZ6ITgKi2dk33dvrOAgMOh6MyuoUkamFfLt1es1xGIjvyR7Vug2LiNM+4URi1z1qmIYv6Bi8pOC4e10+eg9oh6oGiQv543ozbKl8a1I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766327065798414.1514174226795; Sun, 21 Dec 2025 06:24:25 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vXKLQ-00017G-Ky; Sun, 21 Dec 2025 09:23:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vXKLP-000170-7V for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:35 -0500 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vXKLN-0001IL-OH for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:34 -0500 Received: by mail-pf1-x442.google.com with SMTP id d2e1a72fcca58-7bab7c997eeso3647690b3a.0 for ; Sun, 21 Dec 2025 06:23:33 -0800 (PST) Received: from fedora.. ([118.151.210.82]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48f258sm7590449b3a.47.2025.12.21.06.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 06:23:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766327012; x=1766931812; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XnmBsO3QIMZqiiQB9gmAI8e116+uSWX1dZXwpIlj+EY=; b=Ktje2F3jmHi8sY1G2yMYg8sH4U5hlDT+Ac3/ANX0fUIpWYIr64ZDIMJpNECnUmWR+y xwJkpgKwQMeQXIVb7Yoief7FYFe4D7KUaNsqsS4a0gXnHziS5hQgOZLMjcuRgEzlS1Bv j98DoI6kF80hPIYDQanq7/OjGz/QhApUXhGX28tB8EepHlZ9BzZLtsS06iRNdnIAKpqm eZI6jIkfek2xECmiGFWIy8sFYn5Ch7FD9vDUJSj9MXLpuIyfsVpgukd/XlA2an+P//5g WTPkI9xvH5TdUoOt8w9wJc1/n0Xv3eM1aiV9MIjkTh7CrT+KF5SF/Lem0NCBjsoDlu6J ux7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766327012; x=1766931812; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XnmBsO3QIMZqiiQB9gmAI8e116+uSWX1dZXwpIlj+EY=; b=p/6s3AzFGoVE0GxCBwhH8zhGjl6gsI8ewQ4NrO5WVPaggPPf8Li+dvPjG8GnesReaB xR9+ddOBPuZVvCU9QuLKNLgFAVompcVk6Fm0RIjpl91T04E4S4ZlyPJmKK+yFNJAzB5e wXWKNMzkym0WXi6EG36Fk9OUUJpwPfbzj/j0NLdqDs4l6G5Wu206XVx+siT54WoNVyGh jb5SI8dH1d5edmvC3CLRUjqfiUc0rg8pzL6KolnPT3e8eoBdhOBNkWsQGoGJE0eLH6Gm YyahPERTYOjJwJN0264ydiFa56q1SJ1MjiC20cU8NzkuvlMOaaDEwxrjzKUkKdAbDSaJ wzhQ== X-Gm-Message-State: AOJu0YynNzJh31ei0Zrm+oCUaMX9O9L/ELEoos2gS0TKUm6RE/xGVaui cpHNRldmz9cwfJH5pn10KhU9KIBoT2tNDhT9jJ8H4N+Da9Tc1HFWFUsqN9Pf04jej4Y= X-Gm-Gg: AY/fxX71ByxfdEWaK3n4ZKrx58P/UvaNhyn+1mRHNbzrIRcUHiLqMHsSdEXPly3yBZm Cdi/nXzGpUbFLNe/8XY/kpAV3gxwZARPbmIbfVDAO+pUHi0cSXEDaTi3ZToBUDAnACx0/MT6x1V qb0esZs2wVA6G3PnDOOLlH/t1+ZAh5XkjN8BVLviuHPtQ0ws+qUVrWUCdhHCRGw6ZwNmWb3fC43 2/b2Z6MoJzL8XIMPjDISNhh22p7+LDI3lq/8sw07zyzMeAmtcaDVyKjQ6oD5W2udJqDRkeoiz40 Ojih/sQ5kd4tbUJaHIDktkdfOFjI8QC6/UCK/NFsdO8FcW5MG0rPdMcsU84BxuVsTyS0vLAAtTv wM428twQ65FjVK4ZqdHO/8ENyxAcHqTFIqf0H4HuxgsWWjQrAiAkbcF4VmjlJJRNkOITajshzgn Dp0+ipV1UcYB0tUNj6qLM= X-Google-Smtp-Source: AGHT+IH4reJV4fDLeMGNZF8oa8bqfeu4Pv/tHSxdI9Oia7pVXvqJnWfPjQqj/euKCkZ1zm4dh+rFrA== X-Received: by 2002:a05:6a00:ab0d:b0:7ab:78be:3212 with SMTP id d2e1a72fcca58-7ff65d7e735mr6949142b3a.19.1766327011892; Sun, 21 Dec 2025 06:23:31 -0800 (PST) From: Soumyajyotii Ssarkar To: qemu-devel@nongnu.org, deller@gmx.de, sarkarsoumyajyoti23@gmail.com, mark.cave-ayland@ilande.co.uk, richard.henderson@linaro.org Cc: Soumyajyotii Ssarkar Subject: [PATCH 03/10] scsi:ncr710: Fix interrupt related register handing Date: Sun, 21 Dec 2025 19:53:10 +0530 Message-ID: <20251221142317.266293-4-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> References: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=soumyajyotisarkar23@gmail.com; helo=mail-pf1-x442.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1766327068139158501 Content-Type: text/plain; charset="utf-8" - Mask DFE bit in ncr710_update_irq() - Remove manual ISTAT_DIP clearing, let ncr710_update_irq() handle it consistently - Fix SSTAT0 read to clear unconditionally when non zero - Fix SSTAT2 read was returning DSTAT instead - Preserve DFE status bit when clearing DSTAT These fixes ensure proper interrupt signaling and status register behavior during SCSI operations. Signed-off-by: Soumyajyotii Ssarkar Tested-by: Helge Deller --- hw/scsi/ncr53c710.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index ac1ca4cef8..0b7734a129 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -593,7 +593,7 @@ static void ncr710_update_irq(NCR710State *s) { int level =3D 0; =20 - if (s->dstat) { + if (s->dstat & ~NCR710_DSTAT_DFE) { if (s->dstat & s->dien) { level =3D 1; } @@ -1785,7 +1785,6 @@ static uint8_t ncr710_reg_readb(NCR710State *s, int o= ffset) } s->dstat =3D 0; /* Clear all DMA interrupt status bits */ s->dstat |=3D NCR710_DSTAT_DFE; - s->istat &=3D ~NCR710_ISTAT_DIP; ncr710_update_irq(s); =20 if (s->waiting =3D=3D NCR710_WAIT_RESELECT && s->current && @@ -1811,7 +1810,7 @@ static uint8_t ncr710_reg_readb(NCR710State *s, int o= ffset) return ret; case NCR710_SSTAT0_REG: /* SSTAT0 */ ret =3D s->sstat0; - if (s->sstat0 !=3D 0 && !(s->sstat0 & NCR710_SSTAT0_STO)) { + if (s->sstat0 !=3D 0) { s->sstat0 =3D 0; s->istat &=3D ~NCR710_ISTAT_SIP; ncr710_update_irq(s); @@ -1824,14 +1823,7 @@ static uint8_t ncr710_reg_readb(NCR710State *s, int = offset) ret =3D s->sstat0; break; case NCR710_SSTAT2_REG: /* SSTAT2 */ - ret =3D s->dstat; - - if (s->dstat & NCR710_DSTAT_SIR) { - /* SIR bit processing */ - } - s->dstat =3D 0; - s->istat &=3D ~NCR710_ISTAT_DIP; - ncr710_update_irq(s); + ret =3D s->sstat2; break; CASE_GET_REG32(dsa, NCR710_DSA_REG) break; @@ -1902,7 +1894,6 @@ static uint8_t ncr710_reg_readb(NCR710State *s, int o= ffset) if (s->dsps =3D=3D GOOD_STATUS_AFTER_STATUS && (s->dstat & NCR710_DSTAT_SIR)) { s->dstat &=3D ~NCR710_DSTAT_SIR; - s->istat &=3D ~NCR710_ISTAT_DIP; ncr710_update_irq(s); } break; --=20 2.49.0 From nobody Tue Feb 10 11:33:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1766327038; cv=none; d=zohomail.com; s=zohoarc; b=CirwiYV/lFRNzMsXUMwubSYR/NJzUcTXDvWNqyVUFC7sWdLdLbNu122YJYXMraJ7CqNGtx4NrjTutHiWCJ1QhTZUCa4P2pFSQEykvDL3rArht0T3CktfCo0QdOcMOHU3uw7Ma58aQWNMXLNV6y2sO/dd2r8efc7FG3BNqDVQ+8k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766327038; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dG0Amvc2GaV3WxbJOBLx9QPvcppOVvNkAdmdXpA0Nyk=; b=SKUCKTSTpj676z9sRSJq9YYc9xBJQX/9yw3UTe0WlLoI1Prx1LeDdBTE5uuTNZ6TEgEnh5TV/LeWJzHuUq2z8LtJ85A0hSTdQjeOwhrfVPfj2MCzvV4tWBUfWucqn4fRa1zWmCYUnxc0Egjt+J/2uKBPDwkzdgCH5YGypT03aMI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766327038604748.5285608428223; Sun, 21 Dec 2025 06:23:58 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vXKLU-0001DF-Un; Sun, 21 Dec 2025 09:23:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vXKLS-0001Bn-Nf for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:38 -0500 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vXKLR-0001Ii-AO for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:38 -0500 Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-7fbbb84f034so2390663b3a.0 for ; Sun, 21 Dec 2025 06:23:36 -0800 (PST) Received: from fedora.. ([118.151.210.82]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48f258sm7590449b3a.47.2025.12.21.06.23.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 06:23:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766327016; x=1766931816; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dG0Amvc2GaV3WxbJOBLx9QPvcppOVvNkAdmdXpA0Nyk=; b=WDLwNhsOYIBO6frA4q+/itGRwkirhN3aADw2WyeGWXHUzOZIYy0sOpWluDbWDXdOlJ C/NoyeC3ROSrGuGStWj6Yqp216YPp57uYsqs1hOfoPohILEPNSBxWkcUd2GyJdAxnZ9p aQb4WKPo4KhtXu01YMHacpwwuuBEe0MG1s2v0uC+/H6D3PL0QO2UlLD2e7DMzhSkYg3C 81NpHRBqZVrEYc3E/UbR4ngC6k0F2OlGrN531ov7rI3q4meUmeQZN5gAOzjtoehyZUIw glFjelzxD21dk4ekEfnvBojPMSbAgrO9/B2kvro5mmRhD6XN3uJREwO/iQHWj7bP/LpN 7Y0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766327016; x=1766931816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dG0Amvc2GaV3WxbJOBLx9QPvcppOVvNkAdmdXpA0Nyk=; b=Km6neG6f8Bcbsoq70i7VSD1MESS8QWDXL5diryu/z4EJ2chEoq3abuBnBjbS6JW7GF FRrlf+7tNmC4HXHL1dMIDC1zn0FZaIns4ojB8/YbRH4zm6OnXywR/2+kk2D7GgeuyG1f pkSoSGLLfpQoMty1YkVIb4kvkwTy1Ud7H9+a8OcRnDD+UUotykdNrv4wgQARSagsM1tU /KB/L+AGfrSARZ4JNOnzLxKtja3CBEEB9sZtwIjntBkgIik4BriC0xZ81gU0aYCQplez VZK3BxfKnCsOzy85xT5qBOB8qVxCWrTw28QwEdLnKuDZtMvtsyMu92a6me9Kh4blHA8k mmwg== X-Gm-Message-State: AOJu0YzYdsbIqii2nRRteJhsUAr1yTbdnw9tMiV1f7TAXvhBejX8/063 XZRd0sMrVz3+b9FjKcwgpu0AtAG6Ily3heOVlyK7orcFwHSuFh1cW+EaXZFOTrsh4hQ= X-Gm-Gg: AY/fxX7iR8Jo6waF8/MS2fvnewC81FS56wP7Z4RtIG/e9b4wuoAEMwaw6nJSTSXcBHh la7CkgTlyYoN1uSr7jBtOAnlbDjodUVpSS5HU4JqZtjI7xHIpbqpN9OiOmWc/oau2miqkHNI2rK tSxR68U+g/44s8GE2RBWAI2RAQJn65+zpdYqKoRZVqV9WbbmuhJqUxmUkfor5kCWVdUQ6d4uqs/ idLkPfVuhNpHYdWWUcWo+/HRPgwPvov0+SsOB4Kf8LDZ3pCJwQEzHZ1VfUI+TfwNWRGysU1BktF BOERUdFrCxyaLUOITq9r+3NkJzN8vn/O73QAIx+YHidW5SvGio3mZo2np91dVRxtUiT9SkuIx/x FxH94WkRh2Y3ruJuNO7P+PhuFihTPRJh32IpePkDV1+kj60afNJzHmTCel+tgyZK1FaeqVJ6E4H bsk+5a3p15vU7NhEGLGns= X-Google-Smtp-Source: AGHT+IED4Ncpo7Kw2eNcQW3k+JW8ba6mTgULtCIVBkBnXn1AioMPUgQYq2c5P8SHeUgzNaQV9rzDYQ== X-Received: by 2002:a05:6a00:90a2:b0:7e8:4471:8ce with SMTP id d2e1a72fcca58-7ff6687188amr7091817b3a.47.1766327015728; Sun, 21 Dec 2025 06:23:35 -0800 (PST) From: Soumyajyotii Ssarkar To: qemu-devel@nongnu.org, deller@gmx.de, sarkarsoumyajyoti23@gmail.com, mark.cave-ayland@ilande.co.uk, richard.henderson@linaro.org Cc: Soumyajyotii Ssarkar Subject: [PATCH 04/10] scsi:ncr710: Fix DMA State machine and flow control Date: Sun, 21 Dec 2025 19:53:11 +0530 Message-ID: <20251221142317.266293-5-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> References: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=soumyajyotisarkar23@gmail.com; helo=mail-pf1-x443.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1766327039868158500 Content-Type: text/plain; charset="utf-8" Set waiting state and return after scsi_req_continue() to prevent re entrancy when DMA transfer completes. Signed-off-by: Soumyajyotii Ssarkar --- hw/scsi/ncr53c710.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index 0b7734a129..e17d1f3fb8 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -718,7 +718,9 @@ static void ncr710_do_dma(NCR710State *s, int out) if (s->current->dma_len =3D=3D 0) { s->current->dma_buf =3D NULL; s->current->pending =3D 0; + s->waiting =3D NCR710_WAIT_DMA; scsi_req_continue(s->current->req); + return; } else { s->current->dma_buf +=3D count; s->waiting =3D NCR710_WAIT_NONE; --=20 2.49.0 From nobody Tue Feb 10 11:33:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1766327090; cv=none; d=zohomail.com; s=zohoarc; b=cEjy20wg8SHOI4+5iNLHd0SueCiU+y3kgwBaMCRa8NMa0phzSgaaJzih8NzeXz6txn7KHH+awsnMoEf90Umi34RNSLqdR+xcj0ZDp+y1r406BhteJwL+W8B17C2PCJphogfb4VvOKz37x+Sq+/B0ksEJDgAsYJrNqrCwfh4k0OE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766327090; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BDk7QJZD5gFp77T+M8deaWWFziy7QSSXS87FreId1bQ=; b=OK0FiaW/wCFWV2PX25WLqm7BcxvyzW6UszQxZv6n3WtpaNJe71X6roAfk6YPR98ZXnq4L2JG36oeCgvXduZo5iUBPW5rahOyy1A1co/4fRM4SDU2O3gFLoXTdHAthrGyLXtl5TNKq91sLPtFhNDxySdDpjkODcZFwFj2syu1xd0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766327090090762.0489058776656; Sun, 21 Dec 2025 06:24:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vXKLn-0001In-Nd; Sun, 21 Dec 2025 09:24:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vXKLV-0001DZ-Uk for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:42 -0500 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vXKLU-0001JB-DC for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:41 -0500 Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-7bab7c997eeso3647736b3a.0 for ; Sun, 21 Dec 2025 06:23:39 -0800 (PST) Received: from fedora.. ([118.151.210.82]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48f258sm7590449b3a.47.2025.12.21.06.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 06:23:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766327019; x=1766931819; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BDk7QJZD5gFp77T+M8deaWWFziy7QSSXS87FreId1bQ=; b=Cvfvxn+u66vdlpBi6nVD7q7/RLt4GJHzr6+R+H0kM/8J7mqNrUN0VwEt05HXZ8OIxD xyFjj338eEyZGpT8dNgHr2oycLZKG3T4OsCGhcgYZ7vRpuru3Vc4Lk7+V+3h3ksWq8rt l4esM07R3qSZjoq9rc09lPoq/frewsEF0UtYWO6MYMB6Kcl3MOhCl9fxtreqX+dwmomU 1zc7qFU+81yqwBnQM5qv289Mdyafj2fjBvXHbd4TTy1NDea0OsVG62MEzF1QDFyUudBH DU/pzws0z5XysonvKM4OXogg1pCsaPjzCLIoDD6fJfPoyE7U+7nnBcdSjbUVx144NH6F IBFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766327019; x=1766931819; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BDk7QJZD5gFp77T+M8deaWWFziy7QSSXS87FreId1bQ=; b=wfUU9p7N/y5Tv3FpB1zZCuD3CSD1AlwudxNJkwvMHsRM85oJTUCwEd1xsLXuPlR6EC b01MMnymmMTcto5UlGZJeaxrz7sZJxnSYxgcah4Xi1LTEpIEWxc2YVWbwMa9uJB4Ik5C nTvu6slu+XqvzbwIi1jIEA2+Dwv4aBitcFzrlZztDzFxCWSsmVAyaGxkkzaN+NU9KV/K ReXVUpPlvTOOopZQ+jS2MsJWvk0jP39BUN2Dz6R0P+/gX0Uq56ADAlGTn0RKPrlvSiSh joJzO/JrETYByyHvWHdXosVdB4XjuqVCPou3PuKPuYJ6mtTtGx1EABoKnUVktDcXDzio AwOA== X-Gm-Message-State: AOJu0YxkB7ejhVA1YCuXyuxzUFrNgsaXQ7wAfzpM3JpIol+eI+fK2D84 wsS6wR6rosbjgFkfTXmgAsoqctdWfiZActii+AMkVdT8qQF3jvjkNfWA813YSpj8uo8= X-Gm-Gg: AY/fxX6uwswiLNJpUb0TeFXNgA4zckYFnT0V20zk1k/fdn2C0jMk4ekV46opfd+Ksfi 4Zf95Wktc4BGolGGZyWur9jmgYrybLVJXwv54qEeMuTtMRRj0OMnRzKz8FYfiKHY8f4fAIvs2ks eZzHeX+bzV2CosHjdDBj+QJDLcgW9PB2mKmEO7va3XkdZRZfXzF+bbTFa68fqzctZitqJ/rcqKb JExcR6x4oxVPggDK/fcEnKXWxUZMFFF38Ke90pB6b+iEmNPzMtOo79PCJtiLXyRsNU6zuvRW+0f llYvCFNSL50s+w6NckVvtVpBFHHJRYhSut9+1DRQ9m8z5Z3Fmj/GOzNqlIANSgC+nvrSShbqdqA WQXR/Jp7IpdyTmWD19p1PU5MgimG6FHtKkq8GcA6NZRtIVs+rO+UOq3P3jB3inzH8qCnaxUU4Xc /EMb/NRVGYrAOmLq14zic= X-Google-Smtp-Source: AGHT+IHi37o07xVQdlhwAZ97OE06AN+pUUUbXSjS8/8yQeyvN53L8W7DQ/DLI8mulNfNXvty8kwsPQ== X-Received: by 2002:a05:6a00:8017:b0:7e8:4471:ae68 with SMTP id d2e1a72fcca58-7ff67966c94mr6390727b3a.52.1766327018641; Sun, 21 Dec 2025 06:23:38 -0800 (PST) From: Soumyajyotii Ssarkar To: qemu-devel@nongnu.org, deller@gmx.de, sarkarsoumyajyoti23@gmail.com, mark.cave-ayland@ilande.co.uk, richard.henderson@linaro.org Cc: Soumyajyotii Ssarkar Subject: [PATCH 05/10] scsi:ncr710: Fix table indirect addressing endianness Date: Sun, 21 Dec 2025 19:53:12 +0530 Message-ID: <20251221142317.266293-6-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> References: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=soumyajyotisarkar23@gmail.com; helo=mail-pf1-x443.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1766327091990158500 Content-Type: text/plain; charset="utf-8" Correct the endianness conversion for table indirect addressing Now we use be32_to_cpu() instead of cpu_to_le32() This fix descriptor table parsing when using indirect addressing modes in SCRIPTS Signed-off-by: Soumyajyotii Ssarkar --- hw/scsi/ncr53c710.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index e17d1f3fb8..4b42fab754 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -1355,8 +1355,8 @@ again: offset =3D sextract32(addr, 0, 24); ncr710_dma_read(s, s->dsa + offset, buf, 8); /* byte count is stored in bits 0:23 only */ - s->dbc =3D cpu_to_le32(buf[0]) & 0xffffff; - addr =3D cpu_to_le32(buf[1]); + s->dbc =3D be32_to_cpu(buf[0]) & 0xffffff; + addr =3D be32_to_cpu(buf[1]); } /* Check phase match for block move instructions */ if ((s->sstat2 & PHASE_MASK) !=3D ((insn >> 24) & 7)) { --=20 2.49.0 From nobody Tue Feb 10 11:33:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1766327119; cv=none; d=zohomail.com; s=zohoarc; b=A0w+U9aOt6nRhZbGECzuDllVrw8bqpuGRMbr+Qs0OAHviR0ACg/EMRES0k62V8uzVOqjUOzBk6KcwayxQHpux9Il19LQb66LQMlSPUgUNuCgaLi5ga63LQBrodJI23L2XwfRfsPpcOHxDA9kyS76+HY2CMoUgKYG1cvy4SOENGQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766327119; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XdPuLFFZ3D4mmgZaO7d+HZBZoL5op64qzVNSL0sChe4=; b=OGZ6jCovtS/yg5/I7l02maW3bDzdkG2JLdFCJZ2DqxTY8WxPHkukY4SeUk4OeYuXNb2nDY9TEdH8zFQMOmAuIEOBmK0hUM7WBX7kCjvkzx1AP9NxmssuN5UIyEChnUjQAY46aN7i9NxzUE8RayPYACD7ld/f4sUyAEbw71/XjDw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766327119950549.4586462057978; Sun, 21 Dec 2025 06:25:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vXKM7-0001T2-3Q; Sun, 21 Dec 2025 09:24:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vXKLY-0001IZ-Ki for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:48 -0500 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vXKLX-0001JP-6a for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:44 -0500 Received: by mail-pf1-x444.google.com with SMTP id d2e1a72fcca58-7fbbb84f034so2390688b3a.0 for ; Sun, 21 Dec 2025 06:23:42 -0800 (PST) Received: from fedora.. ([118.151.210.82]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48f258sm7590449b3a.47.2025.12.21.06.23.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 06:23:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766327021; x=1766931821; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XdPuLFFZ3D4mmgZaO7d+HZBZoL5op64qzVNSL0sChe4=; b=CBISeN9A9j5z91qrwGP4+j/5+NF520twVOkjpR16f2PRQoy1oz29ozKreQHajlIlBR 9ci5pzcVonqr1muFXAP9H0AqhrfO3grYP/cKnhz8jXDSqxL34gAHucRRV7p+iL8mUyxh hsbnYIGjYbvHfjRVMktdDH7n8Br5yTnq036CemldiahB/XR5q6EsguwMg9YQ5ovqQA08 V6WMGcXQuVkbfkexAhkXPz7/ToroWbZz/MJ+3CosnJ3WffoMe9+W55OQy0FjqPVylcvT MGKFoI+2AnnSZINxDUUb/qBrPq4Kv1IN7QZaTvn5lYVLTOccNnfJix6x7kNgbAkMZhLX OgQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766327021; x=1766931821; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XdPuLFFZ3D4mmgZaO7d+HZBZoL5op64qzVNSL0sChe4=; b=iCOjMONayg1lPippgZ9wT/g0Xe0m6DA4qSeBx/YFx8ySf6Inb/e8WOTyEbsJjF+anI u9quB5Nn76qXFpdw3dkYBIjrm+5IJZfcjQ83zOFJDmS4TARwf78zGnykWpx6ugwQnrFG oVoFcdQJaGEyDCkjvMFbjGzbWD+h4mo5QEAUREdM4SMxrWK+rswQasw1iaI4iYxoCJlE zTb2r7ybig+acltsLmy4HhQkGf3HY5N1qd0mDi5ornM2wbriWV+BPg/83A5PbEqQskVW 4wOEwxMlRa/1symgEwi7iO6hlSNo7h8jnBuPbi3659K1X5HuLN4PXtzi9oKQvESs4HiE AGgw== X-Gm-Message-State: AOJu0Yyi4x5ukJlO7jCIwK7Ejt3IHx5jfyB+wfn9KIpARJ97qHZLVhj9 8E1IKO9Z+I8qNCMG7A+1/TsLoNm7SEBq5BnqQXlhLqkcjCGMkJ75bb0jXz0h0qWU2+k= X-Gm-Gg: AY/fxX7kQN18scyyMQmuRF4r+N5/VVMBKWYuTuDSDzfHSKwgEH78SIWoQga3NuuNAED CpGUotmGWeiL5CdU0rUH3oXwzAXq1eEIXO3dJJsV44eFaxkstzXZ/eWiDnfV8Viv+81jf+F6EFm UlRh8b/wpOPpB6nV/7M++oV1uW05ltaQkaD9uhcbH5XyUlhgzBaENgxhtTgdbtZlFTgjX3XlWhH 61tUbllhZCJUv371AYyYqypB5T/hu3t4JmV5IOag+ELcBRSW9yi/2iBT4E8nk0wtuC6c2dlfGxK C4hneJ9n18rWMzrrek+UBE9Vs+fT2Hs4KtpS3/32f9x1hmfO6/b6RaACh0aPno8cvplR0NgqTrB vzr6MfpSFMD3COj3p0LS+P2ZOf9ojaktpFqavpy6DRfvG9WwyJ4bH4XY1apgwvVluQy5ZyEShgf dt8y09H3raH6jCDxI4z48= X-Google-Smtp-Source: AGHT+IG28diYGF80RZ0QtpeanFRL2g6gItmMNsqtmbusPT3zdERd0iLHnEsiU7RtEdteUkFqcFVx+Q== X-Received: by 2002:a05:6a00:1ca2:b0:7e8:4471:8e2 with SMTP id d2e1a72fcca58-7ff66f569e7mr7616635b3a.67.1766327021542; Sun, 21 Dec 2025 06:23:41 -0800 (PST) From: Soumyajyotii Ssarkar To: qemu-devel@nongnu.org, deller@gmx.de, sarkarsoumyajyoti23@gmail.com, mark.cave-ayland@ilande.co.uk, richard.henderson@linaro.org Cc: Soumyajyotii Ssarkar Subject: [PATCH 06/10] scsi:ncr710:Mark command complete in status phase and fix disconnect Date: Sun, 21 Dec 2025 19:53:13 +0530 Message-ID: <20251221142317.266293-7-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> References: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::444; envelope-from=soumyajyotisarkar23@gmail.com; helo=mail-pf1-x444.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1766327122076158500 Content-Type: text/plain; charset="utf-8" Set command_complete flag after status_phase and use_phase_clearing, instead of full disconnect during message processing Signed-off-by: Soumyajyotii Ssarkar --- hw/scsi/ncr53c710.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index 4b42fab754..3d7318c12e 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -997,6 +997,7 @@ static void ncr710_do_status(NCR710State *s) ncr710_set_phase(s, PHASE_MI); s->msg_action =3D NCR710_MSG_ACTION_DISCONNECT; ncr710_add_msg_byte(s, 0); /* COMMAND COMPLETE */ + s->command_complete =3D NCR710_CMD_COMPLETE; } =20 static void ncr710_do_msgin(NCR710State *s) @@ -1041,7 +1042,7 @@ static void ncr710_do_msgin(NCR710State *s) ncr710_set_phase(s, PHASE_CO); break; case NCR710_MSG_ACTION_DISCONNECT: - ncr710_disconnect(s); + s->sstat2 &=3D ~PHASE_MASK; break; case NCR710_MSG_ACTION_DATA_OUT: ncr710_set_phase(s, PHASE_DO); --=20 2.49.0 From nobody Tue Feb 10 11:33:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1766327101; cv=none; d=zohomail.com; s=zohoarc; b=H2x5sWToQengTAnZVJwpOw2mBE68VCxaRj5uekjQCIkcbgigxxXPAhvZ9TtCQp0n+naIKeAxVgxsoDFydRoo22s1EZ5DOUL2KqM9CVkbPJWDhg04ayWmyGF/PxAk92Fte4Rkv8+CXySOn1yYGGIOGs/xCoAsWbIbhxGQUdll13I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766327101; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bsRWI5gndwtWwttnMKZAc/IN3m1275AuEyjWfFtSTCA=; b=b7AxyvMQB8/IhBOqzvmua6TxEO7LB95j3GoZNom/fEZTQtm0navCxyItrJ58MgW5ki3xclZ5I7J9n/+Ijb5RYyqGP4potb4clSOXQS9bYLlO+OWHAn9v2mtkFui1eoSqNvArkzw8pZO+8ww8jgli01BCeSgW30JbGlgCcC31AQw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766327101109893.7070216700945; Sun, 21 Dec 2025 06:25:01 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vXKM7-0001ct-GS; Sun, 21 Dec 2025 09:24:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vXKLb-0001Io-Hj for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:53 -0500 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vXKLa-0001Jf-10 for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:47 -0500 Received: by mail-pf1-x442.google.com with SMTP id d2e1a72fcca58-7b89c1ce9easo3654752b3a.2 for ; Sun, 21 Dec 2025 06:23:45 -0800 (PST) Received: from fedora.. ([118.151.210.82]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48f258sm7590449b3a.47.2025.12.21.06.23.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 06:23:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766327024; x=1766931824; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bsRWI5gndwtWwttnMKZAc/IN3m1275AuEyjWfFtSTCA=; b=TmFL8a9pK3CZugTQY3V3EKee2UBv+fNEmcP4Z7bup98dYwt6YFpUzE2ElXpB1zJNYX l6IGafeYC6SB0ZUk+1ARZsKWf61xKh85keAyEcoN65R3Ew0bSVv2raTsNg8HzqqFRu9O x/gyfKMjrN1/5qPhwAOMKnhNEPhX7UWgjflPfuU+WzfjmiUuE9ZIi8k8CtW9mPlIn15o 5B4vAav3QtccUpIYKrgbfblRvt88u2kMRbBbRHqjkcERke/YrPXRfTVICjYHaoErNNom lmBNokRfPPt7uDfHdrDLCg+nDw+eh/516E2cn9v+WxA8YYgqUbHXMytWQ85wwWeUKYCS t9LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766327024; x=1766931824; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bsRWI5gndwtWwttnMKZAc/IN3m1275AuEyjWfFtSTCA=; b=G167fKv9CDn2DpjjsMqmSfLwTkrcN0gIjU1fmClztCsy1CnVSLl8QGLhc/R1B9PvSc SR841WV+fsEMIBl/QpF6hbhj4aV5SDWyWBABTGHgCyvClHsWhpqUV2Qff5WrQm+Fwqf0 eCwCNCHHrSJutTbwHLUzZmrmG6U5mWq8NaCoWxV15VxkfqOZ/Db64AzkcbarrvvBWSLY VkDEsF9eUAxpeTGOaoc6mvDrWT4GC8NAbOaugUdAXgRHyxMdSTFf0Tir6Wl6raIzLefp T9GUratEQUsyeLUfW4UpZrOJS7lYTQOAhqLK04S829TawYl/LQ3q/RJE5K+PNs/R0Ayu HlpA== X-Gm-Message-State: AOJu0YzlL4c3A9c3Uq+eGhk/KjxYg9ybJG+vsB/ZdHxWEGoNMh5talcm XkJLPWpK7mBEqAWyRZZTCqFnblnW9rrP6+VxpfavQ0rE+RcMFezSCPdH7xURL0N9naA= X-Gm-Gg: AY/fxX4eXMCEa+tW/0T6KulMWt5LEEC4wFz3kAesyzLdL9CF1S//4t1Hd1Ae9zUG12b Rzd5F80qXOaYK/VUDZFeLvDsTpLkVm6V1VoPegE9jOLq0Q5BmHa5Cc+AoMpsBYbPSsdlmZUgTv7 MYdRICWriFETLe1sUC4IcyHZ+n5eM+M3ZZb/ZRbAyIJK237RC3mcw9P4weMHr/zzaI6hQgK+OHX zO7eEz8JCwvDSuxDTpf9KBN4FDBK3WgWLIWCJhiuB1WTAX9k2j3jW6aAHHMqzpPmiiLJ8rw3eGE TtbsZU2c8yL9Oz8rCAa9LEtcDGmayiq1uwPd4tm3TD1KEoDwqIajC0xretSFJau+pkJTUPTmWcN ZZdw8yLgCva/zNW1FxrMgxFnr/1CuYDy6DuJzRbs+bQrze1uivaGDU5ecF79FM27KW+6zXIG2jL FTUJNdsc0FgoO+HLRoeWY= X-Google-Smtp-Source: AGHT+IGdc+xTBvozWdC+Gkz1WeNdvswNO5j6t4X6U4VfklluPQ/i4AFgioBPV7IDG6asSp5NucGj6w== X-Received: by 2002:a05:6a00:1f17:b0:7f1:fad7:2ce with SMTP id d2e1a72fcca58-7ff679669d1mr8994532b3a.48.1766327024417; Sun, 21 Dec 2025 06:23:44 -0800 (PST) From: Soumyajyotii Ssarkar To: qemu-devel@nongnu.org, deller@gmx.de, sarkarsoumyajyoti23@gmail.com, mark.cave-ayland@ilande.co.uk, richard.henderson@linaro.org Cc: Soumyajyotii Ssarkar Subject: [PATCH 07/10] scsi:ncr53c710: Add LUN scanning Date: Sun, 21 Dec 2025 19:53:14 +0530 Message-ID: <20251221142317.266293-8-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> References: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=soumyajyotisarkar23@gmail.com; helo=mail-pf1-x442.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1766327101994158500 Content-Type: text/plain; charset="utf-8" Add multi-lun support by scanning all 8 luns when ANT bit is set Signed-off-by: Soumyajyotii Ssarkar --- hw/scsi/ncr53c710.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index 3d7318c12e..277aa2c3d3 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -1422,8 +1422,30 @@ again: s->dsp =3D s->dnad; break; } - } else if (!scsi_device_find(&s->bus, 0, idbitstonum(id), = 0)) { + } + bool device_exists =3D false; + if (insn & (1 << 24)) { + /* ATN set - scan all LUNs for this target */ + for (int lun =3D 0; lun < 8; lun++) { + SCSIDevice *dev =3D scsi_device_find(&s->bus, 0, + idbitstonum(id), + lun); + if (dev) { + device_exists =3D true; + break; + } + } + } else { + /* No ATN - check only LUN 0 */ + SCSIDevice *dev =3D scsi_device_find(&s->bus, 0, + idbitstonum(id), 0); + device_exists =3D dev !=3D NULL; + } + if (!device_exists) { ncr710_bad_selection(s, id); + if (!(insn & (1 << 24)) && addr !=3D 0) { + s->dsp =3D addr; + } break; } else { /* --=20 2.49.0 From nobody Tue Feb 10 11:33:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1766327090; cv=none; d=zohomail.com; s=zohoarc; b=edF6uFnxe3sBZwYFZsxgIETmILnmJl+xv0k98D2N5GGskzGFdmftXOfDFYVj6TPvYqaTafid81ywxOm1cXZe1HhxO1zAiCji7tont5reABSB1wBV4YZnFZW8K+TnpBRhHyqJELgJ4y/lGXuaLtItyFKzBO0UCatu7LOR7L0HwG0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766327090; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+XD/BsROiENdr8y/iTNL+8rSfBE9xfwKYoALONG2xb4=; b=JoQAFHl5BZZTdCg6Wz4mnrB5Smdii7mB9FQdFOqNTC54YMApR+gklUmqDfsMs+yGdJjroubgIxluoNo9oa92cHFrmDgrV+kKdmNK9NsmyM+f9sNviK+VSoYodNLs5GUAht0es62yMiNdz0dKYrsMy9wWcnsHxX9Vn0BNnU54lo8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766327090095634.2179916610278; Sun, 21 Dec 2025 06:24:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vXKMA-0001wu-Tl; Sun, 21 Dec 2025 09:24:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vXKLe-0001JG-BJ for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:54 -0500 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vXKLc-0001Js-UB for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:50 -0500 Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-7f651586be1so1489200b3a.1 for ; Sun, 21 Dec 2025 06:23:48 -0800 (PST) Received: from fedora.. ([118.151.210.82]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48f258sm7590449b3a.47.2025.12.21.06.23.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 06:23:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766327027; x=1766931827; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+XD/BsROiENdr8y/iTNL+8rSfBE9xfwKYoALONG2xb4=; b=OLsiUa4xy7Bxwoy2cD6UXQPE6JEcCVnzHLLowUKS+pvGhMsrv/+AJlTA2Pkqymc0Nr ZOfHBIjWr4GoCPZS5ho7oRGwxscmPRhKeOkHAcnl3QDVlvUufxAxZzoeY9+gBAkcQeqd gxW3BIz8RFywSI4gUzs2kLucezSEiA13VPRg05QZZvG9CPIR6DvCtHk+0ZNKuYY8pj6Q bx7113zZkskWi/QrXIwWhkyKXkqaHnWrnhybP72GT8WErURYHoNNupldryrXJSVG/PZz aYklIxoioxpVjI/0V/RAi2pFDRKvJ3UQbhQdUoKHt3b6iiPVRP9ug3Ah1Lv1uwh3k1k8 InUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766327027; x=1766931827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+XD/BsROiENdr8y/iTNL+8rSfBE9xfwKYoALONG2xb4=; b=TKstD8YQLCPziXV/c0xXzrWmk6O+Bhqoy8Ib9mLsPaUjyD3LexlwiilNFr72Qd+zeq SudxmUWaJJF5Vj1YazzB3bnxqhMzPRKOTKSbpCbzEvg7QB/tPfgiOIL8wJo+zxZRBRay TeGoatSP83ReA+SP9ahRFHBQxxqBjHlOMKwz0E9Tx/DvHg6utb1cIsJGNROEF5CL+6Qb CCsLRhCtwv5wie30s5H5auuxDm8jeiNUirJcWXBSo2A+/wFyWw9ICUOQUTlmg0HCRl3w 9JYnS5b1p3/qCi5TVZ2BXJnJ8W9g7bQNrkU3RuGUGUg7ei0AwTpaSZWA6I458xREStO0 R1fw== X-Gm-Message-State: AOJu0YyhR7p6JZUdhE/+AtjqWajrYTIXjQRk/ELPRS4DX3o1dA2J/nlI k/suZHg1yIPJMwo4UsVYg+wZqim5v4X9gSCoIF2757xSz2H7iVzBd87bAXrpjdxFRC0= X-Gm-Gg: AY/fxX7uf2Xtri83AYRpSJ5bEd12WmM4PXY5015t8WIAqG2NpP72XN+AW75X37KONoP JuL5LiGn/n4N6amONGRJpY48giHJGkqfNky6EP5J6si0cpoBdwjnK3u6IHw/3IIVuC/Ga5fez8L E/V7U0wDsA2+3QgA60H+GPzSq3O+pI3JbI4xQ/QSGrrqgH0gaW+yaZrCkXGWHpDHGEl8+ueocp+ 0HU+eZT8CEbxXH9R4y7FqhkJCS/PJVOBMV2v/ItHMQAxFZ1b8srYPgZ/0XxJRxvpvY4MFvrCseS oA9H8xRR38Nw0BSfe/9LexbdurRJSaorWiT0UVMdKByYwehVbr1OQAL4gqjEZyiN0IacFuXjRiI ik+9A7iN5BZ6slXGn6I+aFIcdVQyjaw5QC1Vp1uCD319QY59c/AiW2/Ski9WwtYvemY2KoGeOuQ z6VVCmPr5GW8nU1mrZWeg= X-Google-Smtp-Source: AGHT+IEQlWnTY8GRCL0pTDpnbTWuCxP2kE8I43+GuNrZBQ+0tDnZ3FTmWlgUB2sssrF0ItHkUNpoSw== X-Received: by 2002:aa7:9903:0:b0:7e8:3fcb:9b0b with SMTP id d2e1a72fcca58-7fe0e8319bfmr8133826b3a.33.1766327027336; Sun, 21 Dec 2025 06:23:47 -0800 (PST) From: Soumyajyotii Ssarkar To: qemu-devel@nongnu.org, deller@gmx.de, sarkarsoumyajyoti23@gmail.com, mark.cave-ayland@ilande.co.uk, richard.henderson@linaro.org Cc: Soumyajyotii Ssarkar Subject: [PATCH 08/10] scsi:ncr710: Simplify disconnect handling Date: Sun, 21 Dec 2025 19:53:15 +0530 Message-ID: <20251221142317.266293-9-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> References: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=soumyajyotisarkar23@gmail.com; helo=mail-pf1-x443.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1766327091984158501 Content-Type: text/plain; charset="utf-8" Simplify disconnect instruction by unconditionally clearing waiting statements when command completes Signed-off-by: Soumyajyotii Ssarkar --- hw/scsi/ncr53c710.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index 277aa2c3d3..dd453991e0 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -1469,9 +1469,7 @@ again: if (s->command_complete !=3D NCR710_CMD_PENDING) { s->scntl1 &=3D ~NCR710_SCNTL1_CON; s->istat &=3D ~NCR710_ISTAT_CON; - if (s->waiting =3D=3D NCR710_WAIT_RESELECT) { - s->waiting =3D NCR710_WAIT_NONE; - } + s->waiting =3D NCR710_WAIT_NONE; } else { if (s->current) { s->current->resume_offset =3D s->dsp; --=20 2.49.0 From nobody Tue Feb 10 11:33:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1766327069; cv=none; d=zohomail.com; s=zohoarc; b=MPa2yNt2xx/MzKI3hq0cWDiTXgiqyRfgJnw9XbKBFMNXz23F56MsxOnY/9YNuQtOHT4gbEb5G46+enPkhkXi9UbqHC0GS5hM59ttMjyFVFPh/5gwAeQ0viE52N4Pj1L392DBXyfWk6rB2lUR11cPonC9qLYLnGdr0PSb+ddiFJE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766327069; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0L51uaKTVgxyKMIF4vldQB1dPrYARBcQxc3sUNPphHw=; b=h9xF0FtTxQi5ZHuRLP1Hg7aO9L96dWZ+lXj2+PIQCh9F1ju1BTAht6FVVObIXNBiw4fGHEJS5gDenlBNOWK6RevmNKah9jd2iWbnQwkxHuKD9GctnJZwGXX/vVh83AuWE+qDYTNZGO5VMOmqOUv53C646UlB2vkYq4S7KzO5IYI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766327069975913.2642981748186; Sun, 21 Dec 2025 06:24:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vXKM9-0001pY-DL; Sun, 21 Dec 2025 09:24:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vXKLi-0001LH-CX for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:58 -0500 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vXKLg-0001Lj-Bs for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:53 -0500 Received: by mail-pf1-x442.google.com with SMTP id d2e1a72fcca58-7f0db5700b2so2926011b3a.0 for ; Sun, 21 Dec 2025 06:23:51 -0800 (PST) Received: from fedora.. ([118.151.210.82]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48f258sm7590449b3a.47.2025.12.21.06.23.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 06:23:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766327030; x=1766931830; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0L51uaKTVgxyKMIF4vldQB1dPrYARBcQxc3sUNPphHw=; b=eX/KbLvfS2VDdxqiwi2+U9cYWvhZ+uW4cXrftu83xrg3CYJ9eWkmsjqD8PeAXWFG+N kUL89+85TXvoHKrKo8cKB/iYLVCOebSBAswpxw36Du+qujaEAhQ3591kyqiRa1OwKiBJ 5vl8aW1e1XMwG2ABMkyAP9dxjh/bAFXeU+s7DH/qhwvsMp2kMC3Es7FtHwCIbH8VKFZ2 NM6HlRG1BtW/OURgA5misTgXCi+TOwBdn6SbYJ6ZbHShyKImEM0iBgTcf4KLv5jVwjPD bnoVRsszmHlrO0miMxjHjTsr+kzyLuc4ff7D7lhAB7jr3Ne6md2HJa1MPqQEand19UA8 EumQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766327030; x=1766931830; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0L51uaKTVgxyKMIF4vldQB1dPrYARBcQxc3sUNPphHw=; b=TGjuteJVcR98T5Qqd9jTctSUXKBSgEuRmTSRFnm9QzqelhUbMF2chukypgW6cykHmb reqK8FikxKpY7ZuHBpDBhNQhAqfkfboKQYaDW8ROkXusg6//g4q2/47xZlhJ6NGvyRrU 6t45+YfCwV1Sc3dZrUd0dXPH0DlRZVdwFAmgOQgAW79DfgSVDBuZv5n8FuSo71EQAU/C V3l7zGz8pWvBoJc8r3AHeg39jTz2pNOzoX7x0AbIcG2VYASYxJOM/bkWEmsvhuo6GX6Q OmoxeJe4Af6t/AINFF0w/R/0HTwPvvuQqfAPzapaYwXuMdGqR92H8DH9XgMdpTZhsWvw eevw== X-Gm-Message-State: AOJu0YzRBHBhIrqUJgBb3HG+AZp8Bv/gquJGxK1bWot87AyIM9JGctmr 7L90JjT/WsdGACzTfbEL+SFLQALp4khm4ESy2bzXO8e0EDjjHrKIQB5R6RvxbgxGtV4= X-Gm-Gg: AY/fxX7SLNiou/z51E//ygcVFroj1Yebqz6thlVbAL4cpzgofEyPTTehu6x6auSzUq1 ZuP0IVFROl0NeNkmONvxrwD6jPUf7IOFMlUbZWw+pSI52V9zl9tw9PvHIaodmx0uJE2a7IXTAu6 EHlI+Z+f3RP/c/IE4+R3zh6yrjVDKDYEyg1KuJRgpe4tf11ph2wuFbsAmeNtu6iJoq3+4wTrP7K WNSC3S+yxR9fcHhSCYSQa/nGPX2fInWYVMwxEG25EuhAvQBAvGlS6DNa93zmwa6IiKhnaevPccg D0xpT9tTCpAjz6iuymNKEWTgwu6HQx4U/gt8xod9txYVu6cPtIV0WiFcuKKZHqMLEQsyliha2n9 68eJFuqzyog4y/AOsv6RwLfWCCMMeVhl//C3dg9P1JfRpZZhHivAM/a5nRPaZlFd+CW3oB8XTmX +yWnr1fQhTEpiOLf626g4= X-Google-Smtp-Source: AGHT+IEiLRToAUJMCSGTEtKUnhhjPHenbVqSZ+B/6+bNpjDbZ9IJHVMCRTVNFQNEqa1kfMsAUPp3HQ== X-Received: by 2002:a05:6a00:451a:b0:7fc:da5:f85c with SMTP id d2e1a72fcca58-7ff6607b30dmr7547030b3a.38.1766327030412; Sun, 21 Dec 2025 06:23:50 -0800 (PST) From: Soumyajyotii Ssarkar To: qemu-devel@nongnu.org, deller@gmx.de, sarkarsoumyajyoti23@gmail.com, mark.cave-ayland@ilande.co.uk, richard.henderson@linaro.org Cc: Soumyajyotii Ssarkar Subject: [PATCH 09/10] scsi:ncr710: Fix DSA register Date: Sun, 21 Dec 2025 19:53:16 +0530 Message-ID: <20251221142317.266293-10-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> References: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=soumyajyotisarkar23@gmail.com; helo=mail-pf1-x442.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1766327071917158500 Content-Type: text/plain; charset="utf-8" Implement byte wise write handling for DSA register instead of using the macro, as NetBSD driver accesses it byte by byte Signed-off-by: Soumyajyotii Ssarkar --- hw/scsi/ncr53c710.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index dd453991e0..0ea1fc43a3 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -2078,7 +2078,21 @@ static void ncr710_reg_writeb(NCR710State *s, int of= fset, uint8_t val) /* Linux writes to these readonly registers on startup */ return; =20 - CASE_SET_REG32(dsa, NCR710_DSA_REG) + case NCR710_DSA_REG: + s->dsa &=3D 0xffffff00; + s->dsa |=3D val; + break; + case NCR710_DSA_REG + 1: + s->dsa &=3D 0xffff00ff; + s->dsa |=3D val << 8; + break; + case NCR710_DSA_REG + 2: + s->dsa &=3D 0xff00ffff; + s->dsa |=3D val << 16; + break; + case NCR710_DSA_REG + 3: + s->dsa &=3D 0x00ffffff; + s->dsa |=3D val << 24; break; =20 case NCR710_CTEST0_REG: /* CTEST0 */ --=20 2.49.0 From nobody Tue Feb 10 11:33:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1766327096; cv=none; d=zohomail.com; s=zohoarc; b=f+bc9KPJTlSZCDrxBJNBYmOTe1p7vP0beKLEaUmEzgQeVFEcL+06h3qoeTRsFWhcAamRFAyRs5CR+/LPBAs6ZcRdkW/iY0xJbLLIDq2S89NoJga1nh4Tuw13FBiyDNWQ1WKTq3cLG1UObXaSsjvfg6PmaGnD1pSOCB7vpxss8tk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766327096; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rwo1mKiMyT/GajHYoh8G0G2szHYZLyV9nC1hl1YqUaw=; b=bMfmP0xIP9Yl4tc+alwDFd51IqqUEnDZzMFAvR15uRpz+adOhwXiERONx6m9X5nNmbs1aOV4rKZGZGnhow/Fz5FKjFgteQjb3zcO6ZJ8KMYNP8VWuSq9E7u+5fZF73GAOAHbqML7hUM+4/OLCPWs/zuAQs0z6Y/MNdy702C8Nfk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766327096786296.5339932802767; Sun, 21 Dec 2025 06:24:56 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vXKMB-00024V-Sj; Sun, 21 Dec 2025 09:24:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vXKLk-0001Lb-SD for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:59 -0500 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vXKLi-0001Q9-Tq for qemu-devel@nongnu.org; Sun, 21 Dec 2025 09:23:56 -0500 Received: by mail-pf1-x441.google.com with SMTP id d2e1a72fcca58-7e1651ae0d5so2475560b3a.1 for ; Sun, 21 Dec 2025 06:23:54 -0800 (PST) Received: from fedora.. ([118.151.210.82]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48f258sm7590449b3a.47.2025.12.21.06.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Dec 2025 06:23:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766327033; x=1766931833; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rwo1mKiMyT/GajHYoh8G0G2szHYZLyV9nC1hl1YqUaw=; b=PM/5GLtR6KotrkG4T2Vv6XRsChCJbpB2eEYCqJuKQc7HM5zVUQ+f3VrSlZvNPmljEn GfNJdVdj05b8huTo09efwGv9pg+1XBxqlKR8EAqEGB9dYgTbBYwJV4ZInSXUvh9dw+xA MroY+EvtE0mGLVun21TDnL46kf7UQCeLpJ6I8WmW8hNNgW9t5JGe8p9zrRa7OXYiDCnk GoVT+5ocNc4f9a6881HTRmBF4oSIxJvIh6xKKt4BMgWHpYCXr79JzaTHjOA55mcx1enp LAgoTSbx2v8CrE/1PwK9igKHr5wquUaKqgx7GmQL+LZMJKZgnG7N4N/7pKSp10XGiHxe Rqww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766327033; x=1766931833; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rwo1mKiMyT/GajHYoh8G0G2szHYZLyV9nC1hl1YqUaw=; b=CPaxUOmkgpLMEBoioNMdyeW+FSjYgD9/z2ukAKWGzNdj3eWzN0arhAKfSwdrP05eGM Mta4tLSRKMXd3VAzOrnHe97NLf8yA6dNiiCz5T3I2xydG31sGhNdQ/B9Zk0YC5yhdvRV j/mbV1Ap5/9goO0TidYnZeBhmEh+HAJPCP0xeNcqm5ey2PoDDnWfveQJ8xRI+zmoT22n kdCjZj+sgFABmbUuDxCXFGF5bFxHmNOBZIqPrpGMKEFNrH02KyIvI7COtcvwFSq6A3pW wF6rc45DaeWEvcTxwlH92cz4KZ8n/8ufuHlSZyeQGUV9wHinoFG7yJTrK2pCazR8EFnl 3LQA== X-Gm-Message-State: AOJu0YwPNo5ouBKnvN7FAjyTJ0kJgDy8d+wAPK8HD+URDUA3wpO47cRS dbn/JNPQOATHEZZ3YyvFmXFZj5uKwdQIOpkVp+KmcrhPt8ZV17Xl5k7GwAvNhh1w01o= X-Gm-Gg: AY/fxX5Fb/KAN2lPJJjVThwqTAxvCrofhm+/LnaY4s5CCwgmoULzpSOntyiCFOSDIyr 78UF/BLIO7BEk+AdHKAnCCtdoY5xG0a0CA0kLLx9j3LjyW114TupyIph/UQjj8YVCSjQACxC7HA mB4wX8uFsjDQLTInEa1rZhlwXBIpngpU7tSZJqh4qUjqbUQmCIgIcMjFXzlL/Y8jxdTQh2eWq7m 7effpUu/79k0Z4Cg3oam/MOofOo18gbAq7wQPi694M14/60vTa0OSdArL7zNs/+yq/Yfzpix5vS Mpnfpu95OphUKKcyFBIfv5Sq+RPTamH/70U9qEN5nX1ke6ED8EsR1kGFQ6MB+CoCOTSsQORzJoZ J7Car7EdzSYcDXhfiT4oV6qQlL7+/djqUR3CzsKO9ZDszUo78zadbTdZC5vUK6okOGQJAxrBGrV ohHm6PFl7hlmAKR/xZ+7k= X-Google-Smtp-Source: AGHT+IFv6dh3tArYH7aFS/i++7JDH2y/UAX/tNgQgqrvomDz5RTgLpU2OTYZQzXVEFJLu9g9AZi6+A== X-Received: by 2002:a05:6a00:1d23:b0:7e8:4587:e8b9 with SMTP id d2e1a72fcca58-7ff65f7907cmr7696060b3a.44.1766327033330; Sun, 21 Dec 2025 06:23:53 -0800 (PST) From: Soumyajyotii Ssarkar To: qemu-devel@nongnu.org, deller@gmx.de, sarkarsoumyajyoti23@gmail.com, mark.cave-ayland@ilande.co.uk, richard.henderson@linaro.org Cc: Soumyajyotii Ssarkar Subject: [PATCH 10/10] scsi:ncr710: Fix CTEST FIFO status Date: Sun, 21 Dec 2025 19:53:17 +0530 Message-ID: <20251221142317.266293-11-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> References: <20251221142317.266293-1-soumyajyotisarkar23@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::441; envelope-from=soumyajyotisarkar23@gmail.com; helo=mail-pf1-x441.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1766327097981158500 Content-Type: text/plain; charset="utf-8" Update CTEST1 FIFO status when CTEST8 is written, setting to 0xFF when FIFO is flushed, otherwise clear to 0x00 Signed-off-by: Soumyajyotii Ssarkar --- hw/scsi/ncr53c710.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index 0ea1fc43a3..cdc365478c 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -2161,7 +2161,11 @@ static void ncr710_reg_writeb(NCR710State *s, int of= fset, uint8_t val) if (val & 0x04) { ncr710_scsi_fifo_init(&s->scsi_fifo); s->dstat |=3D NCR710_DSTAT_DFE; + s->ctest1 =3D 0xFF; + } else if (s->ctest8 & 0x04) { + s->ctest1 =3D 0x00; } + s->ctest8 =3D val; break; case NCR710_LCRC_REG: /* LCRC */ s->lcrc =3D val; --=20 2.49.0