From nobody Sat Feb 7 08:28:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.dev ARC-Seal: i=1; a=rsa-sha256; t=1766285071; cv=none; d=zohomail.com; s=zohoarc; b=g6zlC2v+xaH9ab1d6eVrfnCxy5LzVkR+s4OmRL6kyvHvSyu4NyNARfO6dVSdrhexwwNmoM0cXjVnG3/9pcbwnMd4N+6H/K/5XSuVl3pa4uQC3hWu602gJ2aiRM9nkyP6iO0bX5ydz8lvlLpUP+JvZWnBQqJV2une4nnrWWMVROY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766285071; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dmP6Wvk0KETdBC34SFuuuEpsYY5VRmQDyspL0DmBLGA=; b=cqBiScLsHGXHknmjON+4bEYbNaEL0/TiKqNR2fZ1J4Cr07EoV3I94lVwO2yjHibHIv8h0NOvxVMoA+uEvKCUDcEUK6ZbzocD8CXUyhmhyc1i3C7fPxh3xisPHyfCuUgAigYle/IxTeJGCOTkjnS9eAQSjPeE85eJSoHuBPjo2tY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766285071161768.4919037328613; Sat, 20 Dec 2025 18:44:31 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vX9QN-0002a6-1b; Sat, 20 Dec 2025 21:43:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vX9QK-0002Zg-T8 for qemu-devel@nongnu.org; Sat, 20 Dec 2025 21:43:56 -0500 Received: from out-180.mta0.migadu.com ([2001:41d0:1004:224b::b4]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vX9QJ-000470-Cc for qemu-devel@nongnu.org; Sat, 20 Dec 2025 21:43:56 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1766285028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dmP6Wvk0KETdBC34SFuuuEpsYY5VRmQDyspL0DmBLGA=; b=bdnP6y7/N29p2vHUeAbE3WPHfhy9BAWEs1jzkj8RYxRVb/uMoyvnEdorJFCoPhurP4xlDc E7Dz+4lByNjdCJsdZA9sgfKeU9OPRXaAv/sqYAN36MCOIPpUhVrZQfS8CDA+diL7TJH3y+ Tz9zJtp75uolczxPG2BofeKWSJzQuis= From: zhenwei pi To: qemu-devel@nongnu.org Cc: mst@redhat.com, arei.gonglei@huawei.com, mcascell@redhat.com, nakamurajames123@gmail.com, zhenwei pi , zhenwei pi Subject: [PATCH v2 2/2] cryptodev-builtin: Limit the maximum size Date: Sun, 21 Dec 2025 10:43:21 +0800 Message-ID: <20251221024321.143196-3-zhenwei.pi@linux.dev> In-Reply-To: <20251221024321.143196-1-zhenwei.pi@linux.dev> References: <20251221024321.143196-1-zhenwei.pi@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41d0:1004:224b::b4; envelope-from=zhenwei.pi@linux.dev; helo=out-180.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.dev) X-ZM-MESSAGEID: 1766285075426158500 From: zhenwei pi This backend driver is used for demonstration purposes only, unlimited size leads QEMU OOM. Fixes: CVE-2025-14876 Fixes: 1653a5f3fc7 ("cryptodev: introduce a new cryptodev backend") Reported-by: =EC=9D=B4=EC=9E=AC=EC=98=81 Signed-off-by: zhenwei pi --- backends/cryptodev-builtin.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c index 0414c01e06..55a3fbd27b 100644 --- a/backends/cryptodev-builtin.c +++ b/backends/cryptodev-builtin.c @@ -53,6 +53,8 @@ typedef struct CryptoDevBackendBuiltinSession { =20 #define CRYPTODEV_BUITLIN_MAX_AUTH_KEY_LEN 512 #define CRYPTODEV_BUITLIN_MAX_CIPHER_KEY_LEN 64 +/* demonstration purposes only, use a limited size to avoid QEMU OOM */ +#define CRYPTODEV_BUITLIN_MAX_REQUEST_SIZE (1024 * 1024) =20 struct CryptoDevBackendBuiltin { CryptoDevBackend parent_obj; @@ -98,12 +100,7 @@ static void cryptodev_builtin_init( 1u << QCRYPTODEV_BACKEND_SERVICE_TYPE_MAC; backend->conf.cipher_algo_l =3D 1u << VIRTIO_CRYPTO_CIPHER_AES_CBC; backend->conf.hash_algo =3D 1u << VIRTIO_CRYPTO_HASH_SHA1; - /* - * Set the Maximum length of crypto request. - * Why this value? Just avoid to overflow when - * memory allocation for each crypto request. - */ - backend->conf.max_size =3D LONG_MAX - sizeof(CryptoDevBackendOpInfo); + backend->conf.max_size =3D CRYPTODEV_BUITLIN_MAX_REQUEST_SIZE; backend->conf.max_cipher_key_len =3D CRYPTODEV_BUITLIN_MAX_CIPHER_KEY_= LEN; backend->conf.max_auth_key_len =3D CRYPTODEV_BUITLIN_MAX_AUTH_KEY_LEN; cryptodev_builtin_init_akcipher(backend); --=20 2.43.0