From nobody Sat Feb 7 08:28:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.dev ARC-Seal: i=1; a=rsa-sha256; t=1766285071; cv=none; d=zohomail.com; s=zohoarc; b=D0mzxPlQd7Y7ymlU/PW7CYlKVsGVclAC6dJ7BkCKRdM34AHK2CMLb3MvJa2lJz+NHqW3ipAVqBYZK54LV4qnwpbsOzeleTotib7sJbo7OAWPo6JbEpvjuhh7BWb9CwYRtohptO5XewUg7Qd9L6Sn1tqstgiW6wPJeh/AlJQyrjw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766285071; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yEgYMzOvq6jxNIvTmv23gY/0hM5CAwJFQpxXwpO4+9E=; b=INIqrDSwu0vplDLT25yYijakpgTYJeeAF4mt7zFqlb5SBsHym2QjqzxjQECqKiz/I4920G7Bqr65+v6si9et8/b2Ikb5Zkn79h2C6GjmoeJMqLMzaLV8lr8N54yfFbTNbN943WhC9FI888EdHgLQU2MEf22pnZeWypsE3RW8OF4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766285070594734.3946587467852; Sat, 20 Dec 2025 18:44:30 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vX9QP-0002an-FX; Sat, 20 Dec 2025 21:44:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vX9QO-0002aM-3V for qemu-devel@nongnu.org; Sat, 20 Dec 2025 21:44:00 -0500 Received: from out-183.mta0.migadu.com ([2001:41d0:1004:224b::b7]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vX9QM-00046B-Nt for qemu-devel@nongnu.org; Sat, 20 Dec 2025 21:43:59 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1766285020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yEgYMzOvq6jxNIvTmv23gY/0hM5CAwJFQpxXwpO4+9E=; b=IEhib4SKB2fkICaS6LBHf226uB4yiugK01zcxa+/Fh/CbVEgAT1L0WTnp/hUkv/LcMJYaP /oFOyDP6XCVsuqeh8nbXO19hdsK7wZNo4/E3Hask0s6uSLeHp289FWAZL74tYKx6OaQBdy MwVNLjbfCCy8baseGgLNO9AkxiP1OoA= From: zhenwei pi To: qemu-devel@nongnu.org Cc: mst@redhat.com, arei.gonglei@huawei.com, mcascell@redhat.com, nakamurajames123@gmail.com, zhenwei pi , zhenwei pi Subject: [PATCH v2 1/2] hw/virtio/virtio-crypto: verify asym request size Date: Sun, 21 Dec 2025 10:43:20 +0800 Message-ID: <20251221024321.143196-2-zhenwei.pi@linux.dev> In-Reply-To: <20251221024321.143196-1-zhenwei.pi@linux.dev> References: <20251221024321.143196-1-zhenwei.pi@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41d0:1004:224b::b7; envelope-from=zhenwei.pi@linux.dev; helo=out-183.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.dev) X-ZM-MESSAGEID: 1766285075596158500 From: zhenwei pi The total lenght of request is limited by cryptodev config, verify it to avoid unexpected request from guest. Fixes: CVE-2025-14876 Fixes: 0e660a6f90a ("crypto: Introduce RSA algorithm") Reported-by: =EC=9D=B4=EC=9E=AC=EC=98=81 Signed-off-by: zhenwei pi --- hw/virtio/virtio-crypto.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c index 517f2089c5..b20f299937 100644 --- a/hw/virtio/virtio-crypto.c +++ b/hw/virtio/virtio-crypto.c @@ -767,11 +767,18 @@ virtio_crypto_handle_asym_req(VirtIOCrypto *vcrypto, uint32_t len; uint8_t *src =3D NULL; uint8_t *dst =3D NULL; + uint64_t max_len; =20 asym_op_info =3D g_new0(CryptoDevBackendAsymOpInfo, 1); src_len =3D ldl_le_p(&req->para.src_data_len); dst_len =3D ldl_le_p(&req->para.dst_data_len); =20 + max_len =3D (uint64_t)src_len + dst_len; + if (unlikely(max_len > vcrypto->conf.max_size)) { + virtio_error(vdev, "virtio-crypto asym request is too large"); + goto err; + } + if (src_len > 0) { src =3D g_malloc0(src_len); len =3D iov_to_buf(iov, out_num, 0, src, src_len); --=20 2.43.0