From nobody Tue Feb 10 06:25:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766162260; cv=none; d=zohomail.com; s=zohoarc; b=n/22ijU3ahWiHwtX8vr5jifpunnBEM1lUvCx0CRg1NGiTmfmj4OAHbr7xyiXv66VvdvZemQv+ePbdWxtaPOvwnqV29OX3gkgH9eh3E08bYMfvgIG+n1SLgZeutOBMRO6LKb558ag1C7O9QM9LbE4eRgZPg2yH3QOQU9899XJBh4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766162260; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9A1gr5CJUaSQgBXQcHovtENYxaFT/E0t2tXqegO2h5o=; b=QteA3yPpYl3z/btevCAlvxtDoVMxA3LpzKfuCCmBfLAi/qMfp3RErkpbUYpzeffQHJp+XMheA3gwKjq34lgdNoxulr70anMYGiWvfaeY24NcBJyIhPjTpUn0sycDKOyq4gtygGsxAxAUW6Da0uFwWoZhGpatKz5OqoA809owssg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176616226029316.257005844534888; Fri, 19 Dec 2025 08:37:40 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWdTX-0003Yo-7R; Fri, 19 Dec 2025 11:37:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWdTU-0003YF-7b for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:04 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWdTS-0000OX-KV for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:03 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4779aa4f928so18789055e9.1 for ; Fri, 19 Dec 2025 08:37:01 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d19362345sm50113335e9.6.2025.12.19.08.36.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Dec 2025 08:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766162219; x=1766767019; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9A1gr5CJUaSQgBXQcHovtENYxaFT/E0t2tXqegO2h5o=; b=O6jPT5kgvehHU5ayCeMO3BVV1/S8HmV769ujK4hZy5//ver7ont1KItVmUIre50Zlh tJvQW9paC+0s5y6ywGimzRuXye5fbaTQJcopE1G5Hjw4WUn9ACbF1ihLdFT/ivCBjJL4 7HwaQy1JdWFVidh2YA3+87xLHO/fWgizPTXQQf8mjUOqVER4QmHIeDms9BerBwhaiYdq TncNbfXApoxh7vFValaSHfuu+2oF6zIFEpi9GhUZM1ccQ8EulhvOclrrtQtBPUl1DmcX pBrbpvHfsPra/wjnUGyJlQHI+ngp8BopOGawg0Fm7tnCP7Bf687wui8cJb7D3ZAg5eIz E0Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766162219; x=1766767019; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9A1gr5CJUaSQgBXQcHovtENYxaFT/E0t2tXqegO2h5o=; b=lVyox+f9o84mEEuDKkLx+MYUzQZMfzLEvKigLzk7wV4wXloZHb17wyBbX10Tu144KP kLctULn5J9JDiHnNjEINr4xbz0Et1Rp66cgWiwPCH0eQNc2FC5MiYzv2eR6T07IQ5IF6 35emukjjh9yDGFb1tseQLGgYwvgT7dWFI8Ksq8meDJEsFkMw8NkNPLN9C+k8nOT+kaVq ho9NJGVYWDOs9s5VxPVVEsulMiIb1BiAyB7dp93H21ICi4Sb+xnFjvEado/CeJjjPxhc qaqBAi2QuuIuaMML5oF0k9xHG2RhEoNAeTJ2u8lZm6CMNuQBHWMNdkJR71p7yVpZnE09 JJ3Q== X-Gm-Message-State: AOJu0Yy7fofpsEk9AZdeXpEgfa6gEhVwfsg8W3iK489hugxin+e5QvDB U2hDzTQWAtxEGvMwiHfyVRrbaPfx4/vIkoJRGz6Pe2lqxihbRA5Dqa+PDFuR1tpCzP1HdAqrTMs TkWeEqyg= X-Gm-Gg: AY/fxX6zrtJdsG+oFgZjfev7VeY3NzzYSpq8j//bxmG6JhoYcHzj0hsHlqsoccfuKed O8xqIpMdOtO48p0ZX72p0B/feaBfhY5zcK7OU5oXrDKDd5+nzNJ0QcGU+MrbRNHBcVH1NsasS88 KI3XK0L7aWPfSTOPY2D3IFZrRdGgDUa4q3UqQoNW2tSjQoAxiHlchvBVpzHJiBrTof0LivcpBIj ORlpQao/99T18aO4Gt/wGQvuG+BqotY1aBZ2ijsFK8tEsQveObu1UYV5EN+8MgfF1ox4gbFFflE UB/f8KutRSVhgGRmbJNmMynOSTbrgwqJbgG87OubHtmIXA0KvMtgZeR/fAdjob3LmaiLGJYf3nU Mb8y0hS9WUTj9mqFQhhVD7XjuGNNxVBFCAQhtN66ZvA9V54SchibirJB3nHjJCyGH4MZSv1fKzK PJY506BhC717b9OI4Zn8gpflgcQiimombaTkkP0E/LDUG42zdloFZL5IQXFh0j X-Google-Smtp-Source: AGHT+IHqfPjEiCUzly+R6Ir7twXbDm4Ht/xvz7hKR8Sd7YghV0bPZiuSrvkWK6dc79ozNsMX7BAjpQ== X-Received: by 2002:a05:600c:1d1d:b0:477:9eb8:97d2 with SMTP id 5b1f17b1804b1-47d1953b8acmr34176285e9.8.1766162219499; Fri, 19 Dec 2025 08:36:59 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Artyom Tarasenko , Anton Johansson , Richard Henderson , Laurent Vivier , Frederic Konrad , Mark Cave-Ayland , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 1/9] hw/sparc: Use explicit big-endian LD/ST API Date: Fri, 19 Dec 2025 17:36:41 +0100 Message-ID: <20251219163650.74303-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251219163650.74303-1-philmd@linaro.org> References: <20251219163650.74303-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766162262241158500 The SPARC architecture uses big endianness. Directly use the big-endian LD/ST API. Mechanical change running: $ for a in uw w l q; do \ sed -i -e "s/ld${a}_p(/ld${a}_be_p(/" \ $(git grep -wlE '(ld|st)u?[wlq]_p' hw/sparc*/); done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland Reviewed-by: Chigot Cl=C3=A9ment --- hw/sparc/leon3.c | 42 +++++++++++++++++++++--------------------- hw/sparc/sun4m.c | 6 +++--- hw/sparc64/sun4u.c | 6 +++--- 3 files changed, 27 insertions(+), 27 deletions(-) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 631c6113b5c..0414e9df573 100644 --- a/hw/sparc/leon3.c +++ b/hw/sparc/leon3.c @@ -78,21 +78,21 @@ typedef struct ResetData { =20 static uint32_t *gen_store_u32(uint32_t *code, hwaddr addr, uint32_t val) { - stl_p(code++, 0x82100000); /* mov %g0, %g1 */ - stl_p(code++, 0x84100000); /* mov %g0, %g2 */ - stl_p(code++, 0x03000000 + + stl_be_p(code++, 0x82100000); /* mov %g0, %g1 */ + stl_be_p(code++, 0x84100000); /* mov %g0, %g2 */ + stl_be_p(code++, 0x03000000 + extract32(addr, 10, 22)); /* sethi %hi(addr), %g1 */ - stl_p(code++, 0x82106000 + + stl_be_p(code++, 0x82106000 + extract32(addr, 0, 10)); /* or %g1, addr, %g1 */ - stl_p(code++, 0x05000000 + + stl_be_p(code++, 0x05000000 + extract32(val, 10, 22)); /* sethi %hi(val), %g2 */ - stl_p(code++, 0x8410a000 + + stl_be_p(code++, 0x8410a000 + extract32(val, 0, 10)); /* or %g2, val, %g2 */ - stl_p(code++, 0xc4204000); /* st %g2, [ %g1 ] */ + stl_be_p(code++, 0xc4204000); /* st %g2, [ %g1 ] */ =20 return code; } @@ -112,13 +112,13 @@ static void write_bootloader(void *ptr, hwaddr kernel= _addr) =20 /* If we are running on a secondary CPU, jump directly to the kernel. = */ =20 - stl_p(p++, 0x85444000); /* rd %asr17, %g2 */ - stl_p(p++, 0x8530a01c); /* srl %g2, 0x1c, %g2 */ - stl_p(p++, 0x80908000); /* tst %g2 */ + stl_be_p(p++, 0x85444000); /* rd %asr17, %g2 */ + stl_be_p(p++, 0x8530a01c); /* srl %g2, 0x1c, %g2 */ + stl_be_p(p++, 0x80908000); /* tst %g2 */ /* Filled below. */ sec_cpu_branch_p =3D p; - stl_p(p++, 0x0BADC0DE); /* bne xxx */ - stl_p(p++, 0x01000000); /* nop */ + stl_be_p(p++, 0x0BADC0DE); /* bne xxx */ + stl_be_p(p++, 0x01000000); /* nop */ =20 /* Initialize the UARTs */ /* *UART_CONTROL =3D UART_RECEIVE_ENABLE | UART_TRANSMIT_ENABLE; */ @@ -133,17 +133,17 @@ static void write_bootloader(void *ptr, hwaddr kernel= _addr) p =3D gen_store_u32(p, 0x80000318, 3); =20 /* Now, the relative branch above can be computed. */ - stl_p(sec_cpu_branch_p, 0x12800000 - + (p - sec_cpu_branch_p)); + stl_be_p(sec_cpu_branch_p, 0x12800000 + + (p - sec_cpu_branch_p)); =20 /* JUMP to the entry point */ - stl_p(p++, 0x82100000); /* mov %g0, %g1 */ - stl_p(p++, 0x03000000 + extract32(kernel_addr, 10, 22)); - /* sethi %hi(kernel_addr), %g1 */ - stl_p(p++, 0x82106000 + extract32(kernel_addr, 0, 10)); - /* or kernel_addr, %g1 */ - stl_p(p++, 0x81c04000); /* jmp %g1 */ - stl_p(p++, 0x01000000); /* nop */ + stl_be_p(p++, 0x82100000); /* mov %g0, %g1 */ + stl_be_p(p++, 0x03000000 + extract32(kernel_addr, 10, 22)); + /* sethi %hi(kernel_addr), %g1 */ + stl_be_p(p++, 0x82106000 + extract32(kernel_addr, 0, 10)); + /* or kernel_addr, %g1 */ + stl_be_p(p++, 0x81c04000); /* jmp %g1 */ + stl_be_p(p++, 0x01000000); /* nop */ } =20 static void leon3_cpu_reset(void *opaque) diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index 53d7ae08ae9..52ca9586001 100644 --- a/hw/sparc/sun4m.c +++ b/hw/sparc/sun4m.c @@ -268,9 +268,9 @@ static unsigned long sun4m_load_kernel(const char *kern= el_filename, if (*initrd_size > 0) { for (i =3D 0; i < 64 * TARGET_PAGE_SIZE; i +=3D TARGET_PAGE_SI= ZE) { ptr =3D rom_ptr(KERNEL_LOAD_ADDR + i, 24); - if (ptr && ldl_p(ptr) =3D=3D 0x48647253) { /* HdrS */ - stl_p(ptr + 16, INITRD_LOAD_ADDR); - stl_p(ptr + 20, *initrd_size); + if (ptr && ldl_be_p(ptr) =3D=3D 0x48647253) { /* HdrS */ + stl_be_p(ptr + 16, INITRD_LOAD_ADDR); + stl_be_p(ptr + 20, *initrd_size); break; } } diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index 82c3e7c855b..e83c82fc9ae 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -206,9 +206,9 @@ static uint64_t sun4u_load_kernel(const char *kernel_fi= lename, if (*initrd_size > 0) { for (i =3D 0; i < 64 * TARGET_PAGE_SIZE; i +=3D TARGET_PAGE_SI= ZE) { ptr =3D rom_ptr(*kernel_addr + i, 32); - if (ptr && ldl_p(ptr + 8) =3D=3D 0x48647253) { /* HdrS */ - stl_p(ptr + 24, *initrd_addr + *kernel_addr); - stl_p(ptr + 28, *initrd_size); + if (ptr && ldl_be_p(ptr + 8) =3D=3D 0x48647253) { /* HdrS = */ + stl_be_p(ptr + 24, *initrd_addr + *kernel_addr); + stl_be_p(ptr + 28, *initrd_size); break; } } --=20 2.52.0