From nobody Mon Feb 9 06:08:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766162260; cv=none; d=zohomail.com; s=zohoarc; b=n/22ijU3ahWiHwtX8vr5jifpunnBEM1lUvCx0CRg1NGiTmfmj4OAHbr7xyiXv66VvdvZemQv+ePbdWxtaPOvwnqV29OX3gkgH9eh3E08bYMfvgIG+n1SLgZeutOBMRO6LKb558ag1C7O9QM9LbE4eRgZPg2yH3QOQU9899XJBh4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766162260; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9A1gr5CJUaSQgBXQcHovtENYxaFT/E0t2tXqegO2h5o=; b=QteA3yPpYl3z/btevCAlvxtDoVMxA3LpzKfuCCmBfLAi/qMfp3RErkpbUYpzeffQHJp+XMheA3gwKjq34lgdNoxulr70anMYGiWvfaeY24NcBJyIhPjTpUn0sycDKOyq4gtygGsxAxAUW6Da0uFwWoZhGpatKz5OqoA809owssg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176616226029316.257005844534888; Fri, 19 Dec 2025 08:37:40 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWdTX-0003Yo-7R; Fri, 19 Dec 2025 11:37:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWdTU-0003YF-7b for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:04 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWdTS-0000OX-KV for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:03 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4779aa4f928so18789055e9.1 for ; Fri, 19 Dec 2025 08:37:01 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d19362345sm50113335e9.6.2025.12.19.08.36.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Dec 2025 08:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766162219; x=1766767019; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9A1gr5CJUaSQgBXQcHovtENYxaFT/E0t2tXqegO2h5o=; b=O6jPT5kgvehHU5ayCeMO3BVV1/S8HmV769ujK4hZy5//ver7ont1KItVmUIre50Zlh tJvQW9paC+0s5y6ywGimzRuXye5fbaTQJcopE1G5Hjw4WUn9ACbF1ihLdFT/ivCBjJL4 7HwaQy1JdWFVidh2YA3+87xLHO/fWgizPTXQQf8mjUOqVER4QmHIeDms9BerBwhaiYdq TncNbfXApoxh7vFValaSHfuu+2oF6zIFEpi9GhUZM1ccQ8EulhvOclrrtQtBPUl1DmcX pBrbpvHfsPra/wjnUGyJlQHI+ngp8BopOGawg0Fm7tnCP7Bf687wui8cJb7D3ZAg5eIz E0Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766162219; x=1766767019; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9A1gr5CJUaSQgBXQcHovtENYxaFT/E0t2tXqegO2h5o=; b=lVyox+f9o84mEEuDKkLx+MYUzQZMfzLEvKigLzk7wV4wXloZHb17wyBbX10Tu144KP kLctULn5J9JDiHnNjEINr4xbz0Et1Rp66cgWiwPCH0eQNc2FC5MiYzv2eR6T07IQ5IF6 35emukjjh9yDGFb1tseQLGgYwvgT7dWFI8Ksq8meDJEsFkMw8NkNPLN9C+k8nOT+kaVq ho9NJGVYWDOs9s5VxPVVEsulMiIb1BiAyB7dp93H21ICi4Sb+xnFjvEado/CeJjjPxhc qaqBAi2QuuIuaMML5oF0k9xHG2RhEoNAeTJ2u8lZm6CMNuQBHWMNdkJR71p7yVpZnE09 JJ3Q== X-Gm-Message-State: AOJu0Yy7fofpsEk9AZdeXpEgfa6gEhVwfsg8W3iK489hugxin+e5QvDB U2hDzTQWAtxEGvMwiHfyVRrbaPfx4/vIkoJRGz6Pe2lqxihbRA5Dqa+PDFuR1tpCzP1HdAqrTMs TkWeEqyg= X-Gm-Gg: AY/fxX6zrtJdsG+oFgZjfev7VeY3NzzYSpq8j//bxmG6JhoYcHzj0hsHlqsoccfuKed O8xqIpMdOtO48p0ZX72p0B/feaBfhY5zcK7OU5oXrDKDd5+nzNJ0QcGU+MrbRNHBcVH1NsasS88 KI3XK0L7aWPfSTOPY2D3IFZrRdGgDUa4q3UqQoNW2tSjQoAxiHlchvBVpzHJiBrTof0LivcpBIj ORlpQao/99T18aO4Gt/wGQvuG+BqotY1aBZ2ijsFK8tEsQveObu1UYV5EN+8MgfF1ox4gbFFflE UB/f8KutRSVhgGRmbJNmMynOSTbrgwqJbgG87OubHtmIXA0KvMtgZeR/fAdjob3LmaiLGJYf3nU Mb8y0hS9WUTj9mqFQhhVD7XjuGNNxVBFCAQhtN66ZvA9V54SchibirJB3nHjJCyGH4MZSv1fKzK PJY506BhC717b9OI4Zn8gpflgcQiimombaTkkP0E/LDUG42zdloFZL5IQXFh0j X-Google-Smtp-Source: AGHT+IHqfPjEiCUzly+R6Ir7twXbDm4Ht/xvz7hKR8Sd7YghV0bPZiuSrvkWK6dc79ozNsMX7BAjpQ== X-Received: by 2002:a05:600c:1d1d:b0:477:9eb8:97d2 with SMTP id 5b1f17b1804b1-47d1953b8acmr34176285e9.8.1766162219499; Fri, 19 Dec 2025 08:36:59 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Artyom Tarasenko , Anton Johansson , Richard Henderson , Laurent Vivier , Frederic Konrad , Mark Cave-Ayland , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 1/9] hw/sparc: Use explicit big-endian LD/ST API Date: Fri, 19 Dec 2025 17:36:41 +0100 Message-ID: <20251219163650.74303-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251219163650.74303-1-philmd@linaro.org> References: <20251219163650.74303-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766162262241158500 The SPARC architecture uses big endianness. Directly use the big-endian LD/ST API. Mechanical change running: $ for a in uw w l q; do \ sed -i -e "s/ld${a}_p(/ld${a}_be_p(/" \ $(git grep -wlE '(ld|st)u?[wlq]_p' hw/sparc*/); done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland Reviewed-by: Chigot Cl=C3=A9ment --- hw/sparc/leon3.c | 42 +++++++++++++++++++++--------------------- hw/sparc/sun4m.c | 6 +++--- hw/sparc64/sun4u.c | 6 +++--- 3 files changed, 27 insertions(+), 27 deletions(-) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 631c6113b5c..0414e9df573 100644 --- a/hw/sparc/leon3.c +++ b/hw/sparc/leon3.c @@ -78,21 +78,21 @@ typedef struct ResetData { =20 static uint32_t *gen_store_u32(uint32_t *code, hwaddr addr, uint32_t val) { - stl_p(code++, 0x82100000); /* mov %g0, %g1 */ - stl_p(code++, 0x84100000); /* mov %g0, %g2 */ - stl_p(code++, 0x03000000 + + stl_be_p(code++, 0x82100000); /* mov %g0, %g1 */ + stl_be_p(code++, 0x84100000); /* mov %g0, %g2 */ + stl_be_p(code++, 0x03000000 + extract32(addr, 10, 22)); /* sethi %hi(addr), %g1 */ - stl_p(code++, 0x82106000 + + stl_be_p(code++, 0x82106000 + extract32(addr, 0, 10)); /* or %g1, addr, %g1 */ - stl_p(code++, 0x05000000 + + stl_be_p(code++, 0x05000000 + extract32(val, 10, 22)); /* sethi %hi(val), %g2 */ - stl_p(code++, 0x8410a000 + + stl_be_p(code++, 0x8410a000 + extract32(val, 0, 10)); /* or %g2, val, %g2 */ - stl_p(code++, 0xc4204000); /* st %g2, [ %g1 ] */ + stl_be_p(code++, 0xc4204000); /* st %g2, [ %g1 ] */ =20 return code; } @@ -112,13 +112,13 @@ static void write_bootloader(void *ptr, hwaddr kernel= _addr) =20 /* If we are running on a secondary CPU, jump directly to the kernel. = */ =20 - stl_p(p++, 0x85444000); /* rd %asr17, %g2 */ - stl_p(p++, 0x8530a01c); /* srl %g2, 0x1c, %g2 */ - stl_p(p++, 0x80908000); /* tst %g2 */ + stl_be_p(p++, 0x85444000); /* rd %asr17, %g2 */ + stl_be_p(p++, 0x8530a01c); /* srl %g2, 0x1c, %g2 */ + stl_be_p(p++, 0x80908000); /* tst %g2 */ /* Filled below. */ sec_cpu_branch_p =3D p; - stl_p(p++, 0x0BADC0DE); /* bne xxx */ - stl_p(p++, 0x01000000); /* nop */ + stl_be_p(p++, 0x0BADC0DE); /* bne xxx */ + stl_be_p(p++, 0x01000000); /* nop */ =20 /* Initialize the UARTs */ /* *UART_CONTROL =3D UART_RECEIVE_ENABLE | UART_TRANSMIT_ENABLE; */ @@ -133,17 +133,17 @@ static void write_bootloader(void *ptr, hwaddr kernel= _addr) p =3D gen_store_u32(p, 0x80000318, 3); =20 /* Now, the relative branch above can be computed. */ - stl_p(sec_cpu_branch_p, 0x12800000 - + (p - sec_cpu_branch_p)); + stl_be_p(sec_cpu_branch_p, 0x12800000 + + (p - sec_cpu_branch_p)); =20 /* JUMP to the entry point */ - stl_p(p++, 0x82100000); /* mov %g0, %g1 */ - stl_p(p++, 0x03000000 + extract32(kernel_addr, 10, 22)); - /* sethi %hi(kernel_addr), %g1 */ - stl_p(p++, 0x82106000 + extract32(kernel_addr, 0, 10)); - /* or kernel_addr, %g1 */ - stl_p(p++, 0x81c04000); /* jmp %g1 */ - stl_p(p++, 0x01000000); /* nop */ + stl_be_p(p++, 0x82100000); /* mov %g0, %g1 */ + stl_be_p(p++, 0x03000000 + extract32(kernel_addr, 10, 22)); + /* sethi %hi(kernel_addr), %g1 */ + stl_be_p(p++, 0x82106000 + extract32(kernel_addr, 0, 10)); + /* or kernel_addr, %g1 */ + stl_be_p(p++, 0x81c04000); /* jmp %g1 */ + stl_be_p(p++, 0x01000000); /* nop */ } =20 static void leon3_cpu_reset(void *opaque) diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index 53d7ae08ae9..52ca9586001 100644 --- a/hw/sparc/sun4m.c +++ b/hw/sparc/sun4m.c @@ -268,9 +268,9 @@ static unsigned long sun4m_load_kernel(const char *kern= el_filename, if (*initrd_size > 0) { for (i =3D 0; i < 64 * TARGET_PAGE_SIZE; i +=3D TARGET_PAGE_SI= ZE) { ptr =3D rom_ptr(KERNEL_LOAD_ADDR + i, 24); - if (ptr && ldl_p(ptr) =3D=3D 0x48647253) { /* HdrS */ - stl_p(ptr + 16, INITRD_LOAD_ADDR); - stl_p(ptr + 20, *initrd_size); + if (ptr && ldl_be_p(ptr) =3D=3D 0x48647253) { /* HdrS */ + stl_be_p(ptr + 16, INITRD_LOAD_ADDR); + stl_be_p(ptr + 20, *initrd_size); break; } } diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index 82c3e7c855b..e83c82fc9ae 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -206,9 +206,9 @@ static uint64_t sun4u_load_kernel(const char *kernel_fi= lename, if (*initrd_size > 0) { for (i =3D 0; i < 64 * TARGET_PAGE_SIZE; i +=3D TARGET_PAGE_SI= ZE) { ptr =3D rom_ptr(*kernel_addr + i, 32); - if (ptr && ldl_p(ptr + 8) =3D=3D 0x48647253) { /* HdrS */ - stl_p(ptr + 24, *initrd_addr + *kernel_addr); - stl_p(ptr + 28, *initrd_size); + if (ptr && ldl_be_p(ptr + 8) =3D=3D 0x48647253) { /* HdrS = */ + stl_be_p(ptr + 24, *initrd_addr + *kernel_addr); + stl_be_p(ptr + 28, *initrd_size); break; } } --=20 2.52.0 From nobody Mon Feb 9 06:08:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766162260; cv=none; d=zohomail.com; s=zohoarc; b=ZaPAvjro6XyZ5yqORgQufpPzqzKqhc++7CRgPI4W3tKkL41/f+Ff0sFCC6Rs7ddvPIFYh3iWNz87OwuyeT52KCdwmnIMhIs/C9zPx8K6aXPRUgWrEnbFDeL+yBMQlUdwmiLJylkpVUuM3JG7Zx3ZyfrPPV1mb5H/gFOqtQd6otQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766162260; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2pPXI/RNd4YhskZ4GDGLaQPSNUsmTt2IQzm/8dEFuWw=; b=GzVOv27Cbjf8aoLEdxf9h+tZ14DEqUEB3jMgkXbD2H4KDEvv59EJ3AvDZ0hV/xjhch9FjTO2V6Bd66fwTidLDU3V5fbeCIXNV8bO05yBdBOoO4g9alD3zIZuUSuy9rP+5dZH3wzJsOonK3HcDUHDFZSJT6h8yB/ZiYz6Yswxf0g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766162260363109.15681994825468; Fri, 19 Dec 2025 08:37:40 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWdTe-0003Zp-IH; Fri, 19 Dec 2025 11:37:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWdTc-0003ZT-HA for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:12 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWdTY-0000PG-F5 for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:10 -0500 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-42fb03c3cf2so1046406f8f.1 for ; Fri, 19 Dec 2025 08:37:08 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea227e0sm6047164f8f.17.2025.12.19.08.37.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Dec 2025 08:37:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766162227; x=1766767027; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2pPXI/RNd4YhskZ4GDGLaQPSNUsmTt2IQzm/8dEFuWw=; b=Ds2trsHKtOB139NpIustwiw2abp1P+gO7ppMjWLZ/5txUyJOoCbild7r+uiU9JZhli ITA4LX8eNk/FG1LhfIa0O5y8JT6pFKhuGBqUO6ca42lYi/YhvkOCwxQO/VjmmbV4Z/g8 77ZaTHDAWUjS7ei71jt2xy7Yzz6e0gzF8UEkxqMsu5rGMomhP9kns92AndGK8sxJtjnq +S1B/QPYZXMa0+JRyaxiASvzyOinWfHLjOxVsupJRJyawo9GxkhNPkU2D2odOHuZmcbb ZXY3i/BrxzRymptQc9WFUKcX60CSfoFMX5EvZJQ4CM68wapTLeuG6m6aXt1eSESQmgcH yVoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766162227; x=1766767027; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2pPXI/RNd4YhskZ4GDGLaQPSNUsmTt2IQzm/8dEFuWw=; b=O7ua+5QZtU3JSLePKqVUK9+KNmYD6bMJTl7Kc0HUEN8LwnjfVK+f9yBwa6ZQMGQHGV I/jGwquk86ZTvB4iDtnqOn40DMaujKDvX1qdgdOfu2+qlUjbZS6+QYd0OrlQqAymaH0b FSbSy7TNZJo5gUayTG0pkyQzs1MeNtrSuxNqAt0DiGT707/7E34j0493eVt4pcuU1uCz /7X7nL+IOryIlV/8CuF/cnEq6Ogrhx3/cwzpQ/zn/W83odHf5P21IpfK0Xkd6EEWozG5 CNxyD4iW5PbKkK46JC0ThrVNrbG+T6z+j8JmR09cp+MlPRuhoytVhvlBnPkhuQouvGCB ud3w== X-Gm-Message-State: AOJu0YxZB1xtFUcXsNz+Q5I2xiKg8rnTER9oyTtq68ULquLVmEnqch1I oU5oHDWCqv4d92Mbn0MbeFVeuDXj3xzvHKo1WNETLAFob//WxT5F/rR2QuFgD3NG+OEJzn8LcCK vd8SI5qo= X-Gm-Gg: AY/fxX7dddIkKkeLyED8fWVU01LsFqTz/fkA3zr+aeHwUpFqwpLH2rSES41uVTkKP3N LY4IlQ0yppY4s5NUBkzmOdIFEWyRPdQYDDxTjZRx204xxc2fCcFWneA+IAa5GZLAsYZnEojz2tU WJv8RFUG33FfosW50I9xAxsYy31Kf9I1b6PEvwpK2HEfed/bvLuY4Ea+nXbFQuH6/ovUMUYfnkl kLKVZ9IONgHxqrdIRJt791BjLBJthR3c6sh8wITZWZh3xq+wdnrng/jsnq6+9OeOcNQ9P9KF1W5 Cg5rvN/8gcw0pEjJHpyRLppO6Di61fvRNc9/BuYjJZvTucvgenqVyMwjGP6oyTjYMxNtWrQHfH7 I+hzkxhP1kGAxv3ZWPUw26cWahgN7qvmLmG/XqxAe9F4BfpMKVqNAVEdGO1aS0VjXa984C9jg9q iNgZH3vJTVVMbypaNQikVWfnxFKKzS/KmzaVbu1u7J/z8jzCTChYqHeCcQhxDa X-Google-Smtp-Source: AGHT+IG7Toirw4C2eKFF8gBoWapWKoDH4p3CXC20xRGBgUu1amTW+wnUSpU3KeuRQe9/r33fo/flDQ== X-Received: by 2002:a05:6000:430a:b0:42f:9f18:8f59 with SMTP id ffacd0b85a97d-4324e50b471mr4002697f8f.42.1766162226489; Fri, 19 Dec 2025 08:37:06 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Artyom Tarasenko , Anton Johansson , Richard Henderson , Laurent Vivier , Frederic Konrad , Mark Cave-Ayland , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 2/9] target/sparc: Replace MO_TE -> MO_BE Date: Fri, 19 Dec 2025 17:36:42 +0100 Message-ID: <20251219163650.74303-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251219163650.74303-1-philmd@linaro.org> References: <20251219163650.74303-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766162262285158500 We only build the SPARC targets using big endianness order, therefore the MO_TE definitions expand to the big endian one. Use the latter which is more explicit. Mechanical change running: $ sed -i -e s/MO_TE/MO_BE/ \ $(git grep -wl MO_TE target/sparc/) Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/ldst_helper.c | 6 ++-- target/sparc/translate.c | 58 +++++++++++++++++++------------------- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 2c63eb9e036..a87a0b3eee0 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -1169,7 +1169,7 @@ uint64_t helper_ld_code(CPUSPARCState *env, target_ul= ong addr, uint32_t oi) break; case MO_16: ret =3D cpu_ldw_code_mmu(env, addr, oi, ra); - if ((mop & MO_BSWAP) !=3D MO_TE) { + if ((mop & MO_BSWAP) !=3D MO_BE) { ret =3D bswap16(ret); } if (mop & MO_SIGN) { @@ -1178,7 +1178,7 @@ uint64_t helper_ld_code(CPUSPARCState *env, target_ul= ong addr, uint32_t oi) break; case MO_32: ret =3D cpu_ldl_code_mmu(env, addr, oi, ra); - if ((mop & MO_BSWAP) !=3D MO_TE) { + if ((mop & MO_BSWAP) !=3D MO_BE) { ret =3D bswap32(ret); } if (mop & MO_SIGN) { @@ -1187,7 +1187,7 @@ uint64_t helper_ld_code(CPUSPARCState *env, target_ul= ong addr, uint32_t oi) break; case MO_64: ret =3D cpu_ldq_code_mmu(env, addr, oi, ra); - if ((mop & MO_BSWAP) !=3D MO_TE) { + if ((mop & MO_BSWAP) !=3D MO_BE) { ret =3D bswap64(ret); } break; diff --git a/target/sparc/translate.c b/target/sparc/translate.c index d6b599b71fe..23079697f52 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -1764,7 +1764,7 @@ static DisasASI resolve_asi(DisasContext *dc, int asi= , MemOp memop) case ASI_FL16_SL: case ASI_FL16_P: case ASI_FL16_PL: - memop =3D MO_TEUW; + memop =3D MO_BEUW; type =3D GET_ASI_SHORT; break; } @@ -2215,7 +2215,7 @@ static void gen_ldda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) * byte swapped. We perform one 128-bit LE load, so must swap * the order of the writebacks. */ - if ((mop & MO_BSWAP) =3D=3D MO_TE) { + if ((mop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_extr_i128_i64(lo, hi, t); } else { tcg_gen_extr_i128_i64(hi, lo, t); @@ -2235,7 +2235,7 @@ static void gen_ldda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) /* Note that LE ldda acts as if each 32-bit register result is byte swapped. Having just performed one 64-bit bswap, we need now to swap the writebacks. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_extr_i64_tl(lo, hi, tmp); } else { tcg_gen_extr_i64_tl(hi, lo, tmp); @@ -2252,7 +2252,7 @@ static void gen_ldda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) gen_helper_ld_code(tmp, tcg_env, addr, tcg_constant_i32(oi)); =20 /* See above. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_extr_i64_tl(lo, hi, tmp); } else { tcg_gen_extr_i64_tl(hi, lo, tmp); @@ -2277,7 +2277,7 @@ static void gen_ldda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) gen_helper_ld_asi(tmp, tcg_env, addr, r_asi, r_mop); =20 /* See above. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_extr_i64_tl(lo, hi, tmp); } else { tcg_gen_extr_i64_tl(hi, lo, tmp); @@ -2310,7 +2310,7 @@ static void gen_stda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) * byte swapped. We perform one 128-bit LE store, so must swap * the order of the construction. */ - if ((mop & MO_BSWAP) =3D=3D MO_TE) { + if ((mop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_concat_i64_i128(t, lo, hi); } else { tcg_gen_concat_i64_i128(t, hi, lo); @@ -2329,7 +2329,7 @@ static void gen_stda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) /* Note that LE stda acts as if each 32-bit register result is byte swapped. We will perform one 64-bit LE store, so now we must swap the order of the construction. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_concat_tl_i64(t64, lo, hi); } else { tcg_gen_concat_tl_i64(t64, hi, lo); @@ -2345,7 +2345,7 @@ static void gen_stda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) * See comments for GET_ASI_COPY above. */ { - MemOp mop =3D MO_TE | MO_128 | MO_ATOM_IFALIGN_PAIR; + MemOp mop =3D MO_BE | MO_128 | MO_ATOM_IFALIGN_PAIR; TCGv_i64 t8 =3D tcg_temp_new_i64(); TCGv_i128 t16 =3D tcg_temp_new_i128(); TCGv daddr =3D tcg_temp_new(); @@ -2368,7 +2368,7 @@ static void gen_stda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) TCGv_i64 t64 =3D tcg_temp_new_i64(); =20 /* See above. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_concat_tl_i64(t64, lo, hi); } else { tcg_gen_concat_tl_i64(t64, hi, lo); @@ -4428,13 +4428,13 @@ static bool do_ld_gpr(DisasContext *dc, arg_r_r_ri_= asi *a, MemOp mop) return advance_pc(dc); } =20 -TRANS(LDUW, ALL, do_ld_gpr, a, MO_TEUL) +TRANS(LDUW, ALL, do_ld_gpr, a, MO_BEUL) TRANS(LDUB, ALL, do_ld_gpr, a, MO_UB) -TRANS(LDUH, ALL, do_ld_gpr, a, MO_TEUW) +TRANS(LDUH, ALL, do_ld_gpr, a, MO_BEUW) TRANS(LDSB, ALL, do_ld_gpr, a, MO_SB) -TRANS(LDSH, ALL, do_ld_gpr, a, MO_TESW) -TRANS(LDSW, 64, do_ld_gpr, a, MO_TESL) -TRANS(LDX, 64, do_ld_gpr, a, MO_TEUQ) +TRANS(LDSH, ALL, do_ld_gpr, a, MO_BESW) +TRANS(LDSW, 64, do_ld_gpr, a, MO_BESL) +TRANS(LDX, 64, do_ld_gpr, a, MO_BEUQ) =20 static bool do_st_gpr(DisasContext *dc, arg_r_r_ri_asi *a, MemOp mop) { @@ -4451,10 +4451,10 @@ static bool do_st_gpr(DisasContext *dc, arg_r_r_ri_= asi *a, MemOp mop) return advance_pc(dc); } =20 -TRANS(STW, ALL, do_st_gpr, a, MO_TEUL) +TRANS(STW, ALL, do_st_gpr, a, MO_BEUL) TRANS(STB, ALL, do_st_gpr, a, MO_UB) -TRANS(STH, ALL, do_st_gpr, a, MO_TEUW) -TRANS(STX, 64, do_st_gpr, a, MO_TEUQ) +TRANS(STH, ALL, do_st_gpr, a, MO_BEUW) +TRANS(STX, 64, do_st_gpr, a, MO_BEUQ) =20 static bool trans_LDD(DisasContext *dc, arg_r_r_ri_asi *a) { @@ -4468,7 +4468,7 @@ static bool trans_LDD(DisasContext *dc, arg_r_r_ri_as= i *a) if (addr =3D=3D NULL) { return false; } - da =3D resolve_asi(dc, a->asi, MO_TEUQ); + da =3D resolve_asi(dc, a->asi, MO_BEUQ); gen_ldda_asi(dc, &da, addr, a->rd); return advance_pc(dc); } @@ -4485,7 +4485,7 @@ static bool trans_STD(DisasContext *dc, arg_r_r_ri_as= i *a) if (addr =3D=3D NULL) { return false; } - da =3D resolve_asi(dc, a->asi, MO_TEUQ); + da =3D resolve_asi(dc, a->asi, MO_BEUQ); gen_stda_asi(dc, &da, addr, a->rd); return advance_pc(dc); } @@ -4516,7 +4516,7 @@ static bool trans_SWAP(DisasContext *dc, arg_r_r_ri_a= si *a) if (addr =3D=3D NULL) { return false; } - da =3D resolve_asi(dc, a->asi, MO_TEUL); + da =3D resolve_asi(dc, a->asi, MO_BEUL); =20 dst =3D gen_dest_gpr(dc, a->rd); src =3D gen_load_gpr(dc, a->rd); @@ -4544,8 +4544,8 @@ static bool do_casa(DisasContext *dc, arg_r_r_ri_asi = *a, MemOp mop) return advance_pc(dc); } =20 -TRANS(CASA, CASA, do_casa, a, MO_TEUL) -TRANS(CASXA, 64, do_casa, a, MO_TEUQ) +TRANS(CASA, CASA, do_casa, a, MO_BEUL) +TRANS(CASXA, 64, do_casa, a, MO_BEUQ) =20 static bool do_ld_fpr(DisasContext *dc, arg_r_r_ri_asi *a, MemOp sz) { @@ -4561,7 +4561,7 @@ static bool do_ld_fpr(DisasContext *dc, arg_r_r_ri_as= i *a, MemOp sz) if (sz =3D=3D MO_128 && gen_trap_float128(dc)) { return true; } - da =3D resolve_asi(dc, a->asi, MO_TE | sz); + da =3D resolve_asi(dc, a->asi, MO_BE | sz); gen_ldf_asi(dc, &da, sz, addr, a->rd); gen_update_fprs_dirty(dc, a->rd); return advance_pc(dc); @@ -4590,7 +4590,7 @@ static bool do_st_fpr(DisasContext *dc, arg_r_r_ri_as= i *a, MemOp sz) if (sz =3D=3D MO_128 && gen_trap_float128(dc)) { return true; } - da =3D resolve_asi(dc, a->asi, MO_TE | sz); + da =3D resolve_asi(dc, a->asi, MO_BE | sz); gen_stf_asi(dc, &da, sz, addr, a->rd); return advance_pc(dc); } @@ -4629,7 +4629,7 @@ static bool trans_STDFQ(DisasContext *dc, arg_STDFQ *= a) /* Store the single element from the queue. */ TCGv_i64 fq =3D tcg_temp_new_i64(); tcg_gen_ld_i64(fq, tcg_env, offsetof(CPUSPARCState, fq.d)); - tcg_gen_qemu_st_i64(fq, addr, dc->mem_idx, MO_TEUQ | MO_ALIGN_4); + tcg_gen_qemu_st_i64(fq, addr, dc->mem_idx, MO_BEUQ | MO_ALIGN_4); =20 /* Mark the queue empty, transitioning to fp_execute state. */ tcg_gen_st_i32(tcg_constant_i32(0), tcg_env, @@ -4655,7 +4655,7 @@ static bool trans_LDFSR(DisasContext *dc, arg_r_r_ri = *a) } =20 tmp =3D tcg_temp_new_i32(); - tcg_gen_qemu_ld_i32(tmp, addr, dc->mem_idx, MO_TEUL | MO_ALIGN); + tcg_gen_qemu_ld_i32(tmp, addr, dc->mem_idx, MO_BEUL | MO_ALIGN); =20 tcg_gen_extract_i32(cpu_fcc[0], tmp, FSR_FCC0_SHIFT, 2); /* LDFSR does not change FCC[1-3]. */ @@ -4679,7 +4679,7 @@ static bool do_ldxfsr(DisasContext *dc, arg_r_r_ri *a= , bool entire) } =20 t64 =3D tcg_temp_new_i64(); - tcg_gen_qemu_ld_i64(t64, addr, dc->mem_idx, MO_TEUQ | MO_ALIGN); + tcg_gen_qemu_ld_i64(t64, addr, dc->mem_idx, MO_BEUQ | MO_ALIGN); =20 lo =3D tcg_temp_new_i32(); hi =3D cpu_fcc[3]; @@ -4722,8 +4722,8 @@ static bool do_stfsr(DisasContext *dc, arg_r_r_ri *a,= MemOp mop) return advance_pc(dc); } =20 -TRANS(STFSR, ALL, do_stfsr, a, MO_TEUL) -TRANS(STXFSR, 64, do_stfsr, a, MO_TEUQ) +TRANS(STFSR, ALL, do_stfsr, a, MO_BEUL) +TRANS(STXFSR, 64, do_stfsr, a, MO_BEUQ) =20 static bool do_fc(DisasContext *dc, int rd, int32_t c) { --=20 2.52.0 From nobody Mon Feb 9 06:08:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766162277; cv=none; d=zohomail.com; s=zohoarc; b=h7qilZi1LX2kj246fuiR0HHANhAEJILtKOqRN/PYtJOXcTKaNRT0iuWM3dzx6tMqZ6fNBCa3M3ABmu9Izfnh3AfqueI5aMmz4DkJEEZPpZsozMcfnWTXJqCNCEymGku9HuzxPPZx0M0vGhQG419dpjn/iJXbm3tC5jJTsZW7LtM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766162277; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TY+NKK5QrerogI70RsrGnC20hTX4QQeP/jfJOPR/wec=; b=hbpGzZwujSk/86ZL+LdNORdHMVAH8bhE/faE88Gxf+1QnuKXZqPNZMZuOIqycfXJitgR8YWyn/Lbk1IGMIovqcTrSI7FEug4kdEmXkNgHTjpYVcpxG8tW/ZC7s08CivJhY8fRHatMJqfa9mn9dSiOjXo7Wq41K+gyX7tc9KG5XE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766162276988239.09772568140636; Fri, 19 Dec 2025 08:37:56 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWdTk-0003ae-IM; Fri, 19 Dec 2025 11:37:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWdTj-0003aJ-3T for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:19 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWdTh-0000Q3-Ki for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:18 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-477a2ab455fso19209135e9.3 for ; Fri, 19 Dec 2025 08:37:15 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d1936d220sm53976365e9.8.2025.12.19.08.37.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Dec 2025 08:37:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766162233; x=1766767033; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TY+NKK5QrerogI70RsrGnC20hTX4QQeP/jfJOPR/wec=; b=gvBv1xrY0QScZkc1faTe2pgbKFN4CQvDaXMgStLmVLkzBAwuVWfNlPMGIXLubvw11S DOxKKQQyjxPRyJ+pDx8U+CUWEBlsVKCNs6jOPdBmxWPGcYnHsFemdsvZ42Sv7BOKsWN+ XLOf3vVQchS9RqTMZdpcbRtxYV9HdijRRM4g4gi6EA9xhpddsM2V01DlS0kd52cmKyAw N5GwGZjWvtqdhH5o6fg+zHUAbnHncDyxIknEn6/2EBoSQNzC04LyUVvFIqhK5ESa65m7 748nrZ9p0oWGBLeeKJV+CLqj3qAN7KVFEn9Bs9CrfkbUmPVBQ/Ej0ifjrvhRzshX/ggU WwiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766162233; x=1766767033; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TY+NKK5QrerogI70RsrGnC20hTX4QQeP/jfJOPR/wec=; b=YhxGc1gJIkStwRmxSgZwDdTPW2QQHWj1kTqTEl2YEYozh7MR5nlhyiNoTSnrUDfWBk g6tYKUIY0khC1VpzXmBlFO3ge7qgkwwQ6LjDgdYPYDS3Xl9AmP34K5n8BhL6zzP+SpG5 jJ8Be1YXihtWKH/NHq1QfGMaKYabRznKXZEgnByTkgRK+Cdt8cKiGqpzrl2CfYCTgk0s 2HeMfXr+jDuLVHESR5+Lt7/7mezlchPyC5cQccYIR4EAj1N35uugq4KgBm+wo8gmUFHl HU2mGceUFhN9FYG8eeYjumGutaIMM0yd1VKGZN1O4xG9K9bxZyReVx1NafBmSi9dO+h3 ypcg== X-Gm-Message-State: AOJu0YycZ5VcfZHjAYqSa0UOgLwZ/6tEj3WIspm0DHEzrUkosed2kWGq PRKi1q5gMCJRm95YsUwUYJ3VYNemo2/PS39n1umItieiPtZZz1nk/nqasWgmaNA/FE32pdvl1iv ik13RR8g= X-Gm-Gg: AY/fxX6IfCSCFsYLgwfsHXLfGIq8XBjeqdWNQCTxPgD8h3UF6rvs5ee0JlfZ1bJU31V io9xgULUN2HYH4/UKHXC0M7a1Yfp9WlPIyzk1LP1FAr1mN/bMEkhB7EEEoGa244yMPcwFwtz8BI HVmuTIeYJmgKvneyOg5g+g6iZIaOsllvfFvFNMwKJ9BS/nU6kn+TOrPnY5D5Cu2rkRn1E0pIcGN RyP2MCrX5fOzY8YuEupwPepvbU6Lci8Ze+exmWLjgiNVv2zz+WO8K6X7jp00T1Quw7u8nDaqKHr h0DEQBEYROFiEr6h5zs446xpFjen48MM3XdtbHjP5/TC2UOixIvVHlsCw4nNRN19BmbztjSG8i8 di5PYc1TWuk930z5i6onK/GB21SG7O3gp9T9adLtnQrLoL18ufBoanlJwslP1dYXxqcJ0qEgOuG b+B6LvZ5KJgOgNOZaXz2J3B+m9Yje3Yv1NrHohj72AOFqPybimlGyATJiReDKd X-Google-Smtp-Source: AGHT+IEcLPlqf7J+bzderohbYPYsunZArQQqGrvtwE2ok8qIrAqefFxt3a1S3zG4+zC2SyUPD1VOIA== X-Received: by 2002:a05:600c:c08a:b0:46e:1abc:1811 with SMTP id 5b1f17b1804b1-47d197f67edmr24265185e9.27.1766162233572; Fri, 19 Dec 2025 08:37:13 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Artyom Tarasenko , Anton Johansson , Richard Henderson , Laurent Vivier , Frederic Konrad , Mark Cave-Ayland , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 3/9] target/sparc: Use address_space_ld/st[n]_be() in ld/st_asi helpers Date: Fri, 19 Dec 2025 17:36:43 +0100 Message-ID: <20251219163650.74303-4-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251219163650.74303-1-philmd@linaro.org> References: <20251219163650.74303-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766162278153158502 Do not open-code address_space_{ld,st}n(), use it passing the access size as argument. Directly expand to the big-endian variant (with the '_be' suffix) since we only build the SPARC targets as big-endian. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/ldst_helper.c | 42 ++++---------------------------------- 1 file changed, 4 insertions(+), 38 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index a87a0b3eee0..e9139814c26 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -701,25 +701,8 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_ulon= g addr, MemTxResult result; hwaddr access_addr =3D (hwaddr)addr | ((hwaddr)(asi & 0xf) << 32); =20 - switch (size) { - case 1: - ret =3D address_space_ldub(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 2: - ret =3D address_space_lduw(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); - break; - default: - case 4: - ret =3D address_space_ldl(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 8: - ret =3D address_space_ldq(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); - break; - } + ret =3D address_space_ldn_be(cs->as, access_addr, size, + MEMTXATTRS_UNSPECIFIED, &result); =20 if (result !=3D MEMTX_OK) { sparc_raise_mmu_fault(cs, access_addr, false, false, false, @@ -1066,25 +1049,8 @@ void helper_st_asi(CPUSPARCState *env, target_ulong = addr, uint64_t val, MemTxResult result; hwaddr access_addr =3D (hwaddr)addr | ((hwaddr)(asi & 0xf) << = 32); =20 - switch (size) { - case 1: - address_space_stb(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 2: - address_space_stw(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 4: - default: - address_space_stl(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 8: - address_space_stq(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); - break; - } + address_space_stn_be(cs->as, access_addr, val, size, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { sparc_raise_mmu_fault(cs, access_addr, true, false, false, size, GETPC()); --=20 2.52.0 From nobody Mon Feb 9 06:08:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766162287; cv=none; d=zohomail.com; s=zohoarc; b=FWSXhKT8XqJaEvheF66s6FHnItsDX4csqjlwMmbae2FQBaTEOqXKxEKvmXBDLILJ4wPIvpIjrt87bIYTntn+e+RUdqwnM1aGddDJ6JQlfOMdfxDjOZNuz1jWtM17ae6N7DPg7dknhaGNzdFHAnyCjSXaqJyP1lzpNUZ4k/b6/OE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766162287; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=F9motHBrqMt24s1IQyPulB1xIC/+4lJ6JZJS5crr6M0=; b=NzV34HtloAsdSfgsdbuVQ5boxySg+fVfuDwHrRaS99J9QkJNCxOALBEQUqDc+Pam5bS6Y+AWsHavpUYiHjgW3hZa6v/JFzGRw2eY/fZoVEn4d3K0561njLCwDhiUqAJQSLN42vQkfJuFo+3+R2h+1dSDTVXtDoo1tHpiZu49VrQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766162287831978.2034694822668; Fri, 19 Dec 2025 08:38:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWdTq-0003bK-IK; Fri, 19 Dec 2025 11:37:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWdTo-0003b5-Ts for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:24 -0500 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWdTm-0000Qh-PW for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:24 -0500 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-43246af170aso1152665f8f.0 for ; Fri, 19 Dec 2025 08:37:22 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea2267fsm5741288f8f.12.2025.12.19.08.37.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Dec 2025 08:37:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766162241; x=1766767041; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F9motHBrqMt24s1IQyPulB1xIC/+4lJ6JZJS5crr6M0=; b=owDoJChSXD8wFdrhCINEtXevmP6BLHcAVK3G32wUsIgYPZjRxJYulZrO6oNAp6itTT N5VU4CUxhXe1aX2s5mt0RU1ar6X+SfCIgtjy/0Rsig/nJlZSUunmcX60Fzf53KcvpMOb zCr9H4fwwQkoyYHie7/rOdkFQEuTRMDaI2wdIJj0OExJOxo7Jk0cAvsjM4UULB1qUEVa jSfNa5fexRC6I0y6vTBxrg/xxDKKxxWIacTQjqXYdg7zsmowwOJjtjgt+Onq7qISE7xU ZQjybnNLVUaDPrN6I1CzEIdLKbwIqP8Rtp3ooJ5wK2OpQcQ2CL9CKSwO1vYlDOeW5Aaz 69ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766162241; x=1766767041; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=F9motHBrqMt24s1IQyPulB1xIC/+4lJ6JZJS5crr6M0=; b=sQp5PA/tWQVBfRTQ+0tq7Ot2E9Wq1B67yyTr/CDI9CdZX5ySygfYrTh0qjZNXZ08Oz uL0DFiMkHZ03Ih+j1KCloGT1t5HdJ5pImSGvS1JErsc8Wjng0nitXlKEnPjPVzEY61iS 2WWNVenKhJX+S9TIONpQz+cj0fNcv7p9v1SsCL0tYXzS/rCiuw2X+jizFtZLYHwQjG0F jAyRKgXzbJMXecmPvbdePmywM7o175PoORwNUoj4E1EdF+0biKEOJoBbsAsDlq/2jGKQ rLch2fiG7HcFSo1Ma9c09lt3H6qPXDu8cwTDM442TfWGigbWjV9n5fQ1S+vBQu7R2Lmt LUxg== X-Gm-Message-State: AOJu0YyRgf7CnZOBBuAY9wFg8JNF02etVkdT3RgT+wIcUUq/1q7NS+7K sFA+lF70S6dvbwd0NOyrzLi4uzdgCGjoEU7fU1cLFPGlg5/RV0eKEg2kyXVG2wSSxy08HwYffQP o/QePZ7M= X-Gm-Gg: AY/fxX6p8w4yISumKvHetHqe+FOgPIrWJL5ZcLJsox27fPRvl+NskARQW+rFKqsBrq9 GAjWGI9e3EJx+oiUHt0VQEGEPCERq/GqzGyul+4F00V5qqjw2v+9v2EHZmoxrmVDryRxNudF46n C+DiB7BLt+voX1M/OBxwMDpfnaHedh0zQ35ItNo9I31fgKMAw83Tv4qoqrKmAcRcmw/4Bbu0S66 q23fm2sgoUj7SRBbtqcCmC2uWSKpi+DeGvAsfC0zs7sUCzi/PmCrNdvQNZiNa4iAohR0+9RHzZ1 ZOrDpiMbMHnDNpB/IOBEzm+DG6pwtODkeCmiOzCdvb9r9T2AFgTQkwujBDW8oa85g3lnOjAch5F ihpFaCfGjA4RZxTP/hQAE6XbDkD5n2gdX9/o9OlR1bcCqvrAKnswyRu4Ek8A7w4NuRKuQ1tguzb dzVeLWCtF1wSJPJMTu+cI113bwBFvWldqLIij14idnGdOah8wdHzmhfundeqBi X-Google-Smtp-Source: AGHT+IEDKYBb5hqGU3m6BnshX3o8kMw/6OG8EE6/usnEsCwVia3TUyOkv0X9alMc8plV1loP0KULZg== X-Received: by 2002:a05:6000:26c3:b0:430:fd37:ef89 with SMTP id ffacd0b85a97d-432447959a1mr8026923f8f.6.1766162240547; Fri, 19 Dec 2025 08:37:20 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Artyom Tarasenko , Anton Johansson , Richard Henderson , Laurent Vivier , Frederic Konrad , Mark Cave-Ayland , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 4/9] target/sparc: Use explicit big-endian LD/ST API Date: Fri, 19 Dec 2025 17:36:44 +0100 Message-ID: <20251219163650.74303-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251219163650.74303-1-philmd@linaro.org> References: <20251219163650.74303-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766162288181158500 The SPARC architecture uses big endianness. Directly use the big-endian LD/ST API. Mechanical change running: $ for a in uw w l q; do \ sed -i -e "s/ld${a}_p(/ld${a}_be_p(/" \ $(git grep -wlE '(ld|st)u?[wlq]_p' target/sparc/); done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/ldst_helper.c | 12 ++++++------ target/sparc/mmu_helper.c | 32 +++++++++++++++++--------------- 2 files changed, 23 insertions(+), 21 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index e9139814c26..043711f11dc 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -861,10 +861,10 @@ void helper_st_asi(CPUSPARCState *env, target_ulong a= ddr, uint64_t val, MemTxResult result; hwaddr access_addr =3D (env->mxccregs[0] & 0xffffffffULL) = + 8 * i; =20 - env->mxccdata[i] =3D address_space_ldq(cs->as, - access_addr, - MEMTXATTRS_UNSPECIFIE= D, - &result); + env->mxccdata[i] =3D address_space_ldq_be(cs->as, + access_addr, + MEMTXATTRS_UNSPECI= FIED, + &result); if (result !=3D MEMTX_OK) { /* TODO: investigate whether this is the right behavio= ur */ sparc_raise_mmu_fault(cs, access_addr, false, false, @@ -889,8 +889,8 @@ void helper_st_asi(CPUSPARCState *env, target_ulong add= r, uint64_t val, MemTxResult result; hwaddr access_addr =3D (env->mxccregs[1] & 0xffffffffULL) = + 8 * i; =20 - address_space_stq(cs->as, access_addr, env->mxccdata[i], - MEMTXATTRS_UNSPECIFIED, &result); + address_space_stq_be(cs->as, access_addr, env->mxccdata[i], + MEMTXATTRS_UNSPECIFIED, &result); =20 if (result !=3D MEMTX_OK) { /* TODO: investigate whether this is the right behavio= ur */ diff --git a/target/sparc/mmu_helper.c b/target/sparc/mmu_helper.c index 46bf500ea83..5a58239d65e 100644 --- a/target/sparc/mmu_helper.c +++ b/target/sparc/mmu_helper.c @@ -102,7 +102,8 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, /* SPARC reference MMU table walk: Context table->L1->L2->PTE */ /* Context base + context number */ pde_ptr =3D (env->mmuregs[1] << 4) + (env->mmuregs[2] << 2); - pde =3D address_space_ldl(cs->as, pde_ptr, MEMTXATTRS_UNSPECIFIED, &re= sult); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return 4 << 2; /* Translation fault, L =3D 0 */ } @@ -117,8 +118,8 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, return 4 << 2; case 1: /* L0 PDE */ pde_ptr =3D ((address >> 22) & ~3) + ((pde & ~3) << 4); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return (1 << 8) | (4 << 2); /* Translation fault, L =3D 1 */ } @@ -131,8 +132,8 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, return (1 << 8) | (4 << 2); case 1: /* L1 PDE */ pde_ptr =3D ((address & 0xfc0000) >> 16) + ((pde & ~3) << 4); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return (2 << 8) | (4 << 2); /* Translation fault, L =3D 2 = */ } @@ -145,8 +146,8 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, return (2 << 8) | (4 << 2); case 1: /* L2 PDE */ pde_ptr =3D ((address & 0x3f000) >> 10) + ((pde & ~3) << 4= ); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result= ); if (result !=3D MEMTX_OK) { return (3 << 8) | (4 << 2); /* Translation fault, L = =3D 3 */ } @@ -189,7 +190,7 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, if (is_dirty) { pde |=3D PG_MODIFIED_MASK; } - stl_phys(cs->as, pde_ptr, pde); + stl_be_phys(cs->as, pde_ptr, pde); } =20 /* the page can be put in the TLB */ @@ -276,7 +277,8 @@ target_ulong mmu_probe(CPUSPARCState *env, target_ulong= address, int mmulev) /* Context base + context number */ pde_ptr =3D (hwaddr)(env->mmuregs[1] << 4) + (env->mmuregs[2] << 2); - pde =3D address_space_ldl(cs->as, pde_ptr, MEMTXATTRS_UNSPECIFIED, &re= sult); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return 0; } @@ -292,8 +294,8 @@ target_ulong mmu_probe(CPUSPARCState *env, target_ulong= address, int mmulev) return pde; } pde_ptr =3D ((address >> 22) & ~3) + ((pde & ~3) << 4); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return 0; } @@ -310,8 +312,8 @@ target_ulong mmu_probe(CPUSPARCState *env, target_ulong= address, int mmulev) return pde; } pde_ptr =3D ((address & 0xfc0000) >> 16) + ((pde & ~3) << 4); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return 0; } @@ -328,8 +330,8 @@ target_ulong mmu_probe(CPUSPARCState *env, target_ulong= address, int mmulev) return pde; } pde_ptr =3D ((address & 0x3f000) >> 10) + ((pde & ~3) << 4= ); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result= ); if (result !=3D MEMTX_OK) { return 0; } --=20 2.52.0 From nobody Mon Feb 9 06:08:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766162304; cv=none; d=zohomail.com; s=zohoarc; b=XzkWOie9uzDX/IkWQ4bdaQl/M48JqH7qZeCoC3wBXh8dL1BasxMIhwE0K65q4+e4PAslRRGuMHHy1pSstANCkzqYpv6KeNyCRAO7V0T9IjDtPEYddt3pmkSo2SrKJijLVyf/i4jI1gXTDGDbHgYJyYwiXNWQoX9vuq3QxEe+31c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766162304; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pCt5072MT4D8iFZ64nwix4KP4RCAdARcnrd2MW5vRvU=; b=S8Zn0/mGj5gIQRbvVxJPSp3MhCSWlE/ra9uB1Qoa0var1gcRud5aEAhuPkXf7iZ/eZPgiJALocDFc283/JHvj2/KpDEz0N8kcLsGjiAtBnOnrZwhutBg89I//PU89qKDaLN1fvTiqbaVw04oXGyQEXPP+z+GG2YJL+Zzr7JYy9M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766162304568931.5359257171667; Fri, 19 Dec 2025 08:38:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWdTw-0003bv-Gn; Fri, 19 Dec 2025 11:37:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWdTu-0003bm-UG for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:30 -0500 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWdTt-0000S0-Fk for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:30 -0500 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-42fbbc3df8fso988955f8f.2 for ; Fri, 19 Dec 2025 08:37:29 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1b1bdsm5622615f8f.8.2025.12.19.08.37.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Dec 2025 08:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766162248; x=1766767048; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pCt5072MT4D8iFZ64nwix4KP4RCAdARcnrd2MW5vRvU=; b=pyPwbp/MMQkae5gT66xnaS3voGopHr3RQ2EMwB2fllYlsP136rj2LJfq/KtGCtKICo 952gwZ93k2R4XiQxPHPm7koNP+e/9PmfSkSZyn6bIC9CUA8Gf4l3RhfbrgWVth0YGOpg kqAIKyPxXhit9sKss0u2MSC2eYpf1tw64gtH8ixv+q1rQmZWEzR075lar1yjN9Ug2EGx XUOQtGM8OJGjicL3il7GvX/5vD07c98SGfCWofluF5YFiEuSIZgeGomM6onHiFX1TaJU nm/KSc5y6UnQZ2xB2uJAq2A05O5NUH2j3d5p3npdUtbEQ2+7dqxSCjB22RMXDUyCogQz 7BIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766162248; x=1766767048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pCt5072MT4D8iFZ64nwix4KP4RCAdARcnrd2MW5vRvU=; b=B/cSCIvt2PDWQvUQofGhEVlI7odds14cha+Nwc6K/B7VA4KUH7MTnp1T/C8S3a7sTt wGVJqIeSJ6Ay+5onE+6AxQOxenjY3YKOA3LnoyeLMYP/aRoJ3zsHkeO5JncD1pNTGr1z LS14vTXjGqCBAO/4RuC/tHWBhm9ZN5hpvJZA6lCgt+Y/7Zd0YKkMQDfjCSNzT52/cJrC FGNZmNWsYmkEGtgIKoFLT+rxRP5JIMvDFc6gyIaJFSsCRTRo4HyrDkZUUAm7M3BbOI2A YLE/S0q3r1YTcZvxFHsqrsvrJoryUZ4XNE+5B7NMIJOdJjRRop+jo3kSPUR7A5jYwef3 BL2A== X-Gm-Message-State: AOJu0YxbSpFm/nSgk7Jfia2A5raoCRBmbFuPOup1uARxNW/0e3RueTlV t0JzlUwbvQnwUQTVtmyRRALhCsXq3T3GZefA70JLt8vP8zppapeFzpjfgXzXD24abO72Oo4TmvU JvRCGMKU= X-Gm-Gg: AY/fxX7tZIQMqdeh/no0v7KlBi3c4KF9jmdUSpg+hnF3or2dO/m5/j6n8pvHvO4bcMg mzP7rEKXxV9jj1m8bit94DxI+gA7aEh76CbFUaFTWwTRJQD6D5K1rrKiLj0kMqqUCWbQB1i2FiT 4FtJ4Y3aQWIUe2ABcrdrocxkfZGPKVHefOKdHETJI6U7B47ACsM2FyOnkRPEsIn8/Fy5PO0s5jF qKQYwk2B6oVhkdBoEVHUmxr4iMSZSVXMitXR7UT06xj/dhlNMpl6R13jyyQ6kH1nz8bxx4VEp/b UkFwDDFC4vGXRiLMdqB8Exmek4kqBC9J041USgb7rR6PY5mjCyRn6IAYD4TWIhIX1rUsAuiEJWK LnKDMxReG+/oHnMVAafImpvNk1mZVM/GGgwx5y73Qi0E+ykIj8M2yg4kKfzxN3LZ75egZCnsidS J4yxLCZuSQZ+WH6MuMDL8IX2zX+YQwqPxJfmLO7GO1m0gktdzqYfLl25iKm7Op X-Google-Smtp-Source: AGHT+IH2/KwdCJjnVZ8WS/K+hnlCRy1ArMX7mZub37twLzNoXbZGIMlwCZKZP+cFSvUmc8YNGpMrvg== X-Received: by 2002:a05:6000:24c9:b0:430:fc63:8d3 with SMTP id ffacd0b85a97d-4324e4fe005mr3763347f8f.30.1766162247653; Fri, 19 Dec 2025 08:37:27 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Artyom Tarasenko , Anton Johansson , Richard Henderson , Laurent Vivier , Frederic Konrad , Mark Cave-Ayland , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 5/9] target/sparc: Use big-endian variant of cpu_ld/st_data*() Date: Fri, 19 Dec 2025 17:36:45 +0100 Message-ID: <20251219163650.74303-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251219163650.74303-1-philmd@linaro.org> References: <20251219163650.74303-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philmd@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766162306181158501 We only build the SPARC targets using big endianness order, therefore the cpu_ld/st_data*() definitions expand to the big endian declarations. Use the explicit big-endian variants. Mechanical change running: $ tgt=3Dsparc; \ end=3Dbe; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/sparc/ldst_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 043711f11dc..d879ce4e262 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -1194,13 +1194,13 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_u= long addr, ret =3D cpu_ldub_data(env, addr); break; case 2: - ret =3D cpu_lduw_data(env, addr); + ret =3D cpu_lduw_be_data(env, addr); break; case 4: - ret =3D cpu_ldl_data(env, addr); + ret =3D cpu_ldl_be_data(env, addr); break; case 8: - ret =3D cpu_ldq_data(env, addr); + ret =3D cpu_ldq_be_data(env, addr); break; default: g_assert_not_reached(); --=20 2.52.0 From nobody Mon Feb 9 06:08:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766162286; cv=none; d=zohomail.com; s=zohoarc; b=BqRK7BCfjGp9ZAHebmxBuc5aIwRTvrTJk8WXInMkWKv7GSmHa47AFbQZBK72unar8fP08TTXBPd5igOROBceV26Ic8mHiFkTG6mBBblfR8ySqERkMfKBV9CtFUXa9604bHq2XazEpC7ODXz6CGXXP5lea90h2zwKmO+GGfWh4sU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766162286; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gvU8IjxyyWGbnt0TpIestxRQYownf9I7RuEDkGDxUZg=; b=OJcnbteWHULeFYADKV7chv5f1+bQTPGMNdL9qwhUgpukxNUKLJkHyq5GXWSs9Hjhw0NhIUEKm1paV+O4ziZCva1QjhQXQNGslCArDopDBkpy7YdzFGNImrNdbP81EwR7LVq7hStUt6pFUPFgXe3dYgoVYyPzUPcVGnHxEvq1h1o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176616228678298.27487790057353; Fri, 19 Dec 2025 08:38:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWdUJ-0003hV-1S; Fri, 19 Dec 2025 11:37:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWdU3-0003cK-2E for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:39 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWdU0-0000Vj-UK for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:38 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-477a219dbcaso17667285e9.3 for ; Fri, 19 Dec 2025 08:37:36 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be3a6c6ebsm40481015e9.4.2025.12.19.08.37.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Dec 2025 08:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766162255; x=1766767055; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gvU8IjxyyWGbnt0TpIestxRQYownf9I7RuEDkGDxUZg=; b=FviF48zk64weObPMn1tKb0LLuymJjlpZOOSxPKE4Mt9NHePiYx8FtIQ9oVwcV13ki9 4mBMAPLBmG96T4Ly0pcCDYt5vVKBwIiBBuGR89ft5eo5WTyZNTbg8P3PKaRTqGXYie5x a7Z3+KWQcVIeo7l0EvmwfmgK3Ap0pQOAL7bd+iSZavHRdxxLLghVtdHjEHXmc7Py9r72 EOATK9pBUm6AQaz5lP2iz1etkidIIym5MkzHva6AdI/Z2wYSe9kz9/eI2g63hNFXJNkJ LBcA1qR/cSHei2GfNHiRtLkJIRKtkSGWg7CcTY+6yIG6M6aUXjy2Wkgesd5H5RleHryO 856Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766162255; x=1766767055; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gvU8IjxyyWGbnt0TpIestxRQYownf9I7RuEDkGDxUZg=; b=AIvyIxwLmfQwQrhq2psW9Gl+tMfPWU+iLoDx1fJ0DhG966jlws/MKSCy7zuaSecrix 9SL86OhJjhZv7AYzetHsfx6Lqk7pqTAbumWUcuxfVU2vRCKhfZs4YcPgMlv1maDL4/gw 9CyMCO6GZdyMLdZF7l1vvRvyCkMQTa790yPKnUa3g+Vp+Axk0L+58f3hAQyTx4a67QwT 9uJwuWP+4QsLEsT/WYhr9JaTy77T4/8WTiqaMxtviyi8HNW79U4V7JGnG4qcThRlj4T/ rOk8E10q9rP5NEcBOYUB2Mh2Yab2auMtW8KJz5yjuvzRs5j98f1Dn7zLgHNVpFvVYDaR wbSg== X-Gm-Message-State: AOJu0Yzbdfr7pz8PXM+pJzNWSozU8OLetf90L/dKyoRMpKtbnec1VCjp KF1EoPzJIKAt6thhwbLbyx0PA0bwuS4bKvTFUFiLQ3NMzehNdTRf1hIua9z+TBTXKoNQ2j+dPm9 xhRT+yac= X-Gm-Gg: AY/fxX7aRjiRGED7SiRcMnyLaV7apKjkWqSXHKzsZq/y4hbrqasF0PZxjB/JxaZH9MR ZzPpGyzVJrQpE/tNE6CUcPQe9vgq+mmH2GoTnwKaepa/KriuWVZ8MSq9ZYEcC8kNYewIOr6/pLP VUDbgiCBvRijx7CJ6XXJhHclKEmFoMINQlFWbnWYi+CF1pX1sQs1YBQh02roscEF19ckqughiTG +m4i1upriNcRLy9YoaplFH2kwhL0/uMp3T0QaSJGLeW+a7WXNAa8/ClD/uY+tEa03iWhrD6du4Q VHSzT4bqC65oPPzedytFpu/KhiKwlf35uWq32/QMqfx4kW15h3b1aD0J/J0G8qAwQS6Z/bHDnaq U6ee25SZzkBqcS8SJ2+zW+6R9GT6Op1RpfhpwnLABYHCNvZ1ucQENAi1U+9RlbH2QOnD2Tllmpm hRaBqNtotx5BAoroMkCwp6vSYXK7agDVnUwiXInIbmPEHGzr0T6fj6KGjDJS6Z49pJAO8fORY= X-Google-Smtp-Source: AGHT+IFJFYK2I28ZaGAcicQ6d93jyoU5+SdGerlfByXSHGE7xscJVttx8WMqXH4AoyycDRQ/fTjW1Q== X-Received: by 2002:a05:600c:3b0e:b0:477:b0b9:3129 with SMTP id 5b1f17b1804b1-47d1955b7d1mr30755685e9.3.1766162255139; Fri, 19 Dec 2025 08:37:35 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Artyom Tarasenko , Anton Johansson , Richard Henderson , Laurent Vivier , Frederic Konrad , Mark Cave-Ayland , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 6/9] target/sparc: Inline translator_ldl() Date: Fri, 19 Dec 2025 17:36:46 +0100 Message-ID: <20251219163650.74303-7-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251219163650.74303-1-philmd@linaro.org> References: <20251219163650.74303-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766162288126158500 translator_ldl() is defined in "exec/translator.h" as: 198 static inline uint32_t 199 translator_ldl(CPUArchState *env, DisasContextBase *db, vaddr pc) 200 { 201 return translator_ldl_end(env, db, pc, MO_TE); 202 } Directly use the inlined form, expanding MO_TE -> MO_BE since we only build the SPARC targets as big-endian. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 23079697f52..57b50ff8b9a 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -5743,7 +5743,7 @@ static void sparc_tr_translate_insn(DisasContextBase = *dcbase, CPUState *cs) DisasContext *dc =3D container_of(dcbase, DisasContext, base); unsigned int insn; =20 - insn =3D translator_ldl(cpu_env(cs), &dc->base, dc->pc); + insn =3D translator_ldl_end(cpu_env(cs), &dc->base, dc->pc, MO_BE); dc->base.pc_next +=3D 4; =20 if (!decode(dc, insn)) { --=20 2.52.0 From nobody Mon Feb 9 06:08:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766162300; cv=none; d=zohomail.com; s=zohoarc; b=aXylBUcvAgOC10gm9GJtYcmDUsaK47CXa+ZEs8EtKtOX9wnYHPIjVXnxsGROYRkX7uTxBjO3m1rJmBMQwmyG0msVGoZkGjpTFSjhslUSv0MzUjkGmKwhsUbmea98WDq+y1o/RXBucsqgDD2mBEZDTsOZ9jJCX5M3kVmvNFu1F3I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766162300; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=LTDf6gXgcB1jO6b/88BcaLI6db2PR4zQsgUSxotS1SE=; b=VTNey0Gzm/K+gSSfYFXP+nvTLDE3fH/wbhop4wk23qLfYu8HStSAtOcCKRVdVIAfGCUbmQxBEHrkLhOUNYGY/Dwzw+s/oa8UbLebqqda1ff6HDvyN/tzhw8o0uRGuQmPnEyF9DqOJpJc358Z//jYKLKWSoYIqKmwW19HPkAno6k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766162300511431.726010414391; Fri, 19 Dec 2025 08:38:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWdUO-00044w-J6; Fri, 19 Dec 2025 11:38:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWdUA-0003hl-6K for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:49 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWdU8-0000Wb-O0 for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:45 -0500 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-47d1d8a49f5so4933025e9.3 for ; Fri, 19 Dec 2025 08:37:43 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea82feasm5885047f8f.24.2025.12.19.08.37.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Dec 2025 08:37:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766162262; x=1766767062; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LTDf6gXgcB1jO6b/88BcaLI6db2PR4zQsgUSxotS1SE=; b=OOoR3EIAwGQsPsayI7xVn+azQV3bLNj7iJ8T6wVvykBDsZD4SGiWPL2AByQFjIGBeT CApuizXHkerGXbcdlc1ZxwpKD3umJxp/L6nh/83httrvwj4S/FBkL+0NDt6iWfWmu/lU +GcYunxCqgO4GpWKzMvo6m1szklIAMygqfl4xsbOydx2jTQ/AP6GsdQFrKGKOx1Hno6F A95bAvNhTuVhCawHHlg5URLqBovHO5QRRtsyTHELNi823zOiq7jfZtAU03NbS9mfYSHi 0WVZOjG94n6JDmfVF1yP4kOZWePJdD7pPq25Qz47QkXyNtwzvaU0iX28oGio8jD3DnZf w5Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766162262; x=1766767062; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LTDf6gXgcB1jO6b/88BcaLI6db2PR4zQsgUSxotS1SE=; b=YuhDqwYw4zah/5ZdhlhbVQq2W/mpzvyNWXhG9r+g+WXvSPlgRwp0WtFsAgdZuvSQtj BqQ71xgcAeUP3rTl3piZblezGgTlNUIKjmwW3wzjuiqTMFsUp4tg7jcrCWF8NlpCx599 k0YUg1x/jvBPE+FTMDKG/qhqwvA1ezyIr/rxjO+ZLh2rardiq9Wy9Q/g9+4uaBBxMf1j n0NlSY/LA0kigC9ETCmMI9OuzG3ey0o/e7rq8uOFhPgzJpqiitk+AQfqm0aT72npMG2n roi5VPM0AS7/lPTuLqRF+09OSrddJb7oU8cR8EXD4JMyPVgL3qNlnKmGJkNkPKYc2mwR S9bQ== X-Gm-Message-State: AOJu0Yz97/2HNGN6yWov3me8v08RvKBsxZ2dtU+QfQcZU+BM22++/Qyk UHJWNJTNxMOIg29etR5SVS6AciYUfxAOUugVn38dj5ohtYtTIOjEiooALSWcKoIll21A2aQmjP6 Ghd4LTpg= X-Gm-Gg: AY/fxX6JG+NtI3arU5PY7SG/jpH/StAvm4clyNTqhFbdceeXq8NzNJM2OvXmJnTppLt lp4dnw0SU6Mu424lVeuYwxE2jEWs8HEdpWIKd1VCgERFk9+jh6dMhUpPNO7dOS1UTlOEkuXJ9ym xhRTF4f+L0D0q+QjymDmj1zZuBpZw/3s8mKaIt7/vwYs9ntsGZluAeuQ/rPCF5ac9GH+GzDfLtx e7EZQkkf3XUngNt/XC2QsxEYdWrvtGs680T4U3E4HKBtxdpdrxRXRomoYXOSxiU6T6qSteMwyph PZHOC95SED++hu54eVeudiJSSDlZi51I/bjamUtc+53mdSyBD6OMKnvGMfUs1T6QbFCUSGXFFEj Po7UX2tVsBhG6CINDxHTVvZvQqny+n2O1qSIlLcILbgbjsgc3anJpXt+4ZwMLHhQo05K+SsfW0n mR8llbfERi2IIdMkruG9JqJoPX+IOSZ/4T/fUyahb/XpyQGgP8HfBeaQigI7TC X-Google-Smtp-Source: AGHT+IGVn0ryBojkRANNbMa0by1PAI80OdH4kFiFgu7XXa6cp5auA1Lqw7bFrQtJ+VKdG9RLjZ0CCA== X-Received: by 2002:a05:600c:4447:b0:477:9a28:b0a4 with SMTP id 5b1f17b1804b1-47d194c6a2fmr28339435e9.0.1766162262332; Fri, 19 Dec 2025 08:37:42 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Artyom Tarasenko , Anton Johansson , Richard Henderson , Laurent Vivier , Frederic Konrad , Mark Cave-Ayland , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 7/9] target/sparc: Inline cpu_ldl_code() call in cpu_do_interrupt() Date: Fri, 19 Dec 2025 17:36:47 +0100 Message-ID: <20251219163650.74303-8-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251219163650.74303-1-philmd@linaro.org> References: <20251219163650.74303-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766162302082158500 In preparation of removing the cpu_ldl_code wrapper, inline it. Since SPARC instructions are always stored in big-endian order, replace MO_TE -> MO_BE. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/int32_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/sparc/int32_helper.c b/target/sparc/int32_helper.c index b29f693a6bf..d6bb3fa1e54 100644 --- a/target/sparc/int32_helper.c +++ b/target/sparc/int32_helper.c @@ -149,9 +149,11 @@ void sparc_cpu_do_interrupt(CPUState *cs) * mimic delayed trap delivery as if by the subsequent insn. */ if (!env->fsr_qne) { + MemOpIdx oi =3D make_memop_idx(MO_BEUL, cpu_mmu_index(cs, true= )); + env->fsr_qne =3D FSR_QNE; env->fq.s.addr =3D env->pc; - env->fq.s.insn =3D cpu_ldl_code(env, env->pc); + env->fq.s.insn =3D cpu_ldl_code_mmu(env, env->pc, oi, 0); } env->pc =3D env->npc; env->npc =3D env->npc + 4; --=20 2.52.0 From nobody Mon Feb 9 06:08:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766162295; cv=none; d=zohomail.com; s=zohoarc; b=cJXRDNEYVQslmqzz3ZlaTN8gu/HUCGFhj8n/56CohKXM6kc7uXgACvhDQ8UZqtlDnSlvuCcaSqGRwlLSEoBny9Sarwgp/JykzJVHGhKogdREm2c8qyffL6DK+XyLzkO4DoK/foOEPs60zlXCsK3pyXeCvYPSoRVU8+0NtrDGVuw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766162295; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yCWaAKr9HKDQPOGDVeV4ELgBSGxrVu16jLOCiFl1Ing=; b=ftzi2vtJFlgO/frOi4Vh1hbR2orz30Fq9bqCgzuFsag7S98BNiBQBmC0AfoYnGgRCsjNKrnmujeL4i+ABMRjw/o1lKZQZs5RW9C1sTzko+28jZfY9qnYKTiBdWI0DkVauKuydpcUV/Gu/DVmnJ13XEo/fG+nBoOIxtNg/F9XiW8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766162295815671.584277360418; Fri, 19 Dec 2025 08:38:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWdUR-0004AK-29; Fri, 19 Dec 2025 11:38:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWdUI-0003sh-1l for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:56 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWdUG-0000XG-HB for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:53 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-477563e28a3so13041105e9.1 for ; Fri, 19 Dec 2025 08:37:51 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193cba81sm50782315e9.10.2025.12.19.08.37.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Dec 2025 08:37:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766162269; x=1766767069; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yCWaAKr9HKDQPOGDVeV4ELgBSGxrVu16jLOCiFl1Ing=; b=m7MyR4wigTY6kksUbDZu83wAT1LxTCEmOXNetFq/vXMuVHwA8Sf2jKR/ODPCjbBbF+ YkuwShgPtGDIvN1iP6WR7OQql6f5rt4VcvS1uo0fkJjRPXRE9K0aO6IjuGbA09n1ggOb RPgjNsfZejwP9H5Ff9Nq6BYU3a6l7ccCqrBkBdLjVFv0MD8MArssJVvSWfxQ0WB7DQou chTUNRyEVox2XCfOeqtCPgWxmSkof+5ciQKA+cjwmXqlTBjK0d7SWJ6Fu3SB9+AVvN6G dDzHfk0F2e33GzLoOpF6vb8xzr3xhtB4sAP7r4y1haPoiiFxF2yH/BlX2NHmug1UeBDy e+Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766162269; x=1766767069; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yCWaAKr9HKDQPOGDVeV4ELgBSGxrVu16jLOCiFl1Ing=; b=v0Vst58Su+mXfRoyfzJc92G6CNRqAAC+YAV9k7JKkgDgWJR/PDhqRnx52W7rMdL5IB RnsPKZB0iC9CStv7P/VbX5CtvaokGNGSfRpQ+tixMLlZ5pHLQceu1ZG07cfPus8H4HFu +m8bB+Qz+7CBLFL6lg/pqoOkSIsJsCJ9roCIvJGj8BplnWvxIY1LIg4wblWIGUh9P/H6 02rwtny8NKNOAWWeWKVGheUTZvGXR7ahNGBSXOL4JbWlwDSwdWeCxV9YuYeIaWJLI8jg +UxAC3nHiQ8bE1ao500Sr/Ku3eLWfSGq5nYIpbu6HGI9gNVKIvfvqifoilNb1ki/jtMN Lvrw== X-Gm-Message-State: AOJu0YwsOzo26ddjf5TzZZ6DEmarYgv7JKtt5w9DVSNGI8f3iGjpNxDb cekxtTnsvarRjuaIepEBmNtVOX2HfDxHkJv88TQRleQvF4C6axf3gUAfWZmZSKWgtn0n2C3iEh7 yZ/58sJw= X-Gm-Gg: AY/fxX5QCuo7rIK5UwjcZG9puyXdsi0C5xkW4weV6MSa/f2kiUdtGD989Nig+VfbmOw XExiVvHgewCrmC1I1OE/KfN/HME0WO197VdFPpuhW4IbU6B3Y3u5wU+4zcw/Kgy5llNs/rggPzX nMr6DrL3LfxUvIT/qSZu7WlPdFyk6T1h/A0nZvRyNHX93hQvNPfKenrE2puoOlRYijbYgma37k3 BXfoeVPxviIH9E3OtvF5n1OhqUC6YOICoMT2DXlvXKmLSDCMiKesp5z6WGLlq3byr43XmKd8E31 UT2Axj0+SccCk1qVP7BLnehgx8u/dowiB9mxehHBU7sGiLaj6OQPeAtP3gQ6URJmhaPb8bJzn2I edYRuL1a023jvNqBlVv5Q8Qanj6V7Si54IHFI3jo9pjGme5DnxGeywgSVwAdzUlIk5tgNAbvxKb PuiltczZb17Hv+380kFYktJk2DPharZdCbPc73Nn+yFg1U6ymVXrdZXs1D799l X-Google-Smtp-Source: AGHT+IHS3o2ne2jByPhxFqzTUpZuP1OM+2Lt2dFxexatKapa1bDWoGL/OS0cQYAiHj2a1vDa3NmVcg== X-Received: by 2002:a05:600c:4e05:b0:479:13e9:3d64 with SMTP id 5b1f17b1804b1-47d18be1546mr36811585e9.15.1766162269385; Fri, 19 Dec 2025 08:37:49 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Artyom Tarasenko , Anton Johansson , Richard Henderson , Laurent Vivier , Frederic Konrad , Mark Cave-Ayland , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 8/9] target/sparc: Simplify gdbstub sparc_cpu_gdb_write_register() Date: Fri, 19 Dec 2025 17:36:48 +0100 Message-ID: <20251219163650.74303-9-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251219163650.74303-1-philmd@linaro.org> References: <20251219163650.74303-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766162298323158500 Rather than ldtul_p() which uses the underlying 'unsigned long' size, use the ldn() variant, passing the access size as argument (evaluating TARGET_LONG_BITS / 8). No need to use #ifdef'ry to check for TARGET_ABI32, since it is 64-bit: $ git grep -E '(ABI32|LONG_BITS)' configs/targets/sparc* configs/targets/sparc-linux-user.mak:5:TARGET_LONG_BITS=3D32 configs/targets/sparc-softmmu.mak:4:TARGET_LONG_BITS=3D32 configs/targets/sparc32plus-linux-user.mak:2:TARGET_ABI32=3Dy configs/targets/sparc32plus-linux-user.mak:8:TARGET_LONG_BITS=3D64 configs/targets/sparc64-linux-user.mak:8:TARGET_LONG_BITS=3D64 configs/targets/sparc64-softmmu.mak:6:TARGET_LONG_BITS=3D64 Directly expand to the big-endian variant (with the '_be' suffix) since we only build the SPARC targets as big-endian. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/gdbstub.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/target/sparc/gdbstub.c b/target/sparc/gdbstub.c index 134617fb232..d265681f6d2 100644 --- a/target/sparc/gdbstub.c +++ b/target/sparc/gdbstub.c @@ -112,15 +112,7 @@ int sparc_cpu_gdb_write_register(CPUState *cs, uint8_t= *mem_buf, int n) { SPARCCPU *cpu =3D SPARC_CPU(cs); CPUSPARCState *env =3D &cpu->env; -#if defined(TARGET_ABI32) - uint32_t tmp; - - tmp =3D ldl_p(mem_buf); -#else - target_ulong tmp; - - tmp =3D ldtul_p(mem_buf); -#endif + uint64_t tmp =3D ldn_be_p(mem_buf, TARGET_LONG_BITS / 8); =20 if (n < 8) { /* g0..g7 */ @@ -170,7 +162,7 @@ int sparc_cpu_gdb_write_register(CPUState *cs, uint8_t = *mem_buf, int n) #else else if (n < 64) { /* f0-f31 */ - tmp =3D ldl_p(mem_buf); + tmp =3D ldl_be_p(mem_buf); if (n & 1) { env->fpr[(n - 32) / 2].l.lower =3D tmp; } else { --=20 2.52.0 From nobody Mon Feb 9 06:08:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766162307; cv=none; d=zohomail.com; s=zohoarc; b=j9wCDkar3iUkkCM44W5hpNYzgb+Ye6oA2M3wXiHh+0G12moEf66S1ggbF/gl2nGBKNhtrKP8Q+gK1Z87nOh2j1jiDljw+G5KxPNMWMwgNfa7yduPLc+mmdnnWepygCuwerujHQgv99Exclxqrk27uaIetoMVRlL5wEg6US4EoOs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766162307; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Uc7q1S3ew+wCXif1tbZ7lUtNiynYGdMogszF2B2DxFI=; b=Bj6hwIRDSXWJVe+RN6NHlgggcahwh0JtbuQd36XvT/2DSs7i6mh9C0E9Q+GqtANjXaQnpTIxzn78Ioklm2RrnbnUqUdCquSM/Nr5cR2eVPDgnoq5E4WdyuaykCOaqHGhEEgtIufukqvwiCBP/PDbS7wkQ2JMGmghIc1A7HsZItg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176616230703928.363401494152527; Fri, 19 Dec 2025 08:38:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWdUR-0004Ej-C1; Fri, 19 Dec 2025 11:38:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWdUN-00046f-S5 for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:38:00 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWdUM-0000Y8-Dz for qemu-devel@nongnu.org; Fri, 19 Dec 2025 11:37:59 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-477563e28a3so13041945e9.1 for ; Fri, 19 Dec 2025 08:37:58 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193d5372sm54447795e9.14.2025.12.19.08.37.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Dec 2025 08:37:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766162276; x=1766767076; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Uc7q1S3ew+wCXif1tbZ7lUtNiynYGdMogszF2B2DxFI=; b=QNjwHW4x6QJBLSJuPIe0H2l3YBnyyvQJOlfB/DNGGzvJQ7UKiD+XIBz7w4O3jhcoAW rD6+HHHF6Yg/6ba9gMT2b4LYDucwsWH+q13bwEhSrkdK03rj+8cqE1cmC6qPO+YdWsN4 CbgjCcQNq+vgKJIoqelA4XsN4aEo3bxmtA5PTQxzXcSa826XRS2owN6sL4QheZJdEm1m 4X2rukHkdxKjhpaK9YykZcHgT0Dy5yOw33ruxW0CRXoorOAeCLofQH6QGC8jSCillink xvT1xQdH8fxU+EBM5CaBY+KzXHzqPn69IovLjzWtvPd13xqZAvoObftVjleStEAtzyi8 pRcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766162276; x=1766767076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Uc7q1S3ew+wCXif1tbZ7lUtNiynYGdMogszF2B2DxFI=; b=dhw06vhRT3KB0ROL1WgxAj4jJ8WgzkXZybyPn9uznp7kivgmu7HaxqzlqX06USPaE9 17MTrSxf+wBxylwcC+F036p8eTKVAIe7bkKxZQyovasukY6Dm4UL0MxLoI44yVf6bU3o L6/7MrktixsrdIaW/VJWlFc3LUzh/a7MztguuFrfpRmdqfRcIdF7eWhZne+29H0DrJIr EKjTt7K5ceESA1EZPj6rQCddx5732qsAtiSC7mvkZEPekJlqwu4KjOyTEWqYPvO8YtVz 4MpyNRtzUBdoQvc3UE9i+BFDnJ3Q8UnQ/dvceviOsd5/zfyd0EYifPM9zlWHMM7fdVx1 PIxQ== X-Gm-Message-State: AOJu0YwYeUdg+cYf1GR0IdsGMd1wqeukkZdctiiULwGKAGVzvi1KhC0u eP3uuicKKvYWq5GiO1gOxoeZJUSKpzvlhF43a9tK6pNZyZ7kKh3Mp8laGwdEtxvNzPAybIVZ791 OVYy5tTQ= X-Gm-Gg: AY/fxX4DnRYe6nNSjuvgMassZksuV2tX+TzSnmRx23OpMQwbaq5OunTlm3B5xoeA0kN l63DmZqrJBYY2bf8zF/An468/k7mdgV4/zZCvP2tRtExR6uJib2zFjugWeg4qId/6QKxVhLG3Lf 93FyrA6i/Scjc05x2lO7mwvo6V9EVCu0pvo1xNiXH8B0PTQmRs0i8Lg3+xroTc+3NxgyCUi5ijm KYoo6TI4ah/TzNmF6XlDBa4wW0KUDaVGnczQBi3my+rCrxqPa5oR9g6KCEgth8RYDLyDzx8CfW9 t84UHnzh9ZC/Gc2ZhJxsJ3RmmhgP6yHE/t8btMtLpGaBLlrCHCC7IRQIPYhhPP39uOKZjW8rpMx TX1q4xI53dQ5sQeid64ndP+gIWHy/x/2wio+XLvkob5in5rHOB48nZ47v6IisMLEgp2Gn6gHJzv ZSf9KrGJi3qZWSZEMC3WYw4s4RuZKH+YmZ+x8pAA2lfXrQTYWEpmqux5prJCZY X-Google-Smtp-Source: AGHT+IFH+phVPTG8P2oE5tgqdSSZZF/QyWXM4iwzJJIMsAj6r1BFpwGUxf7TilAqEx/WQY/l5leamQ== X-Received: by 2002:a05:600c:4e05:b0:479:13e9:3d64 with SMTP id 5b1f17b1804b1-47d18be1546mr36815175e9.15.1766162276261; Fri, 19 Dec 2025 08:37:56 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Artyom Tarasenko , Anton Johansson , Richard Henderson , Laurent Vivier , Frederic Konrad , Mark Cave-Ayland , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 9/9] configs/targets: Forbid SPARC to use legacy native endianness APIs Date: Fri, 19 Dec 2025 17:36:49 +0100 Message-ID: <20251219163650.74303-10-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251219163650.74303-1-philmd@linaro.org> References: <20251219163650.74303-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766162308425158500 All SPARC-related binaries are buildable without a single use of the legacy "native endian" API. Unset the transitional TARGET_USE_LEGACY_NATIVE_ENDIAN_API definition to forbid further uses of the legacy API. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- configs/targets/sparc-linux-user.mak | 1 - configs/targets/sparc-softmmu.mak | 1 - configs/targets/sparc32plus-linux-user.mak | 1 - configs/targets/sparc64-linux-user.mak | 1 - configs/targets/sparc64-softmmu.mak | 1 - 5 files changed, 5 deletions(-) diff --git a/configs/targets/sparc-linux-user.mak b/configs/targets/sparc-l= inux-user.mak index 1b4ee80fe17..4ff4b7287d2 100644 --- a/configs/targets/sparc-linux-user.mak +++ b/configs/targets/sparc-linux-user.mak @@ -3,4 +3,3 @@ TARGET_SYSTBL_ABI=3Dcommon,32 TARGET_SYSTBL=3Dsyscall.tbl TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D32 -TARGET_USE_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/sparc-softmmu.mak b/configs/targets/sparc-soft= mmu.mak index f02bacb8bbf..57801faf1fc 100644 --- a/configs/targets/sparc-softmmu.mak +++ b/configs/targets/sparc-softmmu.mak @@ -1,4 +1,3 @@ TARGET_ARCH=3Dsparc TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D32 -TARGET_USE_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/sparc32plus-linux-user.mak b/configs/targets/s= parc32plus-linux-user.mak index 75c3a600bf0..7a16934fd17 100644 --- a/configs/targets/sparc32plus-linux-user.mak +++ b/configs/targets/sparc32plus-linux-user.mak @@ -6,4 +6,3 @@ TARGET_SYSTBL_ABI=3Dcommon,32 TARGET_SYSTBL=3Dsyscall.tbl TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D64 -TARGET_USE_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/sparc64-linux-user.mak b/configs/targets/sparc= 64-linux-user.mak index 1b75d276426..7c2ecb7be06 100644 --- a/configs/targets/sparc64-linux-user.mak +++ b/configs/targets/sparc64-linux-user.mak @@ -6,4 +6,3 @@ TARGET_SYSTBL=3Dsyscall.tbl TARGET_BIG_ENDIAN=3Dy TARGET_XML_FILES=3Dgdb-xml/sparc64-core.xml TARGET_LONG_BITS=3D64 -TARGET_USE_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/sparc64-softmmu.mak b/configs/targets/sparc64-= softmmu.mak index bfa1bcfb427..d9d51d21e59 100644 --- a/configs/targets/sparc64-softmmu.mak +++ b/configs/targets/sparc64-softmmu.mak @@ -3,4 +3,3 @@ TARGET_BASE_ARCH=3Dsparc TARGET_BIG_ENDIAN=3Dy TARGET_XML_FILES=3Dgdb-xml/sparc64-core.xml TARGET_LONG_BITS=3D64 -TARGET_USE_LEGACY_NATIVE_ENDIAN_API=3Dy --=20 2.52.0