From nobody Tue Feb 10 15:45:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766096176; cv=none; d=zohomail.com; s=zohoarc; b=hTBGFmU8Xs1myCiTZZzVO3g/3OQIit0X6deuF6uaU/BFReyxG67XU1bKLpBz++ZBx/U7CdYhiyxiKX8gFxg6DKJQR6/P/e7r8DZ2jQ8crT3myHNo8EOha5WXt+k85NcPKHuCrNsF/AihfKltYXALXUHeb6562DrA/mlE7CLtODs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766096176; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/ai82X5qjfSKpHMHTaz42E+3ndTcjTJ0slisrNHpajs=; b=JHsWxvISzYAcu/8raPMzF8U3GjZwTxTOaFEQaGECuS8MKk4iILibjtStvnLmktltKFaAiHZ2pZ1mq0gtLZ2on8U6imvmWjOISjLVitru1bIdkQKvW2fpn4B2iMFH+G4Rke8IBLin5ukR5rLkbI85XX89a90ZAeqM6W9kzpVLaTo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176609617690517.53068145135967; Thu, 18 Dec 2025 14:16:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWMHu-0001yM-6p; Thu, 18 Dec 2025 17:15:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWMHa-0001fS-E1 for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:42 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWMHY-0006xM-B2 for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:38 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-47774d3536dso9794465e9.0 for ; Thu, 18 Dec 2025 14:15:35 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be27b0d5asm63775225e9.13.2025.12.18.14.15.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Dec 2025 14:15:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766096134; x=1766700934; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/ai82X5qjfSKpHMHTaz42E+3ndTcjTJ0slisrNHpajs=; b=Y0RYmoVhD9V3w8maW3iZKhqqVSJa343xosHJsWa8GaXIO4CXIKsU457mmuwB9e3u1r F16l4GESFFwr2p1wuu2nt9uJKiUNr132p1MkIxRK2cyxURf+RzYAFsX2lAPBZ4yNhuUo 0uZ3qOyIriQcki/zRVWyq/3L7TNVZp+VuKf4SKwWLIf1SNP2upc88A8ODRjOAxnGxxA1 FhYX64QkzXZLreDMEGg/bZWcSEaKPo25/CI6QZDYELTkR/W94Z0OsFUlCGzTQOGr1Xkh 8gyQf/EkM2lcnC8aAZ7DMX9KIusljS92QNAfruWJoSktMrBp3KaDmKG5qgpR5pd1v4H+ MLNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766096134; x=1766700934; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/ai82X5qjfSKpHMHTaz42E+3ndTcjTJ0slisrNHpajs=; b=Y2iFgbkrmIdXn9uazQsuPzXPruTltnEYw9dtOFwhhfY/BOZ91QFLiPIWQrhm/4c8gw iiFHWf40yoTC/V1hoaU+lZpY5fxBcc7+yTm0zduAvUNcUinGGzrY8Xqy8ERHa5Y5/DEN YJAJgaVnkMHcDenUaiyCJBfKu2ME8p7hNvOj0/ZBbsgWCF0jiK0naWuslFxlNr2d0xjC MfuTZzOvJaNQNX/RseI/y6WW7111X9rPK/hPgM718Wl9iR8vaLey06Vlbrf5pJ6d5OBm prppbbm0v8xd8LivFhPAxrJ1Cm8U3Y1g0zEzUATYuOHlERFtV7/9U4A4zB37QWfXgaJg rn7w== X-Gm-Message-State: AOJu0YxllwpAXSQ8VaXInqGmP9FIV03k0ykjcAWV46sJ/X8KvSPOMm2/ bTxWDr/CBm5fSGsgjvNtcc/DJjPOot86jjobLta9t/Qx5dT2rVIex1D8ZlPdPJ8lr0kEhvNSXq5 dJRrYOWE= X-Gm-Gg: AY/fxX6lQ6dk1wM8/dy+rD97nE7PgU47HVaEFyA+KwKVNID6+Oqd0uOnneuhm1ZZQTX FYO6xUcntTHHTPEhF7NlIyF6kDPYO06Q6AARHj9XMGtBqriIeJkxn8P0+A40RyMoIBGMMltBLS4 aaPy29CUhLzZnoIfLDzra2/hyGFgxVPfXamLz7e0HBLO9+SCU1cUKRYFAfYpjbr1+Bfkh8CM/z2 zJAB07Y6zDtHn+BkJWv9CyVhIomfm2i29TM98fVy+nmJUtBh55XX2klrRM9aQ4X3g64yJuE1ij1 135NqKOKCKbGxUxXMqme24PlvY7Ur1dd4pb8QvD3IpuLV5+gerUCNRP60B+isNvR+ibcJZHrzCj swzIs+JwUCUI2G0eu6tkVVCM6Jy9uCBUQWB//WEwqJ5fn+GpgVG6YZWw44byVf3gT2fOh7ipb8E EEWMOhzUnWIEGaSWjmZrTgmnhnWYTEAos/Sr7/AFZ6UQwUk/rB8FM2gwCv94AV X-Google-Smtp-Source: AGHT+IEbg6nUPAcQ7Dmf4wv9OGctpaenVpQh4kP0zTmGAfbkG+be/0y3YhcEa8WffAnc40O1Wy6H0w== X-Received: by 2002:a05:600c:46cf:b0:477:9e0c:f59 with SMTP id 5b1f17b1804b1-47d18b833a6mr11165315e9.2.1766096134014; Thu, 18 Dec 2025 14:15:34 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Daniel Henrique Barboza , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Pierrick Bouvier , Richard Henderson , Mark Cave-Ayland , Frederic Konrad , Artyom Tarasenko , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 4/6] target/sparc: Use address_space_ld/st[n]_be() in ld/st_asi helpers Date: Thu, 18 Dec 2025 23:14:55 +0100 Message-ID: <20251218221457.73341-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251218221457.73341-1-philmd@linaro.org> References: <20251218221457.73341-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766096178531158500 Do not open-code address_space_{ld,st}n(), use it passing the access size as argument. Directly expand to the big-endian variant (with the '_be' suffix) since we only build the SPARC targets as big-endian. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/ldst_helper.c | 42 ++++---------------------------------- 1 file changed, 4 insertions(+), 38 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 2c63eb9e036..052608c02d8 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -701,25 +701,8 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_ulon= g addr, MemTxResult result; hwaddr access_addr =3D (hwaddr)addr | ((hwaddr)(asi & 0xf) << 32); =20 - switch (size) { - case 1: - ret =3D address_space_ldub(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 2: - ret =3D address_space_lduw(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); - break; - default: - case 4: - ret =3D address_space_ldl(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 8: - ret =3D address_space_ldq(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); - break; - } + ret =3D address_space_ldn_be(cs->as, access_addr, size, + MEMTXATTRS_UNSPECIFIED, &result); =20 if (result !=3D MEMTX_OK) { sparc_raise_mmu_fault(cs, access_addr, false, false, false, @@ -1066,25 +1049,8 @@ void helper_st_asi(CPUSPARCState *env, target_ulong = addr, uint64_t val, MemTxResult result; hwaddr access_addr =3D (hwaddr)addr | ((hwaddr)(asi & 0xf) << = 32); =20 - switch (size) { - case 1: - address_space_stb(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 2: - address_space_stw(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 4: - default: - address_space_stl(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 8: - address_space_stq(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); - break; - } + address_space_stn_be(cs->as, access_addr, val, size, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { sparc_raise_mmu_fault(cs, access_addr, true, false, false, size, GETPC()); --=20 2.52.0