From nobody Mon Feb 9 05:13:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766096127; cv=none; d=zohomail.com; s=zohoarc; b=aD9UmXsV9OgiBXfxl0RSN3aLAirILHnMetKJg1hhjwSLBZadJgWP7PgyJinqu9KF2qMj5PHgEYEWILnVTh1wiQNX8mJbPB+ekKdVm1lEgdDAQP98cUs0DjyLplkA2faGWo6ZS6vo7DbAEkVtLFTDiakXprwll5V51pDHP54g/ZY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766096127; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9A1gr5CJUaSQgBXQcHovtENYxaFT/E0t2tXqegO2h5o=; b=nNQtRxSD6FT14vV2KNEp+bhVi/5eaexpkeIzDvUb+cVxL1sue7mLHMXgBohEkvLjcRdZqqHUVaYi3bVCIQ7/DdRm2l9A4TGJS/nPLjEZQ9Xbjg71+znypHYwa6wzy0KdYGL1sgrPokYRsPHJCwY1BJpN+KryRiZSDclAEpvZk3U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766096127185750.4803064602793; Thu, 18 Dec 2025 14:15:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWMHC-0001Q9-Ve; Thu, 18 Dec 2025 17:15:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWMHB-0001Pk-BQ for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:13 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWMH9-0006q4-3h for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:13 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4775ae5684fso4650875e9.1 for ; Thu, 18 Dec 2025 14:15:10 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be3a40c5dsm22108935e9.6.2025.12.18.14.15.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Dec 2025 14:15:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766096109; x=1766700909; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9A1gr5CJUaSQgBXQcHovtENYxaFT/E0t2tXqegO2h5o=; b=sWATqa3uHy59IEyAQfwz7C+o684LG0qIFpI8bCtHxcPBiDg6qSluOW+M4oB7coNWS0 43ckuYQS7rLtxh/61qaYd5g87Dw3oOkY4+Uex9xeFIlk0kMuQky+iQTx/e+z6ue5iQcF RnNyD7zWd0aH9lOaf7fsHHy+NaRf9yV8NT5WPJqK56afieTGWG6VY50Coo787X11rnH3 tcnJ63VoVf4MGxw9yrglg4eE5ypOlJYoX3v2B+WGtpumQXv2p6aKRWE1YtmgnFWK/Y46 kXEXxJ02pb2nAQaWKW+wdPzKUvEK7Q9270Ug1ZfyEGtob7YOkKJmt7Z0t+eRpSenK7zr chmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766096109; x=1766700909; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9A1gr5CJUaSQgBXQcHovtENYxaFT/E0t2tXqegO2h5o=; b=rFG3q1tOuASCCJMGfI8XBjDP1P1Uxpfh5K2zEIKkXZBWWELZLtxwKm1Ld0ALfcCBa4 L0kucxxAfqpWXYp6iyRFrILCotmDGP+d9dUGqmB3/HWx0NMX3f1WdFnZFpp2JpuzkeT/ kUR4qBAze+qukwRyORMa4I1sQuyBaaTMZyCBVQFvfLCaRcgIc4UC2KwKUg0T3C/LtKHH MQ6+lRyCtRnLc3uP3E7HGVm+wkfBJCfjnJGIc4C6C1DBOqcH6gASBWPPbAHYXxsVta0F FDc0AVMVa43Mz6gkNrD2+48TJ24BXcLsrGw45dPeJedPcn6u7P9E38G4fWrX2n+4d1q5 mJaQ== X-Gm-Message-State: AOJu0Ywg/UJCLG/y8Pv4BNHVfc+M8/HHsp2J8yIm7Luu2KSFOgfUoLee tqYikL3Ca7eIdCmdpwrJT8WeaHhD3hHHzgUNEVyxnGmEbs7IKEBOKqTXXG9iPjvbRIUcoElrLqD Zy9jaJr0= X-Gm-Gg: AY/fxX6qnWgPlXjSiRBRf3zMlaVpCjjb0YF7jFmZwpyeIaGlx6JYh/uUSfRxkWDhQnr ChgGLLYTtuIPOucm0XodkbqDF1XGaNd08mNKKqeogE2ZL9OUQEqau29PlXE4KjxEbNPPPm829cz mcQT7VH8Q8Fd12sJXqSqseE+K6QU941ul26IyQjm8MYCUdPj4lnwmP8qcc1TSICmpCK64VxsFfc 1MVKh5KD2IcQxFIWoVQ1fHS052MkK9FECKnmq2HStr3MLPhIZPOhvQrd4cgC8WoTzxPsXEO8H4n u99TvqX/PoPSsRNsl+irve0BKRlgmF1MwJNumCJLxYGFzvqUPae05nz1oqI1S00S4JvfM19ciHh xZBnkXrhV3wRY7L5uazk7N+rsNGhtsUl6BVDG304FudaL/ht19HFj0jbSPilf/5Rk5wHt4xOhyf BgCqEc0Upk+QCbTUGMoMdcvSbO1RRbkaXyqTmzU229eWenVTTwGJFdj7zvFO/HaD/JKKNtrFadL KQYvlUIBg== X-Google-Smtp-Source: AGHT+IEWA0AqhiqGd6C3tlcRx7U7sx7I9Zn+5xAeQJTS3aSRMVHJ1129lbAkrTpzL0xmXuMcoFWi4Q== X-Received: by 2002:a05:600c:8216:b0:477:97c7:9be7 with SMTP id 5b1f17b1804b1-47d19549a07mr6458775e9.1.1766096109032; Thu, 18 Dec 2025 14:15:09 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Daniel Henrique Barboza , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Pierrick Bouvier , Richard Henderson , Mark Cave-Ayland , Frederic Konrad , Artyom Tarasenko , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/6] hw/sparc: Use explicit big-endian LD/ST API Date: Thu, 18 Dec 2025 23:14:52 +0100 Message-ID: <20251218221457.73341-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251218221457.73341-1-philmd@linaro.org> References: <20251218221457.73341-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766096129880158500 The SPARC architecture uses big endianness. Directly use the big-endian LD/ST API. Mechanical change running: $ for a in uw w l q; do \ sed -i -e "s/ld${a}_p(/ld${a}_be_p(/" \ $(git grep -wlE '(ld|st)u?[wlq]_p' hw/sparc*/); done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland Reviewed-by: Chigot Cl=C3=A9ment --- hw/sparc/leon3.c | 42 +++++++++++++++++++++--------------------- hw/sparc/sun4m.c | 6 +++--- hw/sparc64/sun4u.c | 6 +++--- 3 files changed, 27 insertions(+), 27 deletions(-) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 631c6113b5c..0414e9df573 100644 --- a/hw/sparc/leon3.c +++ b/hw/sparc/leon3.c @@ -78,21 +78,21 @@ typedef struct ResetData { =20 static uint32_t *gen_store_u32(uint32_t *code, hwaddr addr, uint32_t val) { - stl_p(code++, 0x82100000); /* mov %g0, %g1 */ - stl_p(code++, 0x84100000); /* mov %g0, %g2 */ - stl_p(code++, 0x03000000 + + stl_be_p(code++, 0x82100000); /* mov %g0, %g1 */ + stl_be_p(code++, 0x84100000); /* mov %g0, %g2 */ + stl_be_p(code++, 0x03000000 + extract32(addr, 10, 22)); /* sethi %hi(addr), %g1 */ - stl_p(code++, 0x82106000 + + stl_be_p(code++, 0x82106000 + extract32(addr, 0, 10)); /* or %g1, addr, %g1 */ - stl_p(code++, 0x05000000 + + stl_be_p(code++, 0x05000000 + extract32(val, 10, 22)); /* sethi %hi(val), %g2 */ - stl_p(code++, 0x8410a000 + + stl_be_p(code++, 0x8410a000 + extract32(val, 0, 10)); /* or %g2, val, %g2 */ - stl_p(code++, 0xc4204000); /* st %g2, [ %g1 ] */ + stl_be_p(code++, 0xc4204000); /* st %g2, [ %g1 ] */ =20 return code; } @@ -112,13 +112,13 @@ static void write_bootloader(void *ptr, hwaddr kernel= _addr) =20 /* If we are running on a secondary CPU, jump directly to the kernel. = */ =20 - stl_p(p++, 0x85444000); /* rd %asr17, %g2 */ - stl_p(p++, 0x8530a01c); /* srl %g2, 0x1c, %g2 */ - stl_p(p++, 0x80908000); /* tst %g2 */ + stl_be_p(p++, 0x85444000); /* rd %asr17, %g2 */ + stl_be_p(p++, 0x8530a01c); /* srl %g2, 0x1c, %g2 */ + stl_be_p(p++, 0x80908000); /* tst %g2 */ /* Filled below. */ sec_cpu_branch_p =3D p; - stl_p(p++, 0x0BADC0DE); /* bne xxx */ - stl_p(p++, 0x01000000); /* nop */ + stl_be_p(p++, 0x0BADC0DE); /* bne xxx */ + stl_be_p(p++, 0x01000000); /* nop */ =20 /* Initialize the UARTs */ /* *UART_CONTROL =3D UART_RECEIVE_ENABLE | UART_TRANSMIT_ENABLE; */ @@ -133,17 +133,17 @@ static void write_bootloader(void *ptr, hwaddr kernel= _addr) p =3D gen_store_u32(p, 0x80000318, 3); =20 /* Now, the relative branch above can be computed. */ - stl_p(sec_cpu_branch_p, 0x12800000 - + (p - sec_cpu_branch_p)); + stl_be_p(sec_cpu_branch_p, 0x12800000 + + (p - sec_cpu_branch_p)); =20 /* JUMP to the entry point */ - stl_p(p++, 0x82100000); /* mov %g0, %g1 */ - stl_p(p++, 0x03000000 + extract32(kernel_addr, 10, 22)); - /* sethi %hi(kernel_addr), %g1 */ - stl_p(p++, 0x82106000 + extract32(kernel_addr, 0, 10)); - /* or kernel_addr, %g1 */ - stl_p(p++, 0x81c04000); /* jmp %g1 */ - stl_p(p++, 0x01000000); /* nop */ + stl_be_p(p++, 0x82100000); /* mov %g0, %g1 */ + stl_be_p(p++, 0x03000000 + extract32(kernel_addr, 10, 22)); + /* sethi %hi(kernel_addr), %g1 */ + stl_be_p(p++, 0x82106000 + extract32(kernel_addr, 0, 10)); + /* or kernel_addr, %g1 */ + stl_be_p(p++, 0x81c04000); /* jmp %g1 */ + stl_be_p(p++, 0x01000000); /* nop */ } =20 static void leon3_cpu_reset(void *opaque) diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index 53d7ae08ae9..52ca9586001 100644 --- a/hw/sparc/sun4m.c +++ b/hw/sparc/sun4m.c @@ -268,9 +268,9 @@ static unsigned long sun4m_load_kernel(const char *kern= el_filename, if (*initrd_size > 0) { for (i =3D 0; i < 64 * TARGET_PAGE_SIZE; i +=3D TARGET_PAGE_SI= ZE) { ptr =3D rom_ptr(KERNEL_LOAD_ADDR + i, 24); - if (ptr && ldl_p(ptr) =3D=3D 0x48647253) { /* HdrS */ - stl_p(ptr + 16, INITRD_LOAD_ADDR); - stl_p(ptr + 20, *initrd_size); + if (ptr && ldl_be_p(ptr) =3D=3D 0x48647253) { /* HdrS */ + stl_be_p(ptr + 16, INITRD_LOAD_ADDR); + stl_be_p(ptr + 20, *initrd_size); break; } } diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index 82c3e7c855b..e83c82fc9ae 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -206,9 +206,9 @@ static uint64_t sun4u_load_kernel(const char *kernel_fi= lename, if (*initrd_size > 0) { for (i =3D 0; i < 64 * TARGET_PAGE_SIZE; i +=3D TARGET_PAGE_SI= ZE) { ptr =3D rom_ptr(*kernel_addr + i, 32); - if (ptr && ldl_p(ptr + 8) =3D=3D 0x48647253) { /* HdrS */ - stl_p(ptr + 24, *initrd_addr + *kernel_addr); - stl_p(ptr + 28, *initrd_size); + if (ptr && ldl_be_p(ptr + 8) =3D=3D 0x48647253) { /* HdrS = */ + stl_be_p(ptr + 24, *initrd_addr + *kernel_addr); + stl_be_p(ptr + 28, *initrd_size); break; } } --=20 2.52.0 From nobody Mon Feb 9 05:13:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766096170; cv=none; d=zohomail.com; s=zohoarc; b=X/4Xr2s1DkskjcEQxU1X4xY8EQd+QqvownA4ZrnYpXkQAV5+w/UjWuRaP0kSt0+TKillyFBbPBMVDZgZcM0joZfuOCRQsEbWk59pS8XVAYYfis+kt7VhdmDjOd4pviBoerW82UTQ8jh1H9p9X4YtpTaGGUbjODLfKJqoBgyIhUU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766096170; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yCWaAKr9HKDQPOGDVeV4ELgBSGxrVu16jLOCiFl1Ing=; b=LD3so2khUd34Hj8sa3a3aGipFAWEN3tlVCZC7jDlz+k3USrTL9EffPfjTOw6UkzjNUcrS5Q5cH9Dlo9gnx+jIXSEebeTYB3mpE+91z5hXU6L4NyHEjTF0kpK6+pCuiqAjPgS7JmmSQm7F7M3IsAkpo5fUgB5dI/NOJ1OPodZ0Is= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766096170348375.4382508171999; Thu, 18 Dec 2025 14:16:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWMHN-0001RB-Fa; Thu, 18 Dec 2025 17:15:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWMHM-0001Qy-EH for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:24 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWMHK-0006s6-Rx for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:24 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-477b91680f8so9827865e9.0 for ; Thu, 18 Dec 2025 14:15:22 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be2723b2bsm63332855e9.3.2025.12.18.14.15.14 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Dec 2025 14:15:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766096121; x=1766700921; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yCWaAKr9HKDQPOGDVeV4ELgBSGxrVu16jLOCiFl1Ing=; b=rhvunxi4EkSYP423bvqUq5e2/TDRJl4zQzxul8bT+wqB+LC8joZbBdSYRI+EQeW1iA R1wjmEysaEtFAaPj9mDvEzcVLhzyq5mj1FxzluM3SDgnbIa5LArUC/HYVuhgR7C5JzBc 9ySUNk/xuaWnxkva28LmYQ8P/jyKot4DKVa9UegUs7U2YkNRGida/T++Ug6qcTu829lV pBR1KMhikkZ7Tjx8IOrn15RjZvHA16Y4i3twdWg+Jaac81j15wSSsOjVoAO9wrOsKLeP 5FPoeXhkqwyKWjpe2EHyrCjKoT26bID1E2wBn4tUpfcKjr39I22hhRWp9DOggzO3gSnn YlWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766096121; x=1766700921; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yCWaAKr9HKDQPOGDVeV4ELgBSGxrVu16jLOCiFl1Ing=; b=lUagjykw14Lg4tCOc5pPdZQNCilbgFPf+ZqBfA9/B9awHWliXn1xHvh47sKJaISS/E eLjHzhyFCtl/NBdo9q7OJRPTTJqCEB56f0einT0iEBA+DQDHkW6ytkEugin1Ad/iVh5p SnZv6La5N1Qv5Iwoj48PBD7U8LaaetnnmdPRz238ZyF5pqqgDRAoqXZv9W5935U051Rn pI54chLOtXeof3s+UElyjvfbRns6nm44VOs6hWw4qpiqiybza3/v9ujePg/U0194oOTB RRwpBeB89gYnlT8v3x8IHoA2L7ll97/LIo6IYAngAY94OESJWWqwX+OP5p1DE2+YuHLp eaHA== X-Gm-Message-State: AOJu0Ywk/1qOrdjEiQC0ux3EEuW88Ej69EZv4X3UNVs0/OzW/r3yihaw Whg+G6Ux/f3WY8UN/YsoDBiz/4yQwQBV5Wyx5EI0gmg4DeiG3jS8Gm2bO1glJKi8xhRcPypjxar JlTmqMNo= X-Gm-Gg: AY/fxX4QtKn7ej+7jiyY/SHNZkYOYV1lh5wDa80mCHsTZKkkeryYadOzQHjZUIR6G/s dSI+gFYvuCsHXMm4U5Lxkt9NzIERUbx4G+e+SR1dcnpK8+w42YwbuR+C+1MmeRizjCvjis1pTml ENzkmmB8CZX08/CYLLqCapigWm7NLMzycvdSyxTGc+IQATI14nO/Q8En7TbjenkzUM6Txx5mkB3 Xd2ZrwZVHIroE1LeGlSKuPEK3nvQp9gmT2k3KEokGLqtD0T3FAGZae5FYt5lomPNLMjgpgnENDU TFqzQ5no8gXpd69qU17AzNKQnfjf2BYUPKLLcSqz5Y6LXROE6bsbbcnR+k6k13cDnlrNawsdIaR YSUY52mndHx+2E0fz8Cw0kn+vOg1oq0euOm+CtLivTOTFSKUWTYPk6r9/VVMglyc8AqJX/EOTzA 4D6/SXjOZmWSD1RPOBSVFJCSHYflej5mt/EtEKWXlMbDkevQYF9EUbk30dGz8C X-Google-Smtp-Source: AGHT+IF9r9wD37pALXoumTayaA1cnvyoFGw6iwe2sn2PSmDwMdr2E937layqGaCXcUUWMMvTyvR1QQ== X-Received: by 2002:a05:600c:310e:b0:479:2a3c:f31a with SMTP id 5b1f17b1804b1-47d1956eb70mr6361075e9.1.1766096117529; Thu, 18 Dec 2025 14:15:17 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Daniel Henrique Barboza , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Pierrick Bouvier , Richard Henderson , Mark Cave-Ayland , Frederic Konrad , Artyom Tarasenko , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/6] target/sparc: Simplify gdbstub sparc_cpu_gdb_write_register() Date: Thu, 18 Dec 2025 23:14:53 +0100 Message-ID: <20251218221457.73341-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251218221457.73341-1-philmd@linaro.org> References: <20251218221457.73341-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766096172572158500 Rather than ldtul_p() which uses the underlying 'unsigned long' size, use the ldn() variant, passing the access size as argument (evaluating TARGET_LONG_BITS / 8). No need to use #ifdef'ry to check for TARGET_ABI32, since it is 64-bit: $ git grep -E '(ABI32|LONG_BITS)' configs/targets/sparc* configs/targets/sparc-linux-user.mak:5:TARGET_LONG_BITS=3D32 configs/targets/sparc-softmmu.mak:4:TARGET_LONG_BITS=3D32 configs/targets/sparc32plus-linux-user.mak:2:TARGET_ABI32=3Dy configs/targets/sparc32plus-linux-user.mak:8:TARGET_LONG_BITS=3D64 configs/targets/sparc64-linux-user.mak:8:TARGET_LONG_BITS=3D64 configs/targets/sparc64-softmmu.mak:6:TARGET_LONG_BITS=3D64 Directly expand to the big-endian variant (with the '_be' suffix) since we only build the SPARC targets as big-endian. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/gdbstub.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/target/sparc/gdbstub.c b/target/sparc/gdbstub.c index 134617fb232..d265681f6d2 100644 --- a/target/sparc/gdbstub.c +++ b/target/sparc/gdbstub.c @@ -112,15 +112,7 @@ int sparc_cpu_gdb_write_register(CPUState *cs, uint8_t= *mem_buf, int n) { SPARCCPU *cpu =3D SPARC_CPU(cs); CPUSPARCState *env =3D &cpu->env; -#if defined(TARGET_ABI32) - uint32_t tmp; - - tmp =3D ldl_p(mem_buf); -#else - target_ulong tmp; - - tmp =3D ldtul_p(mem_buf); -#endif + uint64_t tmp =3D ldn_be_p(mem_buf, TARGET_LONG_BITS / 8); =20 if (n < 8) { /* g0..g7 */ @@ -170,7 +162,7 @@ int sparc_cpu_gdb_write_register(CPUState *cs, uint8_t = *mem_buf, int n) #else else if (n < 64) { /* f0-f31 */ - tmp =3D ldl_p(mem_buf); + tmp =3D ldl_be_p(mem_buf); if (n & 1) { env->fpr[(n - 32) / 2].l.lower =3D tmp; } else { --=20 2.52.0 From nobody Mon Feb 9 05:13:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766096142; cv=none; d=zohomail.com; s=zohoarc; b=h/XnoIXvd3lFlmgEaxFAXZp3DJaekXfxHCr/JjT3L9yxDqT2nq/f7fxWZkuGDCRJqRFFXGvMRLvL+ejfCjKBJpvnA2DEdcu5bxzNPuQr2+oeR4789ub+EHi0ON6DPlE6z66A641hNcl5m/9SuYv2KOciXZsqW0JxafQFUyjvX44= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766096142; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FC2VnuRoT3Be3yx27aWW594etoCauJGuy9gbMRT7b30=; b=lPTS32hX75G1MQSWmm0hZsALJcSYqH3KYM4vf/V7Te2oEnB9xJ/x2nRlf/OjMKSFn5on44wobsDKnvknuwTyYiXBGMKs/XF/jFropdAGFPh/osz5ZUuhDMnOwvrpBGglX5NmjAqEV+ylXy37GuPYrKyFEtbMKiNlOOqMOGm6cHQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766096142692777.669538393405; Thu, 18 Dec 2025 14:15:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWMHW-0001Y2-Ko; Thu, 18 Dec 2025 17:15:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWMHT-0001Xf-18 for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:31 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWMHQ-0006tw-HO for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:30 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-47755de027eso7031185e9.0 for ; Thu, 18 Dec 2025 14:15:27 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be27b28a7sm64278165e9.12.2025.12.18.14.15.23 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Dec 2025 14:15:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766096126; x=1766700926; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FC2VnuRoT3Be3yx27aWW594etoCauJGuy9gbMRT7b30=; b=QMijpWo2iBa39rV7fkXZeCG71Pr0/27kHHaBKQJH6f+K+W4hh2YR/n09VEbO8RANb0 zPCjN2hrbVH+ucecYRe7W8O9vh6hWFixeAtT6BRydAZ6aUURL1iHi0noUomuz/Cd1Lq6 CKXd2Kvj9tVMI0MpNoX4OSGiKW9faJyQnPoI05FvifM40YQ90HGdaiafNnTu2mG9zYtN wg0i5z4TVps4Oh6Uu93bWGn3H91H8PD08Tq4HrLSLdf33gkrby7JJAuv/JktaakO1iat DYtRrbaq7NqQ40NQnBqiRIIXUD/y5NZOnjf9EFfkNL88rXbWlCJuXwCFTzN38Up3iRIL fbvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766096126; x=1766700926; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FC2VnuRoT3Be3yx27aWW594etoCauJGuy9gbMRT7b30=; b=lLPSn1tP1XDSlViEGs/Hsd4xpiSWIvtXDZdMXuskiYxVEEy3BUAF+bNyf2jl0u1Mtk 3RyJWFCVm7fG7UsEIkU6uJnsqRy7fv46jo14fPXfmi1WtqytrOhBN+d0vzvDxfFl64IS c9qrBAdM4i7wfzVsMAbMBxAq4naHfJECotdE3vafSxru+WmaKu/LEYLnxR3nxYh2OoZ9 n0D8SWsKHwX3rbmWALRvbYCgO325/49jOjFpFTbWLvJE4JZFtcJyhO2ZQ8gdgI/WomHQ 5pjDTgKAkx1/np7PKMe8iqLeuvl6b0GqBzE8GBJgZmBqZGP5l36j/dOLLSZPV2ARGEIp IUfw== X-Gm-Message-State: AOJu0Yw0Htbyf+W19d/55vbIx5RoTfU59pX1RYqFaNgGXAkZM+6aQCtT +dOdOHsXQZGwjLnsSueRtUdFlJI/dsklwXC4g/CbxtsG0BT8yMTGcqhook+GWWqPjWHbXTv40wB khozQM2U= X-Gm-Gg: AY/fxX4b/dra5epSxJBiA7XNk//M+2hQlNcGP3FzQfCUdFctnFM1Muyg0pENfMwHyYF wS2Erv8CLcOeePAFj6B5dBa6TuqNxVYgv6dVwAd4AXglKxPG3SFjM+6v+dOErI6zTyRZybfKkk9 pcA3AvpTFl4SsxQDT61mNn4jcbmNGArVSV9QjcAsnHI5z2uIlz/GqcjEbtyhyXxcmh3UvVjK2Gv AvP4erAklRMQ9oJUOXm6HXhCfOz/Io/6VogwMdYTOOOaSGdefvSJNlalJLRrvU63Ear8+KXNG7/ wskAV/EZh5LH7aXQNuQZ+tLlboAd7BrtswZCYB5fbFsnYEQjMxb46cxuqxDw7BoYK9R1dme00Kf CEyBwcrbptsgq0jc1tZT3c0oUVpAIh4gukUW1dlO5eoqTc5a360Y9P8QAS9loUMW9h7mPSv/9ld Xd8GcF1m61cm8OoxP3c9hgFIC/kwIARUxF9iVAwK3OpKb1caZN4P2IIVoQrgyt X-Google-Smtp-Source: AGHT+IFeYgb4/uRYNtR2R7RTRiH0HSu1AVsPLPRXFhwq0wrQ4R3G2VuikuF6pUb3BTNqqv6XDRJbNA== X-Received: by 2002:a05:600c:3495:b0:45b:7d77:b592 with SMTP id 5b1f17b1804b1-47d1954a15amr5359715e9.12.1766096126229; Thu, 18 Dec 2025 14:15:26 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Daniel Henrique Barboza , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Pierrick Bouvier , Richard Henderson , Mark Cave-Ayland , Frederic Konrad , Artyom Tarasenko , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/6] target/sparc: Inline translator_ldl() Date: Thu, 18 Dec 2025 23:14:54 +0100 Message-ID: <20251218221457.73341-4-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251218221457.73341-1-philmd@linaro.org> References: <20251218221457.73341-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766096144601158500 translator_ldl() is defined in "exec/translator.h" as: 198 static inline uint32_t 199 translator_ldl(CPUArchState *env, DisasContextBase *db, vaddr pc) 200 { 201 return translator_ldl_end(env, db, pc, MO_TE); 202 } Directly use the inlined form, expanding MO_TE -> MO_BE since we only build the SPARC targets as big-endian. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index d6b599b71fe..1a7e5cc3d73 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -5743,7 +5743,7 @@ static void sparc_tr_translate_insn(DisasContextBase = *dcbase, CPUState *cs) DisasContext *dc =3D container_of(dcbase, DisasContext, base); unsigned int insn; =20 - insn =3D translator_ldl(cpu_env(cs), &dc->base, dc->pc); + insn =3D translator_ldl_end(cpu_env(cs), &dc->base, dc->pc, MO_BE); dc->base.pc_next +=3D 4; =20 if (!decode(dc, insn)) { --=20 2.52.0 From nobody Mon Feb 9 05:13:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766096176; cv=none; d=zohomail.com; s=zohoarc; b=hTBGFmU8Xs1myCiTZZzVO3g/3OQIit0X6deuF6uaU/BFReyxG67XU1bKLpBz++ZBx/U7CdYhiyxiKX8gFxg6DKJQR6/P/e7r8DZ2jQ8crT3myHNo8EOha5WXt+k85NcPKHuCrNsF/AihfKltYXALXUHeb6562DrA/mlE7CLtODs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766096176; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/ai82X5qjfSKpHMHTaz42E+3ndTcjTJ0slisrNHpajs=; b=JHsWxvISzYAcu/8raPMzF8U3GjZwTxTOaFEQaGECuS8MKk4iILibjtStvnLmktltKFaAiHZ2pZ1mq0gtLZ2on8U6imvmWjOISjLVitru1bIdkQKvW2fpn4B2iMFH+G4Rke8IBLin5ukR5rLkbI85XX89a90ZAeqM6W9kzpVLaTo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176609617690517.53068145135967; Thu, 18 Dec 2025 14:16:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWMHu-0001yM-6p; Thu, 18 Dec 2025 17:15:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWMHa-0001fS-E1 for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:42 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWMHY-0006xM-B2 for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:38 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-47774d3536dso9794465e9.0 for ; Thu, 18 Dec 2025 14:15:35 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be27b0d5asm63775225e9.13.2025.12.18.14.15.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Dec 2025 14:15:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766096134; x=1766700934; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/ai82X5qjfSKpHMHTaz42E+3ndTcjTJ0slisrNHpajs=; b=Y0RYmoVhD9V3w8maW3iZKhqqVSJa343xosHJsWa8GaXIO4CXIKsU457mmuwB9e3u1r F16l4GESFFwr2p1wuu2nt9uJKiUNr132p1MkIxRK2cyxURf+RzYAFsX2lAPBZ4yNhuUo 0uZ3qOyIriQcki/zRVWyq/3L7TNVZp+VuKf4SKwWLIf1SNP2upc88A8ODRjOAxnGxxA1 FhYX64QkzXZLreDMEGg/bZWcSEaKPo25/CI6QZDYELTkR/W94Z0OsFUlCGzTQOGr1Xkh 8gyQf/EkM2lcnC8aAZ7DMX9KIusljS92QNAfruWJoSktMrBp3KaDmKG5qgpR5pd1v4H+ MLNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766096134; x=1766700934; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/ai82X5qjfSKpHMHTaz42E+3ndTcjTJ0slisrNHpajs=; b=Y2iFgbkrmIdXn9uazQsuPzXPruTltnEYw9dtOFwhhfY/BOZ91QFLiPIWQrhm/4c8gw iiFHWf40yoTC/V1hoaU+lZpY5fxBcc7+yTm0zduAvUNcUinGGzrY8Xqy8ERHa5Y5/DEN YJAJgaVnkMHcDenUaiyCJBfKu2ME8p7hNvOj0/ZBbsgWCF0jiK0naWuslFxlNr2d0xjC MfuTZzOvJaNQNX/RseI/y6WW7111X9rPK/hPgM718Wl9iR8vaLey06Vlbrf5pJ6d5OBm prppbbm0v8xd8LivFhPAxrJ1Cm8U3Y1g0zEzUATYuOHlERFtV7/9U4A4zB37QWfXgaJg rn7w== X-Gm-Message-State: AOJu0YxllwpAXSQ8VaXInqGmP9FIV03k0ykjcAWV46sJ/X8KvSPOMm2/ bTxWDr/CBm5fSGsgjvNtcc/DJjPOot86jjobLta9t/Qx5dT2rVIex1D8ZlPdPJ8lr0kEhvNSXq5 dJRrYOWE= X-Gm-Gg: AY/fxX6lQ6dk1wM8/dy+rD97nE7PgU47HVaEFyA+KwKVNID6+Oqd0uOnneuhm1ZZQTX FYO6xUcntTHHTPEhF7NlIyF6kDPYO06Q6AARHj9XMGtBqriIeJkxn8P0+A40RyMoIBGMMltBLS4 aaPy29CUhLzZnoIfLDzra2/hyGFgxVPfXamLz7e0HBLO9+SCU1cUKRYFAfYpjbr1+Bfkh8CM/z2 zJAB07Y6zDtHn+BkJWv9CyVhIomfm2i29TM98fVy+nmJUtBh55XX2klrRM9aQ4X3g64yJuE1ij1 135NqKOKCKbGxUxXMqme24PlvY7Ur1dd4pb8QvD3IpuLV5+gerUCNRP60B+isNvR+ibcJZHrzCj swzIs+JwUCUI2G0eu6tkVVCM6Jy9uCBUQWB//WEwqJ5fn+GpgVG6YZWw44byVf3gT2fOh7ipb8E EEWMOhzUnWIEGaSWjmZrTgmnhnWYTEAos/Sr7/AFZ6UQwUk/rB8FM2gwCv94AV X-Google-Smtp-Source: AGHT+IEbg6nUPAcQ7Dmf4wv9OGctpaenVpQh4kP0zTmGAfbkG+be/0y3YhcEa8WffAnc40O1Wy6H0w== X-Received: by 2002:a05:600c:46cf:b0:477:9e0c:f59 with SMTP id 5b1f17b1804b1-47d18b833a6mr11165315e9.2.1766096134014; Thu, 18 Dec 2025 14:15:34 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Daniel Henrique Barboza , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Pierrick Bouvier , Richard Henderson , Mark Cave-Ayland , Frederic Konrad , Artyom Tarasenko , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 4/6] target/sparc: Use address_space_ld/st[n]_be() in ld/st_asi helpers Date: Thu, 18 Dec 2025 23:14:55 +0100 Message-ID: <20251218221457.73341-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251218221457.73341-1-philmd@linaro.org> References: <20251218221457.73341-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766096178531158500 Do not open-code address_space_{ld,st}n(), use it passing the access size as argument. Directly expand to the big-endian variant (with the '_be' suffix) since we only build the SPARC targets as big-endian. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/ldst_helper.c | 42 ++++---------------------------------- 1 file changed, 4 insertions(+), 38 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 2c63eb9e036..052608c02d8 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -701,25 +701,8 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_ulon= g addr, MemTxResult result; hwaddr access_addr =3D (hwaddr)addr | ((hwaddr)(asi & 0xf) << 32); =20 - switch (size) { - case 1: - ret =3D address_space_ldub(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 2: - ret =3D address_space_lduw(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); - break; - default: - case 4: - ret =3D address_space_ldl(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 8: - ret =3D address_space_ldq(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); - break; - } + ret =3D address_space_ldn_be(cs->as, access_addr, size, + MEMTXATTRS_UNSPECIFIED, &result); =20 if (result !=3D MEMTX_OK) { sparc_raise_mmu_fault(cs, access_addr, false, false, false, @@ -1066,25 +1049,8 @@ void helper_st_asi(CPUSPARCState *env, target_ulong = addr, uint64_t val, MemTxResult result; hwaddr access_addr =3D (hwaddr)addr | ((hwaddr)(asi & 0xf) << = 32); =20 - switch (size) { - case 1: - address_space_stb(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 2: - address_space_stw(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 4: - default: - address_space_stl(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); - break; - case 8: - address_space_stq(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); - break; - } + address_space_stn_be(cs->as, access_addr, val, size, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { sparc_raise_mmu_fault(cs, access_addr, true, false, false, size, GETPC()); --=20 2.52.0 From nobody Mon Feb 9 05:13:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766096212; cv=none; d=zohomail.com; s=zohoarc; b=HVUal7yF0NKJ6HVTuRgNrhel83hTqRLLQucoaTp77D9zXYUbc23tZfIihoVSRFq+3lwEFXemJejoFzigzi2y5VS0+O78BjEqjnmvEm6OBz5zn+laKqEG2qLaOWs9wxCB1Ba5RTgokX+r+3ruf4spqNd3BPBmh5as1tcBcvEZkC4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766096212; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lQBTMCfea7CrgtYIaGV0TP3JWVGEy3fzFkDzZcaRRcU=; b=KN3VSbjl8E9pIHZcjhD0OJFsNLe0nvxHPVW7HGE2vXFc7qf382O6Yy7ZVEVk+widH6E2kRBaw5TB4YyZl0k4PRYflyJdZic4/05+HRBxnGgiI9dGDbO8y2H42XF3EfuVcHtAgF/We9cjO4Aw8Xv2CzgjH71VYv7R9HIf7v/zldg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766096212926252.41328842568635; Thu, 18 Dec 2025 14:16:52 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWMII-0002EG-JN; Thu, 18 Dec 2025 17:16:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWMHk-0001wD-Fh for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:49 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWMHf-00072C-Vj for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:47 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-47aa03d3326so6944935e9.3 for ; Thu, 18 Dec 2025 14:15:43 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be2723b2bsm63348565e9.3.2025.12.18.14.15.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Dec 2025 14:15:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766096142; x=1766700942; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lQBTMCfea7CrgtYIaGV0TP3JWVGEy3fzFkDzZcaRRcU=; b=wri4t0v3y76EXcyHjtssS0hqFbFRfn4K+mSLxHPJaLF4HqBXs8nX2IAJlTDnEqMPJ3 cWwzPsay2MbdvWqvdqVTTJ15cSLt5sB1hlf9rd4EBX9GmbKDsgg4qYgqrFTKnyQTihe/ RIoI9GOA6ha32N3NpRrb8/I8PlsQcaNkyHK9aBTJ4dXsLq0Nik4bq0q9U8Y19aZdp4FJ r4SiZMOu6cxypWADCO+rLZjn6THq/dWfDVmLNNLsgRI9YvrXZ/5Xc2wA3KwPb3KDU7ZA u4oGyBggTiDuDgDYm6PAENeYERMhWDISCmqqkTKCltiDcOqQDJgZbRKgH8MZMFA3cDrW RTIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766096142; x=1766700942; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lQBTMCfea7CrgtYIaGV0TP3JWVGEy3fzFkDzZcaRRcU=; b=XEdZvxVMcmD5F86weWlYYHOZ8sRYqawSZbIoCzwHxRU5juAp2wr1GGfc1qJ25DXFAx pdkb5VQ6b8HBasmS1aLUhWCE3NFu+DqXsUUfWRZcDyLYEzbi+OF+TaIE09jmj//G99Mz DFbgeQAlqCMrXTMtZdenaA8pq7+NZsh1RFsx5s6UUn9+ED20JCkcPWE1H6FZ+HnNfxph P9cGBu+Knm2NMTIWyMNItMVwJf8Clo36YZM6q0aA5RCDJcx1D69Xq99GkNK4f+18bhnO 2xoMIx5Ee5aDWqWLa0491YlpvZASfx+LcbFzrii6BARsYvKbPgP067bAnT953GBwz9OS e9hQ== X-Gm-Message-State: AOJu0YybsCgBSxr71wbR3M+VQg/8YIY+Yu4+OOc7RNx9C7WtzBaRU4QV ruJPbudrdHqGpZ4Rl7TPZ7l/B+L8ufeXmqDKOiPJ66ysbqrYTGJPcjswgEQKDpw0K3QNBc8efQC jYFPp62U= X-Gm-Gg: AY/fxX7IGdj7e1IM9H1o3mf+DIAj6a7WsHgCgm9o9CrutAdIp5ze/gQcm5fdP5gzkl8 vNR2Ohv1mhWpC9gkAm7jSmAJYmXDEf8H2G0xd44MwqN+qBSu+VJwXpiuHMZVfg0BBP4W9to0E1c KLgTQhdjGdiGZcmuIFggzpbfkkLL7/YPicCNOmQ7yeiCUga1Z1mnxpcZvdw3nFxdfl3muzINwlI bdxc2VWV9vlHxt6SGsYVtEY4cxhoJCQDSSVmMvJFt11xGcIea1f5z4QWxl+46qgzAOolWrvdTQO SbBMfZfCJIvG2N07c34v5BFVx1TyGa1UTH+puwpQMkyKWSchhbPCM6oiDq+HlmgCxqOK5SEOrVT 2v9iDOhJOL+0F31HEEsnZULDieqqfL5WfvNnh8UV2UVAHvvUmigK5fb7zZ1F20XpaR+MrmwR66B ewwDctRFWQONeUBkxHNJoFbS0YLh9YEmAyh0ebW8/pQAE2pKZqIxU332sYSeOFw160620hvus= X-Google-Smtp-Source: AGHT+IF1zd8m+r0uNjInsUOLt97Eed+6ln7aydXlyXRU8sR76Wmgh1KI1R7kt4ezvYxaA16zwHzO1g== X-Received: by 2002:a05:600c:3b07:b0:47a:814c:eea1 with SMTP id 5b1f17b1804b1-47d195917d2mr5425505e9.35.1766096142163; Thu, 18 Dec 2025 14:15:42 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Daniel Henrique Barboza , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Pierrick Bouvier , Richard Henderson , Mark Cave-Ayland , Frederic Konrad , Artyom Tarasenko , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 5/6] target/sparc: Use explicit big-endian LD/ST API Date: Thu, 18 Dec 2025 23:14:56 +0100 Message-ID: <20251218221457.73341-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251218221457.73341-1-philmd@linaro.org> References: <20251218221457.73341-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766096218685158500 The SPARC architecture uses big endianness. Directly use the big-endian LD/ST API. Mechanical change running: $ for a in uw w l q; do \ sed -i -e "s/ld${a}_p(/ld${a}_be_p(/" \ $(git grep -wlE '(ld|st)u?[wlq]_p' target/sparc/); done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/ldst_helper.c | 12 ++++++------ target/sparc/mmu_helper.c | 30 ++++++++++++++++-------------- 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 052608c02d8..ed79a506584 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -861,10 +861,10 @@ void helper_st_asi(CPUSPARCState *env, target_ulong a= ddr, uint64_t val, MemTxResult result; hwaddr access_addr =3D (env->mxccregs[0] & 0xffffffffULL) = + 8 * i; =20 - env->mxccdata[i] =3D address_space_ldq(cs->as, - access_addr, - MEMTXATTRS_UNSPECIFIE= D, - &result); + env->mxccdata[i] =3D address_space_ldq_be(cs->as, + access_addr, + MEMTXATTRS_UNSPECI= FIED, + &result); if (result !=3D MEMTX_OK) { /* TODO: investigate whether this is the right behavio= ur */ sparc_raise_mmu_fault(cs, access_addr, false, false, @@ -889,8 +889,8 @@ void helper_st_asi(CPUSPARCState *env, target_ulong add= r, uint64_t val, MemTxResult result; hwaddr access_addr =3D (env->mxccregs[1] & 0xffffffffULL) = + 8 * i; =20 - address_space_stq(cs->as, access_addr, env->mxccdata[i], - MEMTXATTRS_UNSPECIFIED, &result); + address_space_stq_be(cs->as, access_addr, env->mxccdata[i], + MEMTXATTRS_UNSPECIFIED, &result); =20 if (result !=3D MEMTX_OK) { /* TODO: investigate whether this is the right behavio= ur */ diff --git a/target/sparc/mmu_helper.c b/target/sparc/mmu_helper.c index 46bf500ea83..035be5b4f9a 100644 --- a/target/sparc/mmu_helper.c +++ b/target/sparc/mmu_helper.c @@ -102,7 +102,8 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, /* SPARC reference MMU table walk: Context table->L1->L2->PTE */ /* Context base + context number */ pde_ptr =3D (env->mmuregs[1] << 4) + (env->mmuregs[2] << 2); - pde =3D address_space_ldl(cs->as, pde_ptr, MEMTXATTRS_UNSPECIFIED, &re= sult); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return 4 << 2; /* Translation fault, L =3D 0 */ } @@ -117,8 +118,8 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, return 4 << 2; case 1: /* L0 PDE */ pde_ptr =3D ((address >> 22) & ~3) + ((pde & ~3) << 4); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return (1 << 8) | (4 << 2); /* Translation fault, L =3D 1 */ } @@ -131,8 +132,8 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, return (1 << 8) | (4 << 2); case 1: /* L1 PDE */ pde_ptr =3D ((address & 0xfc0000) >> 16) + ((pde & ~3) << 4); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return (2 << 8) | (4 << 2); /* Translation fault, L =3D 2 = */ } @@ -145,8 +146,8 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, return (2 << 8) | (4 << 2); case 1: /* L2 PDE */ pde_ptr =3D ((address & 0x3f000) >> 10) + ((pde & ~3) << 4= ); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result= ); if (result !=3D MEMTX_OK) { return (3 << 8) | (4 << 2); /* Translation fault, L = =3D 3 */ } @@ -276,7 +277,8 @@ target_ulong mmu_probe(CPUSPARCState *env, target_ulong= address, int mmulev) /* Context base + context number */ pde_ptr =3D (hwaddr)(env->mmuregs[1] << 4) + (env->mmuregs[2] << 2); - pde =3D address_space_ldl(cs->as, pde_ptr, MEMTXATTRS_UNSPECIFIED, &re= sult); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return 0; } @@ -292,8 +294,8 @@ target_ulong mmu_probe(CPUSPARCState *env, target_ulong= address, int mmulev) return pde; } pde_ptr =3D ((address >> 22) & ~3) + ((pde & ~3) << 4); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return 0; } @@ -310,8 +312,8 @@ target_ulong mmu_probe(CPUSPARCState *env, target_ulong= address, int mmulev) return pde; } pde_ptr =3D ((address & 0xfc0000) >> 16) + ((pde & ~3) << 4); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return 0; } @@ -328,8 +330,8 @@ target_ulong mmu_probe(CPUSPARCState *env, target_ulong= address, int mmulev) return pde; } pde_ptr =3D ((address & 0x3f000) >> 10) + ((pde & ~3) << 4= ); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result= ); if (result !=3D MEMTX_OK) { return 0; } --=20 2.52.0 From nobody Mon Feb 9 05:13:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766096222; cv=none; d=zohomail.com; s=zohoarc; b=m+/j10x/hfHibOmQ1KQtiSCZioaki1kKkEBsw9yNp96RbI64ExIBGFhco0Cpm8a4lu0PYkYUVpZ3Or5JKcfvqy+XoDM2BeOh/sCB8b/3W4OKO72E1cBw/D3QUjWqyrxvYizPJ5rxMPSc7zBMIR4skx8huZJR11WDog3KHe/w/f0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766096222; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WsUp1MmG6LxP68J7b+lmwDBxwNtYNVBOG5/4xZJXmUE=; b=Kz4cK+1e0gwpU3SHrkpPxii8GQbE9mm4Zjb8cI+Fj+4cJ5IUh3XLtPfqn8PUfyDCWD0F6JJRHd00nhy8SA3SEnNH0+P0XOyMaEL3HcciPfTLLleVOAAxP2nUYMiToZ+g6Ji1e98Fga5CSp9lFwtlLBLjzfIzd3E8v2JsVAiKDss= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766096222852242.1666103477911; Thu, 18 Dec 2025 14:17:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWMIo-0002m7-7f; Thu, 18 Dec 2025 17:16:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWMHq-00021I-N9 for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:58 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWMHo-00075q-Kz for qemu-devel@nongnu.org; Thu, 18 Dec 2025 17:15:54 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-47798ded6fcso8039725e9.1 for ; Thu, 18 Dec 2025 14:15:52 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea2267fsm1165453f8f.12.2025.12.18.14.15.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Dec 2025 14:15:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766096151; x=1766700951; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WsUp1MmG6LxP68J7b+lmwDBxwNtYNVBOG5/4xZJXmUE=; b=HEreFxTvhV5g7NBd4R88OIxP09/FV3oDzpFN3DbnuG7cHzhOJsQhF1Pur6uZgv5YBc e0uymD0SsjgKDNjhfK/awQNA6cDxqn77nVuQR2JEVY7cwFg2bhZQlajdjbXwqnFwsSO3 bmrg4hVPLQ4gGN245gzulpEoo72LH0xmwqy4edPbunXvhGiy1cWUkRvg25sB6TaioLzy EGEz1DkwW+6yXvk9ktAHwUxO9jxzr+bmgrjkPjMr9hPCR7w5r9YhCtoRw9icsaw7bk0q Dd85fAyS9U2q31baaAluRXGtvhokqiC0nCfxmY8rtggglj3EVxZ/0XyXdbfEJ8BzKYds ajqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766096151; x=1766700951; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WsUp1MmG6LxP68J7b+lmwDBxwNtYNVBOG5/4xZJXmUE=; b=ULbLu44GIjypTgDYLZ9lAEFUvphm6OsTZ8N8aIRxnLLVaSYtCc1mAr6/x/awDRj/a1 y2omhIvIRkFaCZiiXVXq4gI/tpo46DkrxOM2g3z91ZleZXR2AQrTKVywvw78Ee8KIpkP ZNR3Z+g3B45xXkdwxCFzklSBdiBOltnlJZ+0XcKmOqCfTZrG3CCDtdXRolWMhuRAUoSa RVexHj9chrVvuoAUsDyf9ENcPqG++MTZ6MdGlLJ5CiDVisg5Yaa22WPDsQxir0XnoPQy jw5m6zCjw/5aL3b8PfOWlJngtsoSHwO+rW8lNGf8QWiErCJ0UqVRp+wVayMPCZnFhaiR ggAw== X-Gm-Message-State: AOJu0Yy+rOzvsy392MfyT3ciHI3ZndBf46xZtE7RJwTL+OH37RrLhlWH +P8ls+xb6ahRETIZiPJdn0GIwRLE0IOPCYGjJr0Iv4JeP0KtCQzZdFe0bxZXRynOEKDyiktAoYM 1FJShPIw= X-Gm-Gg: AY/fxX7MXhLFrhRAxz57N11ZVgGp6AQ3JhVv0Ld4KuLE58Q3xsEIoTuvyOi2yJ8vH/d rFMyv7W4LVFY2uZPsRMA5kKBWmtbtspj/4ggHSrZlo/m/4y+GxjuTZIJTlzeZLYoAs6+pYvXwuv X3xWi1AsaS3rnxfPSFs3nECDoH3f3eVq3kOxnCCYDabfLofdVDMJNqDa+htWZTMJ7hJylWO9J3C jWTxwYPJ4WCfKHKnqFeBKyJCY7Tq0kO66V6lhV650nNz5uIP8i/Fu9TFzzWhcQq9f1kEt2DJjnH oggSIfLCpop1pa0QxJko+zoszDTwQaZUr6WjKO46SZuHm7magcLAzsILSPB0c8DTgAoRkdgoUtd ml7jfzCY7jZ2RSQoFfbeCVUjTjZ5JQ7IKbAfFljQIxnh5P/BzmDBW8AMt+q+9I/16pU7dzEBQth EYlZ3kBFWmFjAWDPOnDEfgVJnTkmzvPoVDo3HXFMcIh/+oN3P66fxtNKGJOUYn X-Google-Smtp-Source: AGHT+IEchQlRBaLX94GdssBYf3s4IY/Yz2eEcWJ4UgIzfIk2HDyYDgD+n11Jh5LBvvo9ksIHfwYLiQ== X-Received: by 2002:a5d:5f91:0:b0:42f:b871:66b9 with SMTP id ffacd0b85a97d-4324e7042cdmr1055149f8f.56.1766096150825; Thu, 18 Dec 2025 14:15:50 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Daniel Henrique Barboza , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Pierrick Bouvier , Richard Henderson , Mark Cave-Ayland , Frederic Konrad , Artyom Tarasenko , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 6/6] configs/targets: Forbid SPARC64 to use legacy native endianness API Date: Thu, 18 Dec 2025 23:14:57 +0100 Message-ID: <20251218221457.73341-7-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251218221457.73341-1-philmd@linaro.org> References: <20251218221457.73341-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766096224648158500 The qemu-system-sparc64 binary is buildable without a single use of the legacy "native endian" API. Unset the transitional TARGET_USE_LEGACY_NATIVE_ENDIAN_API definition to forbid further uses of the legacy API. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- configs/targets/sparc64-softmmu.mak | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/targets/sparc64-softmmu.mak b/configs/targets/sparc64-= softmmu.mak index 7b5d475c85d..d9d51d21e59 100644 --- a/configs/targets/sparc64-softmmu.mak +++ b/configs/targets/sparc64-softmmu.mak @@ -1,6 +1,5 @@ TARGET_ARCH=3Dsparc64 TARGET_BASE_ARCH=3Dsparc TARGET_BIG_ENDIAN=3Dy -TARGET_USE_LEGACY_NATIVE_ENDIAN_API=3Dy TARGET_XML_FILES=3Dgdb-xml/sparc64-core.xml TARGET_LONG_BITS=3D64 --=20 2.52.0