From nobody Mon Feb 9 20:59:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766093373; cv=none; d=zohomail.com; s=zohoarc; b=b7LlKBQamFCdaPckuFmf2DZ6Q0knL0161T+7HM5SbNuMG+z10w4ZNjVktRO9oItYmCt/4+4LAW2BLW9zTtmIyVbYb8uOkTjdld8Sv+ytuiM5is2Pj/AcodQGfOHD5HomdHLqzUiWhEbJxFzJK++lYuCQf6p2yXo+Wj/r6Ccqj98= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766093373; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=I6HMTxxs6Ve5Sks2R1l9RktCbKwSNfSiUvebbKXSoPQ=; b=H8Jn8GZGv7f3jHqJarlvPG5yps0u6jinfWCYlifrN91w9LicDDKu0DIdoqHHF7u5/8WJ2rEhNh3pcw701Y2OQtlz3eZeTqATMI/azAmzBb55LWkvGF+bMXFJKri28+gLcXX6E3cGFMLZnvFx1ZxEn0M48c3sOn/xb+8qk6BnfMM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766093372979542.1343769309786; Thu, 18 Dec 2025 13:29:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWLY5-0001EM-Rf; Thu, 18 Dec 2025 16:28:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWLXy-0001DI-CZ for qemu-devel@nongnu.org; Thu, 18 Dec 2025 16:28:30 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWLXw-0007Ee-93 for qemu-devel@nongnu.org; Thu, 18 Dec 2025 16:28:30 -0500 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-42fb0fc5aa4so948035f8f.1 for ; Thu, 18 Dec 2025 13:28:27 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea227e0sm1068294f8f.17.2025.12.18.13.28.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Dec 2025 13:28:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766093306; x=1766698106; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I6HMTxxs6Ve5Sks2R1l9RktCbKwSNfSiUvebbKXSoPQ=; b=fOyXC9eWK3L1rd2bPKAVMUr/xWOBOsI3z5NjnGvQXoQukcbm84VME1i4xmynEp9PAC uWJLmB8l4K50FsULOQNsRiyi7J2CvML8MHXw7QRasOa42oBeTOnJ/eJaHxUUOrguIqWf aBTUdEO0TeQYYvmqMAqNoBvuIyoqdzD4f656xGY2U3dPTfLNewHBD0Ep+OOfxDPI0Tls zJZneZ4sdKz2ayvdxrP9ArsqXdd6Xrws0kTdk4lRBs9z0QHqkUJquxwGMuE6Ctpk8k/p z77PlogzvHE9rWy5kXJBvpDk3PTo98wZ9VS9LV/SD8M5CypoHaDiWBDS8+utzmqX1NTi MROw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766093306; x=1766698106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=I6HMTxxs6Ve5Sks2R1l9RktCbKwSNfSiUvebbKXSoPQ=; b=SWHkIV01KRf8rgTc9hhXAqNkrOU2abqsVYixnwcHJcJ4MLOCI9YxLhcs/DH5xb2n8y X33xwAaPXQlRSoiAOR37FidExRXXD2Z8rcinFTXkbt0olHonOgEfXu+AsjdPx91lCRuQ FZljXko9tF7rCntmTOERjM0aa+Y9MCTvO/+WMBIpqI1jlELW3kwDzT5cGaGLkIIvnkV6 4ekg83y7tdfFuDiaj1An8v/C7hr1n2r8Gu6U+FqURPFOhl4ViHEe9Mnwkf6/hWCxwCf1 HvBXfuaLwFfd4CuL4FdYufmGSDvBGM2WP81cQUwP1+X+8KSzOrSk+OGUaf/xN4tEM7EP XqDQ== X-Gm-Message-State: AOJu0YwjpNALsv7K+TwbiN1ganZWObJ/x5fBKYiEIy8nuShlVtTb9Ij8 fXA+fvjuuPey1nrZE/8/Roj5VoUh7zk6LyVcCu/CrBpu6fQSv9v0+/idLhNS3nIqdRG0r1/lKM+ fll427zE= X-Gm-Gg: AY/fxX5TafwhhMz16RyBFkGjPx/qXQAQ5PBXOHkqyLHWb5USbwDcK6pCp0bJGCWvvOU HKAoAVxfHgF0Af3RzhAw2cHuC9rNpyBrrpPjolXLJHlhbtYlPHG+dd9afoYzvqCvWR44mRKxR1F O/7AUa4VVnSqHrKXW2GE2GimKJaLxQi9vhFa0m/+ipcirCOKdUf2wGyKfN9KqFNxNz2vRqxgfMX mX0CP9Y1w82bbeXA7S5ixbmvszO/cGGwxhBa04FDhJ7/fQZDKezFiwme628YDVhF9KW6tgU6QeH uchEYmbvw8aw9m50tLBGChK23Qkimm1TsMlED2P3lbhoLSnBjQ8ihXXmLYczPIfRr2WMPVwq5Ys ZH5WTd/eWiHuRx3HCxTN5zJ3bLI4/B9b+XrhLVBvxgdP+X27JWvVp3nUGI/1WfMc1UzKGkXgdDD A82+KSU7hKY/NyIhfAsNgJsAduVN4tqAC+W2fyZVXLoo6Ef2fzMhjizg7x0ZbI X-Google-Smtp-Source: AGHT+IEirV0DT3iV3gJMWLAtlllkOQAolkTzB/ofps8NhJRYPSQ6yOwKN1+BCrmcryd/SEm3mE8shw== X-Received: by 2002:a05:6000:3109:b0:430:f494:6a9c with SMTP id ffacd0b85a97d-4324e4cd1b9mr747742f8f.17.1766093306422; Thu, 18 Dec 2025 13:28:26 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Richard Henderson , Daniel Henrique Barboza , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Peter Xu , David Hildenbrand Subject: [PATCH 1/4] system/memory: Use explicit endianness in ram_device::read/write() Date: Thu, 18 Dec 2025 22:28:11 +0100 Message-ID: <20251218212814.61445-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251218212814.61445-1-philmd@linaro.org> References: <20251218212814.61445-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766093375597158500 Replace the ldn_he_p/stn_he_p() calls by their explicit endianness variants. Duplicate the MemoryRegionOps, using one entry for BIG and another for LITTLE endianness. Select the proper MemoryRegionOps in memory_region_init_ram_device_ptr(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- system/memory.c | 68 ++++++++++++++++++++++++++++++++++--------------- 1 file changed, 48 insertions(+), 20 deletions(-) diff --git a/system/memory.c b/system/memory.c index 8b84661ae36..5bcdeaf0bee 100644 --- a/system/memory.c +++ b/system/memory.c @@ -1361,41 +1361,69 @@ const MemoryRegionOps unassigned_mem_ops =3D { .endianness =3D DEVICE_NATIVE_ENDIAN, }; =20 -static uint64_t memory_region_ram_device_read(void *opaque, - hwaddr addr, unsigned size) +static uint64_t memory_region_ram_device_read_le(void *opaque, + hwaddr addr, unsigned siz= e) { MemoryRegion *mr =3D opaque; - uint64_t data =3D ldn_he_p(mr->ram_block->host + addr, size); + uint64_t data =3D ldn_le_p(mr->ram_block->host + addr, size); =20 trace_memory_region_ram_device_read(get_cpu_index(), mr, addr, data, s= ize); =20 return data; } =20 -static void memory_region_ram_device_write(void *opaque, hwaddr addr, - uint64_t data, unsigned size) +static uint64_t memory_region_ram_device_read_be(void *opaque, + hwaddr addr, unsigned siz= e) +{ + MemoryRegion *mr =3D opaque; + uint64_t data =3D ldn_be_p(mr->ram_block->host + addr, size); + + trace_memory_region_ram_device_read(get_cpu_index(), mr, addr, data, s= ize); + + return data; +} + +static void memory_region_ram_device_write_le(void *opaque, hwaddr addr, + uint64_t data, unsigned size) { MemoryRegion *mr =3D opaque; =20 trace_memory_region_ram_device_write(get_cpu_index(), mr, addr, data, = size); =20 - stn_he_p(mr->ram_block->host + addr, size, data); + stn_le_p(mr->ram_block->host + addr, size, data); } =20 -static const MemoryRegionOps ram_device_mem_ops =3D { - .read =3D memory_region_ram_device_read, - .write =3D memory_region_ram_device_write, - .endianness =3D HOST_BIG_ENDIAN ? DEVICE_BIG_ENDIAN : DEVICE_LITTLE_EN= DIAN, - .valid =3D { - .min_access_size =3D 1, - .max_access_size =3D 8, - .unaligned =3D true, - }, - .impl =3D { - .min_access_size =3D 1, - .max_access_size =3D 8, - .unaligned =3D true, +static void memory_region_ram_device_write_be(void *opaque, hwaddr addr, + uint64_t data, unsigned size) +{ + MemoryRegion *mr =3D opaque; + + trace_memory_region_ram_device_write(get_cpu_index(), mr, addr, data, = size); + + stn_be_p(mr->ram_block->host + addr, size, data); +} + +static const MemoryRegionOps ram_device_mem_ops[2] =3D { + [0 ... 1] =3D { + .valid =3D { + .min_access_size =3D 1, + .max_access_size =3D 8, + .unaligned =3D true, + }, + .impl =3D { + .min_access_size =3D 1, + .max_access_size =3D 8, + .unaligned =3D true, + }, }, + + [0].endianness =3D DEVICE_LITTLE_ENDIAN, + [0].read =3D memory_region_ram_device_read_le, + [0].write =3D memory_region_ram_device_write_le, + + [1].endianness =3D DEVICE_BIG_ENDIAN, + [1].read =3D memory_region_ram_device_read_be, + [1].write =3D memory_region_ram_device_write_be, }; =20 bool memory_region_access_valid(MemoryRegion *mr, @@ -1712,7 +1740,7 @@ void memory_region_init_ram_device_ptr(MemoryRegion *= mr, mr->ram =3D true; mr->terminates =3D true; mr->ram_device =3D true; - mr->ops =3D &ram_device_mem_ops; + mr->ops =3D &ram_device_mem_ops[HOST_BIG_ENDIAN]; mr->opaque =3D mr; mr->destructor =3D memory_region_destructor_ram; =20 --=20 2.52.0