From nobody Mon Feb 9 07:57:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766082003; cv=none; d=zohomail.com; s=zohoarc; b=U53j++f8Z0h1IF18V7AD5MfJg2FVPhT5G4EW/ajyxThUL7jAskHJYRkoYRKg+XUY5mYzhg+azwcx5jaqQDSoxj2jwnsSounGmx7yOJ80egzjdMis+bIciIPhNOSa2uBS0JbmqM/sgFGFMS2QqZ5Zms9BS1GYGoxRbx0YRIMP2R8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766082003; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8Fw9wiW8eGiYc4imf57ZBrS/UxIVjWCdGG1Tt5+MH7Y=; b=hSbJ+0pLX/7Bhb5I4p/EWSlg+r2f2KFFiBlhdpI3/KxixODphzjUhPGhkMtNpyFfa7pekyezWxmJcNxXwdQMMYotfd6tE5G2zdNPT/CmUrRNLULWQTyJmbT9HKvETg2nkxltKg32GGvFCbpk7rg7BLnFb6lqRPfb9XJBBR0+2k4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766082003150841.6085537880092; Thu, 18 Dec 2025 10:20:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWIas-0006TV-6N; Thu, 18 Dec 2025 13:19:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWIaB-0006O7-AF for qemu-devel@nongnu.org; Thu, 18 Dec 2025 13:18:40 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWIa3-0002yq-Fa for qemu-devel@nongnu.org; Thu, 18 Dec 2025 13:18:31 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4777771ed1aso7612135e9.2 for ; Thu, 18 Dec 2025 10:18:23 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d19346e48sm3223475e9.2.2025.12.18.10.18.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Dec 2025 10:18:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766081902; x=1766686702; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8Fw9wiW8eGiYc4imf57ZBrS/UxIVjWCdGG1Tt5+MH7Y=; b=DK4sxOgFDcz0j3Ug6SMlaqCbOj6OJjQS4BHT7yvspOJnxB4DSQ7mEAyEX61MoBQcxN /ml++01sZJ+Qvd9SIAE48XpRtRZq2uz++3trcx1lxcbUc/XrfKprAn9L64uyg/vgODHb NtJD4isRJ46IcfSnXDJDU7bFDtzTwIS/dmZIUHHggQNa4BU7bhoEgYKqoMmOnib0PlaE O+qnSnGXUBEBbLa258kaos5GyHTlIcQrFrYbnUmbRA4HKJGfxRbioaF4vI6BhkVhNCqM ZBvTlpZ1goD7HSFv5zGFnfngUppA8r66fQeWhKFdHC2mceeKKpRCyc9W1lePyBVUO96Y 5cmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766081902; x=1766686702; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8Fw9wiW8eGiYc4imf57ZBrS/UxIVjWCdGG1Tt5+MH7Y=; b=UjVhp8vWffU36lEXhdiQNWlG5KiYg0/L9aCZimkxdAYTNoLO773hu+eHMTInUYgicf V4bAPVpfT8s/S+ylMMWmeX/BCODu0y6j4/fpeDjR6K4S/F1BNnwTB5B9TtZV88GExenB Da87bFyTWzl3gHGzbc+vIg/nRdMepo3VetUTu4LX7clzeNutRdJZkwuYQm1+Xr0ZnMpH gi13GKB9YxNd8UNOQBU7OEdgTX03nRA9njyzkUB36UTekGV217at6/wEl1o1EoCrabGp EM6ttf+oLp2PdutR79OWsgTJhTvMVDtwQywvMi/Y133dua/g2pBM5M0hTtSVftMd4NhM ZJ1Q== X-Gm-Message-State: AOJu0YyPYaq++/vVpvgEony2XCb7+xNwRVxDYaiWypuWQ4UJtDqJw1z3 bfuC757tjsJU66G4OuZNJM/7hvz8s/F3nnrsG4yEpEo/+UA7nfEbLbPNN9FMvoSCXZJakflq53c w5ZyuxnU= X-Gm-Gg: AY/fxX5m4WGVN2HBDwK31wW0vjBp3WVSyTFKaB9+fvjeqQjJufA/4BwdOnfG/6BozlM uBYNvnA1+ToVG3gseRJXtqtkmY8kvsFfOToaD5BQwyxTShjzLgLufvjOvUbIjGHY8M3lTzTbkd6 5OD3tz+CDu5AygPcUAr00VoCX5GDY1oS77ILv/eqY4WuDkfvdtOeyqNm99MxLkYnLwQ4NU5RbYT YrBn6isO4JsvxO9RaaHyN7OiUtXv6MTm+zNIN1HouxABogUP1uZwt/gPkLeoaljNicXox1qKQRa mKmEK95AU7VccAj8vla7ExofYNbDxo9Aj/pLRNbMCFGdC7BH8iovjUgxC44CS54f//gxHB/uNw4 bEPDJjoeNMV9ozNpYCknbDtt/qB2kuE+RvCvmy2PI+RVPofIF3lj5/vehN5YYvlvjHLCjv+aVlV rhV+Aw8Ll2uT+NBNQUZ5MN1lSgCod6xcs6zc3m7UWW8MmuxNTdXNcA+a7KusdPO6Zz4iW9dIs= X-Google-Smtp-Source: AGHT+IHqA+vzL5VfowrzPMh4sMwFeuxieIhnO+m2qRQLOkWuGZXOGkqq7f16yyX5dRTnLIeRTkV5vg== X-Received: by 2002:a05:600c:4e8f:b0:477:df7:b020 with SMTP id 5b1f17b1804b1-47d1957da79mr976125e9.18.1766081901671; Thu, 18 Dec 2025 10:18:21 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Peter Maydell , Jason Wang , "Michael S. Tsirkin" , Max Filippov , qemu-arm@nongnu.org, Manos Pitsidianakis , qemu-rust@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/6] hw/char/serial: Let compiler pick serial_mm_ops[] array length Date: Thu, 18 Dec 2025 19:18:06 +0100 Message-ID: <20251218181812.58363-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251218181812.58363-1-philmd@linaro.org> References: <20251218181812.58363-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766082005250158500 No need to enforce the MemoryRegionOps array length. We index by device_endian enum, the compiler will easily pick the correct length. Besides, this allow further adjustments in the device_endian enum itself. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/char/serial-mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/serial-mm.c b/hw/char/serial-mm.c index 13aba780ec5..ce5b589c3fd 100644 --- a/hw/char/serial-mm.c +++ b/hw/char/serial-mm.c @@ -44,7 +44,7 @@ static void serial_mm_write(void *opaque, hwaddr addr, serial_io_ops.write(&s->serial, addr >> s->regshift, value, 1); } =20 -static const MemoryRegionOps serial_mm_ops[3] =3D { +static const MemoryRegionOps serial_mm_ops[] =3D { [DEVICE_NATIVE_ENDIAN] =3D { .read =3D serial_mm_read, .write =3D serial_mm_write, --=20 2.52.0 From nobody Mon Feb 9 07:57:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766082004; cv=none; d=zohomail.com; s=zohoarc; b=W7s3eG3Z4AcmZiOfAoaTUqZsk2y8WvRSNUUxRhWchpRWcGkF5WP3z2H3Ip9JL5+rUUQQXQbaYxDvdKvtNrlOfDyCbApUIGncJ88FBjg2NPDrEejXW3fKHvBcUDC2DFFUkCiRSp3SPsbSdDMf1nHL6UQfdF7EFL3wo8hrAK6rKrQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766082004; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Q2jzZ6rMbXeUMPOwWK0Noq7Cc0GkvQldGamqYQfCrH0=; b=liWWDBkW0OQzsrzjZaG3s9Nir8hpCBk30IRklLFsJb0DYA1flinZKEtVMXKjJao3D8Gcu9lw2qXRRIzR6leb1PPOOFEecCXgJTu1YNL9ZyJRmkzAgXiekcYtMAniQVWVXGE0bH2K1u0kJkQfTI4akQZXUbAbxtpfEGR8HuPBJSw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766082004686468.1596888278267; Thu, 18 Dec 2025 10:20:04 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWIar-0006TT-J0; Thu, 18 Dec 2025 13:19:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWIaM-0006OX-2Y for qemu-devel@nongnu.org; Thu, 18 Dec 2025 13:18:52 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWIaB-0002zQ-0x for qemu-devel@nongnu.org; Thu, 18 Dec 2025 13:18:39 -0500 Received: by mail-wr1-x442.google.com with SMTP id ffacd0b85a97d-42fb0fc5aa4so821471f8f.1 for ; Thu, 18 Dec 2025 10:18:31 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab2a94sm185691f8f.43.2025.12.18.10.18.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Dec 2025 10:18:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766081909; x=1766686709; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q2jzZ6rMbXeUMPOwWK0Noq7Cc0GkvQldGamqYQfCrH0=; b=FBhttFlhM5kfbnIfdiW/hsoU6NC6lCOgkK8XjF0Ayu5gxiF2f55OzKwLT/4tfc3ktO Wu21vY4FDDvCXntT1SvCO/KoqcvnmXaNOdUU5ENjnyZS+f+ERxah5xKEjMYlfiKDnGNf e5ol+3uHcv8rdRqIpz2+1X5KzV67uteJvetuyEB44nQwY5y5iJFAdBDp74NchyUJr+mf JL57oo2iQ8AILMY5jDZLbj8Iyva6YBrL/G3rMPUkmuadE14WF/RUolvjN8KLuqCCKxCP 5GS1v25HEEbWLuxRRyIlQE/GkOj7he9vS56DO0YGD7WOF2iFFpyxcs4JNFsQRrPvneVj ApLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766081909; x=1766686709; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Q2jzZ6rMbXeUMPOwWK0Noq7Cc0GkvQldGamqYQfCrH0=; b=rXlsdwZhHyqShhaG3dbt2UD4m0cdPuAnLvLFejzfkt7tEUkvpvC98uX0QHbp654GwX N6CaHOeNA5boduvX8s+p7BOEfVu4t1/oK185mf17/99+kqI3vJpdOCx/HtPY9amn/7JI 513ZIJrPfPl4Ck0pq+BYoDgL75Cx8KrIipNrDhgy1+KIw+1ui0ECGr/cyiSuD/gyYgvX YAsE6U/Bj3rU9H+3Jwu0FdgSzRJR8IbhIPbwmUYnndouyNRvsb6A1rPnLzhCkA7dZjKA uVVEK3Y/zP0sBRckajvrXFbhMJsF9v2+L+ylT0wsGXAX6Qehyl+urGgVhyINZcRsUfFM gIUA== X-Gm-Message-State: AOJu0YzirPS49shcMeXO6Hca4unUKDbUDumJMpZWcN96vYe7rtaKTrD3 qlBXkJke9mZzrUo0dahT10Vo8+l8WCfHGLT+RqaS1rmDe9aIAmuEahVempSqPFILLLrrsNkWy0d Unq9zhJMHPA== X-Gm-Gg: AY/fxX6QFqPVbgcK97njsjhhuILMIQW0kRvj/oOc5N/d4ifdpb8oa5lf0ujl+QPbTZg kVGqCfLPc8HmjXcaJKHIC5DZQhZbVBpJXBNyJdhZBe9qnk2PHvMOv9X9xfnxHxoDV7k/xHbyFBE DGKFgjFTOSWPL/z+4upOOSIqNuIfqphD8VoCZCRxsokV0GuU6kTNrRw91tT/8gf9GzGZ6HwEOW/ OFGnYxawX8Exbx4TohxIIFXiocyYLcMU19tF5KUncf5TQCqpX8aPXCFEeN5h9cgAvqlgIBivi/O kXm4NTg6XYWTx4Mdb0zXMgFzGAzQezDKq/RSN1V+cOSWQ+HyetiboXzROAlE6CWsZ7nSgc8vVIu 7AnmMfLM1zqYRgJPwTloDRBDOkxOyf2q2rqAirJB+UWZCV1BMeNbhA5JtK6a2sCiPA1C9pRq9Zs fxwOJ4rASPgeygrvmr6Vzc2fG/nq9d/+xd25ShWizBlw5XwxAMEvPaI7Eum9ZV X-Google-Smtp-Source: AGHT+IEAW5huNZELbZIqdkHfWdDcXAGjayFL02oMUq8eWGUy3O/rAQUyNE/GfTGxZLtaQgaaZuRg6w== X-Received: by 2002:a5d:5d0e:0:b0:430:f58d:40df with SMTP id ffacd0b85a97d-4324e4c7132mr487404f8f.10.1766081908907; Thu, 18 Dec 2025 10:18:28 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Peter Maydell , Jason Wang , "Michael S. Tsirkin" , Max Filippov , qemu-arm@nongnu.org, Manos Pitsidianakis , qemu-rust@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/6] hw/net/opencores: Clarify MMIO read/write handlers expect 32-bit access Date: Thu, 18 Dec 2025 19:18:07 +0100 Message-ID: <20251218181812.58363-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251218181812.58363-1-philmd@linaro.org> References: <20251218181812.58363-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=philmd@linaro.org; helo=mail-wr1-x442.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766082006722158500 The read/write handlers access array of 32-bit register by index: 277 struct OpenEthState { .. 287 uint32_t regs[REG_MAX]; .. 291 }; 546 static uint64_t open_eth_reg_read(void *opaque, 547 hwaddr addr, unsigned int size) 548 { .. 551 OpenEthState *s =3D opaque; 552 unsigned idx =3D addr / 4; .. 559 v =3D s->regs[idx]; .. 563 return v; 564 } This is a 32-bit implementation. Make that explicit in the MemoryRegionOps structure (this doesn't change the maximum access size, which -- being unset -- is 64-bit). Move the structure just after the handlers to ease code review. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/net/opencores_eth.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.c index 7e955c01322..bc4565a9a49 100644 --- a/hw/net/opencores_eth.c +++ b/hw/net/opencores_eth.c @@ -682,6 +682,15 @@ static void open_eth_reg_write(void *opaque, } } =20 +static const MemoryRegionOps open_eth_reg_ops =3D { + .read =3D open_eth_reg_read, + .write =3D open_eth_reg_write, + .impl =3D { + .min_access_size =3D 4, + .max_access_size =3D 4, + }, +}; + static uint64_t open_eth_desc_read(void *opaque, hwaddr addr, unsigned int size) { @@ -705,12 +714,6 @@ static void open_eth_desc_write(void *opaque, open_eth_check_start_xmit(s); } =20 - -static const MemoryRegionOps open_eth_reg_ops =3D { - .read =3D open_eth_reg_read, - .write =3D open_eth_reg_write, -}; - static const MemoryRegionOps open_eth_desc_ops =3D { .read =3D open_eth_desc_read, .write =3D open_eth_desc_write, --=20 2.52.0 From nobody Mon Feb 9 07:57:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766082079; cv=none; d=zohomail.com; s=zohoarc; b=mmrYXlL2sIfHbgyawlpnhgH17yqWiThhGp6jSvJWWuHMH5niZKEuHUEpS4vTnK9ehdc+8jdCgby/emYGgEATqWA5xk7OZ1pH7p35EDKBlFWOBSnXne0Nx7kegoJ13zNWFWi/R/+ICcuvD5OxnETcH8bd8NBCn7+auTh7CFMEazc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766082079; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ek0ZqoV7lcVrfafX0nJ7A9JZOJmPGubRBeO+HIeHC5Q=; b=ZNMBiYTDfC5wTRSbEbnJxhgFA92XrfisA5hDTvotsJyOmeZf6ZIgBlnGE1Agsgw1qBhWDyi4pGPCMHuAuuFfyMY1gQn9/e2mDWR2esmNwAcYsQKC1L9AarxpQgkhe7/E7yaJ9SPIVsucjiySZVOdZemWgSXEjTxbhszuK0xroZ8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766082079502346.17827867266476; Thu, 18 Dec 2025 10:21:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWIb0-0006WL-Fb; Thu, 18 Dec 2025 13:19:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWIaP-0006P1-J6 for qemu-devel@nongnu.org; Thu, 18 Dec 2025 13:19:01 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWIaJ-00030E-OQ for qemu-devel@nongnu.org; Thu, 18 Dec 2025 13:18:46 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-47aa03d3326so6014575e9.3 for ; Thu, 18 Dec 2025 10:18:38 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be279c5f8sm52622545e9.9.2025.12.18.10.18.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Dec 2025 10:18:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766081916; x=1766686716; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ek0ZqoV7lcVrfafX0nJ7A9JZOJmPGubRBeO+HIeHC5Q=; b=ptCwowZOyQLojZP2vZ8h6hKy4P6jhHsp35Q1ANQ2V113B7Oi9cSPjBoD15rYSy0V6q DfyZIq7G9QC5F1SmxE0NE5pV8sP5JWstpHABig1ltMSfrkzaHOC48shSgQxtmGFSeWVs FIhTKFU6HHPDqoj2+eKqTsEna2EJGdw4VI9hE1cUB+U/SYC8x1g8GN5Mnqx3G5xGYV8j CTFwjAeK6rDVhhkBaU9AtDgWoh0rpXA8CTk1tNWWgETeCkwxHjRlm2MEwK35fIjebsWv 7RNczGAQFHFOEhttB3UP9TVjZXiwIQP7BQHKEScIsXFO8jrVwRX1WN4PAiUxHjS/S/2R VMfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766081916; x=1766686716; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ek0ZqoV7lcVrfafX0nJ7A9JZOJmPGubRBeO+HIeHC5Q=; b=pjmWey81CJC+fGjf978eSl9sK3wP2iYPaWH8leXSQku+lauCYHvric3mdeYCth+QRv 9n8PPm5UAQ8ulYezra+hcz2wsrjQxaH+NLCg2U63EupxqFOTAqLSpOkLYqMX2/ZfhGWk CDtRRzVZp3+b7vpLAr+sHvXGH45igCSydkQRI+UoqMddfID+4y6JfDqezfazWe0jnjda CKFT25b4sO3rLzpKRHbUP2yExBlGVeAbvrqB3m+A3j6LoXdtOIATtY51BBUMBn8qc7vU kszQ2T0fAxJsNXmAdLpJleeEVcn3PnHkfCRlQdGhzZRaInfcqRhcjAYy5ejghXmIj6S2 Rz9g== X-Gm-Message-State: AOJu0YxvLKYi/jNiv5UfAMkRKqgJeHsu7GhoVkkYQjwAu1VaGdZd52uM HxUiZZWj23yV87XrVIEkXbLCz7CDGPb9iTTII0/WhA0TnYmpa2PUHX9/XsY2U97zkkIv5X0FzO2 8lbrV1js= X-Gm-Gg: AY/fxX5v6qBR2kxWRyA18df0VeqZh9koiq/8C3pYq0tzqIqsOM7kZ4P+2qfbE6Wu9D8 PQ2N8ctVOG5hPOXMXI0jUV0FhP5RLax3EPF+Lgk6S5iEx7L9KARnl/wnG5sAaCyk0EXAaTJUIVW +JnKjw5QO6Ly0FkATa5A77VzEXu+/13Wh1dl00ry+MDt3SjQtYbfA9kdPaVulJktB04xxvrnlj3 kyrXdy1NhLoUF/ZNdRAWPk6nPddB9INHIERw5K3np9yBDnwnKeT7IDGBJtZFYaOH2uiJSDm02yM CyCg86/lHxM8xBpcwf00hX9RW3qk4EI9xE1YyqalAiymY6mOx7Z08uNVSBoYpoMVvc9mRLZ3AIr kTTdGSo9C5Xc1j7MjvC6IBYvtloxO6iXxlMeODH1GhUAf+nBJPidyGdw/XDyee+8JpeHohxuFG5 0dDDzjL/HWBkv7hwPxccaTZHSLFASAwlcjIU/4rht6lifmyXgXzcUc9OvBahZY X-Google-Smtp-Source: AGHT+IG3rBj8MLgy5ArgGS6tuUNGiYQve0lqqiTO86Ek4KJMvYwdpNN/K3yJIGq4tWTBYEXioVJH2g== X-Received: by 2002:a05:600c:8208:b0:46e:33b2:c8da with SMTP id 5b1f17b1804b1-47d1958d960mr769485e9.32.1766081916568; Thu, 18 Dec 2025 10:18:36 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Peter Maydell , Jason Wang , "Michael S. Tsirkin" , Max Filippov , qemu-arm@nongnu.org, Manos Pitsidianakis , qemu-rust@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/6] hw/display/ati: Access host memory as little-endian Date: Thu, 18 Dec 2025 19:18:08 +0100 Message-ID: <20251218181812.58363-4-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251218181812.58363-1-philmd@linaro.org> References: <20251218181812.58363-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766082081050158500 ati_2d.c is part of the ATI_VGA component, being built with the hw/display/ati.c file. Commit 339534d4025 ("ati-vga: Fix indexed access to video memory") made access to host memory using little-endian order. Assume the same order is used for the 2D component. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/ati_2d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/ati_2d.c b/hw/display/ati_2d.c index 309bb5ccb6c..72fde6b8008 100644 --- a/hw/display/ati_2d.c +++ b/hw/display/ati_2d.c @@ -221,7 +221,7 @@ void ati_2d_blt(ATIVGAState *s) for (y =3D 0; y < s->regs.dst_height; y++) { i =3D dst_x * bypp + (dst_y + y) * dst_pitch; for (x =3D 0; x < s->regs.dst_width; x++, i +=3D bypp) { - stn_he_p(&dst_bits[i], bypp, filler); + stn_le_p(&dst_bits[i], bypp, filler); } } } --=20 2.52.0 From nobody Mon Feb 9 07:57:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766082038; cv=none; d=zohomail.com; s=zohoarc; b=ZHK3T6hr2zNe+EUnaMqc/WEt0JBe4ZoUYf4umZTUd5e+CknwYiJXDkvqXoJ/3AoTHhs0qJwIYy1uQ/rRUi45awwtJKZ4JVB3VjDOf0rfY7HFV9BwMDXzMLoW35Ll9w38eohwJeMLk6IXIlV0F8zpRB+dX9XwWeIMIHMjPqleHL0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766082038; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Bvj1AJund8BJzCKIAsZJhSHjk28uN32H7UcwVRZ2KTY=; b=EckjrzhjvGEKcO2ebwooqjLvxLTg2EHStHvNIGUfdUW/LB9NRZExFBOMLUNmuKMnkcyDuCjrcyz/C9ps8fd6snYPbk0m4UYJ2Q5OYaF8xCzDrUAHcDv2VhM7Ltt7TfuED+NgE38gn+S4dDCnhQcIQGsw7UOxuiZQGTohSwHa4/k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176608203809938.825508330917614; Thu, 18 Dec 2025 10:20:38 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWIb1-0006YA-Ig; Thu, 18 Dec 2025 13:19:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWIaW-0006PD-72 for qemu-devel@nongnu.org; Thu, 18 Dec 2025 13:19:03 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWIaQ-00031P-S1 for qemu-devel@nongnu.org; Thu, 18 Dec 2025 13:18:55 -0500 Received: by mail-wm1-x341.google.com with SMTP id 5b1f17b1804b1-477b5e0323bso11461425e9.0 for ; Thu, 18 Dec 2025 10:18:46 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa08efsm199771f8f.29.2025.12.18.10.18.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Dec 2025 10:18:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766081924; x=1766686724; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bvj1AJund8BJzCKIAsZJhSHjk28uN32H7UcwVRZ2KTY=; b=v33p0i4VKUWoTrO5d25jBdmpuJ/6wkvkpqkZpouGO52lZpi6RRDN3mPlsMxjhehcu5 JXv+3BTR6qsS3Q+YXKOGNtY85jciKbHGbdYJEfTg8GqiJl9aGBpfc3wKj5GwlbKOnsvw FoDUOE/N2gD+lkMsquR279yJiloaNjZ0eOio5poMBokTxvtzUQCU9/ZW2AwZD2sFh+SX MTmaaRLVZCi3zHg2dE6ug+5TSEFJX71Nfb6H2cUDqjbkm9ptrv62S9oamIo+p/49OpV2 vdhSDaKE52miIfGdOI5HhaUU/xYTBIBLpSkc+rfIyKf9wlF3inXo1kRB5Aze5DXGc10/ HDuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766081924; x=1766686724; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Bvj1AJund8BJzCKIAsZJhSHjk28uN32H7UcwVRZ2KTY=; b=L2jr9pIPaBo0RrdctX6l/bkjcOAdMPwnyrR4vyCXqTMfAWpC5UUDE59/SvuRAxw9C8 s2HQR3mgViZlGXt+c9G+ZqCnOq88T66zBVzkSQlgc3SZwdl6vuwe0KhylRPFM49O9esz gRt1n8eEbl61+fDBHYSDF9sSP9ZhP7Gu7ut9yoM3sLf5WVxG2/vlgx/9oFntx/FnO+6Q 1WxPeEQlSYA0wY6VsyKwqol+2K2YMFXdVIMRsqNfrKfxE0GmWTj2oJpb/S4/399ddLcU 9vpSnZNdz2zfQ5IaM7T4WueUAaHL7mibTw5S2uBTSaUmSCCA1CEQSSOFuLPNPSR0UAZm o/3w== X-Gm-Message-State: AOJu0YyPnrhAvEU/VltJ2buKOQk6wNUKoVWAxE2BU7AhBk4MnZrgJnDS EPjVM7A0chFoxY6nBplyxTUE/kUY00YkOrxDLz4VqSl1D0HDplQ4jK9EKo/beb6dRWnTLFfKB00 cM6h+Kvo= X-Gm-Gg: AY/fxX6lcUHf9sawhAzGZz9/CylolwCvyWi58HiaAbs9yT5hcDrmTu6D2klH6XbYS5J vWZonrk5nvT57R5whWxW196/wNybPa7d8HL6qLBO763flPIKl2/pKSwyYidAkglP6xH5ZJk2Zzo 9ALNL+/htnyHD3epOZ6XiemzPBW0NsYHNEZIIWH3kQL8fMFLv+Rf9q6m449a7u4nX1HrXYCtSAi SAb01vL0JnlL+NkE6vcYG9aqhmBKf8KE/hL5WWSo6a/JvZCp5IvyB1YcAMDHNEiS9zWJZo7SAiF KeGe8qg/kUkxLXCZ5nFZxx91JuaF1WcAkkGoqmFJfZ0Lg0oIgkA3CKw5Zl077PBP8J207wsuT4T s8XRxyXuY4ibENdCEcUkZa4WIZWUmuk1fMTs4u7254P+bUBwbnsghvKtziJRlBLJfD1OCU24XWP 29iUnz7dXW65PPGu1LjDx2UetwOhNPcjA9P50+jwEKo+AFBwlWr1a517YzRFmD X-Google-Smtp-Source: AGHT+IHHuTTKYx9RGCYajCMCUuN820Kiap/GpFsIBYAXwUF34Sg0U5YEuJQg4DCduJdHoGUzZRCizQ== X-Received: by 2002:a05:6000:250d:b0:430:fa12:3b6e with SMTP id ffacd0b85a97d-432448bf55emr4584653f8f.24.1766081924100; Thu, 18 Dec 2025 10:18:44 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Peter Maydell , Jason Wang , "Michael S. Tsirkin" , Max Filippov , qemu-arm@nongnu.org, Manos Pitsidianakis , qemu-rust@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 4/6] hw/timer/hpet: Mark implementation as being little-endian Date: Thu, 18 Dec 2025 19:18:09 +0100 Message-ID: <20251218181812.58363-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251218181812.58363-1-philmd@linaro.org> References: <20251218181812.58363-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=philmd@linaro.org; helo=mail-wm1-x341.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766082038835158500 The HPET component is only built / used by X86 targets, which are only built in little endianness. Thus we only ever built as little endian, never testing the big-endian possibility of the DEVICE_NATIVE_ENDIAN definition. Simplify by only keeping the little endian variant. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/timer/hpet.c | 2 +- rust/hw/timer/hpet/src/device.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index 1acba4fa9db..bfad626d5e1 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -648,7 +648,7 @@ static const MemoryRegionOps hpet_ram_ops =3D { .min_access_size =3D 4, .max_access_size =3D 8, }, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, }; =20 static void hpet_reset(DeviceState *d) diff --git a/rust/hw/timer/hpet/src/device.rs b/rust/hw/timer/hpet/src/devi= ce.rs index 3564aa79c6e..4f4be84115e 100644 --- a/rust/hw/timer/hpet/src/device.rs +++ b/rust/hw/timer/hpet/src/device.rs @@ -708,7 +708,7 @@ unsafe fn init(mut this: ParentInit) { MemoryRegionOpsBuilder::::new() .read(&HPETState::read) .write(&HPETState::write) - .native_endian() + .little_endian() .valid_sizes(4, 8) .impl_sizes(4, 8) .build(); --=20 2.52.0 From nobody Mon Feb 9 07:57:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766082008; cv=none; d=zohomail.com; s=zohoarc; b=WQBIbYoko+Vm5Uy1ol2ro1sGpURdj5AAliuAa2HTAgKB93H2UmwTevgacMSTLgJE8iOqk2QW73MzRAj4dXEHTE/fh2UATc5lOv4KmIsm8SoABTwH5GlafdZ2kprd6P0NEWaxTPdWNWKKKdYh4NNty7Ffwz7ntKXh6iuG/o8Xdv4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766082008; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nPZZBApwFpp2aCgUR9OuXCPmOWKQbdSQ4X0mg+cAPjw=; b=TRPbLbEZ/OhSx1/gu1hrxVyuyTA8E3eZB6PoXN0Fvv8l3RerOEJ9PAN9dA+n5CGXJlN+y+YKfJqph46Fy0G9RwNhSDQxElxxxaHm9cH6bDN+vy3+VGqPIwJf/QfnSg44bBhWqGl/zhT21STR/3aSv6Wm8ChtwqYT3VsEslO6lb0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766082008715491.5939765110211; Thu, 18 Dec 2025 10:20:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWIaz-0006Vj-8M; Thu, 18 Dec 2025 13:19:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWIab-0006Pa-EZ for qemu-devel@nongnu.org; Thu, 18 Dec 2025 13:19:05 -0500 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWIaU-00032n-Vd for qemu-devel@nongnu.org; Thu, 18 Dec 2025 13:18:56 -0500 Received: by mail-wm1-x344.google.com with SMTP id 5b1f17b1804b1-47a8195e515so8194375e9.0 for ; Thu, 18 Dec 2025 10:18:53 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be27b749esm53916305e9.14.2025.12.18.10.18.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Dec 2025 10:18:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766081931; x=1766686731; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nPZZBApwFpp2aCgUR9OuXCPmOWKQbdSQ4X0mg+cAPjw=; b=WLCZZEGI2NADo2tgC9tk64WwusxKT7tjZaLNOb+ubDqSSJZ6sbUMUkX6h9e2Hsoy7u vJv7NJL7NTS+EQm8a62JflefeHTFmTXRUoaQHpI2Rvz/qw87v027jFCu0vQ0hkeLUgyr efX5zGpwXVQRusYt4v37l6tOvXAmxnEk69aYte+qFWqHWZnzLk3TUrj06sMzAgZBFCta mYPHguyByFFmpK2NoURK7xgoRAW3OSTvmwGOAqOwF2xkOT60TaA0pjGf/tLUHTNy5LqE 0o79p418BcOU+ABmLwr3cdUGHbcbuVWLF3chp3gR6eQhWBlQ8wPSleVcYqyNG0pzYUt9 39mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766081931; x=1766686731; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nPZZBApwFpp2aCgUR9OuXCPmOWKQbdSQ4X0mg+cAPjw=; b=hSjsx7Ma4+j86LJXqfOMgTwFlHy9KQGbQ0ZxaRhYcM/dAw9tgZJufzS6mMhxvJLvGv xOBEl+KpBgVDqvjEHhUBCwVnOMUrEwwEnyflunalc5x/CNYhgXEpU48NcgzVsk1kxa5f AcmU/cNDsHryXpMbdLJudPBb2/4AqsbtHBJ3tOP70GICBmTZpNTuiVfShL1TMDcvSfIq cdS2yCS78y070tx1ORwSOaMGig6trFdRfgpqTt8it/4Foesls+tC+Fh/80a8usdJvHIT hQ6B1Zjet5ADPLy/U8v3l9g+ZsxgWOMchZhPgUNAJsxL9DxAqt+SL8AeP3zq9hRdyQVb QEEw== X-Gm-Message-State: AOJu0YwgK1bmgsZd4XKuAfHzBIjtofQmn7Kz6YMJlKOBBedDvp5e+K8j 8/JEkt8o7GZZ9oBehQAAW/t52ej/qc9rHsC0F7EqUwCwfNR5MP1v3Jmc1f3voPTzqLWyoFljWDL /1zCYT6g= X-Gm-Gg: AY/fxX4B/XhprY6XFxR1MlOG4frzAix/g/nLsf5cpIBDoQZsIWc8pzJgizQAAjkjUO+ 9tX3CI78aDI5263rgifGHqxCklmnv/D1ZyJhyGoW8pv8W79ngOyvJxV1jDwj9bkP1/Pq30bgVrZ PYSv7dmgbdygej4N2Y1sffNYQuUDYY2MdIxEoAkL5qSNvsk/+zlQjh0tjEOH5cW8ovtKcskrTVf d5SLh0CA0Tih19IOvskB9gOZvMvnluZngZ09fXsOYqWaWif9lTK/W6IhXZ1z6GYyi9WXrbLV/8c 3Vo4a2h0SzN1SOTq3ovP2X4reGAS/e5A7uV2AqHJpwl3/zQWMGsojtQyYS1mTsfXmHxCn769uKZ 2qpFIdDJhScEXWu0ZWIqiNvV3LpOneWauAbE8ZAZM18C/9ytAK7RnQLWgECBP/uVkfOU5Jzprt4 QRm3kJGm628M1c9TmqKCtIu9Ji2xKHedm4ggPKaRgRlnHrDsNG+quJ2HFvUsd2 X-Google-Smtp-Source: AGHT+IFj2uRd8hrdtFhyZ94nB8aVUnwZ0Rq4l/D4sNg/vSmct55uTd7IilnKbP4atxOhX0aO7Lktog== X-Received: by 2002:a05:600c:1c29:b0:46e:37a7:48d1 with SMTP id 5b1f17b1804b1-47d1959d4bamr851815e9.34.1766081931339; Thu, 18 Dec 2025 10:18:51 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Peter Maydell , Jason Wang , "Michael S. Tsirkin" , Max Filippov , qemu-arm@nongnu.org, Manos Pitsidianakis , qemu-rust@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 5/6] hw/char/pl011: Mark implementation as being little-endian Date: Thu, 18 Dec 2025 19:18:10 +0100 Message-ID: <20251218181812.58363-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251218181812.58363-1-philmd@linaro.org> References: <20251218181812.58363-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::344; envelope-from=philmd@linaro.org; helo=mail-wm1-x344.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766082010717158500 The PL011 component is only built / used by ARM targets, which are only built in little endianness. Thus we only ever built as little endian, never testing the big-endian possibility of the DEVICE_NATIVE_ENDIAN definition. Simplify by only keeping the little endian variant. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/char/pl011.c | 2 +- rust/hw/char/pl011/src/device.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/pl011.c b/hw/char/pl011.c index 01335d9437d..97cd9bd4c54 100644 --- a/hw/char/pl011.c +++ b/hw/char/pl011.c @@ -538,7 +538,7 @@ static void pl011_clock_update(void *opaque, ClockEvent= event) static const MemoryRegionOps pl011_ops =3D { .read =3D pl011_read, .write =3D pl011_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .impl.min_access_size =3D 4, .impl.max_access_size =3D 4, }; diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src/devi= ce.rs index 04155dabe1a..a6227a99f30 100644 --- a/rust/hw/char/pl011/src/device.rs +++ b/rust/hw/char/pl011/src/device.rs @@ -495,7 +495,7 @@ unsafe fn init(mut this: ParentInit) { static PL011_OPS: MemoryRegionOps =3D MemoryRegionOpsB= uilder::::new() .read(&PL011State::read) .write(&PL011State::write) - .native_endian() + .little_endian() .impl_sizes(4, 4) .build(); =20 --=20 2.52.0 From nobody Mon Feb 9 07:57:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766082025; cv=none; d=zohomail.com; s=zohoarc; b=UlnQjN2o5lIMkxO7DU1dLdLg/2uHO2EDr+Aue/0JyKNCjmKK0E9SorIRr6QT8vpumaGSP55qW7E+Os72qZ7jvppW4Pab7sapWQtPDuExdfdS7HRUXqFenAZNFFx+XNCAvvdqLpGSTYWQmdrvU9Ei6676HOBBz02irLqcksSAJXw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766082025; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KVD7KeNHSoZXyk7/Vq+5GFFpep3i4V4TnIDs7GSc+Ig=; b=jRVRMmgkw22Xs/4vEdsfp08f82gQoKXCF9A5DNmytRjUxgRaLjZBk+0pYwIeEDz6jYYQAismEw06evhBOuAXcz1DLXIV4T1Me01x23y1lE0zj1jCiFfDzoB3wM1A/Y11bC/sh3nBOnoaXVEmjipITO3MxDtSKj8lf1Hwnol1V9A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766082025212917.0902837551408; Thu, 18 Dec 2025 10:20:25 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vWIaw-0006Va-Lo; Thu, 18 Dec 2025 13:19:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vWIae-0006Q2-D8 for qemu-devel@nongnu.org; Thu, 18 Dec 2025 13:19:07 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vWIab-00034D-Hj for qemu-devel@nongnu.org; Thu, 18 Dec 2025 13:19:03 -0500 Received: by mail-wm1-x342.google.com with SMTP id 5b1f17b1804b1-477b198f4bcso7247995e9.3 for ; Thu, 18 Dec 2025 10:19:01 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be2723d19sm62333055e9.2.2025.12.18.10.18.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Dec 2025 10:18:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766081938; x=1766686738; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KVD7KeNHSoZXyk7/Vq+5GFFpep3i4V4TnIDs7GSc+Ig=; b=PJ1fLip4iN0iWvuoPWWWMS76ALLXbphvsg/5iZeBJMvco/8GFsIYnio2t2Bi1V5w0c 7HCtowB8DoTUxsYOacbGnBdIcWXOfHvsxUap/UfeqmhPNhxAM6hs8poQ/LvZirhuiLva lcyC44ERb3iEpRqOUvJiii8VVN+UmQQXO/Y0kd6fQFzyLHGtE8+1bt5/4M2BpSBfoJzs u3KnGApmVjc4Q/vruH23SAIu4MR6yAYRl9vDbSDvuydretMBQ8IVKb0VHjkTN05oW1Re lwgdIc60ejwgKtxFh1c1SzJmo62DzOZdCFBbZBGs4H1Gh32NLTLkeeT5X7o1OZkO7GM6 9muA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766081938; x=1766686738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KVD7KeNHSoZXyk7/Vq+5GFFpep3i4V4TnIDs7GSc+Ig=; b=U+GotEJayVhPYzEv2Vr9QQRQcuYRokuhVc9/2eae/HXJq0oZrmJvaucWidqCzG3p/C +CiKuxPElVzj65KdK6y2AcKcfDjWdeJO7FjIYUu2ndC9d5u1dg+zsXCiMKROZdWUrQUI ryWX60Avubd2/PB+yIQ5T8zRU8z//FGPs0fz/DyOYub+lnR678e+YClHDr4s9Glju4Re HsAtClY7OFkk8ebxRD8NyqwPQFrwUfcJyfm03v759fexsxz+Cfb0XoI3P7QMvm5Q2Uu4 M8gMnXO/Ov1CUwQZudLVkSsReLrItQ4x33Aad9rmT+yzQSX3RHhpJWYzb2ycW+2S6dyS kFvw== X-Gm-Message-State: AOJu0YyHEuN37I5Y96W5hJJfqLlMC/ueexem6RKa3sEu4UZAxK1jdRaz AHdHC06U3HHuSQX//R9fyCgb5s5VhW0YzelD3X0Wr5SFSDdi+W1vdvLk6nvykFbAbqrnz+8/1u0 O/VsvEmg= X-Gm-Gg: AY/fxX5Rj4mb/ExTBb1CSq7sJBJWHL4CyYpXSVivHvYikEF8efWFTdLfwoWrP70+ULD /5eMoN++If4AdB93DQRjRg8nO5gkb+CKt1GcHgSF+KGqInnK7dSEYWncY4ZeESNsrNCjGMGjJqS XGvIdW7aMGvX7gpWWFgCyIzFPKgzl2HN73fxOfxFr+0awOrjpddiKXpYg77vYBMrDq8R498Dw1P lg3fnENm04W4YFW3k5W/igC6+MgyXPUspA6lN5MqsobGG3FF1KCB9Gc9m0xzoUyuLCNT8rcfTsY J2AKoXcSZ+TAxUwRfoACm2eVgD95DPliOJBsL6z7pN8dlZQzfcCBfv0mTFYLhgm++j9aPlHyIpC z18g+LZ0+5MqYvGVRIXWEDLkBfVn1HEWClWFB++6JciTFo+QYy/Ds90siYubTdvP/12bPMFO1fi m/pmlZYu2+Nd8c0/AE/gs0PILIEj8oxiUUpDnpt0WUvQrrVhILxcy8kiyhbK0M X-Google-Smtp-Source: AGHT+IEQS04J5k9ys7VUrixvOqoIfqYL77w/GAjeUbl8nGYnPKg+ydshN38AfVjuXuWkE2AFDKoNcw== X-Received: by 2002:a05:600c:3489:b0:479:2a09:9262 with SMTP id 5b1f17b1804b1-47d1953dabamr1379125e9.9.1766081938576; Thu, 18 Dec 2025 10:18:58 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Peter Maydell , Jason Wang , "Michael S. Tsirkin" , Max Filippov , qemu-arm@nongnu.org, Manos Pitsidianakis , qemu-rust@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 6/6] rust/system: Stop exposing bogus DEVICE_NATIVE_ENDIAN symbol Date: Thu, 18 Dec 2025 19:18:11 +0100 Message-ID: <20251218181812.58363-7-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251218181812.58363-1-philmd@linaro.org> References: <20251218181812.58363-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=philmd@linaro.org; helo=mail-wm1-x342.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766082027012158500 We want to remove the bogus DEVICE_NATIVE_ENDIAN definition (by only having it explicit, either big or little one). Stop exposing it to rust devices to avoid it spreading further. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- rust/system/src/memory.rs | 6 ------ 1 file changed, 6 deletions(-) diff --git a/rust/system/src/memory.rs b/rust/system/src/memory.rs index 4b3316bf767..4e06c16a0b5 100644 --- a/rust/system/src/memory.rs +++ b/rust/system/src/memory.rs @@ -78,12 +78,6 @@ pub const fn little_endian(mut self) -> Self { self } =20 - #[must_use] - pub const fn native_endian(mut self) -> Self { - self.0.endianness =3D device_endian::DEVICE_NATIVE_ENDIAN; - self - } - #[must_use] pub const fn valid_sizes(mut self, min: u32, max: u32) -> Self { self.0.valid.min_access_size =3D min; --=20 2.52.0