From nobody Sun Feb 8 18:43:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1765955513; cv=none; d=zohomail.com; s=zohoarc; b=Rg1e4q7CeuIp6CiopscaFAniDMggYKaWquNU130JUSDqfK5fXcB49e1NqarbQoV+41p76eA+lGMuYP0RiuweNc3s1syNqCVg0QA9tr+mWIHdUK2waI5yUubvmrsoEIGNPMgP2y3j3lPSFiVYnctH4MxEpk3uOOz2ZT4hNZcIdKQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765955513; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=X+71vWb1XfXWzj4F2b7sjtBRXUgUZs3OF3KMjNiwC8w=; b=dNBKFpHSP6ipeQFqdikZUU3cQaeuy0rmuMh/htdjiNZ17O9LcSN+8IgAhbHbZM0Qm1PsoHP1kx+GWaDcGVtvassgnS4brPv05OPVOhPFnYw8o7icguVsNzwxnhH5vmgtkH+cni4dlFPriNNq3XZs3BSqq/7OIg4zmXe8y4/RcvU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765955511949124.69826195828193; Tue, 16 Dec 2025 23:11:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vVlga-0003mF-3O; Wed, 17 Dec 2025 02:11:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVlgX-0003ls-Pm; Wed, 17 Dec 2025 02:10:57 -0500 Received: from fhigh-b8-smtp.messagingengine.com ([202.12.124.159]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVlgV-0000J6-Of; Wed, 17 Dec 2025 02:10:57 -0500 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfhigh.stl.internal (Postfix) with ESMTP id 64E9E7A01C5; Wed, 17 Dec 2025 02:10:51 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Wed, 17 Dec 2025 02:10:51 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Dec 2025 02:10:48 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trainwit.ch; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm1; t=1765955451; x=1766041851; bh=X+ 71vWb1XfXWzj4F2b7sjtBRXUgUZs3OF3KMjNiwC8w=; b=3RxtWFyqvdyk63+MvO +i+kVaf2QfKIpIwUqH+cX4Qlo6kBQxnSlnb+YVwNcSXBdjDpZcBVSBIo8sTii2Ob WHXB6UVU860jFvBo1huDzvAEf289zVu4loVwloZXPEduqoYH1ulKutebvqr10IdT +YmpbSz1Sjds6mtzkZ2mEY2XBajJWO8vfhBVQRR/keDhJ2rSmtFZMg+edSSrvTFt FtH6WhAyiSoWzb0S4VV10YpeNqgjJbUpIqvZn4USaf7oPVpc5QuPhXLyEEqmucK4 PGuuAM+jboZ+ZCU/JrpRu6Q1tRNSqe6lEJ7qNV7pblTqMHTkqtQWUBTqIigZWvMG N59A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1765955451; x=1766041851; bh=X+71vWb1XfXWzj4F2b7sjtBRXUgU Zs3OF3KMjNiwC8w=; b=jjxwU+cpeV7JYBwhvJcshqv6gDvm+gN0aHogf7VnW6n8 gDySVTJDSB4tvRhsNY6OvMYBrQeTk1+3UUP3fmcd7ntG85za1WuquAYnVJJhSNG9 7eXxsSuh2/b26llCrJs4lEIm94orbWX7c8FpSYpsKJo1EE25YMqKfQXUy6D4O6GG POE/Mz5HzA626Q3NhEACCbsi+GVYotNiPjcGnNQwslxRxQ/CVq/2KqHy2YDejFOc xFP+B9Xo2MQpxLP4D/KtU5DQhln2zheqfNCDAuJtmfkOLsKin+M3X9UiIR1RAlIQ +jXK0L1VSuc0S91dbPK4QSaLXLDZdzn0CnP44o1HiQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdegudelfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhfffugggtgffkvfevofesthejredtredtjeenucfhrhhomhepjhhulhhirgcuoehm ihgunhhighhhthesthhrrghinhifihhtrdgthheqnecuggftrfgrthhtvghrnhepfffghe eujedvlefhffejgeegledtgefhteejtddtvdfhveelteeuhedvvedvhfehnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhiughnihhghhhtse htrhgrihhnfihithdrtghhpdhnsggprhgtphhtthhopeeipdhmohguvgepshhmthhpohhu thdprhgtphhtthhopehpsghonhiiihhnihesrhgvughhrghtrdgtohhmpdhrtghpthhtoh epqhgvmhhuqdguvghvvghlsehnohhnghhnuhdrohhrghdprhgtphhtthhopehmihgunhhi ghhhthesthhrrghinhifihhtrdgthhdprhgtphhtthhopehpvghtvghrrdhmrgihuggvlh hlsehlihhnrghrohdrohhrghdprhgtphhtthhopehqvghmuhdqrghrmhesnhhonhhgnhhu rdhorhhgpdhrtghpthhtohepmhgrrhgtrghnughrvgdrlhhurhgvrghusehrvgguhhgrth drtghomh X-ME-Proxy: Feedback-ID: ib36e48e7:Fastmail From: julia Date: Wed, 17 Dec 2025 18:10:41 +1100 Subject: [PATCH] hw/char/cmsdk-apb-uart.c: log guest_errors for r/w to disabled uart MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251217-cmsdk-uart-disabled-warning2-v1-1-847de48840bc@trainwit.ch> X-B4-Tracking: v=1; b=H4sIAHBXQmkC/x3MwQqDMAwA0F+RnA20wSHsV8RDbDMXNutIphuI/ 76y47u8A1xMxeHaHGCyq+taKmLbQLpzmQU1VwMFukSKPabF8wM3tjdmdZ6ekvHDVrTMhCH0xF2 XSDhCLV4mN/3++2E8zx/SUJK8bgAAAA== X-Change-ID: 20251217-cmsdk-uart-disabled-warning2-0072a44c2ea1 To: qemu-devel@nongnu.org Cc: Peter Maydell , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , qemu-arm@nongnu.org, julia X-Mailer: b4 0.14.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=202.12.124.159; envelope-from=midnight@trainwit.ch; helo=fhigh-b8-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @trainwit.ch) X-ZM-MESSAGEID: 1765955517731154100 I don't want to admit how many hours I spent trying to figure out why nothing was being printed (as the enable-ing code hadn't yet run, even thought it existed). Signed-off-by: julia Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/char/cmsdk-apb-uart.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/char/cmsdk-apb-uart.c b/hw/char/cmsdk-apb-uart.c index 32090f3516f6accad32bcd9fe9b10d572f17ed12..26931ab6c5d36f0ec5aac7acf36= 77855a6dd5f22 100644 --- a/hw/char/cmsdk-apb-uart.c +++ b/hw/char/cmsdk-apb-uart.c @@ -159,6 +159,10 @@ static uint64_t uart_read(void *opaque, hwaddr offset,= unsigned size) switch (offset) { case A_DATA: r =3D s->rxbuf; + if (!(s->ctrl & R_CTRL_RX_EN_MASK)) { + qemu_log_mask(LOG_GUEST_ERROR, + "CMSDK APB UART: receive data read with Rx disab= led\n"); + } s->state &=3D ~R_STATE_RXFULL_MASK; cmsdk_apb_uart_update(s); qemu_chr_fe_accept_input(&s->chr); @@ -248,6 +252,10 @@ static void uart_write(void *opaque, hwaddr offset, ui= nt64_t value, switch (offset) { case A_DATA: s->txbuf =3D value; + if (!(s->ctrl & R_CTRL_TX_EN_MASK)) { + qemu_log_mask(LOG_GUEST_ERROR, + "CMSDK APB UART: transmit data write with Tx dis= abled\n"); + } if (s->state & R_STATE_TXFULL_MASK) { /* Buffer already full -- note the overrun and let the * existing pending transmit callback handle the new char. --- base-commit: 7154e4df40468012fccb6687ecd2b288c56a4a2d change-id: 20251217-cmsdk-uart-disabled-warning2-0072a44c2ea1 Best regards, --=20 julia