From nobody Thu Dec 18 23:37:24 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1765898102; cv=none; d=zohomail.com; s=zohoarc; b=XgW8R4LYHrY4DcxaFF8dNRBoJq4uy52mnWeGlJGLWH3tshjn6ZAdKYJ6MWzEhNjp9UUC4z9ZiGHeyDgXcZGOAKY3V7SuGntUy2uA76PvTWQAxrBbMvzPqOWHf0sElQp8piZJPCOS/sAa7Bbr3cCMYEclunR5XTm2WzD8ZRCGaBw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765898102; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cva5ZBoYoUhj+fm1vLQwcvS1IsAUupqHklY5+6VEThg=; b=YGOreSnPlnOLa+NZMaOaEIqnZhwJ9g6z/pAfgAqQB034yra13dufMUoYQo8JT8qIdm2hYfjcFWppCkyilnuw+msPX+0O2UbGgE3g4LgAzKm0Gru5h72dxOIVuCsrIBIFQQ4psqB42CiJkuc5zkHSTpbuTTDhxCSOWEjzfq8x4cU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765898102865542.6037584019605; Tue, 16 Dec 2025 07:15:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vVWkk-0006nK-5i; Tue, 16 Dec 2025 10:14:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVWkh-0006m3-4x; Tue, 16 Dec 2025 10:14:15 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVWkf-0006sa-6Y; Tue, 16 Dec 2025 10:14:14 -0500 Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5BG9S1Eu015202; Tue, 16 Dec 2025 15:14:09 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0wjpyepq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Dec 2025 15:14:09 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 5BGFCogo001449; Tue, 16 Dec 2025 15:14:09 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0wjpyepk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Dec 2025 15:14:09 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5BGCS4U8026786; Tue, 16 Dec 2025 15:14:08 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4b1jfsd26h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Dec 2025 15:14:08 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5BGFE7Et18023070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Dec 2025 15:14:07 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 226DB58059; Tue, 16 Dec 2025 15:14:07 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 481FA58053; Tue, 16 Dec 2025 15:14:06 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 16 Dec 2025 15:14:06 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=cva5ZBoYoUhj+fm1v LQwcvS1IsAUupqHklY5+6VEThg=; b=ROlgWvyRdffaN8mJI/+8vZwazK5HUMdfM lGXt9NRmdOE0Zfn4YU8FEU3cEW2EKZivKU07V9aDBgbeindK94YzeNqWQOjnsYhx nmIkZXIHieVKbUasZxTwq39p0eNSeHxLr/JnK6/S3tzFwNVGZKFxKAZYX7zpCFjh Tefla9Y4qP6wEBBRlu5VOQ1zAWkhu62B21LNoGz+aW9+DjMDO1ccaKZCA+0Wemeu w5/SLgTMBsCiOdW5H19NHuETPX7c5IJAlZDkCh6QvPg1YkUmO8HEpEtddEPgC+he ewuT7Mungoov/icXBtQ0x6clkAdCteV8FttY92PKc4i/VlFLb1hbA== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, kowal@linux.ibm.com, chalapathi.v@linux.ibm.com, calebs@linux.ibm.com, angeloj@linux.ibm.com Subject: [PATCH v3 1/7] hw/ppc: Add VMSTATE information for LPC model Date: Tue, 16 Dec 2025 09:13:53 -0600 Message-ID: <20251216151359.418708-2-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251216151359.418708-1-calebs@linux.ibm.com> References: <20251216151359.418708-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEzMDAwMSBTYWx0ZWRfX4IYaDUtRoAYI vbcnp6azCMjggZcsUcbTbR0yn++Wko3HXXg6MFPQnFPcMUoAfkIwMkxuOCe01URnpzCGXCoKP/T XlwzJfz6y1Spo8qauf20lY4JAdfdNW5kBVNMe2eVG8exHl5e1+11UlVv0D5UM5vKxszP3P/u5/A 2LDz4Z4zBOhbDRU7x3wUDA3sJgdU/XWTG0uUuWweg0iXX1Qqx1clNMoGrgXZSB+amGEBIRYJJKV AiO8FkZUzf3VIT1Sb7d7djxhwGji9ke0ngCOgKmRbrKppuX4AoJ8eVQxr4+vHCxr6FtOxupYYjr 9HxDIlIIN+1XF8arM2ORisi/wclprj2vz6rTQzAAAzHLEJeK5v6cPVZa8LKBS6KiQGB7ZkKQ8J6 d+phfjqC4n/joDy2hdgedExKoKVZJQ== X-Proofpoint-GUID: 1jozaf5xHLVq3yb_ly-8vHwgPXraJjxR X-Proofpoint-ORIG-GUID: r6xhfa6QJGDjRn4EYlA-3hBzGpCOu5BA X-Authority-Analysis: v=2.4 cv=Kq5AGGWN c=1 sm=1 tr=0 ts=69417741 cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=GMd5MdSob7TKo89JhDQA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-16_02,2025-12-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 impostorscore=0 clxscore=1015 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510240000 definitions=main-2512130001 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=calebs@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1765898103609158500 Content-Type: text/plain; charset="utf-8" The PNV LPC model needs snapshot/migration support. Added a VMSTATE descriptor to save model data and an associated post_load() method. Snapshot support added for Power8, Power9, and Power10. Signed-off-by: Michael Kowal Signed-off-by: Caleb Schlossin Reviewed-by: Michael Kowal --- hw/ppc/pnv_lpc.c | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/hw/ppc/pnv_lpc.c b/hw/ppc/pnv_lpc.c index f6beba0917..e52a062181 100644 --- a/hw/ppc/pnv_lpc.c +++ b/hw/ppc/pnv_lpc.c @@ -30,6 +30,7 @@ #include "hw/ppc/pnv_lpc.h" #include "hw/ppc/pnv_xscom.h" #include "hw/ppc/fdt.h" +#include "migration/vmstate.h" =20 #include =20 @@ -696,6 +697,43 @@ static const MemoryRegionOps opb_master_ops =3D { }, }; =20 +static int vmstate_pnv_lpc_post_load(void *opaque, int version_id) +{ + PnvLpcController *lpc =3D PNV_LPC(opaque); + + memory_region_set_alias_offset(&lpc->opb_isa_fw, + lpc->lpc_hc_fw_seg_idsel * LPC_FW_OPB_S= IZE); + pnv_lpc_eval_serirq_routes(lpc); + + pnv_lpc_eval_irqs(lpc); + return 0; +} + +static const VMStateDescription vmstate_pnv_lpc =3D { + .name =3D TYPE_PNV_LPC, + .version_id =3D 1, + .minimum_version_id =3D 1, + .post_load =3D vmstate_pnv_lpc_post_load, + .fields =3D (const VMStateField[]) { + VMSTATE_UINT64(eccb_stat_reg, PnvLpcController), + VMSTATE_UINT32(eccb_data_reg, PnvLpcController), + VMSTATE_UINT32(opb_irq_route0, PnvLpcController), + VMSTATE_UINT32(opb_irq_route1, PnvLpcController), + VMSTATE_UINT32(opb_irq_stat, PnvLpcController), + VMSTATE_UINT32(opb_irq_mask, PnvLpcController), + VMSTATE_UINT32(opb_irq_pol, PnvLpcController), + VMSTATE_UINT32(opb_irq_input, PnvLpcController), + VMSTATE_UINT32(lpc_hc_irq_inputs, PnvLpcController), + VMSTATE_UINT32(lpc_hc_fw_seg_idsel, PnvLpcController), + VMSTATE_UINT32(lpc_hc_irqser_ctrl, PnvLpcController), + VMSTATE_UINT32(lpc_hc_irqmask, PnvLpcController), + VMSTATE_UINT32(lpc_hc_irqstat, PnvLpcController), + VMSTATE_UINT32(lpc_hc_error_addr, PnvLpcController), + VMSTATE_UINT32(lpc_hc_fw_rd_acc_size, PnvLpcController), + VMSTATE_END_OF_LIST() + } +}; + static void pnv_lpc_power8_realize(DeviceState *dev, Error **errp) { PnvLpcController *lpc =3D PNV_LPC(dev); @@ -721,6 +759,7 @@ static void pnv_lpc_power8_class_init(ObjectClass *klas= s, const void *data) PnvLpcClass *plc =3D PNV_LPC_CLASS(klass); =20 dc->desc =3D "PowerNV LPC Controller POWER8"; + dc->vmsd =3D &vmstate_pnv_lpc; =20 xdc->dt_xscom =3D pnv_lpc_dt_xscom; =20 @@ -766,6 +805,7 @@ static void pnv_lpc_power9_class_init(ObjectClass *klas= s, const void *data) PnvLpcClass *plc =3D PNV_LPC_CLASS(klass); =20 dc->desc =3D "PowerNV LPC Controller POWER9"; + dc->vmsd =3D &vmstate_pnv_lpc; =20 device_class_set_parent_realize(dc, pnv_lpc_power9_realize, &plc->parent_realize); @@ -782,6 +822,7 @@ static void pnv_lpc_power10_class_init(ObjectClass *kla= ss, const void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->desc =3D "PowerNV LPC Controller POWER10"; + dc->vmsd =3D &vmstate_pnv_lpc; } =20 static const TypeInfo pnv_lpc_power10_info =3D { --=20 2.47.3