From nobody Fri Dec 19 07:17:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1765895397; cv=none; d=zohomail.com; s=zohoarc; b=Z1um5+Z7wylK+ZmKs7TfMJJ5ESKD28OP3SieBknG23qj6Db6kM5B883bjScGPsUzlaIc4OQPNpMezvwaTurSoBgI0tUIC50r3QN0kNEWiVV7u/ic6mzZa6KTaekVAi75c2yIkNKcjbgLH9Ln9YZNoKiWy6s5/oeEVpgFnx8bd8I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765895397; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=x7uWAdbHVg7wYY6vQfeMr3T/aQ7yLR/z8gVU97jqv3M=; b=g+nW3x2oRQdPIrbakE2f99ZtswWYDptIDvfMo6Ikbv2OLjXrGNGpVD+KT0vmVkaVWkBLrCQryyTerWS54MaWuYsHlrUKOcgSxuI6FnYFr6feDrewrLlDTc5c46TWWe9XjX1nlpNnJ9iiRaz1yt+lYRpYwqowQiOZYnOClCSzy2w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765895397483655.3883371301291; Tue, 16 Dec 2025 06:29:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vVW3R-0005Xq-S1; Tue, 16 Dec 2025 09:29:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVW39-0005WE-BD for qemu-devel@nongnu.org; Tue, 16 Dec 2025 09:29:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVW32-0002x4-UZ for qemu-devel@nongnu.org; Tue, 16 Dec 2025 09:29:13 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-MZV2r5hjP7K2Tw0n-Co14A-1; Tue, 16 Dec 2025 09:28:55 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 610641956063; Tue, 16 Dec 2025 14:28:54 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.62]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 91FA819560A7; Tue, 16 Dec 2025 14:28:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765895339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x7uWAdbHVg7wYY6vQfeMr3T/aQ7yLR/z8gVU97jqv3M=; b=IPOnYUlFGBZrAL28MC4CGrViChos3mUMpkPexfWQoF+fYOd3iQM9vgt1qUUqTISibfADyg 1hx0a69Z1xeJpiWubHYlcYFppgT4da50qNHRHYqmOwckfi8tONPx6d6XKiVHVoqxsGsKzj njhgl0/6vO5p3LA9E+bKOOclT01Y1Dw= X-MC-Unique: MZV2r5hjP7K2Tw0n-Co14A-1 X-Mimecast-MFC-AGG-ID: MZV2r5hjP7K2Tw0n-Co14A_1765895334 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 3/4] monitor: Fix const qualifier build errors with recent glibc Date: Tue, 16 Dec 2025 15:28:42 +0100 Message-ID: <20251216142843.519084-4-clg@redhat.com> In-Reply-To: <20251216142843.519084-1-clg@redhat.com> References: <20251216142843.519084-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1765895398964154100 A recent change in glibc 2.42.9000 [1] changes the return type of strchr() and other string functions to be 'const char *' when the input is a 'const char *'. This breaks the build in : ../monitor/hmp.c:589:7: error: assignment discards =E2=80=98const=E2=80=99 = qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 589 | p =3D strchr(type, ':'); | ^ Fix this by changing the type of the variables that store the result of these functions to 'const char *'. [1] https://sourceware.org/git/?p=3Dglibc.git;a=3Dcommit;h=3Dcd748a63ab1a7a= e846175c532a3daab341c62690 Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Link: https://lore.kernel.org/qemu-devel/20251215101937.281722-4-clg@redhat= .com Signed-off-by: C=C3=A9dric Le Goater --- monitor/hmp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/monitor/hmp.c b/monitor/hmp.c index 34e2b8f748b425e1e4446e8e64aa25b1433d1162..a3ee02e52cda530508b170c4c5e= 8357b304f7df6 100644 --- a/monitor/hmp.c +++ b/monitor/hmp.c @@ -577,10 +577,11 @@ static const char *get_command_name(const char *cmdli= ne, * Read key of 'type' into 'key' and return the current * 'type' pointer. */ -static char *key_get_info(const char *type, char **key) +static const char *key_get_info(const char *type, char **key) { size_t len; - char *p, *str; + const char *p; + char *str; =20 if (*type =3D=3D ',') { type++; --=20 2.52.0