From nobody Thu Dec 18 23:21:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1765895380; cv=none; d=zohomail.com; s=zohoarc; b=hnOK75D6pqGFa8PByYe1ZQMeK8N8XIz+jNknj98TAPSgkvswveCDiNLQeHcPnIlROhnro7AQrFRMp/4j2O4756mSmjSIKDIA8vUsL/pJJwsj4mZSGEoaxn2NIMtTzqJHzljyRDGnScFTuSA7Ht14TnwUDq/bTDqbWqqmApxYWJo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765895380; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6LpOpgbxfx+w1pTyw2YSS9mQcixGb8olJKivMdY6hWk=; b=YMFAMrQv5SFdk37tMJCD3X28YSC2ioIxHAft1uVtmS5eq/WpqFdMjkkrLbUKPmzIiKZoC+IuQ+qRwp+Y2K+id0srpsCVKAbuI/bO1NMSGNH+WcgHRLSjlRyJRLzDz6f2PrH5fRTrDmOJn49QWYVje1GZ19cDIlRGwx3qASr4a98= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765895380535901.0851852924194; Tue, 16 Dec 2025 06:29:40 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vVW3D-0005WH-0o; Tue, 16 Dec 2025 09:29:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVW36-0005Vq-KU for qemu-devel@nongnu.org; Tue, 16 Dec 2025 09:29:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVW2z-0002wY-P7 for qemu-devel@nongnu.org; Tue, 16 Dec 2025 09:29:10 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-201-hBAo-KvAOPqZV6-4_uZHuw-1; Tue, 16 Dec 2025 09:28:50 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8C9971800358; Tue, 16 Dec 2025 14:28:49 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.62]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B3DFD1953960; Tue, 16 Dec 2025 14:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765895336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6LpOpgbxfx+w1pTyw2YSS9mQcixGb8olJKivMdY6hWk=; b=Op8m6ooErE45ap2+jq9VfRU9yIWFrHDnz6ZM07ZB9XBFPbekc3K9DZg8SSQWEph8ioQv/q 9Ub44jV/PfD2nJC7XdYZY8A8St8e9uAUJxrJwKifNqWzgiThBX27GjnayBwiEhC96Zfl/6 uSPhLP9f04ydm+U3x5fd6Q5hsMFNv54= X-MC-Unique: hBAo-KvAOPqZV6-4_uZHuw-1 X-Mimecast-MFC-AGG-ID: hBAo-KvAOPqZV6-4_uZHuw_1765895329 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell Subject: [PULL 1/4] i386: Fix const qualifier build errors with recent glibc Date: Tue, 16 Dec 2025 15:28:40 +0100 Message-ID: <20251216142843.519084-2-clg@redhat.com> In-Reply-To: <20251216142843.519084-1-clg@redhat.com> References: <20251216142843.519084-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1765895382598154100 A recent change in glibc 2.42.9000 [1] changes the return type of strstr() and other string functions to be 'const char *' when the input is a 'const char *'. This breaks the build in : ../hw/i386/x86-common.c:827:11: error: assignment discards =E2=80=98const= =E2=80=99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifier= s] 827 | vmode =3D strstr(kernel_cmdline, "vga=3D"); | ^ Fix this by changing the type of the variables that store the result of these functions to 'const char *'. [1] https://sourceware.org/git/?p=3Dglibc.git;a=3Dcommit;h=3Dcd748a63ab1a7a= e846175c532a3daab341c62690 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Link: https://lore.kernel.org/qemu-devel/20251215101937.281722-2-clg@redhat= .com Signed-off-by: C=C3=A9dric Le Goater --- hw/i386/x86-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/x86-common.c b/hw/i386/x86-common.c index c844749900a30c9c9c284c529e93c84c9457b128..f77e2e63046ff56d079363e411a= 9ee0eca365291 100644 --- a/hw/i386/x86-common.c +++ b/hw/i386/x86-common.c @@ -654,7 +654,7 @@ void x86_load_linux(X86MachineState *x86ms, uint8_t header[8192], *setup, *kernel; hwaddr real_addr, prot_addr, cmdline_addr, initrd_addr =3D 0; FILE *f; - char *vmode; + const char *vmode; MachineState *machine =3D MACHINE(x86ms); struct setup_data *setup_data; const char *kernel_filename =3D machine->kernel_filename; --=20 2.52.0 From nobody Thu Dec 18 23:21:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1765895399; cv=none; d=zohomail.com; s=zohoarc; b=iaq7wVwMPSnU8dTcEkB9HGYfgDaFrWmjDMkHsqpgJGRDlW5RfJi1Hw2ytozcoTcOnJ4TsrsuToerX3cayW+QngWQ2u9Vzvrbm3d3K17z2f4dZJy1lKe19r+mVqHvZ9TCrcEdk+3DH6fqJtTaQoKbsTL+L3Sti/kdQgHE360fuO4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765895399; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Hhvtml6jjvFmeQn1jiKdFKJeyj25+hrS8UKpojuJCQY=; b=MRxn+9C9S+VdMVyw/gu4lGuKPSPcBSHmO/egvtxkscExkDst+UgVyZagaSZldU1GLAn6c5oOqr6Y7c2r9tl3Y2IUCRyXPX2tToV8CHgT2gOcczmdUAVdedGGE5h5B2blre50f54vOV2Y04Ah2YKedMFa771iupYwdyq6IndlHn4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765895399542814.9112541731024; Tue, 16 Dec 2025 06:29:59 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vVW3h-0005e0-BZ; Tue, 16 Dec 2025 09:29:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVW39-0005WF-BR for qemu-devel@nongnu.org; Tue, 16 Dec 2025 09:29:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVW32-0002wi-Tj for qemu-devel@nongnu.org; Tue, 16 Dec 2025 09:29:12 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-Gy9hK1YiN5OeScmVxhbHNg-1; Tue, 16 Dec 2025 09:28:53 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2EA1E18011DF; Tue, 16 Dec 2025 14:28:52 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.62]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0C62019560A7; Tue, 16 Dec 2025 14:28:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765895337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hhvtml6jjvFmeQn1jiKdFKJeyj25+hrS8UKpojuJCQY=; b=gmgpdB2kF51/Ks38dODxJEjs0ylO9Zjin3t7Vl2fuzbFz7H4CJaWoyr6OQS5pIakDQl25y ACIxI4O3TmF4tiBkEPWbiUy3ilCIAgoulyNQc/XlGeVAdMqeAntHtjEnURran0pvVBhbpA j7jUkKUdGMMpRvjvudHVLYyvQ1jRsfo= X-MC-Unique: Gy9hK1YiN5OeScmVxhbHNg-1 X-Mimecast-MFC-AGG-ID: Gy9hK1YiN5OeScmVxhbHNg_1765895332 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Yodel Eldar , Thomas Huth Subject: [PULL 2/4] tests/vhost-user-bridge.c: Fix const qualifier build errors with recent glibc Date: Tue, 16 Dec 2025 15:28:41 +0100 Message-ID: <20251216142843.519084-3-clg@redhat.com> In-Reply-To: <20251216142843.519084-1-clg@redhat.com> References: <20251216142843.519084-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1765895400983154100 A recent change in glibc 2.42.9000 [1] changes the return type of strstr() and other string functions to be 'const char *' when the input is a 'const char *'. This breaks the build in : ../tests/vhost-user-bridge.c: In function =E2=80=98vubr_parse_host_port=E2= =80=99: ../tests/vhost-user-bridge.c:749:15: error: initialization discards =E2=80= =98const=E2=80=99 qualifier from pointer target type [-Werror=3Ddiscarded-q= ualifiers] 749 | char *p =3D strchr(buf, ':'); | ^~~~~~ Fix this by using the glib g_strsplit() routine instead of strdup(). [1] https://sourceware.org/git/?p=3Dglibc.git;a=3Dcommit;h=3Dcd748a63ab1a7a= e846175c532a3daab341c62690 Suggested-by: Peter Maydell Acked-by: Yodel Eldar Tested-by: Yodel Eldar Reviewed-by: Thomas Huth Link: https://lore.kernel.org/qemu-devel/20251215101937.281722-3-clg@redhat= .com Signed-off-by: C=C3=A9dric Le Goater --- tests/vhost-user-bridge.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index a5c711b1de8e9c164dd1614f4329b8e3c05d0402..ce4c3426d3938a0b54195f3e95b= b1f1c3c4ae823 100644 --- a/tests/vhost-user-bridge.c +++ b/tests/vhost-user-bridge.c @@ -746,14 +746,12 @@ vubr_run(VubrDev *dev) static int vubr_parse_host_port(const char **host, const char **port, const char *buf) { - char *p =3D strchr(buf, ':'); - - if (!p) { + g_auto(GStrv) tokens =3D g_strsplit(buf, ":", 2); + if (!tokens[0] || !tokens[1]) { return -1; } - *p =3D '\0'; - *host =3D strdup(buf); - *port =3D strdup(p + 1); + *host =3D g_steal_pointer(&tokens[0]); + *port =3D g_steal_pointer(&tokens[1]); return 0; } =20 --=20 2.52.0 From nobody Thu Dec 18 23:21:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1765895397; cv=none; d=zohomail.com; s=zohoarc; b=Z1um5+Z7wylK+ZmKs7TfMJJ5ESKD28OP3SieBknG23qj6Db6kM5B883bjScGPsUzlaIc4OQPNpMezvwaTurSoBgI0tUIC50r3QN0kNEWiVV7u/ic6mzZa6KTaekVAi75c2yIkNKcjbgLH9Ln9YZNoKiWy6s5/oeEVpgFnx8bd8I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765895397; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=x7uWAdbHVg7wYY6vQfeMr3T/aQ7yLR/z8gVU97jqv3M=; b=g+nW3x2oRQdPIrbakE2f99ZtswWYDptIDvfMo6Ikbv2OLjXrGNGpVD+KT0vmVkaVWkBLrCQryyTerWS54MaWuYsHlrUKOcgSxuI6FnYFr6feDrewrLlDTc5c46TWWe9XjX1nlpNnJ9iiRaz1yt+lYRpYwqowQiOZYnOClCSzy2w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765895397483655.3883371301291; Tue, 16 Dec 2025 06:29:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vVW3R-0005Xq-S1; Tue, 16 Dec 2025 09:29:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVW39-0005WE-BD for qemu-devel@nongnu.org; Tue, 16 Dec 2025 09:29:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVW32-0002x4-UZ for qemu-devel@nongnu.org; Tue, 16 Dec 2025 09:29:13 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-MZV2r5hjP7K2Tw0n-Co14A-1; Tue, 16 Dec 2025 09:28:55 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 610641956063; Tue, 16 Dec 2025 14:28:54 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.62]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 91FA819560A7; Tue, 16 Dec 2025 14:28:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765895339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x7uWAdbHVg7wYY6vQfeMr3T/aQ7yLR/z8gVU97jqv3M=; b=IPOnYUlFGBZrAL28MC4CGrViChos3mUMpkPexfWQoF+fYOd3iQM9vgt1qUUqTISibfADyg 1hx0a69Z1xeJpiWubHYlcYFppgT4da50qNHRHYqmOwckfi8tONPx6d6XKiVHVoqxsGsKzj njhgl0/6vO5p3LA9E+bKOOclT01Y1Dw= X-MC-Unique: MZV2r5hjP7K2Tw0n-Co14A-1 X-Mimecast-MFC-AGG-ID: MZV2r5hjP7K2Tw0n-Co14A_1765895334 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 3/4] monitor: Fix const qualifier build errors with recent glibc Date: Tue, 16 Dec 2025 15:28:42 +0100 Message-ID: <20251216142843.519084-4-clg@redhat.com> In-Reply-To: <20251216142843.519084-1-clg@redhat.com> References: <20251216142843.519084-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1765895398964154100 A recent change in glibc 2.42.9000 [1] changes the return type of strchr() and other string functions to be 'const char *' when the input is a 'const char *'. This breaks the build in : ../monitor/hmp.c:589:7: error: assignment discards =E2=80=98const=E2=80=99 = qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 589 | p =3D strchr(type, ':'); | ^ Fix this by changing the type of the variables that store the result of these functions to 'const char *'. [1] https://sourceware.org/git/?p=3Dglibc.git;a=3Dcommit;h=3Dcd748a63ab1a7a= e846175c532a3daab341c62690 Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Link: https://lore.kernel.org/qemu-devel/20251215101937.281722-4-clg@redhat= .com Signed-off-by: C=C3=A9dric Le Goater --- monitor/hmp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/monitor/hmp.c b/monitor/hmp.c index 34e2b8f748b425e1e4446e8e64aa25b1433d1162..a3ee02e52cda530508b170c4c5e= 8357b304f7df6 100644 --- a/monitor/hmp.c +++ b/monitor/hmp.c @@ -577,10 +577,11 @@ static const char *get_command_name(const char *cmdli= ne, * Read key of 'type' into 'key' and return the current * 'type' pointer. */ -static char *key_get_info(const char *type, char **key) +static const char *key_get_info(const char *type, char **key) { size_t len; - char *p, *str; + const char *p; + char *str; =20 if (*type =3D=3D ',') { type++; --=20 2.52.0 From nobody Thu Dec 18 23:21:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1765895397; cv=none; d=zohomail.com; s=zohoarc; b=Ossg0IjnD3QTzYTwWd8GmxdWxKV+4hTELHYOqHrDAs67ucv/p9W9yfbUYBjq/J0cbWQuWglPyIXVUTfCaRQHUvumuANnF5EgkaNrK5+kEKI24JGwqpG1/TtQI74oRpe0MJs8rE7o6Z4bg+PoHz7xKquoqYupU4UyD+kRANHwBAo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765895397; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=R0mtoUp474yd9a0lUZsHwjTXfN0vz21kck43astX+VY=; b=TL5sIi9AfkYjWo1xpaF2qzA/wPfXtF01BPmp8UqF27zM3TAv4/+XTGRSDVbkCKjKeVTIAt7JmiItJxPihQIUrpUCSrzJ6ZGVGI8S9Po1Zdc8dVa3NbuM00MUXZMRoVAl6SjrxEFXZGYOCPeUofOac2cM5qrN4xde1xfwU6o4tTE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765895397742990.8186160088168; Tue, 16 Dec 2025 06:29:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vVW3N-0005X8-Vs; Tue, 16 Dec 2025 09:29:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVW36-0005Vr-LW for qemu-devel@nongnu.org; Tue, 16 Dec 2025 09:29:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVW32-0002wt-TB for qemu-devel@nongnu.org; Tue, 16 Dec 2025 09:29:10 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-hA2wDdKnOpeIoXAGn0gy7w-1; Tue, 16 Dec 2025 09:28:57 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 917211800610; Tue, 16 Dec 2025 14:28:56 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.62]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D2E9319560A7; Tue, 16 Dec 2025 14:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765895339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R0mtoUp474yd9a0lUZsHwjTXfN0vz21kck43astX+VY=; b=f904EU48ljyQ7HLAkZYJqr8d06duKfTnIfRU0AGUW26d/FRD0BK9encEVsSbothe7K+M9W OV0+qOwKkFxcIyVD3/d+rXzoxxLO0lu0Da+ucfVN+MieLKGVAtpo2Y7klzAI/O8TcZIfw7 AIe/MePqNGzh0Ktv82SusmhIxOZwwjE= X-MC-Unique: hA2wDdKnOpeIoXAGn0gy7w-1 X-Mimecast-MFC-AGG-ID: hA2wDdKnOpeIoXAGn0gy7w_1765895336 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 4/4] gdbstub: Fix const qualifier build errors with recent glibc Date: Tue, 16 Dec 2025 15:28:43 +0100 Message-ID: <20251216142843.519084-5-clg@redhat.com> In-Reply-To: <20251216142843.519084-1-clg@redhat.com> References: <20251216142843.519084-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1765895399724158500 A recent change in glibc 2.42.9000 [1] changes the return type of strstr() and other string functions to be 'const char *' when the input is a 'const char *'. This breaks the build in : ../gdbstub/user.c:322:21: error: assignment discards =E2=80=98const=E2=80= =99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifiers] 322 | pid_placeholder =3D strstr(path, "%d"); | ^ Fix this by changing the type of the variables that store the result of these functions to 'const char *'. [1] https://sourceware.org/git/?p=3Dglibc.git;a=3Dcommit;h=3Dcd748a63ab1a7a= e846175c532a3daab341c62690 Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Link: https://lore.kernel.org/qemu-devel/20251215101937.281722-5-clg@redhat= .com Signed-off-by: C=C3=A9dric Le Goater --- gdbstub/user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub/user.c b/gdbstub/user.c index 2e14ded3f01053d4d4a36426c509ce7a6b81cb67..e233c598165ca1b10a5f2a89c87= 136df9af636ca 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -317,7 +317,7 @@ static bool gdb_accept_socket(int gdb_fd) static int gdbserver_open_socket(const char *path, Error **errp) { g_autoptr(GString) buf =3D g_string_new(""); - char *pid_placeholder; + const char *pid_placeholder; =20 pid_placeholder =3D strstr(path, "%d"); if (pid_placeholder !=3D NULL) { --=20 2.52.0