From nobody Tue Dec 16 16:37:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1765826532; cv=none; d=zohomail.com; s=zohoarc; b=fbYFTb7dW0+m6/U+QNCVzDKammJU17jsr1x+2P9Pq6jkNS34wlccJW7X4jSFzIDPSrVd3a8OYmMAFy+0RZV6Ieet92fiKwK4TKmzxzpokQI8b6yQl5kpQ1GZli32GoYa61kodKGmlJjTOMG47kCRUKi05Ip0yQwxxIgZJYvgzyA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765826532; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cva5ZBoYoUhj+fm1vLQwcvS1IsAUupqHklY5+6VEThg=; b=Uq9I9E0wFOQS5OYOoBktbC0qmsZgIStEIFuiO4pFDi9YnLxRqTnhZ7RSVuFDdpzaQRZ3Og6v0Pus4j/9oAkHYICBAcm+t1DPFvxeQjzCwFvGmo9aGzCPmmdvt4pDxoTn0I0ub5HxyeWc+t9SGjT0Kmqf4Q9Q1W7GrpOt1nCe4Bo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765826532700707.1379418037689; Mon, 15 Dec 2025 11:22:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vVCDa-0002SZ-OD; Mon, 15 Dec 2025 12:18:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVCDQ-0002D2-JG; Mon, 15 Dec 2025 12:18:39 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVCDM-0002gp-K8; Mon, 15 Dec 2025 12:18:32 -0500 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5BFCFEm5030921; Mon, 15 Dec 2025 17:18:24 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0xjktn21-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:23 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 5BFHINnP006935; Mon, 15 Dec 2025 17:18:23 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0xjktn1u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:23 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5BFExYE2012800; Mon, 15 Dec 2025 17:18:22 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4b1juxytvt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:22 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5BFHILd116908830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Dec 2025 17:18:21 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6C50D58060; Mon, 15 Dec 2025 17:18:21 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E9C6A5803F; Mon, 15 Dec 2025 17:18:20 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 15 Dec 2025 17:18:20 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=cva5ZBoYoUhj+fm1v LQwcvS1IsAUupqHklY5+6VEThg=; b=Si2/H2rrWE1YLOadjq4X698a8hirSB6vF PST+dLF1YEhEgowrHF0fieduChL1f0fhaD6MbmMY5SBtD0X491SLqegtLjWrlMWH y/zoSrVRpmzmch6lLV5GNz9X3BVGuGazYjwK13hs/CZW/40J6DTIWfB+zMCBQjzl rkk6hZfOrnVvxJNyBCfFoll1OAc41+IU6dyapqmgUNJjEdwWAAU6GjSyE4VtXQwx IXO5knbg0hdC3EePTcBlyNEvMJFuBOa/KbpoOYKieP//X2Q23u7hGq56Uwzs8IiK 73eQF/ZQOZeuSPrM1WHPcz6Fji7KOiApxRYdBeClNfBRL1mgnNtqw== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, kowal@linux.ibm.com, chalapathi.v@linux.ibm.com, calebs@linux.ibm.com, angeloj@linux.ibm.com Subject: [PATCH v2 1/7] hw/ppc: Add VMSTATE information for LPC model Date: Mon, 15 Dec 2025 11:18:07 -0600 Message-ID: <20251215171813.1670241-2-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251215171813.1670241-1-calebs@linux.ibm.com> References: <20251215171813.1670241-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: n46iAahUqLRPZ0wcFz8zZVciBDve5Lcy X-Authority-Analysis: v=2.4 cv=CLgnnBrD c=1 sm=1 tr=0 ts=694042df cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=GMd5MdSob7TKo89JhDQA:9 X-Proofpoint-GUID: ZiuSycC1SZUN6l27NagRsNSLx0SC5QdI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEzMDAwOSBTYWx0ZWRfX12St5Oo4k3N8 tmpLttKJRmwiqdHGywpYqQjDlfsK2R8h4gq2IgKD1Nsr+YIVnXE4dqtsJbFG53v/2SYkLAvJU7K X5eNM+znsSCAkPPgE4AbyxjdNJeQVVgtvIFvJlvwmcyOAnu6689/Wyq7tJCSO3saUsJT40MChc6 hurRpuT4uh95YCdXvq93BcpB9PGdTGMV2IKOZZ1FjJcj7wtsnGAZ6ZpINEKPB8YvWEz7m4m8gxu P9etIzsK4YvCQsb4D0+XAIrv4g6jOiwh6+2hu4/1Oa3T5FLb27n5ZpYMjhWSYyTtfiTB3+dv1JO 4RI7P0ItfPgynd5uzphRGo2kgOW1i5bk8vWDxeULWuTE50Lg9uh7ultE5bEYaRIrXIoo84gsiCe gF21bTBZdXQui223JOhi8JmKUnAmcw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-15_04,2025-12-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510240000 definitions=main-2512130009 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=calebs@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1765826535284158500 Content-Type: text/plain; charset="utf-8" The PNV LPC model needs snapshot/migration support. Added a VMSTATE descriptor to save model data and an associated post_load() method. Snapshot support added for Power8, Power9, and Power10. Signed-off-by: Michael Kowal Signed-off-by: Caleb Schlossin Reviewed-by: Aditya Gupta --- hw/ppc/pnv_lpc.c | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/hw/ppc/pnv_lpc.c b/hw/ppc/pnv_lpc.c index f6beba0917..e52a062181 100644 --- a/hw/ppc/pnv_lpc.c +++ b/hw/ppc/pnv_lpc.c @@ -30,6 +30,7 @@ #include "hw/ppc/pnv_lpc.h" #include "hw/ppc/pnv_xscom.h" #include "hw/ppc/fdt.h" +#include "migration/vmstate.h" =20 #include =20 @@ -696,6 +697,43 @@ static const MemoryRegionOps opb_master_ops =3D { }, }; =20 +static int vmstate_pnv_lpc_post_load(void *opaque, int version_id) +{ + PnvLpcController *lpc =3D PNV_LPC(opaque); + + memory_region_set_alias_offset(&lpc->opb_isa_fw, + lpc->lpc_hc_fw_seg_idsel * LPC_FW_OPB_S= IZE); + pnv_lpc_eval_serirq_routes(lpc); + + pnv_lpc_eval_irqs(lpc); + return 0; +} + +static const VMStateDescription vmstate_pnv_lpc =3D { + .name =3D TYPE_PNV_LPC, + .version_id =3D 1, + .minimum_version_id =3D 1, + .post_load =3D vmstate_pnv_lpc_post_load, + .fields =3D (const VMStateField[]) { + VMSTATE_UINT64(eccb_stat_reg, PnvLpcController), + VMSTATE_UINT32(eccb_data_reg, PnvLpcController), + VMSTATE_UINT32(opb_irq_route0, PnvLpcController), + VMSTATE_UINT32(opb_irq_route1, PnvLpcController), + VMSTATE_UINT32(opb_irq_stat, PnvLpcController), + VMSTATE_UINT32(opb_irq_mask, PnvLpcController), + VMSTATE_UINT32(opb_irq_pol, PnvLpcController), + VMSTATE_UINT32(opb_irq_input, PnvLpcController), + VMSTATE_UINT32(lpc_hc_irq_inputs, PnvLpcController), + VMSTATE_UINT32(lpc_hc_fw_seg_idsel, PnvLpcController), + VMSTATE_UINT32(lpc_hc_irqser_ctrl, PnvLpcController), + VMSTATE_UINT32(lpc_hc_irqmask, PnvLpcController), + VMSTATE_UINT32(lpc_hc_irqstat, PnvLpcController), + VMSTATE_UINT32(lpc_hc_error_addr, PnvLpcController), + VMSTATE_UINT32(lpc_hc_fw_rd_acc_size, PnvLpcController), + VMSTATE_END_OF_LIST() + } +}; + static void pnv_lpc_power8_realize(DeviceState *dev, Error **errp) { PnvLpcController *lpc =3D PNV_LPC(dev); @@ -721,6 +759,7 @@ static void pnv_lpc_power8_class_init(ObjectClass *klas= s, const void *data) PnvLpcClass *plc =3D PNV_LPC_CLASS(klass); =20 dc->desc =3D "PowerNV LPC Controller POWER8"; + dc->vmsd =3D &vmstate_pnv_lpc; =20 xdc->dt_xscom =3D pnv_lpc_dt_xscom; =20 @@ -766,6 +805,7 @@ static void pnv_lpc_power9_class_init(ObjectClass *klas= s, const void *data) PnvLpcClass *plc =3D PNV_LPC_CLASS(klass); =20 dc->desc =3D "PowerNV LPC Controller POWER9"; + dc->vmsd =3D &vmstate_pnv_lpc; =20 device_class_set_parent_realize(dc, pnv_lpc_power9_realize, &plc->parent_realize); @@ -782,6 +822,7 @@ static void pnv_lpc_power10_class_init(ObjectClass *kla= ss, const void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->desc =3D "PowerNV LPC Controller POWER10"; + dc->vmsd =3D &vmstate_pnv_lpc; } =20 static const TypeInfo pnv_lpc_power10_info =3D { --=20 2.47.3 From nobody Tue Dec 16 16:37:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1765825020; cv=none; d=zohomail.com; s=zohoarc; b=XveM7nFkRqzq2egvmNG7B+bf/2tYWVjDhi6cQqjWbEyiv7wos9/e2sQePm0WjPbUjkUT+5vKc3iixCRiWY8/dt+3W7Dd0y08bO72EwoLwiu0Ha7Jvek73Hy5KErrhvk/cNJh7+LTaMe1mJJRkOuNwhP3cNyz6FFU1WsZJ2khnMs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765825020; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rj+Bv/ZDTNuzXDenrKI5me9VuCCuFuGX+EqeVL+6lhI=; b=B8/HgrMlutxLzp/x0xhz2HeV/3oablpwerxjjuRZX8uMnLcSju7BDlNU4VqK+3Gwt6UcPFIflzukuVdb3VTeQprN0/VwIvesUi1nPwVFUn4AhON7gsaq1raUBWZoF3my7tS6tRJucmMQe+mC7vk8Z5X7H/UDjBiNgjyW2Glm0Dc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765825020976585.9433265605854; Mon, 15 Dec 2025 10:57:00 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vVCDk-0002aG-Qu; Mon, 15 Dec 2025 12:18:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVCDQ-0002D3-Jg; Mon, 15 Dec 2025 12:18:39 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVCDO-0002hB-S3; Mon, 15 Dec 2025 12:18:32 -0500 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5BFCITJ1009495; Mon, 15 Dec 2025 17:18:25 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0yt1ag5b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:25 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 5BFHAmTN006667; Mon, 15 Dec 2025 17:18:25 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0yt1ag57-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:25 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5BFF3N1k002761; Mon, 15 Dec 2025 17:18:24 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4b1kfmyn7s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:24 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5BFHIMHs7996256 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Dec 2025 17:18:23 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C82EB58060; Mon, 15 Dec 2025 17:18:22 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 51D9258063; Mon, 15 Dec 2025 17:18:22 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 15 Dec 2025 17:18:22 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=rj+Bv/ZDTNuzXDenr KI5me9VuCCuFuGX+EqeVL+6lhI=; b=EhSDSSdS5uYvAPLFQmuf3xtDEDGR3YkA+ xvQullxF6Y91y0/ZarjZG47BPjowx9R2HuJ0sA3KytPhndmpWZnhFArR0KvMH12Y LF8YNV/60PdLxqa1OTZ8YJ4UzzPHngaC15VQsjp2ZbHWyOt82/4JTQvSg5fBAi1x FxMbtTILL1G45/QbhIJeqt18OxZEyzOu5OdKmYsU99QyioqMav5CNAOgnH3ZAnEE ZCTxRIg4I9xiTNcslxTccggwnQSX8F/Jppoe6X9Lz/8Q80vzpXINQMSBfJ2ef/2B Ct5GVW/IcVgfgflLctubAwU6MBaN0ElrjayxWh+ymhCIC3wO+KjFQ== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, kowal@linux.ibm.com, chalapathi.v@linux.ibm.com, calebs@linux.ibm.com, angeloj@linux.ibm.com Subject: [PATCH v2 2/7] hw/ppc: Add pnv_spi vmstate support Date: Mon, 15 Dec 2025 11:18:08 -0600 Message-ID: <20251215171813.1670241-3-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251215171813.1670241-1-calebs@linux.ibm.com> References: <20251215171813.1670241-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: E7BIEy2rnquqEUO0z6R5niISKxEcLkBv X-Proofpoint-ORIG-GUID: HJLTq6wCHAR5cVplifDWUd8EEm3Ad-or X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEzMDAyMyBTYWx0ZWRfXww2pC3OIlZBE 8W+uIBu/SyE+F2dBmy010rPM+5cbb36MBJJTfHB1dMuyly9plyqzRTsva4M26Thz9kFkeJc8SPD TrZpVWoMpWqEuQ+t0JVty27ehtUSxBJziR0XDlCol2Oe2Pam99eF6qs9r3pM14kD+VCijqUjJGg 7ysm6r7jiwLY2MEpEgM5UlDbs1vewzDvZN2DotdsO3YIrevAUPierXW0vpm39o1On8Q3SvyGl8i RzqMTXngOY+c/qYAHswNFmX7tBsMePAIG5ja/NqwDcI25ZN8sN5qY2eejMzhnWLbYpdEWPWGOr4 JONJ7KEzmflLi7i1BfAF2P/ARawIMsa42mznZzWyaVemBvfQnnnlywIo9LcKSgiDjXlswsiRtwr T1eWmqQefed09lncfYZLDXHo1ld+dg== X-Authority-Analysis: v=2.4 cv=L/MQguT8 c=1 sm=1 tr=0 ts=694042e1 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=zPJzuvo3V7OF8ZkWVCkA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-15_04,2025-12-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510240000 definitions=main-2512130023 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=calebs@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1765825022448154100 Content-Type: text/plain; charset="utf-8" - Add support for needed PnvSpi structure variables Signed-off-by: Caleb Schlossin Reviewed-by: Aditya Gupta --- hw/ssi/pnv_spi.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/hw/ssi/pnv_spi.c b/hw/ssi/pnv_spi.c index f40e8836b9..389a2cca6b 100644 --- a/hw/ssi/pnv_spi.c +++ b/hw/ssi/pnv_spi.c @@ -13,6 +13,7 @@ #include "hw/ssi/pnv_spi.h" #include "hw/ssi/pnv_spi_regs.h" #include "hw/ssi/ssi.h" +#include "migration/vmstate.h" #include #include "hw/irq.h" #include "trace.h" @@ -1199,6 +1200,31 @@ static int pnv_spi_dt_xscom(PnvXScomInterface *dev, = void *fdt, return 0; } =20 +static const VMStateDescription pnv_spi_vmstate =3D { + .name =3D TYPE_PNV_SPI, + .version_id =3D 1, + .fields =3D (const VMStateField[]) { + VMSTATE_UINT8(fail_count, PnvSpi), + VMSTATE_UINT8(transfer_len, PnvSpi), + VMSTATE_UINT8(responder_select, PnvSpi), + VMSTATE_BOOL(shift_n1_done, PnvSpi), + VMSTATE_UINT8(loop_counter_1, PnvSpi), + VMSTATE_UINT8(loop_counter_2, PnvSpi), + VMSTATE_UINT8(N1_bits, PnvSpi), + VMSTATE_UINT8(N2_bits, PnvSpi), + VMSTATE_UINT8(N1_bytes, PnvSpi), + VMSTATE_UINT8(N2_bytes, PnvSpi), + VMSTATE_UINT8(N1_tx, PnvSpi), + VMSTATE_UINT8(N2_tx, PnvSpi), + VMSTATE_UINT8(N1_rx, PnvSpi), + VMSTATE_UINT8(N2_rx, PnvSpi), + VMSTATE_UINT64_ARRAY(regs, PnvSpi, PNV_SPI_REGS), + VMSTATE_UINT8_ARRAY(seq_op, PnvSpi, PNV_SPI_REG_SIZE), + VMSTATE_UINT64(status, PnvSpi), + VMSTATE_END_OF_LIST(), + }, +}; + static void pnv_spi_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -1209,6 +1235,7 @@ static void pnv_spi_class_init(ObjectClass *klass, co= nst void *data) dc->desc =3D "PowerNV SPI"; dc->realize =3D pnv_spi_realize; device_class_set_legacy_reset(dc, do_reset); + dc->vmsd =3D &pnv_spi_vmstate; device_class_set_props(dc, pnv_spi_properties); } =20 --=20 2.47.3 From nobody Tue Dec 16 16:37:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1765828650; cv=none; d=zohomail.com; s=zohoarc; b=QBaxq1IdvXqYxAa7RMtajU6mpCxiSxKhASsQ+lWxKDB0wUs6CW6VIWFEW3pHIMMSUHhE4gXP4OpOhbyBq6Vg5/L7f9fuiagg3nr91B4RaKqHOUCWLd6T0EKS7ROCkwr+e85Y4IDS1L+sEhUbzUD1TCN97FYHw5pHxvCKetW+5Pk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765828650; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=44fHeX7l2wlwmfL+5d4CWL4ReGvcYhZ6mdi5DIEcxz0=; b=SBAtYNzZEWHU1cCi+mreTLbkzPaIsOXGFKWQABwX3m5DoYTHyjwEMvla/idey/lncghtTqy3fr8ZEJYoCBhabab3CJKQw79op+HI8kz7RZY6+/rTWbBB/aua6s/GG/IjDbL1Z2jwMvze8gFYJQ883AQ3RRVF81qkARONxjz2QBw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765828649991914.8556310087513; Mon, 15 Dec 2025 11:57:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vVCDo-0002bl-Ms; Mon, 15 Dec 2025 12:18:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVCDQ-0002D1-Fd; Mon, 15 Dec 2025 12:18:39 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVCDO-0002hh-S5; Mon, 15 Dec 2025 12:18:32 -0500 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5BFAH1W5004552; Mon, 15 Dec 2025 17:18:27 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0yt1ag5m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:27 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 5BFHHddk021536; Mon, 15 Dec 2025 17:18:26 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0yt1ag5h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:26 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5BFGAd3B014318; Mon, 15 Dec 2025 17:18:26 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([172.16.1.70]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4b1mpjqc7p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:26 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5BFHI8NR8454684 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Dec 2025 17:18:08 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2D27C58056; Mon, 15 Dec 2025 17:18:24 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A163258060; Mon, 15 Dec 2025 17:18:23 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 15 Dec 2025 17:18:23 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=44fHeX7l2wlwmfL+5 d4CWL4ReGvcYhZ6mdi5DIEcxz0=; b=meui0fmF6+j6stqxIxVubE18vlcb32HfI wZ2qVCCflGJknYUZQh58HMYL3E40HTBgwc+tQWLHbM1RvqEP7ykJzo2jOPg95vXs 05PUbPRUsij8TQM2AGRfeyhFCxbAwsjdgjw6F+Yv19an4fp9fNasNSACuwz+OtZy 5t97DQgpAtV+6XZCQgqNlzwcOpV2XwJJivWmBGliLlkUMcDOrNLF7msDRFpt1U7j jTsCIEF+mT0KKeS12UzJp1gOnHSfkJKv/pvLwR6yveiOdEOnlAB6X1mENOmJd8UN kCmpOlNdpiMHrHFyl7x1uOpEpaaQL+2IoXrtaiVST5vINqc5lo8wA== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, kowal@linux.ibm.com, chalapathi.v@linux.ibm.com, calebs@linux.ibm.com, angeloj@linux.ibm.com Subject: [PATCH v2 3/7] hw/ppc: Add pnv_i2c vmstate support Date: Mon, 15 Dec 2025 11:18:09 -0600 Message-ID: <20251215171813.1670241-4-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251215171813.1670241-1-calebs@linux.ibm.com> References: <20251215171813.1670241-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: SHkDNneAByNVkPjCWHZ4w90xIjQwNhNz X-Proofpoint-ORIG-GUID: Taoa8tOOrNv-pQsz3yL7ikumqkVdKGQa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEzMDAyMyBTYWx0ZWRfX3vl1M7s/pZ3V eSCE2JRCiHO5Gg2yoK71JAMoBFbdMwR4oAcGCV9dgQRxYNfcZCU2YM81CGyI+Q2X2gK05vyr549 1YMz4eOzGmJF0SAgCkaYJlHSxtU38UepPY2pW4CKrKhsiocYFjtqNVcwrspVjl3Vw55Njx7hNO6 uKCaEuIUAvRr87taSf0ewZPhky0xzKLD02mrD0u6XYtLqSis00LYoocsi6XWQeXKAFgKVq4kntH m14PSEERp+b17zTV9TcAwKTTcgVOkq+60Y7mxC5lrmAqVHVHHX4zxLvQGw4zZhUver/n3hgsVW3 Iw5RUYKuDbij2mJV5cTHXD43PA9virRSTXHNLx9Xheso5pQgHTaBCc5Rc+4/Xc9vs3f7i8YtUpr i3uT3e2o3eibJ1JJWhjBcb/tcWIoNg== X-Authority-Analysis: v=2.4 cv=L/MQguT8 c=1 sm=1 tr=0 ts=694042e3 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=DGM2Vrrcx73IGRt511UA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-15_04,2025-12-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510240000 definitions=main-2512130023 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=calebs@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1765828652776158500 Content-Type: text/plain; charset="utf-8" - Add vmstate support for i2c registers Signed-off-by: Caleb Schlossin Reviewed-by: Aditya Gupta --- hw/ppc/pnv_i2c.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/ppc/pnv_i2c.c b/hw/ppc/pnv_i2c.c index 60de479491..1018078228 100644 --- a/hw/ppc/pnv_i2c.c +++ b/hw/ppc/pnv_i2c.c @@ -19,6 +19,7 @@ #include "hw/ppc/pnv_i2c.h" #include "hw/ppc/pnv_xscom.h" #include "hw/ppc/fdt.h" +#include "migration/vmstate.h" =20 #include =20 @@ -549,6 +550,15 @@ static const Property pnv_i2c_properties[] =3D { DEFINE_PROP_UINT32("num-busses", PnvI2C, num_busses, 1), }; =20 +static const VMStateDescription pnv_i2c_vmstate =3D { + .name =3D TYPE_PNV_I2C, + .version_id =3D 1, + .fields =3D (const VMStateField[]) { + VMSTATE_UINT64_ARRAY(regs, PnvI2C, PNV_I2C_REGS), + VMSTATE_END_OF_LIST(), + }, +}; + static void pnv_i2c_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -561,6 +571,7 @@ static void pnv_i2c_class_init(ObjectClass *klass, cons= t void *data) =20 dc->desc =3D "PowerNV I2C"; dc->realize =3D pnv_i2c_realize; + dc->vmsd =3D &pnv_i2c_vmstate; device_class_set_props(dc, pnv_i2c_properties); } =20 --=20 2.47.3 From nobody Tue Dec 16 16:37:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1765824915; cv=none; d=zohomail.com; s=zohoarc; b=E/UejaNXHxPR8PV3hhW1n3Fg2bv707JWbhpyyVulrtU50l5rj+pCNmTAGuIcRlCsuOuOLgp1tYu56wWtsTKL6xtHpg5NSiZCsyDJ5rronx+LsjnKY6tjah0+36y4H+t+AG2PRtmS0gb+vYciI+e+nMIx+SgpprgziYTlMG3+30Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765824915; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UXGPJgqGe4SMmBhzjkw2ibPeM4RYnUTKtGy7LaGhK0I=; b=mGYI2EQ6PLhY/VB6ItS4rDrgpZkT/+aQ+YNVM+I+eqCEaXdyQuv9Pf6przkBx79o2DjVOSDnFVGCxZmCPVsmqtDkjAqDP3s5bN+iQ6rgUyd/n53XyPkKDSGQAuZLVFDhmusPX0iG5hrHyio1e59BXGtKxpcs5mhu3Scwr5JF9JU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765824915201108.16173194961334; Mon, 15 Dec 2025 10:55:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vVCEF-00030C-0t; Mon, 15 Dec 2025 12:19:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVCDU-0002GO-AB; Mon, 15 Dec 2025 12:18:39 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVCDP-0002hz-Q8; Mon, 15 Dec 2025 12:18:33 -0500 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5BFClVqR015244; Mon, 15 Dec 2025 17:18:27 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0yvb33tm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:27 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 5BFHElfX013240; Mon, 15 Dec 2025 17:18:27 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0yvb33tg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:27 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5BFGAJBP014324; Mon, 15 Dec 2025 17:18:26 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4b1mpjqc7q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:26 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5BFHIPN425494094 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Dec 2025 17:18:25 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5BFCF58056; Mon, 15 Dec 2025 17:18:25 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DA2FB58061; Mon, 15 Dec 2025 17:18:24 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 15 Dec 2025 17:18:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=UXGPJgqGe4SMmBhzj kw2ibPeM4RYnUTKtGy7LaGhK0I=; b=ik6/Sn3DAYmnNb+eFUeSDnjJud4OcSKnj lETrNilvXoT0h1jbRhivV7gLn9eAF3o/h+QhZtdEyB9dAZV0164F09azSKm+0E20 B6GFjWurh3knV6ooe4c/Cc2xXbnmhEeYUHEqRTi+fsukSX/PNpogMR1oBeCT92eg Fdt02kqBH3uLPMEQq2i7JtyP1a+5TFmtHom68H/QO9hlSGtAEp3lS8dIByowlMLO /UufB8ief0hgXRUXQGTl9e/66Pe9UoQTsWMGXLvCLVVN/UeQRRQbp5ZcQb+n+oCV ahk8wimZw31HHobm68QGzt4GJpa4WaWdtWv+RES94fezeUV7kBevw== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, kowal@linux.ibm.com, chalapathi.v@linux.ibm.com, calebs@linux.ibm.com, angeloj@linux.ibm.com Subject: [PATCH v2 4/7] hw/ppc: pnv_adu.c added vmstate support Date: Mon, 15 Dec 2025 11:18:10 -0600 Message-ID: <20251215171813.1670241-5-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251215171813.1670241-1-calebs@linux.ibm.com> References: <20251215171813.1670241-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=V/JwEOni c=1 sm=1 tr=0 ts=694042e3 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=PgXMhBZ8xRIDpNHfNDEA:9 X-Proofpoint-GUID: c8Odpvyo4tmTzszx9KO0c-ZEVyYuLsmL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEzMDAyMyBTYWx0ZWRfX0j8whX2UHJPy pDuwffDLFYCpXShRxG3gj/HvM+yyiTLxE/1ogRSI0/hdYKrFWwL72HY5oLVPh1LXKdFHOWWio0C pQ8GUkp4EkaodGGigKDh3R7Hidw8KDI+8Wiv+49aQfb6bwq5PecNNpHJ9t4oBMt1odSInBCeiBI +aSA/7hP5sKvnkr1FJR0B7qHOE7dk20Q8FbsnAVx4Z+y+0UbIMhKOjZxNNTgM4BTIbZS/SrZokh d1OrAw35/WvwLWFTTEPdwerc+HzzdscYFW9aEqCrAJMv9+4D1UFm9F+GkjTd1lmtAy7NEZqp/6F f/nEzQDRPjBokb88CC7AZ0phIZ5AwqrN2Yry7AEUft5DOsgmWrNPCVAmxIqtq87oduzF+PXtk9r F/V0AocDteuiBcdxSHJFEPXD0dh6Iw== X-Proofpoint-ORIG-GUID: HnF_8VtVGbBBkbqVaQhG2CZCmoQnszJ7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-15_04,2025-12-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 bulkscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510240000 definitions=main-2512130023 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=calebs@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1765824921263139100 Content-Type: text/plain; charset="utf-8" - Added vmstate support for ADU model Signed-off-by: Angelo Jaramillo Signed-off-by: Caleb Schlossin Reviewed-by: Aditya Gupta --- hw/ppc/pnv_adu.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/ppc/pnv_adu.c b/hw/ppc/pnv_adu.c index 005fbda475..bd2a9e233a 100644 --- a/hw/ppc/pnv_adu.c +++ b/hw/ppc/pnv_adu.c @@ -23,6 +23,7 @@ #include "hw/ppc/pnv_chip.h" #include "hw/ppc/pnv_lpc.h" #include "hw/ppc/pnv_xscom.h" +#include "migration/vmstate.h" #include "trace.h" =20 #define ADU_LPC_BASE_REG 0x40 @@ -189,6 +190,16 @@ static const Property pnv_adu_properties[] =3D { DEFINE_PROP_LINK("lpc", PnvADU, lpc, TYPE_PNV_LPC, PnvLpcController *), }; =20 +static const VMStateDescription pnv_adu_vmstate =3D { + .name =3D TYPE_PNV_ADU, + .version_id =3D 1, + .fields =3D (const VMStateField[]) { + VMSTATE_UINT64(lpc_cmd_reg, PnvADU), + VMSTATE_UINT64(lpc_data_reg, PnvADU), + VMSTATE_END_OF_LIST(), + }, +}; + static void pnv_adu_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -197,6 +208,7 @@ static void pnv_adu_class_init(ObjectClass *klass, cons= t void *data) dc->desc =3D "PowerNV ADU"; device_class_set_props(dc, pnv_adu_properties); dc->user_creatable =3D false; + dc->vmsd =3D &pnv_adu_vmstate; } =20 static const TypeInfo pnv_adu_type_info =3D { --=20 2.47.3 From nobody Tue Dec 16 16:37:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1765829100; cv=none; d=zohomail.com; s=zohoarc; b=baP3DpHNI5kJWRCSFVdHaTqQI2tuid7rQ5iFS5W+lJVwJ1nQtUuklALzhE9Ew7OdXiIpc65u4DENEYnX7HboVkqRe31qD4ArafpO4T9SEo5MxhG13KXAFAVjv3gnQ1RMN98qaoN9171CKY7vEDIxrFozz5HgK8kDRDtSMV1jRd0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765829100; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vakf4KS5jvKAayUTjS8UDZ/c6IzELYhdEzAawdQnx2c=; b=kaU09PI/V8TNfgv/Y8iTRC/VS4aP/J2c+sdEQUGEFk9fITCgyHFTTfj7BeXh7+CZLWDOvVudIp0+0tjBFZWaWLQIJcpJW7KEzzNW2c0F8cTyum3xu6jnSwospzElOh4vUfNipWf7CfZdpLlXcWUFJdciQ4q53Tc8ccQ/+cQNCLI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176582910066942.13287579421649; Mon, 15 Dec 2025 12:05:00 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vVCEP-0003E4-NU; Mon, 15 Dec 2025 12:19:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVCDW-0002HW-7C; Mon, 15 Dec 2025 12:18:39 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVCDQ-0002io-HA; Mon, 15 Dec 2025 12:18:33 -0500 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5BFBG8ZJ020030; Mon, 15 Dec 2025 17:18:29 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0ytv34n6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:28 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 5BFHBq05003481; Mon, 15 Dec 2025 17:18:28 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0ytv34n2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:28 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5BFGNoQa014406; Mon, 15 Dec 2025 17:18:27 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4b1mpjqc7x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:27 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5BFHIQpv15663734 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Dec 2025 17:18:26 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8165058063; Mon, 15 Dec 2025 17:18:26 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0B27958056; Mon, 15 Dec 2025 17:18:26 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 15 Dec 2025 17:18:25 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=vakf4KS5jvKAayUTj S8UDZ/c6IzELYhdEzAawdQnx2c=; b=bRt/YLFnqIQsQusmGKlfJVBvvebDGS8PB PEk3GYmAzVC968zMZzHkg5Wo1ZAWHBzwkEgo2v+rH7vknOO/qXrlZ29iobSNKbjN 2T7WwykpnYTyDAIsl8Kd0Had/bYntNIbEt9AUuL17bclN128vKYUYtjthpcXlNLM tqHf0DMi8Rb95FlZWsedBUCVlTjXmnJcJu3vQ6YXa/1DGaa8R6zEvXGsPNOV9C1Y Bb83693lKTokff1MzytktDOx7vphzTtgR5wnFdqTDovyKxxAvSElX7eZPyUdAjke UApDPwkUi3am6bK9Fo7Lg6ST1M4uybEj0xgv96r9uhRnkh4pbvaIQ== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, kowal@linux.ibm.com, chalapathi.v@linux.ibm.com, calebs@linux.ibm.com, angeloj@linux.ibm.com Subject: [PATCH v2 5/7] hw/ppc: pnv_core.c add vmstate support Date: Mon, 15 Dec 2025 11:18:11 -0600 Message-ID: <20251215171813.1670241-6-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251215171813.1670241-1-calebs@linux.ibm.com> References: <20251215171813.1670241-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEzMDAyMyBTYWx0ZWRfX9EXW57XNLABw atxFhck8FDj+JcD5b3rkVzfKb+DZ7VC2nrbcOj+MOR9JkeJYrOUF4eo3BGLDNMC1HW7AYcFa0kw uB/D5CNkxe/ozN4zobDTpL1HiOVuA9tBwnUnkauwkVvFbniokmHy5dSGSKtv9ivSGt/0skECesU GaMGboX9Q3GKPghmj9hZww/fG9YRaOPNL8D6nrhy0rviv4dmy7R6Fpou0YcPnQw8lpWhBSZzJTE PpOPNPIVnwzC2YwP+gNtlv5HRFbud97F9qoFp2j5lp1x+ecWFwce5YyCE4HcgM4f1mVwyXLGIXG qrB5S9Na9/IVmXXjot+Zyr5DssBsKqn+o+vMcij62mkV+Iojt9Qx8ztDwI83mwTIG2XynTljfzI 1eslxAOZSgahiGql844njHNeON5dlA== X-Proofpoint-ORIG-GUID: 5TKiE3RR4RUIg1AQtaeFljWuFOmJ2NLE X-Authority-Analysis: v=2.4 cv=QtRTHFyd c=1 sm=1 tr=0 ts=694042e4 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=QXuC7XpKZ5phjoL22fcA:9 X-Proofpoint-GUID: Olyfne18taEpvVhX8H4yObEwF2NP_dA6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-15_04,2025-12-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510240000 definitions=main-2512130023 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=calebs@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1765829102949158500 Content-Type: text/plain; charset="utf-8" - Add vmstate support PnvCore and PnvQuad capturing scratch registers and special wakeup registers Signed-off-by: Angelo Jaramillo Signed-off-by: Caleb Schlossin Reviewed-by: Aditya Gupta --- hw/ppc/pnv_core.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c index fb2dfc7ba2..03b64f0013 100644 --- a/hw/ppc/pnv_core.c +++ b/hw/ppc/pnv_core.c @@ -31,6 +31,7 @@ #include "hw/ppc/xics.h" #include "hw/qdev-properties.h" #include "helper_regs.h" +#include "migration/vmstate.h" =20 static const char *pnv_core_cpu_typename(PnvCore *pc) { @@ -478,6 +479,15 @@ static void pnv_core_power11_class_init(ObjectClass *o= c, const void *data) pnv_core_power10_class_init(oc, data); } =20 +static const VMStateDescription pnv_core_vmstate =3D { + .name =3D TYPE_PNV_CORE, + .version_id =3D 1, + .fields =3D (const VMStateField[]) { + VMSTATE_UINT64_ARRAY(scratch, PnvCore, 8), + VMSTATE_END_OF_LIST(), + }, +}; + static void pnv_core_class_init(ObjectClass *oc, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(oc); @@ -486,6 +496,7 @@ static void pnv_core_class_init(ObjectClass *oc, const = void *data) dc->unrealize =3D pnv_core_unrealize; device_class_set_props(dc, pnv_core_properties); dc->user_creatable =3D false; + dc->vmsd =3D &pnv_core_vmstate; } =20 #define DEFINE_PNV_CORE_TYPE(family, cpu_model) \ @@ -737,12 +748,23 @@ static void pnv_quad_power11_class_init(ObjectClass *= oc, const void *data) pnv_quad_power10_class_init(oc, data); } =20 +static const VMStateDescription pnv_quad_vmstate =3D { + .name =3D TYPE_PNV_QUAD, + .version_id =3D 1, + .fields =3D (const VMStateField[]) { + VMSTATE_BOOL(special_wakeup_done, PnvQuad), + VMSTATE_BOOL_ARRAY(special_wakeup, PnvQuad, 4), + VMSTATE_END_OF_LIST(), + }, +}; + static void pnv_quad_class_init(ObjectClass *oc, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(oc); =20 device_class_set_props(dc, pnv_quad_properties); dc->user_creatable =3D false; + dc->vmsd =3D &pnv_quad_vmstate; } =20 static const TypeInfo pnv_quad_infos[] =3D { --=20 2.47.3 From nobody Tue Dec 16 16:37:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1765829252; cv=none; d=zohomail.com; s=zohoarc; b=iF3IvNRB3fNoUlXop+ParRgegejbHE5abkGNKbuXBj6H2WL6faw/oRt3t6Mrd8y3zWfpFjRB6l7xNTU68ycH4MrAuBN3ktoizUl4caIC/0dTysjh5XW7HdgXjiQPVoBZxLRyWqZhs2el91OaQTWPMO83eiBl/G7NAn4IlKfrZ9M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765829252; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jcAN7q4Px4l/w7XdI+IIyXW1K41nZmGak05mxyr+J5o=; b=koRSf5jA8iuRz8uaisH3vv4VkkBCIKoEIOsAK/O0kampNB1UECBPwY/6+QsEfk0uV10Frrar7XUSSy3PK91HnlTOQ7+11wB54bmSLEZWx2t/4Bhi+36XgogYdWqRDLgkgqcAX3XF2CCM5adW4ucIgW4vXyXNo6cVXDzXy0pLOVM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765829252609699.1226350818888; Mon, 15 Dec 2025 12:07:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vVCE5-0002uP-5O; Mon, 15 Dec 2025 12:19:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVCDW-0002HV-7W; Mon, 15 Dec 2025 12:18:39 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVCDQ-0002iv-KP; Mon, 15 Dec 2025 12:18:34 -0500 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5BFCHumS002244; Mon, 15 Dec 2025 17:18:30 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0xjktn2n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:30 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 5BFHITHD007079; Mon, 15 Dec 2025 17:18:29 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0xjktn2h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:29 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5BFFOHhs002856; Mon, 15 Dec 2025 17:18:29 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4b1kfmyn87-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:28 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5BFHIRTc23069240 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Dec 2025 17:18:27 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B167D58063; Mon, 15 Dec 2025 17:18:27 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B4E95805A; Mon, 15 Dec 2025 17:18:27 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 15 Dec 2025 17:18:27 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=jcAN7q4Px4l/w7XdI +IIyXW1K41nZmGak05mxyr+J5o=; b=CQdJ/sXH//BtwriHYk60d2KLXuNpD4Zxv /piQMG5uEMCZJoRojB4toNyVbVYLRm9WFTF757+5gkFZw9lAivCpMernMEMjXdYZ RdUjtPx5QpMfDN5PrujKRw1/80+WBpEDW64J6zotFBE1+Vb+3MZv6ltk9LvolHN7 iVp11EgHkfX5vpE5saT6HLKBi9EyFu+KSG3WtJ+b34Do9saaIukWYCg4Z+XEz/I8 Asz5x8oCTxJbsZA0FjO06ERyL6hoR2JDxlOGErtItuqo9OwhKwTEMssMebSZkoI7 vKVQgJQOZ1nO6Lc3g0q+0a1pv/prmzanKb8AHHX0iu6ex45a5Pinw== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, kowal@linux.ibm.com, chalapathi.v@linux.ibm.com, calebs@linux.ibm.com, angeloj@linux.ibm.com Subject: [PATCH v2 6/7] hw/ppc: pnv_chiptod.c add vmstate support Date: Mon, 15 Dec 2025 11:18:12 -0600 Message-ID: <20251215171813.1670241-7-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251215171813.1670241-1-calebs@linux.ibm.com> References: <20251215171813.1670241-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: CUQYU40ZZEafyUAy-7KE_aFj_E-Meydd X-Authority-Analysis: v=2.4 cv=CLgnnBrD c=1 sm=1 tr=0 ts=694042e6 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=2tKvrj9r5tddppBGlX0A:9 X-Proofpoint-GUID: A-BL0gcu4_n1fPJbExOdiy0FECo1mRi6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEzMDAwOSBTYWx0ZWRfX2/2OZ4XN2DhU 4QWn3pvq3QmLJIpw5dSFR6hPd2ArpfBdD9W8S2XIqJLkOwLaMeCtWTJR3QdKBt3O1BYdw5jC8y6 Wv1/QHZHfxifPBxyPTSBgX3bu6/g2ipoC1/fcjRav906hvFNVw2oy7Qz0Z/NfCJTDcWhNrWgKIp SpWxHXP4Qr2Ea774awBLwRqKhydFqPe6ipfJqq4BmTjuvUpPa0x/ta7EjMHxh98TlyMboq5wmjX wSVjhE3WTQSIYOmtBfjipPPqjnIaTJ9jUBmCnqlmnmCXwH9uYF8092nh0DxqUzboJLIdODHa3kY duFIXjvAa/fDeaO2P+xZ/p1gAVBR1TUrf7gFD3k/QBsv84tHSKyG1/1XgXon+RpZ5ho+Nltem9F mjFRLy+OirkzdNPux9PxUM+ohp2s/g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-15_04,2025-12-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510240000 definitions=main-2512130009 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=calebs@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1765829253837158500 Content-Type: text/plain; charset="utf-8" - Added pre_save and post_load methods to handle slave_pc_target and tod_st= ate Signed-off-by: Angelo Jaramillo Signed-off-by: Caleb Schlossin Reviewed-by: Aditya Gupta --- hw/ppc/pnv_chiptod.c | 38 ++++++++++++++++++++++++++++++++++++ include/hw/ppc/pnv_chiptod.h | 2 ++ 2 files changed, 40 insertions(+) diff --git a/hw/ppc/pnv_chiptod.c b/hw/ppc/pnv_chiptod.c index f887a18cde..9dc5942ca0 100644 --- a/hw/ppc/pnv_chiptod.c +++ b/hw/ppc/pnv_chiptod.c @@ -37,6 +37,7 @@ #include "hw/ppc/pnv_core.h" #include "hw/ppc/pnv_xscom.h" #include "hw/ppc/pnv_chiptod.h" +#include "migration/vmstate.h" #include "trace.h" =20 #include @@ -341,6 +342,8 @@ static void pnv_chiptod_xscom_write(void *opaque, hwadd= r addr, " TOD_TX_TTYPE_CTRL_REG val 0x%" PRIx64 " invalid slave address\n", val); } + /* Write slave_pc_target to a uint64_t variable for vmstate suppor= t. */ + chiptod->tx_ttype_ctrl =3D val; break; case TOD_ERROR_REG: chiptod->tod_error &=3D ~val; @@ -613,6 +616,40 @@ static void pnv_chiptod_unrealize(DeviceState *dev) qemu_unregister_reset(pnv_chiptod_reset, chiptod); } =20 +static int vmstate_pnv_chiptod_pre_save(void *opaque) +{ + PnvChipTOD *chiptod =3D PNV_CHIPTOD(opaque); + chiptod->tod_state_val =3D (uint8_t)chiptod->tod_state; + return 0; +} + +static int vmstate_pnv_chiptod_post_load(void *opaque) +{ + PnvChipTOD *chiptod =3D PNV_CHIPTOD(opaque); + if (chiptod->tx_ttype_ctrl !=3D 0) { + pnv_chiptod_xscom_write(chiptod, TOD_TX_TTYPE_CTRL_REG << 3, + chiptod->tx_ttype_ctrl, 8); + } + chiptod->tod_state =3D (enum tod_state)chiptod->tod_state_val; + return 0; +} + +static const VMStateDescription pnv_chiptod_vmstate =3D { + .name =3D TYPE_PNV_CHIPTOD, + .version_id =3D 1, + .pre_save =3D vmstate_pnv_chiptod_pre_save, + .pre_load =3D vmstate_pnv_chiptod_post_load, + .fields =3D (const VMStateField[]) { + VMSTATE_BOOL(primary, PnvChipTOD), + VMSTATE_BOOL(secondary, PnvChipTOD), + VMSTATE_UINT64(tod_error, PnvChipTOD), + VMSTATE_UINT64(pss_mss_ctrl_reg, PnvChipTOD), + VMSTATE_UINT64(tx_ttype_ctrl, PnvChipTOD), + VMSTATE_UINT8(tod_state_val, PnvChipTOD), + VMSTATE_END_OF_LIST(), + }, +}; + static void pnv_chiptod_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -621,6 +658,7 @@ static void pnv_chiptod_class_init(ObjectClass *klass, = const void *data) dc->unrealize =3D pnv_chiptod_unrealize; dc->desc =3D "PowerNV ChipTOD Controller"; dc->user_creatable =3D false; + dc->vmsd =3D &pnv_chiptod_vmstate; } =20 static const TypeInfo pnv_chiptod_type_info =3D { diff --git a/include/hw/ppc/pnv_chiptod.h b/include/hw/ppc/pnv_chiptod.h index 466b06560a..3e5e3b02b2 100644 --- a/include/hw/ppc/pnv_chiptod.h +++ b/include/hw/ppc/pnv_chiptod.h @@ -41,6 +41,8 @@ struct PnvChipTOD { uint64_t tod_error; uint64_t pss_mss_ctrl_reg; PnvCore *slave_pc_target; + uint64_t tx_ttype_ctrl; + uint8_t tod_state_val; }; =20 struct PnvChipTODClass { --=20 2.47.3 From nobody Tue Dec 16 16:37:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1765825319; cv=none; d=zohomail.com; s=zohoarc; b=HUH9frtWcqW6Npx7XdSSgMLwn3hOdtXgzdbQ8pQZ/YfsugbKTjCZ0j3KL4/9O2NOpRCLjQU0EaCGhjosmzO6yJXnTEf9r+ANC+6UoCMBr/olls/6Smkh4eFmg4zg5NPjtrCuMfQ0oQW3dmRGB348maXoNLQf+6Fntle+vFrXhTw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765825319; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nuTYvNasgluFn+71u0kQIdIJjL+OgfRbewQMJ5XdC+Q=; b=TE1OYS17WRe3YsXD2ijuxdVRLsOr65kuNqQRTPP+yhr/4pD394k03LB2PPXLDkboR5InDZybHA3jShw+OSeDJ3VldIy/6/R/0/KTJ1n8XXPL4dKxiGKhCwNZviVT5PdvdkPGBZddsTOt1+oWy+HDp4yDbFFUgA/Hiku3DUfMrUM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765825319127222.77512558049318; Mon, 15 Dec 2025 11:01:59 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vVCEb-0003lw-2W; Mon, 15 Dec 2025 12:19:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVCDX-0002HX-HG; Mon, 15 Dec 2025 12:18:41 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vVCDT-0002jz-2x; Mon, 15 Dec 2025 12:18:39 -0500 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5BFCb12T008563; Mon, 15 Dec 2025 17:18:31 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0yt1ag66-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:31 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 5BFHEE5T012642; Mon, 15 Dec 2025 17:18:31 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4b0yt1ag63-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:31 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5BFER1dE012810; Mon, 15 Dec 2025 17:18:30 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4b1juxytww-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Dec 2025 17:18:30 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5BFHITNp33817248 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Dec 2025 17:18:29 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0321258056; Mon, 15 Dec 2025 17:18:29 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 80AFA5805A; Mon, 15 Dec 2025 17:18:28 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 15 Dec 2025 17:18:28 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=nuTYvNasgluFn+71u 0kQIdIJjL+OgfRbewQMJ5XdC+Q=; b=ZsnUW44X2fPtlzKxx4MPnIKXuFzpXBKCF l51BrUOyeDzmujEQ3bwY8LkfdeQMyhZfWQ1KiHMmXkyEix3FxC8pvRzmSdqmlC6r 5VmodTFRlE2QKySYdBrZpB2eQ6ntYpusNp6xuYexVE+Ffbrofykr7NwgB1GkHd9t t9Zs3LLjAJEayzU1lv6NBEGcf8nN/CCflkRjrNM3yzzbQZaLrdgnvJxETECuM1XD +WLXT8XWNwXYPHlte7vBt2UqzQT+H/TT7eTAoQUThhYxCuVodP7LLkf2ZHFhtxn2 5M9JHfChyqX067ZEr/oAw0TiQVXF4M5HDdw9Q6+TVz3uktKbRFInQ== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, kowal@linux.ibm.com, chalapathi.v@linux.ibm.com, calebs@linux.ibm.com, angeloj@linux.ibm.com Subject: [PATCH v2 7/7] hw/ppc: Add VMSTATE information to PnvPsi Date: Mon, 15 Dec 2025 11:18:13 -0600 Message-ID: <20251215171813.1670241-8-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251215171813.1670241-1-calebs@linux.ibm.com> References: <20251215171813.1670241-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: nothzA4TzTgWZdQmDQrfN70jBwuEccOz X-Proofpoint-ORIG-GUID: 1TJ1XdbMhUaqY4MkAMfqA-qTRMJulZEU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEzMDAyMyBTYWx0ZWRfX4uQhwF+RtYYj UFh1gPCd8NYu7FBrYk5FB7x7LIRqdeWjiTNJd/V12v/jAtNIAafA1LpzUlXj700ib4Rz5Mx1qol HHRP6Ht6Ayvw3oVvuHg4I2NXMCMu82iDVbRx9jsuTDr4lRf+pDW11iwBZPU17UDP7GqJMVNAzxb J+3utA6DFjity4RF3DidnjFELn0ru5XxxJnSkbRe8h5qsxBjmX9ngenhTz3es0v7yszbyiFKwGR Yvja60MppmOkO+W0Tk7wiT2+0WUzj+Od4mXpDWotwq6mOQY1P499FzJyAkrUjnzcYV4SnH1qUH0 KfS6GlnJSemTTMs3z6gDjP6gaSUPSHLEFTd1jL3KxLN2YmMDyRTV/U5NjtHhiSUVVCZdZxD9Czj /Ez69m23eLxGE42Cf8S+h48glLOUVQ== X-Authority-Analysis: v=2.4 cv=L/MQguT8 c=1 sm=1 tr=0 ts=694042e7 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=yvJQjjxT_zsGvj7SWxAA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-15_04,2025-12-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510240000 definitions=main-2512130023 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=calebs@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1765825320141158500 Content-Type: text/plain; charset="utf-8" PnvPsi needs to be able to save/load snapshots. Add VMSTATE information to the device class and a post_load() method to restore dynamic data items = and memory region mappings. Signed-off-by: Michael Kowal Signed-off-by: Caleb Schlossin Reviewed-by: Aditya Gupta --- hw/ppc/pnv_psi.c | 46 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/hw/ppc/pnv_psi.c b/hw/ppc/pnv_psi.c index 5d947d8b52..88d5f1d45d 100644 --- a/hw/ppc/pnv_psi.c +++ b/hw/ppc/pnv_psi.c @@ -25,6 +25,7 @@ #include "qemu/module.h" #include "system/reset.h" #include "qapi/error.h" +#include "migration/vmstate.h" =20 =20 #include "hw/ppc/fdt.h" @@ -35,6 +36,8 @@ =20 #include =20 +#undef PSI_DEBUG + #define PSIHB_XSCOM_FIR_RW 0x00 #define PSIHB_XSCOM_FIR_AND 0x01 #define PSIHB_XSCOM_FIR_OR 0x02 @@ -130,12 +133,11 @@ static void pnv_psi_set_bar(PnvPsi *psi, uint64_t bar) { PnvPsiClass *ppc =3D PNV_PSI_GET_CLASS(psi); MemoryRegion *sysmem =3D get_system_memory(); - uint64_t old =3D psi->regs[PSIHB_XSCOM_BAR]; =20 psi->regs[PSIHB_XSCOM_BAR] =3D bar & (ppc->bar_mask | PSIHB_BAR_EN); =20 /* Update MR, always remove it first */ - if (old & PSIHB_BAR_EN) { + if (memory_region_is_mapped(&psi->regs_mr)) { memory_region_del_subregion(sysmem, &psi->regs_mr); } =20 @@ -975,6 +977,40 @@ static void pnv_psi_register_types(void) =20 type_init(pnv_psi_register_types); =20 +#ifdef PSI_DEBUG +static void psi_regs_pic_print_info(uint64_t *regs, uint32_t nr_regs, + GString *buf) { + uint i, prev_idx =3D -1; + uint64_t reg1, prev_reg1 =3D -1; + uint64_t reg2, prev_reg2 =3D -1; + uint64_t reg3, prev_reg3 =3D -1; + uint64_t reg4, prev_reg4 =3D -1; + for (i =3D 0; i < nr_regs; i =3D i + 4) { + /* Don't print if values do not change, but print last*/ + reg1 =3D regs[i]; + reg2 =3D regs[i + 1]; + reg3 =3D regs[i + 2]; + reg4 =3D regs[i + 3]; + if (reg1 =3D=3D prev_reg1 && reg2 =3D=3D prev_reg2 && + reg3 =3D=3D prev_reg3 && reg4 =3D=3D prev_reg4 && + i < (nr_regs - 4)) { + if (i =3D=3D (prev_idx + 4)) { + g_string_append_printf(buf, " . . .\n"); + } + continue; + } + + g_string_append_printf(buf, " [%03X] 0x%016lX %016lX %016lX %016l= X\n", + i, reg1, reg2, reg3, reg4); + prev_idx =3D i; + prev_reg1 =3D reg1; + prev_reg2 =3D reg2; + prev_reg3 =3D reg3; + prev_reg4 =3D reg4; + } +} +#endif + void pnv_psi_pic_print_info(Pnv9Psi *psi9, GString *buf) { PnvPsi *psi =3D PNV_PSI(psi9); @@ -985,4 +1021,10 @@ void pnv_psi_pic_print_info(Pnv9Psi *psi9, GString *b= uf) g_string_append_printf(buf, "PSIHB Source %08x .. %08x\n", offset, offset + psi9->source.nr_irqs - 1); xive_source_pic_print_info(&psi9->source, offset, buf); +#ifdef PSI_DEBUG + /* Print PSI registers */ + g_string_append_printf(buf, "\nPSI Regs[0x0..%X]\n", + PSIHB_XSCOM_MAX); + psi_regs_pic_print_info(psi->regs, PSIHB_XSCOM_MAX, buf); +#endif } --=20 2.47.3