From nobody Tue Dec 16 06:35:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1765794071; cv=none; d=zohomail.com; s=zohoarc; b=np1rmm3hR5A32K3ydhZZh4zJ+UicAMefTRyfYvoHyUDe/XURxiyTRE00fsLZpcvlHYJBm7aD8M9S0lD/5xV1kUgEzhChwD6UXZ1iQ1PRvoqYboDNZQuNAKl/PrD1sA+wCkui4t8mMnk07pV50TJS7czlRSP++d7yCD7BSqteXDM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765794071; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oOcqv8DjvO+pW6fAqI2yp6z6bbBurpuhDzRDlRDfPak=; b=PA857oGyQE8zB0xMx85IV0x98VmKwjH+6iX18WKG9l/UMghSJkZ5+S1t0Xu4iA6M3esIsatxjdopZj5Kf4tYlCaw+qUvQcSS/1c6BkD4HvY6kGCdHUKjLHTdParqY7R9yWlAC+tQM0adGewwZRLOXEQu2X3qwJlfvO+RmWw/c2s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765794071688448.564292579267; Mon, 15 Dec 2025 02:21:11 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vV5hG-0002Pc-K6; Mon, 15 Dec 2025 05:20:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vV5gT-0002KT-82 for qemu-devel@nongnu.org; Mon, 15 Dec 2025 05:20:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vV5gP-0006B1-W5 for qemu-devel@nongnu.org; Mon, 15 Dec 2025 05:20:04 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-Ilkk5SmMOBWZ63gQ5ET9Zw-1; Mon, 15 Dec 2025 05:19:51 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AA696195F156; Mon, 15 Dec 2025 10:19:50 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.30]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 32A3D19560A7; Mon, 15 Dec 2025 10:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765794000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oOcqv8DjvO+pW6fAqI2yp6z6bbBurpuhDzRDlRDfPak=; b=e1D/G66ODEI/l9qYNS2O2FMFUjoVtOiDLhdiDAXY2zX50DR9cO5535ex3/1eGIhHjJzOGf cM0IbMVA9sBNTc52NqX3XkxsJPNOpZtnrtetgO9XAT6g+y2Pdr6S2LizBHZySgQSbTVz06 6ATuHQAguSFybSlXcqENCaZ0Rw6wFCI= X-MC-Unique: Ilkk5SmMOBWZ63gQ5ET9Zw-1 X-Mimecast-MFC-AGG-ID: Ilkk5SmMOBWZ63gQ5ET9Zw_1765793990 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell , Paolo Bonzini , Richard Henderson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Yodel Eldar Subject: [PATCH v2 2/4] tests/vhost-user-bridge.c: Fix const qualifier build errors with recent glibc Date: Mon, 15 Dec 2025 11:19:35 +0100 Message-ID: <20251215101937.281722-3-clg@redhat.com> In-Reply-To: <20251215101937.281722-1-clg@redhat.com> References: <20251215101937.281722-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1765794074011158500 A recent change in glibc 2.42.9000 [1] changes the return type of strstr() and other string functions to be 'const char *' when the input is a 'const char *'. This breaks the build in : ../tests/vhost-user-bridge.c: In function =E2=80=98vubr_parse_host_port=E2= =80=99: ../tests/vhost-user-bridge.c:749:15: error: initialization discards =E2=80= =98const=E2=80=99 qualifier from pointer target type [-Werror=3Ddiscarded-q= ualifiers] 749 | char *p =3D strchr(buf, ':'); | ^~~~~~ Fix this by using the glib g_strsplit() routine instead of strdup(). [1] https://sourceware.org/git/?p=3Dglibc.git;a=3Dcommit;h=3Dcd748a63ab1a7a= e846175c532a3daab341c62690 Suggested-by: Peter Maydell Acked-by: Yodel Eldar Tested-by: Yodel Eldar Link: https://lore.kernel.org/qemu-devel/20251210181306.926334-3-clg@redhat= .com Signed-off-by: C=C3=A9dric Le Goater --- tests/vhost-user-bridge.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index a5c711b1de8e9c164dd1614f4329b8e3c05d0402..ce4c3426d3938a0b54195f3e95b= b1f1c3c4ae823 100644 --- a/tests/vhost-user-bridge.c +++ b/tests/vhost-user-bridge.c @@ -746,14 +746,12 @@ vubr_run(VubrDev *dev) static int vubr_parse_host_port(const char **host, const char **port, const char *buf) { - char *p =3D strchr(buf, ':'); - - if (!p) { + g_auto(GStrv) tokens =3D g_strsplit(buf, ":", 2); + if (!tokens[0] || !tokens[1]) { return -1; } - *p =3D '\0'; - *host =3D strdup(buf); - *port =3D strdup(p + 1); + *host =3D g_steal_pointer(&tokens[0]); + *port =3D g_steal_pointer(&tokens[1]); return 0; } =20 --=20 2.52.0