From nobody Sun Feb 8 22:04:17 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1765390436; cv=none; d=zohomail.com; s=zohoarc; b=PYVdG1MLrQLKe8Svk92mCsDJ/+QBSUE9CsApnbKYsrtq8Y7vVPGQ+VB46R5ApnOFvJEPae2gj7WV7wRE/R6FA1jp596kotbEa/ySfN0T3y+KFvrLkC/pY4ORayFKmxOmnr+0IrL8pq2qxLmPYodruCVnvqE+9hjYCnb3e/Uz/pw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765390436; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gZAJ3vIVB4c/pO7qMkA/gIDQhHjYi7k2Ixt7ZFC/Jwc=; b=XbNcccJdpMHB8r9x2UW9yOYo3Rwh/NmGVLCXxRusn7JDzd7BoWZlWViyBS/V+rLRI+9gSqXWR9ZDCGm7EPzByPat7Cl0mTHfbKxr6yjHtDHdsoBR8mY1pGq75NLk6lSped14MbYgIQuo18ia1196XqZaTHV4/e/5MVnZgJ7z7nA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765390436011147.5977459110601; Wed, 10 Dec 2025 10:13:56 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vTOgl-00038S-EP; Wed, 10 Dec 2025 13:13:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vTOgj-00037i-Pk for qemu-devel@nongnu.org; Wed, 10 Dec 2025 13:13:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vTOgh-0002Mo-Tx for qemu-devel@nongnu.org; Wed, 10 Dec 2025 13:13:21 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-133-AkvxRUeNOTy59vSyoCQBSA-1; Wed, 10 Dec 2025 13:13:14 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6E1B9195606D; Wed, 10 Dec 2025 18:13:13 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DBE1C30001A5; Wed, 10 Dec 2025 18:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765390397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gZAJ3vIVB4c/pO7qMkA/gIDQhHjYi7k2Ixt7ZFC/Jwc=; b=G7bPdblKABCTJ2TlZafCWUnY7A0Vx8Pi/6yY58QTpif7wojmL4XjtyJLGa29Xr2wU1vXX/ +Rym0G0zk+arq9k0CwqcrULjZp1Qfx13uqlLEDfuwvBYuzMED335xFtS2KDoTMQ9xeTnNb XWNCD3gleR5DqUs9d5XlQxBe0APuq3A= X-MC-Unique: AkvxRUeNOTy59vSyoCQBSA-1 X-Mimecast-MFC-AGG-ID: AkvxRUeNOTy59vSyoCQBSA_1765390393 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell , Paolo Bonzini , Richard Henderson , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH 1/2] i386: Fix const qualifier build errors with recent glibc Date: Wed, 10 Dec 2025 19:13:05 +0100 Message-ID: <20251210181306.926334-2-clg@redhat.com> In-Reply-To: <20251210181306.926334-1-clg@redhat.com> References: <20251210181306.926334-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1765390437272158500 A recent change in glibc 2.42.9000 [1] changes the return type of strstr() and other string functions to be 'const char *' when the input is a 'const char *'. This breaks the build in : ../hw/i386/x86-common.c:827:11: error: assignment discards =E2=80=98const= =E2=80=99 qualifier from pointer target type [-Werror=3Ddiscarded-qualifier= s] 827 | vmode =3D strstr(kernel_cmdline, "vga=3D"); | ^ Fix this by changing the type of the variables that store the result of these functions to 'const char *'. [1] https://sourceware.org/git/?p=3Dglibc.git;a=3Dcommit;h=3Dcd748a63ab1a7a= e846175c532a3daab341c62690 Signed-off-by: C=C3=A9dric Le Goater Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/x86-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/x86-common.c b/hw/i386/x86-common.c index c844749900a30c9c9c284c529e93c84c9457b128..f77e2e63046ff56d079363e411a= 9ee0eca365291 100644 --- a/hw/i386/x86-common.c +++ b/hw/i386/x86-common.c @@ -654,7 +654,7 @@ void x86_load_linux(X86MachineState *x86ms, uint8_t header[8192], *setup, *kernel; hwaddr real_addr, prot_addr, cmdline_addr, initrd_addr =3D 0; FILE *f; - char *vmode; + const char *vmode; MachineState *machine =3D MACHINE(x86ms); struct setup_data *setup_data; const char *kernel_filename =3D machine->kernel_filename; --=20 2.52.0 From nobody Sun Feb 8 22:04:17 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1765390436; cv=none; d=zohomail.com; s=zohoarc; b=TSAGLsTiJOTc01tQB6gG8rITdyPCnDJsiCvS8/v20BvAv5p1m3t8UxDB8pYTYda9W6E+3XbxwR6fifLlflxFzhmhH5IsKI6bP5HVZSCZ+U9/qR3IXmNpe7X+8wg0j5PDOn7Yu/oxwUOGfW1d9Ow4d2zjrsPtodzpfLAvw8s9Vsc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765390436; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dBFE/InpbeedClIVHYgrgULwY8xVBWKs+q+dlMXxrcs=; b=IiwldGYctbAzzJACuxNFdJTfV8eSPeUbEnE48TsPGTVRxqxZUQ9W6zEd7gSWFJkbpukvJu6Jya1pPz2Z7sKwjipYuwgcg5lt8P3FqsS/WmDDtSxZdLr/FoRj6JEhmeYXSdJI2GSMFb+EAsVHqJZh2YkmY0jjo5bIb5PGJzNfCnU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765390436356556.5909796463623; Wed, 10 Dec 2025 10:13:56 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vTOgl-00038U-Sz; Wed, 10 Dec 2025 13:13:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vTOgj-00037j-TH for qemu-devel@nongnu.org; Wed, 10 Dec 2025 13:13:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vTOgh-0002N4-Rg for qemu-devel@nongnu.org; Wed, 10 Dec 2025 13:13:21 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-333-9pPOftjrPPiSjmibSEu_qA-1; Wed, 10 Dec 2025 13:13:17 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 157F318011DF; Wed, 10 Dec 2025 18:13:16 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1FAD130001A5; Wed, 10 Dec 2025 18:13:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765390399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dBFE/InpbeedClIVHYgrgULwY8xVBWKs+q+dlMXxrcs=; b=dM7I4bGi+ODb4OzouTXaO7rzHsl+e9HhBGa96YzubZBE7KG4lUXhZ0M+ZI78OxzVtk/4DZ FIQFo5o9M52ny0t7PNhZ/QlgfgAGUyWE1HL4Ry9fNmsw+ojZDjJ2Xoc/k7riJEpN4V99gr OVJVGpk7M1mQNwNRC/kmu4+WxPG6shE= X-MC-Unique: 9pPOftjrPPiSjmibSEu_qA-1 X-Mimecast-MFC-AGG-ID: 9pPOftjrPPiSjmibSEu_qA_1765390396 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell , Paolo Bonzini , Richard Henderson , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH 2/2] tests/vhost-user-bridge.c: Fix const qualifier build errors with recent glibc Date: Wed, 10 Dec 2025 19:13:06 +0100 Message-ID: <20251210181306.926334-3-clg@redhat.com> In-Reply-To: <20251210181306.926334-1-clg@redhat.com> References: <20251210181306.926334-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1765390437272158501 A recent change in glibc 2.42.9000 [1] changes the return type of strstr() and other string functions to be 'const char *' when the input is a 'const char *'. This breaks the build in : ../tests/vhost-user-bridge.c: In function =E2=80=98vubr_parse_host_port=E2= =80=99: ../tests/vhost-user-bridge.c:749:15: error: initialization discards =E2=80= =98const=E2=80=99 qualifier from pointer target type [-Werror=3Ddiscarded-q= ualifiers] 749 | char *p =3D strchr(buf, ':'); | ^~~~~~ Fix this by using the glib g_strsplit() routine instead of strdup(). [1] https://sourceware.org/git/?p=3Dglibc.git;a=3Dcommit;h=3Dcd748a63ab1a7a= e846175c532a3daab341c62690 Suggested-by: Peter Maydell Signed-off-by: C=C3=A9dric Le Goater Acked-by: Yodel Eldar Tested-by: Yodel Eldar --- tests/vhost-user-bridge.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index a5c711b1de8e9c164dd1614f4329b8e3c05d0402..ce4c3426d3938a0b54195f3e95b= b1f1c3c4ae823 100644 --- a/tests/vhost-user-bridge.c +++ b/tests/vhost-user-bridge.c @@ -746,14 +746,12 @@ vubr_run(VubrDev *dev) static int vubr_parse_host_port(const char **host, const char **port, const char *buf) { - char *p =3D strchr(buf, ':'); - - if (!p) { + g_auto(GStrv) tokens =3D g_strsplit(buf, ":", 2); + if (!tokens[0] || !tokens[1]) { return -1; } - *p =3D '\0'; - *host =3D strdup(buf); - *port =3D strdup(p + 1); + *host =3D g_steal_pointer(&tokens[0]); + *port =3D g_steal_pointer(&tokens[1]); return 0; } =20 --=20 2.52.0