From nobody Sun Feb 8 22:46:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1765310797; cv=none; d=zohomail.com; s=zohoarc; b=Pnk29WYzUPSEAOrbvDRtpe/d8VCfR9bLfqPhLqnS+mvibyjLqgCeoMgh7QM/Cx/v3wgQU1kljPI6oGycGDwqiBaGb1qwgguIlvF5YUE2uAS9s9lKyEaKYf8iXkklXppOivIHgkAYvdnINs112M5DhXwvnZxD+lQ8VfYVjhl7p2Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765310797; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=SfmQi/8MCkxDKQ5GKF/OmaXAKzuZuaBcOR9eCv28OlM=; b=S/Un1rl2KwkiuPxxwcmZLMmEbNq/8PxoMeqIAjYK6lLbopFoOOt1G60J4moWwJPEewk9gkBLn/iv/NzzWZb+awbe+ojjpf/9BQuU+u/hGUyv/qmb/1Yl80R5GSxtgmCDG0LseW2gEAAAGsp2VmflNnP1PR0GCtRbct66/+goFCg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17653107976192.666106273407536; Tue, 9 Dec 2025 12:06:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vT3y2-0000pd-5f; Tue, 09 Dec 2025 15:05:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vT3y0-0000p7-Tk for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:05:48 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vT3xz-0001HP-8b for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:05:48 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-477aa218f20so40727055e9.0 for ; Tue, 09 Dec 2025 12:05:46 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d3319ccsm32599801f8f.34.2025.12.09.12.05.44 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 09 Dec 2025 12:05:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765310745; x=1765915545; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=SfmQi/8MCkxDKQ5GKF/OmaXAKzuZuaBcOR9eCv28OlM=; b=WdYY7noOp148pdotcHb7rS4YZEVLMiAqMzWjM6RSrSseoI6TRKX3ityPkmZqn4mPf5 fZtsVgEQX+IXoXaOARA1fFFJ5McQyJ8rFjrdHLqK2prknvjEGPwY0kzwJKETdm+O6Fyn WGIGQgfRFHwXuTdn52eo8TsDFBdTewWxAGUp8YWHvnHHVqGeb6JbOOb7WNIoaLjIiAYv 1iGjQCbNYHKzYAO4I3iYWXwAauD1qQCQ6iAPJ/7a7jO3T7AIzFDeEgSYxuwojsdhHR6F CB9rHGTiYJk82+mzjgMoU35ysOqoi1fjKeXQGa9skypA+YbkAiSsyxo2eiYGhMpKV1zf PTsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765310745; x=1765915545; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SfmQi/8MCkxDKQ5GKF/OmaXAKzuZuaBcOR9eCv28OlM=; b=VeJSHE8bsQ8lcxN7OtWhu+MR017caLxQeNKBbrY9065Cv3YDOThtKeH7BouO/gZeeL /xGnqcBJ5dBMHQ+f2vRv3ya86xfHmLo4w5yIiSh7MtOPbmTzVnLwy20Ls91CXbB43Qos xhATk2550y83H6Ba6WYSDa0aEb3qYSgQMZzwLmtTR02dzeAdqPZX68lg6iB/TWdRJIq1 DlWN1E+wIGrjM5059R1IoqjeTAYdrOClI6Ivu/xv7XVblL9ejT+Rhfg+IR246y1TESu5 sM8w+qB5rG7te3p8fcCknGrO5Abaiam5BYav3t8UXgWOuuyxCZcMgB0nUnbH2B6uZhtY kmYw== X-Gm-Message-State: AOJu0Yx2B8TugxTupBXkgsH5jAg+c40CSsu59RzXaW+w0l8el5ODAWv2 bnl7iy/WN7W13+LLKwlHnPfx84I2jdhT+VCKCax448EEHT5hmlPC2oFkj0KXbcmChlh0rcPTAbt IiEfHAMw= X-Gm-Gg: ASbGnctVs2Dkt8CJy2JDFyeX/9t6AOD0sSeY0DMyTwG/a2283sIKJfQX2OEVEEA5uqv s5hGOw2ev3gsqeh7KvLpWRCQnx79lCFwsDW3Zngc4XqSV5SsGC2aIe65WF69xgDMY5wFo7Qar5X ZFgqJgHsgnEA5CKWxC9JvHWtIATn/UGPoZ8Fso16QcOk7+1lY/v2Is2CfZSQtEl7fiWJS+pMBEq jvDgy259OfCjxUJb7RVBDzlG5gQt/QHoIkUsSwAdIJxM7NDazfl1uWCEPVWg4VjvuUpagr9noP+ b5L3vRjmv6JTVyHCnuJTyiVOqz5OCxEP3oGzzpnCenPmRtjExsj6k2higz4O3j6QMG9hIzUyh2J epqOgwK32LIX4EO8DYmAu3gMD8b3AkVDDuRPCwEpohvnfyMcCqhyANIyvxPSw/LPQJKwI1jHIrP xChVs3d9M7S2yRUb3IrO8xvgDQYwyEB31Dv4uhbCzcN3H/0WQB6vdv5bCdLFeD X-Google-Smtp-Source: AGHT+IHdVsjHDCu5ydRC4r4w5ig0PJvy2F3souQCoX3QPMUYm+GtwZYSugWErt0VahtJL1mfaSOi2g== X-Received: by 2002:a05:600c:528e:b0:46d:ba6d:65bb with SMTP id 5b1f17b1804b1-47a8379b9demr909685e9.31.1765310745312; Tue, 09 Dec 2025 12:05:45 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 01/10] osdep: Undefine FSCALE definition to fix Solaris builds Date: Tue, 9 Dec 2025 21:05:28 +0100 Message-ID: <20251209200537.84097-2-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251209200537.84097-1-philmd@linaro.org> References: <20251209200537.84097-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1765310799086158500 Solaris defines FSCALE in : 301 /* 302 * Scale factor for scaled integers used to count 303 * %cpu time and load averages. 304 */ 305 #define FSHIFT 8 /* bits to right of fixed binary poin= t */ 306 #define FSCALE (1<esz], a) | ^~~~~~~~~~ ../target/arm/tcg/translate-sve.c:4249:1: note: in expansion of macro 'DO= _ZPZZ_FP' 4249 | DO_ZPZZ_FP(FSCALE, aa64_sve, sve_fscalbn) | ^~~~~~~~~~ ../target/arm/tcg/translate-sve.c:4249:12: error: expected declaration sp= ecifiers or '...' before numeric constant 4249 | DO_ZPZZ_FP(FSCALE, aa64_sve, sve_fscalbn) | ^~~~~~ ../target/arm/tcg/translate.h:875:25: note: in definition of macro 'TRANS= _FEAT' 875 | static bool trans_##NAME(DisasContext *s, arg_##NAME *a) \ | ^~~~ ../target/arm/tcg/translate-sve.c:4249:1: note: in expansion of macro 'DO= _ZPZZ_FP' 4249 | DO_ZPZZ_FP(FSCALE, aa64_sve, sve_fscalbn) | ^~~~~~~~~~ ../target/arm/tcg/translate.h:875:47: error: pasting "arg_" and "(" does = not give a valid preprocessing token 875 | static bool trans_##NAME(DisasContext *s, arg_##NAME *a) \ | ^~~~ ../target/arm/tcg/translate-sve.c:4205:5: note: in expansion of macro 'TR= ANS_FEAT' 4205 | TRANS_FEAT(NAME, FEAT, gen_gvec_fpst_arg_zpzz, name##_zpzz_fn= s[a->esz], a) | ^~~~~~~~~~ ../target/arm/tcg/translate-sve.c:4249:1: note: in expansion of macro 'DO= _ZPZZ_FP' 4249 | DO_ZPZZ_FP(FSCALE, aa64_sve, sve_fscalbn) | ^~~~~~~~~~ In file included from ../target/arm/tcg/translate-sve.c:100: libqemu-aarch64-softmmu.a.p/decode-sve.c.inc:1227:13: warning: 'trans_FSC= ALE' used but never defined 1227 | static bool trans_FSCALE(DisasContext *ctx, arg_FSCALE *a); | ^~~~~~~~~~~~ ../target/arm/tcg/translate-sve.c:4249:30: warning: 'sve_fscalbn_zpzz_fns= ' defined but not used [-Wunused-const-variable=3D] 4249 | DO_ZPZZ_FP(FSCALE, aa64_sve, sve_fscalbn) | ^~~~~~~~~~~ ../target/arm/tcg/translate-sve.c:4201:42: note: in definition of macro '= DO_ZPZZ_FP' 4201 | static gen_helper_gvec_4_ptr * const name##_zpzz_fns[4] =3D {= \ | ^~~~ As a kludge, undefine it globally in . Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20251203120315.62889-1-philmd@linaro.org> --- include/qemu/osdep.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index cf8d7cf7e61..3cb45a14678 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -141,6 +141,12 @@ QEMU_EXTERN_C int daemon(int, int); #undef ELF_DATA #undef ELF_ARCH =20 +/* + * Avoid conflict with Solaris FSCALE definition from header, + * but we might as well do this unconditionally. + */ +#undef FSCALE + #ifdef CONFIG_IOVEC #include #endif --=20 2.51.0 From nobody Sun Feb 8 22:46:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1765310809; cv=none; d=zohomail.com; s=zohoarc; b=Vwu0FmMB5eZ38BMp/v0bi7SSVI0BEukJsGRVbraJ7xyb1uA0azdoCTHj0HkNnIvd7eSaNkfzDrWnuh99wyLfOU22w7xM/y/J79BJrETD/fLrpkjrNHcnPpryuqQCRqIcUacvCfxD6wmAnrfSvozUb4ni9+3l/XM9vAUyreBZnm0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765310809; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=2HB3vg2EkQ9yT72tK5H3rWvhcfCnwT+b44I6/a1Vbyo=; b=CPROpt40fmpaxgXkwFseMPFAJeELBhcLuJcuQfMK1E3PbTjf8IlpJCBLsTv/f0hah2Itz2yCuJj+gkZbtewZFa7Jxi5Bfql9bjPKJNIN6+PXXZb6VogrAa5ri8210l2DK/RFek3aICEWCu0Um4t/3EN2D4k2CJTL9cPHiny+jn0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17653108096841015.3720440043892; Tue, 9 Dec 2025 12:06:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vT3yA-0000r0-It; Tue, 09 Dec 2025 15:05:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vT3y7-0000qi-GC for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:05:55 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vT3y6-0001Hk-1n for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:05:55 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4779cb0a33fso80284935e9.0 for ; Tue, 09 Dec 2025 12:05:53 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7cbe9032sm31371921f8f.1.2025.12.09.12.05.51 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 09 Dec 2025 12:05:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765310752; x=1765915552; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=2HB3vg2EkQ9yT72tK5H3rWvhcfCnwT+b44I6/a1Vbyo=; b=fg6yAhiTBqJ8y75iiMJex2HCXBasvqNQRWWmqk5+JIvYzyRPjsDxuXCBV/tDyXkbrV n7/uCb6Cf1p3AKM1UaPsXNt4EzcCLTkS/lAXimi6EgzA2WCZxOkLYbTCnp795bEmit7O aPkkqXb+GmNdZGofvaAVuo8QBSnyDvnnm2Z8N+EJ3GHr4phnconNfl7NrOjq7h+U04ls ehjc2g5GDkmtKvdFMV0bX89zupiR7dQ3oDDsHqpzopMFmvrv6Am8sdls107Gtz9cxaMN whAL05FIZKuT+eQ3xOAGCpHU4sOenhPryh6WSvgPZXZbxZI8F+cudD8mci3pC7tI/Ibt 5MRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765310752; x=1765915552; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2HB3vg2EkQ9yT72tK5H3rWvhcfCnwT+b44I6/a1Vbyo=; b=QEjwD6HD5hstdrxy1LmnndXzDUj0FRdMt2LWN8f17uGJeHv0AHcbniu3ekf/8GvZGP 3xHNO32lKoRHeTF17zUWHJYjooWSnkKBm+Izq5ubihdxS1bSEnX7g/fCmv9NsDC5+9eX dL39lTe4ERW1QEganSOswxlJDZIKgKtVWFJkNBzUWPA4/iM8ENeIHy2E+RKq1fkbTeJK JlkrxG4LHYlFyrAZozeQSUw8bZ+sLzreAB1RfXIJ2zv5o9OXMIXJIml33WAHt16wyTq9 86ZRurcvw14lR5JnHapHnogQGb5BO/818nz6tKJfm8jKsI2jpXGgA1PZDbdsCOZDXVxS 4Ssg== X-Gm-Message-State: AOJu0YwkcUS8hfO3PyzLBh9FWgnuEKfP0S3BqZNTOi8JsGL1Bd+t1ztz /U6PIL0vylT/KU7tRRJBC/6O0/WW4W6amYYl5aKNlKtocjFsfZfPCEjpi0w5XMUbB0/KdbHOpe4 mvmnqKk4= X-Gm-Gg: ASbGncufS/a5E4RZgGp2EA8nvEj2M+76hOk03SQE2SvfD3zwH6YQqnE8yAzB2pA6MBB Q41jXVLCWtsUwN9tkE8r6mulGptl1aHq0HLriZ+if7/UUc5OWo2Vd56HzbwkSgahplXdiyTQi92 Nca7/ytZ69n9npsnoMrkvwdV8XZG6GMWXQG9qTiXADPQOkgDRjJo1nXGqb+nFfgI+N4aMzTYwx7 uLi5CCGYoCzZHx61JERcAN97kR4LkVFtLCxFtlh/X853tfx9eqACzpSuyAozovSpEHzSm734Pgg YCmDL582jTkGK51R3+DmA/W1Z4a1sdSw5It5+ed3HlXxUYV5a7fNj3gzXW+exivrmRSQLTPBvAL Y2B1xerbvLSswNm0oz2VeWZ+LMRQH0723zgan4nGqngT6SGqPxBSxoBUAFRZp2UnvocpoN/gKJI wGgmT2CW15fBxNxdfJ5X43V56YDt4KBlq7Q4rqTwY6k4nktvJsyULGsXrnVpOA X-Google-Smtp-Source: AGHT+IEa6Iw5zchbaYwHB3IBTlt38CXAVaJIpbUXld5Wl842kKXvQK8l2M9aASaA5vL2wfAMLZXBOg== X-Received: by 2002:a05:600c:a48:b0:477:7cac:508d with SMTP id 5b1f17b1804b1-47a83814829mr697825e9.16.1765310752026; Tue, 09 Dec 2025 12:05:52 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 02/10] hw/9pfs: Correct typo Date: Tue, 9 Dec 2025 21:05:29 +0100 Message-ID: <20251209200537.84097-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251209200537.84097-1-philmd@linaro.org> References: <20251209200537.84097-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1765310812194158500 From: Alano Song Correct comment typo in xen_9pfs_bh() Signed-off-by: Alano Song Reviewed-by: Christian Schoenebeck Reviewed-by: Thomas Huth Message-ID: <20251202132132.17636-1-AlanoSong@163.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/9pfs/xen-9p-backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c index 79359d911a7..ca0fff5fa9b 100644 --- a/hw/9pfs/xen-9p-backend.c +++ b/hw/9pfs/xen-9p-backend.c @@ -310,7 +310,7 @@ static void xen_9pfs_bh(void *opaque) =20 again: wait =3D ring->co !=3D NULL && qemu_coroutine_entered(ring->co); - /* paired with the smb_wmb barriers in xen_9pfs_init_in_iov_from_pdu */ + /* paired with the smp_wmb barriers in xen_9pfs_init_in_iov_from_pdu */ smp_rmb(); if (wait) { cpu_relax(); --=20 2.51.0 From nobody Sun Feb 8 22:46:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1765310882; cv=none; d=zohomail.com; s=zohoarc; b=e5122MjbgTl7/+xS4T9jdcCjha3t17dh4RFSWg70UslPYRBtTj2LjxtmWAcyU4qM9yUpMRYJCNlrQdVuT9hudGq9usyu1zvByVwKzI1gQZoCiHndVoJVaEjAh6VfsIxNDOwkl+VqbdYKutRRpBku1hRzY1/zHoc9kfPXh7p7ZTA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765310882; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=nV8HsfTtIPwCBLUDWBKBG2A2y3njTaM32r0hbYhDIlk=; b=XPh+l1R0YTvyrAqIa0YkP74+p2roU4COSjLuDGbmlxY8jbZWf6Lbhazd+nggnoyZx7EayAE6MkcLqIjtijKwEORIl6OOOhZ0B+u4N/IT4F+Xcvhem1PZdzJ3I4quiMru1DyToUaNud2bcQjWLGDnqNY1zQoc9tb6hrYwgqz5GEQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765310882630437.88255543538764; Tue, 9 Dec 2025 12:08:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vT3yM-0000wf-91; Tue, 09 Dec 2025 15:06:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vT3yH-0000uM-Kk for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:06 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vT3yC-0001IP-Up for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:05 -0500 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-42e2e52cc04so2199374f8f.0 for ; Tue, 09 Dec 2025 12:06:00 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7cbff320sm33805663f8f.18.2025.12.09.12.05.57 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 09 Dec 2025 12:05:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765310759; x=1765915559; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=nV8HsfTtIPwCBLUDWBKBG2A2y3njTaM32r0hbYhDIlk=; b=Ti6VwvMXohOaTe8DqlJzMmH5gPy41t1QDeLBsBgSkn5FAaYbG0WZiu8RksKO1qmLIe M0LlbQGvaDUd6NxVK44uwGO4BJ0kSU0gjyRaDQ1gSlOpIZP+RXbSyeUJ6Y5uJ6yEbAly DKI9z69WqJEzjvFts7Tw3K/FdoghIfIyaS+a1elyFs3rAOFRlGB0zXk7sEzeaFrUFa/Z IuOp/dVvQdTar8/y4HIv1rcEG+PS8d1MbzVcp9ub1pddlHtjqtaeDBq33oB0wroanezS DONmGQhg7sT66tRIUh+1K6HUGmTc7i7fiy10Id8GSVm2qNt5/Nw3zP8q+zwGHRkJc9vA sAuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765310759; x=1765915559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nV8HsfTtIPwCBLUDWBKBG2A2y3njTaM32r0hbYhDIlk=; b=V6AftGirizoztfiTj0cYLNWM+7mOelBb6dwssugb9shaz8a/y38YruXjgo/PaUdprP 9dw7gAHn4NECF8w/sMULPMrSL0Y/qpVZOz2KkQyyDhIcpZVb76Y2ZVIeYhwo4IbmzFQG JWfQ9MhgautznsmrpMV98RgGPKIFS1Flkqgwb0efG3c5l2QsxeU+0XaCV8PsO7AjLWYj dvyRqmoq3MXnMeEp5Yd6dHpC+HHc4JTk2itrNpnFZUG++CUsdmM5sKwS2BP12Wx/hQiD 1ThMY0UgTHTylkW42esfJ9MuI3fZ9vqL24Biqy1eLc7RX50jLLTkJQnS7OiP68Gkxzt7 C34A== X-Gm-Message-State: AOJu0YzsHsFmx1eqw7/9v8LyDc6Sgg/HBREfPo93/ODNTruXu99mPisx cfR5GQhJZmL/OL96yuNXSDtj5h4OkGl71d1LDPzsy0hQ5O03SmMVHha/H8Jctu6EUsmpyXflVGM WyC9BzeQ= X-Gm-Gg: AY/fxX6JxRbKgswyPfA9M0BLRmOEmX/nxiaM9Kw2S7LO78d3z0LHGS9X4HxAPGUgSFn Dymn3+RDa9lNs1rbqQTmdbTnzkuYI6RC1H+nFemOWGrgjeGHNuFWgGPerTw3qyuYpEO9jtGZQFx 8gT9uSlhMRaZyRKDYzCizsiP3nbSd/Wu9Xl7ipERLdUSyXAKnKrMuwKpi1shZI+Yo8t2NJ8sWg6 uYZJl7UclmJqK6Vaphz6uIqbqTtyY19SqU/NeklCAaj5ilEqCO3BU8XruXk52zPlhDSCO2XYp2A 2vHH82BkuHizAsTtediKqyVL+lcVwaxRG9rfKFqmgBWso3vBuQI/o6T9vSGBiUKMYBcDz+ez5Ad 3ai2VPbKoyGJo6vWW+95VQlbn15JUD6BNJelFrenNGZIcxmfLCYMWmN4YT5JRWZK0S9sggOROvD 1uZ+/T5O9QhvTa9PTwYwKkhacdrp42YoWDcrAE097RO2SzxqSNkV5OsxD7Eaod X-Google-Smtp-Source: AGHT+IH2cw0I7SJ8QFCAtnolhyyiDtxvuDawq/k5wAma/6zi8x9yhItqbLibLU6a+hfr+0eSl4HBbg== X-Received: by 2002:a05:6000:2508:b0:42b:2ac7:7942 with SMTP id ffacd0b85a97d-42f89f0fafcmr13391482f8f.5.1765310758675; Tue, 09 Dec 2025 12:05:58 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 03/10] scripts: fix broken error path in modinfo-collect.py Date: Tue, 9 Dec 2025 21:05:30 +0100 Message-ID: <20251209200537.84097-4-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251209200537.84097-1-philmd@linaro.org> References: <20251209200537.84097-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1765310884483158500 From: "Denis V. Lunev" sys.stderr.print is dropped long ago and should not be used. Official replacement is sys.stderr.write The problem has been found debugging building on some fancy platform derived from Debian. Signed-off-by: Denis V. Lunev CC: John Snow CC: Cleber Rosa Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251203220138.159656-1-den@openvz.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- scripts/modinfo-collect.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/modinfo-collect.py b/scripts/modinfo-collect.py index 6ebaea989db..db78b16c1f5 100644 --- a/scripts/modinfo-collect.py +++ b/scripts/modinfo-collect.py @@ -41,7 +41,7 @@ def main(args): for obj in args: entry =3D compile_commands.get(obj, None) if not entry: - sys.stderr.print('modinfo: Could not find object file', obj) + sys.stderr.write(f'modinfo: Could not find object file {obj}') sys.exit(1) src =3D entry['file'] if not src.endswith('.c'): --=20 2.51.0 From nobody Sun Feb 8 22:46:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1765310885; cv=none; d=zohomail.com; s=zohoarc; b=L+mo+nbzAs+FsVlEVLCYW+g/UP7zhqDaJoNE1X1WqkMeg+MEHFZo3OEaLaaLYb0CJj19ErCWMXjTyleX8UxCf6PA4Q9FT059j3eRp5IJAapssUAvwPTl3ah3oMBDfXhsRZoGAcNrPRaaB7cGRcWAt2WGv9ix4szJz0OvraD0jjM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765310885; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=2TsH1QuOfILL0JbSzIZnX8n/oioAmO7Rffye27/Lbio=; b=NR0JI4m9BNgXktFI4kqgiQ/3Svi5TFQQqJ+NkyW0BgVL3FDDS5Dv2fb+y8tpaZWqHJGXeImH/B2Y8HMf9nx0wjJXl3s0Vy/gpR0ON3jGYpuI8bhDzOCyFjqqh3QsNMDKQC1VpDDoOPh752e5SwyhOSREwM0QjRnH4lKpdgW8iIA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765310885241938.567120361339; Tue, 9 Dec 2025 12:08:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vT3yP-000136-57; Tue, 09 Dec 2025 15:06:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vT3yL-0000wj-R6 for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:10 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vT3yK-0001Ix-5K for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:09 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-477b198f4bcso52820015e9.3 for ; Tue, 09 Dec 2025 12:06:06 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a82d7efdbsm7210075e9.9.2025.12.09.12.06.04 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 09 Dec 2025 12:06:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765310765; x=1765915565; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=2TsH1QuOfILL0JbSzIZnX8n/oioAmO7Rffye27/Lbio=; b=wBAtmHHOEVkFmSK5i8dduhuRx6ujtDU8xUvIC9mkLV+AMWrRAIX7cqUVBtbPRQnroy vTJDrMvKU9MGTpeBmEi9OzRdqzWx/C1vlLcudTR69GwC2IhVFeV2GwanJ/OMsVzz1UJ4 DDAfXkOICSpWdUZwQaZrQ5TqERnlrRxB5vrpAHnzJR4X0L4uP/LFriSjTesraeJlqIA1 0oK/qzE8HvYMZnKxLKsUwTV+ZuCixcGBOOrOQgMyUBqAXTDZGRoZljdLOX4bco1wMB0v QohpGkbwDlRNgi2gt3/wsF+SR5A02ds5BlHgRl7YVklfIxX/ArnxN2F6ea4sRVtLWDfz jlRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765310765; x=1765915565; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2TsH1QuOfILL0JbSzIZnX8n/oioAmO7Rffye27/Lbio=; b=jsCBR+h6ESv2emR/VV71l2ILKv0EFk4geYaaUdxsz5mJf/qdHLrMbVzBnrttZcUhDI l/+8hIHeZIONiKpNEZpxH7Uls9Q3JuCj6cpVNe/j6moFxmJ9oIjEYHegMIUEYf4HzsJ9 1qfk6pBa5wOo3bGcg0iJUSxVh/pi7Vfz3zmE4zF6QYEiYBvBvAF5juAOeEk7yAZKbU+E Eyacd+gumVWVhyaIKxyFcERXUdCzIs9pkc4a/VEVXDLVFZz6SulHy3/FyjSLjYJOTAjb ZaOEl+aDVMBGA/4Vy0Gd9Xeb0TVL9W2l2f9MRlZ5guNq27Bp1Qdcfl/t6mj/FlTchIWE gcdQ== X-Gm-Message-State: AOJu0YzQ+eqNIKp7aLTdPs5BqGDn2hzeqvvPdFStPM8vkiMXT8VNmsmc DPjB+q/OpzFSPrkZoqwhy2H+YrjD1Xy00B7JCxe42p11VTVsJ1XXnEpKW/+jXwPZLil2i6tmsLt qFQrs82Q= X-Gm-Gg: ASbGnctSFuqA56vYNo6OTeh+TLV2QsEhrCXXuVDJ/16UMJ9fPfKY9mk2KbEVr2LDQSG KpavFZns4kEGqB6vaQgAlOAE3qlGBizVYyhRpdIzMGnwJNc/Tf8eGgdmP1vvYvU2ayFxqrC/UOI 2KmassJaDBAJcnxJGBvmYAyeD/DeKEm8mnq52J1GiQlE2yzj0uuq+S2SQhF3VnHol92UpOOUqFk V8geQpJT8mbza08Ma1xnXh+UHyikSrgydaSCi7G0slUCswiiT29n2MsSbGQp9edc6bC3ILTjQ2t MHEZSMFqB6+4SawgAATxF3uoG/rgE8CNI8p7f0Y0BkEeUcTpH8hpDsdLcXbmsiNzPzbnryAjQja bYL1oqy5rTIuqLpBw/mbLJrgBrbjqfs1gTrH4AGEVXj0Cw/HqkeKeIYP+P5O7mOLm+5DWbnVEvX d4Eg22ICHfnuGNBa4qr7QUqT7ffX3konWVN3nHzJUxdZLwFFYyeAa3/kMj4/LP X-Google-Smtp-Source: AGHT+IFqxVth0wnzVr6cP3Ln91muyD60oO13YIgzEwHN5xCcbtD90JjCM8YWvRvNdn1b8nltbVnIhA== X-Received: by 2002:a05:600c:3496:b0:477:333a:f71f with SMTP id 5b1f17b1804b1-47a83790c18mr968935e9.17.1765310765285; Tue, 09 Dec 2025 12:06:05 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 04/10] vhost: Always initialize cached vring data Date: Tue, 9 Dec 2025 21:05:31 +0100 Message-ID: <20251209200537.84097-5-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251209200537.84097-1-philmd@linaro.org> References: <20251209200537.84097-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1765310886304158500 From: Hanna Czenczek vhost_virtqueue_start() can exit early if the descriptor ring address is 0, assuming the virtqueue isn=E2=80=99t ready to start. In this case, all cached vring information (size, physical address, pointer) is left as-is. This is OK at first startup, when that info is still initialized to 0, but after a reset, it will retain old (outdated) information. vhost_virtqueue_start() must make sure these values are (re-)set properly before exiting. (When using an IOMMU, these outdated values can stall the device: vhost_dev_start() deliberately produces an IOMMU miss event for each used vring. If used_phys contains an outdated value, the resulting lookup may fail, forcing the device to be stopped.) Cc: qemu-stable@nongnu.org Signed-off-by: Hanna Czenczek Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251208113008.153249-1-hreitz@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/virtio/vhost.c | 38 +++++++++++++++++++++++--------------- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 266a11514a1..e654ea468a0 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -1261,7 +1261,7 @@ int vhost_virtqueue_start(struct vhost_dev *dev, BusState *qbus =3D BUS(qdev_get_parent_bus(DEVICE(vdev))); VirtioBusState *vbus =3D VIRTIO_BUS(qbus); VirtioBusClass *k =3D VIRTIO_BUS_GET_CLASS(vbus); - hwaddr s, l, a; + hwaddr l; int r; int vhost_vq_index =3D dev->vhost_ops->vhost_get_vq_index(dev, idx); struct vhost_vring_file file =3D { @@ -1272,8 +1272,17 @@ int vhost_virtqueue_start(struct vhost_dev *dev, }; struct VirtQueue *vvq =3D virtio_get_queue(vdev, idx); =20 - a =3D virtio_queue_get_desc_addr(vdev, idx); - if (a =3D=3D 0) { + vq->desc_size =3D virtio_queue_get_desc_size(vdev, idx); + vq->desc_phys =3D virtio_queue_get_desc_addr(vdev, idx); + vq->desc =3D NULL; + vq->avail_size =3D virtio_queue_get_avail_size(vdev, idx); + vq->avail_phys =3D virtio_queue_get_avail_addr(vdev, idx); + vq->avail =3D NULL; + vq->used_size =3D virtio_queue_get_used_size(vdev, idx); + vq->used_phys =3D virtio_queue_get_used_addr(vdev, idx); + vq->used =3D NULL; + + if (vq->desc_phys =3D=3D 0) { /* Queue might not be ready for start */ return 0; } @@ -1301,24 +1310,23 @@ int vhost_virtqueue_start(struct vhost_dev *dev, } } =20 - vq->desc_size =3D s =3D l =3D virtio_queue_get_desc_size(vdev, idx); - vq->desc_phys =3D a; - vq->desc =3D vhost_memory_map(dev, a, &l, false); - if (!vq->desc || l !=3D s) { + l =3D vq->desc_size; + vq->desc =3D vhost_memory_map(dev, vq->desc_phys, &l, false); + if (!vq->desc || l !=3D vq->desc_size) { r =3D -ENOMEM; goto fail_alloc_desc; } - vq->avail_size =3D s =3D l =3D virtio_queue_get_avail_size(vdev, idx); - vq->avail_phys =3D a =3D virtio_queue_get_avail_addr(vdev, idx); - vq->avail =3D vhost_memory_map(dev, a, &l, false); - if (!vq->avail || l !=3D s) { + + l =3D vq->avail_size; + vq->avail =3D vhost_memory_map(dev, vq->avail_phys, &l, false); + if (!vq->avail || l !=3D vq->avail_size) { r =3D -ENOMEM; goto fail_alloc_avail; } - vq->used_size =3D s =3D l =3D virtio_queue_get_used_size(vdev, idx); - vq->used_phys =3D a =3D virtio_queue_get_used_addr(vdev, idx); - vq->used =3D vhost_memory_map(dev, a, &l, true); - if (!vq->used || l !=3D s) { + + l =3D vq->used_size; + vq->used =3D vhost_memory_map(dev, vq->used_phys, &l, true); + if (!vq->used || l !=3D vq->used_size) { r =3D -ENOMEM; goto fail_alloc_used; } --=20 2.51.0 From nobody Sun Feb 8 22:46:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1765310797; cv=none; d=zohomail.com; s=zohoarc; b=e6BhqcApV1vLnkmlSg59Cr6koei19h0CmJcDATtnpehZGdgqB/N9DyhTMSrE1SSXXKEHKOLFtvIQS6TP+Gb08VmnTVcHAnq/Iomk4y3hpzFJJZqKHfMxPvTGQw8P2dmUH4NK3/kAaGePvFmZXi0eTyIvODq+KB7wC2nFNKbnK1E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765310797; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=c+XhViGePU7FVlwUFzwVc9jH+z21suBf3LC87dmzJlc=; b=crwlkf/eV1oDwpUt6mfywRsQX+p9Rd8SHHAiSKpQBpAZPAZ2V28lIrrqGfKZDOYUeGPXZg56ZrXgVb9p2s4/I1hDLMFmOlzakKmP9pD+Scl5+iDgCe5yBAGy9cpxIIV/R6xkZugjhJNRBbSFeccbDV3swfvLJW0kNyvQZ/g+cyo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765310797014263.40635051792356; Tue, 9 Dec 2025 12:06:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vT3yU-000151-Fb; Tue, 09 Dec 2025 15:06:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vT3yR-00013D-E4 for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:15 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vT3yP-0001JL-Tq for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:15 -0500 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-42b47f662a0so97715f8f.0 for ; Tue, 09 Dec 2025 12:06:13 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d222506sm35630666f8f.28.2025.12.09.12.06.11 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 09 Dec 2025 12:06:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765310772; x=1765915572; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=c+XhViGePU7FVlwUFzwVc9jH+z21suBf3LC87dmzJlc=; b=w13Tu4tK8PuWEcRVtwPhkaFJEM8ikWbt6hSg+E6zPY75DIV4TSzlPx7HE7NbxWVYH3 c8rjnqVzrdLT8SifGiMaA69hH7SlVxWds0J3Byrk4H6FYOO8nObYhfjr49/6/Aq2ycci eZCEWp+qLHWJAZJhKnaXxoT302GVp2vIYNOrRu5SU5T6ED9NTh8Xjw51moViNp9UOOxK /nP/HJrkCj2QvgIWp5rGQFQ6CDY915PlAI8irL6I8b8a1aMI79Isfb0x+XzZ/jZ7sR65 KOa6VJ/5A6/eVFZNFNxKyi1IOOzC8OGSOgHcoS/Hyb4NDN1XrCPCjBHiPqLlnOqFLiLv Ly9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765310772; x=1765915572; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=c+XhViGePU7FVlwUFzwVc9jH+z21suBf3LC87dmzJlc=; b=JWoAhtVWc2iwM55AO3/dA5W1VO6FaM6/RFC6OTL53kJD/15sgP4jVVZn6RZFLF9yNr mADB5TjRTXcvrDVD2GKq+KpIl8r7XR5Vr2bC5OmeKEOMwYayYtKbfg/JISWSmVG5hFbm kJQ0mZBfBOku6r54sZU2k5YJDEnHhqBKqEuLwUQe76Fy/MEgJ2ZACJBXikgAb7G3EmcJ p7sDzxzjjBpiUZvK/Hc6rciHu9uqa++VJ09juNxsKM+XDsoGAjTgSf84BSo8P79VZfxy gUzW2L43VyUPrLOHQyqlfw+hQm+fmFhByhhHEpz3MPoibvKL46JN1pP7OlYEZKpNDtfs /6Qw== X-Gm-Message-State: AOJu0YzM72KbWu0fn+2JhcKV6ILwemGPWUnkJEna0n35HhgPYQLr0P0C 2nqPcn8FbHVIJthkeT9U9X5AYWVuTy9vdIPQV10H+EufqXPUmacNdcnFeEvu0ISH0gHRNLB47M0 J7320cek= X-Gm-Gg: AY/fxX62d5l6TQ0/F1A3OuVD+AI5vGQrhechLgW4luoe5YWxU3tKvK8WrVvBMVPBQKz hzht88JEa7r+ju3VsyniEo9w+wKp6oXhlGlwUSrl/VNvyzIUhjvI0CHWSbTHSo0pChBCZhNXLDl ATdBQaEb4ZzBAH1jYwA0uZu2Psc1Nnjqw8RLrGYt+vVKJqmkZ8gugnOdgXEZX4ZpCkBEe1yJAzC dMqTV4ghRAhTFjtMkmA6rw1CJsln5/QQge6VPHmSGgghUBM9nUVl8eLcVEO31XPj6h5C1MRFCNM 02ew/Fzw7FxWK5Ec2eHxep1YcY9hYdLiOvYPPMcXvySNvYz1Lm8NpmhHJncPLHnEzJ5Hlg+n1wF yDWXnvynKINdAbJk6QMAF6rTb76/17vZXktdOqUB0/Nzt4R8Tx/vfej+oFz4HQX3phoniI9G7Z7 ynSXyEZwHdsHNG9ND/xsoLipOZk8F+yd/rp6ZgdA/LG1LbNeD6tbYxqEFWCQ5ADRm51Md52ws= X-Google-Smtp-Source: AGHT+IF68cz2tJEYTPejxUXhpefjvTppK7MvtvwBwc64fE9WIGCZu9QmP31Ud0GJDrQgsbohPimqFw== X-Received: by 2002:a05:6000:1a86:b0:429:d253:8619 with SMTP id ffacd0b85a97d-42fa071b78fmr3645039f8f.5.1765310771909; Tue, 09 Dec 2025 12:06:11 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 05/10] migration: Fix order of function arguments Date: Tue, 9 Dec 2025 21:05:32 +0100 Message-ID: <20251209200537.84097-6-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251209200537.84097-1-philmd@linaro.org> References: <20251209200537.84097-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=philmd@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1765310799062158500 From: Stefan Weil This fixes a compiler error when higher warning levels are enabled: ../migration/postcopy-ram.c: In function =E2=80=98postcopy_temp_pages_setup= =E2=80=99: ../migration/postcopy-ram.c:1483:50: error: =E2=80=98g_malloc0_n=E2=80=99 s= izes specified with =E2=80=98sizeof=E2=80=99 in the earlier argument and no= t in the later argument [-Werror=3Dcalloc-transposed-args] 1483 | mis->postcopy_tmp_pages =3D g_malloc0_n(sizeof(PostcopyTmpPage)= , channels); | ^~~~~~~~~~~~~~~ ../migration/postcopy-ram.c:1483:50: note: earlier argument should specify = number of elements, later size of each element Avoid also a related int/unsigned mismatch by fixing the type of two local variables. Signed-off-by: Stefan Weil Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251209125049.764095-1-sw@weilnetz.de> [PMD: Replace g_malloc0_n() by g_new0()] Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Peter Xu Message-Id: <20251209195010.83219-1-philmd@linaro.org> --- migration/postcopy-ram.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index 7c9fe61041f..715ef021a91 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -1467,7 +1467,8 @@ retry: static int postcopy_temp_pages_setup(MigrationIncomingState *mis) { PostcopyTmpPage *tmp_page; - int err, i, channels; + int err; + unsigned i, channels; void *temp_page; =20 if (migrate_postcopy_preempt()) { @@ -1479,7 +1480,7 @@ static int postcopy_temp_pages_setup(MigrationIncomin= gState *mis) } =20 channels =3D mis->postcopy_channels; - mis->postcopy_tmp_pages =3D g_malloc0_n(sizeof(PostcopyTmpPage), chann= els); + mis->postcopy_tmp_pages =3D g_new0(PostcopyTmpPage, channels); =20 for (i =3D 0; i < channels; i++) { tmp_page =3D &mis->postcopy_tmp_pages[i]; --=20 2.51.0 From nobody Sun Feb 8 22:46:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1765310802; cv=none; d=zohomail.com; s=zohoarc; b=iTZ0UYThz4syMbOSX7W2mpYAIa9Yo+rMg4DEoC+VNC2TQqw4UJpTY1aBiO55/fvQ3gkO9L4HO0E1pYmPx3k3lDuPM5nno6PUqx0pyo/saPwRRdsPVdGPqM4Utu1kfHWzbbH3ek32fLjacUgLAITuNZ8nLH1dGLuJtznKNOb3ODU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765310802; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=mm7cQtcn5xkKQTNvHIWxJwwmJPuvh0n6grNa/WZuROg=; b=QF6dufdoUiCW0gviYm0lemTwlgUchAEv3SUx7Elu9Ym1Glti64Mxrk/v85khbnNDBmDnFOt+wqHyUFHDZFisH1rSuMLUbhzxmMmQHP+IAOIrl5CeRzr2q4Hx3EYhfhgTL9OVDnXzTgoi2D9CyywkQzmUW+g7HWoCUxDDrTKXsOI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765310802831556.7001459700493; Tue, 9 Dec 2025 12:06:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vT3yb-0001CC-Ci; Tue, 09 Dec 2025 15:06:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vT3yZ-00018G-2a for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:23 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vT3yX-0001Jc-Kv for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:22 -0500 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-42e2e47be25so3076118f8f.2 for ; Tue, 09 Dec 2025 12:06:20 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d22249esm33049671f8f.25.2025.12.09.12.06.17 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 09 Dec 2025 12:06:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765310779; x=1765915579; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=mm7cQtcn5xkKQTNvHIWxJwwmJPuvh0n6grNa/WZuROg=; b=Ux9q6JUSRviniacjq7AwtRTzhLrPv7PVKnRUHqt+UGTS7ZYSyk200I0ynBQtLzZp2o etJL15E2tD9GS2A0X+jEWTk6IfYhj0KQz0layqg8hfu2tVe7cnR3A9kcAr1FqJtKbsHS oojvpKrRqwVgsjXnJOStvYMwGeGb6P+AYCjpS3hEnYJRc5ug3b1+LjqWNNCV+KyzsCoi VjdKsjnUxg6pPRt1yBRqmzPUFZOpiq6tJzg4g6ilJDWluJG9NJmGFx9JWqgTbJje+Dk/ EfLNOspOdodf11dQucTg7iX0ehm8AkMvEIUcenQZ3q89OkKH+aHDdOK19ES5AaEcSK9C 33PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765310779; x=1765915579; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mm7cQtcn5xkKQTNvHIWxJwwmJPuvh0n6grNa/WZuROg=; b=PxEu+Kn1HNUnznGHotwmBdooSdDIQQVp2BhMq1HOb//WjYYFBb0V1aeWUQGKyE3dHx v636O85mkKQRVlILSr05fEO50oQAWrw6wK7jlB9WkR3XC2LD5L8M6o+vc7qPQn/JVaxn fsNLFLfZYZxj7oI03LSAdDXHqqPtyb72OBgzPKEi5cW65dYXcOX4Kcjp6xV/fZfoh9f4 KzLiTlEjpNs1LHP9mCQrkcUDTgBvcLj9phWHXbrYZEfaJdWgsfIkxgPSRcijPYJcxf6P vUxMYd57tET0L8ot7qm1Al/JJsSNX7LFExhS68T4Qj/UZKMu+R55fEdcC5Y1NDRRat20 nLUg== X-Gm-Message-State: AOJu0YzCDBbfD1rPcfz6LF0HbxsghYucC2iv4EKg6LEtnvoIb4jayp9s gkAcP3DsDE4sd1J5qn5y70JzsNF3rvT3vcp+2KPAq10nhddJfLKmkNQvXAUe4L2x9o1SBn2K0Li 7UvTM/Ho= X-Gm-Gg: AY/fxX4RDQ3tBfsmzbtGBXFfjGliwdybtQgnwVpVSIGT52g+RNVt6mY4KKVVFkcR8l5 O0iJ1Uau2dbI+GWJCQhYBTMMyAsGkfZX+n9OHmZOwgewEg3u7ZLZYaDaOYgdKElI4Ui/cZZLeEN BeTdmA/UUkyctNpXpwkQpPTnUIblh3JNt4IGVdok+KkJPPjtsfI4d4a49AmyWdTBwZJ+isDHUPe jMk+BqJfYKsJQah7GocxmMIKWvqB3Q/X/4WJZslcYx87Y13xuCyn8B7n64n48QwIgHRHp0TDz9P I810ajE/e8QfdEpTpY3BI/N+UYiPAW+k3FuCNgRxqlcQL8824fbz8SLAOpUrksvc/9OQtbmoX8+ 2lZsOCgBsuzgyQPHHTo7PjkUvA5qGSJeIzLBaNcKxKG/mp3fZ34qlPs/KkrMGwMsdQz81aVgY5i oKNypGi5DsrZ88DZOoVbGLk63Kto8hD6xrM8oFXpamHZImAdJe3gjrK8iU1WBu X-Google-Smtp-Source: AGHT+IGCcjDLKc1LXLzaeZIIAtfda9+zZCb/+juAMCDdJI4u6knVPBN8+V3lCZ3WxjkaS414aQwgNw== X-Received: by 2002:a05:6000:402c:b0:3e8:b4cb:c3dc with SMTP id ffacd0b85a97d-42f89f0943fmr13001691f8f.3.1765310779483; Tue, 09 Dec 2025 12:06:19 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 06/10] hw/pci: Fix typo in documentation Date: Tue, 9 Dec 2025 21:05:33 +0100 Message-ID: <20251209200537.84097-7-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251209200537.84097-1-philmd@linaro.org> References: <20251209200537.84097-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=philmd@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1765310804125158501 From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier Message-ID: <20251209125759.764296-1-sw@weilnetz.de> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/pci/pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 6bccb25ac2f..b72e4845009 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -751,7 +751,7 @@ int pci_iommu_register_iotlb_notifier(PCIDevice *dev, u= int32_t pasid, =20 /** * pci_iommu_unregister_iotlb_notifier: unregister a notifier that has been - * registerd with pci_iommu_register_iotlb_notifier. + * registered with pci_iommu_register_iotlb_notifier. * * Returns 0 on success, or a negative errno otherwise. * --=20 2.51.0 From nobody Sun Feb 8 22:46:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1765310868; cv=none; d=zohomail.com; s=zohoarc; b=MEJ9zzlznlAf5StlPEvvUAl2G58Wi2vsGOCz0O8++Uwx3BMP43MOiha5wUZ1apxZKWsSkIO291Jo7X2jnl2pw7//CDgwyUIGTjUWFWZ8nKXfYYuNHxfPLJHvnk3e7KhuFW7OhGYhL+n6qly2ZERedF0yFLB4PeW3oyNRA12N+aU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765310868; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=bib5KwWT8F3I0Wt/g5NCURFK5YXFN/pQovwLilFRpf8=; b=FVtUw5FTTjHMuvKiNsmuycIn0s5Dd8t8lQRf9ANl4BF4gPeSjiavnLqF5MWO/mcqVhGwJdm4iPejCIFksYo8lPAFU9DQboe6VJRCCGo36e5uZXeg7gf3h3hy+S0rro6SiX4pewmFC2wrnfosxDGfsCTs31TtWJ9tLsjRkhZWd7s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765310868496794.3111810684543; Tue, 9 Dec 2025 12:07:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vT3yg-0001E0-Nh; Tue, 09 Dec 2025 15:06:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vT3yf-0001DT-8S for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:29 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vT3yd-0001K4-Pq for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:28 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so57595435e9.2 for ; Tue, 09 Dec 2025 12:06:27 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7cbfee5bsm33334148f8f.16.2025.12.09.12.06.25 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 09 Dec 2025 12:06:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765310786; x=1765915586; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=bib5KwWT8F3I0Wt/g5NCURFK5YXFN/pQovwLilFRpf8=; b=PwU77H4SZlWpzSSk1FftlhcASJnntjXzufSFOpf6IqaXOc+JFqbqRujQropt/71Z5l wQrDjN9hUlZA7DC8EhVahhYu2s5x1kGfAaDRxlV6nFTBcFWsVMtV0ehe5rpC3iE0Q02W QJO5zQqkIKeYjxFKIBdZo7Clxpzt5qL1wDkpkHvwcQ6O0RQ9rcHhWxv25kaBJ8QM2QaA oyxwpj5skHwarKNVTBbJyNM2F2sdcStZEWCt8vJcZ6DHSeCShjVwaL9TCZY9XWc7y3nx jTKGIqr2Yfzqjf3o09NxfQA7bHuLx/V/HTo75UviaUF13A78o5zd3ryNHRqTFWzufjAL /cBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765310786; x=1765915586; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bib5KwWT8F3I0Wt/g5NCURFK5YXFN/pQovwLilFRpf8=; b=TWm/SdAfixFJ6ZnFoSsD4sBAbIaoQxvRWGvRDjmR9TPDB6hH7ELhpOxzKZVL6o41dd MH/ZpDvRSqhmwEI4wW4BJ1EDZq5YmB4DlcDqJaQz/OvcgF9pW03iDq2DsGGWlK02sWBR Yd5Rgi8FkAojczL04zgTL2SHl4l7sPANULGhxu/iL5xgLP6GfJ0okHi0pkWWYmPIoNy+ fYOQCZ8C8bqkvt6VUF0Ost8CRDOiulu49fL7vnD/ywLvQLHrEffJXwW94pKoA6E2OGds 94+c4bAZHWpPjfazjH5aaQQ2mKFBDB3rvfkMGB8qrdq+SSIxPqJz0FsqWSNd0v0rmgHB t2ZA== X-Gm-Message-State: AOJu0Yy4EtrJz+xOK5f0GqAQnbCRDZTO4Re3IA8p/3epene/Z60N2eyk e8CKFn97H+gUfKp9gB9FPMx8PXM2JeZZ/3gha86DeKyCOaIyO5GKhJ184fupLq1tTk8iFJRQQSd 3TWoM2TU= X-Gm-Gg: ASbGnct0rsWH+KduNfdhtXusy+CBnsNgXYJnt4OsY6+8fjlFTD2cInRXBE8gLcCdfu/ gg67iJwbLImu6V29dqwK+nO/ykwyFowIColxGc0w5poJSzEjfBKy7+TTTsLDhsvkbAUiD2u4n/6 mbC+xtmC5ReruGDLNnUeMwh+OltNw7vBT6j0ZnI0lXvcztdsYmbEJbFkDBAe+ZPOoYgAIJfeehE WNfqOYdtxU0cwYnFrr/sedY/gwEMpic9EVGugi7fs2MI2aEwXjc4ueLiwCFR5Phei8YkTq8cO3r SRvQAxSalDctaW7LnmR+mPRoiozkb3q2fXh4nyZvPh3sVWn3XCwdM454Jn1M3Fwb7ey3V3ejlGV UdK/WINGzlXo+RmPkwYSanWARBBeKF8YbVHFCmCfi/oEH49AuTqUwv/Ls/M7wWewEHc8uXdH95a xQyBatutFr78C+H+tRypiv/xgqBTVm0fMdlnq9BIPKaKb44+ao1vvkCVA+gtBc X-Google-Smtp-Source: AGHT+IG+VXCUrJICQgvkIL6QM3rdWG++EG27y9R1vLXzu4Gvwg+g+JraiNgnrkPfqpJXR84luMb7Hg== X-Received: by 2002:a05:600c:1c93:b0:471:d2f:7987 with SMTP id 5b1f17b1804b1-47a837b9a4cmr757985e9.26.1765310786005; Tue, 09 Dec 2025 12:06:26 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 07/10] scripts/nsis.py: Tell makensis that WoA is 64 bit Date: Tue, 9 Dec 2025 21:05:34 +0100 Message-ID: <20251209200537.84097-8-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251209200537.84097-1-philmd@linaro.org> References: <20251209200537.84097-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1765310870265158500 From: Stefan Weil This fixes some settings like the default installation path for the QEMU installation on Windows on ARM (WoA). Signed-off-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251209130212.764443-1-sw@weilnetz.de> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- scripts/nsis.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/nsis.py b/scripts/nsis.py index 8f469634eb7..33069f4a86e 100644 --- a/scripts/nsis.py +++ b/scripts/nsis.py @@ -114,7 +114,7 @@ def main(): "-DSRCDIR=3D" + args.srcdir, "-DBINDIR=3D" + destdir + prefix, ] - if args.cpu =3D=3D "x86_64": + if args.cpu =3D=3D "aarch64" or args.cpu =3D=3D "x86_64": makensis +=3D ["-DW64"] makensis +=3D ["-DDLLDIR=3D" + dlldir] =20 --=20 2.51.0 From nobody Sun Feb 8 22:46:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1765310813; cv=none; d=zohomail.com; s=zohoarc; b=hQF1T4nHrIOh3fdZxHARqEIlm50K/ziYzcHpCjym0Lgsa1FLzQPsS/Xd9QVma0TEyl8e7e7TcKGmDIuBRAnnUwspPDXLxJe2PjXN/+kiXkqY0hjnMe6THaP0XFdOyLyQdk2VzuLiIW9owO3QdxOzweIcNYDqgmpmRo5xRyctIis= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765310813; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ed40xnu/OysTcrDHnWWD1d+2jw+gGT2aWZVPYLkNz/4=; b=IY2HVQyUf/I8zmT42FggculIdw9MBNL2mtnA2M18k32kV877e0VzeNn0WyRMJyYhedqLwKHi2ixI24ChBKWWPDrEAsJa/yHZAlpGQFnhmkbO7rY3nTYeWScf6HjDuJ74FGXZrRLEJ57q/YOUcwVavYGJLD40RsYC+r5WYed+T+I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765310813562697.3152505989176; Tue, 9 Dec 2025 12:06:53 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vT3yq-0001tM-TV; Tue, 09 Dec 2025 15:06:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vT3ym-0001Xa-Nu for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:37 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vT3yk-0001KV-LO for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:36 -0500 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-42e2ce8681eso4140445f8f.0 for ; Tue, 09 Dec 2025 12:06:34 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7cbff352sm34087145f8f.17.2025.12.09.12.06.31 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 09 Dec 2025 12:06:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765310793; x=1765915593; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ed40xnu/OysTcrDHnWWD1d+2jw+gGT2aWZVPYLkNz/4=; b=qTAp7y8MjHE/3nHcR7Wm3H2K6eZEWIokdEnHPl7YJkZ2pZCVEV0/0s8mYiq7ynOaP3 xHh2I75NqqzLrn9WjhzWPiY1yxlqx5qKeM6cM7j/swby97y7x8Bu41dWrUuw7KGVUjg1 1i8oKeddx7w4XgE40eiUVXYOEAkSEju3k3ryoPzUm3uInRbtCO1S3sC7euSrd3TPW4sY qjpJxywetTBcevIvu31mzpWOOm/qfvTR3lTnyQhSKNTeTZecL3V6ZLLpZx9WM1fNaXw3 hvdrlU5xy4xhwBpkmghiH9ceGnzXfp20svwZPTgAFn5XXuRkcOpvbgbWuvSmeKgK1b/X 6Kfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765310793; x=1765915593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ed40xnu/OysTcrDHnWWD1d+2jw+gGT2aWZVPYLkNz/4=; b=w36Xzx62Hw+QMABUPbQdD1bXSmI1eC1tCHrP+tjYACn5rK0Lbtr+dIdQglB5lNwQvn OgNoZJMMg3FrnY0Trs0760l7EnqRypxdEnGuoCLk6Yn8WfUgy6V7pVAEkmh4fhY5qmk2 fdT8qKsjN2r0rVM6R0YAaL3D6oG+UAsAQY69RPlalC+b92qb5vjI6ncoJXMthOc5lbhm xhlZcneIZPFu2vWoFvGnb2E98tLMS1N2PX/ja73DiVBPFZvf+uFZx3uU/RA3UKgebp7b NM9eKYaxSjYO89qj4bxWkg42Nob7IwR34kscKPDGqgdKJjwjY0DdPo6TuICdtyQV1+n1 aacA== X-Gm-Message-State: AOJu0Yx33Fq3i6SDgC5nx1zVupkmDWPyBAYFXbjSQMPk/Mparr7rjGCV HDKz73NTUvOwwCkeGdD9LGf9UgdbdGuKf7ne9FjoXp4jOepeyLoc0a05cVWMtgPAgc9sPV9KG9P OMAb+wow= X-Gm-Gg: AY/fxX5yOSbRNuJ6H96tJy9rc0ohvaasfvkakJaMBZuQIy6MiBQnM4xvpJfDtRt4JAw uSLHvdjV5uGm5cQja94qK8i7iA4PbWa7/3CcK/moP2NCBYPFJC5N/f3iBr4wbw5ypAINnLuz36W 9NTrF/h/kLBVtqMYqgBUvYnpfaXo0sZdgg6r277af8x91eOLGPiHM+uKUK3AFzOxdVYd9iZEHeS TDwgtUNZmjIMrlGxYolGBd3frylosD18nQAKgoAjqsn5XFwQRCt+LMC+r9W3YqmyZgYU+z4cHAT a1vrSlnqABZ2BsohW2PaKRmINt4yrNFdecrIh7KK7cE9jqH0wP8lbAqDQWV5FQI6Xt7zxP+t+pf WMlm4gststozKdCA2wAaAEUmUmffav9nlar5yDIIjbL73eNLKg1fq2MvnpVfDaPC9ck76lIucz9 QvploKRO9AKm5r6EL8vWJlaTLpfmDQsgEzIi8Bm72Px7DiBYuCZQTSpRH3yWYztVIz5CT0Gk8= X-Google-Smtp-Source: AGHT+IF4Vw0VQfZGYl/x0KeII0dzR5+MlpJqu4csL7uKbwZewmpHtOmFONmk2WyMhvPhBHk6bYHQmQ== X-Received: by 2002:a05:6000:2302:b0:42b:52c4:663a with SMTP id ffacd0b85a97d-42f89f0af94mr14494971f8f.11.1765310792628; Tue, 09 Dec 2025 12:06:32 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 08/10] Fix const qualifier build errors with recent glibc Date: Tue, 9 Dec 2025 21:05:35 +0100 Message-ID: <20251209200537.84097-9-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251209200537.84097-1-philmd@linaro.org> References: <20251209200537.84097-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1765310814214158500 From: C=C3=A9dric Le Goater A recent change in glibc 2.42.9000 [1] changes the return type of strstr() and other string functions to be 'const char *' when the input is a 'const char *'. This breaks the build in various files with errors such as : error: initialization discards 'const' qualifier from pointer target type= [-Werror=3Ddiscarded-qualifiers] 208 | char *pidstr =3D strstr(filename, "%"); | ^~~~~~ Fix this by changing the type of the variables that store the result of these functions to 'const char *'. [1] https://sourceware.org/git/?p=3Dglibc.git;a=3Dcommit;h=3Dcd748a63ab1a7a= e846175c532a3daab341c62690 Signed-off-by: C=C3=A9dric Le Goater Reviewed-by: Laurent Vivier Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251209174328.698774-1-clg@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- backends/tpm/tpm_passthrough.c | 2 +- block/vmdk.c | 2 +- block/vvfat.c | 2 +- gdbstub/gdbstub.c | 2 +- qga/commands-linux.c | 7 ++++--- ui/ui-hmp-cmds.c | 2 +- util/log.c | 2 +- 7 files changed, 10 insertions(+), 9 deletions(-) diff --git a/backends/tpm/tpm_passthrough.c b/backends/tpm/tpm_passthrough.c index b7c7074c2aa..a9f35ab7d60 100644 --- a/backends/tpm/tpm_passthrough.c +++ b/backends/tpm/tpm_passthrough.c @@ -211,7 +211,7 @@ static size_t tpm_passthrough_get_buffer_size(TPMBacken= d *tb) static int tpm_passthrough_open_sysfs_cancel(TPMPassthruState *tpm_pt) { int fd =3D -1; - char *dev; + const char *dev; char path[PATH_MAX]; =20 if (tpm_pt->options->cancel_path) { diff --git a/block/vmdk.c b/block/vmdk.c index 3b35b63cb59..89e89cd10e3 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1089,7 +1089,7 @@ vmdk_open_vmdk4(BlockDriverState *bs, BdrvChild *file= , int flags, static int vmdk_parse_description(const char *desc, const char *opt_name, char *buf, int buf_size) { - char *opt_pos, *opt_end; + const char *opt_pos, *opt_end; const char *end =3D desc + strlen(desc); =20 opt_pos =3D strstr(desc, opt_name); diff --git a/block/vvfat.c b/block/vvfat.c index 814796d9185..e334b9febb1 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -1826,7 +1826,7 @@ cluster_was_modified(BDRVVVFATState *s, uint32_t clus= ter_num) =20 static const char* get_basename(const char* path) { - char* basename =3D strrchr(path, '/'); + const char *basename =3D strrchr(path, '/'); if (basename =3D=3D NULL) return path; else diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index dd5fb5667cc..5b2fc06e58d 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -362,7 +362,7 @@ static const char *get_feature_xml(const char *p, const= char **newp, * qXfer:features:read:ANNEX:OFFSET,LENGTH' * ^p ^newp */ - char *term =3D strchr(p, ':'); + const char *term =3D strchr(p, ':'); *newp =3D term + 1; len =3D term - p; =20 diff --git a/qga/commands-linux.c b/qga/commands-linux.c index 4a09ddc760c..c639a60a941 100644 --- a/qga/commands-linux.c +++ b/qga/commands-linux.c @@ -403,7 +403,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const *= syspath, int i, offset, nhosts =3D 0, pcilen; GuestPCIAddress *pciaddr =3D disk->pci_controller; bool has_ata =3D false, has_host =3D false, has_tgt =3D false; - char *p, *driver =3D NULL; + const char *p; + char *driver =3D NULL; bool ret =3D false; =20 p =3D strstr(syspath, "/devices/pci"); @@ -543,7 +544,7 @@ static bool build_guest_fsinfo_for_nonpci_virtio(char c= onst *syspath, Error **errp) { unsigned int tgt[3]; - char *p; + const char *p; =20 if (!strstr(syspath, "/virtio") || !strstr(syspath, "/block")) { g_debug("Unsupported virtio device '%s'", syspath); @@ -575,7 +576,7 @@ static bool build_guest_fsinfo_for_ccw_dev(char const *= syspath, Error **errp) { unsigned int cssid, ssid, subchno, devno; - char *p; + const char *p; =20 p =3D strstr(syspath, "/devices/css"); if (!p || sscanf(p + 12, "%*x/%x.%x.%x/%*x.%*x.%x/", diff --git a/ui/ui-hmp-cmds.c b/ui/ui-hmp-cmds.c index 980a8bbc518..6c93d452c9c 100644 --- a/ui/ui-hmp-cmds.c +++ b/ui/ui-hmp-cmds.c @@ -418,7 +418,7 @@ err_out: void sendkey_completion(ReadLineState *rs, int nb_args, const char *str) { int i; - char *sep; + const char *sep; size_t len; =20 if (nb_args !=3D 2) { diff --git a/util/log.c b/util/log.c index 41f78ce86b2..c44d66b5ce7 100644 --- a/util/log.c +++ b/util/log.c @@ -203,7 +203,7 @@ static ValidFilenameTemplateResult valid_filename_template(const char *filename, bool per_thread, Error **err= p) { if (filename) { - char *pidstr =3D strstr(filename, "%"); + const char *pidstr =3D strstr(filename, "%"); =20 if (pidstr) { /* We only accept one %d, no other format strings */ --=20 2.51.0 From nobody Sun Feb 8 22:46:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1765310827; cv=none; d=zohomail.com; s=zohoarc; b=W1ttCtb8jnzvGwhDInpprkEkBy18m9tv/VhVomLgYn9SHgT+ai3yTGlMBUFUHDgegP+iZ440kjYkyJPVIwdb0KusFN+n4oMuA1/r+Tr20vtYfZplFJcLbGaf4h8g+af4fj5cxcnZc1Iz8wUM8pbRhYbjgnS4EDD8c3BSpZqAfs8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765310827; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=KT0sNA3i3Q26pmMDca66O2amoVWltnvDxFfPQCtL5KU=; b=Cz1MCxppBrbUewZJaFjY4MWd+d7VP0DHi0udHs6iHFVktIgq1/TjHJDYC0iJTDMdpaZWCrgl9CVACWcY8xWqKICSMUrRBQMwKKJA5tAH8Qc53jZoK8KEBKWLpJPQx4AfhJ0O/8Q1dGQKU4p3MKqFd5uRiR+fXIsluWASNKHnh9E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765310827860380.56588694614663; Tue, 9 Dec 2025 12:07:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vT3z1-0002KF-NR; Tue, 09 Dec 2025 15:06:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vT3yt-000224-0y for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:43 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vT3yr-0001LE-Co for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:42 -0500 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-42e2cf93f7dso4330260f8f.1 for ; Tue, 09 Dec 2025 12:06:40 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d353f80sm33018715f8f.41.2025.12.09.12.06.38 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 09 Dec 2025 12:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765310799; x=1765915599; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=KT0sNA3i3Q26pmMDca66O2amoVWltnvDxFfPQCtL5KU=; b=T/NfGPnuibKHuINnDFQs2IAzG7ArFsCqJFI14mlKXvluNmUVwlt4MRjlod0ouRbeSN YO6IGs9SapwCnj1AkIkTINbWGY7oDlDUSA2R/tCvj64k8TMZr1zWOHIQwOlgB0HPm968 25m/nh1ZbOkmIg1BuqxyvANSvxoE/+i7IeptcScPsO2/z+aY5bcImXkRk3lJjX6EHdz/ E1Wjk3uWucKDZSlTbjUOhwFr8aaY2xmmx3WXCoHqwqqc9AVvPtHCsp6+t0BVhu+Ed5hz Ce0syltOIz6MExNKRU7k2jAMiChvyEI1WnKxUiX2To5H07puWqVyn+s15OejKUYK975a yG2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765310799; x=1765915599; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=KT0sNA3i3Q26pmMDca66O2amoVWltnvDxFfPQCtL5KU=; b=U98315XMJm8lGeuKm4CeKGgsXBM46SWuxLO8vqWXCzn0+T/4ieyh+J38osdEgtMPPy xTwu6Hn8IH9owVUAyA5r/yn7mr+eSQxeNekpiWaDuUCDvSj/eyOTc9K78E/pyz7aThTy UdEfg+p3LQGGez5UANup20kad11Zjk5TU6mPqtmWu1IBhSzuPiVdr3P13m2gPt/em9xW 0P77xkkoqQ2YIIl/6z9Lju0vOMV00ddcV8gQLPCQGo5wkf//2iN+UFII3GQ569HEEC6j dS1H+5LV7zzPmbErd8JXKGEsnYSsef+HGjC5OEkfafMhvgKZUP5cYMrmTxsAzkXzAFZm o6lA== X-Gm-Message-State: AOJu0YyFnR+8hZBdpSkk9QuAAY0AXm55Zslqh278k4xaD5apvAIU0UHj /WtAaJ4bgQyXvjIfc6ta76hOHhEV3hQS84ygVrlE1M5BoLdg2pbwZB+iOF342slOeNWkKYbDyfW TqJbE7ZQ= X-Gm-Gg: AY/fxX7PY2k1bfH0DZDumLocfXr0RsmlBvxWFpbFizJ7GYAraOUXVND1F1vVIcn/sJJ vg1lZcmudhE0QD5CE8RMgIILWc4Un1tmIRvbnr9882+5nJqgEWTBrf2qQP+8ZueCw0wsukALoUI Z+T5N9/h/rmpO+rip0VoA/1fCtWzpmh/GTs8BvJ04xrIEnnxJ11UoUAaPVqrlegxAr7I5qSIT3D Pi9FTMwVrwI0fGf/4E/L2tVyw/vGBryW2tRbT1UgYKGHnSnBHpKm+zB/NKTGS+pOc6tNHsW9UFv BH9/CAjSTXHnyAKF4RgA3Jpn2M1csgpWLzlPUkumzUWtWfzneGv2d+9+amakfev6Q6W/aOZvyGj gOLX4uxzXzAfn3qIPQBXGtAOkzSoH3B71X39Xdn8EFsqgzzLwb5eFvT4qNGjrePlFCtyJkj7juU 2Re/Vc2UgUGY7zlb9FA0+ZG3De2KP95O4PD7wFxtJTMRMZVgl06h+64dwaQ189 X-Google-Smtp-Source: AGHT+IEof+RYVppOWSf7jziJ6Rimy190nZZU5gIrmIFsC1Bg1yGyNXYFl1h/H6HlUso0OvPdvlFYHw== X-Received: by 2002:a5d:5887:0:b0:42f:8817:7f0 with SMTP id ffacd0b85a97d-42f89f64a95mr13259523f8f.61.1765310799209; Tue, 09 Dec 2025 12:06:39 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 09/10] Revert "migration/vmstate: remove VMSTATE_BUFFER_POINTER_UNSAFE macro" Date: Tue, 9 Dec 2025 21:05:36 +0100 Message-ID: <20251209200537.84097-10-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251209200537.84097-1-philmd@linaro.org> References: <20251209200537.84097-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1765310828038158500 Next commit will re-use VMSTATE_BUFFER_POINTER_UNSAFE(). This reverts commit 58341158d022823234d25fd337654a82fa6d157b. Suggested-by: Fiona Ebner Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/migration/vmstate.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index df57e6550a2..a87a5efa428 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -727,6 +727,15 @@ extern const VMStateInfo vmstate_info_qlist; .offset =3D offsetof(_state, _field), \ } =20 +#define VMSTATE_BUFFER_POINTER_UNSAFE(_field, _state, _version, _size) { \ + .name =3D (stringify(_field)), \ + .version_id =3D (_version), \ + .size =3D (_size), \ + .info =3D &vmstate_info_buffer, \ + .flags =3D VMS_BUFFER | VMS_POINTER, \ + .offset =3D offsetof(_state, _field), \ +} + /* Allocate a temporary of type 'tmp_type', set tmp->parent to _state * and execute the vmsd on the temporary. Note that we're working with * the whole of _state here, not a field within it. --=20 2.51.0 From nobody Sun Feb 8 22:46:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1765310853; cv=none; d=zohomail.com; s=zohoarc; b=iKC7DN7cjUSsuUrRzZx/ClauoiLT9Uh+Tt4czd+LF0i+SUinkNMvV+s6uNzprzLu6R96eibLyiwtzYj3s9WERxfhgGr6JLqEGbubNYOxfHDwqwhJEumGt7j/s2z0MrOQDXE9eNoVzS4+ezleOCdgy+QYOr1OfNt8ad0dfFpc5xQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765310853; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=monw4Wg+E2ePG8KINi+zLSSpB7+yENlvRjgHjIT21Uk=; b=nwUrmGj2ahW9ICfmLk9Mh6sV0F+0OcXQjbE5kqlXaIZEYDmKm0RM2lDCNbeIAlOP3HjugNJi5gT2mbGMaI3lJ3wNGziPu0u27CX42lREWPA7wSYeHHFsKop855mphEheu3tRAqPCeuAbGd7khRB4oRzIM6hofL2k+vStxDJBQS0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765310853373367.1705718896844; Tue, 9 Dec 2025 12:07:33 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vT3z3-0002cI-H2; Tue, 09 Dec 2025 15:06:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vT3z0-0002FA-LL for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:51 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vT3yy-0001Mh-VL for qemu-devel@nongnu.org; Tue, 09 Dec 2025 15:06:50 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4775895d69cso30834025e9.0 for ; Tue, 09 Dec 2025 12:06:48 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a7d3e6651sm24550505e9.7.2025.12.09.12.06.45 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 09 Dec 2025 12:06:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765310807; x=1765915607; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=monw4Wg+E2ePG8KINi+zLSSpB7+yENlvRjgHjIT21Uk=; b=djiI/f/wzteaYOYg4zEDhaomnwilEZ802taIzXyDc6nX8J9iyoQGqrTGuF1G4eMbmT PtKRCDK/fYGBYiOEbJIEMOGOFrJ6iSaEPDWAvd6aqhymUv7Rt2hlXBdNs2+UgC0+9mjU yPVBo6uigpGmQWl4Xu3bYr+XTj6OQZfpIM5hFRtNYOAUgzOkbefhuC64aaKMEOXN9/op yNqEK1iQH6sJqsijRCJ0a1ZzhNH6UsHpDbLzfwRiwa8Tp9pgvyaGhtY1oi/z/IjO2LqT Em6Nw+J+pp+GaxOIp0zQGLLc2i4bCCbmTBL8HL74CK5zl/XmuzGXfraI0pVrWvAaUxKV zXzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765310807; x=1765915607; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=monw4Wg+E2ePG8KINi+zLSSpB7+yENlvRjgHjIT21Uk=; b=mlruen/3HVPWPRyHzADmG0qJpGyhWcStsEQCitvzvPFc9fRBaMcGTSZdI2TT+dIlx2 32D41oM8scS1SSAhoh0e0CFYrQ3tQLyHJTXAciHvf3VboJ3F6p/IE1Vb3BhIGMN+Nzy+ MetbOObQi1F1CuK+I+RC78eQ4FAMzBaULqOxBBHSIEaYHlTKhGQfVBTj7wax6kvlJDpK cE+j33IYF4EeLLiTMIO7IXRYzjHkPT0xtKnCyI54COYvow52iEdzArThQcPQ28uiB9aI +ff64d4AkXFCNW7h63D2Z1OazrYnPnWgMHqCcw80AFJBZ36CqEdFUtI6Vs6yuOGZl5zg pO8w== X-Gm-Message-State: AOJu0Yym/nGjRMmpUiDzPfj50uCl3gSs+UZA5QJVW31RfSiizrFC+fCk Txhl5WIe6y3w8iv46PVujDBFB6LUtmluiGQ1oKWYr/SeAp2jxpWI1UnsD/Na0teNrW1IAwB54h7 eycL/QDw= X-Gm-Gg: ASbGncvEfXGSTIbpqKUN7NFUvpWKaOGdEgAXj8vk1mtcuGAHYOhSb5dPuq+Ln3orrjF HbjbcDh6a9PCh5sOGbhI9WAhAfMhQc/DRnOYdwpv59lNZCiSum+v4ybINzH76wtSL9GHZuCqjw9 fIvE61HvfY3hs2CZaSL0mIIiMBl4Am6zeWcdryso9RCw6kTGXNymv8leRskr/gXdOlNr/F+JQWH f87aaKsLJywQZggNO41weI/8KCcaE4cZa3gPWuGLjCzctkD2G6D5ZRbyX9oHVeY5p23LUBwqnqH sv0esGvqsCaHECdF9deQI2l8jOhyYYnXc9AFiHdusknrTtUHmhdBfbsBbZZUGg6vCPBNWy7Uava 2IpxQVJSA7/LIBzVylHOPsmQRCBfrw9shXwv9AVf/6pLcbAohrMZtFPtATosT7nwaUtI39P7QnF S2IKOMZO5qkPUSi/8e13nqNjghzI+OerjpP1PVxjfz7zq9ea4hRH3CGUHuMQgs X-Google-Smtp-Source: AGHT+IEtrRjOzMoibLSmbu4TFXJhdwFMc6XNdC4mMZJMGTxczCyWOCVzX202+PqEqLi+Oxum1ZAKtA== X-Received: by 2002:a05:600c:64c9:b0:458:a7fa:211d with SMTP id 5b1f17b1804b1-47a837b9d3emr677935e9.29.1765310806859; Tue, 09 Dec 2025 12:06:46 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 10/10] Revert "hw/net/virtio-net: make VirtIONet.vlans an array instead of a pointer" Date: Tue, 9 Dec 2025 21:05:37 +0100 Message-ID: <20251209200537.84097-11-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251209200537.84097-1-philmd@linaro.org> References: <20251209200537.84097-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1765310854247158500 Per https://lore.kernel.org/qemu-devel/7798584d-e861-47b7-af52-2c2efb67a4de= @proxmox.com/: Loading a VM state taken with v10.1.2 or older doesn't work anymore, using the script [*] we get: kvm: VQ 1 size 0x100 < last_avail_idx 0x9 - used_idx 0x3e30 kvm: load of migration failed: Operation not permitted: error while loadi= ng state for instance 0x0 of device '0000:00:13.0/virtio-net': Failed to lo= ad element of type virtio for virtio: -1 qemu-system-x86_64: Missing section footer for 0000:00:13.0/virtio-net qemu-system-x86_64: Section footer error, section_id: 41 [*]: #!/bin/bash rm /tmp/disk.qcow2 args=3D" -netdev type=3Dtap,id=3Dnet1,ifname=3Dtap104i1,script=3D/usr/libexec/qe= mu-server/pve-bridge,downscript=3D/usr/libexec/qemu-server/pve-bridgedown,v= host=3Don -device virtio-net-pci,mac=3DBC:24:11:32:3C:69,netdev=3Dnet1,bus=3Dpci.= 0,addr=3D0x13,id=3Dnet1 -machine type=3Dpc-i440fx-10.1 " $1/qemu-img create -f qcow2 /tmp/disk.qcow2 1G $1/qemu-system-x86_64 --qmp stdio --blockdev qcow2,node-name=3Dnode0,file= .driver=3Dfile,file.filename=3D/tmp/disk.qcow2 $args < Suggested-by: Fiona Ebner Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/virtio/virtio-net.h | 2 +- hw/net/virtio-net.c | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h index f7083553068..5b8ab7bda79 100644 --- a/include/hw/virtio/virtio-net.h +++ b/include/hw/virtio/virtio-net.h @@ -202,7 +202,7 @@ struct VirtIONet { uint8_t uni_overflow; uint8_t *macs; } mac_table; - uint32_t vlans[MAX_VLAN]; + uint32_t *vlans; virtio_net_conf net_conf; NICConf nic_conf; DeviceState *qdev; diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index f5d93eb4005..ca813203d76 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -986,7 +986,7 @@ static void virtio_net_set_features(VirtIODevice *vdev, virtio_has_feature_ex(vdev->guest_features_ex, VIRTIO_NET_F_CTRL_VLAN)) { bool vlan =3D virtio_has_feature_ex(features, VIRTIO_NET_F_CTRL_VL= AN); - memset(n->vlans, vlan ? 0 : 0xff, sizeof(n->vlans)); + memset(n->vlans, vlan ? 0 : 0xff, MAX_VLAN >> 3); } =20 if (virtio_has_feature_ex(features, VIRTIO_NET_F_STANDBY)) { @@ -3598,8 +3598,7 @@ static const VMStateDescription vmstate_virtio_net_de= vice =3D { * buffer; hold onto your endiannesses; it's actually used as a bi= tmap * but based on the uint. */ - VMSTATE_BUFFER_UNSAFE(vlans, VirtIONet, 0, - sizeof(typeof_field(VirtIONet, vlans))), + VMSTATE_BUFFER_POINTER_UNSAFE(vlans, VirtIONet, 0, MAX_VLAN >> 3), VMSTATE_WITH_TMP(VirtIONet, struct VirtIONetMigTmp, vmstate_virtio_net_has_vnet), VMSTATE_UINT8(mac_table.multi_overflow, VirtIONet), @@ -4017,7 +4016,8 @@ static void virtio_net_device_realize(DeviceState *de= v, Error **errp) =20 n->mac_table.macs =3D g_malloc0(MAC_TABLE_ENTRIES * ETH_ALEN); =20 - memset(n->vlans, 0xff, sizeof(n->vlans)); + n->vlans =3D g_malloc0(MAX_VLAN >> 3); + memset(n->vlans, 0xff, MAX_VLAN >> 3); =20 nc =3D qemu_get_queue(n->nic); nc->rxfilter_notify_enabled =3D 1; @@ -4066,6 +4066,7 @@ static void virtio_net_device_unrealize(DeviceState *= dev) n->netclient_type =3D NULL; =20 g_free(n->mac_table.macs); + g_free(n->vlans); =20 if (n->failover) { qobject_unref(n->primary_opts); --=20 2.51.0