From nobody Fri Dec 12 09:40:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=sifive.com ARC-Seal: i=1; a=rsa-sha256; t=1765296173; cv=none; d=zohomail.com; s=zohoarc; b=gd+vwDlYvdzPUijiyydrJsfSjYspYF1eGZdBfjO/uRBGriCoD6eIHQsTg+RUu5ULa8jU2Lgvb5LR4gW0Y56GHuR5mB5sjyP1SyfImEjR/vVNjPasbdsMwy8h+O0aEx3hDWU2kUyFt1RdO+ufvmq9j2f+mdQs2yEdyQ3HfUXEjSo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765296173; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WmSr+7UNGyS0cxdPZ6v+rDg2ZVlykU+2MSIiprx7dSE=; b=mL/euamXOjigT8LrGMRFssWJQ2u/aK1x4s6vgUlsNiHH4ysZZYJB2ERv+wVnZcac0V2pcXMqSH6KAeVqt98fZ7lhzAbARE5cE3AL0xDwI3gElwwzLAMZs7vY1DCh8F/3p370aJ+1Ck+eCSsItOsXqSAVGpjDy/TFHBi/u4l2k8w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1765296173863368.2838046517734; Tue, 9 Dec 2025 08:02:53 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vT0A7-0003iV-Pk; Tue, 09 Dec 2025 11:02:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vT09m-0003cZ-Lr for qemu-devel@nongnu.org; Tue, 09 Dec 2025 11:01:42 -0500 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vT09k-0003sI-DC for qemu-devel@nongnu.org; Tue, 09 Dec 2025 11:01:42 -0500 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-299d40b0845so93041215ad.3 for ; Tue, 09 Dec 2025 08:01:39 -0800 (PST) Received: from hsinchu16.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7e29ff6c68csm16475242b3a.19.2025.12.09.08.01.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 08:01:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1765296098; x=1765900898; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WmSr+7UNGyS0cxdPZ6v+rDg2ZVlykU+2MSIiprx7dSE=; b=Bh9S1BCkaQWh+XjX6oaxs/nR4v5XcPfcSSlXf/y8AGPsucoWGNY818Bfa30I221i5a uXUNCUzE1lQTTD1lEQaY0O1VsLFFQ3+Tb/NkyvHCQGX3/4r3mMk287DpuVesbfkv3Qq4 +olKta6WttukiRgHLnUfWaM05hNWuFJI6QIj7Pb9gFUY/ld6b0ssbCP637LuVbzgrwaR JBZEvIBC4um0x6pn0fuhaFJM5SNBmOETjb0X4gCeGYEj2+RlOzskmHI08O2H6BR9Scwa 8CQmfKcIngOTGtFo/KJkgUvSXHkhIVUoGRHNMn5Y3IXrzRN5zmmZRmu+xrVIn4lLPkgd p4eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765296098; x=1765900898; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WmSr+7UNGyS0cxdPZ6v+rDg2ZVlykU+2MSIiprx7dSE=; b=YgmhZGE4Ar5Io3O5waFB4FMcIGlfApCfhYPkbc59luX0EpoCaGvtuWiUO5Jw/Qpgge C0k+6u+cJkRLykPm0mH/Ccav5uXLJjaKlRM5RcSQ9ipQHErjEE1vimTjUWlP7xlG3P2h Fj3XxLsBUK+XK8v1BokKtCM+3OqtUAcToADfnmcD8ofG6gUBnWxXUImIzjRZKBizgFD7 kV0vYkkrRtzEbtNj7yWgqaJeGDQ6z4dmbMUnwhuAISHTpHLIa2yOgMZoiYBroKWvhNA8 FFJ02JK9gU/pU63rTSX0qOcT9n17WQm4WS28rwU+MxnF+oY8UX4JyP0H93iUZ9t587qY m9NQ== X-Gm-Message-State: AOJu0YwBOduNWkPtksP0GIaXncI+IeFoxgNRuGewXDX7yDZjLQ2US3w0 l09/xAoMQQN8MF/1Cdb5HyZHla6q3aDUavBabdguHmOxJ4QlAa/WMaCVhvuuQugOBeZVKRAUNpu 41WhIjn+MsP9J9bmIu8KcShsc0IpqC/aJYL8xqN/AASY9A/rAL0Te0h4iDcSRoCoyf3PPR+5QAw XSytHSiP0Slk/LaIaYcbgd9qlH5f/Gl9QLDaQ/ra1c8eU= X-Gm-Gg: AY/fxX7emtu4QjLYsqQdF68vf2YP3tJ8CoNFGeeeaxxNuAGzyGxW9qecymju2iS/70E 9d96hyeSTf8yfzTq+9UF4/BtZE34ScnbzDvJRmhPVKHWN7rY9X3v52dOq7OryRz9ERg4vzUdWFS iTiYCsXvmKbeUHD90IK0NUQ/g1G5JX76Z9pKZTcFzUOn70Vq+Ixy26Ryx33SI0tmlMhALajYann H3zQCTac0+LX3Iq8gQW4DIjlcb0TbuS/QU3JTZRWieXaYsWvbS0CwjEtxLByXNgEBE8SwhD658S TV2YvKTIJ3hwU5E0UmnvArvDHLwPuIaf1hdm3sxq0qHPY0ND3E5OKwbHrwNA/vn/4F/ZHalOebY NOh4qbjXHNqAHTqskuwKEvoiKS5H+JnY3XKZ+FHRhH1i8dsezqUlX/hrICcm/mNyyPxnM34eXeJ s32RHUn6mPD7DTz5qgjRIQr3cbDL8b4rYv1tTgBQ== X-Google-Smtp-Source: AGHT+IF+sUn2KZYCbTWUD/QKNeD0lJ4Bv2zDIz+ZzvW6elUuO859z1+5wNWAcnUlvAaabVHN5DzU2Q== X-Received: by 2002:a17:903:2c08:b0:295:9b73:b15c with SMTP id d9443c01a7336-29df5deb493mr123498985ad.42.1765296097804; Tue, 09 Dec 2025 08:01:37 -0800 (PST) From: frank.chang@sifive.com To: qemu-devel@nongnu.org Cc: Alistair Francis , Palmer Dabbelt , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , qemu-riscv@nongnu.org (open list:SiFive Machines), Frank Chang Subject: [PATCH v2 4/4] hw/char: sifive_uart: Remove ip variable Date: Wed, 10 Dec 2025 00:01:17 +0800 Message-ID: <20251209160117.1239596-5-frank.chang@sifive.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251209160117.1239596-1-frank.chang@sifive.com> References: <20251209160117.1239596-1-frank.chang@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=frank.chang@sifive.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @sifive.com) X-ZM-MESSAGEID: 1765296177168158500 Content-Type: text/plain; charset="utf-8" From: Frank Chang The ip variable is no longer used in the code. Remove it from the codebase. Signed-off-by: Frank Chang --- hw/char/sifive_uart.c | 6 ++---- include/hw/char/sifive_uart.h | 1 - 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index c3bb9d5ba66..4e8c8234175 100644 --- a/hw/char/sifive_uart.c +++ b/hw/char/sifive_uart.c @@ -285,7 +285,6 @@ static void sifive_uart_reset_enter(Object *obj, ResetT= ype type) =20 s->txfifo =3D 0; s->ie =3D 0; - s->ip =3D 0; s->txctrl =3D 0; s->rxctrl =3D 0; s->div =3D 0; @@ -343,14 +342,13 @@ static void sifive_uart_reset_hold(Object *obj, Reset= Type type) =20 static const VMStateDescription vmstate_sifive_uart =3D { .name =3D TYPE_SIFIVE_UART, - .version_id =3D 2, - .minimum_version_id =3D 2, + .version_id =3D 3, + .minimum_version_id =3D 3, .fields =3D (const VMStateField[]) { VMSTATE_UINT8_ARRAY(rx_fifo, SiFiveUARTState, SIFIVE_UART_RX_FIFO_SIZE), VMSTATE_UINT8(rx_fifo_len, SiFiveUARTState), VMSTATE_UINT32(ie, SiFiveUARTState), - VMSTATE_UINT32(ip, SiFiveUARTState), VMSTATE_UINT32(txctrl, SiFiveUARTState), VMSTATE_UINT32(rxctrl, SiFiveUARTState), VMSTATE_UINT32(div, SiFiveUARTState), diff --git a/include/hw/char/sifive_uart.h b/include/hw/char/sifive_uart.h index e216cacf693..50d7418f94b 100644 --- a/include/hw/char/sifive_uart.h +++ b/include/hw/char/sifive_uart.h @@ -73,7 +73,6 @@ struct SiFiveUARTState { =20 uint32_t txfifo; uint32_t ie; - uint32_t ip; uint32_t txctrl; uint32_t rxctrl; uint32_t div; --=20 2.43.0