From nobody Sun Dec 14 11:17:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1764863099; cv=none; d=zohomail.com; s=zohoarc; b=kIobsa9ZTOpYsytu9ES1dfM/tFI4h8YgzJhN0kQ3vjC60xJ0rEJSnj5M+nSShglZEBfGiWPr4IuzXe2IDXfLhqh7pnjob62w5w53nvvqyA4tvtfSrZdgXwNjgrFC3TfO1ozabvWr7cRfIEzSIPDB62Pei9CC80VLgVpp/n2B0KY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764863099; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QEF7AKFuJmnyk85mUPCxeEPGdXymBb7vQLej3LTUu5A=; b=Ix9aJ8E2+NnWwml2SNCW80yzm/JNUQelhPtqEpmSkyS3bM8izCvWurWMQ+ghWOd/Ow126yhOTIFZ/apHLcEn2yywoxWLeG+cHrpvV5tRjevKYljCjBPSu2RoqyOddPYaxHCcuW6kWiqGm+Nc3+xx8mIUoLJVfTiL4WzH/8zJgc8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764863099577164.51360675150397; Thu, 4 Dec 2025 07:44:59 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vRBTx-0006Tv-2S; Thu, 04 Dec 2025 10:43:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vRBTm-0006R8-AG for qemu-devel@nongnu.org; Thu, 04 Dec 2025 10:42:51 -0500 Received: from forwardcorp1b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vRBTj-0007F4-IX for qemu-devel@nongnu.org; Thu, 04 Dec 2025 10:42:50 -0500 Received: from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net [IPv6:2a02:6b8:c24:fa2:0:640:41ee:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id E067680771; Thu, 04 Dec 2025 18:42:45 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:83c::1:2e]) by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id agnhnW0F9Gk0-M5vImUFU; Thu, 04 Dec 2025 18:42:45 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1764862965; bh=QEF7AKFuJmnyk85mUPCxeEPGdXymBb7vQLej3LTUu5A=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=w9ad2q8Dd5M/yYj48/xg5HRqapMUSbYho0Z7WVPm5pVv1k0PLyFv2QPdi9dZccOMT ddF4dOENVd6mHzuk7Mvjzm03NpMCn6GCRwYNYdHKts9CgVYi+LZDHBKsTVqzFk+ecz rfX1zPwFkFrn0MRRpZwkX/fX7gERb2gqx0dr0TxQ= Authentication-Results: mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: marcandre.lureau@redhat.com Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, vsementsov@yandex-team.ru, d-tatianin@yandex-team.ru Subject: [PATCH v2 07/10] chardev/char-pty: store pty_name into PtyChardev state Date: Thu, 4 Dec 2025 18:42:31 +0300 Message-ID: <20251204154235.149575-8-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251204154235.149575-1-vsementsov@yandex-team.ru> References: <20251204154235.149575-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1764863101450019200 Content-Type: text/plain; charset="utf-8" We'll use it in following commit. Note the bonus: stop use blind strcpy(). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Marc-Andr=C3=A9 Lureau --- chardev/char-pty.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/chardev/char-pty.c b/chardev/char-pty.c index 9e26e97baf..a582aa7bc7 100644 --- a/chardev/char-pty.c +++ b/chardev/char-pty.c @@ -43,6 +43,7 @@ struct PtyChardev { int connected; GSource *timer_src; char *path; + char *pty_name; }; typedef struct PtyChardev PtyChardev; =20 @@ -303,7 +304,7 @@ static void cfmakeraw (struct termios *termios_p) #endif =20 /* like openpty() but also makes it raw; return master fd */ -static int qemu_openpty_raw(int *aslave, char *pty_name) +static int qemu_openpty_raw(int *aslave, char **pty_name) { int amaster; struct termios tty; @@ -324,9 +325,7 @@ static int qemu_openpty_raw(int *aslave, char *pty_name) cfmakeraw(&tty); tcsetattr(*aslave, TCSAFLUSH, &tty); =20 - if (pty_name) { - strcpy(pty_name, q_ptsname(amaster)); - } + *pty_name =3D g_strdup(q_ptsname(amaster)); =20 return amaster; } @@ -335,11 +334,12 @@ static bool pty_chr_open(Chardev *chr, ChardevBackend= *backend, Error **errp) { PtyChardev *s; int master_fd, slave_fd; - char pty_name[PATH_MAX]; char *name; char *path =3D backend->u.pty.data->path; =20 - master_fd =3D qemu_openpty_raw(&slave_fd, pty_name); + s =3D PTY_CHARDEV(chr); + + master_fd =3D qemu_openpty_raw(&slave_fd, &s->pty_name); if (master_fd < 0) { error_setg_errno(errp, errno, "Failed to create PTY"); return false; @@ -351,11 +351,10 @@ static bool pty_chr_open(Chardev *chr, ChardevBackend= *backend, Error **errp) return false; } =20 - chr->filename =3D g_strdup_printf("pty:%s", pty_name); + chr->filename =3D g_strdup_printf("pty:%s", s->pty_name); qemu_printf("char device redirected to %s (label %s)\n", - pty_name, chr->label); + s->pty_name, chr->label); =20 - s =3D PTY_CHARDEV(chr); s->ioc =3D QIO_CHANNEL(qio_channel_file_new_fd(master_fd)); name =3D g_strdup_printf("chardev-pty-%s", chr->label); qio_channel_set_name(s->ioc, name); @@ -364,7 +363,7 @@ static bool pty_chr_open(Chardev *chr, ChardevBackend *= backend, Error **errp) =20 /* create symbolic link */ if (path) { - int res =3D symlink(pty_name, path); + int res =3D symlink(s->pty_name, path); =20 if (res !=3D 0) { error_setg_errno(errp, errno, "Failed to create PTY symlink"); --=20 2.48.1