From nobody Sun Dec 14 11:17:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1764863108; cv=none; d=zohomail.com; s=zohoarc; b=Q11X6czwobLHGrKITelZ2qQDz/ZtD5AZCWRTMFr5dYazH9tR7ZtdPAWeBfzpx0YyKNuIXaZXPUPfY+baKKl7v7/J1RQKalhvBt0KJ4klFxF7T57nc09O068rea2VaPrmxR0lxhp4ntT5sPRmSj28RulTnXKT0D2+hXyc72PVe4Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764863108; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UqYZB+gcAm7m4lFoOx1hkX6Uvxqb1CZng0virje0KxM=; b=jcuVFUk886XNP86Jhsbne0KIt4A18yNqeJfaYLlDDOv3YMcGf+Yxb81RUhfEt2CeM2MMZlXpsvkIUzHiVqo1TCvKbjXlT6t0oLrsI2IxDbukERmtWx/u7M7k+AP4ZpFiCtGSdl3CkylMm3pDs/ajcWzAPDk9yM0fSoZ2MoDVIIs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764863108194711.7469444121417; Thu, 4 Dec 2025 07:45:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vRBU8-0006YB-Qk; Thu, 04 Dec 2025 10:43:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vRBTq-0006Sj-KH for qemu-devel@nongnu.org; Thu, 04 Dec 2025 10:42:55 -0500 Received: from forwardcorp1b.mail.yandex.net ([178.154.239.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vRBTn-0007Fd-CE for qemu-devel@nongnu.org; Thu, 04 Dec 2025 10:42:54 -0500 Received: from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net [IPv6:2a02:6b8:c24:fa2:0:640:41ee:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id 23A67808F1; Thu, 04 Dec 2025 18:42:49 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:83c::1:2e]) by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id agnhnW0F9Gk0-OvAP4G0n; Thu, 04 Dec 2025 18:42:48 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1764862968; bh=UqYZB+gcAm7m4lFoOx1hkX6Uvxqb1CZng0virje0KxM=; h=Cc:Message-ID:References:Date:In-Reply-To:Subject:To:From; b=ArjBfe8sykeJ9RylzLcyB3F0C5pqTtMKEJpl4RASkoN8VMllTufwLdoSMgzPzGSI2 3SBWBpp5CZfTWr/o0u5ISgOJDxTVVL/Tz+r/a31/icX1qXpkgrebKxB4g8JpaUWSc+ 61YGWrFg2fvFWjBMXyCN/8DwvMM0DpU146C5hOxU= Authentication-Results: mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: marcandre.lureau@redhat.com Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, vsementsov@yandex-team.ru, d-tatianin@yandex-team.ru, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 10/10] chardev/char: qemu_char_open(): add return value Date: Thu, 4 Dec 2025 18:42:34 +0300 Message-ID: <20251204154235.149575-11-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251204154235.149575-1-vsementsov@yandex-team.ru> References: <20251204154235.149575-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.136; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1764863109327019200 Accordingly with recommendations in include/qapi/error.h accompany errp by boolean return value and get rid of error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- chardev/char.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/chardev/char.c b/chardev/char.c index bdd907f015..e2ec4e15cc 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -246,7 +246,7 @@ int qemu_chr_add_client(Chardev *s, int fd) CHARDEV_GET_CLASS(s)->chr_add_client(s, fd) : -1; } =20 -static void qemu_char_open(Chardev *chr, ChardevBackend *backend, Error **= errp) +static bool qemu_char_open(Chardev *chr, ChardevBackend *backend, Error **= errp) { ChardevClass *cc =3D CHARDEV_GET_CLASS(chr); /* Any ChardevCommon member would work */ @@ -262,13 +262,15 @@ static void qemu_char_open(Chardev *chr, ChardevBacke= nd *backend, Error **errp) } chr->logfd =3D qemu_create(common->logfile, flags, 0666, errp); if (chr->logfd < 0) { - return; + return false; } } =20 - if (cc->chr_open) { - cc->chr_open(chr, backend, errp); + if (!cc->chr_open) { + return true; } + + return cc->chr_open(chr, backend, errp); } =20 static void char_init(Object *obj) @@ -1007,7 +1009,6 @@ static Chardev *chardev_new(const char *id, const cha= r *typename, { Object *obj; Chardev *chr =3D NULL; - Error *local_err =3D NULL; =20 assert(g_str_has_prefix(typename, "chardev-")); assert(id); @@ -1018,9 +1019,7 @@ static Chardev *chardev_new(const char *id, const cha= r *typename, chr->label =3D g_strdup(id); chr->gcontext =3D gcontext; =20 - qemu_char_open(chr, backend, &local_err); - if (local_err) { - error_propagate(errp, local_err); + if (!qemu_char_open(chr, backend, errp)) { object_unref(obj); return NULL; } --=20 2.48.1