From nobody Sun Dec 14 12:16:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1764840992; cv=none; d=zohomail.com; s=zohoarc; b=bmv1mM/R4h4W/+mlr83uC+sSWZRwD+b0TlAQ/EqRtfDBULqu2s9IYwjyPRXm9Zz1WXLSw9B3ocTFlBiiq0/Xno0ZlsodPa4V0USSGUUTMdwu1Mh/kEnqob0uh9LpN5I+mMqqW+3dgwtyrXOzUonNqzmJnNdrOFTG5YuU+BfF3iI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764840992; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7b25Fv33Xq/PZxsyLv+FhSwrtyaBUSUZvYVfFNhl+n0=; b=Rdd6haEShjrB2qgOrx/xeD4G6d0MQhyNsOAmjBUF+SktPi3Nfj+PeGsHV1nOpycxggThvfW1KbCA3BDvqYZUKF9rY3scPtmuQOvd1pop5B8vXaFdpmT21QbnBFqNEnWFtRdRJNIS3f9qG7H5s0qN1tXZRLcdoZcJAR6KM0BzriE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764840992891547.4093073609488; Thu, 4 Dec 2025 01:36:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vR5kc-0001aF-50; Thu, 04 Dec 2025 04:35:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vR5k3-00019Y-30 for qemu-devel@nongnu.org; Thu, 04 Dec 2025 04:35:15 -0500 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vR5jz-0003O3-LQ for qemu-devel@nongnu.org; Thu, 04 Dec 2025 04:35:13 -0500 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-63c489f1e6cso1178666a12.1 for ; Thu, 04 Dec 2025 01:35:09 -0800 (PST) Received: from PC-DA2D10.beckhoff.com ([195.226.174.194]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-647b2edf72asm856573a12.11.2025.12.04.01.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Dec 2025 01:35:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764840908; x=1765445708; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7b25Fv33Xq/PZxsyLv+FhSwrtyaBUSUZvYVfFNhl+n0=; b=hP41a3BCOtLWdNUUIAksi8xnHw3KR4KvKCBsxwqHxbrdFl1PQUK2YE8qtkQi0Toieo B/UpivEQoXwDSYhQVfOGEZK6gdwRCxwkxe6XiRdjYtIpv8iGijqzhANe2VSgVKu94Zg2 +nUsIkYmBjrTC65Aw5P6ynnp8yu39IC2uHJCWO3z+z37QAgmAiEmCFCgMDHrmt+kkT7T 68JnjMTOgJtbcS9TwHP6jl/F7KoQ50TeYr6pI0DKom9gXy52aKfC9yqoZlKmeGxmApHO JWUpOjL/zIeSmy+ekWiFipWJ3Z6GREjEhIG+EOorVZtu1x+lgDTAu3gvmdtagNU1Nz6Z +5vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764840908; x=1765445708; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7b25Fv33Xq/PZxsyLv+FhSwrtyaBUSUZvYVfFNhl+n0=; b=WdPk4iKZvCqjVJPeuuYNMwg4CAgnvPV4bEVvPjaa+H4x3/6SeJI679n4f5ayQHnzzW c5JFqJIGPJ/J+02AeyuRktMROVfg/SzGx0ljpaDAc78pU6TaAVsFpjr7wwTSXN/hoaap D9B3ddhVXGd2VLMjNSQoOoYuow6xKJWeYpl+5wLYSY2NEelIqtGiIYYYxNGG5RvYFzQ5 KIydv75OuDgqbmGFxGRQfGUKnmPLG0JyIYzh7ju/GZBL4eilzGNGfEA40XGRShpyn+VT XZzFmWrgASy7UhcxLEP8i0TS3nLS2/A4O5SFxCTnlZKbOqgU95FVoTJNxMOTRSczmB9B h5aw== X-Gm-Message-State: AOJu0Yyj/1H9aXFMhcetc5U68n07wjN78BFwwODy176WatabEcSvjkd+ Uq5KblldwigTtzztqi60QTiuaSHwsL6bv5TtGh08Vvb9/kN+wXr15LdVb0mz7vLr X-Gm-Gg: ASbGncu+LS47UJ7zz+p0kyLgOe7WPDYLNO0IpYW4uBlSHQ7LaAs8b7KZgz24CPwWEXH coLn9YhZlZmgzO5sFXf85yHp3gUYsCuJp5fiwBPDmjNfsFXgYfaBYiULNQLuCLf0qXaKRcmqey4 6Qxiwj4RbUiAEFx4gqUIjhpq+osz1izr4GM3FdvE0/FB+sIfpahEpAnVK30djEC95VUMq9wnHh8 3jjE+mtWybhm7XabUEkq0dswO0E3hhLhf6veKRWFIpyacT8l65SX/cnold8PaNjup78Hi25/c8j sJhWoUt01zFshDJGpDxtUPkLJtMHgFXoJENexN/YR1SEXZiXh8/Sgsn7p/D0AcGF1TMbaVgpaN9 2dZY7UVG8Bk/OpXUid3adyVrCjcf2YsFL2ULQYXGQ4gbDLYyy4BlHJrSSYiUmIMeP7sU+5JMU9y Gtp+kGc4h1eatquoXtmtDyG/nq3SMroN8kkaNUKsJS1Q== X-Google-Smtp-Source: AGHT+IGD3i0LrPdz5e0vL2bVXHvaVwO3UwaQb643ryzJqh4NN+/Ny4XDYuq6HOVcEOUUcRWhewotkw== X-Received: by 2002:a05:6402:35c2:b0:641:1cbe:a5bf with SMTP id 4fb4d7f45d1cf-647a6a418a3mr2209665a12.9.1764840908018; Thu, 04 Dec 2025 01:35:08 -0800 (PST) From: =?UTF-8?q?Corvin=20K=C3=B6hne?= To: qemu-devel@nongnu.org Cc: "Edgar E. Iglesias" , Paolo Bonzini , Alistair Francis , qemu-arm@nongnu.org, Peter Maydell , Kevin Wolf , qemu-block@nongnu.org, =?UTF-8?q?Corvin=20K=C3=B6hne?= , Hanna Reitz , =?UTF-8?q?Yannick=20Vo=C3=9Fen?= , YannickV , "Edgar E. Iglesias" Subject: [PATCH v5 04/15] hw/arm/zynq-devcfg: Prevent unintended unlock during initialization Date: Thu, 4 Dec 2025 10:34:51 +0100 Message-ID: <20251204093502.50582-5-corvin.koehne@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251204093502.50582-1-corvin.koehne@gmail.com> References: <20251204093502.50582-1-corvin.koehne@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=corvin.koehne@gmail.com; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1764840993748019200 Content-Type: text/plain; charset="utf-8" From: YannickV During the emulation startup, all registers are reset, which triggers the `r_unlock_post_write` function with a value of 0. This led to an unintended memory access disable, making the devcfg unusable. During startup, the memory space no longer gets locked. Signed-off-by: YannickV Reviewed-by: Edgar E. Iglesias --- hw/dma/xlnx-zynq-devcfg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/dma/xlnx-zynq-devcfg.c b/hw/dma/xlnx-zynq-devcfg.c index 2430d70bf7..0c06daa6b9 100644 --- a/hw/dma/xlnx-zynq-devcfg.c +++ b/hw/dma/xlnx-zynq-devcfg.c @@ -221,7 +221,9 @@ static void r_unlock_post_write(RegisterInfo *reg, uint= 64_t val) { XlnxZynqDevcfg *s =3D XLNX_ZYNQ_DEVCFG(reg->opaque); const char *device_prefix =3D object_get_typename(OBJECT(s)); - + if (device_is_in_reset(DEVICE(s))) { + return; + } if (val =3D=3D R_UNLOCK_MAGIC) { DB_PRINT("successful unlock\n"); s->regs[R_CTRL] |=3D R_CTRL_PCAP_PR_MASK; --=20 2.47.3