From nobody Sat Dec 6 23:29:30 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@getutm.app; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=getutm.app ARC-Seal: i=1; a=rsa-sha256; t=1764734395; cv=none; d=zohomail.com; s=zohoarc; b=WS7sN/vR+dYKA9xdhnYnNgMl0CI87Nkw4pbxoNL/InCNIZxrxJvAHGz9EkUxhxPeAEV7Mh+5By+rTgb0t5lGXIb3HdYU9S6pUrLof1bzZeO3qly54Cqn6Xe2E7MTjQXhui9TlrafJ5Y89VGggOQEUSFhzxhJ+G8oJqVG8U5JxME= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764734395; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/u1E37d+3X51ePDYb6BmriMzonR1iBWObPUX/d1gKos=; b=BkrXFWP+tSaGhwuxFYmU3ybn9z59QVzr4YZ3/oa6l9+Zc4i/Zfe7xquevMlvbzLLgZ0Oacom6D4MZcwpmdKE4uiCfguo0e9Xkv/Hxyr+VNqqthvhlmRakY5a7yT+1LqbF5YdW0XTCK1Vot4WoxpCMID4li2HvFX4/5azl4HJs/Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@getutm.app; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764734395463308.464050110941; Tue, 2 Dec 2025 19:59:55 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vQe1M-0008EM-Q1; Tue, 02 Dec 2025 22:59:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQe1L-0008EB-N6 for qemu-devel@nongnu.org; Tue, 02 Dec 2025 22:59:15 -0500 Received: from a4i956.smtp2go.com ([158.120.83.188]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQe1J-000080-PE for qemu-devel@nongnu.org; Tue, 02 Dec 2025 22:59:15 -0500 Received: from [10.159.238.187] (helo=localhost.localdomain) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA512__CHACHA20_POLY1305:256) (Exim 4.98.1-S2G) (envelope-from ) id 1vQe13-FnQW0hPuz7X-XUJo; Wed, 03 Dec 2025 03:58:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=getutm.app; i=@getutm.app; q=dns/txt; s=s483429; t=1764734343; h=from : subject : to : message-id : date; bh=/u1E37d+3X51ePDYb6BmriMzonR1iBWObPUX/d1gKos=; b=egAtQscEEIJgRuwddjPdAmq4tABynjX+tgYuHgDQhCYWqkNZ0QR2jjFgxG0YHMdCNfVQG Pj7N0Y/sszLDXAgAo9k9f/4GA/kwgKdDPFbPqL8bgQfyKUUNVxR81d08ejunm5Zm3LV5ztX B8NXO6ZIrz/GgQBlrMErfdTEbEK2j2HLn1G8uuiry9aFmlDOI3z6RufZ67268/q24j8q3jT twkyrJuNBmvS52Xc3VOn1hGCPf662AapJIDHk2SDb7IGvS0aFiEEdjdqOl5TZ6TmL40j/24 mpeB03RnOzak8I0Z5QV7pFiq6q8xCcHrDdgwXUkzGdp2cBoyxu0JoCHCzBxQ== From: Joelle van Dyne To: qemu-devel@nongnu.org Cc: Joelle van Dyne , Cameron Esfahani , Roman Bolshakov , Phil Dennis-Jordan , Mads Ynddal Subject: [PATCH] hvf: warn when attempting to add unaligned page size Date: Tue, 2 Dec 2025 19:58:47 -0800 Message-ID: <20251203035847.94102-2-j@getutm.app> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20251203035847.94102-1-j@getutm.app> References: <20251203035847.94102-1-j@getutm.app> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please forward a copy of this message, including all headers, to Feedback-ID: 483429m:483429abrvJvs:483429socTp5oMZ1 X-smtpcorp-track: nTpqvOl5bKWd.XwnSChh5x7a6.HiMA1QJCakm Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=158.120.83.188; envelope-from=bounce.d0e4v9dbe8d7847=ei9y78n82hs8=kkrtpyhcwbj6lz@em483429.getutm.app; helo=a4i956.smtp2go.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @getutm.app) X-ZM-MESSAGEID: 1764734397663019200 Content-Type: text/plain; charset="utf-8" Instead of silently failing, we should print a warning so it is clear why a future guest access to that location might cause an exception. Signed-off-by: Joelle van Dyne --- accel/hvf/hvf-all.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index 0a4b498e83..7823d8416c 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -112,6 +112,14 @@ static void hvf_set_phys_mem(MemoryRegionSection *sect= ion, bool add) =20 if (!QEMU_IS_ALIGNED(int128_get64(section->size), page_size) || !QEMU_IS_ALIGNED(section->offset_within_address_space, page_size))= { + if (add) { + warn_report("Cannot add 0x%016llX:0x%016llX because it is not " + "aligned to page size (0x%X)", + section->offset_within_address_space, + section->offset_within_address_space + + int128_get64(section->size), + (uint32_t)page_size); + } /* Not page aligned, so we can not map as RAM */ add =3D false; } --=20 2.41.0