From nobody Mon Feb 9 06:10:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1764664379; cv=none; d=zohomail.com; s=zohoarc; b=KivFkydV70Nd2pL0y3qxRKUGrpHSBLrGZ0RZM9gFZldubdmgiHUlvxrnhit40hwh9DMiBndqDjJf0SnRFrzNz7fnefudC5M3w2874LFdD0gZzg3kqyPVzwsPFjHdpSfWniN/egzlb3kRoLsN8Mg6Em9j1QYZEiLtrRk8++1hF/k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764664379; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=y6nwHsloA98edYs4iEMv73ZiHGKr8bKy7cA0jyrEQu8=; b=eXos6EodMh2P85MujKMVuhihQpkcauU/d2znWaNBS2xcOfVq6SR5TLJdd3LJREKaBsOH32yiiO4H2l7TvLy+ai+cS/wOzamDKE6EPr8OdEeDgn1Ix6BaQO/h3DxNyQS/2q/jja9SpWqgpr3S9xiHeeALxSyuXnog+YvjJMP5xB0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764664379283671.51458076317; Tue, 2 Dec 2025 00:32:59 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vQLo2-0000rA-G6; Tue, 02 Dec 2025 03:32:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQLo0-0000qH-5c for qemu-devel@nongnu.org; Tue, 02 Dec 2025 03:32:16 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQLny-0007Iq-Gd for qemu-devel@nongnu.org; Tue, 02 Dec 2025 03:32:15 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-1XwbUN8_OjO_e55c08bjRA-1; Tue, 02 Dec 2025 03:32:10 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C1B3118002C5; Tue, 2 Dec 2025 08:32:09 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.7]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 437A41956095; Tue, 2 Dec 2025 08:32:09 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id BF1D021E6935; Tue, 02 Dec 2025 09:32:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764664332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y6nwHsloA98edYs4iEMv73ZiHGKr8bKy7cA0jyrEQu8=; b=h1PvHLJ3pJ8SW1MT4yyfzpjXaBcu0HzQXM9P6m/sbpKx6L/lTZsGr7wfRup+rByfVinkui bJ2xKc5R+Uw+wbUCd7JJ/qTvu3ShH0y5aLLydgLGYrnFRC6eNdZ1/QnguVPnz4mA4aIuR9 3EjCIp4Vl46sH0HHMwEwMoT7N4T/lCg= X-MC-Unique: 1XwbUN8_OjO_e55c08bjRA-1 X-Mimecast-MFC-AGG-ID: 1XwbUN8_OjO_e55c08bjRA_1764664329 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org Subject: [PULL 1/2] migration: Fix double-free on error path Date: Tue, 2 Dec 2025 09:32:05 +0100 Message-ID: <20251202083206.4180561-2-armbru@redhat.com> In-Reply-To: <20251202083206.4180561-1-armbru@redhat.com> References: <20251202083206.4180561-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1764664381016019200 Content-Type: text/plain; charset="utf-8" Fixes: ffaa1b50a879 (migration: Use warn_reportf_err() where appropriate) Resolves: Coverity CID 1643463 Signed-off-by: Markus Armbruster Message-ID: <20251125070554.2256181-1-armbru@redhat.com> Acked-by: Peter Xu --- migration/multifd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/multifd.c b/migration/multifd.c index 6210454838..3203dc98e1 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -450,7 +450,7 @@ static void multifd_send_set_error(Error *err) */ static void migration_ioc_shutdown_gracefully(QIOChannel *ioc) { - g_autoptr(Error) local_err =3D NULL; + Error *local_err =3D NULL; =20 if (!migration_has_failed(migrate_get_current()) && object_dynamic_cast((Object *)ioc, TYPE_QIO_CHANNEL_TLS)) { --=20 2.49.0 From nobody Mon Feb 9 06:10:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1764664379; cv=none; d=zohomail.com; s=zohoarc; b=WabZrIg5ENvIymA9+9pjELX7pLY89hab8C+OiPPY7nwCLzgX0r/2+A1LJyMC8anP8VP5bsibycyaU2VDpTrTD9LCxCQrj/v+0JslAk3GK3d8eJ6K/3WDdyUgLt7gR4oy7IFQwE+XjHzWMkWlUzIbh9+45qFi6C0A5I29t5drlt0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764664379; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PlqrRvm9IwaVz0zr9mAiY+yA/lgInqpEN8yalyL4j4c=; b=BlNSX1RkNWRBuX3XOP9lxe+TKCn8ohpMKEHNkubCoyRPxYyTAesZL1bb5G+soqvt7fpi/0kBAyDD6yH+PuCU0qZ/wBR9dfUk7XFdhldj0qH22eskTV5alGj+Mgyj4pVIhWQSB7Hi6hnMqsuOGtHoiT17BPUYx26XbVEJWbltrqo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764664379211465.0978303992284; Tue, 2 Dec 2025 00:32:59 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vQLo3-0000rb-Sx; Tue, 02 Dec 2025 03:32:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQLo1-0000qd-BD for qemu-devel@nongnu.org; Tue, 02 Dec 2025 03:32:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQLny-0007In-GT for qemu-devel@nongnu.org; Tue, 02 Dec 2025 03:32:17 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-544-c5x7YLivPKGl1z6bV9bhcQ-1; Tue, 02 Dec 2025 03:32:10 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AB9CF1955E74; Tue, 2 Dec 2025 08:32:09 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.7]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4B3DD18002AC; Tue, 2 Dec 2025 08:32:09 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C4CB221E6741; Tue, 02 Dec 2025 09:32:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764664331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PlqrRvm9IwaVz0zr9mAiY+yA/lgInqpEN8yalyL4j4c=; b=ciw6uoEdptL4Pmmspep5ZLPxRETqAJZUyyBeV0H3nOJzjlQw2JIA0ixkgJ18ntNzyKWz3I CTyVug7bOiVWl7s2HKSmxTTtfF2meek1xpOpJz3rMAXfbBP/rfRfxL2tgnHC+h/8agVUr0 kQMtFKwwCfPkC2MgvmEFVZVI1MQEneg= X-MC-Unique: c5x7YLivPKGl1z6bV9bhcQ-1 X-Mimecast-MFC-AGG-ID: c5x7YLivPKGl1z6bV9bhcQ_1764664329 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org Subject: [PULL 2/2] kvm: Fix kvm_vm_ioctl() and kvm_device_ioctl() return value Date: Tue, 2 Dec 2025 09:32:06 +0100 Message-ID: <20251202083206.4180561-3-armbru@redhat.com> In-Reply-To: <20251202083206.4180561-1-armbru@redhat.com> References: <20251202083206.4180561-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1764664381025019200 These functions wrap ioctl(). When ioctl() fails, it sets @errno. The wrappers then return that @errno negated. Except they call accel_ioctl_end() between calling ioctl() and reading @errno. accel_ioctl_end() can clobber @errno, e.g. when a futex() system call fails. Seems unlikely, but it's a bug all the same. Fix by retrieving @errno before calling accel_ioctl_end(). Fixes: a27dd2de68f3 (KVM: keep track of running ioctls) Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251128152050.3417834-1-armbru@redhat.com> --- accel/kvm/kvm-all.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index f9254ae654..28006d73c5 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3373,10 +3373,10 @@ int kvm_vm_ioctl(KVMState *s, unsigned long type, .= ..) trace_kvm_vm_ioctl(type, arg); accel_ioctl_begin(); ret =3D ioctl(s->vmfd, type, arg); - accel_ioctl_end(); if (ret =3D=3D -1) { ret =3D -errno; } + accel_ioctl_end(); return ret; } =20 @@ -3413,10 +3413,10 @@ int kvm_device_ioctl(int fd, unsigned long type, ..= .) trace_kvm_device_ioctl(fd, type, arg); accel_ioctl_begin(); ret =3D ioctl(fd, type, arg); - accel_ioctl_end(); if (ret =3D=3D -1) { ret =3D -errno; } + accel_ioctl_end(); return ret; } =20 --=20 2.49.0