From nobody Sun Dec 14 05:56:40 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1764594043; cv=none; d=zohomail.com; s=zohoarc; b=bug1V7HanHrmmE+av5CxHtdbLItgMYzufguQ/rlLdHssUyJk/RNM23j/aKWL1lOER2t0RnneA+/fnAR529mWQaJjL97IAtPtVGhcSVuTtoSIb75IP/CRxwQi94QXFix7Z0n/JUZSVCDfMZg2bsALL52PGwNuJUHBCD9zaeIT1Nk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764594043; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Uy30EGZxUbbK0AXQ2bdscXYyRHo9fm1/HxaZfC06wJ0=; b=VQynqf6sFfaYmLaSpusTkT0L22c8ephMm9AjyVFv8NE+A83QpqZ8bRSzLuzCq1T/8Ndo2fg626T7J7SP9aQuBSK65ghus+apxnYpHrqylbTD8lcMQf78tZxZyfSU1eEFeiKEaW4fixkfnRIX1Gt+WL1+stZdZ6L1JRTiFFVa6zQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764594039956857.9158289545968; Mon, 1 Dec 2025 05:00:39 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vQ3O6-0001hB-B3; Mon, 01 Dec 2025 07:52:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQ3Nr-0001Be-SE for qemu-devel@nongnu.org; Mon, 01 Dec 2025 07:52:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQ3Nq-0003o5-3O for qemu-devel@nongnu.org; Mon, 01 Dec 2025 07:52:03 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-LTPwpfe_NsWPF-ZwLRZtXQ-1; Mon, 01 Dec 2025 07:51:54 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7BEC01800473 for ; Mon, 1 Dec 2025 12:51:53 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.44.32.210]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DAE3F19560A7; Mon, 1 Dec 2025 12:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764593515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Uy30EGZxUbbK0AXQ2bdscXYyRHo9fm1/HxaZfC06wJ0=; b=g6DChoZepBiEXrDOcJeNPG2HGElGx6PVqlz5oF+AFPL5UUQ8moZPDAJ5mfYZE+wW9epzJ8 n5hiBeCbgyuUIMFQVVONYQNejPwvb3GAk/NCciuRdDtDSzVxqt+thHAAZvZcv8w4bCDRa0 jKJCMdNoW4HE0FloiyiZeOU46eQPNb4= X-MC-Unique: LTPwpfe_NsWPF-ZwLRZtXQ-1 X-Mimecast-MFC-AGG-ID: LTPwpfe_NsWPF-ZwLRZtXQ_1764593513 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Lei Yang , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Stefano Garzarella , Jason Wang Subject: [PATCH] vhost: accept indirect descriptors in shadow virtqueue Date: Mon, 1 Dec 2025 13:51:49 +0100 Message-ID: <20251201125149.2151026-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1764594047348019200 The device is not able to generate indirect descriptors by itself, only the driver can do it. And SVQ is already able to handle them by reusing VirtQueue struct. Shadow VirtQueue just transform the indirect descriptors to chained buffers. This way we don't need to map a new buffer for the indirect table and handle its exhaustion etc. As they are only used in control plane and HW devices don't like indirect, we should not see significant downsides with these. Signed-off-by: Eugenio P=C3=A9rez -- Tested functionally by forwarding the CVQ descriptors. Acked-by: Jason Wang --- hw/virtio/vhost-shadow-virtqueue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-vi= rtqueue.c index 2481d49345..6242aeb69c 100644 --- a/hw/virtio/vhost-shadow-virtqueue.c +++ b/hw/virtio/vhost-shadow-virtqueue.c @@ -34,6 +34,7 @@ bool vhost_svq_valid_features(uint64_t features, Error **= errp) switch (b) { case VIRTIO_F_ANY_LAYOUT: case VIRTIO_RING_F_EVENT_IDX: + case VIRTIO_RING_F_INDIRECT_DESC: continue; =20 case VIRTIO_F_ACCESS_PLATFORM: --=20 2.52.0