From nobody Sat Nov 29 10:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1764360406; cv=none; d=zohomail.com; s=zohoarc; b=UMxtv16glwu4VqzTfL2jpdHsX+Xx84KEovESzHjDb4xysExhXj5Mn2xoA99nv9ZRVbvxY+M7oE7hi7ADHM6TVxbYCf5VQRkSy/zmoA1NOsphkeU32gmwLr+7CrLs73+8HQcKpEZGXOwqTXYCms9jlVYKBDU/5Jbouli6GwLXwAg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764360406; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ug2xojQAwutgyKxatHFJVtNcr8aNK9EqFdIW+a5P3V0=; b=T0gY+/pyQH5AHbVjqpbVc1pXmOVGIQlyXqPt01iwko+tidB/+Ec80sH13QwMGEvg53I0bTbmeyoJCTAd1dsFz+kcEIUeXecImHIb3QEUO81HQcAox2eCu/pM4dJL0eCm6N7xGkO4XKPJENqHwJwXeOoAqPysQN9KfCymqATj458= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764360406725952.612281531007; Fri, 28 Nov 2025 12:06:46 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vP4j5-0002W5-HX; Fri, 28 Nov 2025 15:05:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vP4j1-0002UE-HC for qemu-devel@nongnu.org; Fri, 28 Nov 2025 15:05:51 -0500 Received: from forwardcorp1d.mail.yandex.net ([178.154.239.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vP4ix-0000Rr-DW for qemu-devel@nongnu.org; Fri, 28 Nov 2025 15:05:51 -0500 Received: from mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net [IPv6:2a02:6b8:c42:65a0:0:640:e1de:0]) by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id EF25B81173; Fri, 28 Nov 2025 23:05:38 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:894::1:13]) by mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id b5mcgZ0FDuQ0-bigdVyc1; Fri, 28 Nov 2025 23:05:38 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1764360338; bh=Ug2xojQAwutgyKxatHFJVtNcr8aNK9EqFdIW+a5P3V0=; h=Cc:Message-ID:References:Date:In-Reply-To:Subject:To:From; b=dClwPu5ao8v2imsNBiyM6DGdT7TmhBtwhyt/bLu+g9T4cTqLoSha5EXRt4HCAvmxP j+xeA19O8M4fPxeqyl8+xmHj0QJk8PxZuW4GXFGKHna8cUpFD+EXQ7YEYJtDYjfone CWwsvW3AMgAlnXYM8xqziHhJIUoq3b4ThKZi3ZJg= Authentication-Results: mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: marcandre.lureau@redhat.com Cc: pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com, berrange@redhat.com, vsementsov@yandex-team.ru, yc-core@yandex-team.ru, d-tatianin@yandex-team.ru, qemu-devel@nongnu.org Subject: [RFC PATCH 1/3] char: qemu_chr_write_log() use qemu_write_full() Date: Fri, 28 Nov 2025 23:05:33 +0300 Message-ID: <20251128200536.207344-2-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251128200536.207344-1-vsementsov@yandex-team.ru> References: <20251128200536.207344-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.200; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1764360409260019200 logfd is blocking, so we don't need to care about EAGAIN. Let's simply use qemu_write_full(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- Honestly, I'm not sure, may be EAGAIN handling is needed for some non-linux OSes? That's why it's RFC.. The original commit 0d7708ba29cbcc34336 "qemu-char: add logfile facility to all chardev backends" doen't mention, why should we handle EAGAIN. chardev/char.c | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/chardev/char.c b/chardev/char.c index 3e432195a5..64006a3119 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -82,29 +82,17 @@ void qemu_chr_be_event(Chardev *s, QEMUChrEvent event) CHARDEV_GET_CLASS(s)->chr_be_event(s, event); } =20 -/* Not reporting errors from writing to logfile, as logs are - * defined to be "best effort" only */ static void qemu_chr_write_log(Chardev *s, const uint8_t *buf, size_t len) { - size_t done =3D 0; - ssize_t ret; - if (s->logfd < 0) { return; } =20 - while (done < len) { - retry: - ret =3D write(s->logfd, buf + done, len - done); - if (ret =3D=3D -1 && errno =3D=3D EAGAIN) { - g_usleep(100); - goto retry; - } - - if (ret <=3D 0) { - return; - } - done +=3D ret; + if (qemu_write_full(s->logfd, buf, len) < len) { + /* + * qemu_write_full() is defined with G_GNUC_WARN_UNUSED_RESULT, + * but logging is best=E2=80=91effort, we do ignore errors. + */ } } =20 --=20 2.48.1 From nobody Sat Nov 29 10:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1764360392; cv=none; d=zohomail.com; s=zohoarc; b=C0uP3l6pzALTeCmIXJ9W5r/Gt6bVump7MPgYa/qbMDRlmR5nPjo48CYhRmkqSab5wvWuRjd5Lsl2HWJjceeJuUVrIWykpxqtZIGrTreT8pkgfCwwqKQKNif5IYcPwyL2adBqAwwgxFq0UI7sLuqIbzv1AjoFRHLx5G09bD6GpTo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764360392; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9prDWx4Tuh5NMXxULCIsUGRu46D0miCzYKR+fy/XRzY=; b=DH4dvpsG9E+xo8nPNzlXW8L/mat0SUE095Znzz/KjGrNS+zWJWR9YqW+bphTvJ2VASRQlGklqTz8rTmG3AgmCFsVwIYtu6dMqw5yCqxLWDjh1KKV+yjrMl4iT1OAdVbU5tRsxk23VPOHEClHNeNmmjyd98RlSYZ0MRUm3We6U+k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764360391921304.2039918117438; Fri, 28 Nov 2025 12:06:31 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vP4j5-0002VP-3z; Fri, 28 Nov 2025 15:05:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vP4j1-0002UM-Iq for qemu-devel@nongnu.org; Fri, 28 Nov 2025 15:05:51 -0500 Received: from forwardcorp1d.mail.yandex.net ([2a02:6b8:c41:1300:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vP4ix-0000Rt-D2 for qemu-devel@nongnu.org; Fri, 28 Nov 2025 15:05:49 -0500 Received: from mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net [IPv6:2a02:6b8:c42:65a0:0:640:e1de:0]) by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 7791B81174; Fri, 28 Nov 2025 23:05:39 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:894::1:13]) by mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id b5mcgZ0FDuQ0-84gYId7K; Fri, 28 Nov 2025 23:05:39 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1764360339; bh=9prDWx4Tuh5NMXxULCIsUGRu46D0miCzYKR+fy/XRzY=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=wIoSgjM04UDPqUjcVmUHFmJXUhx1qwAfhzOe0Ub+oqcViNue/PQjUIlv9685ULEWM oHr8I+pzpAySMfo2RNv1k0H0WH0tHPMYVLMLiLo7fLXCLa8c+koIanIOymYlC0yHP2 aiNhm35uw+5RzX7LWc0PRiajaltToMM1fUTtX3CU= Authentication-Results: mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: marcandre.lureau@redhat.com Cc: pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com, berrange@redhat.com, vsementsov@yandex-team.ru, yc-core@yandex-team.ru, d-tatianin@yandex-team.ru, qemu-devel@nongnu.org Subject: [PATCH 2/3] error-report: move real_time_iso8601() to header Date: Fri, 28 Nov 2025 23:05:34 +0300 Message-ID: <20251128200536.207344-3-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251128200536.207344-1-vsementsov@yandex-team.ru> References: <20251128200536.207344-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c41:1300:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1764360395651019200 Content-Type: text/plain; charset="utf-8" To be reused in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/error-report.h | 6 ++++++ util/error-report.c | 7 ------- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h index 3ae2357fda..412b705898 100644 --- a/include/qemu/error-report.h +++ b/include/qemu/error-report.h @@ -74,4 +74,10 @@ extern bool message_with_timestamp; extern bool error_with_guestname; extern const char *error_guest_name; =20 +static inline char *real_time_iso8601(void) +{ + g_autoptr(GDateTime) dt =3D g_date_time_new_now_utc(); + return g_date_time_format_iso8601(dt); +} + #endif diff --git a/util/error-report.c b/util/error-report.c index 1b17c11de1..20618640e8 100644 --- a/util/error-report.c +++ b/util/error-report.c @@ -169,13 +169,6 @@ static void print_loc(void) } } =20 -static char * -real_time_iso8601(void) -{ - g_autoptr(GDateTime) dt =3D g_date_time_new_now_utc(); - return g_date_time_format_iso8601(dt); -} - /* * Print a message to current monitor if we have one, else to stderr. * @report_type is the type of message: error, warning or informational. --=20 2.48.1 From nobody Sat Nov 29 10:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1764360392; cv=none; d=zohomail.com; s=zohoarc; b=H7dQFXuiRpahatw8U4zDJR2qZ6/c3y8SBwJPokgHS4MwB+zw2+NGinIzsuXgXOvhrxPKIrej7ZlDqmnLiqFl6N6KtviLgljxPgsA3h72bfcObchI/71ARwAYlPAFWmGHm931hhgWxyAixVXhET3wgP0BU9IrFhEjs+INfob3cZ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764360392; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=SeytG3v7nZ3UnEGfTy35SUMEpij0sc1khpDxV0rfvUM=; b=QK1UDzGF62hW2fjEAkn5ItdM1xphMbxcre9dXUX3Am+qOa7nqcRgvvLti9rCywg72WVi8+sEIK84ygfhnSwSs0H9OLMiEdsUwP0T0/qfLfo9/CcB7ozhG3shGNrkV3kOTAfY+9VZDgECYS9AsVuJYVOpUQcJ6ejQhVBQ3JtGHbk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764360391737457.8104277593885; Fri, 28 Nov 2025 12:06:31 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vP4j6-0002WW-0c; Fri, 28 Nov 2025 15:05:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vP4j1-0002UR-JR for qemu-devel@nongnu.org; Fri, 28 Nov 2025 15:05:51 -0500 Received: from forwardcorp1d.mail.yandex.net ([178.154.239.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vP4ix-0000Ru-DS for qemu-devel@nongnu.org; Fri, 28 Nov 2025 15:05:51 -0500 Received: from mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net [IPv6:2a02:6b8:c42:65a0:0:640:e1de:0]) by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 149B681172; Fri, 28 Nov 2025 23:05:40 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:894::1:13]) by mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id b5mcgZ0FDuQ0-XltlNhT2; Fri, 28 Nov 2025 23:05:39 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1764360339; bh=SeytG3v7nZ3UnEGfTy35SUMEpij0sc1khpDxV0rfvUM=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=vSoZv8sXcfRYYXlzPhiefuxsDHjkaylT300KqB1pZ4pP23fnf3dYe7MyN1o0zel2m PjyfsT91UggBZVI2Gms922V8YU4ERsVhct/orVWaBD2p5lvGymyo4VhTLxLk+gTHdX Q5InP8JEBYIs750/slsg/5UVD/9z4qxXoySmnLns= Authentication-Results: mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: marcandre.lureau@redhat.com Cc: pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com, berrange@redhat.com, vsementsov@yandex-team.ru, yc-core@yandex-team.ru, d-tatianin@yandex-team.ru, qemu-devel@nongnu.org Subject: [PATCH 3/3] chardev: add logtimestamp option Date: Fri, 28 Nov 2025 23:05:35 +0300 Message-ID: <20251128200536.207344-4-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251128200536.207344-1-vsementsov@yandex-team.ru> References: <20251128200536.207344-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.200; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1764360395715019200 Content-Type: text/plain; charset="utf-8" Add an option to inject timestamps into serial log file. That simplifies debugging a lot, when you can simply compare QEMU logs with guest console logs. Signed-off-by: Vladimir Sementsov-Ogievskiy --- chardev/char.c | 63 ++++++++++++++++++++++++++++++++++++++---- include/chardev/char.h | 2 ++ qapi/char.json | 6 +++- 3 files changed, 65 insertions(+), 6 deletions(-) diff --git a/chardev/char.c b/chardev/char.c index 64006a3119..57c65544d0 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -82,12 +82,8 @@ void qemu_chr_be_event(Chardev *s, QEMUChrEvent event) CHARDEV_GET_CLASS(s)->chr_be_event(s, event); } =20 -static void qemu_chr_write_log(Chardev *s, const uint8_t *buf, size_t len) +static void do_write_log(Chardev *s, const uint8_t *buf, size_t len) { - if (s->logfd < 0) { - return; - } - if (qemu_write_full(s->logfd, buf, len) < len) { /* * qemu_write_full() is defined with G_GNUC_WARN_UNUSED_RESULT, @@ -96,6 +92,55 @@ static void qemu_chr_write_log(Chardev *s, const uint8_t= *buf, size_t len) } } =20 +static void do_write_log_timestamps(Chardev *s, const uint8_t *buf, size_t= len) +{ + g_autofree char *timestr =3D NULL; + + while (len) { + size_t i; + + if (s->log_line_start) { + if (!timestr) { + timestr =3D real_time_iso8601(); + } + do_write_log(s, (const uint8_t *)timestr, strlen(timestr)); + do_write_log(s, (const uint8_t *)" ", 1); + s->log_line_start =3D false; + } + + for (i =3D 0; i < len; i++) { + if (buf[i] =3D=3D '\n') { + break; + } + } + + if (i =3D=3D len) { + /* not found \n */ + do_write_log(s, buf, len); + return; + } + + i +=3D 1; + do_write_log(s, buf, i); + buf +=3D i; + len -=3D i; + s->log_line_start =3D true; + } +} + +static void qemu_chr_write_log(Chardev *s, const uint8_t *buf, size_t len) +{ + if (s->logfd < 0) { + return; + } + + if (s->logtimestamp) { + do_write_log_timestamps(s, buf, len); + } else { + do_write_log(s, buf, len); + } +} + static int qemu_chr_write_buffer(Chardev *s, const uint8_t *buf, int len, int *offset, bool write_all) @@ -249,6 +294,7 @@ static void qemu_char_open(Chardev *chr, ChardevBackend= *backend, } else { flags |=3D O_TRUNC; } + chr->logtimestamp =3D common->has_logtimestamp && common->logtimes= tamp; chr->logfd =3D qemu_create(common->logfile, flags, 0666, errp); if (chr->logfd < 0) { return; @@ -266,6 +312,7 @@ static void char_init(Object *obj) =20 chr->handover_yank_instance =3D false; chr->logfd =3D -1; + chr->log_line_start =3D true; qemu_mutex_init(&chr->chr_write_lock); =20 /* @@ -505,6 +552,9 @@ void qemu_chr_parse_common(QemuOpts *opts, ChardevCommo= n *backend) backend->logfile =3D g_strdup(logfile); backend->has_logappend =3D true; backend->logappend =3D qemu_opt_get_bool(opts, "logappend", false); + + backend->has_logtimestamp =3D true; + backend->logtimestamp =3D qemu_opt_get_bool(opts, "logtimestamp", fals= e); } =20 static const ChardevClass *char_get_class(const char *driver, Error **errp) @@ -956,6 +1006,9 @@ QemuOptsList qemu_chardev_opts =3D { },{ .name =3D "logappend", .type =3D QEMU_OPT_BOOL, + },{ + .name =3D "logtimestamp", + .type =3D QEMU_OPT_BOOL, },{ .name =3D "mouse", .type =3D QEMU_OPT_BOOL, diff --git a/include/chardev/char.h b/include/chardev/char.h index b65e9981c1..6a5318c918 100644 --- a/include/chardev/char.h +++ b/include/chardev/char.h @@ -64,6 +64,8 @@ struct Chardev { char *label; char *filename; int logfd; + bool logtimestamp; + bool log_line_start; int be_open; /* used to coordinate the chardev-change special-case: */ bool handover_yank_instance; diff --git a/qapi/char.json b/qapi/char.json index 140614f82c..a4abafa680 100644 --- a/qapi/char.json +++ b/qapi/char.json @@ -197,11 +197,15 @@ # @logappend: true to append instead of truncate (default to false to # truncate) # +# @logtimestamp: true to insert timestamps into logfile +# (default false) (since 11.0) +# # Since: 2.6 ## { 'struct': 'ChardevCommon', 'data': { '*logfile': 'str', - '*logappend': 'bool' } } + '*logappend': 'bool', + '*logtimestamp': 'bool' } } =20 ## # @ChardevFile: --=20 2.48.1