From nobody Sat Nov 29 10:15:38 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764354189; cv=none; d=zohomail.com; s=zohoarc; b=BTEDB1+iEhBQ1TyzzG5AHmpvau0B3KNuOxJU0/BMJwwRXb4AhERAjFv6o+DLmeyOpq/zWTy9tfIFr3XmIlvf4uXF8ynZrHsIcyXLDR567qN1IYXVrDqVj3dO38j/HG7KcYU6qG5lWCmgYAIMyZaTFVlVIhQKzBySOB5EqU0IGSc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764354189; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1DGGN972COszVw0XgwjUe95FT8j0aUdcqd6miQIJWy4=; b=OJ4M8aqva6mZH60YKbp14eEd1R5hwy9MOLygwn+7jUWbLn0jHIOnpsCwYbag6YKXTBfX4T7WYXXyoyd1Q8dGT7vLnGwsMY/5tuh//ScACFY7+2WYsXA8exiQ1I2nRjjLvjEduAJVuv2pub/Jd4ASmu5LievL4h13zoSPqlNtjJs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764354189480582.2160301323422; Fri, 28 Nov 2025 10:23:09 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vP36t-000322-GR; Fri, 28 Nov 2025 13:22:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vP36k-0002zU-Dc for qemu-devel@nongnu.org; Fri, 28 Nov 2025 13:22:15 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vP36h-000372-JT for qemu-devel@nongnu.org; Fri, 28 Nov 2025 13:22:14 -0500 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-42b32a3e78bso2028675f8f.0 for ; Fri, 28 Nov 2025 10:22:00 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1caa86d0sm10876989f8f.39.2025.11.28.10.21.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 10:21:58 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id D6C6B5F8DA; Fri, 28 Nov 2025 18:21:57 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764354120; x=1764958920; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1DGGN972COszVw0XgwjUe95FT8j0aUdcqd6miQIJWy4=; b=PjBfgI6MomUQ+0+iSSGbsMIVC7tWelwRuuZ9C/99vBBwpyyNwRAB3FdNviWFgDY+3j 3RBw34W+UDzIa93g07TgOMpMqCZjP+UzujBGgJ3dqjUdiQpTvOqxQ790E69z9KYb4eBQ 2T3vUBItcdeIb4Sa1ZN3thwpFVQXpBercoj5owwE4rT+jfDSoz3ae2Ks3j0psLVB4Vxl n+zB/w45rmZxzMmxYH0/g0hzMFUnhl+NoSA7Nf004fBDBrp/8MHHFT43p8njBxUQ1jID xMQMolxbZTJtTrhsNFM7ANrpaa1WbdDu+23J1RXklzQdSWOP4Ttfj1633X8bpL1af+Sv OCHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764354120; x=1764958920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1DGGN972COszVw0XgwjUe95FT8j0aUdcqd6miQIJWy4=; b=ugz/E6GMTwQGJognqgp+j8Wg6VduLkUa4lOtLURYmVlOAq0v6UiJWQrDb9KifgGjr6 +Qxp9gkyRhXR0KXnYDF4EHdctozwh7u0yuTRyxH9JvWJl1XnJmsuMc7EYz4bfpDcerle DN183mrO3UJIwdJ3hIKSu3r/CqA+NUy6jbup+TRUopLDeuPusPpI55e2kffigf7Fc1UT JNTbvhhK4xMU0siCElHJ5Rjm32zFpim7Qffchc9+InqjjLCDWvu9HQCu02dFCyd2z76S KQ03Zm6YkJkfk6Eo9qLHhSnCmAGiIiN43jKyNbuSfXfIVRFy2lZ5tFtHOA7lLIqcwSph ZLDA== X-Gm-Message-State: AOJu0Yx2/ZeYatGtWZjaN/P6zwU+/UW1Vy+if2T1ZWQuFs43mOsJuy/s aEc+9M167+lwkW7p8gP5Or/mv4qE7gK68E37XUD5PgA8QcvdYUfRbca+lGPdrQuvwtA= X-Gm-Gg: ASbGnctWsCRFJzIs0PBrh2WzZDc0Tpl8wAEYfEv/RIJryvNp9PkrkSdu9CPTPyc1Jea bvvdxJdinycmrJMTWcVAEPk0IFmByLv9QRLoFiCKkDPMjYBwokWkPEkVek/WIL4g72dr1UgjPvf s3asTbYxrNsjzUXdqAFV+uOPfjL0Wq3Y7wpgXNl9Lgcw/0SNEtGkxlmd8xFDrNq4qWwyw+Nr4Zr VUOJujRazkPQO+WNBAXPsR+4qCJGtQ5q00Tzf1ZbNjfd7lCg2t2IZIS6XFkD77JmryfxuR/Tdgi w9SFnTijSC9KPJczKGpl19jDBqlWJeEjlmDNJq7HZbzgNYdnoxwMGqJ5VXZM/na7+r8N+nTzKmO PiH7hKH0Cf2f6fQUmT4P0c1pdo80qtW2vtCZLqfl35LiXkniuwwwMM8pA4AVQHzbgRPa+hnMuep CV5Thb0HQ0gNauQ/0tw9Tmiw== X-Google-Smtp-Source: AGHT+IEnIZBfOdH7h0Hh53uTrnI3vcLTh3LFkAu9RTvy0bbzoYigwm2w+yYI28QOXog9Rkc5lWneTg== X-Received: by 2002:a05:6000:22ca:b0:42b:30a6:9c10 with SMTP id ffacd0b85a97d-42cc1d22e12mr32401337f8f.56.1764354119628; Fri, 28 Nov 2025 10:21:59 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Markus Armbruster , Mahmoud Mandour , Pierrick Bouvier , Alexandre Iooss , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/5] tests/tcg: honour the available QEMU binaries when running check-tcg Date: Fri, 28 Nov 2025 18:21:53 +0000 Message-ID: <20251128182157.4125745-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251128182157.4125745-1-alex.bennee@linaro.org> References: <20251128182157.4125745-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764354191151019200 Currently configure can identify all the targets that have cross-compilers available from the supplied target-list. By default this is the default_target_list which is all possible targets we can build. At the same time the target list passed to meson is filtered down depending on various factors including not building 64 bit targets on 32 bit hosts. As a result make check-tcg will erroneously attempt to run tests for which we haven't built a QEMU. Solve this by filtering the final list of TCG_TEST_TARGETS based on what actually was configured by meson. Rename the variable that configure spits out to TCG_TESTS_WITH_COMPILERS for clarity and to avoid larger churn in the Makefile. Signed-off-by: Alex Benn=C3=A9e --- configure | 6 +++--- tests/Makefile.include | 9 +++++++++ 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/configure b/configure index a2f66f7ff9c..82cace1bc95 100755 --- a/configure +++ b/configure @@ -1801,7 +1801,7 @@ if test "$plugins" =3D "yes" ; then fi echo "PYTHON=3D$python" >> tests/tcg/$config_host_mak =20 -tcg_tests_targets=3D +tcg_tests_with_compilers=3D for target in $target_list; do arch=3D${target%%-*} =20 @@ -1852,12 +1852,12 @@ for target in $target_list; do fi =20 echo "run-tcg-tests-$target: $qemu\$(EXESUF)" >> Makefile.prereqs - tcg_tests_targets=3D"$tcg_tests_targets $target" + tcg_tests_with_compilers=3D"$tcg_tests_with_compilers $target" fi done =20 if test "$tcg" =3D "enabled"; then - echo "TCG_TESTS_TARGETS=3D$tcg_tests_targets" >> $config_host_mak + echo "TCG_TESTS_WITH_COMPILERS=3D$tcg_tests_with_compilers" >> $config= _host_mak fi =20 if test "$skip_meson" =3D no; then diff --git a/tests/Makefile.include b/tests/Makefile.include index d4dfbf3716d..7728098981d 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -37,6 +37,15 @@ export SRC_PATH =20 SPEED =3D quick =20 + +# TCG_TESTS_WITH_COMPILERS represents the test targets we have cross compi= ler +# support for, CONFIGURED_TEST_TARGETS it what meson has finally +# configured having rejected stuff we can't build. +CONFIGURED_TCG_TARGETS=3D$(patsubst %-config-target.h, %, $(wildcard *-con= fig-target.h)) + +# This is the intersection of what tests we can build and is configured +TCG_TESTS_TARGETS=3D$(filter $(CONFIGURED_TCG_TARGETS), $(TCG_TESTS_WITH_C= OMPILERS)) + # Per guest TCG tests BUILD_TCG_TARGET_RULES=3D$(patsubst %,build-tcg-tests-%, $(TCG_TESTS_TARGE= TS)) CLEAN_TCG_TARGET_RULES=3D$(patsubst %,clean-tcg-tests-%, $(TCG_TESTS_TARGE= TS)) --=20 2.47.3 From nobody Sat Nov 29 10:15:38 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764354168; cv=none; d=zohomail.com; s=zohoarc; b=SJIhK7L/kkug2V1bFUk2vEVS/5YaCAGtwOD6xm2bfSejCpeiSHg9ydQLWKcDvaBqLiMEteZuVjN+mu326WBrhRUV+2ZBXE5InxSdG6fM75q+S0hx0+bJ/WRt1FrImcjQp5HYLl7GQCVHwLVWc4Zy28GGsY14cWeXpmeGENXOQis= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764354168; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GgY4wKPjvv9aRCmLjqgJ412b/n2ao+a4W2M6nwlctWM=; b=RTFlx5gKtZv0T/QshlTV7+pphAmd/JZma2xbrygnNMh7uGh2oYxRG62mTsXt6QlPbGWCpT/Gn8KW3sImHYRCjE4MQpzS2ADf115ArX5spa5KUsQU3JUkvL0tGtSGtzBlRIjknpnLzh41wXiWozgQE91yd2BCrlQIuGgSqrqz4HE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764354168255308.9650098123549; Fri, 28 Nov 2025 10:22:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vP36t-00032y-Vd; Fri, 28 Nov 2025 13:22:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vP36j-0002yo-71 for qemu-devel@nongnu.org; Fri, 28 Nov 2025 13:22:13 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vP36h-00037i-JW for qemu-devel@nongnu.org; Fri, 28 Nov 2025 13:22:12 -0500 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-42b566859ecso2038427f8f.2 for ; Fri, 28 Nov 2025 10:22:01 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1c5d6181sm11013710f8f.18.2025.11.28.10.21.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 10:21:58 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id ED3C45F8F9; Fri, 28 Nov 2025 18:21:57 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764354120; x=1764958920; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GgY4wKPjvv9aRCmLjqgJ412b/n2ao+a4W2M6nwlctWM=; b=M3YI7FzRr0/VdR9MwX2T7oihLiSM38OiO/yiOk7kHD+i09Gv6DoxBdmHRIaXz19TNi fVshUi/jhGlXPGpeDhgGJts4Aq/I4MFma7g3YyW/FE5zVXKqr+fad7M5AzzF9XIEGnzC g+/EXLAWkH4Oawlqq9XQiD24WxUr9pZuTxdZGf6RVNbpE8S+BfCzp8Wmhr76zHhy53EZ QVZ5+wnMe5o5EkhOB3WAFyqn+D0ML4Ld+Dre+hI7ahf+paDXsFlXrtkHls5iV/HyOLpg aduGzJHqmyY29iLVvO578+yF681ZnlklxlCGt8/iO0mjYAg+2XCd+znfYV8sBrFlvzkH 9oTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764354120; x=1764958920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GgY4wKPjvv9aRCmLjqgJ412b/n2ao+a4W2M6nwlctWM=; b=HvQAU3LxvHzimJFhnCS+HL2Xvq49+8kkPhzIFyBb5pWpmnRKsK33eaQN3aCOampK/I zPyNXlkHxrrCtP1OmoMQGslVqm6W0sa2eSYPh6DPbGtP2fbgeLCgib/ZeUGhxq3RlimG ZkX4qHBej7NzueMwchLQo8a6Ukx4qtdM5dXYWjvnibqcGg8sTxsa8Z85cNDNA5scUhmp REXJ/SWsiQvK2Zg3CrY/2gNDI3fIYWFOMo4OG3WfKqx3lPpYXypNjD1/ZBXt9TuyZTtJ iDK5yp0edGQr0mZp6PUmIhF/dVGmkdeAIng/P4EWB3YvYfq3JKWQOE7iRVb8zKPCjNzI ALKQ== X-Gm-Message-State: AOJu0YwluUs8uslKEUIX4C35VN3CYIn+E6NHajyEaK0OnAZoQdn6BD8o CuLzq/EVHU2o2FGSqVlLB4wEEVitcinPq9DXDQpsBJgDUmivm3GPOxXMHIGuhXNKZpA= X-Gm-Gg: ASbGncuohjxexG2bu/4pe5P3GXQQxX5F0okAxmaAexpmzMCTAvXy/a9em6J8cBWBKsS DLFaOVuvOXFXsFs06+QYkrFIqu0Wa1dNpoWgGUn+TGfNJdJahWMVqwNvBvetUJrWltm39/+H5mz dt9BSocmZxiTw8uk5QITxHrVhi8Qufsw8dQr8OLkjdVL0HM8pIiEJbYxlRqwHxIwmP6yVQQN79+ P/KplU+4VT1k8UZSnXx5kCfoiYl1+Ec5qRGPQU43cicQ/ZEPaoIpPaeHoh/PsO6B/x3r8li9fxI RznmE4vx2smYaL86OP05N+DZ4aAeMAkuUPdvWMEX/uucOLJkbayJ4IRbPyGVW7YghSa+G1Wd4ak bl6ws/+aofwEMfzmy7mNoNPznXKCO0jlQ9A+b06R9e9KvlpRost7eb4PwtJpmSWfg2T+OD+yAK6 Ot7R6OAiHGwYY= X-Google-Smtp-Source: AGHT+IH+7s4qQYVhzcAEvMLiaxBPi9TuZ4xPrnEhqbmBmMUzuCV6RchHo3FuTQ3M7jrX+8WqS4/mDQ== X-Received: by 2002:a05:6000:381:b0:42b:3ad7:fdd3 with SMTP id ffacd0b85a97d-42e0f21e953mr18429580f8f.18.1764354119986; Fri, 28 Nov 2025 10:21:59 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Markus Armbruster , Mahmoud Mandour , Pierrick Bouvier , Alexandre Iooss , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/5] tests/lcitool: add bzip2 to the minimal dependency list Date: Fri, 28 Nov 2025 18:21:54 +0000 Message-ID: <20251128182157.4125745-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251128182157.4125745-1-alex.bennee@linaro.org> References: <20251128182157.4125745-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764354170719019200 You cannot build any softmmu targets without it by default unless you build with --disable-install-blobs. Signed-off-by: Alex Benn=C3=A9e --- tests/lcitool/projects/qemu-minimal.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/lcitool/projects/qemu-minimal.yml b/tests/lcitool/projec= ts/qemu-minimal.yml index 6bc232a1c3e..2a1ac51d402 100644 --- a/tests/lcitool/projects/qemu-minimal.yml +++ b/tests/lcitool/projects/qemu-minimal.yml @@ -4,6 +4,7 @@ packages: - bash - bc - bison + - bzip2 - ccache - findutils - flex --=20 2.47.3 From nobody Sat Nov 29 10:15:38 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764354167; cv=none; d=zohomail.com; s=zohoarc; b=D+0vA0xJfNtsuncA+5LdetXUOfqGscQrbnEvJHlqhoAMnbixeJCcfwfEyMBmd4F8PjnGrX70LcFGLsSS261/uv0pfskbLnl31/cUXY2x1ASiJD2DZc9H5cp1XsLpWUg1UhDM5qCawN1cM6lfcrVehAcWaGlfeTj5uEQnCFlzwKE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764354167; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IAQyAJgpGubRNxWkkAOB/xJeZ3yjTXTZaU1tMjDuYsk=; b=SMQOX4ponVzYugHkLOd57TRN74PYWvIcVG1WY1KwsBM6RXlEE8KBR9E2wBqKdu+ktEeHfc+2mB+ihvQ2qhsxtP1/vbgMS7T6H2CK6fsbmcqvpn6kUf7jB79x+H2oOjqT6XaVnpyfcuJoD/AdeE0TwlX40xJOYCHM6oZdbPqTBlY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176435416771515.369018687282619; Fri, 28 Nov 2025 10:22:47 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vP36s-00031T-OM; Fri, 28 Nov 2025 13:22:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vP36k-0002zX-RS for qemu-devel@nongnu.org; Fri, 28 Nov 2025 13:22:16 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vP36h-00036X-JV for qemu-devel@nongnu.org; Fri, 28 Nov 2025 13:22:14 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4779ce2a624so19496985e9.2 for ; Fri, 28 Nov 2025 10:22:00 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1ca1a303sm11560447f8f.27.2025.11.28.10.21.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 10:21:58 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 110C85F8FD; Fri, 28 Nov 2025 18:21:58 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764354119; x=1764958919; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IAQyAJgpGubRNxWkkAOB/xJeZ3yjTXTZaU1tMjDuYsk=; b=GCzhEU6EHUGAcTn4LrCCstviimvGLbf0HLG+pboCIW91UaPv33I8txFA20uf7E01Wd 4Bmo8lv3mNzICQkajTvDQJDtZsmHrd2F6h/56cc2hqDCP5ActJzVQSwWRx4Xi6T7Fj/1 gaY/Bd1FmMhwxMHO3XY9VWeSl4v8McFRLlIy5Qaj29eavwFG2sPz8Ng1geYTfBl0ENeL BlnrlJeZ/wjBq23Mog9YvgkzRrk6L2oDlXg+/m2XeeW7L8lIDELvpwKFkmzstU+FKYpn NYOB4scP7viQKiFsPFcf0j8ZeDG8SSeWlCAoNxIjn4uGHwDSLMna9r2ivQsKmHUYOzvj ULKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764354119; x=1764958919; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IAQyAJgpGubRNxWkkAOB/xJeZ3yjTXTZaU1tMjDuYsk=; b=vK3rs8i/czHRUyMuIcx5XxoxOhNcF2FzOx1ZALTajrm6RfsPTLWAWh736BHfpsGAn8 D+LkraQk49ysJBFEVjDxyFX1KtiWIb7NPc2LVilDvYqZM9299pzeUuQU/T3YUcg4nVdO wnExCdlV026lvX+TyIkmDJobmrh0pCFPFAS2gppokpimD7HRjB7907h7+Qx6sOf7Ha6W ThnvBcB+KAbMT5qRvB8nStKD8s39ERvsBUWewIu4gNgLfFT5GbLcsZbhLS03VQlWd40A 5pmXjEyzCeVBhHOun3xJDk21GvVrOPJsmkOclel4Lt9ygwM3shzBrQvMfSpn3Zp3MNtC KanQ== X-Gm-Message-State: AOJu0YwBmcEDD1gYwco5eEaQnTS7JyvjMyWZKwBxVT+bpbn8ZCO9dYTt 9VUzhbKfryxJtW2J4XrWAyHUWvryvMLkEJR8c6zgjs5p6ejWO2yGAI2xevwKLE8E/Nk= X-Gm-Gg: ASbGncuLeEmhObRpgUu3IlS2q0wx62L08OIAml8En4cqsc1Tq3KAAfO9y249iMa5juf C4pKS9biw3EOy5kv1fekjFjT9VtQpXcmqDNLlaO1PHtysR2xqGysz9wokPIcaN2vuIp08XTMi1o rK6NGZf18QB+K/t00lyCMDjPHAyrHJKfAVOJSEz3HCitwQ7U/iXCpa7yT6ZTz6jTJQ9dg/1M+iC SIOpAwWWX4g2ImtX4YsTuR8s3HUzk1h7BanoHFdIexx+o3HxNpHGgaEOH+oTOxYMzwNYxhLObjn WfT2EZTeQaVgPFmAafHny5ToFXhjvrLhaIy1RYAeg9D2XEtUGEm7/odJ2kuVHibRk3coRQQOXeR IftXDYyvYmbm8gaAdXxBnkeJQlWDUiW6BLXrFnqy4k/zBqyYtldcFh+jrEsd2epGmcpVN9WYX3Y ZsucymGmKnVhQ= X-Google-Smtp-Source: AGHT+IGUKS88VUyI4SNGgHqvQXeVaVEyU18MSvhrIRToJ9oU0nDASusK79Y+FFfx02MG0LGDOcqvuA== X-Received: by 2002:a05:600c:3ba8:b0:477:af8d:203a with SMTP id 5b1f17b1804b1-47904b24076mr161290475e9.27.1764354119274; Fri, 28 Nov 2025 10:21:59 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Markus Armbruster , Mahmoud Mandour , Pierrick Bouvier , Alexandre Iooss , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/5] tests/dockerfiles: transition debian-all-test-cross to lcitool Date: Fri, 28 Nov 2025 18:21:55 +0000 Message-ID: <20251128182157.4125745-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251128182157.4125745-1-alex.bennee@linaro.org> References: <20251128182157.4125745-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764354169026019200 While we are at it bump up to debian-13. As we use this container in the CI runs this also has the benefit of ensuring our qemu-minimal dependencies project really has just what we need to build a basic QEMU. Signed-off-by: Alex Benn=C3=A9e --- .../dockerfiles/debian-all-test-cross.docker | 122 ++++++++++-------- tests/lcitool/refresh | 43 ++++++ 2 files changed, 111 insertions(+), 54 deletions(-) diff --git a/tests/docker/dockerfiles/debian-all-test-cross.docker b/tests/= docker/dockerfiles/debian-all-test-cross.docker index 420a4e33e60..7c33630a83b 100644 --- a/tests/docker/dockerfiles/debian-all-test-cross.docker +++ b/tests/docker/dockerfiles/debian-all-test-cross.docker @@ -1,77 +1,91 @@ +# THIS FILE WAS AUTO-GENERATED # -# Docker all cross-compiler target (tests only) +# $ lcitool dockerfile --layers all debian-13 qemu-minimal # -# While the normal cross builds take care to setup proper multiarch -# build environments which can cross build QEMU this just installs the -# basic compilers for as many targets as possible. We shall use this -# to build and run linux-user tests on GitLab -# -FROM docker.io/library/debian:12-slim +# https://gitlab.com/libvirt/libvirt-ci =20 -# Duplicate deb line as deb-src -RUN sed -in "s/Types: deb/Types: deb deb-src/g" /etc/apt/sources.list.d/de= bian.sources +FROM docker.io/library/debian:13-slim =20 RUN export DEBIAN_FRONTEND=3Dnoninteractive && \ apt-get update && \ apt-get install -y eatmydata && \ eatmydata apt-get dist-upgrade -y && \ - apt build-dep -yy --arch-only qemu + eatmydata apt-get install --no-install-recommends -y \ + bash \ + bc \ + bison \ + bzip2 \ + ca-certificates \ + ccache \ + findutils \ + flex \ + gcc \ + git \ + libc6-dev \ + libfdt-dev \ + libffi-dev \ + libglib2.0-dev \ + libpixman-1-dev \ + locales \ + make \ + ninja-build \ + pkgconf \ + python3 \ + python3-pip \ + python3-setuptools \ + python3-venv \ + python3-wheel \ + sed \ + tar && \ + eatmydata apt-get autoremove -y && \ + eatmydata apt-get autoclean -y && \ + sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ + dpkg-reconfigure locales && \ + rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED && \ + dpkg-query --showformat '${Package}_${Version}_${Architecture}\n' --sh= ow > /packages.txt && \ + mkdir -p /usr/libexec/ccache-wrappers && \ + ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/cc && \ + ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/gcc =20 -# Add extra build tools and as many cross compilers as we can for testing -RUN DEBIAN_FRONTEND=3Dnoninteractive eatmydata \ - apt install -y --no-install-recommends \ - bison \ - ccache \ - clang \ - dpkg-dev \ - flex \ - gcc \ - git \ - libclang-rt-dev \ - ninja-build \ - python3-pip \ - python3-setuptools \ - python3-tomli \ - python3-venv \ - python3-wheel +RUN /usr/bin/pip3 install meson=3D=3D1.8.1 =20 -# All the generally available compilers +ENV CCACHE_WRAPPERSDIR=3D"/usr/libexec/ccache-wrappers" +ENV LANG=3D"en_US.UTF-8" +ENV MAKE=3D"/usr/bin/make" +ENV NINJA=3D"/usr/bin/ninja" +ENV PYTHON=3D"/usr/bin/python3" ENV AVAILABLE_COMPILERS gcc-aarch64-linux-gnu \ - libc6-dev-arm64-cross \ - gcc-arm-linux-gnueabihf \ - libc6-dev-armhf-cross \ - gcc-mips-linux-gnu \ - libc6-dev-mips-cross \ - gcc-mips64-linux-gnuabi64 \ - libc6-dev-mips64-cross \ - gcc-mips64el-linux-gnuabi64 \ - libc6-dev-mips64el-cross \ - gcc-mipsel-linux-gnu \ - libc6-dev-mipsel-cross \ - gcc-powerpc64le-linux-gnu \ - libc6-dev-ppc64el-cross \ - gcc-riscv64-linux-gnu \ - libc6-dev-riscv64-cross \ - gcc-s390x-linux-gnu \ - libc6-dev-s390x-cross - + libc6-dev-arm64-cross \ + gcc-arm-linux-gnueabihf \ + libc6-dev-armhf-cross \ + gcc-mips-linux-gnu \ + libc6-dev-mips-cross \ + gcc-mips64-linux-gnuabi64 \ + libc6-dev-mips64-cross \ + gcc-mips64el-linux-gnuabi64 \ + libc6-dev-mips64el-cross \ + gcc-mipsel-linux-gnu \ + libc6-dev-mipsel-cross \ + gcc-powerpc64le-linux-gnu \ + libc6-dev-ppc64el-cross \ + gcc-riscv64-linux-gnu \ + libc6-dev-riscv64-cross \ + gcc-s390x-linux-gnu \ + libc6-dev-s390x-cross RUN if dpkg-architecture -e amd64; then \ export AVAILABLE_COMPILERS=3D"${AVAILABLE_COMPILERS} gcc-hppa-linux-gnu = libc6-dev-hppa-cross"; \ export AVAILABLE_COMPILERS=3D"${AVAILABLE_COMPILERS} gcc-m68k-linux-gnu = libc6-dev-m68k-cross"; \ export AVAILABLE_COMPILERS=3D"${AVAILABLE_COMPILERS} gcc-powerpc-linux-g= nu libc6-dev-powerpc-cross"; \ export AVAILABLE_COMPILERS=3D"${AVAILABLE_COMPILERS} gcc-powerpc64-linux= -gnu libc6-dev-ppc64-cross"; \ export AVAILABLE_COMPILERS=3D"${AVAILABLE_COMPILERS} gcc-sparc64-linux-g= nu libc6-dev-sparc64-cross"; \ - fi && \ - DEBIAN_FRONTEND=3Dnoninteractive eatmydata \ - apt install -y --no-install-recommends \ - ${AVAILABLE_COMPILERS} && \ - dpkg-query --showformat '${Package}_${Version}_${Architecture}\n' = --show > /packages.txt - - +fi && \ +DEBIAN_FRONTEND=3Dnoninteractive eatmydata \ +apt install -y --no-install-recommends \ +${AVAILABLE_COMPILERS} && \ +dpkg-query --showformat '${Package}_${Version}_${Architecture}' --show > /= packages.txt ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-tools ENV DEF_TARGET_LIST aarch64-linux-user,arm-linux-user,hppa-linux-user,i386= -linux-user,m68k-linux-user,mips-linux-user,mips64-linux-user,mips64el-linu= x-user,mipsel-linux-user,ppc-linux-user,ppc64-linux-user,ppc64le-linux-user= ,riscv64-linux-user,s390x-linux-user,sparc64-linux-user # As a final step configure the user (if env is defined) -ENV MAKE /usr/bin/make ARG USER ARG UID RUN if [ "${USER}" ]; then \ diff --git a/tests/lcitool/refresh b/tests/lcitool/refresh index 3a31fcfee9c..714e989c953 100755 --- a/tests/lcitool/refresh +++ b/tests/lcitool/refresh @@ -161,6 +161,40 @@ ubuntu2204_rust_extras =3D [ 'RUN cargo install bindgen-cli\n', ] =20 +debian_all_test_cross_compilers =3D [ + "ENV AVAILABLE_COMPILERS gcc-aarch64-linux-gnu \\\n", + " libc6-dev-arm64-cross \\\n", + " gcc-arm-linux-gnueabihf \\\n", + " libc6-dev-armhf-cross \\\n", + " gcc-mips-linux-gnu \\\n", + " libc6-dev-mips-cross \\\n", + " gcc-mips64-linux-gnuabi64 \\\n", + " libc6-dev-mips64-cross \\\n", + " gcc-mips64el-linux-gnuabi64 \\\n", + " libc6-dev-mips64el-cross \\\n", + " gcc-mipsel-linux-gnu \\\n", + " libc6-dev-mipsel-cross \\\n", + " gcc-powerpc64le-linux-gnu \\\n", + " libc6-dev-ppc64el-cross \\\n", + " gcc-riscv64-linux-gnu \\\n", + " libc6-dev-riscv64-cross \\\n", + " gcc-s390x-linux-gnu \\\n", + " libc6-dev-s390x-cross\n", + "RUN if dpkg-architecture -e amd64; then \\\n", + " export AVAILABLE_COMPILERS=3D\"${AVAILABLE_COMPILERS} gcc-hppa-linu= x-gnu libc6-dev-hppa-cross\"; \\\n", + " export AVAILABLE_COMPILERS=3D\"${AVAILABLE_COMPILERS} gcc-m68k-linu= x-gnu libc6-dev-m68k-cross\"; \\\n", + " export AVAILABLE_COMPILERS=3D\"${AVAILABLE_COMPILERS} gcc-powerpc-l= inux-gnu libc6-dev-powerpc-cross\"; \\\n", + " export AVAILABLE_COMPILERS=3D\"${AVAILABLE_COMPILERS} gcc-powerpc64= -linux-gnu libc6-dev-ppc64-cross\"; \\\n", + " export AVAILABLE_COMPILERS=3D\"${AVAILABLE_COMPILERS} gcc-sparc64-l= inux-gnu libc6-dev-sparc64-cross\"; \\\n", + "fi && \\\n", + "DEBIAN_FRONTEND=3Dnoninteractive eatmydata \\\n", + "apt install -y --no-install-recommends \\\n", + "${AVAILABLE_COMPILERS} && \\\n", + "dpkg-query --showformat '${Package}_${Version}_${Architecture}' --sho= w > /packages.txt\n", + "ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-too= ls\n", + "ENV DEF_TARGET_LIST aarch64-linux-user,arm-linux-user,hppa-linux-user= ,i386-linux-user,m68k-linux-user,mips-linux-user,mips64-linux-user,mips64el= -linux-user,mipsel-linux-user,ppc-linux-user,ppc64-linux-user,ppc64le-linux= -user,riscv64-linux-user,s390x-linux-user,sparc64-linux-user\n", +] + def cross_build(prefix, targets): conf =3D "ENV QEMU_CONFIGURE_OPTS=3D--cross-prefix=3D%s\n" % (prefix) targets =3D "ENV DEF_TARGET_LIST=3D%s\n" % (targets) @@ -256,6 +290,15 @@ try: # https://github.com/mesonbuild/meson/pull/14991 enable_rust=3DFalse) =20 + # We also generate some docker files with minimal dependencies and + # as many cross-compilers as Debian will package for building TCG + # tests. + + generate_dockerfile("debian-all-test-cross", "debian-13", + project=3D"qemu-minimal", + enable_rust=3DFalse, + trailer=3D"".join(debian_all_test_cross_compilers)) + # # Cirrus packages lists for GitLab # --=20 2.47.3 From nobody Sat Nov 29 10:15:38 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764354167; cv=none; d=zohomail.com; s=zohoarc; b=MKsst+XUhTL/Y++g46es2mV3iXcwTpxdT5Vmt0pYYo0h5V21INQa6oRaC/Cxa6G/KveUTo5aVq8r8FQFoFFI434a8QbIwQUIhAXXXyYAk+kZVKq33xOvMGKqqJnk+9qnvD2usBmfCzqS/SPhaiX68JDIEo+WBIyKW0K1K/SflOk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764354167; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=i4XS1mjCDo4NWoAdI8vYhiDsjbq4lRngZIqqDpS45Z8=; b=jVnbkgjDda99dzmps66MpXemrdS/q+zaZS7kjY6wiiwJ5tb87f1i2u1JVdr3iovZQkKC8zZyvBwVRD3C9cwQvq9xRBcd6nVwxdhlcx5LBcLEzV54VF3xUYnq0UXQ08Mc5TiTO+Q7r+xynVY+pRlHs2devifDhE1MJIS+w7hzZKg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764354167983230.23577676117372; Fri, 28 Nov 2025 10:22:47 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vP36u-00033B-3t; Fri, 28 Nov 2025 13:22:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vP36k-0002zW-P3 for qemu-devel@nongnu.org; Fri, 28 Nov 2025 13:22:15 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vP36h-00039u-JV for qemu-devel@nongnu.org; Fri, 28 Nov 2025 13:22:14 -0500 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-42b39d51dcfso1410527f8f.2 for ; Fri, 28 Nov 2025 10:22:02 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1ca8e00fsm10997483f8f.34.2025.11.28.10.21.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 10:21:58 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 2731A5F8FE; Fri, 28 Nov 2025 18:21:58 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764354122; x=1764958922; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i4XS1mjCDo4NWoAdI8vYhiDsjbq4lRngZIqqDpS45Z8=; b=kC4JXPROr3OXj29p/1pdA5HPPjOa8qKLI4rVm3ueUXC+oZnLgDKtz3WXRan5Z3vM9/ QWz4UmwbK5i3x/FnOC4TlLMFvweawIGaDYxpFzL4ak57MmD/lBUjMSZRySc56AJQyjBO /tgpxHjl59gc9XZzA4vAfLd2FzTW4x7fA+T/DU7PxCtRIQGRRW2k2DJQvWex65udjoZB YA5jamsm5rsVvGoYWbxIAK0+cfavtkxYEsjImbZon79gnno4AVfcJy6HV4tXfv0BuB+w lnpEZd1AuqpU579OlbNvtRNdqhFEc5ZUMNBamxhIV8Go+Rnavw6yhng9KW7blzE+YtGF SqZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764354122; x=1764958922; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=i4XS1mjCDo4NWoAdI8vYhiDsjbq4lRngZIqqDpS45Z8=; b=mb9uZSwtfqU4nh9FiM8Qk+76dMOlglGganzTA36XQfDkKHceN05ZnFCYIDo8OQsYH7 72Qhaxj2rg/IWMU9u3Uxsr37xuBdDWvCLGx+7ZQWNm+Eyz8UYOfWd/2rSMdJi9U1qhkd hXciqq2co4WMkTiGggo8WgWYDXl2MDlwntiSHbIQQdeuiZXKBzx9aRop5cORvync58bo 4HUO8AOPpJN8zn3iGQ8DPxpUtw6vds4+mHmU/mwqSoqTmrZ6NiOx/MRoGQmFqW73YR7f uPuj4bS7iLTOPvFs8W4aTfqxmEBzPcgNZ7TXXOmLM9qY8Jn+V+bi+8/0wxzAoGqzSEpP qnrg== X-Gm-Message-State: AOJu0Yw0b7LSlclAouWnMsdbWcqF3MeXzNR7nRbk0Je41LnHTI0yTaO7 oSeO99eTDnzM4JL0csQTFVUl2YsNprlGhRekdf3NuUt59iZE3mT5UZk6VIme4Bxd4yo= X-Gm-Gg: ASbGncvXzZ1yo1Exj46Bdok7y3WlWYxIT98J2M2ihI/CZsCrqkI/YR936Ow2Y0du2Jy nTrhkLnpOJX3Qp0e5Adgp8oOe351mRNYEuJbwJrVPmQCG4CPzV/igWu9f4oEx3uuXp0/dgX+TaO fPOBuyAzF5aCwsUWvzzVvf+2qU8MsP3T8dIEI7Sw0IXBE/nge8wMaXCabN/FXzF53pw/BMS0qAx vzwZ9JfktLwjF1h187NcHAf0rH/6QLL7eWxPJUY3Arq2xE8rlGKm7NhJn0l8JSaHDAlgJH+uymf I9Y/1vnuApFCWQ05OmUiZtQPtpMWUPULl5uKanQs1SWLaYw5UGjlP7ajEuJseE8xy/sRjyKTAOe 2N8okyfa1TlubOwkak4ZPljTiud+MrYUdUhyOkO1E+LsArOeeGe5nKtYrBObMtYohtc+zwxIZiW QEwRkqqLsWrws= X-Google-Smtp-Source: AGHT+IHJhG0r9kSDwTx8qOBPvFfgInulipzZLNqECfzKPh0CG6a9OpYaQhwzRSKCJUEOOoP6xGlUsA== X-Received: by 2002:a5d:588b:0:b0:42b:3806:2bb5 with SMTP id ffacd0b85a97d-42cc1abe1fbmr33396766f8f.12.1764354121562; Fri, 28 Nov 2025 10:22:01 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Markus Armbruster , Mahmoud Mandour , Pierrick Bouvier , Alexandre Iooss , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 4/5] docs/devel: update build environment setup documentation Date: Fri, 28 Nov 2025 18:21:56 +0000 Message-ID: <20251128182157.4125745-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251128182157.4125745-1-alex.bennee@linaro.org> References: <20251128182157.4125745-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764354169148019200 Bring `libvirt-ci` front and centre when discussing dependencies for QEMU. While we are at it: - drop links to additional instructions (libvirt is more upto date) - compress pkg installs into a table - call out distro/upstream dep difference in a proper note Signed-off-by: Alex Benn=C3=A9e --- docs/devel/build-environment.rst | 145 ++++++++++++++++++++----------- 1 file changed, 96 insertions(+), 49 deletions(-) diff --git a/docs/devel/build-environment.rst b/docs/devel/build-environmen= t.rst index 661f6ea8504..61b2dc0d1bc 100644 --- a/docs/devel/build-environment.rst +++ b/docs/devel/build-environment.rst @@ -4,55 +4,103 @@ Setup build environment =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 -QEMU uses a lot of dependencies on the host system. glib2 is used everywhe= re in -the code base, and most of the other dependencies are optional. - -We present here simple instructions to enable native builds on most popular -systems. - -You can find additional instructions on `QEMU wiki `_: - -- `Linux `_ -- `MacOS `_ -- `Windows `_ -- `BSD `_ - -Note: Installing dependencies using your package manager build dependencie= s may -miss out on deps that have been newly introduced in qemu.git. In more, it = misses -deps the distribution has decided to exclude. - -Linux ------ - -Fedora -++++++ - -:: - - sudo dnf update && sudo dnf builddep qemu - -Debian/Ubuntu -+++++++++++++ - -You first need to enable `Sources List `_. -Then, use apt to install dependencies: - -:: - - sudo apt update && sudo apt build-dep qemu - -MacOS ------ - -You first need to install `Homebrew `_. Then, use it to -install dependencies: - -:: - - brew update && brew install $(brew deps --include-build qemu) +QEMU uses a lot of dependencies on the host system a large number of +which are optional. At a minimum we expect to have a system C library +(usually glibc but others can work), the glib2 library (used heavily +in the code base) and a few other core libraries for interfacing with +code modules and system build descriptions. + +We use the ``libvirt-ci`` project to handle the mapping of +dependencies to a wide variety output formats including system install +scripts. For example: + +.. code-block:: bash + + # THIS FILE WAS AUTO-GENERATED + # + # $ lcitool buildenvscript debian-13 ./tests/lcitool/projects/qemu-mini= mal.yml + # + # https://gitlab.com/libvirt/libvirt-ci + + function install_buildenv() { + export DEBIAN_FRONTEND=3Dnoninteractive + apt-get update + apt-get dist-upgrade -y + apt-get install --no-install-recommends -y \ + bash \ + bc \ + bison \ + bzip2 \ + ca-certificates \ + ccache \ + findutils \ + flex \ + gcc \ + git \ + libc6-dev \ + libfdt-dev \ + libffi-dev \ + libglib2.0-dev \ + libpixman-1-dev \ + locales \ + make \ + meson \ + ninja-build \ + pkgconf \ + python3 \ + python3-venv \ + sed \ + tar + sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen + dpkg-reconfigure locales + rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED + dpkg-query --showformat '${Package}_${Version}_${Architecture}\n' --= show > /packages.txt + mkdir -p /usr/libexec/ccache-wrappers + ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/cc + ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/gcc + } + + export CCACHE_WRAPPERSDIR=3D"/usr/libexec/ccache-wrappers" + export LANG=3D"en_US.UTF-8" + export MAKE=3D"/usr/bin/make" + export NINJA=3D"/usr/bin/ninja" + export PYTHON=3D"/usr/bin/python3" + +If you instead select the ``qemu.yml`` project file you will get all +the dependencies that the project can use. + +Using you system package manager +-------------------------------- + +.. note:: + + Installing dependencies using your package manager build dependencies m= ay + miss out on deps that have been newly introduced in qemu.git. It + also misses deps the distribution has decided to exclude. + +Systems with Package Managers ++++++++++++++++++++++++++++++ + +.. list-table:: Package Manager Commands + :widths: 10 50 40 + :header-rows: 1 + + * - System + - Command + - Notes + * - Fedora + - ``sudo dnf update && sudo dnf builddep qemu`` + - + * - Debian/Ubuntu + - ``sudo apt update && sudo apt build-dep qemu`` + - Must enable `Sources List + `_ first + * - MacOS + - ``brew update && brew install $(brew deps --include-build qemu)`` + - Using `Homebrew `_. =20 Windows -------- ++++++++ =20 You first need to install `MSYS2 `_. MSYS2 offers `different environments `_. @@ -104,7 +152,7 @@ build QEMU in MSYS2 itself. makepkg --syncdeps --nobuild PKGBUILD || true =20 Build on windows-aarch64 -++++++++++++++++++++++++ +~~~~~~~~~~~~~~~~~~~~~~~~ =20 When trying to cross compile meson for x86_64 using UCRT64 or MINGW64 env, configure will run into an error because the cpu detected is not correct. @@ -115,4 +163,3 @@ and force a cross compilation (with empty prefix). :: =20 ./configure --cpu=3Dx86_64 --cross-prefix=3D - --=20 2.47.3 From nobody Sat Nov 29 10:15:38 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764354192; cv=none; d=zohomail.com; s=zohoarc; b=I2hzq8zpZDKMl+u37mkCWqUaqGf8seeXDHL74rZHMdaP8STaMM0zNIsAheHBhqnqjbLBg2SJ+H5YqsvPCIxPmEosGermwn4b2ysxeamKZ7fn62yGodzWqgoZ/02RMhKe23KNB/2m8djHlVE9rfUjEt8+aqsu6k7gHcJG+DfCrOY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764354192; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=esgdSOmxvxoM6dFXZTRW1Fb4sqxSg/3cnp175TBjiD8=; b=W0e7t9a07DY2mUfZDezJeh9otkyQTswZWr+2CEzcy1dqF8xrqrOX6xjSZYkeKx6BOYbWNOiCSaTGkp0pNfF01HF+cjSNBDytjKkxgkNBDdSDBuo8VkfwJtws8IR1sZlUexur0y7q5IFlDrOvPWEtgC3onW1aecMPcARuKt6PWm0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764354192097992.3526846399342; Fri, 28 Nov 2025 10:23:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vP36t-00031S-0s; Fri, 28 Nov 2025 13:22:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vP36k-0002z9-7z for qemu-devel@nongnu.org; Fri, 28 Nov 2025 13:22:15 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vP36h-0003A8-KK for qemu-devel@nongnu.org; Fri, 28 Nov 2025 13:22:13 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-47798ded6fcso11753015e9.1 for ; Fri, 28 Nov 2025 10:22:04 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1c5d6277sm10790714f8f.17.2025.11.28.10.21.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 10:22:01 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 3C47E5F901; Fri, 28 Nov 2025 18:21:58 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764354123; x=1764958923; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=esgdSOmxvxoM6dFXZTRW1Fb4sqxSg/3cnp175TBjiD8=; b=FARoRGXVly9U2u0fWqbwJJOXg3NfIJYKggCnVzqK3M0eIELLOWPGZDSvgXLirOOHIX Q6oThUbXWjS/C6ChkRnUZm/RdWTIP6VmOKmEDALhCpBGXAAjCyqqK3q/NWX8X46MYooj P37snoTdfuzXG7ULamCSdqe1ABpbNlBY8dOx9K3eFvbxH1edNwcpFt4xTI/xW+lIHHEq qHayo2l+3Sw59yjADRqEu4ab4l7dVqCM2AaJxomVYyQQ3c6QsVDqBncIl+aFrMq26To3 gUtPF67oHAp9+ZrmhcrQ6ZbZ/tSRW0shyCWkqyGBwJnwcvnEmVghHMtMG+6RVB3bQyPa YvZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764354123; x=1764958923; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=esgdSOmxvxoM6dFXZTRW1Fb4sqxSg/3cnp175TBjiD8=; b=QKLrCUBggK4Dlaq9ruGKbWN3pPuI0w9xNJXw6MwgE8Q3wnT8ryIDABpIgbY7qi9WZw mhbvp+IwqBWZJfm0r0gjkwHDrk0Bs1n0lRUS00N+2UvJmUQxEb3vQLcmL8Xjp4XgCY90 rzfXsfrrptKabiJHjYeyZRhEj4cXuL7Q5XBZxK/dEe//+NndaWPB8pbmHuAOUR8wCNKG hMIwcMP56bZtk70mNld6Kgb0nJDZLjqLxffJYyi5U8AjmDb1i/FgiBTMtlYRYmllbbka W4MkpmLdOzYmQdCCNSDfZt4xSpD8d0eGk8ZSceOMu3IZvzmR3oyUStDlqe1T+04j4Mt6 O2Mg== X-Gm-Message-State: AOJu0Yz8jvhI+1/exqkluI0HG78qoFdxd7ehYr0hqd99rQk47JK+V4+e 4rcxaS4vz/bJQxrgxpbeo0uKQI6+2m1ko+qVzvbFTzd4Gu8ygDQpI9JnoWoD4vvc2rM= X-Gm-Gg: ASbGncsW3xDxydIo3b+jxfOG7uMZmoy87E7AnUgalumJwH9QlvZo3P9z1rYdkXL1AG7 n2P+d0YD0+yldX4ZG+5cyrlPvVP0K/dVugvNgE1C384mKWbkaFH2LKp35VfW8wFMqh+e1Vav14x rN7ATWDBjVSnId8UOa1AS8Vwnasn/pQ6VeTfbmQDA3i6If0W07x1CLHvYk2hswNWhClW5AGw30X 3NCujD9MVT9w9KDRr8RjsDpPNPIHoHsMUKvOsgT8p0E/olXpYkr5+ipAGXB761/umuv3u4/9u3N zgxzHOn3a9m7rvcEc5jK0D+dP+b5mWT5eK6LabiuoiTAVBnuqyP4elbA3TmoyYSEjIMOZWZo+uL kS/hlHhC+CM2rZFTuU8kIZpxaca4iFol4X/FtpYnWfxQmiidaCwWXE0Mo38pfqjYZI5yiCDRQir Wwjk8ciVT23p8= X-Google-Smtp-Source: AGHT+IEElwhQapHzhGkC4j6s5mIyKJ1Fs4Zxn7EqlQSunWLgsytllkXPRt2s+YweeXiXIXwic5P2dQ== X-Received: by 2002:a05:600c:1f0f:b0:477:8b2e:aa7d with SMTP id 5b1f17b1804b1-477c1132bf2mr293186825e9.30.1764354123161; Fri, 28 Nov 2025 10:22:03 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Markus Armbruster , Mahmoud Mandour , Pierrick Bouvier , Alexandre Iooss , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Julian Ganz Subject: [PATCH 5/5] plugins/core: allow reading of registers during discon events Date: Fri, 28 Nov 2025 18:21:57 +0000 Message-ID: <20251128182157.4125745-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251128182157.4125745-1-alex.bennee@linaro.org> References: <20251128182157.4125745-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764354192845019200 We have protections that prevent callbacks that didn't declare themselves as wanting to access registers. However for discontinuities the system state is fully rectified so they should always be able to read the register values. a1688bc86ce (plugins: add hooks for new discontinuity related callbacks) Signed-off-by: Alex Benn=C3=A9e Cc: Julian Ganz --- plugins/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/core.c b/plugins/core.c index 8f8bc7219c2..b4b783008f7 100644 --- a/plugins/core.c +++ b/plugins/core.c @@ -119,6 +119,7 @@ static void plugin_vcpu_cb__discon(CPUState *cpu, struct qemu_plugin_cb *cb, *next; uint64_t to =3D cpu->cc->get_pc(cpu); =20 + qemu_plugin_set_cb_flags(cpu, QEMU_PLUGIN_CB_RW_REGS); if (cpu->cpu_index < plugin.num_vcpus) { /* iterate safely; plugins might uninstall themselves at any time = */ QLIST_FOREACH_SAFE_RCU(cb, &plugin.cb_lists[ev], entry, next) { @@ -127,6 +128,7 @@ static void plugin_vcpu_cb__discon(CPUState *cpu, func(cb->ctx->id, cpu->cpu_index, type, from, to); } } + qemu_plugin_set_cb_flags(cpu, QEMU_PLUGIN_CB_NO_REGS); } =20 /* --=20 2.47.3