From nobody Mon Feb 9 05:00:16 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1764122582; cv=pass; d=zohomail.com; s=zohoarc; b=ky8IACVPUDanu0NZDY+INRQvQi6v0MBSew01Nye2hy9/KzE8AWXJ/M0XD0+dfAuqXetI1QRjtqrTtCsH4/9yL0gRJfwvH9WtpYlJ/cS8uyIHy77hSC4PFwyfKox+hgtvyA0qIwUs5Vc4vIIO7Q0x92Z6fNR6L+HIiQvDjiMus/k= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764122582; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=U1gkB3o1NEuWSGuVI24D6NEwy/kKHWK0wS6FvAkvqpY=; b=N+MUWv3E29FVegAiFVmbw2uzh1BJP6OPyYBphv0eZYpkTuynDmrX8SPHXcIQbYK7IPaLdTMKy1CeouWQqPqcjwVXNNewJ0y6jHhPqIGR/VAUZ+U6/CZphNGpW6mrlsS8BR4cSgnNHRXPx272+GFIiyOUVFiu/vQPvmXHf7N8niY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764122582040669.3464059794031; Tue, 25 Nov 2025 18:03:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vO4rn-0000za-Ja; Tue, 25 Nov 2025 21:02:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vO4rl-0000sm-4E for qemu-devel@nongnu.org; Tue, 25 Nov 2025 21:02:45 -0500 Received: from mail-southcentralusazlp170120001.outbound.protection.outlook.com ([2a01:111:f403:c10d::1] helo=SN4PR2101CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vO4ri-0002ZX-Sj for qemu-devel@nongnu.org; Tue, 25 Nov 2025 21:02:44 -0500 Received: from CH5P221CA0010.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:1f2::28) by PH7PR12MB5925.namprd12.prod.outlook.com (2603:10b6:510:1d8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.11; Wed, 26 Nov 2025 02:02:36 +0000 Received: from CH3PEPF00000009.namprd04.prod.outlook.com (2603:10b6:610:1f2:cafe::81) by CH5P221CA0010.outlook.office365.com (2603:10b6:610:1f2::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9366.12 via Frontend Transport; Wed, 26 Nov 2025 02:02:35 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000009.mail.protection.outlook.com (10.167.244.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.7 via Frontend Transport; Wed, 26 Nov 2025 02:02:36 +0000 Received: from honglei-remote.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Tue, 25 Nov 2025 20:02:33 -0600 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RM/Gc6YRQzhLVPsc6cGZsQMje4UG1ovNwsszblJGt2E7SQsT7oc7IZEnnf5GHt9uSp2YFqku2GxxU4524jN0b6xDV8DnXeJjhHBJebYDTFfATfV42y9OqjiHi35Wq5JnUrAFm6PWcllxwal31/wdHn0N+PBhOIY0N7HhyG6gJ8nJp8NrehoqWo6zKWSCZH6nGXoKq9Ijpu9mshrJ9cL3mgxv9GTZfmnUurdYsK4PNAssAmlVcWi96PCksI6cEvlioR0N0oMBOfQRXkcHN54Z2YQNVAHdLirN8zCdOgc6ySLCHtrY/qYP3tgD214cpeTd8FePEL++I9Kjf6PEQV+clw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U1gkB3o1NEuWSGuVI24D6NEwy/kKHWK0wS6FvAkvqpY=; b=LhVB7arBUuT8X1V2Tss1mB6S9BPvCvN+B9mlsZ65mZMEnp0rl5CZd7xsE/qH6YABC42CaGzauW4tCMqNtASoX18YSD0NH0lOlZvaDcgodU4myc/sskZj8WqZ2BR5AWip652+kkyqN0+ZNQA0P0NL+aSOd+mKWKBATaYYMoVDD/oFsRe3dRWHw7NCVWVdhLT4fBKuCnervK2v67Sa86a0rAgmHxRqum/NBmyh+3AmRjci2j9OxhzxU7hcVX1cL4jJIx2CeTzbELrEjTd88GGvvQN3UW88ay+cXw0KYLcjA/H+Wo/LYqkySVSmz1G2NazgmAnRZRGTiI9Tp8wZk6x8kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U1gkB3o1NEuWSGuVI24D6NEwy/kKHWK0wS6FvAkvqpY=; b=EKlgOBAcsyG+37bV9jNtZVmpWwDacGC9MACXQSH/cqdmrf0n8PRP5Xsq9BZCt950lJ15rypD/cNjPqUzIXJ6+iRopnLa+MGuYyuvJ8yKx1xGlyd3q91sg1EauXzBNxP8T4mw57j0iALPl05vuX/vgr0jRUpdB4euARgU3w+rC+8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Honglei Huang To: , , , CC: , , , , , Honglei Huang Subject: [v6 1/2] virtio-gpu: fix error handling in virgl_cmd_resource_create_blob Date: Wed, 26 Nov 2025 10:02:07 +0800 Message-ID: <20251126020208.2449414-2-honghuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251126020208.2449414-1-honghuan@amd.com> References: <20251126020208.2449414-1-honghuan@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000009:EE_|PH7PR12MB5925:EE_ X-MS-Office365-Filtering-Correlation-Id: c5f702b8-be00-43bd-ef77-08de2c8fdeb1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?yK0vtlA641AheYHcEuOxgoM40k9X7a7I1n4Es9a+UUPqfbe6UGwYVtZNCtA8?= =?us-ascii?Q?u/g/hYhHMVCwEP1sAqMpvOQ16xG7qakgxoO8ykwprjQnXb5RQNJgEcpTLmXv?= =?us-ascii?Q?OlNmPTtGbOd+R0jHQzNmjUDMU2h+YTncceBkNxVyQU1Lnz581Jdaw2LPDVcA?= =?us-ascii?Q?q+kABl/9wuS+mQYvoZLgvOtFjjgWJ0s05g+o2bDKgnebiYKzxJjRCw9tUYBk?= =?us-ascii?Q?yQc8bK/ZlQKgRKf2L9W9O7lJtn0srpDU1E4KCLGkEft7GbcVwOMOUs5omrG4?= =?us-ascii?Q?9jm7MpTA7RgwPj3GNStRbK7xDUNAbV2B3mIEOH15WPxaBC6Ae8e43Oof7wFp?= =?us-ascii?Q?Je0MeuyVcfXxbHhVczF17HUVe46Rcm/AwKoK6SJf23AltEYFoa5Ia+OjZBgH?= =?us-ascii?Q?MzAZ3Oqf+4Lrixb7uSjYs8LsiDCPf1v1Yly2DR7SMKCs56XXpSO1IFi7CHUE?= =?us-ascii?Q?APBXoQq8B37lfv56vChhfGcnsua7ifdcUdKWaCG2sJvajyqCp6k+HyD0c+bZ?= =?us-ascii?Q?Wb+8VwgI7NkT3J4oHZ0zgqHORWLmUG96LKGryJJQxqv4ab47edaKb9NJUveM?= =?us-ascii?Q?VxUfYBkrl35y8zF5YInxZqdM3CZsT/ndBsip9oKTeqvD1km0j58ikv72bZDm?= =?us-ascii?Q?aPJsOSnz9EN8i79v9FQkg6H5bQvfuOMeObd0FIx96tHzWHIjZaEen2WCuo6k?= =?us-ascii?Q?sXoi3eSQXxvDePP3FqB0djpTD/4dnK3zED2GY/lGwfPZyAWTw+jxUYf2gbCJ?= =?us-ascii?Q?bVL64aTWx7qNn5uuQWQ4cXFd1WHAChpyoFpOVg0vX5x/Wym7DO3x2U+8bX59?= =?us-ascii?Q?zru/rJCu+LyBGvunoLBxF0p3M7V0Ix1WXzDp/bgPDLwGiOCQHgB50EUFuGOm?= =?us-ascii?Q?3+RoDqN9m8KcMyYM8ippxJqpseWPgBCd5sHl93E00suEAxXEnbE6R/gnGoWd?= =?us-ascii?Q?1Jp4fzLHl44lt95gtVP30S4hY+QdjhR6Wa/sdqBVdm8P7pAVP6QsThom7TWA?= =?us-ascii?Q?EDYH3tmmQ+jgfYufhyaEM52PwE5xQSl3XeFns1P9oC+zY1hGPO5yRG/X2VHk?= =?us-ascii?Q?TKOL20r4LlvWQxwgVzmzFsHLcdpT61ildBjsn5eiF3sup4TdWHo7unMwU/Ug?= =?us-ascii?Q?rTd3RflU7csah1OeaLaF4MdAjTOl3Rl+4BkI+Pzvonbp4yq3j98z+T8l9grE?= =?us-ascii?Q?qR5TamPMzHXwsMIKlPe7KFbTQZhMCx/zYbSeyOkQS9IZbkM8Blg8E1oET5K/?= =?us-ascii?Q?eBEV2m9xenT9nfeLbQ4z6NVM5v67TSN7hR7lRggJdcgkHS+qAPufUZuGUwPm?= =?us-ascii?Q?NMFmKlsw0KtFlsdPGqi4AnkK5smp65jeQBGtNevfK0LpkcvXAwsnHyRRWers?= =?us-ascii?Q?xvLnkwsGfT9T7kMYmejL+rjCbpiB12IIH1Z867lSz+EmsxPmRSbrG6x4CJEo?= =?us-ascii?Q?tX3sy7RxExFvJdzlwIesP+QMiQRJt1JPJUIe6hpCGrFTMGBzQYybOnwBXq44?= =?us-ascii?Q?H2fyt3aagFwWUlNDVJLvhuG7YGOSd48PzM7Gchc8Y8ynd7IXH3kwidQvkbMS?= =?us-ascii?Q?OH+gTtPpHk6Pmi1bCbw=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2025 02:02:36.0794 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c5f702b8-be00-43bd-ef77-08de2c8fdeb1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000009.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5925 Received-SPF: permerror client-ip=2a01:111:f403:c10d::1; envelope-from=Honglei1.Huang@amd.com; helo=SN4PR2101CU001.outbound.protection.outlook.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.152, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1764122583737019200 Content-Type: text/plain; charset="utf-8" Fix inverted error check in virgl_cmd_resource_create_blob() that causes the function to return error when virtio_gpu_create_mapping_iov() succeeds. virtio_gpu_create_mapping_iov() returns 0 on success and negative values on error. The check 'if (!ret)' incorrectly treats success (ret=3D0) as an error condition, causing the function to fail when it should succeed. Change the condition to 'if (ret !=3D 0)' to properly detect errors. Fixes: 7c092f17ccee ("virtio-gpu: Handle resource blob commands") Signed-off-by: Honglei Huang Reviewed-by: Akihiko Odaki Reviewed-by: Dmitry Osipenko Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/virtio-gpu-virgl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 94ddc01f91..e60e1059df 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -701,7 +701,7 @@ static void virgl_cmd_resource_create_blob(VirtIOGPU *g, ret =3D virtio_gpu_create_mapping_iov(g, cblob.nr_entries, sizeof(= cblob), cmd, &res->base.addrs, &res->base.iov, &res->base.iov= _cnt); - if (!ret) { + if (ret !=3D 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } --=20 2.34.1 From nobody Mon Feb 9 05:00:16 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1764122632; cv=pass; d=zohomail.com; s=zohoarc; b=no5mL66R4/YtgdQ32GzolSvY0u6O0ZPcVO96SdmDvqfpFCSWmF+ek7RMDZ4mpwjoZ0XzqQORAhuKohXDJCXipLrWZlCU0HynQpEVZ75ppoc02OIHAv+g7VZc8zxM6R+wzjTGh1weuW8wyyH8Kri+RP+X0JfjNxFyGctmso/jO1w= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764122632; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Q7Tn0BkLKu+HeQ1JqYp33MBxN2ExdmuRRhuYwCIUWhE=; b=h6GCvJMQLNSJE2aFyaqQVstqFWmqR7xABxxE6SSfncnRBxVJW68Sa8mMQEXe66FmfgJ9CTqe8sEDxlhoH7gliP8BE64TSRxdLTWojrPok0r46fNLIXvMc4Qww+3t+LobUX0mXNFdPHh8SRM1QAufeUo+0aCkXetwsFft4NDDlpQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764122632442710.2878854644682; Tue, 25 Nov 2025 18:03:52 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vO4ro-00012w-H1; Tue, 25 Nov 2025 21:02:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vO4rl-0000vx-Th for qemu-devel@nongnu.org; Tue, 25 Nov 2025 21:02:46 -0500 Received: from mail-southcentralusazlp170120001.outbound.protection.outlook.com ([2a01:111:f403:c10d::1] helo=SN4PR2101CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vO4rj-0002Zd-8F for qemu-devel@nongnu.org; Tue, 25 Nov 2025 21:02:45 -0500 Received: from CH5P221CA0008.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:1f2::24) by SN7PR12MB7953.namprd12.prod.outlook.com (2603:10b6:806:345::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.17; Wed, 26 Nov 2025 02:02:38 +0000 Received: from CH3PEPF00000009.namprd04.prod.outlook.com (2603:10b6:610:1f2:cafe::a5) by CH5P221CA0008.outlook.office365.com (2603:10b6:610:1f2::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9366.12 via Frontend Transport; Wed, 26 Nov 2025 02:02:37 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000009.mail.protection.outlook.com (10.167.244.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.7 via Frontend Transport; Wed, 26 Nov 2025 02:02:38 +0000 Received: from honglei-remote.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Tue, 25 Nov 2025 20:02:35 -0600 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=s214Ur19/cJTi7a1S9gD+FjWFHMNbqLUkfJ5ZlQ8lcDOpGtfLnJz8LWBkQGDyO6khjM7VTX66qbZKFgHb3PU8O8OnKUT1xtI5f/Eb1X+wMNt49uHUqeK4P3V6ra0HX3tNgQuryVBA7XPwBGntbWFk1SnIS6wHNcoKJfuF75Gf1/ev0ovjOsOS3HoeLULcENZy95UyvkTvCSUMDn13qJJOZ1vYAyLDh8Tkhv3x70Ry3pZHk9bebm4OuFZLcOMUxD/X+MjbOT/tpv9/SXhpehlSzi8/W+FeX0DhKIJIGB7IjE4hOs8i3TLLeNbXrz8jW0FGBvCk7NuSbVFACkY1WSfew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q7Tn0BkLKu+HeQ1JqYp33MBxN2ExdmuRRhuYwCIUWhE=; b=HxQv6dJhjXZtwGISRbFziV0u2hWBH2srQsw09PB2ibz5tiAENl0DUFk2GwDbbQ7a5KefVDxhJ4hzOi2nDpNNf47XAQt9CXbmQQ5tEfFmrumwvRdd2IeYAcLVC/Ng+62ZU8rHxavCnKOlD/04tFwXmMlMSE051dv2UZfOCWAxni6j3roT2iDdOqAfPX08rMU7i4iXlm/snrPfU868pCvTzNnjBtorD9HMDqdFMoPBYKfAjxjvxi9idYCXHS9B63+lE30t+J4Gxj06bYf7NC65driPEhw2P31V1wEVN9QM5C9JjnCGOHt9XBK2nlCZjFRqFhdCzOlwt8o3mMAu2EsJWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q7Tn0BkLKu+HeQ1JqYp33MBxN2ExdmuRRhuYwCIUWhE=; b=TxxG2+hG1fzOAxB62AMOWMhCeytrSVvwVGzt6iJWJ+RvSwa+Ny9tgZbC8zCRysqOMclNzMdToAQkmZ1yuKGgUW7qz5VXXiaeui40n6vhwhdZif8cgSgmjfE+D8kt7OfH5lTo+pk3NtM+ye4O1/EPHyZIEmdnBisi9dwsZzFcsbY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Honglei Huang To: , , , CC: , , , , , Honglei Huang Subject: [v6 2/2] virtio-gpu: use consistent error checking for virtio_gpu_create_mapping_iov Date: Wed, 26 Nov 2025 10:02:08 +0800 Message-ID: <20251126020208.2449414-3-honghuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251126020208.2449414-1-honghuan@amd.com> References: <20251126020208.2449414-1-honghuan@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000009:EE_|SN7PR12MB7953:EE_ X-MS-Office365-Filtering-Correlation-Id: c1444a66-69f3-4269-3af5-08de2c8fe020 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|36860700013|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?OPrcKpfAuEMF3TKzWYbkVsp6nIeBu2AffyofH8pMS3k0uozTSMnXmrdgVAha?= =?us-ascii?Q?g7T7sUK7trzfauXNyXLUGPSQPaD15rAogQVKO5KsMUAr6wETZXyIQS9GUxEi?= =?us-ascii?Q?/r0ahmjCkqEX9Zxqi9ZtmZKMOzJPX8vX08VnqWT/O70NTAYJNzNwR8LEmyE/?= =?us-ascii?Q?d7V3A+NeFauMb07FbCIORO/YPTMoJChW9MOUath9xy1X5IGZ8PsZrYtMTki8?= =?us-ascii?Q?RtWgLHc0LNB2zik11k98E56HKSbsBYF7p5Vt1+g0gXQHTlOEzVHBzadW5ejO?= =?us-ascii?Q?dx1VntUVgmcS2J+dc19aaLyUiAUwTv0U7Rn5e+BivpGzKnc1Qdr4KT4klhRk?= =?us-ascii?Q?DNaHxk+MYWb9f+8+982zENYQ06Jr2rHUvrhARzfKbFe3F+VtX5D/mewMDLx6?= =?us-ascii?Q?jVjeyb/DCm4ErvJS9HAREhjBPkyYS2SFfRveHHEiMEJNyrwf7XodnKVDtNfo?= =?us-ascii?Q?BUs9FjNH3roLzJl8zU/CZFCDiQHxu0Md7L2TxvIZB2GL0P6S+sfD3Z0wTFwl?= =?us-ascii?Q?/3o7KDd3MWcu4g3wi50ubdbiM39Ll4aNQl3PYqWq8VGgcrHR2Kkf4ZQzEul2?= =?us-ascii?Q?6PW1cub0bLIxXdWNBoJBY4SJ1Dm14YZq5MZmqiyNS6AQvtAAtFOFi415Qd+i?= =?us-ascii?Q?Zlml5ZlLnsyhUOBehJyFD/BT1Ky0sP0dWvB4mbqbfrS7or5XVUm1EpfgaP01?= =?us-ascii?Q?InKMxk7aqpxGhFUdgjIO2DB2KkQzPadxCUqBBv/dwMkoQPnIjDB6gkeRQVxD?= =?us-ascii?Q?v5Xr0/B1FuO9MJ3RV2QFG/RElw1+xBLcGT95Gon6nRmCcuRz+mHS3k7mo3B2?= =?us-ascii?Q?4CidOgSdMjhf+a6Rpk3biMOo1XhOnPgJzAGqujl4RxfVJM0Ro19if7YTdQeB?= =?us-ascii?Q?fw+tbQWK3WXgFNjtbqspHmVISACw/z5FAlweRgdMv2Hz2xz2zDGTMWtY6dwE?= =?us-ascii?Q?IjTjnY6Q8dYm8Z/TBl7lEC/hC03QLXdfWXIWOeJ08gBOprT/6pTkbdwo/MQ2?= =?us-ascii?Q?SqU/wOdoW9o6x1ednbY7SbAG/TR+YbdE/MRbKEYbDARllTTIDcbzWp87RnBr?= =?us-ascii?Q?WXutWtsRU7U6LW9r8SPpwY9UWoMu+XzeuPdCAe2nOdF2sbU3y1+WZNlAPTqj?= =?us-ascii?Q?Q7g+YFQ6fgKPbbf7HL2Ufyw5hKp29vX5thfWO7zpU3+T8kXYC1G2EJegylnN?= =?us-ascii?Q?EiA+0/SAAxY+Nwxl6TkpjQ41d2mNUfzEAQKa/K1tvokORbtsObPCvzEmDJiL?= =?us-ascii?Q?LgkIuuq+jfFBrcVyrZo/RrWBMWNKrA5ltpXZpOhdm2OB6fJrsPun39atw1VT?= =?us-ascii?Q?U2tHwqlRSQN8GhCCejnFUfYZ8jTsQn83Az7VGlefHV/4/L0wE/I5VBfD1GMN?= =?us-ascii?Q?tg1KK3l+bUjFJVyfC8eCXaDt6QbphPcUuOv98YrG6toDuSvf5eE5JXUDCm2d?= =?us-ascii?Q?j3SNurWkeckk5Lzm19oXJFkd3KkdKQaL8LL18DUS4kUud84uVmksRJflRCmB?= =?us-ascii?Q?+DPU1cSTtCyDMqtrZ1ZuxWADwdJ7y+KChtUtowshMkE5PfBgcV2oQ1DmWK0L?= =?us-ascii?Q?hLGkk/NDynME5nUqkz0=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(36860700013)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2025 02:02:38.4783 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c1444a66-69f3-4269-3af5-08de2c8fe020 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000009.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7953 Received-SPF: permerror client-ip=2a01:111:f403:c10d::1; envelope-from=Honglei1.Huang@amd.com; helo=SN4PR2101CU001.outbound.protection.outlook.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.152, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1764122633836019200 Content-Type: text/plain; charset="utf-8" Unify error checking style for virtio_gpu_create_mapping_iov() across the codebase to improve consistency and readability. virtio_gpu_create_mapping_iov() returns 0 on success and negative values on error. The original code used inconsistent patterns for checking errors: - Some used 'if (ret !=3D 0)' in virtio-gpu-virgl.c and virtio-gpu.c - Some used 'CHECK(!ret, cmd)' in virtio-gpu-rutabaga.c For if-statement checks, change to 'if (ret < 0)' which is the preferred QEMU coding convention for functions that return 0 on success and negative on error. This makes the return value convention immediately clear to code readers. For CHECK macro usage in virtio-gpu-rutabaga.c, keep the original 'CHECK(!ret, cmd)' pattern as it is more concise and consistent with other error checks in the same file. Updated locations: - hw/display/virtio-gpu-virgl.c: virgl_resource_attach_backing() - hw/display/virtio-gpu-virgl.c: virgl_cmd_resource_create_blob() - hw/display/virtio-gpu.c: virtio_gpu_resource_create_blob() - hw/display/virtio-gpu.c: virtio_gpu_resource_attach_backing() Signed-off-by: Honglei Huang Reviewed-by: Markus Armbruster Reviewed-by: Akihiko Odaki Reviewed-by: Dmitry Osipenko Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/virtio-gpu-virgl.c | 4 ++-- hw/display/virtio-gpu.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index e60e1059df..6ebd9293e5 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -557,7 +557,7 @@ static void virgl_resource_attach_backing(VirtIOGPU *g, =20 ret =3D virtio_gpu_create_mapping_iov(g, att_rb.nr_entries, sizeof(att= _rb), cmd, NULL, &res_iovs, &res_niov); - if (ret !=3D 0) { + if (ret < 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } @@ -701,7 +701,7 @@ static void virgl_cmd_resource_create_blob(VirtIOGPU *g, ret =3D virtio_gpu_create_mapping_iov(g, cblob.nr_entries, sizeof(= cblob), cmd, &res->base.addrs, &res->base.iov, &res->base.iov= _cnt); - if (ret !=3D 0) { + if (ret < 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 0a1a625b0e..1038c6a49f 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -352,7 +352,7 @@ static void virtio_gpu_resource_create_blob(VirtIOGPU *= g, ret =3D virtio_gpu_create_mapping_iov(g, cblob.nr_entries, sizeof(cblo= b), cmd, &res->addrs, &res->iov, &res->iov_cnt); - if (ret !=3D 0) { + if (ret < 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; g_free(res); return; @@ -931,7 +931,7 @@ virtio_gpu_resource_attach_backing(VirtIOGPU *g, =20 ret =3D virtio_gpu_create_mapping_iov(g, ab.nr_entries, sizeof(ab), cm= d, &res->addrs, &res->iov, &res->iov_= cnt); - if (ret !=3D 0) { + if (ret < 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } --=20 2.34.1