From nobody Sun Feb 8 22:53:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764107370; cv=none; d=zohomail.com; s=zohoarc; b=LQckfe5cNQKbqmnnLgwtQG7DW2K4Ms6hniqcPzzogGpeLdlmP132+fUxUn1ZDQOp/p5LOkiHrdFRueg/vblMikOQaQ4R3BqdSob/hoEX+z84Cr7iLmyYur5+kH4hSXehKR9jbTfQkpCMzjjXd6EuN7707svqPUP8fRMFlFS62Ro= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764107370; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=0m+k2UyUztzmcb8I6pH4YXiVmZQfT+gR4LS5nZYwQho=; b=A2eL2tuAyx8UsUh7PotN1rsWWTV1IP++ZLr+lTI1V5+8DlY/bNvgG3NJHU8QN8FMUI+mHaj3oqb+/7mF8k8rWybr6ZCbDX/CNrWKj6h+38SRj5Yzg8DFS8wk4xLgqLF/PzKOA54XAs7sv9x1HY/10hBln4JMtihwMOnAqFQUUzk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176410737088584.57502108870199; Tue, 25 Nov 2025 13:49:30 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vO0tj-0001WU-4D; Tue, 25 Nov 2025 16:48:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vO0tV-0001QK-My for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:48:23 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vO0tU-0005CS-4E for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:48:17 -0500 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-429c48e05aeso128610f8f.1 for ; Tue, 25 Nov 2025 13:48:15 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fa3a76sm36678238f8f.24.2025.11.25.13.48.09 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 13:48:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764107294; x=1764712094; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=0m+k2UyUztzmcb8I6pH4YXiVmZQfT+gR4LS5nZYwQho=; b=vyR3oRPE0W4AE8SfMECR3A4Qx2pB+beXuJa2eW0idKPVkLt7FIvBwNki1K53cv3nCR 90OE8nTn5E+cIhHgXE2di7NJlUVo1hNRC/yVonSMkNBfh2TRwiQv4tMqtjzsXMwIqMbd 7eoxq+jG1YZcLqUZsZgzlFhKbf4OJ8dxae+EtXZw0Jt+fgF56+yzNjLsrRp1PBvzix+p 3qSy6KgK0TdQvAztgSwBe5w7VWFdnh0JkhrRs+DbE0PGP513RVusWuucheeVBHZ1XDZo N5Z0lfd1zVtEY5kovcDoGwMoEobe4kSNVN/k1qbap5DVe0rl8Dc2cli61sMn3J5dTBrc 7D1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764107294; x=1764712094; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0m+k2UyUztzmcb8I6pH4YXiVmZQfT+gR4LS5nZYwQho=; b=DBRZj2aba7v2BeTVWirV5+SgV0A3dnnyArhcn999s1lK+AURaaYH9nfakINRmc2cvT 4RkT9O5SBdLL8PWunWizgvXrAo5N7+riSPmY74zVGX/e5uvyh5vfLDpNyHsaDqWCfkTt pZeb8ul/jo4r2lgnxcKJ4c9VAStzZNX1Kaana9wy92FnhZhH3noNnYYAZZb3Snhdh5Yu a8qxOCDgNxjtRVdQjCEfm7PDs5R5AO2pO/iAUO3NrLtqcPTX3rJ/xjLLOzoT+UF1QEjm vf6OLXNSPl1vmx6zMnL3qb2ZQsUm9U9dguMSY0Bu4oiMRK1MyZ6Gr4azfPkve8ICSyXx lRag== X-Gm-Message-State: AOJu0YzGUXC7siVI2kYE81inE3a/04WMnEzNq06y+ScO+3JPNpDkCTe1 Rn6iMaHoamaVznNuD0qJiJRaJe8LvlP48/0zoAgApHJUPo9I3nwft92VJE3yWXB7Jcqt7jeznM7 7+OEvtAwIkQ== X-Gm-Gg: ASbGncu+98LvzcGJbQy/83HnfN6E2Lw9Rv9MG0qxiR5P3lVfRUFI+bkDN5qikF/pECi n4KaG5abxvckrb1DkWYlVaWwk4XyCfmxoJqEqjuUbXJNIq2W9sWT1RzbcSvFNQ36irPdLX46xro pOCMyWzKnoD2L/arcYiwDrnoi7oID7xPLl3kPjQ97JC/fiMsax1+L5+zJMF4ZktfCdLyzNoKOos 0eEZI+FdfUwr12Nm+bu8zH+F0vI2lKyUgo0BE/oVkFPIQdDAnS8CReiHLCtvNuoFIKuo0p6TpmE cmUE2ArrfOjr2RFTBj81PuDVXAW/gE82/CxOOSl3bXp3a1rvCwden+xEuxGkfZI7Xarv9k/vGEK UQWw/7UvS57St7YCpA7AWkBeCjacsxsndjYXnld9BWEoX3Z2uLkQ6OAM7tWbPFD146v3t4l3ma0 lffpPyTmoSr/fg1GE8e8Wy/F5tPdcG1Mzi0GV+Rdm2I33PqFdVlcb5ExRBRdpg X-Google-Smtp-Source: AGHT+IEG7a34iYTcnYTKnB2EeWKdfViP10xcsFGjFIFNuYI9ddq01JQajN40YNIBZkoT7wCcjihTjQ== X-Received: by 2002:a05:6000:1a8a:b0:42b:47ef:1d59 with SMTP id ffacd0b85a97d-42cba63b5b2mr24795015f8f.4.1764107293971; Tue, 25 Nov 2025 13:48:13 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 1/9] qtest: Allow and ignore blank lines in input Date: Tue, 25 Nov 2025 22:47:53 +0100 Message-ID: <20251125214802.1929-2-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125214802.1929-1-philmd@linaro.org> References: <20251125214802.1929-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764107373742019100 From: Peter Maydell Currently the code that reads the qtest protocol commands insists that every input line has a command. If it receives a line with nothing but whitespace it will trip an assertion in qtest_process_command(). This is a little awkward for the case where we are feeding qtest a set of bug-reproduction commands via standard input or a file, because it means you need to be careful not to leave a blank line at the start or the end when cutting and pasting the command sequence from a bug report. Change the code to allow and ignore blank lines in the input. Signed-off-by: Peter Maydell Reviewed-by: Fabiano Rosas Message-ID: <20251106151959.1088095-1-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- system/qtest.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/system/qtest.c b/system/qtest.c index cbeb7f37728..67e2385f4b0 100644 --- a/system/qtest.c +++ b/system/qtest.c @@ -69,6 +69,9 @@ static void *qtest_server_send_opaque; * so clients should always handle many async messages before the response * comes in. * + * Extra ASCII space characters in command inputs are permitted and ignore= d. + * Lines containing only spaces are permitted and ignored. + * * Valid requests * ^^^^^^^^^^^^^^ * @@ -367,7 +370,11 @@ static void qtest_process_command(CharFrontend *chr, g= char **words) fprintf(qtest_log_fp, "\n"); } =20 - g_assert(command); + if (!command) { + /* Input line was blank: ignore it */ + return; + } + if (strcmp(words[0], "irq_intercept_out") =3D=3D 0 || strcmp(words[0], "irq_intercept_in") =3D=3D 0) { DeviceState *dev; --=20 2.51.0 From nobody Sun Feb 8 22:53:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764107331; cv=none; d=zohomail.com; s=zohoarc; b=RPOV6c4ae9UnBPQl9gOai4Fmmh6hZUUAhNCDVWDr3s/fr0jx/zesDTuRbhd/Kyo5QGIORHI4g9TBBiM4Ro7wEIwTD6HY9u7uAjo2baAy+HqviVe8dLbuNKGZ+fmHaGyllbI6K7KoqQYJ2AVIjrAViOYNx6bs4nSbgH+IKnAA+WM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764107331; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=d6d95B2GWp5Ove4p4VnyCUqYCaY8kuW0FwTElFhEInU=; b=T5MN/931H5JcvR26TmeHa1KMyTjFuhwfZM3QdFx7vx6f5mrcYO5UoL0B/iNPpZsnVoACCni8nsvssa0JmkMBl/LVX5Fv5SBl/3iFb+zwhU7V9hDvbOf0/fIIfAGsl3LF0H5q4IDZHQLJ8Z0DkF5D2TOgNq2sorMy/Ck67EaMJDY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764107331240267.3158434477617; Tue, 25 Nov 2025 13:48:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vO0ts-0001YP-IF; Tue, 25 Nov 2025 16:48:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vO0td-0001TL-9z for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:48:25 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vO0tb-0005Dd-JX for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:48:25 -0500 Received: by mail-wr1-x442.google.com with SMTP id ffacd0b85a97d-42b3c965cc4so125108f8f.0 for ; Tue, 25 Nov 2025 13:48:23 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd8baesm36862625f8f.39.2025.11.25.13.48.19 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 13:48:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764107302; x=1764712102; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=d6d95B2GWp5Ove4p4VnyCUqYCaY8kuW0FwTElFhEInU=; b=E6ZYRZ/5GG1Gz79fkSPOeKWa7SssNATbjIe7M8yobgEtS6BcUBTR+olV9s2lX11/C6 VlE8KGNhYGuLQBj4tRPgh1GA9LcFfjv70pVkP/8Y9mLr09ADYJGoATUwUQR5x3Z4oEHI NfCUTOb3L/VKgQB/KV5PtqDpXwXrh04ffa+eHLuYbVJqPWqjJwqxNgVWlUJGl3wuz7lc d2rzCfnDjB6YuLsKpSO1x7N+jSfOJeW0oOsHi47DuX7jVAuuuEHlGoup0EG36o42EjRf G3BlD81AJVygT2wCcItEJ7PAW1rQ+SDSgUqlS6c1Ipy7ojWNSJ4eWdrINCXWIyYi89Vd XYYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764107302; x=1764712102; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=d6d95B2GWp5Ove4p4VnyCUqYCaY8kuW0FwTElFhEInU=; b=jh9KXx9RxO0qQQ6UP0ELnW8DbF6G605LmOOszgu2Gr1xYZd5ZvdJiha443nvXFUG++ dVnSKbTSRIAQBWx+Uv+tw40mFCVG1199tNj6wQA++QiG2nhAvmaHam2Z7UK5kW5H+sVL cS3RC9FdytBhyJH+ZtyGk2gJ1SJ4pR4qG4AH5ymR6PpN5CjOul3YnX46VNPzTH9zU2qh LpuYaaDh5GcJceZjCRQbOqBMEjwcl8klF58m8Aa9IC63meR1I9MPFX/GFWLB/BLzD/HP VVqb0NQ9wdgTRf5RUX0ERonDzVVqeMbe+yjwxaQWyD+UAsbM4MAfACdD4muYxrdjPqdA gDdA== X-Gm-Message-State: AOJu0Yx1HYXFODed7U0gnvPBGCSHYtzGbYCP26MNYmba0i/f5Cbw/Pxc /vcYtxJEUMq8MqO+qSdG4K8Hr/TIL6WZvKfG447icB5bgqedPive7ydEmzdGK6biz8MQH6aiGLN YWOeYBlEZ7/9d X-Gm-Gg: ASbGnct9xjRW0CaAp6uA7AUHJZ6wFYsi7c9oEUOJfOiPwgASF12+AmRp6FbKBMa+0sU PSP31aNWMjf3xXjwf52Lxuiq6/tF+tobCKkl7g6xgTXkAKQHuMgbZpeWOyvExTIQdugs58HHk0y E5FGJ8fdzTcT6pdL7ic2j1xq17r/SehgWw4cibMqdbHHg00cJjAQXwFHdPDtldrBFIwOGAuYAxY zZ5rPt1g0AVtw1GV86GpSpWtAgxhhMjtC5v71ZEfGb1jXtgcyprNFhtNLUIun8Fxy8i4VCxtmxe a/lbeqLLM8T3xVPfH0RVX+Z4/FdV9wsOrm/f93ECVuqNJurla/DvMj2cdwMMR27nfW8/iea2LuF hcm+hk0SJCPLvEzwJ1OI/zhd4zxgKhcS5yV0S6fx2ycAqj4OOq7trg88yqtG/l9QZn1bzC61mmv bmlXaedbtHfMkSIPjmgXYHolDrURGarHZSNNnT80BJ5+xbM5lRTG4N0aXcCIjR X-Google-Smtp-Source: AGHT+IFD7SkpHNFLe42ShT6gQ6VD9+0FhGQu0QeIhti0WWdCjJP2+E+5xlSML7Rhq2xclARrW40lRA== X-Received: by 2002:a05:6000:2911:b0:429:cfa3:5fde with SMTP id ffacd0b85a97d-42cba652baamr24556664f8f.11.1764107301685; Tue, 25 Nov 2025 13:48:21 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 2/9] hw/pci: Make msix_init take a uint32_t for nentries Date: Tue, 25 Nov 2025 22:47:54 +0100 Message-ID: <20251125214802.1929-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125214802.1929-1-philmd@linaro.org> References: <20251125214802.1929-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=philmd@linaro.org; helo=mail-wr1-x442.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764107332648019100 From: Peter Maydell msix_init() and msix_init_exclusive_bar() take an "unsigned short" argument for the number of MSI-X vectors to try to use. This is big enough for the maximum permitted number of vectors, which is 2048. Unfortunately, we have several devices (most notably virtio) which allow the user to specify the desired number of vectors, and which use uint32_t properties for this. If the user sets the property to a value that is too big for a uint16_t, the value will be truncated when it is passed to msix_init(), and msix_init() may then return success if the truncated value is a valid one. The resulting mismatch between the number of vectors the msix code thinks the device has and the number of vectors the device itself thinks it has can cause assertions, such as the one in issue 2631, where "-device virtio-mouse-pci,vectors=3D19923041" is interpreted by msix as "97 vectors" and by the virtio-pci layer as "19923041 vectors"; a guest attempt to access vector 97 thus passes the virtio-pci bounds checking and hits an essertion in msix_vector_use(). Avoid this by making msix_init() and its wrapper function msix_init_exclusive_bar() take the number of vectors as a uint32_t. The erroneous command line will now produce the warning qemu-system-i386: -device virtio-mouse-pci,vectors=3D19923041: warning: unable to init msix vectors to 19923041 and proceed without crashing. (The virtio device warns and falls back to not using MSIX, rather than complaining that the option is not a valid value this is the same as the existing behaviour for values that are beyond the MSI-X maximum possible value but fit into a 16-bit integer, like 2049.) To ensure this doesn't result in potential overflows in calculation of the BAR size in msix_init_exclusive_bar(), we duplicate the nentries error-check from msix_init() at the top of msix_init_exclusive_bar(), so we know nentries is sane before we start using it. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2631 Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251107131044.1321637-1-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/pci/msix.h | 4 ++-- hw/pci/msix.c | 10 ++++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/include/hw/pci/msix.h b/include/hw/pci/msix.h index 11ef9454c13..551a2bcfe73 100644 --- a/include/hw/pci/msix.h +++ b/include/hw/pci/msix.h @@ -7,12 +7,12 @@ =20 void msix_set_message(PCIDevice *dev, int vector, MSIMessage msg); MSIMessage msix_get_message(PCIDevice *dev, unsigned int vector); -int msix_init(PCIDevice *dev, unsigned short nentries, +int msix_init(PCIDevice *dev, uint32_t nentries, MemoryRegion *table_bar, uint8_t table_bar_nr, unsigned table_offset, MemoryRegion *pba_bar, uint8_t pba_bar_nr, unsigned pba_offset, uint8_t cap_pos, Error **errp); -int msix_init_exclusive_bar(PCIDevice *dev, unsigned short nentries, +int msix_init_exclusive_bar(PCIDevice *dev, uint32_t nentries, uint8_t bar_nr, Error **errp); =20 void msix_write_config(PCIDevice *dev, uint32_t address, uint32_t val, int= len); diff --git a/hw/pci/msix.c b/hw/pci/msix.c index 8c7f6709e2a..b35476d0577 100644 --- a/hw/pci/msix.c +++ b/hw/pci/msix.c @@ -318,7 +318,7 @@ static void msix_mask_all(struct PCIDevice *dev, unsign= ed nentries) * also means a programming error, except device assignment, which can che= ck * if a real HW is broken. */ -int msix_init(struct PCIDevice *dev, unsigned short nentries, +int msix_init(struct PCIDevice *dev, uint32_t nentries, MemoryRegion *table_bar, uint8_t table_bar_nr, unsigned table_offset, MemoryRegion *pba_bar, uint8_t pba_bar_nr, unsigned pba_offset, uint8_t cap_pos, @@ -392,7 +392,7 @@ int msix_init(struct PCIDevice *dev, unsigned short nen= tries, return 0; } =20 -int msix_init_exclusive_bar(PCIDevice *dev, unsigned short nentries, +int msix_init_exclusive_bar(PCIDevice *dev, uint32_t nentries, uint8_t bar_nr, Error **errp) { int ret; @@ -401,6 +401,12 @@ int msix_init_exclusive_bar(PCIDevice *dev, unsigned s= hort nentries, uint32_t bar_pba_offset =3D bar_size / 2; uint32_t bar_pba_size =3D QEMU_ALIGN_UP(nentries, 64) / 8; =20 + /* Sanity-check nentries before we use it in BAR size calculations */ + if (nentries < 1 || nentries > PCI_MSIX_FLAGS_QSIZE + 1) { + error_setg(errp, "The number of MSI-X vectors is invalid"); + return -EINVAL; + } + /* * Migration compatibility dictates that this remains a 4k * BAR with the vector table in the lower half and PBA in --=20 2.51.0 From nobody Sun Feb 8 22:53:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764107340; cv=none; d=zohomail.com; s=zohoarc; b=OG+4p7aLG7AlaBnW7gJ+zSCXoxozdDxyr1YYO2S2J2FCGBQ2J8SBx/dfWzenqb7sRkDuL/7V8/P0zs4i3sFIluCYepDPJxcrjAlSMpTmgKXP8t0ZjsLzUhcHkH93ZCYMukkHB1BLtK2FIchP1IENgU7rPCHiyMcTdPQ/2f/MJ8A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764107340; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=PHzH+lCK4DEu5MLOOUlhaw7zhQlxhytN2R2hX7cMvgM=; b=Qz2DfjZGNi1biTXzwYJugYuxYkdcbDO09FpAVYO43Wla0IX0kXKySSzvykMwCcXd9Ny/wFlU1ssUwXtb+bb7oxpkD9mpoeDXZbyk3OIKIVOxhBgeY6ho0vncle3fepiJYlaMfk0QedHSutNzgYEVRY8C3i0mDnA7mtsYjsOVDtU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764107340878574.2445737917958; Tue, 25 Nov 2025 13:49:00 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vO0ty-0001h9-CB; Tue, 25 Nov 2025 16:48:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vO0tk-0001Yu-Fq for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:48:39 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vO0ti-0005F0-To for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:48:32 -0500 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-429c7869704so5045942f8f.2 for ; Tue, 25 Nov 2025 13:48:30 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fb91f4sm37231193f8f.31.2025.11.25.13.48.27 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 13:48:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764107308; x=1764712108; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=PHzH+lCK4DEu5MLOOUlhaw7zhQlxhytN2R2hX7cMvgM=; b=M2NvBtVAmyesaUDCtfYpYWnFJnTB2cQXlC/GP1fxBzQRB60ZvPPGPITkxiIrYOcMB5 6GK05NXGz+tjGQKl/hNbwV9HnkKEoWDGtRrOexNMqQiF9sVjmUkbEK5ZLPmFim4ybL2x ftZ4L+KdkhAr2lQYWhYz3NHOHOxnKs0Bz0uHq9LBYRMMn7C/BJgSnDnFnQw3qw3UtIie Upr4VHrQ8u5DfkVuwn3o5hFCMOyPwT8lAP9Sar8IqSctn2yJaZ9cihGtbhxjZw7Jwu9/ X4DgFeAqFYGOn8JH72qblxpcs1tmNXL2dV1QqOP7L0xj598qJv6H6vM941cr5H2Ih19I PWjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764107308; x=1764712108; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PHzH+lCK4DEu5MLOOUlhaw7zhQlxhytN2R2hX7cMvgM=; b=S5kHOxXDBlDFmoQJfXY1mu06EwCT3XB8Lnpb8Srby5M9enrIJzvj06bJiRrk2rgOGH v+fEK4VFM6JqMime436vcujBKHBgcega3Fpxa6UBT0mWdHB15kfsbSMIOUjBTY2fgEp+ qi0+W42EsYUGWhWiJb8YTbZpc3opbYtPcTTBTUH6uY+s/RDKMAelzFv+GZ81DlPxKJKL 3Zy/YM4tVftqcndDrCguJuZLkv1vtCKhk/Ngh3OfVUsxIB8L81GiSEXL/Oe94zCPc5r6 kvS65tykpd/+lRcLZCZSIFhn+inaIT+JUE57+79pmx2CVK4hhxWCK6VZw+7fPxPTBFoi AauA== X-Gm-Message-State: AOJu0YwCP4cFBHT9+8EFJG0szHmu2TeXqcypNx4UmMJ/cNY7SAWCyG4Z LjCTGZWafawMunJPhWx1eAI3VC8ucKipezVp3kGmn3g+oBvoPwn8IqvotrTdwaByfJsk3Oktebe 86V32DlG/1g== X-Gm-Gg: ASbGncuPmcha1NW0oOnok9rKM9gLftYQoWj8yCW9KDPcOczGjJf4sEhJBKKVAoKpiBk G4uFiAFsBVa8S34IE+SqfpmX54Rk2AHcFSesXsjZ5nAcHOv+e6hakwjQwmUIEry6YHWDtVomTz5 f1sI4ahtpeitGSoflqTx6qk4iDyhFyWCkl6SJsVEgQNyfbnvDnxR06Q+HxuKAALMIJH4FWVlf4R g3oWz0kTe2SJSrL2MY+l/f8K80gp4xwvy/MR2uVOffXOISSYugm9V2uQGsr8BiiMwqDGz7ehKon EfM1eLHSiycMqfzoVDjjnT82Zkph4CBQ2nqbbkLnsU7fjAxFxao1QKgsJrnqawi4lnncI0e0yRd nrCx6XXBKquyU1kGgbpaBLFjwciHA4/43wg0f6OD4wKBfvu01GB2k3T1J9XpPoNzlw3gypx70Zw fdK8/qUjKm/FSVVooVUK0ReTCyfjwfBdAOvAop56Oec037BEesSqxrWASTpk6H X-Google-Smtp-Source: AGHT+IHcNW54oX7DBvziDn5MwXe4pi3vz++Mui2Niob9Fw/7S7w4CPbdJNtdCOLt844wqK1/pX+vOQ== X-Received: by 2002:a05:6000:184a:b0:42b:38b1:e32e with SMTP id ffacd0b85a97d-42e0f34f998mr4581945f8f.46.1764107308462; Tue, 25 Nov 2025 13:48:28 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 3/9] docs/deprecated: Remove undeprecated SMP description Date: Tue, 25 Nov 2025 22:47:55 +0100 Message-ID: <20251125214802.1929-4-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125214802.1929-1-philmd@linaro.org> References: <20251125214802.1929-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764107342595019100 From: Zhao Liu "Unsupported 'parameter=3D1' SMP configuration" was proposed to be deprecated in the commit 54c4ea8f3ae6 ("hw/core/machine-smp: Deprecate unsupported "parameter=3D1" SMP configurations"). But the related code was reverted later in the commit 9d7950edb0cd ("hw/core: allow parameter=3D1 for SMP topology on any machine"). Thus, this SMP behavior is still valid and is not actually deprecated. Remove outdated document descriptions. Reported-by: Markus Armbruster Signed-off-by: Zhao Liu Reviewed-by: Markus Armbruster Message-ID: <20251121084416.1031466-1-zhao1.liu@intel.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- docs/about/deprecated.rst | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 30ab72b2a4c..9386cffba26 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -54,20 +54,6 @@ as short-form boolean values, and passed to plugins as `= `arg_name=3Don``. However, short-form booleans are deprecated and full explicit ``arg_name= =3Don`` form is preferred. =20 -``-smp`` (Unsupported "parameter=3D1" SMP configurations) (since 9.0) -''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' - -Specified CPU topology parameters must be supported by the machine. - -In the SMP configuration, users should provide the CPU topology parameters= that -are supported by the target machine. - -However, historically it was allowed for users to specify the unsupported -topology parameter as "1", which is meaningless. So support for this kind = of -configurations (e.g. -smp drawers=3D1,books=3D1,clusters=3D1 for x86 PC ma= chine) is -marked deprecated since 9.0, users have to ensure that all the topology me= mbers -described with -smp are supported by the target machine. - QEMU Machine Protocol (QMP) commands ------------------------------------ =20 --=20 2.51.0 From nobody Sun Feb 8 22:53:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764107376; cv=none; d=zohomail.com; s=zohoarc; b=UhL0SGh8yun9bYxelYlOu7KanEvR9pryqkcIVqPv5wFLmvA+ZMBCjkTH5ArgM8ItOGjh38ioHHErey3AmI8siwoysnDvm8SCeQuClDAqJjxuqJvhJSt305Qt/1fo6+VpoJxdUVvgSuYKjUSifxo4WOdymH3ctxWr7hf7fiF0mYE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764107376; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=2IIA1n/JeVNTSE3MnCSqO40c5B5NHTi2Pu8G8dVM3fg=; b=oLSpwLdi1hE5iRUcrUv+laRl8DYnEvEI3iCHlVhoilugEY32gijl3sV99AhKvW26UUXoueUaqaJVCzktOrSsf/AN4PLoQzdBeNxyYgyPcxxm+xsVk8zFtWL4c8mrWzfA1KqLr8hVBfHTFnRysnbVPhuZl5POHkYIhZ85FsKnuCQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764107376449483.55879304643395; Tue, 25 Nov 2025 13:49:36 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vO0u2-0001ko-Az; Tue, 25 Nov 2025 16:48:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vO0tq-0001dB-9S for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:48:40 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vO0to-0005G3-TF for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:48:38 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-47774d3536dso1987045e9.0 for ; Tue, 25 Nov 2025 13:48:36 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f3635bsm37135940f8f.17.2025.11.25.13.48.34 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 13:48:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764107315; x=1764712115; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=2IIA1n/JeVNTSE3MnCSqO40c5B5NHTi2Pu8G8dVM3fg=; b=DK9gyFtYGUptN5JIlTsiglym8aQelzQop5CrgGaODWG1JJ8WlDTSigICrKHxOvVdaE fdc40mRjW21rsZ+YhzALSue36K5CD7wSxAZeH0IV/ru2Q/Azk5JAbdBfYfzMl1N2sqLe 8a2cNB1uDHGahv7c3weDXvHxxmKGB8fuhWthvJdl2WKSAQHVIyKtOMgrRN6Gb6hZfOSF 9Af8kqg927LIVtUcx1gxERzBdXSG7ZBvkyz/nSgDJUlftizknevLjxt6q6U5ijecIIOx v+l1zct4Ngtopzk32VVwvcekGARMh5S0UUl1TZl57h0LkF51pm9X32SoaNoRRVXdtmlk o/Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764107315; x=1764712115; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2IIA1n/JeVNTSE3MnCSqO40c5B5NHTi2Pu8G8dVM3fg=; b=IQ4wdt/jsgdbAMu32Lf8XjrROF9t2LHSlSyjlLSaVgJEnLzMcmPNJOXslVAC71UE9o muBJ/eMcpTOu+7R5RE1mWnWJxs00AOupJYSspQIdcoPZKdMtmaNZjBwDVVjzTYv+9qLA Y0dpr7yOpFCXszRrEmjJhKBEYiGw6EM/2QZKqyq/LBzNCYzfLIsy95kxqmYJ2UdBm4AZ elabZpwh/UqrVp6kIy8RYKMU1lrCWWWOHY0i+PlZGBPLokOuThtncYbKLCOW8caMqHbw tYfdQ2oMNJjLJpVlxen/PXmrpvQs5joZzlj48EAqsFrJ+iqZEsF9vzaxrYVfSo6YZfnh 9b8Q== X-Gm-Message-State: AOJu0YybXEetY0oZjr4cPscqqGx5JD+wp5CHHLe/SSwkCyRQmR6gCqwV lrsUJ3ANkBdbUSyFMyttBoziNLaqAXlg/Bu/JCNDJ6PBOHef1mD1TKEMT/8ikzpbiYARybCRZam r9fIfgc21KQ== X-Gm-Gg: ASbGncuzLdUjkVLOHA4TAe5X8vTbLW2zxfXpyXt9Tu7wd+nWOsgiMMHLHSdUQ7UCoNd FZdeZYiFlti7K8txls6p+xCwPbhUtMGTyreNm8oW4sECcbMCVF+MHiG12SHSI9uXzgdVxOKgfFc I6Cwg6xPniPGzR0mUuQJPgZcnk5BN7Pizoaz/hiXqQd3J1B9POwXoiNpuROKvtccLbYLJ0QmyxY tt2Oa2CtRWXc00fKqJfx2VYJs/5kzYG9290ve96kz3TEYxyZBM39/jY3ioON3F7KA2D9KRpjSy3 XhuVY0PqiluZBuK9lRsNoOQU34jZvDT/dwobYFS7k1FYXPS3m+lXVIjvXJEx1UN/tBRv8Qlmv1U Epk0I11lWAEt31MnDhDwrLldQ6961eyVzBOn/I8REWKFoYQIGcvuzlJPoSmn8VQoa8oHV1QjU6Q Whcv8BWo0atT8m13+3/iXll3jqHj0qjNMwBoDxIhNo1I0IYsZv+WCcdfVHhPfu X-Google-Smtp-Source: AGHT+IEfVTUvQhtQTuSC2MmzPnYvCRU03lW+LIg6HIWrEAfrr1QSJC0shvbZkCh2K+RIDvxIGRGy6A== X-Received: by 2002:a05:600c:4eca:b0:46f:a2ba:581f with SMTP id 5b1f17b1804b1-477c0540a68mr186355435e9.16.1764107315126; Tue, 25 Nov 2025 13:48:35 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 4/9] hw/usb: Convert to qemu_create() for a better error message Date: Tue, 25 Nov 2025 22:47:56 +0100 Message-ID: <20251125214802.1929-5-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125214802.1929-1-philmd@linaro.org> References: <20251125214802.1929-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764107379760019100 From: Markus Armbruster The error message changes from open FILENAME failed to Could not create 'FILENAME': REASON where REASON is the value of strerror(errno). Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251121121438.1249498-3-armbru@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/bus.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index 8dd2ce415eb..714e33989f4 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -259,10 +259,9 @@ static void usb_qdev_realize(DeviceState *qdev, Error = **errp) } =20 if (dev->pcap_filename) { - int fd =3D qemu_open_old(dev->pcap_filename, - O_CREAT | O_WRONLY | O_TRUNC | O_BINARY, 06= 66); + int fd =3D qemu_create(dev->pcap_filename, + O_WRONLY | O_TRUNC | O_BINARY, 0666, errp); if (fd < 0) { - error_setg(errp, "open %s failed", dev->pcap_filename); usb_qdev_unrealize(qdev); return; } --=20 2.51.0 From nobody Sun Feb 8 22:53:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764107339; cv=none; d=zohomail.com; s=zohoarc; b=bObct/oMLJNpYGw/t6yMeqr+5m3e1AMMCJ0Rv5tj8xOrOB/zgOAHOJRLQJrJT0fxDix7wkftgv1rpF40j9fjacfszzvOsY0Fu+k1vNeqXRNwjo3yqD9H7+fjZ7BnVUS+bL/8vLAFzjQMhI/cTMetG4UWkJFQAB+ls/rdhp6NP7M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764107339; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=yYI88q2Amny+q3PiM3TiKWYQwpqS2W1DuHTcySN9NwY=; b=hl0/9n+731x8iKDQlTVE0FcbUgA+qxJALSfxn1i40YHgrZ1N52uHp2Gb9LnePJWTpE1RHXEBjmPbLAfUtbU6zBMt5kahUUvk2zjldmwA5hQKZ+FjeQNy/KKRI6n7LK0U+kZsWchjiWMs7iNCngAq3VFoPb1YZ+7lNVmttBrTf8E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764107339733910.1479041295477; Tue, 25 Nov 2025 13:48:59 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vO0u3-0001nC-K9; Tue, 25 Nov 2025 16:48:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vO0tx-0001hE-5F for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:48:46 -0500 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vO0tv-0005H9-Hl for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:48:44 -0500 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-42b3108f41fso3665224f8f.3 for ; Tue, 25 Nov 2025 13:48:43 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34ff3sm37401920f8f.16.2025.11.25.13.48.40 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 13:48:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764107322; x=1764712122; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=yYI88q2Amny+q3PiM3TiKWYQwpqS2W1DuHTcySN9NwY=; b=SmSuNi4vh50TTNX+uoji/rkPQ9sAsDYfG0WCJEzNjMO+tWvBn4a3M6qhT+qWZlutRX dxeiQaeUN8uWEIcNAHg0uAoiXV7x2CQ61qXbrhl7aj2/D4P9qNHlJeVbbFcfUmBDv/nf dqpOVPpNrCebtfByJZY4AO+TdiM7HsuVN0lEFb2qoOBVIsnv/rxddMH1k5pmxhWFkQw4 QgM45TrpTFkUFMJ7TKEJDl44VyhwkxOP250TQ1h2GJD26ojAW6nUxKVEynG1VuiMiGI8 ar0i5XZjtcItJuJCYS3LEo5HKZTbuF2MV1simGbxcXAZGVqK++QmqbxbABnss6BMPXXF 5rqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764107322; x=1764712122; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yYI88q2Amny+q3PiM3TiKWYQwpqS2W1DuHTcySN9NwY=; b=xSMipOLqmBXFy7Tz0JTDMvNlptp445UewT7cE2Jn2vfzteNBJ+v9FkRgphSWbdA4Ox SpaOLUINArrlOQo47EeEp1SwtPlGe06UILRSwriest4kX9K6P9TZ0OFlDHxs43d8tYRv UfxTpmXt2lib9/RNuwWqhgncvLQeMl3Tm35RmV3Qiye659jBoLlJhJrvXNc+i1g9wCKY LZDQ4CIxmssBX+75LUVzIqa6dWninknXrtk0vGp08JbQ40NTzMKMjVeKU4eahpQacyhA 7//lv6Vj1xt7rHRbcY0iUXZQQ9tCOXgtmblvg0XQPzqpLbzXJUZqclVJiu/Fz+G2wwqu oyXg== X-Gm-Message-State: AOJu0Yy0OCRkqb3w27B31DNqmkxeHxm6jaqKPdWryrBEuPLvnmyurrbg rgxnh2GuQ4jOy6DvXirmZPucw3y+b4Gwm2HFSmQIXyh4JYMjwrSngvJbOE6deyVxNGWZymdLkMh d9hdE9K8tzQ== X-Gm-Gg: ASbGncv5X5zCCbLFT0hHITt9CG5s/0OT9lZxIwXSvWYZu+OjE7KXNSgeJoIKezuslhv aR7YyivDC9d4pBFmTvL3lKS+RHci7LhJdsIVH/+Zd/ly9aj2aLiBXJ668zclglHPIObGGWwHEwm ksFuGbVPraiTlY1l/XehCyxoMTn9D2zIMjjS0rb1w7I2ZGRe2CvMOAFeSFNBV9HnlV2ms65WCcx s1Tb8/Vmo6QbS6JrtGLXtSjxmoSvE901425j0uRBDrpzcdQb+yb4YR+qnDKBJ05H/NNZWS2s8Fo AZQCkRUx0g1WWD9VLHR7w6DQOLRMnAzHhkWWYFFGT3EMC+GwzV9z1G9F6eLDLpJ6ae/iBYh0Qn7 ztnEciZ7YAh4n07v5S9ypWdI63oOHsgP7d79LN1RiRpjgMhFhYE0O9cDrewRaKcGjsKB7bZDN9B LqmFx/I2sMcS+88tHlfDQP//28AZ8pGGcJVW5KySruOsMdwamJwWzEx6c3XTO6 X-Google-Smtp-Source: AGHT+IEVsi29xYCDE8Xh1aRgNa1WVxJgBHTr/5YXbcEjTsxY2kkQbjI2VGQBLzHmSKoyt1L/lyMmIg== X-Received: by 2002:a05:6000:2484:b0:42b:4061:23f3 with SMTP id ffacd0b85a97d-42cc1d0cfb8mr17357542f8f.44.1764107321726; Tue, 25 Nov 2025 13:48:41 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 5/9] hw/scsi: Use error_setg_file_open() for a better error message Date: Tue, 25 Nov 2025 22:47:57 +0100 Message-ID: <20251125214802.1929-6-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125214802.1929-1-philmd@linaro.org> References: <20251125214802.1929-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764107342583019100 From: Markus Armbruster The error message changes from vhost-scsi: open vhost char device failed: REASON to Could not open '/dev/vhost-scsi': REASON I think the exact file name is more useful to know than the file's purpose. We could put back the "vhost-scsi: " prefix with error_prepend(). Not worth the bother. Signed-off-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251121121438.1249498-7-armbru@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/scsi/vhost-scsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index cdf405b0f86..239138c9316 100644 --- a/hw/scsi/vhost-scsi.c +++ b/hw/scsi/vhost-scsi.c @@ -245,8 +245,7 @@ static void vhost_scsi_realize(DeviceState *dev, Error = **errp) } else { vhostfd =3D open("/dev/vhost-scsi", O_RDWR); if (vhostfd < 0) { - error_setg(errp, "vhost-scsi: open vhost char device failed: %= s", - strerror(errno)); + error_setg_file_open(errp, errno, "/dev/vhost-scsi"); return; } } --=20 2.51.0 From nobody Sun Feb 8 22:53:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764107400; cv=none; d=zohomail.com; s=zohoarc; b=RmzdFhnRliNGfyPWg5l0oW+sBMnoniR7eFpH2FPKD31GpeotLFWMNQj9GrZqj6ILWO/hOJ0DPCxoXT3KVVUZvjANHat+prUMyxJkR0Ie+/5mOmrZGJMd833g4OfFFwVHK3Bw7byS9uDfu2s3fREXohPBsDZ3ctdDtAf2KHHmNGU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764107400; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=TqZ00m1dp5ykFypA1defAPknRVwrY3XHn9VogXTLVOs=; b=mPPF0eOtaR1ilLrYWhas5lqJFLR6jgq8Ay0FWA/diOrneZymAlaZ4BeZ5SsopkFVhTELx6sdZwwiqZxYjOTZseishVCyqdwxhEEsHYJ6IelkDxjvMjHJ9OTPMOrNRMW+r+KtU6a/C/k0aRAkGDNQwvdnbT9b+Al3nSaH6d0bDYw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764107400898762.9184699824582; Tue, 25 Nov 2025 13:50:00 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vO0u7-00021w-P3; Tue, 25 Nov 2025 16:48:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vO0u5-0001tA-Jq for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:48:54 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vO0u4-0005Ip-1W for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:48:53 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-477b5e0323bso1525285e9.0 for ; Tue, 25 Nov 2025 13:48:51 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4790addeeaasm9836885e9.7.2025.11.25.13.48.47 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 13:48:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764107330; x=1764712130; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=TqZ00m1dp5ykFypA1defAPknRVwrY3XHn9VogXTLVOs=; b=PRfJAta9L3IP8sfsjDttSFZfseAhydNVBQcGjc1S9hUY+4myBpMpvI8xZdiwIb/lRT 6cr/EYhgmqXA4/QFKvf9jfI7M4blvav3BDzIIkNUkmHmXW6ORxxOUwS/Wg2YFTlf/XVW As505wuHNTwAT0UUGXQegZ6ZvvlW9UCW4Gri4m/3Y8qIZGhMoOTY/5qxVd4tv/Yo41SH cFtFZSohVaCk6hhZTsf18/F/QU5Siwj9QRxjlxnybgwtOlNP1EpEnsrZObulc3985xxW bY+dtk8AYEVd4ZzzuEQd3ND9mFUUalHpenHk/VWgOLukR28cteCT9srp5WGdGlErrTzF YKAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764107330; x=1764712130; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TqZ00m1dp5ykFypA1defAPknRVwrY3XHn9VogXTLVOs=; b=cgRPgZmLANdBODMXr418vItToM0/xrqMzx9zKtScuGnYbrr44/OB68B8I6Y1Pq2kwJ eFAHhdHLRsFv1EmO5tq3HhmBHp1zpQJzAkJ643ajCTpVRbA5P2O1sw3+Y767tiSbzDXa nVxexN5AB6WxIlD/mf9rs5x5MQ3oREAT+wSXNJxnmVhE2MncQ7pzttXCfHAjQ0EOgCSl KR4r/gE8mrL7lGOgdQUkaZVGjxym/Qex5f0x3EiWxrBtdtA3VX7wmQ0NnSLUnbRatpvH 2ijeeejVdgr/uMP2qY9bWOoVHIrtdZN1GQvuSaUN2kHDMfIAFunTUSVCcoPDiTdy6pRM jnPA== X-Gm-Message-State: AOJu0YzfmHdlOcFRTmmCYHKCtpjU5n+qC9gX4856dWG41iaRhIkEf9mC nPLidqclcbF0aHzU8X1ngqBHeFpnzbXs4T4ukdnuhL4lKdx6ygRFWBYLqhoKmlm/u9aBrpVJNzJ OfaLZsDHMhQ== X-Gm-Gg: ASbGncsHiDs8WL+vfJKd+mjOMJeEG08mwbR6u4uw7ioUpy0deKF42KisZ/WOT0f1tIj +YcNEIxPIBey/9FDCiW2P1r6+Hq7XhRX5rP2AL2qxOdqKquQ8eG5iXH5P23r2EbtkO5elBxR+QU MpO9n+26mtN3UCw7+vjM9TavUlw+6aIf7PlXf4KhytedX8DRHp0NoxZ/R75wJ8/AphQGuQIGk2I 54gx0T9Y3US/GtnAxlfifS0pkIQvZtN1ypDtXRkbNnMJuoIndNSKqK7925xFeNjqf/JED6h8gC3 QWdmTf5wxeG7QHgPCXW2Z3yIVEd7RSL65Qt9WJf2Q2kyRkwR1iMgyKYkpVh2zCK522VogjN9+9B WM1UK6xmJKmlTChJ3Jurn8QXXaTo6vsBKelFG3IGaRMarUKw/uD4xX+kaAKAG4Wx1P/HxjGArga ZPBiIUrbOOcO1Ec8loP4e+1ejpfxVgLR2TVjfJnVG+hiz+fVG4qNUkatRt6v2B X-Google-Smtp-Source: AGHT+IEB89Kx8FICGKk1uMdkc4zzO4l0fjvVDLf9NlDN32Z5tPSRKUFq2tDjKFtnqgnzAYNpILDq7Q== X-Received: by 2002:a05:600c:b52:b0:475:d91d:28fb with SMTP id 5b1f17b1804b1-477b9ea35fbmr143250905e9.4.1764107330113; Tue, 25 Nov 2025 13:48:50 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 6/9] hw/virtio: Use error_setg_file_open() for a better error message Date: Tue, 25 Nov 2025 22:47:58 +0100 Message-ID: <20251125214802.1929-7-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125214802.1929-1-philmd@linaro.org> References: <20251125214802.1929-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764107401918019100 From: Markus Armbruster The error message changes from vhost-vsock: failed to open vhost device: REASON to Could not open '/dev/vhost-vsock': REASON I think the exact file name is more useful to know than the file's purpose. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251121121438.1249498-8-armbru@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/virtio/vhost-vsock.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/virtio/vhost-vsock.c b/hw/virtio/vhost-vsock.c index 107d88babea..7940b60d8a5 100644 --- a/hw/virtio/vhost-vsock.c +++ b/hw/virtio/vhost-vsock.c @@ -153,8 +153,7 @@ static void vhost_vsock_device_realize(DeviceState *dev= , Error **errp) } else { vhostfd =3D open("/dev/vhost-vsock", O_RDWR); if (vhostfd < 0) { - error_setg_errno(errp, errno, - "vhost-vsock: failed to open vhost device"); + error_setg_file_open(errp, errno, "/dev/vhost-vsock"); return; } =20 --=20 2.51.0 From nobody Sun Feb 8 22:53:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764107398; cv=none; d=zohomail.com; s=zohoarc; b=KU7ExZCtTdESGoV7bQNaUC6KndaIe2g476M+kl4Qqkd7Z8RXvPTKoreWXI0MQafz6dlP5T//FQKGHkM91aLzNSfQFntWw/0PFZCAhT/aMveA4v0vO+u0Rhf+yJBpr96zqb9Cat4YsdmhB2ynXpuL4TUPBRTJ4/5J9OJZt8+iCsg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764107398; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=0nHuBXitg7641bu6kmkOgxo7UOR8YoWwGXOBRRXCaPw=; b=leBCj6xOrV8oosXz0GPb0DT4trIr2yYhkL2X2yZwybaAUFLyf7VFozlqOkULLuPj7FZ8BJlWQAbZr8yDCMsYOeD4QexG3zvMhVS55dp1JACFxHfYbkfG6TUruuAxRAAWyZTW2MMFMBWcHFDAjEmbpMkkcvY4FJC/Go/Fp3yR5+A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764107398702861.9477273276763; Tue, 25 Nov 2025 13:49:58 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vO0uE-0002UI-QH; Tue, 25 Nov 2025 16:49:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vO0uC-0002IT-DQ for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:49:00 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vO0uA-0005JY-TC for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:49:00 -0500 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-42b38693c4dso2633008f8f.3 for ; Tue, 25 Nov 2025 13:48:58 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd9061sm36737712f8f.41.2025.11.25.13.48.56 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 13:48:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764107337; x=1764712137; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=0nHuBXitg7641bu6kmkOgxo7UOR8YoWwGXOBRRXCaPw=; b=lbOpWFXhF9Pd2+3Zp9vKnF+60xUqed9wxsVIVM5WXYDZq/NGqNMRSP/E/BJsXgNx3v WQXkD5GAZSiXtqzOhPJnCv8wugf8gZhxgyAi3OZ8PQ3K5hXf5Gx3p5gEhkuAEytEuccl Cdycts93Ah31dypy4y3lFQ+kyGwk/IzpuNw4+lOqceMnP7pZ5N+6ZKgY5dX1ggz0932i 9vAdiY+JrxjXBRi0olarJIT23CyPVYkDrhf2lrLhKaxLMA2AkVgk8bhPi9jU/irHYAii OjY8UXscRaSjO+V06N2yzOxDvDVg6w2aT4CI9PZdrTAdjzKjcs+AVg3nTKSbzuB+nxbU 0H6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764107337; x=1764712137; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0nHuBXitg7641bu6kmkOgxo7UOR8YoWwGXOBRRXCaPw=; b=i+NnLHXKtYDQQmEVCPrfUihdGgFumEyHFMIhOOFDPiS7faXzsn/S7OKKuuo+AYliup 9kcZ8EgCpEd/oqIFl+Dr4+0IkQxz2kNrgBPYQcuQwnEOkMQVxSGMmuJgbYevsfKanatS V236xqPd48KGS4b+qpdSCTx9S+pS4bbvJ4J+AzeYlhkGBjqKm6fnQVB9Rbxy2XWGH8gw GM98ZoAOQHXv4pmEPlP1+TRB2ZL4BLqw/8/5U1amHisDmhrQJqYK6HeOTbUAa4qQfPUi bHKwRD1TLe2Q0NH62l0gO2Ezq1yODwgrdAT5MGp0CsvpHiLN6x7+oR1KOUVr6LkSzeJs yriA== X-Gm-Message-State: AOJu0YwjsCUMme+PPAVH9ZVH+RmRFmrKjJMQqDKvEsEmmwWX4Gr7AsIi 6TENqpUH5YE1HFGdxLz6rRRZSMkETKCRoWEEh0jbX+6CsFMVjk2gLhGbUMszbR0XeHVV0hbaBvt yjMjYr4sIKA== X-Gm-Gg: ASbGncvxamjuQWzSIkSjUr68kDP9uekBUug+bskpVoBAp46srHhlm4hJACGqg8UnRrZ NKFGii9/mkFwHvVhBzbXVxl8sZdQTb2uiIkCgGhh98S+SkNimnquZDNy+3qh5CwsAooA9zqOot+ 3EOSgjly9yENvuODPv8tM8SEwVGvFxmtviLNUOjve9f/pH4IIQqpys9Z7KRz8CjFRa+f+lnIZf9 Cptw1/miZS1mkwcL2PvHtm8P2OCXDlsa1mwgocLsm7Q1BThh5wFv99W/XKIa9J36BFi4St6hh3A dPGgrJFos6a/uAZN/RFyW509OTlc/ZpkcO8DSR+Irn4cc54xzVbkqXJCZ0nR6v7fZMMi0UuaBq/ CSHecyivI0Oo6IyyBDQ7jV+SRbkhH2Jpw/puKGEtUs9zAd/v4aGglRm4Hx8l8aNi8W0xMa+3Aij OLyJkmiLElk/ViKRSZiN9Mb0SdtKLt+hYdZIPIPEYMNVv6bVkwJvMMw3cZAnaK X-Google-Smtp-Source: AGHT+IGkFMSR/+r9pMiQOCMw8s+vpkVEMFGScr2R0o+iRFYr0z+dSv4KT0as3cRryENFKDhSxuELyg== X-Received: by 2002:a05:6000:430b:b0:42c:b8fd:21b4 with SMTP id ffacd0b85a97d-42e0f35c36bmr4981529f8f.57.1764107336745; Tue, 25 Nov 2025 13:48:56 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 7/9] replay: Improve assert in replay_char_read_all_load() Date: Tue, 25 Nov 2025 22:47:59 +0100 Message-ID: <20251125214802.1929-8-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125214802.1929-1-philmd@linaro.org> References: <20251125214802.1929-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=philmd@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764107399918019100 From: Peter Maydell In replay_char_read_all_load() we get a buffer and size from the replay log. We know the size has to fit an int because of how we write the log. However the way we assert this is wrong: we cast the size_t from replay_get_array() to an int and then check that it is non-negative. This misses cases where an over-large size is truncated into a positive value by the cast. Replace the assertion with checking that the size is in-range before doing the cast. Coverity complained about the possible overflow: CID 1643440. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251124173407.50124-1-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- replay/replay-char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/replay/replay-char.c b/replay/replay-char.c index 81dc416e988..4e58dd154af 100644 --- a/replay/replay-char.c +++ b/replay/replay-char.c @@ -126,8 +126,8 @@ int replay_char_read_all_load(uint8_t *buf) int res; replay_get_array(buf, &size); replay_finish_event(); + assert(size <=3D INT_MAX); res =3D (int)size; - assert(res >=3D 0); return res; } else if (replay_next_event_is(EVENT_CHAR_READ_ALL_ERROR)) { int res =3D replay_get_dword(); --=20 2.51.0 From nobody Sun Feb 8 22:53:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764107414; cv=none; d=zohomail.com; s=zohoarc; b=mXPttT/TYrCpPeXepKIR/0lTZXS8xVdldIDGnN/ysXoBCerQIP5AL5Tq038DbLGosZfVN76eNqQmn38hgr2rCTEo1Z5vNm/HdEr/bGQfsxkmAsq3TEEHB4HCpWYMUMnmk7fdQrPaAX4dVjXzVtwF+IrY59LxbL8HsxOwr1PJkWk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764107414; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Dl6LvASd0O/JG4z7ogldG5dWvUV97lajqPubCgwHmSU=; b=jub3uh/EBFgWfpOlCXRwra0vaHTmHAmCabLrgxMJLxiE2JnSxDECpZ/1OXIQXxJTU4+mupAnC+lwpJmYzGpcoKjGJiunshY1rk1Na5TR3VM5Fl6y9/kp1ipjSBcsHWCC8AFs3ewrhTayZ158BwFYTZziFrs3fNVcU10Tg3uMXPA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176410741455425.23058025301725; Tue, 25 Nov 2025 13:50:14 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vO0v6-0003ED-2R; Tue, 25 Nov 2025 16:49:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vO0uL-0002jc-II for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:49:14 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vO0uJ-0005KJ-GA for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:49:09 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4777771ed1aso39811595e9.2 for ; Tue, 25 Nov 2025 13:49:06 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fba201sm36636378f8f.32.2025.11.25.13.49.02 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 13:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764107345; x=1764712145; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Dl6LvASd0O/JG4z7ogldG5dWvUV97lajqPubCgwHmSU=; b=iy6fYnVqTlQJXoMj6hQBDV48svu43bNL4AcHUi8Kiei/v+ggvZ00042sx1qFB1yfBB LMoFaPamlyYJa2CO9qKPrHyqsU+r/Sz3FNQwWlUTObnRp3YAMTpqc3p4Zum6eB2f7FiI r4MJsqVlY5rQtTmD55/mHGPXSDRQXTr3IIl+W/0Zrk7lSw4XA40DiSrlE8z4x4/cdtw2 3UNkWXQPvYuYM4xPaQXNnBsiQMJm7K3bMmAORQ0gcdg46xzE9pJ/mltzNzSdsqzE6e7H dj/2eeSwPC+CdNLR6m6YOKXlDeAghEt1MU95pEYimvQ2vi/NfD+TX4C2bF3pU09XzZJo tW9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764107345; x=1764712145; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Dl6LvASd0O/JG4z7ogldG5dWvUV97lajqPubCgwHmSU=; b=pu25msZCXVXbtgFhWxAz5eraKElv9Eszuq472FcxinzkzstaMQh3ZL+YF81kwiN/Cd PghyUMcbS2GRIFJ4xZ0yMkMBuzK+YY/HJwyPMmtEJMXMRQc9YIoXtDt+hzfBCpW6zMOM 2vpk3Vcv4zVkm8OZgnl+m91XQBl/ryzBebs7m0ZxiZeLeiIRfnWQ9J3MIawRWgp044K/ cNpSWUj87/helkqqjWPnKUmjNvut267Saz9ZDuh8SpFJhMVTYJvJ9Ey4rvZopegU1Hz6 n7JdzrftzEHjiRW7//64xciYifA0qxx8GjbE34DPGXLItPFJmiW0Fv5ZGLXdLCRN49Wc bmSg== X-Gm-Message-State: AOJu0YxBrCVg+R9uQ3j7bzqDN8G5lZ3UQShsm6pzhZMziGvUEe1HZVc3 L6FD2yJ4OzQ0VNn0BBM/H3DBQ/QAPDf6SwQ/1ZjoPp98fB0rLYLI/JvRXApV2/1tQMlI+luG79q bE8l6oxlAzQ== X-Gm-Gg: ASbGnctukc+hdqO5jgluWslfKaRzdG05u4axvPaEkK3/taW77UEYhuGIHJzDW3c2cbe 298WOEVrbPOi4zjlecWT1jtF0d6gsGytAFlNQ4k9HbyiTTCqqYnkZus01jGRcVMN+riTc0lPaLi exsHFHr9iTtEx6J4BnuJyKnb+fPMmSXeqRoBZprh4xJl7GCkCcKFZUfUwohVbDvHTPuIWJ5ouhV JFkJRMLJnAa1TE+UHThLYMdmJrHMbRH3dMbV6rP3cqR48CCxFqu2aNyErRiJ4+YDXB5H23wcdnC mkGM56jTW7I2X0xLWfhpX6dKUPbcJj9rRHT0t/FU9WFb1f73mPNQAihpG3ZfNxXu105lCtA7zFz PSorhz8M0fDiNLYIE/ccJeMUN7tvlTRxAoIOgkewHWNI4D4L1DeNwKcWy3aZYb/0qn710mGUUgX dQdAL7RCwyQwJ0rsWQeJNzXgg/omNfBd+J/ndg6xMAST9ISIw3i/beNx7L0RN/ X-Google-Smtp-Source: AGHT+IHSxZ4NHwdixRTVfgseIeGCnr1FG+U7hfQc/zezWkEgnJxI0FVNoMJgbJIMEIhhmVoCmORvqw== X-Received: by 2002:a05:6000:400f:b0:42b:3c3e:5d53 with SMTP id ffacd0b85a97d-42cc1cedbf7mr19533973f8f.16.1764107345087; Tue, 25 Nov 2025 13:49:05 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 8/9] hw/core/machine: Provide a description for aux-ram-share property Date: Tue, 25 Nov 2025 22:48:00 +0100 Message-ID: <20251125214802.1929-9-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125214802.1929-1-philmd@linaro.org> References: <20251125214802.1929-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764107415988019100 From: Peter Xu It was forgotten when being introduced in commit 91792807d1 ("machine: aux-ram-share option"). Cc: qemu-stable@nongnu.org Reported-by: Peter Maydell Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas Message-ID: <20251124191408.783473-1-peterx@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/core/machine.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index 06e0c9a179b..27372bb01ef 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -1204,6 +1204,8 @@ static void machine_class_init(ObjectClass *oc, const= void *data) object_class_property_add_bool(oc, "aux-ram-share", machine_get_aux_ram_share, machine_set_aux_ram_share); + object_class_property_set_description(oc, "aux-ram-share", + "Use anonymous shared memory for auxiliary guest RAMs"); #endif =20 object_class_property_add_bool(oc, "usb", --=20 2.51.0 From nobody Sun Feb 8 22:53:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764107412; cv=none; d=zohomail.com; s=zohoarc; b=e9c7CRPR85ICh4uy8ZQu1zgCtRQIq6w0smFLxxnrbLsUW/6yJDq9Asw4JqxeYD2CWcobUJ8c6awnMfqb5Nfi9MYs/NNb1uUBmNIddKOTvX3y6eT71jRwdQBTR+OsS3pr8h/RQWQ+KcVIzo7QwCnAqETy1CWgRwWWwj6eHNHADvM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764107412; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=dmTD8Lm1Ik0C912Tu/eoR015Q1kbSP/lIxEJnzSa3u0=; b=M4AE1Me4SRBNyKDcin0AFkfIAEtEmfAkIHTpC35DPS3rTsbtWj/tIW+1XBVfxmNrLqwL+9bcOlTrAFCovN3MSrvA6RdFQCFj4/WxmJBUhMIr0EbXzb70ZIrMGanlo83uwLtN4usH95TAon/yx0+z9/R5t+31amqWAuoXQa2t0HQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764107411997905.5498352973837; Tue, 25 Nov 2025 13:50:11 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vO0vG-0003Vj-3B; Tue, 25 Nov 2025 16:50:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vO0uS-0002pP-LO for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:49:20 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vO0uQ-0005Km-Pv for qemu-devel@nongnu.org; Tue, 25 Nov 2025 16:49:16 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-477632b0621so40584775e9.2 for ; Tue, 25 Nov 2025 13:49:13 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479052cfd9dsm25113205e9.7.2025.11.25.13.49.10 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 13:49:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764107352; x=1764712152; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=dmTD8Lm1Ik0C912Tu/eoR015Q1kbSP/lIxEJnzSa3u0=; b=iwRJicheey5ERCpt0IqlxPiElScgv2wR42nBqfkVAQQfS1Gzizm3HXMZ5bqq9QsloK HoVVDo5lUQr1tQ+EB32pPfORHQkXc6NRcTgt6a59X+2i+vshqoVCZI7UsaSMIJsR3iGK tJZoREvM+gwL9pNg4daJIsG6NYmvv2+DtBAlQrgkxJ8LlfgJroEGpDh9LzjmSyryrEhY 77NoHPcdKB7Bwh/RjWxLyhFe/1Be17vJkegduXcjHHLG+8bxZJ9AiH6HJv/TWekZjkzU VLyb/KakBL/KTRPk2/vv8pqIMviyqfjDxss1/hZT0VJsXsxvKrqArcWjfgGXw62oqZwO Vz9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764107352; x=1764712152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dmTD8Lm1Ik0C912Tu/eoR015Q1kbSP/lIxEJnzSa3u0=; b=BeZBBF+h3l/NvIqoPaFR+bE+SBODyj7pdAp8EqsKa74mjvjW7/6i3vE8OLEuMywfEe hzW1U+7WOoXt2neyJ28OyKsykS2RO9le3IUVFPsT1LtDCgWBkEIEIqfv0cDsiNlQsVc3 l3aN5GRZTGteM/AH9NCh1Trir6/YIJoWCGp7ZvAWvQRLJ7t1t7iZSX3dyKyU3JFgjKVd 0jI7wgom6vM6tKcH/EjoSHLnMwjNW4/ykJzZbViknRrhpSjGG4KP/mIcXwHHwO7ns4t9 2BkgwuZIl7lBRCC6/CvOQufWElNHKhNXfy3o9+DpEB2A9XJ8XBR1D1sAtFzvxIMoPGkE 72lg== X-Gm-Message-State: AOJu0YySGPe2pBZX33KFhOWedt+tJuO79LJ4kWWDhIL5xclTRDqdqoZd HchxAA1cJkuq0XoxdKRImprqH9SEgf3/Be60yWqlD163yYMd86srhycz+vxtK+4xXaSzHWN4LxY JMY5v+1BJzg== X-Gm-Gg: ASbGncu+5D0YvyfOySTgymO10JBfuUct4OWQPjAc/QwrXcLI3eOZP3Q33mbg48uHJC4 UeBHo+04/wPSzzP7N8myqOv1O2yJ19DvwWcU9T8VIc3F5HXWfkcW1vBTX8NJ8+7WuyTYU9yjFHu nuPlJ5YkvCYAvaEMlcEzuDb+LvzOfxtN9ZN36rCEIdkc9R1FgkYSXhSdjVSyNcZtRFe8vvOCXzC 5SPVAG5aClqlzQ4kZBcfyLHUXRpa0kVuJ/u9jOvoA9572hNkBnTZy7wGER0Em1JRtWtGUCOftG4 W94Nh6gSAWkXIkb/ONIEiQCChf/5WZahpNQGNfpdY6N4RKyElPdsir9Lux6jIk4XKs53n6DCHeO GjYVHHM1vterjGh61R1IE2b44feklk3w0+bUixWiUR6UEGlue/u0ut/UTZ4sP8NwzgFvtBg7FJC h9H/NBr1lMgnodA3lZErxnHeqNBHdwnzor/gaj8agckEhvuD5PxtAqmVh4zPVufg0iGGH7M1M= X-Google-Smtp-Source: AGHT+IE9BwDlniSAF7UdiSk+WUl4iRjFhUKWrqXlfmdt7R9v0u5oLkx86O2PjBxx9mY5/7gJ1bElDg== X-Received: by 2002:a05:600c:1c20:b0:477:9d54:58d7 with SMTP id 5b1f17b1804b1-477c1131d60mr179336655e9.29.1764107351952; Tue, 25 Nov 2025 13:49:11 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 9/9] hw/aspeed/{xdma, rtc, sdhci}: Fix endianness to DEVICE_LITTLE_ENDIAN Date: Tue, 25 Nov 2025 22:48:01 +0100 Message-ID: <20251125214802.1929-10-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125214802.1929-1-philmd@linaro.org> References: <20251125214802.1929-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764107414021019100 From: C=C3=A9dric Le Goater When the XDMA, RTC and SDHCI device models of the Aspeed SoCs were first introduced, their MMIO regions inherited of a DEVICE_NATIVE_ENDIAN endianness. It should be DEVICE_LITTLE_ENDIAN. Fix that. Signed-off-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251125142631.676689-1-clg@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/misc/aspeed_xdma.c | 2 +- hw/rtc/aspeed_rtc.c | 2 +- hw/sd/aspeed_sdhci.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/misc/aspeed_xdma.c b/hw/misc/aspeed_xdma.c index cc03c422b0e..c448ad32ff2 100644 --- a/hw/misc/aspeed_xdma.c +++ b/hw/misc/aspeed_xdma.c @@ -113,7 +113,7 @@ static void aspeed_xdma_write(void *opaque, hwaddr addr= , uint64_t val, static const MemoryRegionOps aspeed_xdma_ops =3D { .read =3D aspeed_xdma_read, .write =3D aspeed_xdma_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .valid.min_access_size =3D 4, .valid.max_access_size =3D 4, }; diff --git a/hw/rtc/aspeed_rtc.c b/hw/rtc/aspeed_rtc.c index c4feea23a0b..6793e253f47 100644 --- a/hw/rtc/aspeed_rtc.c +++ b/hw/rtc/aspeed_rtc.c @@ -131,7 +131,7 @@ static void aspeed_rtc_reset(DeviceState *d) static const MemoryRegionOps aspeed_rtc_ops =3D { .read =3D aspeed_rtc_read, .write =3D aspeed_rtc_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, }; =20 static const VMStateDescription vmstate_aspeed_rtc =3D { diff --git a/hw/sd/aspeed_sdhci.c b/hw/sd/aspeed_sdhci.c index fc38ad39ce1..f5c0c4956aa 100644 --- a/hw/sd/aspeed_sdhci.c +++ b/hw/sd/aspeed_sdhci.c @@ -124,7 +124,7 @@ static void aspeed_sdhci_write(void *opaque, hwaddr add= r, uint64_t val, static const MemoryRegionOps aspeed_sdhci_ops =3D { .read =3D aspeed_sdhci_read, .write =3D aspeed_sdhci_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .valid.min_access_size =3D 4, .valid.max_access_size =3D 4, }; --=20 2.51.0