From nobody Wed Feb 11 03:07:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1764085251; cv=none; d=zohomail.com; s=zohoarc; b=YnsVo6BOyo80AWAHYrawVwl8Y/GXtf3kMCCQzVAL39uvjiLMpRE5E6j4BJ1QqWs3OD27HaQfdd4a76oVvIlLgkfPb6CBfXpgO0cO5LnYHvNFav0XSHuRyBohjy2gfOayPdutZN4q15lCCt2yZzRY5KJFuk9hZ2BWJRJ7tCDUEkg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764085251; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=e8yxiX8Z9UsoH0msFhGyk8AU2zMkQsGn7Fw81tqF28w=; b=c4+ekwllPC8+ODpIHyGPNPLH85BV4zgpUkcQdU5NVbm1cHh3z0ja0X6GfRvQyD6G0V3jxuVUxuR3f5xo0LuSLIiTjNoke+kwqTsItZRPD9K4mWXkFTjSvC75/++D1SzVKtO2MDExmlUlHJVKSOj4kbaFnqYvtk42GxDpbGP8Oes= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764085251592480.126711001696; Tue, 25 Nov 2025 07:40:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNttk-0004eC-Um; Tue, 25 Nov 2025 09:20:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNtrm-0003Z6-1n for qemu-devel@nongnu.org; Tue, 25 Nov 2025 09:18:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNtrk-0001Xo-KQ for qemu-devel@nongnu.org; Tue, 25 Nov 2025 09:18:01 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-tHuPggAYOYOGsjqJ67LRIQ-1; Tue, 25 Nov 2025 09:17:56 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 712FD18001D1; Tue, 25 Nov 2025 14:17:55 +0000 (UTC) Received: from localhost (unknown [10.44.22.27]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4CAA53003761; Tue, 25 Nov 2025 14:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764080280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e8yxiX8Z9UsoH0msFhGyk8AU2zMkQsGn7Fw81tqF28w=; b=fKlHN+CgDMU39L0MpGVZpWzAuw6cncnR5bk5SGZBkDoBe6n6U9122Uwxlsna0AWbbyC4Wc O0PQjfd4JGiR8nYRLtyStMJ/+0GznQZLeelSoBhjjkjb8TuUQsEHFAua6jhd08Db+GUS9r s8GhiyZTi/AV4xUR8e6CdskB5MNMO0U= X-MC-Unique: tHuPggAYOYOGsjqJ67LRIQ-1 X-Mimecast-MFC-AGG-ID: tHuPggAYOYOGsjqJ67LRIQ_1764080275 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "AlanoSong@163.com" Subject: [PULL 4/4] ui/vnc: Fix qemu abort when query vnc info Date: Tue, 25 Nov 2025 18:17:26 +0400 Message-ID: <20251125141726.1755276-5-marcandre.lureau@redhat.com> In-Reply-To: <20251125141726.1755276-1-marcandre.lureau@redhat.com> References: <20251125141726.1755276-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.152, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1764085258829019100 From: "AlanoSong@163.com" When there is no display device on qemu machine, and user only access qemu by remote vnc. At the same time user input `info vnc` by QMP, the qemu will abort. To avoid the abort above, I add display device check, when query vnc info in qmp_query_vnc_servers(). Reviewed-by: Marc-Andr=C3=A9Lureau Signed-off-by: Alano Song [ Marc-Andr=C3=A9 - removed useless Error *err ] Signed-off-by: Marc-Andr=C3=A9 Lureau Message-ID: <20251125131955.7024-1-AlanoSong@163.com> --- ui/vnc.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 0d499b208b..e6bcf0e1cf 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -556,9 +556,12 @@ VncInfo2List *qmp_query_vnc_servers(Error **errp) qmp_query_auth(vd->auth, vd->subauth, &info->auth, &info->vencrypt, &info->has_vencrypt); if (vd->dcl.con) { - dev =3D DEVICE(object_property_get_link(OBJECT(vd->dcl.con), - "device", &error_abort)); - info->display =3D g_strdup(dev->id); + Object *obj =3D object_property_get_link(OBJECT(vd->dcl.con), + "device", NULL); + if (obj) { + dev =3D DEVICE(obj); + info->display =3D g_strdup(dev->id); + } } if (vd->listener !=3D NULL) { nsioc =3D qio_net_listener_nsioc(vd->listener); --=20 2.51.1