From nobody Mon Feb 9 04:27:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=163.com ARC-Seal: i=1; a=rsa-sha256; t=1764076836; cv=none; d=zohomail.com; s=zohoarc; b=d3kJCK5kdmYmr5hZQDXog6aMk8bpJtSffW25F5XYi7UQwmR6zBsxFPFQlfwkGoF++cC5sRdD8NrMZVEwhkdsJMzUk/zuO5Tztv2QCBYXkaG+E5JRyRC6D401usUuGs1PtramPQn3+eY6rfrXlprTf1Qr//DVUj/ypwpwcrEGtqk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764076836; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CGNvIR5PxVeMt32KFU40tzaCgqPLgYeNUqpwd8sf1UQ=; b=SVjcnpwW4wG6BpyLA826IacdtJpGr/Kx1zTDeVQSV3Vh+QkUONvb85Bh46v2unLzNCgkStEQk4cO2QYq8mpKsibVYGIyQlxdIyXdnsXhRDDR8v0jq12E+hQ1oIH+7eRvSh2gUeEW0TGRsC6zOlnuUyv1oC5kh9z0Ng/3KoxGnPY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764076836341877.5092067633066; Tue, 25 Nov 2025 05:20:36 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNsxv-0000ds-Pu; Tue, 25 Nov 2025 08:20:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNsxq-0000ZN-KN for qemu-devel@nongnu.org; Tue, 25 Nov 2025 08:20:14 -0500 Received: from m16.mail.163.com ([117.135.210.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNsxl-0000jt-Om for qemu-devel@nongnu.org; Tue, 25 Nov 2025 08:20:14 -0500 Received: from DESKTOP-V2BFH29.localdomain (unknown []) by gzga-smtp-mtada-g1-4 (Coremail) with SMTP id _____wC38AL8rCVpHvoGCQ--.1521S2; Tue, 25 Nov 2025 21:19:56 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version: Content-Type; bh=CGNvIR5PxVeMt32KFU40tzaCgqPLgYeNUqpwd8sf1UQ=; b=L2xqrE1PjUM0Uc30Vwrrn5QzSJ4+CZNtsoPJB9F9W82Y1OnY5X0m5r/M/zVsBi WmwxXvh9ytv5KrwZlm0Me4miFCQ0oVqJbOF0DusHy4YwTgsiEMVwXYjFkTknp0Qs xqed3LpmX6tETalKLNL4sD9iYjXw7BubEGbDMWVRs0FB8= From: AlanoSong@163.com To: qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, Alano Song Subject: [RFC v2] ui/vnc: Fix qemu abort when query vnc info Date: Tue, 25 Nov 2025 21:19:55 +0800 Message-ID: <20251125131955.7024-1-AlanoSong@163.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wC38AL8rCVpHvoGCQ--.1521S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruF45KrWDGrW8uw1UZrW8JFb_yoWkKFX_ua 4jvw45Gry5GF4kGa12grs5ArWkXrsrGFWUGF9rKrW8GryUJFW5Xr1xXw1rurn7G39akrZ0 9rs5ZF98tw409jkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRi2NtUUUUUU== X-Originating-IP: [59.174.57.70] X-CM-SenderInfo: xdod00pvrqwqqrwthudrp/xtbBXwMRFGklqz4fQwAAsc Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=117.135.210.5; envelope-from=alanosong@163.com; helo=m16.mail.163.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @163.com) X-ZM-MESSAGEID: 1764076840940019200 When there is no display device on qemu machine, and user only access qemu by remote vnc. At the same time user input `info vnc` by QMP, the qemu will abort. To avoid the abort above, I add display device check, when query vnc info in qmp_query_vnc_servers(). Reviewed-by: Marc-Andr=C3=A9Lureau Signed-off-by: Alano Song --- ui/vnc.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 0d499b208b..3a54a6d24b 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -556,9 +556,15 @@ VncInfo2List *qmp_query_vnc_servers(Error **errp) qmp_query_auth(vd->auth, vd->subauth, &info->auth, &info->vencrypt, &info->has_vencrypt); if (vd->dcl.con) { - dev =3D DEVICE(object_property_get_link(OBJECT(vd->dcl.con), - "device", &error_abort)); - info->display =3D g_strdup(dev->id); + Error *err =3D NULL; + Object *obj =3D object_property_get_link(OBJECT(vd->dcl.con), + "device", &err); + if (obj) { + dev =3D DEVICE(obj); + info->display =3D g_strdup(dev->id); + } else { + error_free(err); + } } if (vd->listener !=3D NULL) { nsioc =3D qio_net_listener_nsioc(vd->listener); --=20 2.43.0