From nobody Mon Feb 9 07:57:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764068231; cv=none; d=zohomail.com; s=zohoarc; b=atjwMvjww/5x2cdoEA/LSEOgngOta4j5VH5qe9+gGY9yvXTq0yFSvGgKBLkYVeNe3KY+a4I1M77G0aPtgOa0rQMxY0FllcREPEE9XfI74QRHTAS8az9fNsvzIr3L1KVkb6aq2fLhwrfd5pL5//k+JkhISJE6PFUJPCQi1eRcLs4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764068231; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FtKth+b9TdPq30wZ/hp2A5R8f47SbZbi440xtKAdXk8=; b=ARfCps9cXI0ZjmZQQjA5K7bMZVgoFhKxT3uUDaPq58Z65VhHEbUhEDqxW4ObwcMiwwJhmC0+VFTAG/Z53bnk6TtG5xlp35owGW1No2jYfYcGxXxeRHlG4cXUPuLpnizsIF2SAJwu5mbT5j1056Lc+ldljXtqBOqxmHBaAvg+I70= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764068231319120.26769958441878; Tue, 25 Nov 2025 02:57:11 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNqhW-0003si-9A; Tue, 25 Nov 2025 05:55:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNqh7-0003eR-5z for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:54:51 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vNqh4-0001PZ-3d for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:54:48 -0500 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4775895d69cso22242585e9.0 for ; Tue, 25 Nov 2025 02:54:45 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fb91f4sm34331366f8f.31.2025.11.25.02.54.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 02:54:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764068083; x=1764672883; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FtKth+b9TdPq30wZ/hp2A5R8f47SbZbi440xtKAdXk8=; b=gTyY0jpjKH1pAxxN4P4DyTapD2xBf5LYj5ID7AkL/6uTDCsecOjF4tWED2wQfOuSVk +tw58Sc4VBeuWg0wN36Txoc7FI5mu22J/M7sddl/Z2vCFTRUDSMXykacw5GAAXsuweNF 40I7WXVa++U+O1kIXczxlag0kjtiwMBmuSwwEjhf3MzN2jCkcOt1qAOW7Qkyx7llITK2 qRcSYv7KpUyOC5mgn/79tiAcMNolDzBfeoK/tEMB8FrkbIVwPA1AYw9s13RHkirMWB4N KoNiif67O5R1Dup8kEuykjo7hBXMkZgSAKRCF9mRBr8Kxp34CXEL5qYJdzicQC0dKKNS ef3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764068083; x=1764672883; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FtKth+b9TdPq30wZ/hp2A5R8f47SbZbi440xtKAdXk8=; b=ncwtjhgVFwHqTydRpR6C5up/gvGInIho8rh1CDosmpzwcibKV6bBojnBYpBo3U+es2 sULcwz2JJCbJPKj30QlpmCeTUhcNabyEx6BeiniXRQ4Mz0qdAR1TItj7PTkbDJo9Alvr njCAY2zic1XDQmZRh+/j87b8zKWNNPPadhGBVRkBSXQoiAfCSXbmoDA5puuDlbik0t54 TctLwmUkQ7E0VVOgM7wrMx5neVXkMklmq65wSZBYq/hk3QuuRzWBuBN2gKjF7f3U6U1h LxeiesDZQsyrmH20mdhwGYq298yyFF+Mc066jf4GfJKHAbufBt/hyfHEDYGCCDoZHsdk SlWw== X-Gm-Message-State: AOJu0YxXFGB2bUulc1Eo0DCPdzf1O2HbVu40qCajFDDbRTNo8uwGEWyP JIzipRXloO/fTknipICYTL2YhzlhZCyC96W3X/cediHBaySMuBYQlu4wiKaPgqVm3eSwvJRVnlC IkFaHOWbHsQ== X-Gm-Gg: ASbGncuchvMYBC6KvtehzuxYmydfyyjeHygbRVqltyVSb5WN4PUOojBgmK/r8Q33b/V a6z8nCjZuNg/rPM78iM12HV1AMsMpFPmddyPAv0AYSgETCwM5MZJxU7kEGH1P2bLdV4l+gbK5br JNVj20/PHLRHPgHGbS5tcvxdWOH2UzJTZKcixCkkDtycnF7hA24JhhT1PkHyM1aqxy7b7o/Htzl XnekTAW5ppg7Xz8B8SrZBA/pOFcBSBAn43O1P+AcGxAEL/pmp0jRvyMcqRJ/onNgDw+fu9qvGZ0 +BHjCNWyUSYyyLbFqkrX2yFTVOvHs6uj/UJBJMM39yK1MIYUM3RxMQCN+uhjOcmJEu6C0zviZPG n5lqdjPCueveqHD68AYHzaI6dvdiAaK9NtGXYHRs/EIFGuYffe9opmc+VE6cnXceKw+KmtQaLM/ zW4xWNlIIz7j01NGroEC6e1zgNQgp92Xmq8EJLcxd4eRZsIhdf+U2pz8zD2beR X-Google-Smtp-Source: AGHT+IFaBvSEQ5Wqbc6MfyEWzq5WR0YZGeylAW80PRB1W31X6BTwbu5A//9Zo6uNtRPEWl1RL3KRcw== X-Received: by 2002:a05:6000:2004:b0:42b:3b8a:308c with SMTP id ffacd0b85a97d-42e0f34fa61mr2380260f8f.42.1764068083482; Tue, 25 Nov 2025 02:54:43 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Brian Cain Subject: [PATCH-for-11.0 01/12] target/hexagon: Use little-endian variant of cpu_ld/st_data*() Date: Tue, 25 Nov 2025 11:54:22 +0100 Message-ID: <20251125105434.92355-2-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125105434.92355-1-philmd@linaro.org> References: <20251125105434.92355-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764068232267019200 We only build the Hexagon target using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Dhexagon; \ end=3Dle; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Brian Cain --- target/hexagon/macros.h | 6 +++--- target/hexagon/op_helper.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h index 088e5961ab7..6c2862a2320 100644 --- a/target/hexagon/macros.h +++ b/target/hexagon/macros.h @@ -519,9 +519,9 @@ static inline TCGv gen_read_ireg(TCGv result, TCGv val,= int shift) #define fLOAD(NUM, SIZE, SIGN, EA, DST) MEM_LOAD##SIZE##SIGN(DST, EA) #else #define MEM_LOAD1 cpu_ldub_data_ra -#define MEM_LOAD2 cpu_lduw_data_ra -#define MEM_LOAD4 cpu_ldl_data_ra -#define MEM_LOAD8 cpu_ldq_data_ra +#define MEM_LOAD2 cpu_lduw_le_data_ra +#define MEM_LOAD4 cpu_ldl_le_data_ra +#define MEM_LOAD8 cpu_ldq_le_data_ra =20 #define fLOAD(NUM, SIZE, SIGN, EA, DST) \ do { \ diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index e2e80ca7efa..08db1e9c56b 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -77,13 +77,13 @@ static void commit_store(CPUHexagonState *env, int slot= _num, uintptr_t ra) cpu_stb_data_ra(env, va, env->mem_log_stores[slot_num].data32, ra); break; case 2: - cpu_stw_data_ra(env, va, env->mem_log_stores[slot_num].data32, ra); + cpu_stw_le_data_ra(env, va, env->mem_log_stores[slot_num].data32, = ra); break; case 4: - cpu_stl_data_ra(env, va, env->mem_log_stores[slot_num].data32, ra); + cpu_stl_le_data_ra(env, va, env->mem_log_stores[slot_num].data32, = ra); break; case 8: - cpu_stq_data_ra(env, va, env->mem_log_stores[slot_num].data64, ra); + cpu_stq_le_data_ra(env, va, env->mem_log_stores[slot_num].data64, = ra); break; default: g_assert_not_reached(); --=20 2.51.0 From nobody Mon Feb 9 07:57:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764068149; cv=none; d=zohomail.com; s=zohoarc; b=JRCIJ+JNm+DghHMYpZ+TmAXYe7bVDGR/OI8jmH72V5XsO+F0XaLiPo2ilTtt27WJ8lIDIi+83L8wN/r/M38XxTD+pAaAtQqSNKLC+YW+QLnT0t+82wzYxTIiIqO2/jKl+TtMZeKf4mYLBZ002vAzCu3tDW2z6NuAY54laFcN1No= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764068149; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=g6GufoGaaceDifeP+Y5j1u2tXZkEGmQIoKK0KjlWQxI=; b=hmffnBwb8/armmiHBZKRm0H/nbxGTAlVivHN+64/KqsSVU16aOxlcCopWFRGk6RGVo7n21lPs08RJ9qFHmqBYChASoFjv1IcTQIzG7x6nFN2JaB60WqAwZBzkl6G1GqCSjoj9DOACJVkHpC5UHxG1wcZk3Z/+DcaCqSg1oLWaPs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764068149467435.34053017959934; Tue, 25 Nov 2025 02:55:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNqhU-0003mE-BJ; Tue, 25 Nov 2025 05:55:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNqhI-0003gv-9J for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:01 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vNqhC-0001QL-Ku for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:54:57 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-477a219db05so31660525e9.2 for ; Tue, 25 Nov 2025 02:54:53 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47903e65d51sm16430725e9.0.2025.11.25.02.54.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 02:54:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764068092; x=1764672892; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g6GufoGaaceDifeP+Y5j1u2tXZkEGmQIoKK0KjlWQxI=; b=Q4oo59RtsHK7MnNJHzQm7gS+RZnpzQZvZTYSf+ajeAqDfvpnXArGoaEB73ikzwcZ47 +IUfde7sKKgrmTyWKlTZM9pyPLr/E5e0r3ueRGzCdLzw5RByPCtYlfBcNJcrlT0PniOe vK9V4SWB7F5nG6K8MyNESqi8vP34b3r+VOOQEI+SwVzXHlxGJRTEUBSfsrn4RNVYCj/L jzccSoOvceGfDS0aQMjWWxWWLdaAxIkDOEb3RzsJIjOwB91zhyzSxlHs3lAMg6drBYkD 71t/i1l/1Gr5JhE7qunxjjo4/ceOq59qf6aolw/y4F9/w4TIzAjALje/WL8cVGO7qKnZ OzmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764068092; x=1764672892; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=g6GufoGaaceDifeP+Y5j1u2tXZkEGmQIoKK0KjlWQxI=; b=wsAtmFzc7ERUWjCia2Ndu0zrAXnVjVVwdBeEodW/D8IzlkpOa0IUdyE/vjsil693hn M1ESSCHS52PLAdVEqAWEB9KYOyu55IXG78T1uU+C/JazkJXcQMn+NRkXo9LXE4c0ko0w 9rIIXG195DF9CDamopXFzXhSZ0cB93pTT4kIVyTZnMJMgknrqgw4fneMW4JEo9ksyIEX /eO2JR2CLKMUDUPmd9FIor/0xHXhjHKivOQ3nLELmwnOzrfsZ7Nn+sRT8BUBYw9C0tUl rPaL3bBqVyc9C6tr/UhjNBm/aH/VZcz3i+8TMSy/bxxcBI5ip7AYaHCSIKAEy04uRLUT rcRw== X-Gm-Message-State: AOJu0Yy0numWD/37708ifwC5tADDWlgjj74En4GugXbzr8KdEV6RxPNF T6vCABYIx8Dbx5DX0yqLl6Rd5UxBJeAw9KWXOKHwOHQ9pOfXxIpS7ZINhuQqMenf1nwZHz4F86m jNtalNpD3RA== X-Gm-Gg: ASbGncuXrmrP07RaV/oyOA9ctspOHnARvjZSrC4K4vtUZv/Cd0vUqpIbWetELoFQtPb E+mrlygQbedTcC07oTOPBUqr4Va6TFe+XvgynwBVeIkkQTD8XofYJETSLwl0dzphhuiPXdyMMd2 a9UWzgtrbaqZ9dixkbZHZrqoSrWD7BXvxMe6GrG5h2FuUz0TfiWGLuAywKgmVZsXLtvlNDGv9+B MxuBlpOLBVuj8ij2bhhQ2fNqM/tU1+18PqLziHTxYFCHgHBOwNaLVPJtPvBUHk4Kx1RUUmbIad9 G7+Y553/0ICCak72ntQYaLLDQ5FgCoiob/j8+QXLEKbNoCWsa9DZD9IYWfbwa2MDpukeC8teBaq V+TijyMFBfMmC+Tg+6SWTXgtC359KnXTxiX1Sl8MUCjMxjIQC6O6EaES19rqENQhgbLvB8ge0rc 6t90uJ0GJvqfz6vpZXiSq3GsKb64EshYqwGf2QW+Nq7dtUbhbMr4w2vAgvGRh2 X-Google-Smtp-Source: AGHT+IGTXEORh517e6jh2cAd5XrOFD9M9eoLrqIHgzw8P2Mr4PGtCsWY8/Ln20cAEnjBigspVpmRBA== X-Received: by 2002:a05:600c:529a:b0:477:8a2a:123e with SMTP id 5b1f17b1804b1-477c1133932mr142115545e9.33.1764068091647; Tue, 25 Nov 2025 02:54:51 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Bastian Koppelmann Subject: [PATCH-for-11.0 02/12] target/tricore: Use little-endian variant of cpu_ld/st_data*() Date: Tue, 25 Nov 2025 11:54:23 +0100 Message-ID: <20251125105434.92355-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125105434.92355-1-philmd@linaro.org> References: <20251125105434.92355-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764068149841019200 We only build the TriCore target using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Dtricore; \ end=3Dle; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/tricore/op_helper.c | 152 ++++++++++++++++++------------------- 1 file changed, 76 insertions(+), 76 deletions(-) diff --git a/target/tricore/op_helper.c b/target/tricore/op_helper.c index 2c8281a67e0..88b50bc1a9b 100644 --- a/target/tricore/op_helper.c +++ b/target/tricore/op_helper.c @@ -2451,84 +2451,84 @@ static bool cdc_zero(uint32_t *psw) =20 static void save_context_upper(CPUTriCoreState *env, uint32_t ea) { - cpu_stl_data(env, ea, env->PCXI); - cpu_stl_data(env, ea+4, psw_read(env)); - cpu_stl_data(env, ea+8, env->gpr_a[10]); - cpu_stl_data(env, ea+12, env->gpr_a[11]); - cpu_stl_data(env, ea+16, env->gpr_d[8]); - cpu_stl_data(env, ea+20, env->gpr_d[9]); - cpu_stl_data(env, ea+24, env->gpr_d[10]); - cpu_stl_data(env, ea+28, env->gpr_d[11]); - cpu_stl_data(env, ea+32, env->gpr_a[12]); - cpu_stl_data(env, ea+36, env->gpr_a[13]); - cpu_stl_data(env, ea+40, env->gpr_a[14]); - cpu_stl_data(env, ea+44, env->gpr_a[15]); - cpu_stl_data(env, ea+48, env->gpr_d[12]); - cpu_stl_data(env, ea+52, env->gpr_d[13]); - cpu_stl_data(env, ea+56, env->gpr_d[14]); - cpu_stl_data(env, ea+60, env->gpr_d[15]); + cpu_stl_le_data(env, ea, env->PCXI); + cpu_stl_le_data(env, ea+4, psw_read(env)); + cpu_stl_le_data(env, ea+8, env->gpr_a[10]); + cpu_stl_le_data(env, ea+12, env->gpr_a[11]); + cpu_stl_le_data(env, ea+16, env->gpr_d[8]); + cpu_stl_le_data(env, ea+20, env->gpr_d[9]); + cpu_stl_le_data(env, ea+24, env->gpr_d[10]); + cpu_stl_le_data(env, ea+28, env->gpr_d[11]); + cpu_stl_le_data(env, ea+32, env->gpr_a[12]); + cpu_stl_le_data(env, ea+36, env->gpr_a[13]); + cpu_stl_le_data(env, ea+40, env->gpr_a[14]); + cpu_stl_le_data(env, ea+44, env->gpr_a[15]); + cpu_stl_le_data(env, ea+48, env->gpr_d[12]); + cpu_stl_le_data(env, ea+52, env->gpr_d[13]); + cpu_stl_le_data(env, ea+56, env->gpr_d[14]); + cpu_stl_le_data(env, ea+60, env->gpr_d[15]); } =20 static void save_context_lower(CPUTriCoreState *env, uint32_t ea) { - cpu_stl_data(env, ea, env->PCXI); - cpu_stl_data(env, ea+4, env->gpr_a[11]); - cpu_stl_data(env, ea+8, env->gpr_a[2]); - cpu_stl_data(env, ea+12, env->gpr_a[3]); - cpu_stl_data(env, ea+16, env->gpr_d[0]); - cpu_stl_data(env, ea+20, env->gpr_d[1]); - cpu_stl_data(env, ea+24, env->gpr_d[2]); - cpu_stl_data(env, ea+28, env->gpr_d[3]); - cpu_stl_data(env, ea+32, env->gpr_a[4]); - cpu_stl_data(env, ea+36, env->gpr_a[5]); - cpu_stl_data(env, ea+40, env->gpr_a[6]); - cpu_stl_data(env, ea+44, env->gpr_a[7]); - cpu_stl_data(env, ea+48, env->gpr_d[4]); - cpu_stl_data(env, ea+52, env->gpr_d[5]); - cpu_stl_data(env, ea+56, env->gpr_d[6]); - cpu_stl_data(env, ea+60, env->gpr_d[7]); + cpu_stl_le_data(env, ea, env->PCXI); + cpu_stl_le_data(env, ea+4, env->gpr_a[11]); + cpu_stl_le_data(env, ea+8, env->gpr_a[2]); + cpu_stl_le_data(env, ea+12, env->gpr_a[3]); + cpu_stl_le_data(env, ea+16, env->gpr_d[0]); + cpu_stl_le_data(env, ea+20, env->gpr_d[1]); + cpu_stl_le_data(env, ea+24, env->gpr_d[2]); + cpu_stl_le_data(env, ea+28, env->gpr_d[3]); + cpu_stl_le_data(env, ea+32, env->gpr_a[4]); + cpu_stl_le_data(env, ea+36, env->gpr_a[5]); + cpu_stl_le_data(env, ea+40, env->gpr_a[6]); + cpu_stl_le_data(env, ea+44, env->gpr_a[7]); + cpu_stl_le_data(env, ea+48, env->gpr_d[4]); + cpu_stl_le_data(env, ea+52, env->gpr_d[5]); + cpu_stl_le_data(env, ea+56, env->gpr_d[6]); + cpu_stl_le_data(env, ea+60, env->gpr_d[7]); } =20 static void restore_context_upper(CPUTriCoreState *env, uint32_t ea, uint32_t *new_PCXI, uint32_t *new_PSW) { - *new_PCXI =3D cpu_ldl_data(env, ea); - *new_PSW =3D cpu_ldl_data(env, ea+4); - env->gpr_a[10] =3D cpu_ldl_data(env, ea+8); - env->gpr_a[11] =3D cpu_ldl_data(env, ea+12); - env->gpr_d[8] =3D cpu_ldl_data(env, ea+16); - env->gpr_d[9] =3D cpu_ldl_data(env, ea+20); - env->gpr_d[10] =3D cpu_ldl_data(env, ea+24); - env->gpr_d[11] =3D cpu_ldl_data(env, ea+28); - env->gpr_a[12] =3D cpu_ldl_data(env, ea+32); - env->gpr_a[13] =3D cpu_ldl_data(env, ea+36); - env->gpr_a[14] =3D cpu_ldl_data(env, ea+40); - env->gpr_a[15] =3D cpu_ldl_data(env, ea+44); - env->gpr_d[12] =3D cpu_ldl_data(env, ea+48); - env->gpr_d[13] =3D cpu_ldl_data(env, ea+52); - env->gpr_d[14] =3D cpu_ldl_data(env, ea+56); - env->gpr_d[15] =3D cpu_ldl_data(env, ea+60); + *new_PCXI =3D cpu_ldl_le_data(env, ea); + *new_PSW =3D cpu_ldl_le_data(env, ea+4); + env->gpr_a[10] =3D cpu_ldl_le_data(env, ea+8); + env->gpr_a[11] =3D cpu_ldl_le_data(env, ea+12); + env->gpr_d[8] =3D cpu_ldl_le_data(env, ea+16); + env->gpr_d[9] =3D cpu_ldl_le_data(env, ea+20); + env->gpr_d[10] =3D cpu_ldl_le_data(env, ea+24); + env->gpr_d[11] =3D cpu_ldl_le_data(env, ea+28); + env->gpr_a[12] =3D cpu_ldl_le_data(env, ea+32); + env->gpr_a[13] =3D cpu_ldl_le_data(env, ea+36); + env->gpr_a[14] =3D cpu_ldl_le_data(env, ea+40); + env->gpr_a[15] =3D cpu_ldl_le_data(env, ea+44); + env->gpr_d[12] =3D cpu_ldl_le_data(env, ea+48); + env->gpr_d[13] =3D cpu_ldl_le_data(env, ea+52); + env->gpr_d[14] =3D cpu_ldl_le_data(env, ea+56); + env->gpr_d[15] =3D cpu_ldl_le_data(env, ea+60); } =20 static void restore_context_lower(CPUTriCoreState *env, uint32_t ea, uint32_t *ra, uint32_t *pcxi) { - *pcxi =3D cpu_ldl_data(env, ea); - *ra =3D cpu_ldl_data(env, ea+4); - env->gpr_a[2] =3D cpu_ldl_data(env, ea+8); - env->gpr_a[3] =3D cpu_ldl_data(env, ea+12); - env->gpr_d[0] =3D cpu_ldl_data(env, ea+16); - env->gpr_d[1] =3D cpu_ldl_data(env, ea+20); - env->gpr_d[2] =3D cpu_ldl_data(env, ea+24); - env->gpr_d[3] =3D cpu_ldl_data(env, ea+28); - env->gpr_a[4] =3D cpu_ldl_data(env, ea+32); - env->gpr_a[5] =3D cpu_ldl_data(env, ea+36); - env->gpr_a[6] =3D cpu_ldl_data(env, ea+40); - env->gpr_a[7] =3D cpu_ldl_data(env, ea+44); - env->gpr_d[4] =3D cpu_ldl_data(env, ea+48); - env->gpr_d[5] =3D cpu_ldl_data(env, ea+52); - env->gpr_d[6] =3D cpu_ldl_data(env, ea+56); - env->gpr_d[7] =3D cpu_ldl_data(env, ea+60); + *pcxi =3D cpu_ldl_le_data(env, ea); + *ra =3D cpu_ldl_le_data(env, ea+4); + env->gpr_a[2] =3D cpu_ldl_le_data(env, ea+8); + env->gpr_a[3] =3D cpu_ldl_le_data(env, ea+12); + env->gpr_d[0] =3D cpu_ldl_le_data(env, ea+16); + env->gpr_d[1] =3D cpu_ldl_le_data(env, ea+20); + env->gpr_d[2] =3D cpu_ldl_le_data(env, ea+24); + env->gpr_d[3] =3D cpu_ldl_le_data(env, ea+28); + env->gpr_a[4] =3D cpu_ldl_le_data(env, ea+32); + env->gpr_a[5] =3D cpu_ldl_le_data(env, ea+36); + env->gpr_a[6] =3D cpu_ldl_le_data(env, ea+40); + env->gpr_a[7] =3D cpu_ldl_le_data(env, ea+44); + env->gpr_d[4] =3D cpu_ldl_le_data(env, ea+48); + env->gpr_d[5] =3D cpu_ldl_le_data(env, ea+52); + env->gpr_d[6] =3D cpu_ldl_le_data(env, ea+56); + env->gpr_d[7] =3D cpu_ldl_le_data(env, ea+60); } =20 void helper_call(CPUTriCoreState *env, uint32_t next_pc) @@ -2566,7 +2566,7 @@ void helper_call(CPUTriCoreState *env, uint32_t next_= pc) ea =3D ((env->FCX & MASK_FCX_FCXS) << 12) + ((env->FCX & MASK_FCX_FCXO) << 6); /* new_FCX =3D M(EA, word); */ - new_FCX =3D cpu_ldl_data(env, ea); + new_FCX =3D cpu_ldl_le_data(env, ea); /* M(EA, 16 * word) =3D {PCXI, PSW, A[10], A[11], D[8], D[9], D[10], D= [11], A[12], A[13], A[14], A[15], D[12], D[13], D[14], D[15]}; */ @@ -2632,7 +2632,7 @@ void helper_ret(CPUTriCoreState *env) A[13], A[14], A[15], D[12], D[13], D[14], D[15]} =3D M(EA, 16 * wo= rd); */ restore_context_upper(env, ea, &new_PCXI, &new_PSW); /* M(EA, word) =3D FCX; */ - cpu_stl_data(env, ea, env->FCX); + cpu_stl_le_data(env, ea, env->FCX); /* FCX[19: 0] =3D PCXI[19: 0]; */ env->FCX =3D (env->FCX & 0xfff00000) + (env->PCXI & 0x000fffff); /* PCXI =3D new_PCXI; */ @@ -2662,7 +2662,7 @@ void helper_bisr(CPUTriCoreState *env, uint32_t const= 9) ea =3D ((env->FCX & 0xf0000) << 12) + ((env->FCX & 0xffff) << 6); =20 /* new_FCX =3D M(EA, word); */ - new_FCX =3D cpu_ldl_data(env, ea); + new_FCX =3D cpu_ldl_le_data(env, ea); /* M(EA, 16 * word) =3D {PCXI, A[11], A[2], A[3], D[0], D[1], D[2], D[= 3], A[4] , A[5], A[6], A[7], D[4], D[5], D[6], D[7]}; */ save_context_lower(env, ea); @@ -2726,7 +2726,7 @@ void helper_rfe(CPUTriCoreState *env) A[13], A[14], A[15], D[12], D[13], D[14], D[15]} =3D M(EA, 16 * word= ); */ restore_context_upper(env, ea, &new_PCXI, &new_PSW); /* M(EA, word) =3D FCX;*/ - cpu_stl_data(env, ea, env->FCX); + cpu_stl_le_data(env, ea, env->FCX); /* FCX[19: 0] =3D PCXI[19: 0]; */ env->FCX =3D (env->FCX & 0xfff00000) + (env->PCXI & 0x000fffff); /* PCXI =3D new_PCXI; */ @@ -2744,10 +2744,10 @@ void helper_rfm(CPUTriCoreState *env) icr_set_ccpn(env, pcxi_get_pcpn(env)); =20 /* {PCXI, PSW, A[10], A[11]} =3D M(DCX, 4 * word); */ - env->PCXI =3D cpu_ldl_data(env, env->DCX); - psw_write(env, cpu_ldl_data(env, env->DCX+4)); - env->gpr_a[10] =3D cpu_ldl_data(env, env->DCX+8); - env->gpr_a[11] =3D cpu_ldl_data(env, env->DCX+12); + env->PCXI =3D cpu_ldl_le_data(env, env->DCX); + psw_write(env, cpu_ldl_le_data(env, env->DCX+4)); + env->gpr_a[10] =3D cpu_ldl_le_data(env, env->DCX+8); + env->gpr_a[11] =3D cpu_ldl_le_data(env, env->DCX+12); =20 if (tricore_has_feature(env, TRICORE_FEATURE_131)) { env->DBGTCR =3D 0; @@ -2794,7 +2794,7 @@ void helper_svlcx(CPUTriCoreState *env) ea =3D ((env->FCX & MASK_FCX_FCXS) << 12) + ((env->FCX & MASK_FCX_FCXO) << 6); /* new_FCX =3D M(EA, word); */ - new_FCX =3D cpu_ldl_data(env, ea); + new_FCX =3D cpu_ldl_le_data(env, ea); /* M(EA, 16 * word) =3D {PCXI, PSW, A[10], A[11], D[8], D[9], D[10], D= [11], A[12], A[13], A[14], A[15], D[12], D[13], D[14], D[15]}; */ @@ -2837,7 +2837,7 @@ void helper_svucx(CPUTriCoreState *env) ea =3D ((env->FCX & MASK_FCX_FCXS) << 12) + ((env->FCX & MASK_FCX_FCXO) << 6); /* new_FCX =3D M(EA, word); */ - new_FCX =3D cpu_ldl_data(env, ea); + new_FCX =3D cpu_ldl_le_data(env, ea); /* M(EA, 16 * word) =3D {PCXI, PSW, A[10], A[11], D[8], D[9], D[10], D= [11], A[12], A[13], A[14], A[15], D[12], D[13], D[14], D[15]}; */ @@ -2887,9 +2887,9 @@ void helper_rslcx(CPUTriCoreState *env) A[13], A[14], A[15], D[12], D[13], D[14], D[15]} =3D M(EA, 16 * wo= rd); */ restore_context_lower(env, ea, &env->gpr_a[11], &new_PCXI); /* M(EA, word) =3D FCX; */ - cpu_stl_data(env, ea, env->FCX); + cpu_stl_le_data(env, ea, env->FCX); /* M(EA, word) =3D FCX; */ - cpu_stl_data(env, ea, env->FCX); + cpu_stl_le_data(env, ea, env->FCX); /* FCX[19: 0] =3D PCXI[19: 0]; */ env->FCX =3D (env->FCX & 0xfff00000) + (env->PCXI & 0x000fffff); /* PCXI =3D new_PCXI; */ --=20 2.51.0 From nobody Mon Feb 9 07:57:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764068133; cv=none; d=zohomail.com; s=zohoarc; b=GPg6otBtmEYp6c4VCxronrqhgsmXYShYCtAGLZLV5DuWmHOKCMscrbtPlaPoutwDXMB0qDlgdFKMWs60t2zA8xvRJkHrRxtp635+HC46WNe24iyFMhX5nZoR16s0nbUjlaKYDBMbnwNb94zDGW1skoBWxgm5BQg7SPGykCnHsXo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764068133; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NVumjk0F6Tq93V240FNbMOnFtVOEoBWTLGnL0WT9/nA=; b=hLSGY4Ps5pG+FQC2BQdI/wKnvtvME909x200pEqTd3QE69+2cvMOzVRkh3hPYmZ+anq0QAxhqqBT+7jbfwjxKf4faPN5YKMkpEDjLJWHwd2AawO/J2G6rCwbkC7+jgpJ8T8wY5n0uoZhAeEJzaoSaVGt0+IxW7p+7nSsngvwsR8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764068133536761.2701519975083; Tue, 25 Nov 2025 02:55:33 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNqhX-0003xs-Q7; Tue, 25 Nov 2025 05:55:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNqhN-0003j8-EO for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:09 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vNqhK-0001Qj-0n for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:04 -0500 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-429c7869704so4457953f8f.2 for ; Tue, 25 Nov 2025 02:55:00 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f363e4sm34060597f8f.12.2025.11.25.02.54.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 02:54:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764068099; x=1764672899; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NVumjk0F6Tq93V240FNbMOnFtVOEoBWTLGnL0WT9/nA=; b=IlTwdXmkY45ydg66iilqx+bOGLC0ywl2qnjjFJ/orAYpF5DEtpTEgoXRIr+nbeSJY/ MaMG6WEmEEAzzT7xNEmzCPj7vs+WSEKYKRmBqM+MZHDhdNWr0U+Z1hi0oo+toB8i0gaC nNV3FYtNZ0Mucs1XaWXnGGIJdLWC82iHoOUU96fXo5XJPoIa04c4NY8Syqwbu3KpNO8S rdUqib+vp3N3LlMHPuFclFViPX1KTPm0iIr/ZufMGkhan2h7zhcWJ+0SKFe5iAnLJCjq qyHZoFubO3I5YICJLk+FYnQilgeSuPXPmzsU+93xcrRLMPNK9RS5s8FvgsKnEaksZC8Z TfOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764068099; x=1764672899; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NVumjk0F6Tq93V240FNbMOnFtVOEoBWTLGnL0WT9/nA=; b=Eeue2wQwax9YQQF3792pH2lB1glUTtKVVG7inqLlYCdWDqFbT3bRxowxATPYukNQH0 m2qJ8Jc5pZv8NEPk7FhHqSkX2/5f6kh1SQHo052GQfZu5wK7FMjoTHtf2tW+vIqzaePP O0688rj9vRTSuwf7micc8W0FLB1pgpZZmLPsVjfnz/2L6tFAdfsOl6bIDK4nPMSAtQsT A46i3d3XPsxNvtRZrSElulLlYUVFy8FCBdifhI65YVoBVi+5xj19KhWK/12OGDirqJUs UWEyI3hZK5I65A6CAh78JMbv5JlLSqLbdTq4LGOFMfeMNJzXJW+7HWaxh79Xku6s13m4 jkcQ== X-Gm-Message-State: AOJu0Yx3/Km5XyRIkWBrDuc6WOAL7+QZDG6Kj6IVNHA6xMYUFwEaQUYv IC4Xy+8nA0kj8oSdv3ICH2qLt6G35HAB3CMMrYyZUn+QuArYfZpzknREa9gnUs+zGYPAgUrswd0 Y7hKCkt6nmw== X-Gm-Gg: ASbGncsB4vmYIJ3SQ+QV0Fy3kjCw3/dURhTaTmxSIAHTN22BFQU2SiqC4pbM8K+bPdW 1c7+U+jUBI4eaJ5veG3l5r2DLjh5l6SRrImrhBqPmGj6JWAkaZiSfMuufKK/rbBFgeHaIhJnk4B j3tfKUQ/eMEpqMiW39cV8KYUzJer5DereSVaEDkVoDhnvupiMF2F/xL/cS4mYgTSRZ1xu4ydwId 96iLHMrz8sc3MRNWhXoZVCXyWcGgBjsq5FcOeVMFyfWfcNRZ3NgVCiHmedxpg+y4tKTV7F0WGjh wCrbMtaKiNtqjF30tT93pzZ254iYBIBOyIwe4DI+XN6mzf7PkIOqARVstzJERHzN4xGAKDrp3Wy VX4vSHxSx+TZMH/9WO0WssF5UKTtMzQ+L2gf/4A9ReR3BZH4EcULhzgaErkg2Q+740MKzHZ+GSF mi5Ctf+mtU3B9aF/0oglPmPn0+wFTJivCIKCMyk+pUdd/nDuXiJiVIYPGBybC+d3Pf48qcogs= X-Google-Smtp-Source: AGHT+IEiVpF5o+SfyjWN7bCv64a0BsvPVLLknCQNWUQyyXwxLPUetlS8IgypNYrMqQE9+aneNqCs1Q== X-Received: by 2002:a05:6000:2210:b0:42b:4961:eb4c with SMTP id ffacd0b85a97d-42e0f1d57f9mr2509092f8f.1.1764068098723; Tue, 25 Nov 2025 02:54:58 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Yoshinori Sato Subject: [PATCH-for-11.0 03/12] target/rx: Use little-endian variant of cpu_ld/st_data*() Date: Tue, 25 Nov 2025 11:54:24 +0100 Message-ID: <20251125105434.92355-4-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125105434.92355-1-philmd@linaro.org> References: <20251125105434.92355-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764068135666019200 We only build the RX target using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Drx; \ end=3Dle; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/rx/helper.c | 14 +++++++------- target/rx/op_helper.c | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/target/rx/helper.c b/target/rx/helper.c index e9a7aaf610d..83cd491eb4a 100644 --- a/target/rx/helper.c +++ b/target/rx/helper.c @@ -68,10 +68,10 @@ void rx_cpu_do_interrupt(CPUState *cs) qemu_log_mask(CPU_LOG_INT, "fast interrupt raised\n"); } else if (cpu_test_interrupt(cs, CPU_INTERRUPT_HARD)) { env->isp -=3D 4; - cpu_stl_data(env, env->isp, save_psw); + cpu_stl_le_data(env, env->isp, save_psw); env->isp -=3D 4; - cpu_stl_data(env, env->isp, env->pc); - env->pc =3D cpu_ldl_data(env, env->intb + env->ack_irq * 4); + cpu_stl_le_data(env, env->isp, env->pc); + env->pc =3D cpu_ldl_le_data(env, env->intb + env->ack_irq * 4); env->psw_ipl =3D env->ack_ipl; cpu_reset_interrupt(cs, CPU_INTERRUPT_HARD); qemu_set_irq(env->ack, env->ack_irq); @@ -82,14 +82,14 @@ void rx_cpu_do_interrupt(CPUState *cs) const char *expname =3D "unknown exception"; =20 env->isp -=3D 4; - cpu_stl_data(env, env->isp, save_psw); + cpu_stl_le_data(env, env->isp, save_psw); env->isp -=3D 4; - cpu_stl_data(env, env->isp, env->pc); + cpu_stl_le_data(env, env->isp, env->pc); =20 if (vec < 0x100) { - env->pc =3D cpu_ldl_data(env, 0xffffff80 + vec * 4); + env->pc =3D cpu_ldl_le_data(env, 0xffffff80 + vec * 4); } else { - env->pc =3D cpu_ldl_data(env, env->intb + (vec & 0xff) * 4); + env->pc =3D cpu_ldl_le_data(env, env->intb + (vec & 0xff) * 4); } =20 if (vec =3D=3D 30) { diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c index 2b190a4b2cf..ca3e9e85fc7 100644 --- a/target/rx/op_helper.c +++ b/target/rx/op_helper.c @@ -217,20 +217,20 @@ void helper_scmpu(CPURXState *env) static uint32_t (* const cpu_ldufn[])(CPUArchState *env, abi_ptr ptr, uintptr_t retaddr) =3D { - cpu_ldub_data_ra, cpu_lduw_data_ra, cpu_ldl_data_ra, + cpu_ldub_data_ra, cpu_lduw_le_data_ra, cpu_ldl_le_data_ra, }; =20 static uint32_t (* const cpu_ldfn[])(CPUArchState *env, abi_ptr ptr, uintptr_t retaddr) =3D { - cpu_ldub_data_ra, cpu_lduw_data_ra, cpu_ldl_data_ra, + cpu_ldub_data_ra, cpu_lduw_le_data_ra, cpu_ldl_le_data_ra, }; =20 static void (* const cpu_stfn[])(CPUArchState *env, abi_ptr ptr, uint32_t val, uintptr_t retaddr) =3D { - cpu_stb_data_ra, cpu_stw_data_ra, cpu_stl_data_ra, + cpu_stb_data_ra, cpu_stw_le_data_ra, cpu_stl_le_data_ra, }; =20 void helper_sstr(CPURXState *env, uint32_t sz) --=20 2.51.0 From nobody Mon Feb 9 07:57:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764068234; cv=none; d=zohomail.com; s=zohoarc; b=N8MawKhGKTg5uekPkSVQ96tApilz6fsgGxC1289xUxOdKDc4+5rb5WGYfX+tu/OxIIIbW2eAiVmPRCCbyDE2eMX/5FSpzcJ2eyeoLGDxFRRAhZjqojuwhqn6oEA1jewXHYD2pxpk9B6LFwQVHC53c4AEXUJaZCgvJXsU25L99to= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764068234; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=27Oww4qQxdixc+Id3IXgq5AJQ19OjMu/GDoS0nr9Vqw=; b=EaJOBvLONKrBSQHi/qbyKyKBFveYKfRpHlbBTiu2x/3hOl6nmNORtMKvrd+w7/+t/8SOBDgDxOPIc+W2WzWi75414ZNEWcc/23qY89jBy5wae7IkGGq2yvaCCptIHXNmep7NWNKB1LYx25i/uqFwSSYPbYoPkiOCZGwg9uQg6nY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764068234414910.3724716297894; Tue, 25 Nov 2025 02:57:14 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNqhZ-00042T-Jy; Tue, 25 Nov 2025 05:55:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNqhS-0003mT-RM for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:12 -0500 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vNqhQ-0001cw-BC for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:10 -0500 Received: by mail-wm1-x344.google.com with SMTP id 5b1f17b1804b1-4779a637712so32655645e9.1 for ; Tue, 25 Nov 2025 02:55:07 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fba20esm33716389f8f.37.2025.11.25.02.55.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 02:55:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764068106; x=1764672906; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=27Oww4qQxdixc+Id3IXgq5AJQ19OjMu/GDoS0nr9Vqw=; b=AERx+yVH92H4qj75A6QQ0juHjQ1xLqZtI9Xx7wqmoo5KZAHnmPvVIXQ6TfV5Uqd6bl sxCUfx4DyxZ/UIYuczLZmpIJwBDWFpHwPBuhV6o3+mUrbMzybEvxEnTIYbK6Bmv7JQKM 0BQjXsiTZCG8ZTYMBwVB0pseSr2/HLAds2J0nZWsS5eaCcap1vPibXJ4LkQ2P9mvxje+ gqZvgZZKzhmHGfjAXfojFUkvSpxaIRUQj+IPKByz+wbsphZ0qN+ZHcJV9u/V+mfCOO+x +lADQug97AFGByCfpoalW9RO5X2HfBB2uj00sIwQtDQQ9oRmnocoHZkNpF7E8yKy6/ww ZKxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764068106; x=1764672906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=27Oww4qQxdixc+Id3IXgq5AJQ19OjMu/GDoS0nr9Vqw=; b=diUsbE6OjpMkk0ia7SbxuRgmXbIiMYvcL3NSFlrn2tkNf0ou3fwPHlEKAMEnQrVZtj emslMXFPp0r75TAN8xFODo6wcdMO6hrUTaAzlPogcsXKKSMRIhP1O5D+ZdK+yo5/35ip auNqTtCFeKMPcUcl4q2fvrW9Tt+uz5jPaBgWpJ1853L6xH6ecGg75RI26sgUoz9+Fexc dymU9+v0a+/8OMJ2QqN27fJJsP/YkwQC+9dYrmThoS2Cfp9K7NsidGjlWpcxMvXm49eW aswoBm1sUqwk6uis5je3dWuxjyherAQAGztzswpkXoqHltRoBDscHf3IQ5iXsEmfvNrR OkxA== X-Gm-Message-State: AOJu0YynJRoDNkEKwmMf15rXLIdvm+j45cv1TZARfZbsUHaTdAllXeSv MCv/YdCRUBMMnOUIudHiquhsdvoxeXgtUyU9nKtVcMS1CHLwSDmYDPuJETl3BFkG2w1JyQmseLd EY53oQsibY77L X-Gm-Gg: ASbGncsnSNLD2wbsutKvMObRrNXo91/zKtHBDUJCzyqnGC9FR77WwX6DcumvK6xw++j iIi28NHtE0WNJPPPrg87FcF9C+1kFQGI0DFAnFAl0bc+RfbBxAr0YcUc+Vp1ksBYpv8qq3QOU6+ 6wzQDsiEdXfcXVsuMcEoaC9k5X+0MQCUTh61IocfWAyZ4nXG9WIABr/EzQFdCoqKmUOylaxjQRc 2UtaRjtIZ92yEKeWURiuUZG4yOxU7oyHOieJGW8/MIVoITg2UrMtoiT2C+bZxTqJtlqd8l7cBr6 i2Zp2WEzNVZM6TOLw1n1mwts1hcHJXcpzJZuwdLS0aggagRt2Cx+4E+JWPKuE6IXzlsK2Vrq3w7 jWpwQlFRMlV2CZZr6vQx20ywSrVayjw3Y2A5ONoovxtF+OUF0t2eFHuv6vHF4XLD5oc60v0yqvV q4TbSbFuy45GqUT0SvaBOEDZE/5XAUlrzZ6I2J08wxyJwSabE/KLWbJ5S12Gz1 X-Google-Smtp-Source: AGHT+IG5wAax9M2wPLydKe/qH81pYYW/FEoJGxK+P8LAWQtVmIFngUJ+IUH7VGp9Anxqxxp5ubmJog== X-Received: by 2002:a05:600c:4f88:b0:477:af07:dd17 with SMTP id 5b1f17b1804b1-477c01c3721mr191342375e9.24.1764068105830; Tue, 25 Nov 2025 02:55:05 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier Subject: [PATCH-for-11.0 04/12] target/m68k: Use little-endian variant of cpu_ld/st_data*() Date: Tue, 25 Nov 2025 11:54:25 +0100 Message-ID: <20251125105434.92355-5-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125105434.92355-1-philmd@linaro.org> References: <20251125105434.92355-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::344; envelope-from=philmd@linaro.org; helo=mail-wm1-x344.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764068236341019200 We only build the M68k target using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Dm68k; \ end=3Dbe; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/m68k/fpu_helper.c | 12 +++--- target/m68k/op_helper.c | 88 ++++++++++++++++++++-------------------- 2 files changed, 50 insertions(+), 50 deletions(-) diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.c index 56012863c85..f49f841d489 100644 --- a/target/m68k/fpu_helper.c +++ b/target/m68k/fpu_helper.c @@ -510,8 +510,8 @@ static int cpu_ld_floatx80_ra(CPUM68KState *env, uint32= _t addr, FPReg *fp, uint32_t high; uint64_t low; =20 - high =3D cpu_ldl_data_ra(env, addr, ra); - low =3D cpu_ldq_data_ra(env, addr + 4, ra); + high =3D cpu_ldl_be_data_ra(env, addr, ra); + low =3D cpu_ldq_be_data_ra(env, addr + 4, ra); =20 fp->l.upper =3D high >> 16; fp->l.lower =3D low; @@ -522,8 +522,8 @@ static int cpu_ld_floatx80_ra(CPUM68KState *env, uint32= _t addr, FPReg *fp, static int cpu_st_floatx80_ra(CPUM68KState *env, uint32_t addr, FPReg *fp, uintptr_t ra) { - cpu_stl_data_ra(env, addr, fp->l.upper << 16, ra); - cpu_stq_data_ra(env, addr + 4, fp->l.lower, ra); + cpu_stl_be_data_ra(env, addr, fp->l.upper << 16, ra); + cpu_stq_be_data_ra(env, addr + 4, fp->l.lower, ra); =20 return 12; } @@ -533,7 +533,7 @@ static int cpu_ld_float64_ra(CPUM68KState *env, uint32_= t addr, FPReg *fp, { uint64_t val; =20 - val =3D cpu_ldq_data_ra(env, addr, ra); + val =3D cpu_ldq_be_data_ra(env, addr, ra); fp->d =3D float64_to_floatx80(*(float64 *)&val, &env->fp_status); =20 return 8; @@ -545,7 +545,7 @@ static int cpu_st_float64_ra(CPUM68KState *env, uint32_= t addr, FPReg *fp, float64 val; =20 val =3D floatx80_to_float64(fp->d, &env->fp_status); - cpu_stq_data_ra(env, addr, *(uint64_t *)&val, ra); + cpu_stq_be_data_ra(env, addr, *(uint64_t *)&val, ra); =20 return 8; } diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c index e9c20a8e032..eac45669ce7 100644 --- a/target/m68k/op_helper.c +++ b/target/m68k/op_helper.c @@ -32,8 +32,8 @@ static void cf_rte(CPUM68KState *env) uint32_t fmt; =20 sp =3D env->aregs[7]; - fmt =3D cpu_ldl_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); - env->pc =3D cpu_ldl_mmuidx_ra(env, sp + 4, MMU_KERNEL_IDX, 0); + fmt =3D cpu_ldl_be_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); + env->pc =3D cpu_ldl_be_mmuidx_ra(env, sp + 4, MMU_KERNEL_IDX, 0); sp |=3D (fmt >> 28) & 3; env->aregs[7] =3D sp + 8; =20 @@ -48,13 +48,13 @@ static void m68k_rte(CPUM68KState *env) =20 sp =3D env->aregs[7]; throwaway: - sr =3D cpu_lduw_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); + sr =3D cpu_lduw_be_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); sp +=3D 2; - env->pc =3D cpu_ldl_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); + env->pc =3D cpu_ldl_be_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); sp +=3D 4; if (m68k_feature(env, M68K_FEATURE_EXCEPTION_FORMAT_VEC)) { /* all except 68000 */ - fmt =3D cpu_lduw_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); + fmt =3D cpu_lduw_be_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); sp +=3D 2; switch (fmt >> 12) { case 0: @@ -250,12 +250,12 @@ static void cf_interrupt_all(CPUM68KState *env, int i= s_hw) /* ??? This could cause MMU faults. */ sp &=3D ~3; sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, retaddr, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, retaddr, MMU_KERNEL_IDX, 0); sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, fmt, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, fmt, MMU_KERNEL_IDX, 0); env->aregs[7] =3D sp; /* Jump to vector. */ - env->pc =3D cpu_ldl_mmuidx_ra(env, env->vbr + vector, MMU_KERNEL_IDX, = 0); + env->pc =3D cpu_ldl_be_mmuidx_ra(env, env->vbr + vector, MMU_KERNEL_ID= X, 0); =20 do_plugin_vcpu_interrupt_cb(cs, retaddr); } @@ -270,24 +270,24 @@ static inline void do_stack_frame(CPUM68KState *env, = uint32_t *sp, switch (format) { case 4: *sp -=3D 4; - cpu_stl_mmuidx_ra(env, *sp, env->pc, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, *sp, env->pc, MMU_KERNEL_IDX, 0); *sp -=3D 4; - cpu_stl_mmuidx_ra(env, *sp, addr, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, *sp, addr, MMU_KERNEL_IDX, 0); break; case 3: case 2: *sp -=3D 4; - cpu_stl_mmuidx_ra(env, *sp, addr, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, *sp, addr, MMU_KERNEL_IDX, 0); break; } *sp -=3D 2; - cpu_stw_mmuidx_ra(env, *sp, (format << 12) + (cs->exception_index = << 2), + cpu_stw_be_mmuidx_ra(env, *sp, (format << 12) + (cs->exception_ind= ex << 2), MMU_KERNEL_IDX, 0); } *sp -=3D 4; - cpu_stl_mmuidx_ra(env, *sp, retaddr, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, *sp, retaddr, MMU_KERNEL_IDX, 0); *sp -=3D 2; - cpu_stw_mmuidx_ra(env, *sp, sr, MMU_KERNEL_IDX, 0); + cpu_stw_be_mmuidx_ra(env, *sp, sr, MMU_KERNEL_IDX, 0); } =20 static void m68k_interrupt_all(CPUM68KState *env, int is_hw) @@ -346,49 +346,49 @@ static void m68k_interrupt_all(CPUM68KState *env, int= is_hw) env->mmu.fault =3D true; /* push data 3 */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* push data 2 */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* push data 1 */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 1 / push data 0 */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 1 address */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 2 data */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 2 address */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 3 data */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 3 address */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, env->mmu.ar, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, env->mmu.ar, MMU_KERNEL_IDX, 0); /* fault address */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, env->mmu.ar, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, env->mmu.ar, MMU_KERNEL_IDX, 0); /* write back 1 status */ sp -=3D 2; - cpu_stw_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stw_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 2 status */ sp -=3D 2; - cpu_stw_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stw_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 3 status */ sp -=3D 2; - cpu_stw_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stw_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* special status word */ sp -=3D 2; - cpu_stw_mmuidx_ra(env, sp, env->mmu.ssw, MMU_KERNEL_IDX, 0); + cpu_stw_be_mmuidx_ra(env, sp, env->mmu.ssw, MMU_KERNEL_IDX, 0); /* effective address */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, env->mmu.ar, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, env->mmu.ar, MMU_KERNEL_IDX, 0); =20 do_stack_frame(env, &sp, 7, oldsr, 0, env->pc); env->mmu.fault =3D false; @@ -436,7 +436,7 @@ static void m68k_interrupt_all(CPUM68KState *env, int i= s_hw) =20 env->aregs[7] =3D sp; /* Jump to vector. */ - env->pc =3D cpu_ldl_mmuidx_ra(env, env->vbr + vector, MMU_KERNEL_IDX, = 0); + env->pc =3D cpu_ldl_be_mmuidx_ra(env, env->vbr + vector, MMU_KERNEL_ID= X, 0); =20 do_plugin_vcpu_interrupt_cb(cs, last_pc); } @@ -784,11 +784,11 @@ void HELPER(cas2w)(CPUM68KState *env, uint32_t regs, = uint32_t a1, uint32_t a2) int16_t l1, l2; uintptr_t ra =3D GETPC(); =20 - l1 =3D cpu_lduw_data_ra(env, a1, ra); - l2 =3D cpu_lduw_data_ra(env, a2, ra); + l1 =3D cpu_lduw_be_data_ra(env, a1, ra); + l2 =3D cpu_lduw_be_data_ra(env, a2, ra); if (l1 =3D=3D c1 && l2 =3D=3D c2) { - cpu_stw_data_ra(env, a1, u1, ra); - cpu_stw_data_ra(env, a2, u2, ra); + cpu_stw_be_data_ra(env, a1, u1, ra); + cpu_stw_be_data_ra(env, a2, u2, ra); } =20 if (c1 !=3D l1) { @@ -845,11 +845,11 @@ static void do_cas2l(CPUM68KState *env, uint32_t regs= , uint32_t a1, uint32_t a2, } } else { /* We're executing in a serial context -- no need to be atomic. */ - l1 =3D cpu_ldl_data_ra(env, a1, ra); - l2 =3D cpu_ldl_data_ra(env, a2, ra); + l1 =3D cpu_ldl_be_data_ra(env, a1, ra); + l2 =3D cpu_ldl_be_data_ra(env, a2, ra); if (l1 =3D=3D c1 && l2 =3D=3D c2) { - cpu_stl_data_ra(env, a1, u1, ra); - cpu_stl_data_ra(env, a2, u2, ra); + cpu_stl_be_data_ra(env, a1, u1, ra); + cpu_stl_be_data_ra(env, a2, u2, ra); } } =20 @@ -951,12 +951,12 @@ static uint64_t bf_load(CPUM68KState *env, uint32_t a= ddr, int blen, case 0: return cpu_ldub_data_ra(env, addr, ra); case 1: - return cpu_lduw_data_ra(env, addr, ra); + return cpu_lduw_be_data_ra(env, addr, ra); case 2: case 3: - return cpu_ldl_data_ra(env, addr, ra); + return cpu_ldl_be_data_ra(env, addr, ra); case 4: - return cpu_ldq_data_ra(env, addr, ra); + return cpu_ldq_be_data_ra(env, addr, ra); default: g_assert_not_reached(); } @@ -970,14 +970,14 @@ static void bf_store(CPUM68KState *env, uint32_t addr= , int blen, cpu_stb_data_ra(env, addr, data, ra); break; case 1: - cpu_stw_data_ra(env, addr, data, ra); + cpu_stw_be_data_ra(env, addr, data, ra); break; case 2: case 3: - cpu_stl_data_ra(env, addr, data, ra); + cpu_stl_be_data_ra(env, addr, data, ra); break; case 4: - cpu_stq_data_ra(env, addr, data, ra); + cpu_stq_be_data_ra(env, addr, data, ra); break; default: g_assert_not_reached(); --=20 2.51.0 From nobody Mon Feb 9 07:57:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764068166; cv=none; d=zohomail.com; s=zohoarc; b=iWbSHqCyE0fA3q9FiVtRzLJH4q3ApnmnH5zlBx4qqZUv1UG2UhpgQsBc3RFHqJEjbN/raisFy3WgjYIr+SeqI2PLcAcTdpTNoZxcWyacHKKfwqxI6z6ecCKNq7AOlzfo06zqXsFzRtOTIjrH6phs2htRaSWi1At7M4fe0pHbNyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764068166; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QBX0cTyOfypgSePFwe7y0VDhNeDc+UxNVe7O+z7zfxs=; b=G5expdweVd+tJ7HwtSoqyG4GkeAjIhEJOIrLNNJG1aoqpX8F2mDmjwate7q5bcPJTafm6DTj5dEfr69SSOMTOltNLXSJzpzAyDI2N8323WxK1sGZERwPDsIyE1IDHHiHO2+zY+DmIEeRwN1VLSShCteBIk5ptBXCLgY8nlpUB4M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764068165995624.8996669347208; Tue, 25 Nov 2025 02:56:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNqhd-0004Bm-U3; Tue, 25 Nov 2025 05:55:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNqhb-000460-L5 for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:19 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vNqhX-0001en-P1 for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:19 -0500 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-477a219db05so31662815e9.2 for ; Tue, 25 Nov 2025 02:55:14 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf3b4c13sm243662865e9.13.2025.11.25.02.55.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 02:55:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764068113; x=1764672913; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QBX0cTyOfypgSePFwe7y0VDhNeDc+UxNVe7O+z7zfxs=; b=Dxn8pj6UAaIX+ycTC8EyFnRuTd9V12LwNC7+9os/F6vrUCnoWux0soBewphoD65kcq ji6HV/3JwiKJeb16WJxxsSHO4jcWtKuJOQ29j5Z5T/86ymEUpLT5/rngwad61OHQXNNY g4wGLdAXjINTYqPq+5UC6ULYxp4+Jwlq56xsFAOUPTSKaLtoNYu9Auo7gQ7R2RV8/2h8 JiDSpL4aIVAcQsI9IkFxh+na43/giw4Sd2ZSo4A7YH6/wV158+h/LFr9I67L0cDUsj8C SIqkzXIEfwsNFEHgmfLAeR7RyoAbO+nEIsdNHtb9fgvAxFxjsU7MYMuGDRvM39RVrvhC nBrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764068113; x=1764672913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QBX0cTyOfypgSePFwe7y0VDhNeDc+UxNVe7O+z7zfxs=; b=XWErlD2emziDeo2vDvCDxjkgcBCSSOwjmN7aSj1OLKcJYwdrepIXX3PD1hiWCi04V8 XUpc5UQ4revXtKqdR6wh1HqYocTZX7Mi9WRRYwUfHXJxJ12OwsfNFahPF9vPkDbg4n8f jK60QVkvRaVYY1QP7zEbgMNMiO34c+gtbNVdaae7NihimAcoAQhPDzuN5SKu/JqacU/S qOfzC4KhTygLk4yOHiYYChpiQKlqN31zc6kj3NJV7iDLAtpe4x5mUBiOyULOeFeCxi3X kAbYTz/DjAgtdE6L+NcSpFf7UnsB5RauVglLW2p3MxO2ZbJ4LfLoJq7PYyTLoteQbniS qFhg== X-Gm-Message-State: AOJu0YwD2MKhZ51D0pbXvNsKlINoEKYgxGbkQSHXCTwWTci/YW751Lqm BO9ZJ8he9DRNdjnQ0jEZQkblTSnaCXYvDe1oz1wBbQCE1Krd15JxfVG22EEMX6OWO2GltNYW3Cz MvujCOOhckA== X-Gm-Gg: ASbGncuG42Z9QV6ZA7Ldo+Ahl2kKnSOfVe4XOss44cNrKNtuWC+yCL/TxoYLe3Ylw3W YUnOxK5jpG4wLa7Z9uM6uHLOWG0pfUE0d0gdj5WpJ0UWSYZKcl9P54XsCokuwM9zfE/WAaNg+TE eeNQMykan9HRuZlA9MoMmzBWxsTKYki8sHZMBgFaSlGlh6cImNXxpy1778rX2JrBMIQWc846XJR hHdKIdA5wx0PMNb202K3xFFXL7HigW3kKrxuBrb03KBFQTBCHx0zXOdWsMG2U+QiYlVhENboTmk F3yNUkYB6dsvD1JYO53V85GQJ+U8tW3QEtIGkrdoMPc0IeCEnmahPrxmJnzCXFFp/+3nxTnbVeN t7sGZdacThD/1fFDSpDmdV19700yuOGcTp+fQyQltq59tHfnIuXtPd3ymnH9CvIZvVfRK6ewJW4 zshnI4WkyOh6xSLFNfM2qKpZRMXCnF65xo/9xqgnEZDGPqhrbi7yjmB7414syy X-Google-Smtp-Source: AGHT+IF10+EarZb+KODThEaCO/W17Ttqob+eAK+nkvNF/XmYe4Y37Mjtashzw+Ih+rlX0MbTGOS40A== X-Received: by 2002:a05:600c:3511:b0:476:d494:41d2 with SMTP id 5b1f17b1804b1-477c112f7b1mr145384405e9.29.1764068113305; Tue, 25 Nov 2025 02:55:13 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Ilya Leoshkevich , David Hildenbrand , Thomas Huth Subject: [PATCH-for-11.0 05/12] target/s390x: Use little-endian variant of cpu_ld/st_data*() Date: Tue, 25 Nov 2025 11:54:26 +0100 Message-ID: <20251125105434.92355-6-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125105434.92355-1-philmd@linaro.org> References: <20251125105434.92355-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764068167821019200 We only build the S390x target using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Ds390x; \ end=3Dbe; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/s390x/tcg/mem_helper.c | 48 +++++++++++++++++------------------ target/s390x/tcg/vec_helper.c | 8 +++--- 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c index 24675fc818d..482c3febf91 100644 --- a/target/s390x/tcg/mem_helper.c +++ b/target/s390x/tcg/mem_helper.c @@ -101,7 +101,7 @@ static inline uint64_t cpu_ldusize_data_ra(CPUS390XStat= e *env, uint64_t addr, case 1: return cpu_ldub_data_ra(env, addr, ra); case 2: - return cpu_lduw_data_ra(env, addr, ra); + return cpu_lduw_be_data_ra(env, addr, ra); default: abort(); } @@ -117,7 +117,7 @@ static inline void cpu_stsize_data_ra(CPUS390XState *en= v, uint64_t addr, cpu_stb_data_ra(env, addr, value, ra); break; case 2: - cpu_stw_data_ra(env, addr, value, ra); + cpu_stw_be_data_ra(env, addr, value, ra); break; default: abort(); @@ -865,7 +865,7 @@ void HELPER(srstu)(CPUS390XState *env, uint32_t r1, uin= t32_t r2) env->cc_op =3D 2; return; } - v =3D cpu_lduw_data_ra(env, str + len, ra); + v =3D cpu_lduw_be_data_ra(env, str + len, ra); if (v =3D=3D c) { /* Character found. Set R1 to the location; R2 is unmodified.= */ env->cc_op =3D 1; @@ -1022,7 +1022,7 @@ void HELPER(lam)(CPUS390XState *env, uint32_t r1, uin= t64_t a2, uint32_t r3) } =20 for (i =3D r1;; i =3D (i + 1) % 16) { - env->aregs[i] =3D cpu_ldl_data_ra(env, a2, ra); + env->aregs[i] =3D cpu_ldl_be_data_ra(env, a2, ra); a2 +=3D 4; =20 if (i =3D=3D r3) { @@ -1042,7 +1042,7 @@ void HELPER(stam)(CPUS390XState *env, uint32_t r1, ui= nt64_t a2, uint32_t r3) } =20 for (i =3D r1;; i =3D (i + 1) % 16) { - cpu_stl_data_ra(env, a2, env->aregs[i], ra); + cpu_stl_be_data_ra(env, a2, env->aregs[i], ra); a2 +=3D 4; =20 if (i =3D=3D r3) { @@ -1363,7 +1363,7 @@ Int128 HELPER(cksm)(CPUS390XState *env, uint64_t r1, =20 /* Process full words as available. */ for (len =3D 0; len + 4 <=3D max_len; len +=3D 4, src +=3D 4) { - cksm +=3D (uint32_t)cpu_ldl_data_ra(env, src, ra); + cksm +=3D (uint32_t)cpu_ldl_be_data_ra(env, src, ra); } =20 switch (max_len - len) { @@ -1372,11 +1372,11 @@ Int128 HELPER(cksm)(CPUS390XState *env, uint64_t r1, len +=3D 1; break; case 2: - cksm +=3D cpu_lduw_data_ra(env, src, ra) << 16; + cksm +=3D cpu_lduw_be_data_ra(env, src, ra) << 16; len +=3D 2; break; case 3: - cksm +=3D cpu_lduw_data_ra(env, src, ra) << 16; + cksm +=3D cpu_lduw_be_data_ra(env, src, ra) << 16; cksm +=3D cpu_ldub_data_ra(env, src + 2, ra) << 8; len +=3D 3; break; @@ -1955,7 +1955,7 @@ void HELPER(lctlg)(CPUS390XState *env, uint32_t r1, u= int64_t a2, uint32_t r3) } =20 for (i =3D r1;; i =3D (i + 1) % 16) { - uint64_t val =3D cpu_ldq_data_ra(env, src, ra); + uint64_t val =3D cpu_ldq_be_data_ra(env, src, ra); if (env->cregs[i] !=3D val && i >=3D 9 && i <=3D 11) { PERchanged =3D true; } @@ -1992,7 +1992,7 @@ void HELPER(lctl)(CPUS390XState *env, uint32_t r1, ui= nt64_t a2, uint32_t r3) } =20 for (i =3D r1;; i =3D (i + 1) % 16) { - uint32_t val =3D cpu_ldl_data_ra(env, src, ra); + uint32_t val =3D cpu_ldl_be_data_ra(env, src, ra); uint64_t val64 =3D deposit64(env->cregs[i], 0, 32, val); if ((uint32_t)env->cregs[i] !=3D val && i >=3D 9 && i <=3D 11) { PERchanged =3D true; @@ -2028,7 +2028,7 @@ void HELPER(stctg)(CPUS390XState *env, uint32_t r1, u= int64_t a2, uint32_t r3) } =20 for (i =3D r1;; i =3D (i + 1) % 16) { - cpu_stq_data_ra(env, dest, env->cregs[i], ra); + cpu_stq_be_data_ra(env, dest, env->cregs[i], ra); dest +=3D sizeof(uint64_t); =20 if (i =3D=3D r3) { @@ -2048,7 +2048,7 @@ void HELPER(stctl)(CPUS390XState *env, uint32_t r1, u= int64_t a2, uint32_t r3) } =20 for (i =3D r1;; i =3D (i + 1) % 16) { - cpu_stl_data_ra(env, dest, env->cregs[i], ra); + cpu_stl_be_data_ra(env, dest, env->cregs[i], ra); dest +=3D sizeof(uint32_t); =20 if (i =3D=3D r3) { @@ -2065,7 +2065,7 @@ uint32_t HELPER(testblock)(CPUS390XState *env, uint64= _t real_addr) real_addr =3D wrap_address(env, real_addr) & TARGET_PAGE_MASK; =20 for (i =3D 0; i < TARGET_PAGE_SIZE; i +=3D 8) { - cpu_stq_mmuidx_ra(env, real_addr + i, 0, MMU_REAL_IDX, ra); + cpu_stq_be_mmuidx_ra(env, real_addr + i, 0, MMU_REAL_IDX, ra); } =20 return 0; @@ -2324,11 +2324,11 @@ void HELPER(idte)(CPUS390XState *env, uint64_t r1, = uint64_t r2, uint32_t m4) for (i =3D 0; i < entries; i++) { /* addresses are not wrapped in 24/31bit mode but table index = is */ raddr =3D table + ((index + i) & 0x7ff) * sizeof(entry); - entry =3D cpu_ldq_mmuidx_ra(env, raddr, MMU_REAL_IDX, ra); + entry =3D cpu_ldq_be_mmuidx_ra(env, raddr, MMU_REAL_IDX, ra); if (!(entry & REGION_ENTRY_I)) { /* we are allowed to not store if already invalid */ entry |=3D REGION_ENTRY_I; - cpu_stq_mmuidx_ra(env, raddr, entry, MMU_REAL_IDX, ra); + cpu_stq_be_mmuidx_ra(env, raddr, entry, MMU_REAL_IDX, ra); } } } @@ -2355,9 +2355,9 @@ void HELPER(ipte)(CPUS390XState *env, uint64_t pto, u= int64_t vaddr, pte_addr +=3D VADDR_PAGE_TX(vaddr) * 8; =20 /* Mark the page table entry as invalid */ - pte =3D cpu_ldq_mmuidx_ra(env, pte_addr, MMU_REAL_IDX, ra); + pte =3D cpu_ldq_be_mmuidx_ra(env, pte_addr, MMU_REAL_IDX, ra); pte |=3D PAGE_ENTRY_I; - cpu_stq_mmuidx_ra(env, pte_addr, pte, MMU_REAL_IDX, ra); + cpu_stq_be_mmuidx_ra(env, pte_addr, pte, MMU_REAL_IDX, ra); =20 /* XXX we exploit the fact that Linux passes the exact virtual address here - it's not obliged to! */ @@ -2695,7 +2695,7 @@ static int decode_utf16(CPUS390XState *env, uint64_t = addr, uint64_t ilen, if (ilen < 2) { return 0; } - s0 =3D cpu_lduw_data_ra(env, addr, ra); + s0 =3D cpu_lduw_be_data_ra(env, addr, ra); if ((s0 & 0xfc00) !=3D 0xd800) { /* one word character */ l =3D 2; @@ -2706,7 +2706,7 @@ static int decode_utf16(CPUS390XState *env, uint64_t = addr, uint64_t ilen, if (ilen < 4) { return 0; } - s1 =3D cpu_lduw_data_ra(env, addr + 2, ra); + s1 =3D cpu_lduw_be_data_ra(env, addr + 2, ra); c =3D extract32(s0, 6, 4) + 1; c =3D (c << 6) | (s0 & 0x3f); c =3D (c << 10) | (s1 & 0x3ff); @@ -2730,7 +2730,7 @@ static int decode_utf32(CPUS390XState *env, uint64_t = addr, uint64_t ilen, if (ilen < 4) { return 0; } - c =3D cpu_ldl_data_ra(env, addr, ra); + c =3D cpu_ldl_be_data_ra(env, addr, ra); if ((c >=3D 0xd800 && c <=3D 0xdbff) || c > 0x10ffff) { /* invalid unicode character */ return 2; @@ -2792,7 +2792,7 @@ static int encode_utf16(CPUS390XState *env, uint64_t = addr, uint64_t ilen, if (ilen < 2) { return 1; } - cpu_stw_data_ra(env, addr, c, ra); + cpu_stw_be_data_ra(env, addr, c, ra); *olen =3D 2; } else { /* two word character */ @@ -2802,8 +2802,8 @@ static int encode_utf16(CPUS390XState *env, uint64_t = addr, uint64_t ilen, d1 =3D 0xdc00 | extract32(c, 0, 10); d0 =3D 0xd800 | extract32(c, 10, 6); d0 =3D deposit32(d0, 6, 4, extract32(c, 16, 5) - 1); - cpu_stw_data_ra(env, addr + 0, d0, ra); - cpu_stw_data_ra(env, addr + 2, d1, ra); + cpu_stw_be_data_ra(env, addr + 0, d0, ra); + cpu_stw_be_data_ra(env, addr + 2, d1, ra); *olen =3D 4; } =20 @@ -2816,7 +2816,7 @@ static int encode_utf32(CPUS390XState *env, uint64_t = addr, uint64_t ilen, if (ilen < 4) { return 1; } - cpu_stl_data_ra(env, addr, c, ra); + cpu_stl_be_data_ra(env, addr, c, ra); *olen =3D 4; return -1; } diff --git a/target/s390x/tcg/vec_helper.c b/target/s390x/tcg/vec_helper.c index 46ec4a947dd..304745c971b 100644 --- a/target/s390x/tcg/vec_helper.c +++ b/target/s390x/tcg/vec_helper.c @@ -45,9 +45,9 @@ void HELPER(vll)(CPUS390XState *env, void *v1, uint64_t a= ddr, uint64_t bytes) if (likely(bytes >=3D 16)) { uint64_t t0, t1; =20 - t0 =3D cpu_ldq_data_ra(env, addr, GETPC()); + t0 =3D cpu_ldq_be_data_ra(env, addr, GETPC()); addr =3D wrap_address(env, addr + 8); - t1 =3D cpu_ldq_data_ra(env, addr, GETPC()); + t1 =3D cpu_ldq_be_data_ra(env, addr, GETPC()); s390_vec_write_element64(v1, 0, t0); s390_vec_write_element64(v1, 1, t1); } else { @@ -195,9 +195,9 @@ void HELPER(vstl)(CPUS390XState *env, const void *v1, u= int64_t addr, probe_write_access(env, addr, MIN(bytes, 16), GETPC()); =20 if (likely(bytes >=3D 16)) { - cpu_stq_data_ra(env, addr, s390_vec_read_element64(v1, 0), GETPC()= ); + cpu_stq_be_data_ra(env, addr, s390_vec_read_element64(v1, 0), GETP= C()); addr =3D wrap_address(env, addr + 8); - cpu_stq_data_ra(env, addr, s390_vec_read_element64(v1, 1), GETPC()= ); + cpu_stq_be_data_ra(env, addr, s390_vec_read_element64(v1, 1), GETP= C()); } else { int i; =20 --=20 2.51.0 From nobody Mon Feb 9 07:57:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764068177; cv=none; d=zohomail.com; s=zohoarc; b=U3agnmoxyNNilbkVP5ivupGYGkTJgTYAZBhK4E3yqnEFdlB1k86IThA661j3wud2xmIHqMeMTRTiFPBwYJ7B2d8/Rm6RlVl9iHnwLZqX1zDj5oDa8K1k96Tm71N7Wu5QwmUiirEpQQPRMsXDDrGH/X58BzcGoKGOl9dJf5lcup4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764068177; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lJnvThjS80O1Eon7AqXWBK1cOL1m23OMM4urIwDftzk=; b=Rmmwnd7Y4MaRPfpVRZ2RNuGyFiuNgQXNBrUI/SMqs4AOlImcy+F4i0I/vbaRiAnAmgH/Lsmkvmo9kzShdLAgYo4KMf8IF2WF2rotxbclkJjcuAy1WOOhqdILCQCuX3YwM84Hy6c4rTOcSL8gG0YV7OznhSslW5rZN7Nez/ICSK0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764068177350593.4117919328532; Tue, 25 Nov 2025 02:56:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNqhj-0004GR-3S; Tue, 25 Nov 2025 05:55:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNqhg-0004EE-Iw for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:24 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vNqhe-0001fa-OX for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:24 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4779a4fc95aso40263015e9.1 for ; Tue, 25 Nov 2025 02:55:21 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cc231dc6esm24752764f8f.7.2025.11.25.02.55.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 02:55:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764068120; x=1764672920; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lJnvThjS80O1Eon7AqXWBK1cOL1m23OMM4urIwDftzk=; b=dSDcv4fY4jLmCrbYeNtvQ0dYyApViaKAs/GV1CV50xxofebri4Ke+gZoNPhANMrfHm WMcLzGwDp/+TZl9Zh2R4TAz+wimCjsXXrleFitFX44woseRj2dMKlRYSPKfDtfjPgSRw ZQKV0nPfC60OYcVtE8ZTTB2QdHwdY3b0NNDdmxanloM+LKKeQGt+tTspJ6tLmlqSk4I9 9NrYLLcjOiRUirvB5J1EU9wQqMEmj+YwQfbiBn69AF/usgtj34n8YqUZCUIhOPbtdpGd VHdQqkxtxd6/qra20DCaDajVFUjkMK33Kd+PYYFQS2y9A1eZRk1NJO2P1EoGwW6Z1TZB zYyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764068120; x=1764672920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lJnvThjS80O1Eon7AqXWBK1cOL1m23OMM4urIwDftzk=; b=COsa3lBtuxqhfPQ5zLQxnTw18H7lYW2hoqq+fZwYlTOicYMmZhVxlRCHnXRhnW21pY r1+q39lqpVOyBBP0FXHMEtaYJ45J8cdcqefWqxkffGWzB6iWJViFYwW9znwAjj2Rz7GM RzgtAH2thvp/Xo1JO+cklL1yMvRx+mVfdO4s2DIPqPBVE8Ztv8P9Y8xG9W1buwYIzRuN dkL82C/G2N8vvm18EBufRBZfCQk3qr32dDa4hrxPmmLtjYqwj/ypYqRXlUsJiROYQnrB iOb9pHb0HZtYywQeT9LdJjW/0VycQYhSR3DYcYXmgjYORRA8+dv1QN0BVJLKYMeMOuLS IbAg== X-Gm-Message-State: AOJu0Yx6yZQtS6E0Sjz3inNJ8XPLl1dBNqRiDih7iLiYeNzTOTtmVeeb Lq5Qno/2gFuXM7NZSepPyTyUBQ3nP+/5DtZiOqzOgckJerQ1lfzfM8xSSkDLSuHXTAc6CyvMOup LmvsJpfOxlg== X-Gm-Gg: ASbGncvuLNfU2Hn8iW3WKRewvolzVt0aoBvitaAJ9Z/kfIUoT9F2f0Pl5cVIsZbn1Pv 0t0Sd6rdM6ywhmgVl3jifpusTNOojX4397rPKO109I3wezKGfbCI3aOiDrGquFLR6kGB8z2xKV+ smlwyvE46GITCW9u4M27kOxv2IYWqFcdG4LGBDcP2cF/RMQ4TGULR42Qosgj6TNwmxKoZXXTcAa DpMt/ru3WTkcuX/hd81REKBX3zX5krIIrvnu0SGPy4gzhUjSI7haUX1tUnGvE1BG4mzb/YKGOrN QikC+YdzowQq/rAHSwRhKNmiDBZHFi9N2Q5bSk8DIU1NQ79R6N8s9V2zt2O2ZwNj5uH1GhQ1BzQ h8WmTJhI8r7vC+nVCqJaTKotUMPzpiRYcYt1HqZ2oWlQwm/UdDCjmx50asXVOyWgazHgsxr9XmV dyY1NHm/SK7ARN8DIMXylZLroL1mdpM3xtErfiRdaXxy32kLGnygsT1ISOXfrO X-Google-Smtp-Source: AGHT+IGsqiVHH5SjJWCQB8QRWjbF3lU+3KogymlcesoKSiwG5fKIhJYXXZqXGAfxfKyTCo39hLqidw== X-Received: by 2002:a05:6000:4010:b0:42b:3dbe:3a37 with SMTP id ffacd0b85a97d-42cc1302285mr17879937f8f.10.1764068120487; Tue, 25 Nov 2025 02:55:20 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mark Cave-Ayland , Artyom Tarasenko Subject: [PATCH-for-11.0 06/12] target/sparc: Use little-endian variant of cpu_ld/st_data*() Date: Tue, 25 Nov 2025 11:54:27 +0100 Message-ID: <20251125105434.92355-7-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125105434.92355-1-philmd@linaro.org> References: <20251125105434.92355-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764068177944019200 We only build the SPARC targets using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Dsparc; \ end=3Dbe; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/ldst_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 2c63eb9e036..bd0257d313a 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -1228,13 +1228,13 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_u= long addr, ret =3D cpu_ldub_data(env, addr); break; case 2: - ret =3D cpu_lduw_data(env, addr); + ret =3D cpu_lduw_be_data(env, addr); break; case 4: - ret =3D cpu_ldl_data(env, addr); + ret =3D cpu_ldl_be_data(env, addr); break; case 8: - ret =3D cpu_ldq_data(env, addr); + ret =3D cpu_ldq_be_data(env, addr); break; default: g_assert_not_reached(); --=20 2.51.0 From nobody Mon Feb 9 07:57:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764068175; cv=none; d=zohomail.com; s=zohoarc; b=etkk98qDoa/aNI5hZdsJOuJZPPo0gLXi075yRO3vj0kYWqlUANMwajKGeB8niT/wfGBkdHhYrH28bzJP7EnaLjrHhzFSn0J3+i1K+YTh00Xq9yX74Bw/Qa/39jUkzCOP665jFYjy6k4nyGb83oeOH7WISNSUwl1pmjWRJEcllX8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764068175; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cSMQofszP9d0Zf69Q3/r02u7/TYYXgRxG7oyvHr35Vw=; b=nhj/bj4wmKLbMl9rYraL43IyGGfqHHxEKtYICMBc0P2322DNvnI1yysZZcUDK2X69mOsJVsMPLVFICbyvVhAdY1gRZsRQB3IeEmu2vuqJ9Svx3Kq9UTwxG3pbRCJkWRIebqEOFRL8oDR4Tzmm89bCigzDZLmBMXVEGRXGz2eDVc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764068175930284.25734857130135; Tue, 25 Nov 2025 02:56:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNqiG-0004iE-SK; Tue, 25 Nov 2025 05:56:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNqht-0004Qx-Qw for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:39 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vNqhn-0001gO-TG for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:36 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4779cb0a33fso52187675e9.0 for ; Tue, 25 Nov 2025 02:55:30 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4790530f0a4sm12914155e9.8.2025.11.25.02.55.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 02:55:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764068129; x=1764672929; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cSMQofszP9d0Zf69Q3/r02u7/TYYXgRxG7oyvHr35Vw=; b=EOsotMNdt3miDTZ1EozAvDKABmyspJezY0Sw8W15ZuElLGEAuB3DiOSIebWbKqLRJ7 epHFZ+PFZLne+wleJHaR9t8g7dUfR1Ul32atuwR4rxiy8bVHviucWGrUwGUBHvkWBqSl yr2Ddh+v/HZ/MwG8JjlYDQSovSAizbyXZN2hshLp7fKQ/55Jc2kxI7v2XLctEc8H1cKD 1LxNoxL/BNs8b5/kqPfV+mBngFWIpzvhVk7OXU8wjoiN6d2i9QCz48UDH1JyuNxHYyAc bV+pDvYrP3J80FZaIclTZDoXdJYPJ4ye/UXUFoSehAwq77o+w/N5YLUjFtdu4LRopIWD wA5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764068129; x=1764672929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cSMQofszP9d0Zf69Q3/r02u7/TYYXgRxG7oyvHr35Vw=; b=MhaZCoye6hMsZk2psv3gq80PpylA09eYavPocQ1GA7pisxmcU9easyVWeBMSuXzpAA DoV/9HSgIDmcdPrEJQUoQCqEbblrljUVMskZuSiSo6fAwWxEdHmbo8TSltGQ5oZ9PZyO i2zverqSRbVdziQhWP/NUwiY6mJLHrAVULqnIjywWV4gOs2QQrWnkmVdLtrHa+8n2zyQ M7VbjQzd3By3TuHa5de8b+hVtkPKBNpDs0g3AniBaDNAaEYly6wtJsKH4P8n62oimu6p x6ubkvpID4YVK8TtqCmpKTBclgpYA7+bt7eaF74LFCIF3KbBpr1Ci1bfpS80BDc/urBq lj5w== X-Gm-Message-State: AOJu0YxrPrRqdDJ5dNdoX+d3JpW+zPGXir4h4REKsNjnvSdILQeaxe+R lsRZcP+A2V7s1xwgM+zXUuu7WLQfQrCCCNpLOqVjeCsmS4O+PRQKA/netZtQlcI9I6LASjtKPy9 +MMACPP56fA== X-Gm-Gg: ASbGncvSfnOv/4AIHLQI3JSNL99gabBhN8bOXX4uouDqCWuIkTW9GmywNZCWmJZq6/q mw+dmS1Bl8cGSPusgA4AMr3mVq+R0sP6hBjQWKLkN+P+1mgbOvnuhFMZ11dm9lROe7bQY3OxwKP kmSkzvW7w5bASnpA4hvEks9ZIiXola4O8r7+I4XpWfYBxh/oEKeRjmCkhi6FqkxYmYL7WELmEat giYL65Ld1uj+dJCLsXb9XrQtj3QwmUfgoDugQfPLgMX1KLXpNdNmg8Sc7Cbg85ScnC6NMIJfAkU EQoc/G+sbVpKJb49mw1KWX0lnzKdi2l316WuvVlIC6HSQRCxlRRdRuoknBmqehkUA8bzbjTr6IP PI52ksmA89FQIa1x8r7rNyoRwdNcFSzuO3Tkj0mEPBXH8YBCqrl9HQZlBmOy6/o7VIsGoJYBLR0 /PpiBAAffr1mJjdNvu3+eNO+7gpnp+xtnAssVXodn7e9/qq3JJfDoKG1G4EsIV X-Google-Smtp-Source: AGHT+IHtlRX8AOLqO7+N9lyBnTd5D7LDcZquZ/ce/BTw9xDiDYDyTWzC1KjA2pXHQ8msvnqvKXISig== X-Received: by 2002:a05:600c:1c02:b0:477:9caa:1a26 with SMTP id 5b1f17b1804b1-477c01eed7cmr153573625e9.29.1764068128893; Tue, 25 Nov 2025 02:55:28 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Paolo Bonzini , Zhao Liu , Eduardo Habkost Subject: [PATCH-for-11.0 07/12] target/i386: Use little-endian variant of cpu_ld/st_data*() Date: Tue, 25 Nov 2025 11:54:28 +0100 Message-ID: <20251125105434.92355-8-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125105434.92355-1-philmd@linaro.org> References: <20251125105434.92355-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764068177960019200 We only build the X86 targets using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Di386; \ end=3Dle; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/ops_sse.h | 12 +++---- target/i386/tcg/seg_helper.h | 12 +++---- linux-user/vm86.c | 4 +-- target/i386/tcg/mem_helper.c | 8 ++--- target/i386/tcg/mpx_helper.c | 28 ++++++++-------- target/i386/tcg/seg_helper.c | 16 +++++----- target/i386/tcg/system/excp_helper.c | 8 ++--- target/i386/tcg/system/svm_helper.c | 48 ++++++++++++++-------------- 8 files changed, 68 insertions(+), 68 deletions(-) diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h index a2e4d480399..213db53382c 100644 --- a/target/i386/ops_sse.h +++ b/target/i386/ops_sse.h @@ -2326,7 +2326,7 @@ void glue(helper_vpmaskmovd_st, SUFFIX)(CPUX86State *= env, =20 for (i =3D 0; i < (2 << SHIFT); i++) { if (v->L(i) >> 31) { - cpu_stl_data_ra(env, a0 + i * 4, s->L(i), GETPC()); + cpu_stl_le_data_ra(env, a0 + i * 4, s->L(i), GETPC()); } } } @@ -2338,7 +2338,7 @@ void glue(helper_vpmaskmovq_st, SUFFIX)(CPUX86State *= env, =20 for (i =3D 0; i < (1 << SHIFT); i++) { if (v->Q(i) >> 63) { - cpu_stq_data_ra(env, a0 + i * 8, s->Q(i), GETPC()); + cpu_stq_le_data_ra(env, a0 + i * 8, s->Q(i), GETPC()); } } } @@ -2369,7 +2369,7 @@ void glue(helper_vpgatherdd, SUFFIX)(CPUX86State *env, if (v->L(i) >> 31) { target_ulong addr =3D a0 + ((target_ulong)(int32_t)s->L(i) << scale); - d->L(i) =3D cpu_ldl_data_ra(env, addr, GETPC()); + d->L(i) =3D cpu_ldl_le_data_ra(env, addr, GETPC()); } v->L(i) =3D 0; } @@ -2383,7 +2383,7 @@ void glue(helper_vpgatherdq, SUFFIX)(CPUX86State *env, if (v->Q(i) >> 63) { target_ulong addr =3D a0 + ((target_ulong)(int32_t)s->L(i) << scale); - d->Q(i) =3D cpu_ldq_data_ra(env, addr, GETPC()); + d->Q(i) =3D cpu_ldq_le_data_ra(env, addr, GETPC()); } v->Q(i) =3D 0; } @@ -2397,7 +2397,7 @@ void glue(helper_vpgatherqd, SUFFIX)(CPUX86State *env, if (v->L(i) >> 31) { target_ulong addr =3D a0 + ((target_ulong)(int64_t)s->Q(i) << scale); - d->L(i) =3D cpu_ldl_data_ra(env, addr, GETPC()); + d->L(i) =3D cpu_ldl_le_data_ra(env, addr, GETPC()); } v->L(i) =3D 0; } @@ -2415,7 +2415,7 @@ void glue(helper_vpgatherqq, SUFFIX)(CPUX86State *env, if (v->Q(i) >> 63) { target_ulong addr =3D a0 + ((target_ulong)(int64_t)s->Q(i) << scale); - d->Q(i) =3D cpu_ldq_data_ra(env, addr, GETPC()); + d->Q(i) =3D cpu_ldq_le_data_ra(env, addr, GETPC()); } v->Q(i) =3D 0; } diff --git a/target/i386/tcg/seg_helper.h b/target/i386/tcg/seg_helper.h index ea98e1a98ed..20ce47d62d9 100644 --- a/target/i386/tcg/seg_helper.h +++ b/target/i386/tcg/seg_helper.h @@ -40,18 +40,18 @@ int cpu_mmu_index_kernel(CPUX86State *env); * and use *_mmuidx_ra directly. */ #define cpu_lduw_kernel_ra(e, p, r) \ - cpu_lduw_mmuidx_ra(e, p, cpu_mmu_index_kernel(e), r) + cpu_lduw_le_mmuidx_ra(e, p, cpu_mmu_index_kernel(e), r) #define cpu_ldl_kernel_ra(e, p, r) \ - cpu_ldl_mmuidx_ra(e, p, cpu_mmu_index_kernel(e), r) + cpu_ldl_le_mmuidx_ra(e, p, cpu_mmu_index_kernel(e), r) #define cpu_ldq_kernel_ra(e, p, r) \ - cpu_ldq_mmuidx_ra(e, p, cpu_mmu_index_kernel(e), r) + cpu_ldq_le_mmuidx_ra(e, p, cpu_mmu_index_kernel(e), r) =20 #define cpu_stw_kernel_ra(e, p, v, r) \ - cpu_stw_mmuidx_ra(e, p, v, cpu_mmu_index_kernel(e), r) + cpu_stw_le_mmuidx_ra(e, p, v, cpu_mmu_index_kernel(e), r) #define cpu_stl_kernel_ra(e, p, v, r) \ - cpu_stl_mmuidx_ra(e, p, v, cpu_mmu_index_kernel(e), r) + cpu_stl_le_mmuidx_ra(e, p, v, cpu_mmu_index_kernel(e), r) #define cpu_stq_kernel_ra(e, p, v, r) \ - cpu_stq_mmuidx_ra(e, p, v, cpu_mmu_index_kernel(e), r) + cpu_stq_le_mmuidx_ra(e, p, v, cpu_mmu_index_kernel(e), r) =20 #define cpu_lduw_kernel(e, p) cpu_lduw_kernel_ra(e, p, 0) #define cpu_ldl_kernel(e, p) cpu_ldl_kernel_ra(e, p, 0) diff --git a/linux-user/vm86.c b/linux-user/vm86.c index 5091d53fb84..4e120875a06 100644 --- a/linux-user/vm86.c +++ b/linux-user/vm86.c @@ -44,7 +44,7 @@ static inline int is_revectored(int nr, struct target_rev= ectored_struct *bitmap) static inline void vm_putw(CPUX86State *env, uint32_t segptr, unsigned int reg16, unsigned int val) { - cpu_stw_data(env, segptr + (reg16 & 0xffff), val); + cpu_stw_le_data(env, segptr + (reg16 & 0xffff), val); } =20 void save_v86_state(CPUX86State *env) @@ -157,7 +157,7 @@ static void do_int(CPUX86State *env, int intno) &ts->vm86plus.int21_revectored)) goto cannot_handle; int_addr =3D (intno << 2); - segoffs =3D cpu_ldl_data(env, int_addr); + segoffs =3D cpu_ldl_le_data(env, int_addr); if ((segoffs >> 16) =3D=3D TARGET_BIOSSEG) goto cannot_handle; LOG_VM86("VM86: emulating int 0x%x. CS:IP=3D%04x:%04x\n", diff --git a/target/i386/tcg/mem_helper.c b/target/i386/tcg/mem_helper.c index 9e7c2d80293..c15a32d60ad 100644 --- a/target/i386/tcg/mem_helper.c +++ b/target/i386/tcg/mem_helper.c @@ -30,8 +30,8 @@ void helper_boundw(CPUX86State *env, target_ulong a0, int= v) { int low, high; =20 - low =3D cpu_ldsw_data_ra(env, a0, GETPC()); - high =3D cpu_ldsw_data_ra(env, a0 + 2, GETPC()); + low =3D cpu_ldsw_le_data_ra(env, a0, GETPC()); + high =3D cpu_ldsw_le_data_ra(env, a0 + 2, GETPC()); v =3D (int16_t)v; if (v < low || v > high) { if (env->hflags & HF_MPX_EN_MASK) { @@ -45,8 +45,8 @@ void helper_boundl(CPUX86State *env, target_ulong a0, int= v) { int low, high; =20 - low =3D cpu_ldl_data_ra(env, a0, GETPC()); - high =3D cpu_ldl_data_ra(env, a0 + 4, GETPC()); + low =3D cpu_ldl_le_data_ra(env, a0, GETPC()); + high =3D cpu_ldl_le_data_ra(env, a0 + 4, GETPC()); if (v < low || v > high) { if (env->hflags & HF_MPX_EN_MASK) { env->bndcs_regs.sts =3D 0; diff --git a/target/i386/tcg/mpx_helper.c b/target/i386/tcg/mpx_helper.c index fa8abcc4820..73d33bf5e4a 100644 --- a/target/i386/tcg/mpx_helper.c +++ b/target/i386/tcg/mpx_helper.c @@ -44,7 +44,7 @@ static uint64_t lookup_bte64(CPUX86State *env, uint64_t b= ase, uintptr_t ra) } =20 bde =3D (extract64(base, 20, 28) << 3) + (extract64(bndcsr, 20, 44) <<= 12); - bt =3D cpu_ldq_data_ra(env, bde, ra); + bt =3D cpu_ldq_le_data_ra(env, bde, ra); if ((bt & 1) =3D=3D 0) { env->bndcs_regs.sts =3D bde | 2; raise_exception_ra(env, EXCP05_BOUND, ra); @@ -64,7 +64,7 @@ static uint32_t lookup_bte32(CPUX86State *env, uint32_t b= ase, uintptr_t ra) } =20 bde =3D (extract32(base, 12, 20) << 2) + (bndcsr & TARGET_PAGE_MASK); - bt =3D cpu_ldl_data_ra(env, bde, ra); + bt =3D cpu_ldl_le_data_ra(env, bde, ra); if ((bt & 1) =3D=3D 0) { env->bndcs_regs.sts =3D bde | 2; raise_exception_ra(env, EXCP05_BOUND, ra); @@ -79,9 +79,9 @@ uint64_t helper_bndldx64(CPUX86State *env, target_ulong b= ase, target_ulong ptr) uint64_t bte, lb, ub, pt; =20 bte =3D lookup_bte64(env, base, ra); - lb =3D cpu_ldq_data_ra(env, bte, ra); - ub =3D cpu_ldq_data_ra(env, bte + 8, ra); - pt =3D cpu_ldq_data_ra(env, bte + 16, ra); + lb =3D cpu_ldq_le_data_ra(env, bte, ra); + ub =3D cpu_ldq_le_data_ra(env, bte + 8, ra); + pt =3D cpu_ldq_le_data_ra(env, bte + 16, ra); =20 if (pt !=3D ptr) { lb =3D ub =3D 0; @@ -96,9 +96,9 @@ uint64_t helper_bndldx32(CPUX86State *env, target_ulong b= ase, target_ulong ptr) uint32_t bte, lb, ub, pt; =20 bte =3D lookup_bte32(env, base, ra); - lb =3D cpu_ldl_data_ra(env, bte, ra); - ub =3D cpu_ldl_data_ra(env, bte + 4, ra); - pt =3D cpu_ldl_data_ra(env, bte + 8, ra); + lb =3D cpu_ldl_le_data_ra(env, bte, ra); + ub =3D cpu_ldl_le_data_ra(env, bte + 4, ra); + pt =3D cpu_ldl_le_data_ra(env, bte + 8, ra); =20 if (pt !=3D ptr) { lb =3D ub =3D 0; @@ -113,9 +113,9 @@ void helper_bndstx64(CPUX86State *env, target_ulong bas= e, target_ulong ptr, uint64_t bte; =20 bte =3D lookup_bte64(env, base, ra); - cpu_stq_data_ra(env, bte, lb, ra); - cpu_stq_data_ra(env, bte + 8, ub, ra); - cpu_stq_data_ra(env, bte + 16, ptr, ra); + cpu_stq_le_data_ra(env, bte, lb, ra); + cpu_stq_le_data_ra(env, bte + 8, ub, ra); + cpu_stq_le_data_ra(env, bte + 16, ptr, ra); } =20 void helper_bndstx32(CPUX86State *env, target_ulong base, target_ulong ptr, @@ -125,9 +125,9 @@ void helper_bndstx32(CPUX86State *env, target_ulong bas= e, target_ulong ptr, uint32_t bte; =20 bte =3D lookup_bte32(env, base, ra); - cpu_stl_data_ra(env, bte, lb, ra); - cpu_stl_data_ra(env, bte + 4, ub, ra); - cpu_stl_data_ra(env, bte + 8, ptr, ra); + cpu_stl_le_data_ra(env, bte, lb, ra); + cpu_stl_le_data_ra(env, bte + 4, ub, ra); + cpu_stl_le_data_ra(env, bte + 8, ptr, ra); } =20 void helper_bnd_jmp(CPUX86State *env) diff --git a/target/i386/tcg/seg_helper.c b/target/i386/tcg/seg_helper.c index 227336c4ef2..58aac720119 100644 --- a/target/i386/tcg/seg_helper.c +++ b/target/i386/tcg/seg_helper.c @@ -65,20 +65,20 @@ typedef struct StackAccess static void pushw(StackAccess *sa, uint16_t val) { sa->sp -=3D 2; - cpu_stw_mmuidx_ra(sa->env, sa->ss_base + (sa->sp & sa->sp_mask), + cpu_stw_le_mmuidx_ra(sa->env, sa->ss_base + (sa->sp & sa->sp_mask), val, sa->mmu_index, sa->ra); } =20 static void pushl(StackAccess *sa, uint32_t val) { sa->sp -=3D 4; - cpu_stl_mmuidx_ra(sa->env, sa->ss_base + (sa->sp & sa->sp_mask), + cpu_stl_le_mmuidx_ra(sa->env, sa->ss_base + (sa->sp & sa->sp_mask), val, sa->mmu_index, sa->ra); } =20 static uint16_t popw(StackAccess *sa) { - uint16_t ret =3D cpu_lduw_mmuidx_ra(sa->env, + uint16_t ret =3D cpu_lduw_le_mmuidx_ra(sa->env, sa->ss_base + (sa->sp & sa->sp_mask), sa->mmu_index, sa->ra); sa->sp +=3D 2; @@ -87,7 +87,7 @@ static uint16_t popw(StackAccess *sa) =20 static uint32_t popl(StackAccess *sa) { - uint32_t ret =3D cpu_ldl_mmuidx_ra(sa->env, + uint32_t ret =3D cpu_ldl_le_mmuidx_ra(sa->env, sa->ss_base + (sa->sp & sa->sp_mask), sa->mmu_index, sa->ra); sa->sp +=3D 4; @@ -905,12 +905,12 @@ static void do_interrupt_protected(CPUX86State *env, = int intno, int is_int, static void pushq(StackAccess *sa, uint64_t val) { sa->sp -=3D 8; - cpu_stq_mmuidx_ra(sa->env, sa->sp, val, sa->mmu_index, sa->ra); + cpu_stq_le_mmuidx_ra(sa->env, sa->sp, val, sa->mmu_index, sa->ra); } =20 static uint64_t popq(StackAccess *sa) { - uint64_t ret =3D cpu_ldq_mmuidx_ra(sa->env, sa->sp, sa->mmu_index, sa-= >ra); + uint64_t ret =3D cpu_ldq_le_mmuidx_ra(sa->env, sa->sp, sa->mmu_index, = sa->ra); sa->sp +=3D 8; return ret; } @@ -1887,7 +1887,7 @@ void helper_lcall_protected(CPUX86State *env, int new= _cs, target_ulong new_eip, pushl(&sa, env->segs[R_SS].selector); pushl(&sa, env->regs[R_ESP]); for (i =3D param_count - 1; i >=3D 0; i--) { - val =3D cpu_ldl_data_ra(env, + val =3D cpu_ldl_le_data_ra(env, old_ssp + ((env->regs[R_ESP] + i= * 4) & old_sp_mask), GETPC()); pushl(&sa, val); @@ -1896,7 +1896,7 @@ void helper_lcall_protected(CPUX86State *env, int new= _cs, target_ulong new_eip, pushw(&sa, env->segs[R_SS].selector); pushw(&sa, env->regs[R_ESP]); for (i =3D param_count - 1; i >=3D 0; i--) { - val =3D cpu_lduw_data_ra(env, + val =3D cpu_lduw_le_data_ra(env, old_ssp + ((env->regs[R_ESP] + = i * 2) & old_sp_mask), GETPC()); pushw(&sa, val); diff --git a/target/i386/tcg/system/excp_helper.c b/target/i386/tcg/system/= excp_helper.c index f622b5d588e..d7ea77c8558 100644 --- a/target/i386/tcg/system/excp_helper.c +++ b/target/i386/tcg/system/excp_helper.c @@ -90,7 +90,7 @@ static inline uint32_t ptw_ldl(const PTETranslate *in, ui= nt64_t ra) if (likely(in->haddr)) { return ldl_p(in->haddr); } - return cpu_ldl_mmuidx_ra(in->env, in->gaddr, in->ptw_idx, ra); + return cpu_ldl_le_mmuidx_ra(in->env, in->gaddr, in->ptw_idx, ra); } =20 static inline uint64_t ptw_ldq(const PTETranslate *in, uint64_t ra) @@ -98,7 +98,7 @@ static inline uint64_t ptw_ldq(const PTETranslate *in, ui= nt64_t ra) if (likely(in->haddr)) { return ldq_p(in->haddr); } - return cpu_ldq_mmuidx_ra(in->env, in->gaddr, in->ptw_idx, ra); + return cpu_ldq_le_mmuidx_ra(in->env, in->gaddr, in->ptw_idx, ra); } =20 /* @@ -116,9 +116,9 @@ static bool ptw_setl_slow(const PTETranslate *in, uint3= 2_t old, uint32_t new) cpu_exec_end(cpu); /* Does x86 really perform a rmw cycle on mmio for ptw? */ start_exclusive(); - cmp =3D cpu_ldl_mmuidx_ra(in->env, in->gaddr, in->ptw_idx, 0); + cmp =3D cpu_ldl_le_mmuidx_ra(in->env, in->gaddr, in->ptw_idx, 0); if (cmp =3D=3D old) { - cpu_stl_mmuidx_ra(in->env, in->gaddr, new, in->ptw_idx, 0); + cpu_stl_le_mmuidx_ra(in->env, in->gaddr, new, in->ptw_idx, 0); } end_exclusive(); cpu_exec_start(cpu); diff --git a/target/i386/tcg/system/svm_helper.c b/target/i386/tcg/system/s= vm_helper.c index 4b86796518f..3f97a639aeb 100644 --- a/target/i386/tcg/system/svm_helper.c +++ b/target/i386/tcg/system/svm_helper.c @@ -30,13 +30,13 @@ static void svm_save_seg(CPUX86State *env, int mmu_idx, hwaddr addr, const SegmentCache *sc) { - cpu_stw_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, selector), + cpu_stw_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, selector), sc->selector, mmu_idx, 0); - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, base), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, base), sc->base, mmu_idx, 0); - cpu_stl_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, limit), + cpu_stl_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, limit), sc->limit, mmu_idx, 0); - cpu_stw_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, attrib), + cpu_stw_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, attrib), ((sc->flags >> 8) & 0xff) | ((sc->flags >> 12) & 0x0f00), mmu_idx, 0); @@ -58,16 +58,16 @@ static void svm_load_seg(CPUX86State *env, int mmu_idx,= hwaddr addr, unsigned int flags; =20 sc->selector =3D - cpu_lduw_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, selector), + cpu_lduw_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, select= or), mmu_idx, 0); sc->base =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, base), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, base), mmu_idx, 0); sc->limit =3D - cpu_ldl_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, limit), + cpu_ldl_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, limit), mmu_idx, 0); flags =3D - cpu_lduw_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, attrib), + cpu_lduw_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, attrib= ), mmu_idx, 0); sc->flags =3D ((flags & 0xff) << 8) | ((flags & 0x0f00) << 12); =20 @@ -507,31 +507,31 @@ void helper_vmload(CPUX86State *env, int aflag) =20 #ifdef TARGET_X86_64 env->kernelgsbase =3D - cpu_ldq_mmuidx_ra(env, + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.kernel_gs_base= ), mmu_idx, 0); env->lstar =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.lstar), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.lstar), mmu_idx, 0); env->cstar =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.cstar), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.cstar), mmu_idx, 0); env->fmask =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sfmask), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sfmask= ), mmu_idx, 0); svm_canonicalization(env, &env->kernelgsbase); #endif env->star =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.star), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.star), mmu_idx, 0); env->sysenter_cs =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_= cs), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysent= er_cs), mmu_idx, 0); env->sysenter_esp =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_= esp), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysent= er_esp), mmu_idx, 0); env->sysenter_eip =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_= eip), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysent= er_eip), mmu_idx, 0); } =20 @@ -567,22 +567,22 @@ void helper_vmsave(CPUX86State *env, int aflag) &env->ldt); =20 #ifdef TARGET_X86_64 - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.kernel_gs_bas= e), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.kernel_gs_= base), env->kernelgsbase, mmu_idx, 0); - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.lstar), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.lstar), env->lstar, mmu_idx, 0); - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.cstar), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.cstar), env->cstar, mmu_idx, 0); - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sfmask), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sfmask), env->fmask, mmu_idx, 0); #endif - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.star), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.star), env->star, mmu_idx, 0); - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_cs), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_c= s), env->sysenter_cs, mmu_idx, 0); - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_esp), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_e= sp), env->sysenter_esp, mmu_idx, 0); - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_eip), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_e= ip), env->sysenter_eip, mmu_idx, 0); } =20 --=20 2.51.0 From nobody Mon Feb 9 07:57:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764068214; cv=none; d=zohomail.com; s=zohoarc; b=bVOLUpokTXBf4hyvDbxXxEPSVnIkhMzBq85KyA7SQQoFB+rJ7MJ1JLK2jel2CLiLgkNmEP8Hla2o2wcFrXSXGfTB4EWGIENKlCZWqDOOI1+D/9/DhOX3/N9cHWEX/i3tgn00ZoqwfJxTRNnZr1r5Ps8r+Jw3e3BPzIyVTUfxI3E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764068214; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=idPfVbwdmuwP3E4rOS4isKmneb6eqTi31QSmeF+nOd0=; b=iFGT6X6hNfOIEx6FVMBgEKyXMa16H4LUp2U96tCLcuUAYK5mQOFK7+FMtC/1jauPPXh1wK9Z9tsSGqLD6qW7ipBC7ACyUGc1mgNGHwc0nbWz3QmrMyyP/5uCIDfTRcfIr+FvFYBC7ovC/tRcUIb4b/xfYav9d6ToYyKKXUNmvQ8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764068214972321.01860451972846; Tue, 25 Nov 2025 02:56:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNqiG-0004fW-Dz; Tue, 25 Nov 2025 05:56:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNqhz-0004ST-IM for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:48 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vNqhv-0001lY-4O for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:42 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-47774d3536dso41496715e9.0 for ; Tue, 25 Nov 2025 02:55:38 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f2e5b6sm33267759f8f.1.2025.11.25.02.55.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 02:55:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764068136; x=1764672936; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=idPfVbwdmuwP3E4rOS4isKmneb6eqTi31QSmeF+nOd0=; b=liIaP2nQtgUVbfTvfqHMDQMA3Y7/Ck5aNulP3dWUmoFYY7SmDVkqc2Oi7xbb3g7TQo Pr1GTllfp8Me60rJpsT6VNk0XY+bmzRVKinJEUH5tTH1NuS9tRwIKlfIE9XRt10P5t2Y G/GMTvOujwOhTxaBvK1cfH2ao2Jxsz+PM9rU/66AA+WKY6wnkoDEjMFQgY7CwwOSER1G YyhajHCUm8ekKJlQRPIBdPCUy4ZFbrfnszdGoVui1H4jsztT1Z380nNm95vPjzPgUruv 1tP4hWDsLtzlTEkJIwaAcdTuO+zQkgbr9ZRozHY3hjEIALX3QnGWZsP3uq5RPbo0AMnG 6pIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764068136; x=1764672936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=idPfVbwdmuwP3E4rOS4isKmneb6eqTi31QSmeF+nOd0=; b=SERxfGOWlBTt5wTiDbXY5cEqwZb96gqxuWCaVFVI5VtCklLPfeQ14iHGQDfo7YgoLS O2dUsVMRE68ir46PgXqiyyPCd2/P1YMabOT1t1p5jo2jItu3M3QA5vsHSeLEiwfPicoN 5tY2aNU20aOWJ8rfzoCyKL5liFGx2j48WKvV6ZpyryytSBFgRiigQWM5gR/uIN6s7Vpj KCK21W8K+aWAv/0o8Gv9E0VEDzkAiLCdd3lr4PR1B7j1SPudUCBVWPlfzTvC3zRaJePF RhP1vqEZXqNKxSJvU6mXh94Y9M8wHqUr6Qa4dGPUPl9K1vsxsAmL4bqHfHeMt/WUzy2Z fTfw== X-Gm-Message-State: AOJu0YxUE3TMRh3lgAZfhbS/zSVCi8BVT+yt0JrMF0vIErVp4V1WTGRw 5NOkQWkrTUBh82cEEWZ8gprCdWIxyYH9Z0FulrNHriLsVJdN2UtuaPIK2hVnANfC1ETv3HfMtwX 5CoBmPIdi4g== X-Gm-Gg: ASbGncvNuN9R9wkhO0LXO05tfutg5dRPSh55+Y769PCoxTvlswyR8V1QAqmtgEq9nRm brXnigRk1f2ip5LG/mqyLVzJ0T7++jcqdmAXfkjoGaeuetjBx2NZwskay9Y5vS5QGDUTMVWcnCA R+SrOMcbWoc0ajji4NSrkGz7Q76oaM4UMKmvFKzio7s5C8rqA9hvydIjp8UOjNMN540X/IeyyJW RM+vdd3DZV1VgH/Qw3CTZs1mZyn8aU7oVBAmY5xCV+OV1XRP5dw3Woc96X7K8hUYFtjhnyn68kd pmlBLNVB2W+1++NKkO8M++Ps736ari9KYKgiA1D00pUij8XiEke5n5COfUPAYDcjCh30yL/ANyT qtY4ZCmjUND6qFfGkRauvPH4tsbzyNTIxxTm4VT3EnacDeWTTGDbhhxaNxxdXnhKLZrAdkANLYz 9736zLJ43HM/lUj/D+0PlPYrJ3NIIJ75ON6+mllvb4dKL+cy1lmZ/e5xvGqvjB X-Google-Smtp-Source: AGHT+IHqFvVaV1NpPrrFgJAwG9qoxoIIsgYpq5DCkzwkvMmtxEBHOyDGzJI1lnHrjyrkPXEiPeQ7FA== X-Received: by 2002:a05:600c:4685:b0:475:ddad:c3a9 with SMTP id 5b1f17b1804b1-477c052f04bmr158778295e9.13.1764068136086; Tue, 25 Nov 2025 02:55:36 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Helge Deller Subject: [PATCH-for-11.0 08/12] target/hppa: Use little-endian variant of cpu_ld/st_data*() Date: Tue, 25 Nov 2025 11:54:29 +0100 Message-ID: <20251125105434.92355-9-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125105434.92355-1-philmd@linaro.org> References: <20251125105434.92355-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764068216391019200 We only build the HPPA target using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Dhppa; \ end=3Dbe; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/hppa/op_helper.c | 44 ++++++++++++++++++++--------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c index 0458378abb2..65faf03cd0a 100644 --- a/target/hppa/op_helper.c +++ b/target/hppa/op_helper.c @@ -107,7 +107,7 @@ static void do_stby_b(CPUHPPAState *env, target_ulong a= ddr, target_ulong val, cpu_stb_data_ra(env, addr, val, ra); break; case 2: - cpu_stw_data_ra(env, addr, val, ra); + cpu_stw_be_data_ra(env, addr, val, ra); break; case 1: /* The 3 byte store must appear atomic. */ @@ -115,11 +115,11 @@ static void do_stby_b(CPUHPPAState *env, target_ulong= addr, target_ulong val, atomic_store_mask32(env, addr, val, 0x00ffffffu, ra); } else { cpu_stb_data_ra(env, addr, val >> 16, ra); - cpu_stw_data_ra(env, addr + 1, val, ra); + cpu_stw_be_data_ra(env, addr + 1, val, ra); } break; default: - cpu_stl_data_ra(env, addr, val, ra); + cpu_stl_be_data_ra(env, addr, val, ra); break; } } @@ -132,7 +132,7 @@ static void do_stdby_b(CPUHPPAState *env, target_ulong = addr, uint64_t val, cpu_stb_data_ra(env, addr, val, ra); break; case 6: - cpu_stw_data_ra(env, addr, val, ra); + cpu_stw_be_data_ra(env, addr, val, ra); break; case 5: /* The 3 byte store must appear atomic. */ @@ -140,11 +140,11 @@ static void do_stdby_b(CPUHPPAState *env, target_ulon= g addr, uint64_t val, atomic_store_mask32(env, addr, val, 0x00ffffffu, ra); } else { cpu_stb_data_ra(env, addr, val >> 16, ra); - cpu_stw_data_ra(env, addr + 1, val, ra); + cpu_stw_be_data_ra(env, addr + 1, val, ra); } break; case 4: - cpu_stl_data_ra(env, addr, val, ra); + cpu_stl_be_data_ra(env, addr, val, ra); break; case 3: /* The 5 byte store must appear atomic. */ @@ -152,7 +152,7 @@ static void do_stdby_b(CPUHPPAState *env, target_ulong = addr, uint64_t val, atomic_store_mask64(env, addr, val, 0x000000ffffffffffull, 5, = ra); } else { cpu_stb_data_ra(env, addr, val >> 32, ra); - cpu_stl_data_ra(env, addr + 1, val, ra); + cpu_stl_be_data_ra(env, addr + 1, val, ra); } break; case 2: @@ -160,8 +160,8 @@ static void do_stdby_b(CPUHPPAState *env, target_ulong = addr, uint64_t val, if (parallel) { atomic_store_mask64(env, addr, val, 0x0000ffffffffffffull, 6, = ra); } else { - cpu_stw_data_ra(env, addr, val >> 32, ra); - cpu_stl_data_ra(env, addr + 2, val, ra); + cpu_stw_be_data_ra(env, addr, val >> 32, ra); + cpu_stl_be_data_ra(env, addr + 2, val, ra); } break; case 1: @@ -170,12 +170,12 @@ static void do_stdby_b(CPUHPPAState *env, target_ulon= g addr, uint64_t val, atomic_store_mask64(env, addr, val, 0x00ffffffffffffffull, 7, = ra); } else { cpu_stb_data_ra(env, addr, val >> 48, ra); - cpu_stw_data_ra(env, addr + 1, val >> 32, ra); - cpu_stl_data_ra(env, addr + 3, val, ra); + cpu_stw_be_data_ra(env, addr + 1, val >> 32, ra); + cpu_stl_be_data_ra(env, addr + 3, val, ra); } break; default: - cpu_stq_data_ra(env, addr, val, ra); + cpu_stq_be_data_ra(env, addr, val, ra); break; } } @@ -211,12 +211,12 @@ static void do_stby_e(CPUHPPAState *env, target_ulong= addr, target_ulong val, if (parallel) { atomic_store_mask32(env, addr - 3, val, 0xffffff00u, ra); } else { - cpu_stw_data_ra(env, addr - 3, val >> 16, ra); + cpu_stw_be_data_ra(env, addr - 3, val >> 16, ra); cpu_stb_data_ra(env, addr - 1, val >> 8, ra); } break; case 2: - cpu_stw_data_ra(env, addr - 2, val >> 16, ra); + cpu_stw_be_data_ra(env, addr - 2, val >> 16, ra); break; case 1: cpu_stb_data_ra(env, addr - 1, val >> 24, ra); @@ -239,8 +239,8 @@ static void do_stdby_e(CPUHPPAState *env, target_ulong = addr, uint64_t val, atomic_store_mask64(env, addr - 7, val, 0xffffffffffffff00ull, 7, ra); } else { - cpu_stl_data_ra(env, addr - 7, val >> 32, ra); - cpu_stw_data_ra(env, addr - 3, val >> 16, ra); + cpu_stl_be_data_ra(env, addr - 7, val >> 32, ra); + cpu_stw_be_data_ra(env, addr - 3, val >> 16, ra); cpu_stb_data_ra(env, addr - 1, val >> 8, ra); } break; @@ -250,8 +250,8 @@ static void do_stdby_e(CPUHPPAState *env, target_ulong = addr, uint64_t val, atomic_store_mask64(env, addr - 6, val, 0xffffffffffff0000ull, 6, ra); } else { - cpu_stl_data_ra(env, addr - 6, val >> 32, ra); - cpu_stw_data_ra(env, addr - 2, val >> 16, ra); + cpu_stl_be_data_ra(env, addr - 6, val >> 32, ra); + cpu_stw_be_data_ra(env, addr - 2, val >> 16, ra); } break; case 5: @@ -260,24 +260,24 @@ static void do_stdby_e(CPUHPPAState *env, target_ulon= g addr, uint64_t val, atomic_store_mask64(env, addr - 5, val, 0xffffffffff000000ull, 5, ra); } else { - cpu_stl_data_ra(env, addr - 5, val >> 32, ra); + cpu_stl_be_data_ra(env, addr - 5, val >> 32, ra); cpu_stb_data_ra(env, addr - 1, val >> 24, ra); } break; case 4: - cpu_stl_data_ra(env, addr - 4, val >> 32, ra); + cpu_stl_be_data_ra(env, addr - 4, val >> 32, ra); break; case 3: /* The 3 byte store must appear atomic. */ if (parallel) { atomic_store_mask32(env, addr - 3, val >> 32, 0xffffff00u, ra); } else { - cpu_stw_data_ra(env, addr - 3, val >> 48, ra); + cpu_stw_be_data_ra(env, addr - 3, val >> 48, ra); cpu_stb_data_ra(env, addr - 1, val >> 40, ra); } break; case 2: - cpu_stw_data_ra(env, addr - 2, val >> 48, ra); + cpu_stw_be_data_ra(env, addr - 2, val >> 48, ra); break; case 1: cpu_stb_data_ra(env, addr - 1, val >> 56, ra); --=20 2.51.0 From nobody Mon Feb 9 07:57:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764068262; cv=none; d=zohomail.com; s=zohoarc; b=emdwI1WF67v90OvRfA7qSkiHhTRdAdXu3KIFmwvzIXRyYj+sMS92YEHX2ueVUCZW4GOCWMMxc5E2OY+f0tfMOB2+GKKEp945Di2uDVmJPHgKTilydh4fc7PXGRJ65lENIscxcy9XiXTVzJvm2OLFyEmAzH08RjSWTGEfi1zheDs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764068262; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1/moKxyhhhNUAAssiCB4z5/4yHLvVf9L6ospDexZsZ8=; b=J+yFqkhOY5MJIluzbXSWnJK/TJzKOpm7Ix2/0ZXYndHhHJdwVCm+wcP09SVoTuHKg2q084RbWz9c4xyzFsXtY8Etmaib1IGRTCnU/iHkZ7kpI3k1TnATObo7Mn9HBZGzwkHza29dm59MQaRaE+I2zb1EEYBsDLLRSnD0aUI9t+E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764068262428341.94414822391036; Tue, 25 Nov 2025 02:57:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNqiI-0004rc-U8; Tue, 25 Nov 2025 05:56:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNqi8-0004XI-60 for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:53 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vNqi4-0001nO-21 for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:51 -0500 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-42b2dc17965so5061955f8f.3 for ; Tue, 25 Nov 2025 02:55:45 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cc231dc6esm24754351f8f.7.2025.11.25.02.55.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 02:55:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764068143; x=1764672943; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1/moKxyhhhNUAAssiCB4z5/4yHLvVf9L6ospDexZsZ8=; b=yOlt9LaYNYjuk6yA/JJ6P4+iYfNT+9NlDEBRdTs2kQAKSia4j+rM7kLZG3CJm2nvGS w4key30D/JlP/+8ojziaLxU0oxRTMSffekjlxZKMBTp4r0jfHnf+ZIy79ZOwabm7YdXp ijnGtGijz4jL9sXCS4exwsNZsjrfshh/aBzj2HFQbCSv/FEnE+tvs4wFh5L6hAcAsO8/ N8dLhKIEt9WkpNnq3IekpsNBXLHo8aUSuLf9Ww7jrG40sO1O7dV3bEOkwICTdD7ERbFq 2iP9rFbvprUTXPl8f1nbCvpzdf4HI5s5k3obyXYnW+yOVb7A6SU2ZvpxRw9p/I9g+b7c 5L6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764068143; x=1764672943; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1/moKxyhhhNUAAssiCB4z5/4yHLvVf9L6ospDexZsZ8=; b=KpKW9yKzSfzXsikAhAEPSWTgQZIxShw4CUFbV5J/j6LCxyNDU73ZJwQKs/ieV3GhdV oLqRmqBEZjb/PfUNYO6xes3qkhN1IAnd0wDpHQur7Kv6EQ4SIhSXOR/XUx7OZyYJ5nKQ SrXX9aKb7FOKm531i0KYSvDtlBQB0ty9EZWWTjsH3a3TmUpWP0EbhB6t+lXZ9aV+1GP0 8vqSZcswsyupIbnTWcoThDbI/IjTkZxeqKJdfwp1Tzjdr9ioMVQDLLd6R2lBIGDuNHep 8kZ5ysECBOo/YHizG23oP63gA9/sJb2pWshYVKHm/Iy9JdV0iBjSC239lZik8p08eD0Q GXTg== X-Gm-Message-State: AOJu0Yy/qCZOdn4hMN+DAJL+xzeuFfFmViY++MKUjgfOZYUmO4yZlgl6 TzLMcZaSLNKvq5ETF6tiStpZUhCWp/WJ76HHBccpw5qRHTAETlFVRnSGcCP5+0OLkm18AAmdEtF JzwIr5fNiAQ== X-Gm-Gg: ASbGncuT0OX7gTn+VHY4c/qOSwc+pwaJqTXJ/Mcckt0GULiROotqTkRJ2FAC1e6lXT8 Ug7h+mOSY8tshiJ97DSdpcB2bovPdGrE7PnyqQKPdG62GbYUMv6H94FU05YLoFTepIsrSn7XAUw bJWhzlimrl8o2pzJecxJP/UkgWlQLWDivEpEYcgNNRLPVP42I5eXSSR+HsFCMyWBTFMC+JKmgGG hz6q3L70jdjh+KYE23XgKvyW3cuH4zByT/+OosnFAvWhmV/ZS5JAeFQqUrEWOoyoagOwnhvB92u zzh+xvDcs8hDWx218ef8l79Qk5OU+B+P1C6sDVJUDcrDQOhbQC8cXoDPZ2VjSOTS37OlhSqXGvH EGjqM1yfb2MwJ+I4xt3n7VHlrAj343t5GG93lUoSOijVFRu2IUUh0YbkVsacRLnB4wBfrOxeDJp LL7S0ps6lHkMEETux2kUsREdgttbHV0JfClgILAFYM2hk2F8pbso8IGr/tONTn X-Google-Smtp-Source: AGHT+IHyvsxgcQUNPg/NfqXzo+L4q8Axosz32sAX+4NDQUAgn/EY3SkUaSnhck7OcRoCLKievYQ1+w== X-Received: by 2002:a05:6000:4022:b0:42b:3746:3b85 with SMTP id ffacd0b85a97d-42cc1d198c0mr15200852f8f.45.1764068143512; Tue, 25 Nov 2025 02:55:43 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei Subject: [PATCH-for-11.0 09/12] target/riscv: Use little-endian variant of cpu_ld/st_data*() for vector Date: Tue, 25 Nov 2025 11:54:30 +0100 Message-ID: <20251125105434.92355-10-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125105434.92355-1-philmd@linaro.org> References: <20251125105434.92355-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764068264765019200 RISC-V vector "elements are simply packed in order from the least-signicant to most-signicant bits of the vector register" [*] which is little endianness, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. [*] RISC-V "V" Vector Extension v1.0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/riscv/vector_helper.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 2de3358ee86..caa8dd9c125 100644 --- a/target/riscv/vector_helper.c +++ b/target/riscv/vector_helper.c @@ -193,9 +193,9 @@ void NAME##_host(void *vd, uint32_t idx, void *host) = \ } =20 GEN_VEXT_LD_ELEM(lde_b, uint8_t, H1, ldub) -GEN_VEXT_LD_ELEM(lde_h, uint16_t, H2, lduw) -GEN_VEXT_LD_ELEM(lde_w, uint32_t, H4, ldl) -GEN_VEXT_LD_ELEM(lde_d, uint64_t, H8, ldq) +GEN_VEXT_LD_ELEM(lde_h, uint16_t, H2, lduw_le) +GEN_VEXT_LD_ELEM(lde_w, uint32_t, H4, ldl_le) +GEN_VEXT_LD_ELEM(lde_d, uint64_t, H8, ldq_le) =20 #define GEN_VEXT_ST_ELEM(NAME, ETYPE, H, STSUF) \ static inline QEMU_ALWAYS_INLINE \ @@ -214,9 +214,9 @@ void NAME##_host(void *vd, uint32_t idx, void *host) = \ } =20 GEN_VEXT_ST_ELEM(ste_b, uint8_t, H1, stb) -GEN_VEXT_ST_ELEM(ste_h, uint16_t, H2, stw) -GEN_VEXT_ST_ELEM(ste_w, uint32_t, H4, stl) -GEN_VEXT_ST_ELEM(ste_d, uint64_t, H8, stq) +GEN_VEXT_ST_ELEM(ste_h, uint16_t, H2, stw_le) +GEN_VEXT_ST_ELEM(ste_w, uint32_t, H4, stl_le) +GEN_VEXT_ST_ELEM(ste_d, uint64_t, H8, stq_le) =20 static inline QEMU_ALWAYS_INLINE void vext_continuous_ldst_tlb(CPURISCVState *env, vext_ldst_elem_fn_tlb *ldst_t= lb, --=20 2.51.0 From nobody Mon Feb 9 07:57:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764068265; cv=none; d=zohomail.com; s=zohoarc; b=X23e2MeXZJ4XG7hI0mV6eDGg8SQjzNUsRie0NctoaT++vTA4ZhGARA2bQau+ha0CHXxUHlazfvH3akT/VuplmZ69uMqguZ6AhbuNWGfWSMoagQJ0sqXE0NyX0YlEQrX1o7ZVbGnLCNrEhPFMOGMnbNtvrfGFZy77XRNwPZ/XZ4E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764068265; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yQ3G/f5z9MwEGa9QMBSOfQ0OhqIrmAfETxxhBlriST8=; b=C+30VRQ8w0Wve7hl+8StC/MnA6JV1hFqDK0wx5TZ5N4M8aodeCaCpeGblDUZ7wfMRe7cUlSRhJD/cI49nKfHTjvNmVe0Hlk/fKXU+BMn5wDMqhGUorKGQ03LQVXb+hnMjLgO5DsaSqyqUR5eBImUQR7j8jebiw5Im6GM62WlzxQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764068265310509.51259715858805; Tue, 25 Nov 2025 02:57:45 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNqiI-0004pF-A7; Tue, 25 Nov 2025 05:56:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNqiE-0004aQ-Uz for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:59 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vNqi9-0001pi-GJ for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:55:58 -0500 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-42b3ad51fecso4279239f8f.1 for ; Tue, 25 Nov 2025 02:55:52 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f2e556sm33315291f8f.5.2025.11.25.02.55.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 02:55:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764068151; x=1764672951; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yQ3G/f5z9MwEGa9QMBSOfQ0OhqIrmAfETxxhBlriST8=; b=HW6ICViWFx8fuSrzOcD3jeSkj6qEn196PIb5nJnkcVf6mwMMiWEest23aJ6iS6oaBG 6aJFQlwLlAgxF66RadU/Y6/uoZGSjnk3q0e3b75EcSW94Cbh+tmtusREBacM2zN2Anz7 zk8PVRuuG0oQjk9xagBy6JsMNYqm/pIT7aTftTTF59ef8E/zD5qZg/OcHKV/XVbMbrcz D9voG5wGgJxmmpc0DbDNf8EhHcA4dLrQdzHHUvZSOv+tD1dWxoSg/DU3Ef3RT7lt/Dwr 11gkUpl/M2yOgK0MyAqcGAyfe91kgVArvx7LPtA5asUGuQg/n7HrNtHpLCDqv6TFpuaa Ew2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764068151; x=1764672951; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yQ3G/f5z9MwEGa9QMBSOfQ0OhqIrmAfETxxhBlriST8=; b=pdhYYMLkLhMgxU/Arw6u2UY7SoBJb+RlB5mZn/gz3SE53Ot+tuv706aPAETTOdkdyw 3c/8i0M2QmX4qz3aO8F+EHDxY+9yEhlgtgvKBH5dQah1fHlW1/99EsyKQCoZIXIRaaNh u2P1UFP6m5G90treRQ36Bhx0TZGhIBWQLgI1HNpd0xulzh+H1AjsH7lVZH0W9nOMzjIT 2k18Y7xI8C/biAf1w+GvTLe/fNizDcDSFDqf+MK36pYDP+JphtCWCpBi8wR8nsA/KIkg QWKoAVlwtE2KM8HTNznhAM5bgMaddXJGHUd4faQaZ4yEWnJ0XFxatz8kqhikE4Svfusj hm+A== X-Gm-Message-State: AOJu0YwK4MbaMWv0Vjbr2EJE0shBS4klDaUnsrxfEWYfVz1Br3fd3TMQ rYPb5mbEozpUHnO2bUOrfnXjAg4LlLGLEL9nOw2p5ZVdRWaunExOKi9uOMQUUITey0rigsfDaU7 VzRGEb+yivA== X-Gm-Gg: ASbGncsBXqzK22dW0aDonn1/HlzimX83ptqCK2iHWZsivqoOw4PY4faKpW0fimGrkw0 mMVpR+m57+dLj80c4eKralTDHSfJA/JmbdHnr7dg5pt6CQXfP+CILkAN92h/HRHIY6yNjOvgtoW 0ZdejaLe+dckfCqm5VZ9LN5FVrRrY9KrlwqE3MyyQczu0z+IdTkIG5+0c+WbhhIVy4Zk3ixvzh/ joJBCPf1mxf/B/MpSfk6wXVR2IeuCXNca11dzbcnU1l2/49xzddE5pncKhPMxOb+BIl0BO5kj9d BSCvNTP4uwPed/4pXv6rKKdCkvQMG+EKG0LaO7IUoB8Z+TUskUZatFaUTpJF0gsC8uYxCWscznS ZsUzH56db2WwBkYHGOyF48o3JHOxdyh17pa/LUeAf0EbZlRm2Llfs/kqUQph31JzoKVlJE1PvU7 cbkFQMVEoFyMcLVfiF6d1rM5rJhmHc3tsRZkbZPHVMIFM53rEvvMOnCPtmmFu6KiPJSAtfh4k= X-Google-Smtp-Source: AGHT+IGmr8rG25zaL9CLrRLJSz/n7IqXyNjVat0SFDPCDEhkxdniYE3qgen3PT1iXCuE3DIPg9nYAQ== X-Received: by 2002:a05:6000:2c0c:b0:42b:38de:f00b with SMTP id ffacd0b85a97d-42e0f33f7d3mr2380017f8f.35.1764068150673; Tue, 25 Nov 2025 02:55:50 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Yoshinori Sato Subject: [PATCH-for-11.0 10/12] target/sh4: Replace cpu_stl_data() by explicit endianness variants Date: Tue, 25 Nov 2025 11:54:31 +0100 Message-ID: <20251125105434.92355-11-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125105434.92355-1-philmd@linaro.org> References: <20251125105434.92355-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764068266741019200 See commit 852d481faf7 ("SH: Improve movca.l/ocbi emulation") for more context on this code. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sh4/op_helper.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/sh4/op_helper.c b/target/sh4/op_helper.c index 557b1bf4972..63515cc5e6c 100644 --- a/target/sh4/op_helper.c +++ b/target/sh4/op_helper.c @@ -143,7 +143,11 @@ void helper_ocbi(CPUSH4State *env, uint32_t address) if ((a & ~0x1F) =3D=3D (address & ~0x1F)) { memory_content *next =3D (*current)->next; - cpu_stl_data(env, a, (*current)->value); + if (TARGET_BIG_ENDIAN) { + cpu_stl_be_data(env, a, (*current)->value); + } else { + cpu_stl_le_data(env, a, (*current)->value); + } =20 if (next =3D=3D NULL) { --=20 2.51.0 From nobody Mon Feb 9 07:57:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764068171; cv=none; d=zohomail.com; s=zohoarc; b=jl+AiqQtXEtLuuzSIeS2godNhlsf8LkbYl2FCFoZIryeugLykTHGZgESFZNUdTQGNCo2nzlJg3iYYE3FggTwgGN6WSopU0IW29FJ/QQYoDbphv1+p+S66BMNsMqxWvZFmg7jDVZbFifzoYRoEJzhTddac+Vi3u+AptAse4y8AgM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764068171; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HDoRFtIf4DtlaKu8FqeCDNwKdTIWIuyOpEl6R55IExI=; b=it6gIbppBTtrJ/8hGQ/+LiGN4uAuSanL6oex/1JgbpIWgD6lbXNC7M/xBVtIfQ5FtpnVYmOIqw123o6YKsFLW379abnZ2lv7uXHQFjr2QKGIuqQQNazpmXOKRjrRBk6sMk5wUr8DwK8wx4kKAk9WRtDZdXKl9Nlw/W/J2Xy6EX8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764068171564909.2449520751594; Tue, 25 Nov 2025 02:56:11 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNqiO-0005AS-3v; Tue, 25 Nov 2025 05:56:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNqiM-0004zm-Cu for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:56:06 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vNqiG-0001sl-JH for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:56:06 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-477632b0621so35906745e9.2 for ; Tue, 25 Nov 2025 02:55:59 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f2e454sm33465521f8f.2.2025.11.25.02.55.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 02:55:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764068158; x=1764672958; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HDoRFtIf4DtlaKu8FqeCDNwKdTIWIuyOpEl6R55IExI=; b=hprdA8aOlnPEBbuJd8iUpEoXMUP1lsym4RWyOHiBdXBHvEjG0z++p6d8q2MmppWH87 z90DKRfo5VRm/S+UUGJORWVgZtJdANAOA1pzwcig297qw3lUJUTplZmmPQ64N4Qi9C9p oqB+LSI7S/MucF9q4hdffkLml1GK4vaFxmWOVL4m5a7iaTniZha/2rsdpvNu8mpBYdcu DhYACUhRlz+rR1TMwiTUGhwgXWD3mt7PA+2z4xZnBiG0LD4PyMjoYqD2e+IJKyzvKlyh qLl4flr3KezO2/8x1ld7M7WSgSM8taaJzH4g4qx2v5lNDRJL0aAjNxAT7nu2+MZwyLzX mROA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764068158; x=1764672958; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HDoRFtIf4DtlaKu8FqeCDNwKdTIWIuyOpEl6R55IExI=; b=lOpgDNkXoFpWqlKVZUB0TA9x7qVbQdgkI64NQouGJiw509cN/OmZVhU4ZDGrSZn+5Y LVIN/uL64XTp2r15aGy4QS2f4Nk81/OfT/szQIkYY46F0wldqGxRPLxMY0SxDmmgnysD YFlL8Zy/XN0KVytrMnR9aTjiW/CxkcWj67yk4D/4sZhSm5w9FVCj4PCN4hzPZIzDAiDX T0hKSFLeqQPGTn0HExp85pOZsgRUu5K2mrHIZD+5cgGmBPLDN1zTvRVRUfNV+1Fu/evp HFrJTdNCHMbPn7WAODYXdJUu1sB17W7Fm30CbjvRNmFMKPgmjhVrv+3KXHnWLd1lTynp BYIw== X-Gm-Message-State: AOJu0YzmrsoIwZ5sBELW3XolDECYKnQls1bUwNbtFZ/MVpxfW5kzgnOX DaYPXJN78bB7Y7dtzBtp4XMvv5LZUNCYCWUg5fhkUxjaJI1Uc1DPD8p6k3lwrxfEY7IX4lJ+Jt5 Z1YqbcX8vFw== X-Gm-Gg: ASbGnct3MBntMRhe+qGp/bPygKM5h2gDWzUw4GOgPGSw7pLGwQkbFU/F/vfps4zDoB2 fkfWTMqW04bzNcVRMfK70yQlmsVU1v6/FUJE/Z/lQj5YEfEU+TzPWToe84WOmBGQ9LmeEc9TyT9 2d3Up11NMM9VOMItA6hyPhYT0l84xeMZ/UxSSHrTv20fkcmipVdyX9sNlFG59BRMZtkX4rMdV/P zKGG/1UbpUEi/6eHcTvfxxXWYhm+haLOXjJNcwCXW7led2pqVxWcOq8p84XZgAQFFPMoSup2rTy 7EjmKdSATl0cWaaU6pJYYwYK6kh1Ea230Dh20TT1QLmDt50ootBCrJy3Q5y/5SzdjaBHTE5x4fE 2SICEU+Nr3dfV2Ag6x4pm4oGGFwyam3fefzCFehVqW+uIYUagVvVEph95BlLsdNtbbOABo1uyru ZPjPVRZoekfjEO4cY42xC6eVdZhNeUT4tFLvkD99vu1/a4PfVdKMYEc2U4LEyLPe6RGeoH0SU= X-Google-Smtp-Source: AGHT+IHr03pzFhWB/PnWCBSB1i5bbKRPT86qcWm/75XnkinSN50awFtNa6LLShFW7ByfEpSaCld24w== X-Received: by 2002:a05:6000:1448:b0:42b:3ace:63cc with SMTP id ffacd0b85a97d-42cc1d2d5dcmr14899744f8f.35.1764068158147; Tue, 25 Nov 2025 02:55:58 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Aleksandar Rikalo Subject: [PATCH-for-11.0 11/12] target/mips: Use big-endian variant of cpu_ld/st_data*() for MSA Date: Tue, 25 Nov 2025 11:54:32 +0100 Message-ID: <20251125105434.92355-12-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125105434.92355-1-philmd@linaro.org> References: <20251125105434.92355-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764068172941019200 MSA vectors are accessed in big endianness. Per the "MIPS=C2=AE SIMD Architecture" (MD00926 rev 1.03): 3.1 Registers Layout MSA vectors are stored in memory starting from the 0th element at the lowest byte address. The byte order of each element follows the big- or little-endian convention of the system configuration. Use the explicit big-endian variants of cpu_ld/st_data*(). Running files in tests/tcg/mips/user/ase/msa shows: NLOC.B | PASS: 80 | FAIL: 0 | elapsed time: 0.21 ms | NLOC.H | PASS: 80 | FAIL: 0 | elapsed time: 0.22 ms | NLOC.W | PASS: 80 | FAIL: 0 | elapsed time: 0.18 ms | NLOC.D | PASS: 80 | FAIL: 0 | elapsed time: 0.18 ms | NLZC.B | PASS: 80 | FAIL: 0 | elapsed time: 0.19 ms | NLZC.H | PASS: 80 | FAIL: 0 | elapsed time: 0.18 ms | NLZC.W | PASS: 80 | FAIL: 0 | elapsed time: 0.21 ms | NLZC.D | PASS: 80 | FAIL: 0 | elapsed time: 0.18 ms | PCNT.B | PASS: 80 | FAIL: 0 | elapsed time: 0.17 ms | PCNT.H | PASS: 80 | FAIL: 0 | elapsed time: 0.19 ms | PCNT.W | PASS: 80 | FAIL: 0 | elapsed time: 0.18 ms | PCNT.D | PASS: 80 | FAIL: 0 | elapsed time: 0.19 ms | BINSL.B | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | BINSL.H | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | BINSL.W | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | BINSL.D | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | BINSR.B | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | BINSR.H | PASS: 112 | FAIL: 0 | elapsed time: 0.58 ms | BINSR.W | PASS: 112 | FAIL: 0 | elapsed time: 0.58 ms | BINSR.D | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | BMNZ.V | PASS: 112 | FAIL: 0 | elapsed time: 0.65 ms | BMZ.V | PASS: 112 | FAIL: 0 | elapsed time: 0.59 ms | BSEL.V | PASS: 112 | FAIL: 0 | elapsed time: 0.60 ms | BCLR.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BCLR.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BCLR.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BCLR.D | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | BNEG.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BNEG.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | BNEG.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BNEG.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BSET.B | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | BSET.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BSET.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BSET.D | PASS: 80 | FAIL: 0 | elapsed time: 0.33 ms | MADD_Q.H | PASS: 112 | FAIL: 0 | elapsed time: 0.60 ms | MADD_Q.W | PASS: 112 | FAIL: 0 | elapsed time: 0.83 ms | MADDR_Q.H | PASS: 112 | FAIL: 0 | elapsed time: 0.62 ms | MADDR_Q.W | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | MSUB_Q.H | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | MSUB_Q.W | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | MSUBR_Q.H | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | MSUBR_Q.W | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | MUL_Q.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MUL_Q.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MULR_Q.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MULR_Q.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | FMAX_A.W | PASS: 80 | FAIL: 0 | elapsed time: 0.36 ms | FMAX_A.D | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | FMAX.W | PASS: 80 | FAIL: 0 | elapsed time: 0.33 ms | FMAX.D | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | FMIN_A.W | PASS: 80 | FAIL: 0 | elapsed time: 0.36 ms | FMIN_A.D | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | FMIN.W | PASS: 80 | FAIL: 0 | elapsed time: 0.35 ms | FMIN.D | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | ADD_A.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADD_A.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADD_A.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADD_A.D | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | ADDS_A.B | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | ADDS_A.H | PASS: 80 | FAIL: 0 | elapsed time: 0.33 ms | ADDS_A.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDS_A.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDS_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDS_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDS_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.80 ms | ADDS_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | ADDS_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDS_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDS_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDS_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDV.B | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | ADDV.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDV.W | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | ADDV.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HADD_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HADD_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HADD_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HADD_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HADD_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.33 ms | HADD_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVE_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVE_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVE_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVE_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVE_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVE_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVE_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | AVE_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVER_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVER_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | AVER_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVER_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVER_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | AVER_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVER_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVER_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CEQ.B | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | CEQ.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CEQ.W | PASS: 80 | FAIL: 0 | elapsed time: 0.38 ms | CEQ.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLE_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLE_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLE_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLE_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | CLE_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | CLE_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | CLE_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | CLE_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | CLT_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | CLT_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | CLT_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLT_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLT_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLT_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | CLT_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLT_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | DIV_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | DIV_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | DIV_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DIV_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DIV_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.39 ms | DIV_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | DIV_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DIV_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DOTP_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DOTP_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.35 ms | DOTP_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DOTP_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DOTP_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | DOTP_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DPADD_S.H | PASS: 112 | FAIL: 0 | elapsed time: 0.59 ms | DPADD_S.W | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | DPADD_S.D | PASS: 112 | FAIL: 0 | elapsed time: 0.58 ms | DPADD_U.H | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | DPADD_U.W | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | DPADD_U.D | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | DPSUB_S.H | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | DPSUB_S.W | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | DPSUB_S.D | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | DPSUB_U.H | PASS: 112 | FAIL: 0 | elapsed time: 0.58 ms | DPSUB_U.W | PASS: 112 | FAIL: 0 | elapsed time: 0.59 ms | DPSUB_U.D | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | MAX_A.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MAX_A.H | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | MAX_A.W | PASS: 80 | FAIL: 0 | elapsed time: 0.33 ms | MAX_A.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MAX_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MAX_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MAX_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MAX_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.35 ms | MAX_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.35 ms | MAX_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MAX_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | MAX_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_A.B | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | MIN_A.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_A.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_A.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.33 ms | MIN_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | MIN_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | MOD_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | MOD_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | MOD_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MOD_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MOD_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.37 ms | MOD_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | MOD_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MOD_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MADDV.B | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | MADDV.H | PASS: 112 | FAIL: 0 | elapsed time: 0.63 ms | MADDV.W | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | MADDV.D | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | MSUBV.B | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | MSUBV.H | PASS: 112 | FAIL: 0 | elapsed time: 0.65 ms | MSUBV.W | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | MSUBV.D | PASS: 112 | FAIL: 0 | elapsed time: 0.65 ms | MULV.B | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | MULV.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MULV.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MULV.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ASUB_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ASUB_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ASUB_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ASUB_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ASUB_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.44 ms | ASUB_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | ASUB_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ASUB_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HSUB_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HSUB_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | HSUB_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | HSUB_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HSUB_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HSUB_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | SUBS_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | SUBS_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.38 ms | SUBS_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | SUBS_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBS_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBS_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | SUBS_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | SUBS_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBSUS_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBSUS_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | SUBSUS_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBSUS_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBSUU_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBSUU_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | SUBSUU_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBSUU_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBV.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBV.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBV.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBV.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVEV.B | PASS: 80 | FAIL: 0 | elapsed time: 0.35 ms | ILVEV.H | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | ILVEV.W | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | ILVEV.D | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | ILVOD.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVOD.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVOD.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVOD.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVL.B | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | ILVL.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVL.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVL.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVR.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVR.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | ILVR.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVR.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AND.V | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | NOR.V | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | OR.V | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | XOR.V | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | MOVE.V | PASS: 80 | FAIL: 0 | elapsed time: 0.18 ms | PCKEV.B | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | PCKEV.H | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | PCKEV.W | PASS: 112 | FAIL: 0 | elapsed time: 0.68 ms | PCKEV.D | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | PCKOD.B | PASS: 112 | FAIL: 0 | elapsed time: 0.61 ms | PCKOD.H | PASS: 112 | FAIL: 0 | elapsed time: 0.62 ms | PCKOD.W | PASS: 112 | FAIL: 0 | elapsed time: 0.58 ms | PCKOD.D | PASS: 112 | FAIL: 0 | elapsed time: 0.58 ms | VSHF.B | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | VSHF.H | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | VSHF.W | PASS: 112 | FAIL: 0 | elapsed time: 0.62 ms | VSHF.D | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | SLL.B | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | SLL.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SLL.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SLL.D | PASS: 80 | FAIL: 0 | elapsed time: 0.38 ms | SRA.B | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | SRA.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | SRA.W | PASS: 80 | FAIL: 0 | elapsed time: 0.37 ms | SRA.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SRAR.B | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | SRAR.H | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | SRAR.W | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | SRAR.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SRL.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SRL.H | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | SRL.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SRL.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SRLR.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SRLR.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | SRLR.W | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | SRLR.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/msa_helper.c | 51 ++++++++++++++++++++++-------------- 1 file changed, 31 insertions(+), 20 deletions(-) diff --git a/target/mips/tcg/msa_helper.c b/target/mips/tcg/msa_helper.c index f554b3d10ee..d6ce17abf9a 100644 --- a/target/mips/tcg/msa_helper.c +++ b/target/mips/tcg/msa_helper.c @@ -8231,8 +8231,8 @@ void helper_msa_ld_b(CPUMIPSState *env, uint32_t wd, uint64_t d0, d1; =20 /* Load 8 bytes at a time. Vector element ordering makes this LE. */ - d0 =3D cpu_ldq_le_data_ra(env, addr + 0, ra); - d1 =3D cpu_ldq_le_data_ra(env, addr + 8, ra); + d0 =3D cpu_ldq_be_data_ra(env, addr + 0, ra); + d1 =3D cpu_ldq_be_data_ra(env, addr + 8, ra); pwd->d[0] =3D d0; pwd->d[1] =3D d1; } @@ -8248,9 +8248,9 @@ void helper_msa_ld_h(CPUMIPSState *env, uint32_t wd, * Load 8 bytes at a time. Use little-endian load, then for * big-endian target, we must then swap the four halfwords. */ - d0 =3D cpu_ldq_le_data_ra(env, addr + 0, ra); - d1 =3D cpu_ldq_le_data_ra(env, addr + 8, ra); - if (mips_env_is_bigendian(env)) { + d0 =3D cpu_ldq_be_data_ra(env, addr + 0, ra); + d1 =3D cpu_ldq_be_data_ra(env, addr + 8, ra); + if (!mips_env_is_bigendian(env)) { d0 =3D bswap16x4(d0); d1 =3D bswap16x4(d1); } @@ -8269,9 +8269,9 @@ void helper_msa_ld_w(CPUMIPSState *env, uint32_t wd, * Load 8 bytes at a time. Use little-endian load, then for * big-endian target, we must then bswap the two words. */ - d0 =3D cpu_ldq_le_data_ra(env, addr + 0, ra); - d1 =3D cpu_ldq_le_data_ra(env, addr + 8, ra); - if (mips_env_is_bigendian(env)) { + d0 =3D cpu_ldq_be_data_ra(env, addr + 0, ra); + d1 =3D cpu_ldq_be_data_ra(env, addr + 8, ra); + if (!mips_env_is_bigendian(env)) { d0 =3D bswap32x2(d0); d1 =3D bswap32x2(d1); } @@ -8286,8 +8286,12 @@ void helper_msa_ld_d(CPUMIPSState *env, uint32_t wd, uintptr_t ra =3D GETPC(); uint64_t d0, d1; =20 - d0 =3D cpu_ldq_data_ra(env, addr + 0, ra); - d1 =3D cpu_ldq_data_ra(env, addr + 8, ra); + d0 =3D cpu_ldq_be_data_ra(env, addr + 0, ra); + d1 =3D cpu_ldq_be_data_ra(env, addr + 8, ra); + if (!mips_env_is_bigendian(env)) { + d0 =3D bswap64(d0); + d1 =3D bswap64(d1); + } pwd->d[0] =3D d0; pwd->d[1] =3D d1; } @@ -8320,8 +8324,8 @@ void helper_msa_st_b(CPUMIPSState *env, uint32_t wd, ensure_writable_pages(env, addr, mmu_idx, ra); =20 /* Store 8 bytes at a time. Vector element ordering makes this LE. */ - cpu_stq_le_data_ra(env, addr + 0, pwd->d[0], ra); - cpu_stq_le_data_ra(env, addr + 8, pwd->d[1], ra); + cpu_stq_be_data_ra(env, addr + 0, pwd->d[0], ra); + cpu_stq_be_data_ra(env, addr + 8, pwd->d[1], ra); } =20 void helper_msa_st_h(CPUMIPSState *env, uint32_t wd, @@ -8337,12 +8341,12 @@ void helper_msa_st_h(CPUMIPSState *env, uint32_t wd, /* Store 8 bytes at a time. See helper_msa_ld_h. */ d0 =3D pwd->d[0]; d1 =3D pwd->d[1]; - if (mips_env_is_bigendian(env)) { + if (!mips_env_is_bigendian(env)) { d0 =3D bswap16x4(d0); d1 =3D bswap16x4(d1); } - cpu_stq_le_data_ra(env, addr + 0, d0, ra); - cpu_stq_le_data_ra(env, addr + 8, d1, ra); + cpu_stq_be_data_ra(env, addr + 0, d0, ra); + cpu_stq_be_data_ra(env, addr + 8, d1, ra); } =20 void helper_msa_st_w(CPUMIPSState *env, uint32_t wd, @@ -8358,12 +8362,12 @@ void helper_msa_st_w(CPUMIPSState *env, uint32_t wd, /* Store 8 bytes at a time. See helper_msa_ld_w. */ d0 =3D pwd->d[0]; d1 =3D pwd->d[1]; - if (mips_env_is_bigendian(env)) { + if (!mips_env_is_bigendian(env)) { d0 =3D bswap32x2(d0); d1 =3D bswap32x2(d1); } - cpu_stq_le_data_ra(env, addr + 0, d0, ra); - cpu_stq_le_data_ra(env, addr + 8, d1, ra); + cpu_stq_be_data_ra(env, addr + 0, d0, ra); + cpu_stq_be_data_ra(env, addr + 8, d1, ra); } =20 void helper_msa_st_d(CPUMIPSState *env, uint32_t wd, @@ -8372,9 +8376,16 @@ void helper_msa_st_d(CPUMIPSState *env, uint32_t wd, wr_t *pwd =3D &(env->active_fpu.fpr[wd].wr); int mmu_idx =3D mips_env_mmu_index(env); uintptr_t ra =3D GETPC(); + uint64_t d0, d1; =20 ensure_writable_pages(env, addr, mmu_idx, GETPC()); =20 - cpu_stq_data_ra(env, addr + 0, pwd->d[0], ra); - cpu_stq_data_ra(env, addr + 8, pwd->d[1], ra); + d0 =3D pwd->d[0]; + d1 =3D pwd->d[1]; + if (!mips_env_is_bigendian(env)) { + d0 =3D bswap64(d0); + d1 =3D bswap64(d1); + } + cpu_stq_be_data_ra(env, addr + 0, d0, ra); + cpu_stq_be_data_ra(env, addr + 8, d1, ra); } --=20 2.51.0 From nobody Mon Feb 9 07:57:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1764068205; cv=none; d=zohomail.com; s=zohoarc; b=Gq5PDVuz/YqcsxYX3XCys+4RQIHIjes1dcYgxJx0sSvQBB3xjIvA6hZWH68Cl03rx5VsevaHIFq4kD9/JKO2dTjRUhAhAF35qJfclPxjAnsz2BacaGOH0HP8m6ir3vVfXYSCkOBZqkd//gdTrTaxrxja+1IChvg9YQD60b7nzeg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764068205; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HqbvtytwZhlAGHOU7hmLAcqlvwP/xTJGGdaDHqryDAY=; b=dTC0gNFoI6/A0U3UYLGhpdknTGRGPtWGP+xCduE/RY0E/E/duzibQlr/m8WhV7x3fhsMUwDY00Vp/ClxIIbyiSafM9hla8ySwb5j5K+WUI3Kpd0ApLEawovJJ8tfH2h/vYzBCL3FPrzNlDj4XQ7LjMl8Hxoh60xL0iW/pXZrt5s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1764068205480918.0354069521451; Tue, 25 Nov 2025 02:56:45 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNqiS-0005g8-81; Tue, 25 Nov 2025 05:56:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNqiQ-0005Qf-8Z for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:56:10 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vNqiN-0001tr-Oe for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:56:09 -0500 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-42b32900c8bso3088419f8f.0 for ; Tue, 25 Nov 2025 02:56:07 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fb8e62sm33608840f8f.35.2025.11.25.02.56.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 02:56:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764068165; x=1764672965; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HqbvtytwZhlAGHOU7hmLAcqlvwP/xTJGGdaDHqryDAY=; b=S6G/zLYIFutIk2e3jnEXqKV1445hTeQGV7Cxo3h2x3ni39CWPyPCMTjHPFb/IiLQf8 wmSoZfCZvQj6NbbtllCKliPIzUlxOTqFxXyOrTFVwQj4hE1/M7+IZzBAInWa/XPV0/Qc C6rN8THVZSHEVV4sV8iHAe1Pgf11o8kIN5FOxVcWr6OLo9pk5knG0/j19LfW7MP/F0Uh y0xSwZVNbA1vsYn9XUlhRqBt9blT5i9/TO/u+DtcW/pmnw03A84CY+J+5DhPKQ2Ur5MF 5gIZXw5XWl1UAGjvk9LR1ykvcaeWUbFjbGhRMOXrLj6XUj4CnCD2Mki0hBQI1k1BzFhm bnlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764068165; x=1764672965; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HqbvtytwZhlAGHOU7hmLAcqlvwP/xTJGGdaDHqryDAY=; b=EhZ9Gguu8FkzNrZYvmw4rh7aWsvYVPkkSzTw6GL1n9FkCquXSPX/nel+i69tDHr1uN /1pkRXaVYQBc38IPHEc+Uot5FLGyg0PkHlldxGgXjusVoKyFuYuttbSj4jNmrTclJyON nUkxJCsvA0XJJUnwvsIYqxolmifb8WiTXYLYAGmvo9OrwZuzaInxnqrYhkxq6VQ47ZXA dJ+aOT/63KpsXP9jpDvwmUjyn0AvN9ElD+PKHf7HG1n9kxbRgQyUIPB9ciqwZ5y+TG8I 6lZCST55JXA2OHiLQhcGiEKbXHYAwv/JqCX1/AF4nyKeJbVTzD/HjRYkUTes58D+9FhF 5hyg== X-Gm-Message-State: AOJu0Ywg7by/sZNdOwiU6RRSIvl4UFaCtyJE6yGQ2bg2C3q33kKHmOoZ BHR7njEBEPQyoDyndMafazfvTLgBnOLUskYTkWRKjb9p9mqLaNxtWgFwH/94VOCFLnOuq6+9tZ1 tzeq4zcH62w== X-Gm-Gg: ASbGnctUJdnctd0N7EgjZR6W1RvQMCd7zUUJO3Gs5XtxIKAc63Ua/To1eYfAgOYbnmL zZJOXDkuQAhE9J0zmbWjPYQcYlfda8o6Aa9KetcD0mP5W+7hfPISMmQKQyscmYnYthi/tTuPO8+ 4BvOhtZ5vtxvL6mkJsREMHQUkCicOYlS45u+04r0bNyP4Ffod+JFzr4zDoWOVwvwNmIjUI5T0HA VGUgnWQwYTcq5W2oWniTXmuDaXaQcy1LtBiPi6dn25iVRjPMtS0QddRLm1kpANC32kb1asmGzYj 70/aBOOb4wZMSMvRdoMUiyvyOGBHqu0lC2v0+vS4PA6LdRJvCBWq0L4Jyfb2eDGX0nffSn6XTJp ujtP1FufEe8qvLJjqBnQHM4+67ADEfj0i3N8ReuhuNd3TK4cBYguMLlNyRi3D7FNr4LroMoD20Q mhJ0uf/yz6KAXhGTmMIzE7hFGNDaBd4MrYGjXTQXosJsafdQ3WTXSWMMT4scHq X-Google-Smtp-Source: AGHT+IEi5lbB43t1hen5gtYZrTis4D86qp8KTt2V55htTR5tlKY+FOKUCP4/Mo4dCjJthpO9zgxAoA== X-Received: by 2002:a05:6000:1a8e:b0:429:cf88:f7ac with SMTP id ffacd0b85a97d-42cc1d35d6dmr15171928f8f.44.1764068165307; Tue, 25 Nov 2025 02:56:05 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini Subject: [PATCH-for-11.0 12/12] accel/tcg: Remove non-explicit endian cpu_ld/st*_data*() helpers Date: Tue, 25 Nov 2025 11:54:33 +0100 Message-ID: <20251125105434.92355-13-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125105434.92355-1-philmd@linaro.org> References: <20251125105434.92355-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1764068206081019200 All uses were converted to the explicit cpu_ld/st*_{be,le}_data*() helpers, no need for the non-explicit versions anymore. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- FIXME: Still some PPC/MIPS uses --- include/accel/tcg/cpu-ldst.h | 46 ------------------------------------ 1 file changed, 46 deletions(-) diff --git a/include/accel/tcg/cpu-ldst.h b/include/accel/tcg/cpu-ldst.h index 0de7f5eaa6b..12dd38599a6 100644 --- a/include/accel/tcg/cpu-ldst.h +++ b/include/accel/tcg/cpu-ldst.h @@ -428,52 +428,6 @@ cpu_stq_le_data(CPUArchState *env, abi_ptr addr, uint6= 4_t val) cpu_stq_le_data_ra(env, addr, val, 0); } =20 -#if TARGET_BIG_ENDIAN -# define cpu_lduw_data cpu_lduw_be_data -# define cpu_ldsw_data cpu_ldsw_be_data -# define cpu_ldl_data cpu_ldl_be_data -# define cpu_ldq_data cpu_ldq_be_data -# define cpu_lduw_data_ra cpu_lduw_be_data_ra -# define cpu_ldsw_data_ra cpu_ldsw_be_data_ra -# define cpu_ldl_data_ra cpu_ldl_be_data_ra -# define cpu_ldq_data_ra cpu_ldq_be_data_ra -# define cpu_lduw_mmuidx_ra cpu_lduw_be_mmuidx_ra -# define cpu_ldsw_mmuidx_ra cpu_ldsw_be_mmuidx_ra -# define cpu_ldl_mmuidx_ra cpu_ldl_be_mmuidx_ra -# define cpu_ldq_mmuidx_ra cpu_ldq_be_mmuidx_ra -# define cpu_stw_data cpu_stw_be_data -# define cpu_stl_data cpu_stl_be_data -# define cpu_stq_data cpu_stq_be_data -# define cpu_stw_data_ra cpu_stw_be_data_ra -# define cpu_stl_data_ra cpu_stl_be_data_ra -# define cpu_stq_data_ra cpu_stq_be_data_ra -# define cpu_stw_mmuidx_ra cpu_stw_be_mmuidx_ra -# define cpu_stl_mmuidx_ra cpu_stl_be_mmuidx_ra -# define cpu_stq_mmuidx_ra cpu_stq_be_mmuidx_ra -#else -# define cpu_lduw_data cpu_lduw_le_data -# define cpu_ldsw_data cpu_ldsw_le_data -# define cpu_ldl_data cpu_ldl_le_data -# define cpu_ldq_data cpu_ldq_le_data -# define cpu_lduw_data_ra cpu_lduw_le_data_ra -# define cpu_ldsw_data_ra cpu_ldsw_le_data_ra -# define cpu_ldl_data_ra cpu_ldl_le_data_ra -# define cpu_ldq_data_ra cpu_ldq_le_data_ra -# define cpu_lduw_mmuidx_ra cpu_lduw_le_mmuidx_ra -# define cpu_ldsw_mmuidx_ra cpu_ldsw_le_mmuidx_ra -# define cpu_ldl_mmuidx_ra cpu_ldl_le_mmuidx_ra -# define cpu_ldq_mmuidx_ra cpu_ldq_le_mmuidx_ra -# define cpu_stw_data cpu_stw_le_data -# define cpu_stl_data cpu_stl_le_data -# define cpu_stq_data cpu_stq_le_data -# define cpu_stw_data_ra cpu_stw_le_data_ra -# define cpu_stl_data_ra cpu_stl_le_data_ra -# define cpu_stq_data_ra cpu_stq_le_data_ra -# define cpu_stw_mmuidx_ra cpu_stw_le_mmuidx_ra -# define cpu_stl_mmuidx_ra cpu_stl_le_mmuidx_ra -# define cpu_stq_mmuidx_ra cpu_stq_le_mmuidx_ra -#endif - static inline uint32_t cpu_ldub_code(CPUArchState *env, abi_ptr addr) { CPUState *cs =3D env_cpu(env); --=20 2.51.0