From nobody Sat Feb 7 08:54:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1763954729; cv=pass; d=zohomail.com; s=zohoarc; b=UNQh+os9OEGPtGO7XxSZMAWfsiBjEeJCqK5CWNAmR+DYOXj+PsPzPYBJwUg9QGlLd2N6hpQr+oZt2LI3xsNfgNz8s4FmTCBpXq6uYavhLg9sefz/SukLqQ/MYyZ7JroEaJGG1NjI/vsrhKKa4NWEf5fi6FuNaupvcdH8IyMzMvg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763954729; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eiK7se19Qd0xoHx2vgEJs3TpWaV+5tL3C22/R0isA9M=; b=nzTPlaVRa4nA/PVK73SJ/w/Pbz73gqEGfMd1z8jFg6J1u2y+MOTByGzI7nmHma5C1fiewsztVTEuUr2cAha7Xa44oBMu0CN8yH/nNpQkq9NMkYZ+DqalySnYgQT3W7vkXFMasGiveno71mRAFpxB0UIg8eNR4X3CwaNNahOc3FI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763954729230676.1490591573195; Sun, 23 Nov 2025 19:25:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNNCL-0005QA-Gx; Sun, 23 Nov 2025 22:25:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNNCC-0005Mj-Sb for qemu-devel@nongnu.org; Sun, 23 Nov 2025 22:24:59 -0500 Received: from mail-northcentralusazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c105::5] helo=CH5PR02CU005.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNNCA-0004eG-TB for qemu-devel@nongnu.org; Sun, 23 Nov 2025 22:24:56 -0500 Received: from BYAPR06CA0013.namprd06.prod.outlook.com (2603:10b6:a03:d4::26) by IA1PR12MB6283.namprd12.prod.outlook.com (2603:10b6:208:3e5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.15; Mon, 24 Nov 2025 03:24:47 +0000 Received: from CO1PEPF000044F9.namprd21.prod.outlook.com (2603:10b6:a03:d4:cafe::6a) by BYAPR06CA0013.outlook.office365.com (2603:10b6:a03:d4::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.17 via Frontend Transport; Mon, 24 Nov 2025 03:24:46 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by CO1PEPF000044F9.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.0 via Frontend Transport; Mon, 24 Nov 2025 03:24:47 +0000 Received: from honglei-remote.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 23 Nov 2025 21:24:44 -0600 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BvFOQfSJU9Gzq4jM7RFlMV54CQElb9z4e/YeSJwLfls5Lp1yPH46Zd5u48DdLJLeV/SefKqh71c0NSftykOGdXl7VndvBOOd1N8UwbweALjPGXanxi3jzlXWAw2cQ+xp5Jq2Rf10RwZ560nfmtYrBoBLpm8z140TkWIc70RhfMqgWPYTCjIKBZzq/k7pwnZePv2Bclxp8Mp0ZsRNh/wpcAQtFikxyzAqmL5MJIj6MObPmYm5pCx778FnRch8oZYUCzvYgji47rlDewsWheT4aF2LO9TRDvUBhvmTTd4gUsmJse+P6dUZKLfxQ0BkVw5pQrgob7OYRwYHZK7MzRWayQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eiK7se19Qd0xoHx2vgEJs3TpWaV+5tL3C22/R0isA9M=; b=JWl1+WPqCL6zSlqLLPmRdAqdReX9FRDMZM8+yflcJEUyqsECoRcDvDjPJIwfV6xUGasW2G6XttHDyiuhfZR/hMwW652PZ7hHP4TOgQIsSbp3StvM59CgfjlyerACcGHyqrTMzyM37mtH+Zbiuk+hBAS/O1FAdh/1+tYoVvPo/iD0/t3xIrkYNzMcnG1nGkoDBfgiUGSHhm9ZV+2YOFXQIFRgIgTqXPr+ZTe82wD1GSRm+o2bIKo4MdxiKb0jaL0g7p7EQjtr0JnTxsWf7fViuKSN4pf6wOkJgi/5gyHmN5eoSrC2608nejHsMwXjsC6wLc0DEmgwqROFTMSMTjG5IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eiK7se19Qd0xoHx2vgEJs3TpWaV+5tL3C22/R0isA9M=; b=GM3q0v+6qUTOUHAZZlEj/IxV1dXppPAtt8lqyqaavYvM5jDK8V9HkliW/aCTZTlLeY6BcxspJ2/2Zfr2TqbfReN04CahLhAx6LD4OSkyff6VsqRpN2SXQWLSNBrv3AYs+YJuPItJGKfaRtg5Bv3mj9Gpif1zMew+0cQ70CFFqnM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Honglei Huang To: , , , CC: , , , , , Honglei Huang Subject: [v5 1/2] virtio-gpu: fix error handling in virgl_cmd_resource_create_blob Date: Mon, 24 Nov 2025 11:24:22 +0800 Message-ID: <20251124032423.227712-2-honghuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251124032423.227712-1-honghuan@amd.com> References: <20251124032423.227712-1-honghuan@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F9:EE_|IA1PR12MB6283:EE_ X-MS-Office365-Filtering-Correlation-Id: 19be19ec-fe6e-48c8-a4b6-08de2b090533 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DR2NFwVspLbUDz5Q2iz7aeFE1HZn8uwdZkEQ2SCGkIG7+SwQCtkSakbiHrwy?= =?us-ascii?Q?CPYEndfFtMYLmQQR/rhs5oqDeBd4hyTc3G37KoT4/gwyeknNgFiVkcZt09xN?= =?us-ascii?Q?5JaZnVMQsswcF6TJgb9cZ59WyhH6GY3pDKgVqFqOEiXIC5pcJ7KWuUDv6+KD?= =?us-ascii?Q?rSaIfKF94Y4PACNPqDgQ1SAo4KUi9eXh3xcQFknVewa5mscAcKPJ8Yg1B2o5?= =?us-ascii?Q?2QqEXwTePjlfTFHwz1/oUTDrJ46SuMEpwoEMIYqZuN2MQJ+yZEdv/Yz/H30T?= =?us-ascii?Q?9vLAd5ctcCAvUxBkRNUxRTjqRChSFF+s++cIK8iJrrMZ1E/sBFG+QwcQoE0s?= =?us-ascii?Q?rcu6QFcz/s0IHENFtria2+v41OD3NGsU2GL9YhC9HIs77EXYyYpu3WUr4WEi?= =?us-ascii?Q?4qonySZzRmdRoMZ9aXhKNrz5bna11p33k/p8FEwU77Wt26x1hYBx2qKBmJxP?= =?us-ascii?Q?Y4JGxcFhePnrzON52goznLWpTkZqGZ32W8T8qoWguX6GROyaDTggD2Nd8ImA?= =?us-ascii?Q?GASWOSHUmjPiTwQEpinLxHbDbRrXG3jN6guXXl1VdyBan9UFp9TCdaLzf5S8?= =?us-ascii?Q?2OOMAAGs2cbYzt+auyEgbRqnauZiY0uOFANip/Ki9fWD224BzUQzaPvicKN4?= =?us-ascii?Q?QkgQTRqExJP1+RMcMhU9FZI+4kKjBUpbYSPEt6xICjhxn2qalV0fKeHyP6WE?= =?us-ascii?Q?PJKG9KIZYhQpYZuJ5q0aJaH+NMiX7gfphoNHcnI+7x+EwqscwJ3uvm2sN8o3?= =?us-ascii?Q?udkrwo82611o5Ngg7nYPMmuMwiNNQOdbtZMO4b3loOTeBDv7Oyo5JXMeEFpu?= =?us-ascii?Q?Exs9wCagVS1Kh5LL/a7LS/x+9bhrrtAf2P68uhMrRWCmh+eYm7HeHL/xS1UB?= =?us-ascii?Q?tqOeJBLtbPmqcwpof8txRX6nC6ixyh+wR7AEODGGsNU0wfk8ex2NQu1sm6/j?= =?us-ascii?Q?tiaTfmVD+2K0Tw97ls54dyNp3nzDV9WO6+WeYQREa7NyvKrVNuS3NkOE26Wh?= =?us-ascii?Q?uC1oWg073cxaaIq7eI+5R56senVwTVSqhdFyGXkOqdqJ3M9N7kr48/W4+1a2?= =?us-ascii?Q?BaZ6+JA3R2ZHHDWtIfeCzen8wNaTM0Crciz75NwKdFz9Rn658GoAO5nHInjO?= =?us-ascii?Q?93m6vP7H5iJiszcdsuYSTCYojBTWviH0pdD0NxvuOIjIUxCnZ0Fcm4NqROur?= =?us-ascii?Q?/j+GifhZf+dgHmF4x0pxGkXq5Q6GSvARv8o481sPuYxA7bRgNlsCTvxI5L8d?= =?us-ascii?Q?y3ho2XEbx492N5QbyMA00LU8bs6jtqfIIybXXmtI0lL5EQRyOjdJfihe9I1F?= =?us-ascii?Q?L3HpZjIGl/3Rno7xm64YMPjBKRFjILkF3dj1n25HANGEe2tJQ063gVJEFPZZ?= =?us-ascii?Q?Lh3sH7LfzCvgxlHpadH70ULACcMwPm7JvTV7MkQkqNJ0bsFHUE7uwWuKZh5l?= =?us-ascii?Q?iZw3MRc1Ua5Y1UaTX7xw9vYKF6jK75mKGZTh6ZnBRjgsvx4gPZ3V66WvxDKX?= =?us-ascii?Q?Zzy3wMQhTUhoG1HJyqsugpBx74pGHPmV0g9VUQNnI3rSRSLqmPNrQwF+/lKz?= =?us-ascii?Q?jO3IOcOzPjoRoDuVTOM=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2025 03:24:47.3816 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 19be19ec-fe6e-48c8-a4b6-08de2b090533 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F9.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6283 Received-SPF: permerror client-ip=2a01:111:f403:c105::5; envelope-from=Honglei1.Huang@amd.com; helo=CH5PR02CU005.outbound.protection.outlook.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.161, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1763954730886019200 Content-Type: text/plain; charset="utf-8" Fix inverted error check in virgl_cmd_resource_create_blob() that causes the function to return error when virtio_gpu_create_mapping_iov() succeeds. virtio_gpu_create_mapping_iov() returns 0 on success and negative values on error. The check 'if (!ret)' incorrectly treats success (ret=3D0) as an error condition, causing the function to fail when it should succeed. Change the condition to 'if (ret !=3D 0)' to properly detect errors. Fixes: 7c092f17ccee ("virtio-gpu: Handle resource blob commands") Signed-off-by: Honglei Huang Reviewed-by: Akihiko Odaki Reviewed-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 94ddc01f91..e60e1059df 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -701,7 +701,7 @@ static void virgl_cmd_resource_create_blob(VirtIOGPU *g, ret =3D virtio_gpu_create_mapping_iov(g, cblob.nr_entries, sizeof(= cblob), cmd, &res->base.addrs, &res->base.iov, &res->base.iov= _cnt); - if (!ret) { + if (ret !=3D 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } --=20 2.34.1 From nobody Sat Feb 7 08:54:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1763954744; cv=pass; d=zohomail.com; s=zohoarc; b=mZ2g0pR0P9lDgKgfG93mWe/7ux93lcZunQQKrk2mP2cZLysE6y3n917mHXTiwffiM4Esa7yXxOlPg6VxwakJhc2nfnyS8vhwT4tf3/Fb8dwOWARsRreEPKqGD2hKyRgYHuLpj0q6IHA2gs/B8UWav+TFfwVIVwPmUD+eb5RB5A0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763954744; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iTNBSi5cU6xrUe7PU03n1OXePNw5YWxYRXV7IJrYsKU=; b=TvdPRf09dS6ZiK3BwDrEPT0JlKcnVytbeaHuAEIcB7O8wsiyFjKqmgylStP5UnKFT0W2n+dHIzUqi0l79gtoyGgH3LSEVWGtdQpNSyfySqlQPqqOtj7RhoIE5SCx0l1tvOZ5LOKvfsSZu2JT4Zd2EPzJkh9vS8JFDCDXZLrPvjM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763954744760528.9800577801313; Sun, 23 Nov 2025 19:25:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNNCT-0005SJ-LT; Sun, 23 Nov 2025 22:25:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNNCD-0005Mw-Jf for qemu-devel@nongnu.org; Sun, 23 Nov 2025 22:24:59 -0500 Received: from mail-northcentralusazlp170100001.outbound.protection.outlook.com ([2a01:111:f403:c105::1] helo=CH1PR05CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNNCB-0004eL-DN for qemu-devel@nongnu.org; Sun, 23 Nov 2025 22:24:57 -0500 Received: from BYAPR06CA0016.namprd06.prod.outlook.com (2603:10b6:a03:d4::29) by BY5PR12MB4050.namprd12.prod.outlook.com (2603:10b6:a03:207::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.17; Mon, 24 Nov 2025 03:24:50 +0000 Received: from CO1PEPF000044F9.namprd21.prod.outlook.com (2603:10b6:a03:d4:cafe::d7) by BYAPR06CA0016.outlook.office365.com (2603:10b6:a03:d4::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.17 via Frontend Transport; Mon, 24 Nov 2025 03:24:46 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by CO1PEPF000044F9.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.0 via Frontend Transport; Mon, 24 Nov 2025 03:24:50 +0000 Received: from honglei-remote.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 23 Nov 2025 21:24:46 -0600 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VmdRRK9R8guobiVVn/HJr/oiqqdT+KAgaU/3EIAuxHdyjFeEl22THdbBt7pw+iYvT5Z/Iavb3wQ3/QSD9QL42LDstH6GlDqHngRTDMvqCIdciBSxdWz+9Tl4CILj3wcKCqky+16sfjaGPhNmU4n3Eny6lHI50JbXIjBadHd11xfY710RmUk4jBUTg/ukL/7tLThpbFDEf1oZrzsL0/6LR6Of8c0V5QSki4D4tyFOEX2uTDbYPUFkNlioTPSN4hanfgFMMz5i8RorIz2nmiunDgk85Dw6r6NBD3GQisWfCZ53JQ4ZEceCxDeHKy4LiZqXbpSNnD2hNFarP11IDR/7gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iTNBSi5cU6xrUe7PU03n1OXePNw5YWxYRXV7IJrYsKU=; b=QQ9My4b2W0dTRNgjcJydwD2pNO76+rg3xw3+ufve4PsxOWnGSYjMGNWiOtQ8aUVL5DDldQrDdfkFTFNtAEH16SrPtqYGixmnpUz3iby/WLe/qeHFuxPNkDRaooVgmdmiCHlQ1MR2vlrd9bdWZrLdITGkVRwDrWAyX0uwEnpz6ypczo+LP+2R0Krjnn75NN5guZN79ducJGNaVfP8q0G5dIWI5DeThNXqkT0fPvwLROKkVqQD/6utiH8cCb8O7/wiAldTj0ubgNv85dhngkas5ljX+i3z6Cs8qYR4AFxuGjoK53daP5+8OLHkeP/qoashu7VhmZkukIUECBKJogQrCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iTNBSi5cU6xrUe7PU03n1OXePNw5YWxYRXV7IJrYsKU=; b=Cpn3DsOvQPLM4V8IghDgRZRIKUTCDASNCJPiipm6dGPdTN7w6XHMNT+RWeRI9ukvYSb+0UHjP1aYBiUv/0CJIoGWvcvDzV6s8gO7pHwQCBOSQr+Fvaii6i3Mv2qUcRIMP1PKJA6f2Uq0FAHRHBwsGwaSeQ5GurUrDQsjXLMy0MM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Honglei Huang To: , , , CC: , , , , , Honglei Huang Subject: [v5 2/2] virtio-gpu: use consistent error checking for virtio_gpu_create_mapping_iov Date: Mon, 24 Nov 2025 11:24:23 +0800 Message-ID: <20251124032423.227712-3-honghuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251124032423.227712-1-honghuan@amd.com> References: <20251124032423.227712-1-honghuan@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F9:EE_|BY5PR12MB4050:EE_ X-MS-Office365-Filtering-Correlation-Id: f3d0dd1e-f665-4187-2408-08de2b0906d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Vdji0XU2AuzDjFdr3QNX93SVTmXY1Vb70QZc4ZLIoSj2v+8L/PO21vf/xLrI?= =?us-ascii?Q?//fb+vjpiJO8EazdxigSo402JPGrfjWjNXm3Eo7H5jPfDHjpqFr4iIVNrqrS?= =?us-ascii?Q?GBMdyjs8nHnpzt6TCNdTJI21fdt2gFfeBwAalVjeM/ogfaAdMJwkOwXtewUT?= =?us-ascii?Q?CP57dXT9U6UzKJByQ6yqBS3QBVBR08TYDDglFwytwMrc7eZrzryXMIqkbIne?= =?us-ascii?Q?UQ77kerSZVzrcGpn6tiYuXRF9lESaaqduPDVgBIlj7yvsB9HnjnTLMH3sOpN?= =?us-ascii?Q?AYjQCFphsEwWlr1b4FB7O1jE656nLIKJVY5oLzx82DnxGCPVgUcXFDw9Echw?= =?us-ascii?Q?qssh0F4Idl0dDT8mcETwYJ7g5Kq+S0Urst8aso2JE9UBQib3/PMi1Ez1uhJX?= =?us-ascii?Q?Avi6o1VP/U7vC/mhhaB/MyZuXLQ6TDUutLIkZj5zZPlOEyIyIC5Sd3SAp8qp?= =?us-ascii?Q?UsmgYaL813uRcA5HzUn8j3iRtyIayqpeijjcsiQhIp4AHJ+LAQ51XWmKjERn?= =?us-ascii?Q?qBvo9XL54VlmRFHE+pPjurcwfj87j1sC9eJ9fL2I+lRlU71BYxiTNCtFpB6l?= =?us-ascii?Q?erBwOlybuTf80q+cfs4D0zkhxzR1/doObgOShB/woE5oLKdeD2z72sLGucW1?= =?us-ascii?Q?KggRFwkNxMfBnZPMTuTISfZ8qFJsAOtUp5m7RHCbUih0IcykO71OVChiP81J?= =?us-ascii?Q?3EvXRAJkbMo7zRLRw24eYJLTTA7p2XzRCEdHTWAoJn6CXpJAw1E8XvCxz7ER?= =?us-ascii?Q?OM3VJtqiN7H8J24/bYbNK1GeH+4hu6ME1oNa1lCaYZ6s+N5Ss6F/b9DVBERS?= =?us-ascii?Q?VArSppDNNBVzfSXPcMlOT+mq/AwfbF29aZePHJuRkmwPYmwoF4anR/QBYuC/?= =?us-ascii?Q?yHcXMpCo4S2six9RMWiVYf6PJrPH1QkRGGCMq4oJN1CgSE7dxV0HW4i6DP2e?= =?us-ascii?Q?OoI5wzMs+LZ3gIMCqsG0u4Jz9xYMFvlG2m4Xf+B78rV1fU8byDg4GLos9Jat?= =?us-ascii?Q?MqPXCKDBnlnTK4e95kZ4OryM6Bxttug2jfyaEUwstNlv8f6/eWrKWkT3Aj+x?= =?us-ascii?Q?SGzbfIYGw/ptC2O/oDh4YzTj1ziSsZsUU7/mRUKekiXwxXiJi4HqnFJ1Gsvp?= =?us-ascii?Q?2neH6IQNu9pPOazFlKawEKUxmd7L5pDPre0ZpsRu4Y+VRAP1/GYMcprdBRwC?= =?us-ascii?Q?lWGZEGIhYvZ1lO87bDK9mM+HV/hLEvlzK93Wa27JYOByPoVObSI8u8Udk0M0?= =?us-ascii?Q?xAaFBPTPWZQg9FHFe825976aizq0nk/hguZpw+WC7ojm0nU3rDpwGtAnZiHh?= =?us-ascii?Q?+HxIyaRC4pq+YSDs+oXlT4PA3MDvm42xzUVbRMF1Tb1hdQen1ZCdBmgkKmjV?= =?us-ascii?Q?vGwYHcWmC5pFSZiDJxlNXmVxyf/xHM7XP4wfbG9fdRq0W26JrKIr5TT+itCH?= =?us-ascii?Q?lO5AjzV+4P2Tt/K+H/Mr0KfVgPWyNRGJU1LBv3kO/4tkVPf5bJSdxSICwT/Q?= =?us-ascii?Q?xeEQ9Wz+r9JXrYKjEHhzHo2nlXwUib9eSHInSCwg9c4WLxBB/oxcJCkg8JXB?= =?us-ascii?Q?N/eVuO9N+bKFQJo2G4I=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2025 03:24:50.1186 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3d0dd1e-f665-4187-2408-08de2b0906d5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F9.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4050 Received-SPF: permerror client-ip=2a01:111:f403:c105::1; envelope-from=Honglei1.Huang@amd.com; helo=CH1PR05CU001.outbound.protection.outlook.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.161, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1763954745151019200 Content-Type: text/plain; charset="utf-8" Unify error checking style for virtio_gpu_create_mapping_iov() across the codebase to improve consistency and readability. virtio_gpu_create_mapping_iov() returns 0 on success and negative values on error. The original code used inconsistent patterns for checking errors: - Some used 'if (ret !=3D 0)' - Some used 'CHECK(!ret, cmd)' - Some used 'CHECK(!result, cmd)' Change all checks to use the consistent 'if (ret < 0)' or 'CHECK(ret >=3D 0= )' patterns, following the preferred QEMU coding convention for functions that return 0 on success and negative on error. This makes the return value convention immediately clear to code readers without needing to look up the function definition. Updated locations: - hw/display/virtio-gpu-virgl.c: virgl_resource_attach_backing() - hw/display/virtio-gpu.c: virtio_gpu_resource_create_blob() - hw/display/virtio-gpu.c: virtio_gpu_resource_attach_backing() - hw/display/virtio-gpu-rutabaga.c: rutabaga_cmd_attach_backing() - hw/display/virtio-gpu-rutabaga.c: rutabaga_cmd_resource_create_blob() Signed-off-by: Honglei Huang Reviewed-by: Markus Armbruster --- hw/display/virtio-gpu-rutabaga.c | 4 ++-- hw/display/virtio-gpu-virgl.c | 4 ++-- hw/display/virtio-gpu.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/display/virtio-gpu-rutabaga.c b/hw/display/virtio-gpu-rutab= aga.c index ed5ae52acb..ea2928b706 100644 --- a/hw/display/virtio-gpu-rutabaga.c +++ b/hw/display/virtio-gpu-rutabaga.c @@ -466,7 +466,7 @@ rutabaga_cmd_attach_backing(VirtIOGPU *g, struct virtio= _gpu_ctrl_command *cmd) =20 ret =3D virtio_gpu_create_mapping_iov(g, att_rb.nr_entries, sizeof(att= _rb), cmd, NULL, &res->iov, &res->iov_cn= t); - CHECK(!ret, cmd); + CHECK(ret >=3D 0, cmd); =20 vecs.iovecs =3D res->iov; vecs.num_iovecs =3D res->iov_cnt; @@ -616,7 +616,7 @@ rutabaga_cmd_resource_create_blob(VirtIOGPU *g, result =3D virtio_gpu_create_mapping_iov(g, cblob.nr_entries, sizeof(cblob), cmd, &res->a= ddrs, &res->iov, &res->iov_cnt); - CHECK(!result, cmd); + CHECK(result >=3D 0, cmd); } =20 rc_blob.blob_id =3D cblob.blob_id; diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index e60e1059df..6ebd9293e5 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -557,7 +557,7 @@ static void virgl_resource_attach_backing(VirtIOGPU *g, =20 ret =3D virtio_gpu_create_mapping_iov(g, att_rb.nr_entries, sizeof(att= _rb), cmd, NULL, &res_iovs, &res_niov); - if (ret !=3D 0) { + if (ret < 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } @@ -701,7 +701,7 @@ static void virgl_cmd_resource_create_blob(VirtIOGPU *g, ret =3D virtio_gpu_create_mapping_iov(g, cblob.nr_entries, sizeof(= cblob), cmd, &res->base.addrs, &res->base.iov, &res->base.iov= _cnt); - if (ret !=3D 0) { + if (ret < 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 0a1a625b0e..1038c6a49f 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -352,7 +352,7 @@ static void virtio_gpu_resource_create_blob(VirtIOGPU *= g, ret =3D virtio_gpu_create_mapping_iov(g, cblob.nr_entries, sizeof(cblo= b), cmd, &res->addrs, &res->iov, &res->iov_cnt); - if (ret !=3D 0) { + if (ret < 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; g_free(res); return; @@ -931,7 +931,7 @@ virtio_gpu_resource_attach_backing(VirtIOGPU *g, =20 ret =3D virtio_gpu_create_mapping_iov(g, ab.nr_entries, sizeof(ab), cm= d, &res->addrs, &res->iov, &res->iov_= cnt); - if (ret !=3D 0) { + if (ret < 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } --=20 2.34.1