From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763783498419215.63195890937425; Fri, 21 Nov 2025 19:51:38 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMcrI-00060W-9S; Fri, 21 Nov 2025 20:56:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMbdW-0004Hc-4s for qemu-devel@nongnu.org; Fri, 21 Nov 2025 19:37:59 -0500 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMbdM-0006Dx-M3 for qemu-devel@nongnu.org; Fri, 21 Nov 2025 19:37:55 -0500 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-640bd9039fbso4295347a12.2 for ; Fri, 21 Nov 2025 16:37:32 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fa3a81sm11468220f8f.26.2025.11.21.05.45.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:45:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763771846; x=1764376646; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EctDLYXHneCSbnit9AgBWHWi2e7ESBxD60JGtambQRU=; b=O7KVRf9KkjuzWXhxWUAELGpGWnMWSDWsbCmgLUBiLbAS82EUYX4Hx6VC/TPmPVDnsE xKu5Zko/posqxCn8Qrk/yFNJIgeMOUBYudiDF6fR0wQqBgbbMRGbknXKoKF/T5OLK3mB R87AQz1YXH2KKJ6iyQLJrNTbcYl3NV2DUuy+7W272p/tlYar7LiWSsm8Wo/o1hcH1zil BRvBQsl9jM2+wVcUfMCjQb4QUhLNpVxl5xHVciBsYPFjiNc1qAQXOzuHf9ucwk13dFKJ vTxeLLmpXNxhVQCrdq5MF6mQLJQ1gIZ2qk4LkILX60AridyDDkxgbWTjyJBj6ByJH3RZ 1/yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763771846; x=1764376646; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EctDLYXHneCSbnit9AgBWHWi2e7ESBxD60JGtambQRU=; b=PpTiOGuBblNE0Exm4Qcaylu27asBEb+JjQ2bGiwdy+/A+tXFpfVhjQeXFhaoyYO6cd KVWbjSGV4GOtp9AwZOIlLDYzrZbFpWxkUYZcTYOK0S8Pjvpp/JzG+WXzvrflSxN2dALN bSAKQ4U4Ji6n6ng9ZQtfAlNzTMjzRn00qdroCyecs2XNdBhgcPJFmVyyo7wI/f/Wrbg3 NzCk6GSVGwFOeQ+ol6gDbne2GeoCHj15ZFEC8qwCv3bqfe3JPiDt3TqwUYuAqyWwUT6U 4Tm4Zc4hsr/vDbVbJV01RmMnBES+mHzEYFx3KUPO7Nzp+OJcIwmiUMXP5c7qazINuoOz 8YMw== X-Gm-Message-State: AOJu0YxwLT2adQd1+kD0gev/SAeXh8rJFkBr1iUke4sd23sEtRv4SBvn QQiO38JTvGXMVZPBlPaJig4ZNEgsZhq6JpDzjCOvhrIhaq0E65d6+VEaLWIsx/SUK1Pqz/QmtWl d4nLbQE7wYQ== X-Gm-Gg: ASbGnct0EJiSKuK45KMwH8Pm2z+lpAd0kC1RUHdazB3fy6LJ4DKEznqGaBNz+iUTElF nILpQtXvCNJK5FdCkcts8T0PritHCkIsDdL+7Ojk9vOOEy0FUERyE6dCsL1UFlhe/jepN0+K25q jViBaEw1hFAX5iecVmw1cICgy9GIep1xQAnEvgFPaXE6ulQ+txxu133QfGRyFa9XNA17aUgj1dn rj71DNdQI7XI8RvknPbrMQ/PzCsAdsZ4BxUOqvh/rdG4bA1pV5c/DmrJrpxMkCdyD9TUNFKgI39 wFSdWC6I4iEJQN49wt4VNh/nQKy0kknWzRSLfAW0Hk7hPlyAbaAn0cMnzbzisueVCbb5AkFLINe kiVZyEgBFfp95ne0guXwfh3vSy6RJngw13LeKEF3Jq1ZJ0HoaZyls0S8WqWhQiBuIBvEBXY+U8e XbRr6WTSwS5X4AcI8EPs/Bd+fT7Qk+C7/+gjLfdExgwOAdq2uKN+mh7Tn/GFFO X-Google-Smtp-Source: AGHT+IFGyrbXIQA/mWcfwBA3/DPi2Xn3k/tzNEZtqSYygwo+ZK2frzyKGRo+I3+b+Ow2xi4/97VfGg== X-Received: by 2002:a05:6000:40dc:b0:42b:39ee:2889 with SMTP id ffacd0b85a97d-42cc1d520d7mr2510492f8f.48.1763732711689; Fri, 21 Nov 2025 05:45:11 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 01/21] accel/tcg: Add endianness variants of cpu_ld{uw, l, q}_code() Date: Fri, 21 Nov 2025 14:44:43 +0100 Message-ID: <20251121134503.30914-2-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=philmd@linaro.org; helo=mail-ed1-x532.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1763783499092018900 Allow target with fixed-endianness to not use the MO_TE definition. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/accel/tcg/cpu-ldst.h | 43 +++++++++++++++++++++++++++++++----- 1 file changed, 37 insertions(+), 6 deletions(-) diff --git a/include/accel/tcg/cpu-ldst.h b/include/accel/tcg/cpu-ldst.h index 0de7f5eaa6b..e4ec4e7d367 100644 --- a/include/accel/tcg/cpu-ldst.h +++ b/include/accel/tcg/cpu-ldst.h @@ -481,25 +481,56 @@ static inline uint32_t cpu_ldub_code(CPUArchState *en= v, abi_ptr addr) return cpu_ldb_code_mmu(env, addr, oi, 0); } =20 -static inline uint32_t cpu_lduw_code(CPUArchState *env, abi_ptr addr) +static inline uint32_t cpu_lduw_le_code(CPUArchState *env, abi_ptr addr) { CPUState *cs =3D env_cpu(env); - MemOpIdx oi =3D make_memop_idx(MO_TEUW, cpu_mmu_index(cs, true)); + MemOpIdx oi =3D make_memop_idx(MO_LEUW, cpu_mmu_index(cs, true)); return cpu_ldw_code_mmu(env, addr, oi, 0); } =20 -static inline uint32_t cpu_ldl_code(CPUArchState *env, abi_ptr addr) +static inline uint32_t cpu_ldl_le_code(CPUArchState *env, abi_ptr addr) { CPUState *cs =3D env_cpu(env); - MemOpIdx oi =3D make_memop_idx(MO_TEUL, cpu_mmu_index(cs, true)); + MemOpIdx oi =3D make_memop_idx(MO_LEUL, cpu_mmu_index(cs, true)); return cpu_ldl_code_mmu(env, addr, oi, 0); } =20 -static inline uint64_t cpu_ldq_code(CPUArchState *env, abi_ptr addr) +static inline uint64_t cpu_ldq_le_code(CPUArchState *env, abi_ptr addr) { CPUState *cs =3D env_cpu(env); - MemOpIdx oi =3D make_memop_idx(MO_TEUQ, cpu_mmu_index(cs, true)); + MemOpIdx oi =3D make_memop_idx(MO_LEUQ, cpu_mmu_index(cs, true)); return cpu_ldq_code_mmu(env, addr, oi, 0); } =20 +static inline uint32_t cpu_lduw_be_code(CPUArchState *env, abi_ptr addr) +{ + CPUState *cs =3D env_cpu(env); + MemOpIdx oi =3D make_memop_idx(MO_BEUW, cpu_mmu_index(cs, true)); + return cpu_ldw_code_mmu(env, addr, oi, 0); +} + +static inline uint32_t cpu_ldl_be_code(CPUArchState *env, abi_ptr addr) +{ + CPUState *cs =3D env_cpu(env); + MemOpIdx oi =3D make_memop_idx(MO_BEUL, cpu_mmu_index(cs, true)); + return cpu_ldl_code_mmu(env, addr, oi, 0); +} + +static inline uint64_t cpu_ldq_be_code(CPUArchState *env, abi_ptr addr) +{ + CPUState *cs =3D env_cpu(env); + MemOpIdx oi =3D make_memop_idx(MO_BEUQ, cpu_mmu_index(cs, true)); + return cpu_ldq_code_mmu(env, addr, oi, 0); +} + +#if TARGET_BIG_ENDIAN +# define cpu_lduw_code cpu_lduw_be_code +# define cpu_ldl_code cpu_ldl_be_code +# define cpu_ldq_code cpu_ldq_be_code +#else +# define cpu_lduw_code cpu_lduw_le_code +# define cpu_ldl_code cpu_ldl_le_code +# define cpu_ldq_code cpu_ldq_le_code +#endif + #endif /* ACCEL_TCG_CPU_LDST_H */ --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763777419; cv=none; d=zohomail.com; s=zohoarc; b=e2vswzkblpXoCOCBe2V8+lUeWtwxs6/bNg2MDMNeqijVYcYX+fUr2MtrUjCoX9RsJz+GJ951Fi0XgDA54Qx+TQTG9+cwwVl+HysRh0l9zGzsTnQ1QdMgrtvC2Vtt5fspny4rRBJnA7P55saD5Cy02Y39vAXZOHgbMDn96gYo7f4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763777419; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=j3j2FTpR0aj6OQBGpq/AXoTS1vEHZTJrzZrKRCUXjeU=; b=Zf+0TdAsEL5CY9K46cyHDGRPOQM17XrtejiuQ0JinDhvHogxDXc8XkeJOultOWeloHdB1CVWhsYj+nALpvsiRyixYFiIUhcxzJFkRTv0hSlKf6IvlYSIoeFm3v12ky0JsLU3Rri1rASZr7HPo5LLpiHVQUeba1TDSJtcpUUuhos= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763777419044979.3776540434019; Fri, 21 Nov 2025 18:10:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMd1Q-0000uZ-Jr; Fri, 21 Nov 2025 21:06:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMcW9-0001KM-Ey for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:34:25 -0500 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMcU7-0001cx-RE for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:34:22 -0500 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-64074f01a6eso4574629a12.2 for ; Fri, 21 Nov 2025 17:32:03 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fb91f4sm11225263f8f.31.2025.11.21.05.45.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:45:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763775118; x=1764379918; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j3j2FTpR0aj6OQBGpq/AXoTS1vEHZTJrzZrKRCUXjeU=; b=TVpWcMmEyRxHrgXHmlWBN2SHXbdBCDwAaOM33r8ft81XtOf0e1Y8EYQEXRQtCDdKVj v4tWtGXntxMKUSR08KwjNJVU1PF7inmNKLQOqahY6PDinm4omBIjJHVWLGoPMCJzUhLy flgwuk6runvuwLmoTH49Zre50anfhfym2aVjrnUNv/PMfIstNEBzSF5caMEh8lv+i34g 77duwyuSOFd+nGDrqfZ7MfUYkptRwHkoIZJ2PogONXWKB14/UpixujRfECw59+KOOyis bhKwVbfTpJUfwwI0FuxfSdnmownJTdRsO5xSANPgJdJYjG97+hJYo3HPPT6ZPeluqjIh 7z/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763775118; x=1764379918; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=j3j2FTpR0aj6OQBGpq/AXoTS1vEHZTJrzZrKRCUXjeU=; b=KzEjByvLiI68hX288JK8REQze/7SXpFcX/JdcMXp/aWlU5fDOqMlAH7W6Admh4NVim wssdfIZ72PshgwL9SSU1/S6mcJ4nIJhQn7AeF+kv0J9KvvEETFImVohGEo96ASwVmeus 1qYQeiNI9gn6ngBmg4r1nyGUQU45qSNb7Y76cjqyV7cIYZtW6ZnnOjOp3RkRKWp9bxlq 0vppYOr37QK0T/aqbCRN2fc2PLhZGr4DBAB3Gtzo58PsIJngtYg39+6ekIm449zHYy9K NwUUImmdigPVDvtOKeFFursQuEKtyTTsN0BtgNE5j3bIbTkvZGez6S6CStaER9yn4mGe M9Vw== X-Gm-Message-State: AOJu0YxUNDVQKvgMzb/cmnE/ulKXsptkgpQsjzvpDyx+PgQ10UvTdEem 5EP6X8i2cOZ7fU9cpbvKWsoDyinZyb2ugMmWd2UisLs5FSfU/SkwC+ioyrAAotfAdisIxi3Slm5 8ISga2CFl5g== X-Gm-Gg: ASbGnctjRl7I/zykP/R1uSRlvwTRd8buVQ4r37QJb7u2zP8tikkJGjPVpzJTsilUu3W KYvkBhN5NetMi+dAXLKqHyKe4lCUZOznC1epyedZ2so0MB5YLSWywWV0VbSHWh3NpKWJd5Zfh+a XuaT2ib2CQi4u2ViCuJf4l5ipfh1oSNXcc+sg8by9a6TmqluSGBtcOCVp+w5Gj00x+ZaF/05S7v WjuW6hih8tLZMv73BfS6GVh3ASUcBVEo2u0EvDSohaTmJYdZ6zsNWG3E/A3Mkj8CSQSKx2P0Jth JLPcgGiYrRdiDvbfjgkKqklZbDLpW6JDOGLSPJJuuBwZMjqrgtGI7X9gDGg2RASm5qO3ClIjEY/ MLiypOD3DtwC8fVmPE3KpaMMHa2VwrMzJwB9d7N0UgEPb2jItUARtKNZmOhbLfv94ZmHkH1vall 21aiFBHl4uSMMDWp0L+ZE/W1qOD166Ub8vd33atEC98Lc4JAlX2rgdysj7gb0P X-Google-Smtp-Source: AGHT+IHpvm5n0pXcwmuEu2SPCCvHmpMRTUrtjIsejteUgK9JQ67Eb0yeRu5feXOzOqB6uzvh7RRxOA== X-Received: by 2002:a05:600c:3b01:b0:477:54cd:200a with SMTP id 5b1f17b1804b1-477c110325dmr19164615e9.6.1763732718198; Fri, 21 Nov 2025 05:45:18 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 02/21] target/alpha: Use little-endian variant of cpu_ldl_code() Date: Fri, 21 Nov 2025 14:44:44 +0100 Message-ID: <20251121134503.30914-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=philmd@linaro.org; helo=mail-ed1-x52f.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763777420451018900 Alpha instructions are always stored in little-endian order. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/alpha/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/alpha/mem_helper.c b/target/alpha/mem_helper.c index 2113fe33ae2..d04d086b59d 100644 --- a/target/alpha/mem_helper.c +++ b/target/alpha/mem_helper.c @@ -30,7 +30,7 @@ static void do_unaligned_access(CPUAlphaState *env, vaddr= addr, uintptr_t retadd cpu_restore_state(env_cpu(env), retaddr); =20 pc =3D env->pc; - insn =3D cpu_ldl_code(env, pc); + insn =3D cpu_ldl_le_code(env, pc); =20 env->trap_arg0 =3D addr; env->trap_arg1 =3D insn >> 26; /* opcode */ --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763780055; cv=none; d=zohomail.com; s=zohoarc; b=dNbyRD3U7OhZ8LSInM0seHy+duTba4RuuooL16X9iN1nvdbZPSVd8W4hw2oIQhERr7fUHyxPRa3R8A4sLDuIBzEoZnhS4TEpDTVsDNAcszCty/AHKoHE3a9mxQ0wYXS8AXXtoAYuFcp1FwXScaukVBlTvlN1NYLqvShZ5vEZBJM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763780055; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TgM8VF9g+T2JoeRRqaHzTf5tHPKfcxDzwnP0zHhd7Bo=; b=JqERcUZy6hXTqaXSQMj5ILQJaKfs16DWCYE+Z7XJcsaejsbjjEsdOvHnm7wvrMUiwz6tONmE1F8bntmCw2pMj2rZAJsxhVSLc6FEyufV8OcAwgcZCpDhBhHkAaY2Vucv3nzM1i5uMGld5wFDVlaehA8cCZzNdgG7HHxDtF2/SLo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763780055151265.5288912829799; Fri, 21 Nov 2025 18:54:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMd8U-00066g-Ma; Fri, 21 Nov 2025 21:14:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMcvl-0001Oz-AX for qemu-devel@nongnu.org; Fri, 21 Nov 2025 21:00:53 -0500 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMcuG-0008NW-2m for qemu-devel@nongnu.org; Fri, 21 Nov 2025 21:00:50 -0500 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-b7355f6ef12so560312366b.3 for ; Fri, 21 Nov 2025 17:59:03 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf1df3d5sm45386075e9.2.2025.11.21.05.45.23 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:45:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763776738; x=1764381538; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TgM8VF9g+T2JoeRRqaHzTf5tHPKfcxDzwnP0zHhd7Bo=; b=ySCzrNpxdXy6lpblNnG3/V3c6kfjw7GSy0XJjOwSzAtkSiNWtIYFO/84J9seLrqHCZ xJhfObBey/Sp7yWw42hrkbgArxIHnXp2vlJnwL2A3lTCuh9iYfP40xtypi278D6kkP3g 4I7Qh2qUbtCrI/l89OkPUyJsmS62GAKnbsy8ZhWm6vZQo52Ofa8Gni3vdZml8i3UYgQd qnAxuukP7uPnWQ7QtTFuIQLgBtVF3ak9lgEzg9e8zXBq7a0c57PoY3iE3cRtRvlLZjcA bkerFjeHlpfN29r9vGUzONKihg6/wAjViiD9svr3EDoIHkzlDZqLsr/kV0EIyuNCpP1/ WcVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763776738; x=1764381538; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TgM8VF9g+T2JoeRRqaHzTf5tHPKfcxDzwnP0zHhd7Bo=; b=eh9jzAX0ZtSeawtrrf1AVqUbnCcUgJCS6mFFh7hNKf8i7wJgFgq1bsgsyekTTkf1qc SXR+wbFA+pn5ZYjlGBh+sHgFn5R2qpoLGg8YLdLWuT9ptH/i/aMXt80qBHUU441RpnGN 7P7sBau7xIkiLcPWgcjLmZnnvc3Wu6QzJVnPUEEAwrfSClZPg6nx9ZimDbULVvwJFDwI YhvcHBvnEuhsu3z/sCRsyWN8X4QFtaf6PGwRfOJ9kjYnVvdm0KpoUUs/QupJJJWzZrc5 zlG2z9xku4Icu4fVirIm8dkJ75Vzrmb1OB2pfs2zgW/lmTT7G42hiqqCJ/RRsv7o10W/ 6Zuw== X-Gm-Message-State: AOJu0YxI3Qk8XRdBDlPBKYFuLNaRYN1YFzKJKwml1YQzya9h2mnBJ46v xyttg88c4SkfZWLUS9zi2+uY4Z7of9P1wvPLAeKb/iissWTbiKRZn9/tNsJ43MrR2Z5PJFO+/WZ +80y1QBg0lA== X-Gm-Gg: ASbGncsEZbqQ6LKEnmLKWV8XYx8RAaORC3HMXULJolvO/7+R/a84LGZYGhaVNc9I7Lp 2Vn+HbfQl2Atty7iIRSuBDI7AN+GfRwDzTr2SIvNocvD+kjdrSezvXx5FUCG4kNNQdIXG3vj/uc r9yFaRaWVcHoRohdGjMkYa+gpKE35cYW4QAkxcmDIVtKq1Y6mHhcUYzgNHK0YTBkclbaqeqDukC o7jQJb8yV2dJD/6rF9H32ZTGl4JY4dYFzsBwwLFSc56Luk8K2kXyuhT1RqY3L6fNghGW9G2CrPp Cdb871pbDfuI6qLkGUt7c5S9uat9VXsQiATohgpYdg/pGqGDtZ/XcvN7//Y6JoRUS0FILeVaHxj ogjB0gs3IIC6PVKVrauNxoIHKF3gtry274kAWhBP6dlijN1oY/GaSTMGMvVltbvECePloIValKR +JRUKNZrDuNUV/QMAUzhcT5Bw1SbXUEtWyjXv1xeTjQyFgple+wtoiNAH/80Nz X-Google-Smtp-Source: AGHT+IF3EsSzc0eJZJYndSarF3h0dI4pV449x9CnhsCZOYGbm8OepOHZAGRyHDokyTGWlmDUQPVNvg== X-Received: by 2002:a05:600c:1f0f:b0:477:8b2e:aa7d with SMTP id 5b1f17b1804b1-477c1132bf2mr25241485e9.30.1763732724874; Fri, 21 Nov 2025 05:45:24 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 03/21] target/loongarch: Use little-endian variant of cpu_ldl_code() Date: Fri, 21 Nov 2025 14:44:45 +0100 Message-ID: <20251121134503.30914-4-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=philmd@linaro.org; helo=mail-ej1-x629.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, T_SPF_HELO_TEMPERROR=0.01, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763780055941018900 LoongArch instructions are always stored in little-endian order. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/loongarch/tcg/tcg_cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/loongarch/tcg/tcg_cpu.c b/target/loongarch/tcg/tcg_cpu.c index 9d077c56d9d..3f4b5f9258e 100644 --- a/target/loongarch/tcg/tcg_cpu.c +++ b/target/loongarch/tcg/tcg_cpu.c @@ -140,7 +140,7 @@ static void loongarch_cpu_do_interrupt(CPUState *cs) } =20 if (update_badinstr) { - env->CSR_BADI =3D cpu_ldl_code(env, env->pc); + env->CSR_BADI =3D cpu_ldl_le_code(env, env->pc); } =20 /* Save PLV and IE */ --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763799027; cv=none; d=zohomail.com; s=zohoarc; b=GsfgIogSFOMSiz/2yP67m1xLrVENqhfMV0eCz7t2HKcGTMGOooBf6bVR1hbrgpIDdT0M8fezVSuDxFWjFQeuh9k84DlmaWqxcCHn3y0U+KBr02mdyPq1qqhExgADUSu+pZuQqZ95PL1D9LV2LAj042OYU9WwHtbdNI0/aXAAlr0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763799027; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=q/LNyvQG4XVC2EIShm261QCUAXye4D5qWj6DTyVXrjE=; b=cONMuEDe1vLZWMjKFcSVePRgdFUUYPklr4t57WQj6FubeE1AzqS23ijDzOVcJ61FsRJLQmoRQiaYvc6i+cw2PgIAob1JrnWsMPJPCwWfmtnq0tamMhyP5ekc+XDgyQyMO47TqAcv2tfSa8GmmWOxA7COZjwB2NO6TYcAFfDXXgU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763799027640496.4738364723571; Sat, 22 Nov 2025 00:10:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMcnY-0003hE-EV; Fri, 21 Nov 2025 20:52:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMbah-0002O1-RC for qemu-devel@nongnu.org; Fri, 21 Nov 2025 19:35:04 -0500 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMbaW-0005YG-Ig for qemu-devel@nongnu.org; Fri, 21 Nov 2025 19:35:01 -0500 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-37a33f49018so22313761fa.2 for ; Fri, 21 Nov 2025 16:34:35 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf3b4fafsm46361865e9.14.2025.11.21.05.45.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:45:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763771671; x=1764376471; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q/LNyvQG4XVC2EIShm261QCUAXye4D5qWj6DTyVXrjE=; b=t7m3NKUZjxoBpuMLDt+hBbUgRB3c6vsUK2ycdFvjrwGw7gEtLkl3iGQGBJIH9c+vdU nyE/AAsgfizFag1ouNHsw4IBBndUyXFqjbqOzfO1ZGHxdY6jiP98unsbVuxjLYOL0lMz /20tXq93ZNNPSeClDsSTaCMOFPA/u0TrbsUwis7jqF28PD0MMYij64vYcKrxW83cxMeX RZ9rePLy2pPg+O2FEGzOe33OixMN3yFAeJMfiHO55jm6aC3AZ2z0BCVq8IHQSl0JaH0i 8D1DyHmdCJ62w8Z450SfLrBK+2toiD9O4fAxcERQXIcnwLVsB4+FqC6AxUdHJGdG0use Szcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763771671; x=1764376471; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=q/LNyvQG4XVC2EIShm261QCUAXye4D5qWj6DTyVXrjE=; b=QdFjM51jYbg1KIn/wMR7HKGZ6dBvXdCPvoYYhWPsjFsDaG5kvad+GjmJyz59fTRNXH 2F7mCohnuunBuTq+rZmX+7RXxaChki4UxIiKOBs4o/vkQ8ozGLGW09fCYxHhAtWcGqvm O6TmIyl3gW/AmkT5Qe/omD8D+UR6Y1PCkY0YHPq/hOgeDCt0vRu/C3zd217m9oEkApjw cyfej0arAIPD5F3DGpv/2A+C78CvsKMQJQj4AkPlDWsuJ0TET1cE91X7wZq9P3OUa3u0 Q4mrBj3zTnf/rtkS9zcSZovAJouHQ6DIjY7BRR8/HVNQFVXINy0SQ/p+sbUailKrHTvE 8pOg== X-Gm-Message-State: AOJu0YwKgijlMHvZdJuFmZxJ0AUipJIKPZjSs4OLtWaDSyEFLk9Fjxbr Jbsv+oDuSQnxgP2PN1bCsMdr3v4d9lFBcheOfOM0M06uzqu8DJMkS1RusfuYHBJt8KuWJw3zeVd kHiI7Beuxdg== X-Gm-Gg: ASbGncsWVfEDbl/cb7mpeuv3GobBnvDJK3AdpxS0fV+MTrgp2fDx7k0E+7LZqdMBjqS TgupPRO66hdbOpmoKG8JoQPj2MdvbYdpr2P0PVZEzHiBWRWzmhbhD7p3UuZYEplkv47HI/vJHXw fSwrufEXm5k6rtSXn99sQqtvwnGR4St5U0QiIxPOg0yeZJer3f/ny1JBJ5+96YnrR9Uoz/tnbFa vV4v3qpwiRmN+cz/uMjpwsIMMMkNisf3I+OMr3wBmyXQFV/z4COQUJma3KZA5w7a1QGYRgpmVoN CkI43f17saUh0gUMQ3XqkPWdCd5yltOhlxRHoZEL6mJwASrG0Ov/fFaGhfGUE1y7Hgc62LcvdTM ozdP2PsreuA6isBvvaJ/oKxhPJGXv8s1isNBBhVRCIQ8QukE1HGD5OvFcnFcn5+Nw0OiJn05le8 h/81zKNaZbw2mHPG6SY0IG02jBYMw0dxZQHi/UfnIRaXieMWNuKO16/T5aANUr X-Google-Smtp-Source: AGHT+IHi2XGY1TFl9wA1rCtz+bEe5WEfPewQzhXmx5u8D2IE8b9YHW2sB3qoaedzS00kIvOYQaqrpQ== X-Received: by 2002:a05:600c:3111:b0:477:b734:8c53 with SMTP id 5b1f17b1804b1-477c10deffamr25063045e9.12.1763732731485; Fri, 21 Nov 2025 05:45:31 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 04/21] target/sparc: Use big-endian variant of cpu_ldl_code() Date: Fri, 21 Nov 2025 14:44:46 +0100 Message-ID: <20251121134503.30914-5-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::232; envelope-from=philmd@linaro.org; helo=mail-lj1-x232.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763799030025018900 SPARC instructions are always stored in big-endian order. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/int32_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sparc/int32_helper.c b/target/sparc/int32_helper.c index b29f693a6bf..a777d17a01c 100644 --- a/target/sparc/int32_helper.c +++ b/target/sparc/int32_helper.c @@ -151,7 +151,7 @@ void sparc_cpu_do_interrupt(CPUState *cs) if (!env->fsr_qne) { env->fsr_qne =3D FSR_QNE; env->fq.s.addr =3D env->pc; - env->fq.s.insn =3D cpu_ldl_code(env, env->pc); + env->fq.s.insn =3D cpu_ldl_be_code(env, env->pc); } env->pc =3D env->npc; env->npc =3D env->npc + 4; --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763785319419803.3182893966359; Fri, 21 Nov 2025 20:21:59 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMcya-0003oZ-D6; Fri, 21 Nov 2025 21:03:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMc7P-00056E-Kc for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:08:51 -0500 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMc7F-000403-3c for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:08:48 -0500 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-b735b7326e5so632950066b.0 for ; Fri, 21 Nov 2025 17:08:24 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477a9deb126sm84952915e9.9.2025.11.21.05.45.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:45:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763773698; x=1764378498; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dSqacx8J6/zgtlp2PptQ1lYmcrsegZl83a7tVHbquyY=; b=PMBG1EX8lEomnpRnx2+EoHi6IquUJW0C4tUYBmTO0rRiHsZnEBd3btlZ5DYfJFUQCG DiRpNkVIS4vrsQLTZfCQDMhw/MGzqagGgtOne+pCHJrgMi3Lm2ZZmvCA1ifznu+kuYod vq+qHLvhdVhTqiFPUXnGmE1SKZnjW2gpAU8BvFdNm4pTqjKmUBc56glnuqSeY0+OUXGr myElEdIdkwGeSV9yDkdvmdBwLV0rw8/kSibozLVW/lv0r1Bjqh8xNYFICdH5cKnxZCA6 g91FcfbEARERatp3TmKt8p9IXtjGkz5MSE8ccJ0EFFLfgYu+5Ds5sYmlqcnqFBg4/WZM 6New== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763773698; x=1764378498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dSqacx8J6/zgtlp2PptQ1lYmcrsegZl83a7tVHbquyY=; b=Wz5J5bmI5OFrEkPvDnno4SkZvM1/WJjZg7K9m3f1LfPezFUdjL7oH+gYj02WuFrNNu 1gmhSmhqEPVxVfQaCE7Rb1s47OouAvI5cAaJFEO+qYgg6g3R7+poexKLh6YuEgQgMuyJ 4jGltLLF4+otxQ6Az/YCNcvtrxSYbNA4FptBpbBPXNa15uxvUiV//bHSgP5ZkVRX3Dh3 0+P+Zbwyjkp1lrQlJC3sOQf+MBSWmSXw57jfu6uNCIusE2P3XbJo+O1UtnfKPivYBhrM usx1/c2pBPIog1yGM4Cus0HuTBBGAc6YCkgsEhL53Dsem8NUU4D4DDzKDrLulmwYVYSt Fctg== X-Gm-Message-State: AOJu0YxST1e0rc3PYh49ePol5SeRb+Aam+YZf1bwcH4D7eixCHJxolF6 JyyfU6Ks1Wf7eKoDLUTEMO3MBQurECFhSourIbViY/JCgQU452/othLlFvAEPKc2QOcObVRjYvd 7JEy6gydMMg== X-Gm-Gg: ASbGnct5QNQo5u7c8y8CPajKjUXViXDksLQOqGhm37CF1X68IpNNen+SLVi59YdvOXe ORj9xOY0MonMaTfuqCenvgvsvhPMTXlX0jUtKNCdzO9KFZODMeOjuLgHLjxCT+E9quoDctTvXcT sTFe6MnoJZlil3jbskmHqvSfsAvMwqGzgbih0d9DSpI2iAK1lqvnNLE9VBANm1sQIT2Ox20fano vA2D/PW7Ft9qxgC/KlF2iNdRe87zAO68qJseP3cvKEoJExkWHdCPAmWjmHAw5ZQMQKw//6fE0Sk 758LFdzRUqcxLOpcbfAp0x7/YDHYACgLTysHw4DDp9DcvDa/sf4ubBe2BSw5HmfkwmjuTt0KKdk QzY3H72oFgBcY0ccZKsGuM1nYR8JPfPjcTGOBBB3xSzig1cQp+GuCluxNc0ny9RnxbpWgv+dwHs YexrEYhntNY7PtHvkoq5KuAiHcZp+CnKoJ1EYMsTeKLigTeqOb/Y2fkrv3wska X-Google-Smtp-Source: AGHT+IG2LBpzN/7MutT6FD1rJI5Vj5/7zy760hif3q1afu5JBf0/MDhD9wPBUQFy3NBz/75gXvtlLA== X-Received: by 2002:a05:600c:35c6:b0:477:a219:cdc3 with SMTP id 5b1f17b1804b1-477c0513e47mr31299105e9.12.1763732739098; Fri, 21 Nov 2025 05:45:39 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 05/21] target/s390x: Use big-endian variant of cpu_ld{uw, l}_code() Date: Fri, 21 Nov 2025 14:44:47 +0100 Message-ID: <20251121134503.30914-6-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=philmd@linaro.org; helo=mail-ej1-x62e.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1763785321379018900 S390x instructions are always stored in big-endian order. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/s390x/tcg/mem_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c index 24675fc818d..84d901c2008 100644 --- a/target/s390x/tcg/mem_helper.c +++ b/target/s390x/tcg/mem_helper.c @@ -2437,7 +2437,7 @@ void HELPER(ex)(CPUS390XState *env, uint32_t ilen, ui= nt64_t r1, uint64_t addr) tcg_s390_program_interrupt(env, PGM_SPECIFICATION, GETPC()); } =20 - insn =3D cpu_lduw_code(env, addr); + insn =3D cpu_lduw_be_code(env, addr); opc =3D insn >> 8; =20 /* Or in the contents of R1[56:63]. */ @@ -2449,10 +2449,10 @@ void HELPER(ex)(CPUS390XState *env, uint32_t ilen, = uint64_t r1, uint64_t addr) case 2: break; case 4: - insn |=3D (uint64_t)cpu_lduw_code(env, addr + 2) << 32; + insn |=3D (uint64_t)cpu_lduw_be_code(env, addr + 2) << 32; break; case 6: - insn |=3D (uint64_t)(uint32_t)cpu_ldl_code(env, addr + 2) << 16; + insn |=3D (uint64_t)(uint32_t)cpu_ldl_be_code(env, addr + 2) << 16; break; default: g_assert_not_reached(); --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763787548420817.5154585134236; Fri, 21 Nov 2025 20:59:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMd27-0001Ha-7T; Fri, 21 Nov 2025 21:07:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMcbX-00048y-9B for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:40:00 -0500 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMcZV-0002lN-MN for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:39:57 -0500 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-b73a9592fb8so556322866b.1 for ; Fri, 21 Nov 2025 17:37:37 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fa41d2sm10946251f8f.22.2025.11.21.05.45.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:45:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763775452; x=1764380252; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gX9jGmeu+KwJPxY0MI+9o8DmOfeDSzlJfBVH4f7ccoo=; b=mtycuAHV+Zz8F+oM2KomidNA5iFwvYiUIRV/tW3h3CpTu3xcuVun1j7Z8DOtenoQLX XvZ/YNEedT+vGuuzAcjyAZWRqeLEdeFvSikKkD3fc2Ky6yGNUYs5zPJRYL8vodBXTfpA cQjwfTeRW5fm+LXIPSYU7Idc6rJokxwZUab13fFlZinItuJMoYK5PvOBMyS+xExg3g0W fnwFOwJxOwK6OL9rotEJmd1/8soFPvgfQnhqR1jKDQUAB/AV9OUtA5FQBfPjkQMfRADT LbPVW2KKckf4KYVL/A7aE4ad6zBOjnXa+3Dhna4M++fZWTuWVheoWSXcoqrIb4Uo2PhO gNKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763775452; x=1764380252; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gX9jGmeu+KwJPxY0MI+9o8DmOfeDSzlJfBVH4f7ccoo=; b=dbxgMJGxpdEaho6BN9rU4XdI5qgDeGF6cppDROiI2FcjteUv0A3o2j3qrpYW9eosAe uJErgYTYHytX5QNvo/cVZp8SuP6tx7nlFAfk8d1Bt+cwJ0kOEYGNkETztdTni1sLrQao Vf3DiA4tW4zI6ngz6L9pq2cjkLndIBN3MsCLD5YxFC1Vh89GFos+v2984ok0Z68SgabK r868Riv229/0dxcS9BN5/PgFbQLMZFkE+QL/yGtXlakmrmSYevfduQGGqZhpUTDKaxge VT0AA9VJOzCugiuNRE2Myie5rvzEK2Qfv8xxeTtNoyQ4DWFPqkISwdxQuLILdrLDpixH xNdQ== X-Gm-Message-State: AOJu0YwDfMfhOTGHYk142imDHFWkgALjT9f0p0M/TW+1SOVcsUWUn1pi zcfGBsnUTqExOF0CH7I5Nhf8YdV+YCqbXyD0bI8uPk3L/NqNmJ+Ql96etzm3SpABsZt9OTH0pjr xt3heNT4pqQ== X-Gm-Gg: ASbGncs4AHoibf/XaGVLHjL/lJJ7NZrH2LoNe9MEvwEtYFPbVR51rcdNDRFHIUIqogS Re9lS8/TzpRrq3WnxEWBr/m7VqVu/HoZigKmvpPew8ehOzIU1qLH7Phb4EA1OcWqNDxg47iNJIy 9aUlBNmc/AF2FXoORMxKgH1wXzKOGZr6D898NWR/zp8pXHVZTthVqA/uJarzGoLFK+hDiYFTPQo 3BQayMxlJWP3fXMpmci12lz5x+C8Zp6bLXpnhakJW1pTLv9yfyfsYYQUGb0pyg3Hiak2LpWtfXI TbLLNuY3OGM8gpKhRWK9LKhbHxn7XHyeYJTdUk6Je2GeqEKOgfutjGbtn5C1K/G26xUjAQ7CDcq unNtWRnZVIydIkjpswWz7RE/5f4sUwlSldLCe+tRsOdh+esrXW5SktV/DM9j+6v1o+n7X/Eeb9Y 54klCcGqBFjN2EYMWe4+fegfwRdmhDweoT00HgbSxUxTKPHcgdE5S5RvjkBky2 X-Google-Smtp-Source: AGHT+IFOH4LNpKae+OXXzyYpeXqAhEmkuW3HbrrPigIx2IrcfACRtYTQr9+u6IbBTF8irO0fqbXFBA== X-Received: by 2002:a05:6000:288b:b0:426:fb27:974a with SMTP id ffacd0b85a97d-42cba7c4cc9mr7182956f8f.27.1763732745859; Fri, 21 Nov 2025 05:45:45 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 06/21] target/riscv: Use little-endian variant of cpu_ld{l, q}_code() Date: Fri, 21 Nov 2025 14:44:48 +0100 Message-ID: <20251121134503.30914-7-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=philmd@linaro.org; helo=mail-ej1-x634.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1763787550369018901 RISC-V instructions are always stored in little-endian order (see "Volume I: RISC-V Unprivileged ISA" document, chapter 'Instruction Encoding Spaces and Prefixes': "instruction fetch in RISC-V is little-endian"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/riscv/translate.c | 2 +- target/riscv/zce_helper.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index e1f4dc5ffd0..847481a9b41 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -1182,7 +1182,7 @@ static uint32_t opcode_at(DisasContextBase *dcbase, t= arget_ulong pc) CPUState *cpu =3D ctx->cs; CPURISCVState *env =3D cpu_env(cpu); =20 - return cpu_ldl_code(env, pc); + return cpu_ldl_le_code(env, pc); } =20 #define SS_MMU_INDEX(ctx) (ctx->mem_idx | MMU_IDX_SS_WRITE) diff --git a/target/riscv/zce_helper.c b/target/riscv/zce_helper.c index 55221f5f375..992e2f964e0 100644 --- a/target/riscv/zce_helper.c +++ b/target/riscv/zce_helper.c @@ -44,10 +44,10 @@ target_ulong HELPER(cm_jalt)(CPURISCVState *env, uint32= _t index) =20 if (xlen =3D=3D 32) { t0 =3D base + (index << 2); - target =3D cpu_ldl_code(env, t0); + target =3D cpu_ldl_le_code(env, t0); } else { t0 =3D base + (index << 3); - target =3D cpu_ldq_code(env, t0); + target =3D cpu_ldq_le_code(env, t0); } =20 return target & ~0x1; --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763783522; cv=none; d=zohomail.com; s=zohoarc; b=DdO75ZqRskeyVa6Ah88rnyuniTQTiiPkw8TWxXxc0p6nBIKvH7xuNuCoPLpss/vihyYBejpxowkrx+PSIwr6BW8LHR0UCMR1z6+GorwJ69RtACxe1OwpycfS1OSUaI+pcwX+Z+xXyZU3DzaiRVvZ8poPoiIwqjNSRB8UfBy9L6c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763783522; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Fq19cbHx1urHYB7WgX1thdWAR2rwXrisZPcOy65hifc=; b=ST5x/YimLuqZai6IN2s6dJxU6VFf8QoNVJG4LRduHczqnjcSkhqaS8ZPAQIPwT8V6vS/ru+nEZPV5RDOPw6zP7C5OEwyXmU4kSufg9dERrpGjUXVeY7bFRV7X5+EB8RiaO37ws3nzDTp3MJRdE+QOiTnCSHuu5kPBReZO0PqCco= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763783522414694.4237651227699; Fri, 21 Nov 2025 19:52:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMd4u-00034C-5Z; Fri, 21 Nov 2025 21:10:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMcoZ-0004c7-ER for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:53:27 -0500 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMcmX-00061N-S1 for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:53:24 -0500 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-b728a43e410so476360966b.1 for ; Fri, 21 Nov 2025 17:51:05 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fa3a76sm11017266f8f.24.2025.11.21.05.45.51 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:45:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763776259; x=1764381059; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fq19cbHx1urHYB7WgX1thdWAR2rwXrisZPcOy65hifc=; b=CXTXrC03rOGdUjmC4vE1dPAaL4l+wKMr5Jd92rM60YVAFNblM7f5Pr/juvB5RPA6lp Q4pNe8tiQXbBEi0CwAEWIK8YIY1DhpbCwOuU4ti1PlrTurHzTdwYJB72D+qgHvV4IrUu Mg+SJeC2CPYi0VHiieMnvraCR6GAnLWA+hTbPhUv3shsx+oFw54KF0mdefnTBL1g2/uy b2e+JZwcjBOrsOMAWH5ithZyI9BKLS0C5V/VTggwrtTq/ZcUuhUESMXKCC8KZkcHOWPD 1JEbfzxGr2co6Ak2a2i3FB7udzyTYjO5rAKcPyC6tzC/aIvlRsWJOAfxaByzY1pGaGr2 JxAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763776259; x=1764381059; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Fq19cbHx1urHYB7WgX1thdWAR2rwXrisZPcOy65hifc=; b=E4yPCKNoQuoRcQoFCwOySxHp84i1IG+Yw4JG7YspAfeHZojIkH9F0W68pt/1KqSF1y PYKq2W5/XlQzLZhSoCp43h/hiRqxzkNfYBpH2x6RUo8x3wIScGmi06VPBM7BKQtnT2/x 3d/VEchycGOX8bFS5K96yufgb2uBomA1Uj0WZof3lgmaRG1SnN3OMFTeeOw+sIg8wNZ1 DoA5Stb4azW4DpGbXsS7Lrxkzi3m2lA5zbJ4VaXb+XWMndqxSQNX76DvVfQV2qSZjiGH 8EQ7mzpEkLQvIlKgL5guFOMmjguRg66BwpshxtmjqYnn8t50N510XLRHSpUkY3jcofAc rZ6g== X-Gm-Message-State: AOJu0YwvscoBub++rHLTQ1E1k2QPGf3RkUVyra3pEVDe959F3FemEwh3 VkTa81PDZ1qcg0n49Dg4lS6CxNW9CPaZXsBigc3cMJekTK2quU8acJIGUVQDu0nDVCApKk7MDKb I4OAMum6bUQ== X-Gm-Gg: ASbGncvQzg7bBVWdbTcyWu383iu3i9UGaAiX9/LaBOEzdJEs51pUDVhf1opJMMCcJkb iJ9i36YMJz7PJwjlfq5uXkOmvfQfsQs6KmyccxH1+POdEwAOs9jEWpVeskYmv1M82ok2ehC/2Tc 7TCZ8D1iZPj8W42AVVgv/AZJqn+I4SGk7crtJUEcANl0lhzQEkw7OG2VBOaYO6+Ds0CdFqlOKUp T3WCoXQo9e53YGoavpLeFbupYmqigBbxDHVJf6v/1LPq6y1sODkRePpma85GN3KAijEQfaJcU5e 70j9QAD3JnnuPhL2bmxsV5vCa046ucuhp6mml7sz2NIVi7QUQ1mGrGqiDhyj/BoNk6iKoRYfAys dDeQ9i8ZTxEqWdJLlcbELvZ+JNBqbbtcZl0TUsh8UG0THWc8YUZM/q9sp1NiBq7dHd70p2CqEKh HxpGMH2lUXudteNa04NoUrNkxKpTDteRnP9G0u6F89joriRnFXpnMEZMyIZFeC X-Google-Smtp-Source: AGHT+IFNOpsJhQzQPin1axIEEtvxDd8MYGAjtHV1dNpSExkzS4tkHFNwrMPxw8oYK/UwOJeSPwDpOg== X-Received: by 2002:a05:6000:2281:b0:42b:2e1c:6341 with SMTP id ffacd0b85a97d-42cc1abe28bmr2632465f8f.9.1763732752391; Fri, 21 Nov 2025 05:45:52 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 07/21] target/ppc: Replace cpu_ldl_code() by explicit endianness variants Date: Fri, 21 Nov 2025 14:44:49 +0100 Message-ID: <20251121134503.30914-8-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=philmd@linaro.org; helo=mail-ej1-x62d.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763783523317018900 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/tcg-excp_helper.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/target/ppc/tcg-excp_helper.c b/target/ppc/tcg-excp_helper.c index edecfb85725..b2d36ab11b1 100644 --- a/target/ppc/tcg-excp_helper.c +++ b/target/ppc/tcg-excp_helper.c @@ -424,22 +424,10 @@ G_NORETURN void powerpc_checkstop(CPUPPCState *env, c= onst char *reason) cpu_loop_exit_noexc(cs); } =20 -/* Return true iff byteswap is needed to load instruction */ -static inline bool insn_need_byteswap(CPUArchState *env) -{ - /* SYSTEM builds TARGET_BIG_ENDIAN. Need to swap when MSR[LE] is set */ - return !!(env->msr & ((target_ulong)1 << MSR_LE)); -} - uint32_t ppc_ldl_code(CPUArchState *env, target_ulong addr) { - uint32_t insn =3D cpu_ldl_code(env, addr); - - if (insn_need_byteswap(env)) { - insn =3D bswap32(insn); - } - - return insn; + return FIELD_EX64(env->msr, MSR, LE) ? cpu_ldl_le_code(env, addr) + : cpu_ldl_be_code(env, addr); } =20 #if defined(TARGET_PPC64) --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763784503236569.5406352834732; Fri, 21 Nov 2025 20:08:23 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMcoi-0004dN-BA; Fri, 21 Nov 2025 20:53:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMbZu-0001sD-M3 for qemu-devel@nongnu.org; Fri, 21 Nov 2025 19:34:14 -0500 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMbXs-0004ru-T4 for qemu-devel@nongnu.org; Fri, 21 Nov 2025 19:34:11 -0500 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-5957f617ff0so2879582e87.2 for ; Fri, 21 Nov 2025 16:31:52 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477a9dea7fcsm87143845e9.8.2025.11.21.05.45.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763771507; x=1764376307; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PeYBDSu6cMgQceRuy5tiVH2SP+8CoWLSP+CQiGR2J0w=; b=hEZjXeTYsBIYWX5wd51UrXeaoBrNb7Uasi1ITZbdd69+MRjId1Ht6EFwrYO4+f0fOR c5TW20+k/4EaaXgFL+SapMkRTWyBhF/4M2OP4Bks52u32cTDYSuflG5vxILmKNv5Fhip RYzhLzrTID1B+JF68kmgoqweox3YoloAfKI+9AGpH68xFLj8HZNq3S3b3eC7LjxfAwev E9jHo5essNDjt0TIZdbcQDSCitVL23xufn4g684b3lGMdMdZfhGdHTzx5EHng+SPNwS6 bJOuj/w3VxmuEpLr+8HshE4UC6+HGcnB6hPG60Sjr2g476ITm/MfYypUmzLu1K3/rRLu hQWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763771507; x=1764376307; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PeYBDSu6cMgQceRuy5tiVH2SP+8CoWLSP+CQiGR2J0w=; b=Tv7xLEYrMlWXas9i/1vNbcnugjGgKCoDjJ+qA3d5nNobbTzC03u5KVDYvrp8BUrAZM ZqMdKumeIuqAoh9tOz/PN5lJEtBtsq8Fgp38xv2bx0XECMoSHp9fD5W8y+5wZRwv6bU0 HuCk4k4BjeREZV1y+Mx6slqdgGXY/qouNuA18qVWNexJIeoLZCAg5gIzetl+Ah+mDH8z 5Ygjr6+afQNrE8VCzgTthwV4ofI4Y+maQKKGZB5j/Aj0F93uC6GYi8SjVffUu5Mo5u2T 52ok9UB2f7mCpXtHF49YQfMobfpCxWg19+k+3O541uIwXrq13KSb+yfkQQJVlX8ey3VM n9hw== X-Gm-Message-State: AOJu0YwyY6Y2bqI3Z+HOXdRi9xrrIlerqy2KpCKHUaA7+VIN3E1Ayk0p EYq8+hf5oerciPPRZ4ioQbspta3iNKpymGqpuKj9RXCyizE3WlPnegQdP4JJJJj1fXJp49xFDK6 65H4YYsT0oA== X-Gm-Gg: ASbGnctidIR8FZTo3YVGVAndhaOm+i4oPxb3ZkFc3KjpgB/+9Hnuxhfch/JVb0ghkWN gzauo7LDz0Pbu0VEEMGHl4scvO4sRebosxHqxsg7V4BLleDcmhFFua35aZHC0Ts4tb+ob02v29H iE75iFAjnv/8aIcrhe1vq/JMD5pouJpYzl4CnWRz6sC8l3mKYEdsjXejMIAb04QouV5ypvjVOmH myLmXOKK8mthqKHUCrmy9LmQeDEkzvUUtp+hC2DKtst2bo/bAun4bO/RAdSl50GJptOmcIQWZHL /Pn86S6fKv9frYjIS5t583ehIoxDEZTwGe/ZiMyqwlAgaw3DM/ru/hJHrJ0+kRS0cCsnjSM184t 1+EEU5cioMgKWuRcZMiU91dOKvWn7lKIYLksFD9DcsnqgTMBOBe00LBWElswTR/ypaSTRh3Pyxk fevgx38mGR5YlhYn/2HDJzlNXHobhlqCaPd0nOiN9Li8zmYdzUxyWU+zQrVfDW X-Google-Smtp-Source: AGHT+IGOy7ijW3Saoq3tEPfafETXCLdd03s9R4J1y/0QOA7IKP9EnH8884b5OD/Z9Zvc/CZ5mAuqPw== X-Received: by 2002:a05:600c:3551:b0:471:131f:85b7 with SMTP id 5b1f17b1804b1-477c10e2bc2mr28653215e9.15.1763732758974; Fri, 21 Nov 2025 05:45:58 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 08/21] target/mips: Replace cpu_ld{uw, l}_code() by explicit endianness variants Date: Fri, 21 Nov 2025 14:44:50 +0100 Message-ID: <20251121134503.30914-9-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::12b; envelope-from=philmd@linaro.org; helo=mail-lf1-x12b.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1763784504911018900 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/system/tlb_helper.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/target/mips/tcg/system/tlb_helper.c b/target/mips/tcg/system/t= lb_helper.c index 566924b079e..415c214c5b4 100644 --- a/target/mips/tcg/system/tlb_helper.c +++ b/target/mips/tcg/system/tlb_helper.c @@ -997,18 +997,30 @@ static void set_hflags_for_handler(CPUMIPSState *env) } } =20 +static uint16_t lduw_code(CPUMIPSState *env, target_ulong addr) +{ + return mips_env_is_bigendian(env) ? cpu_lduw_be_code(env, addr) + : cpu_lduw_le_code(env, addr); +} + +static uint32_t ldl_code(CPUMIPSState *env, target_ulong addr) +{ + return mips_env_is_bigendian(env) ? cpu_ldl_be_code(env, addr) + : cpu_ldl_le_code(env, addr); +} + static inline void set_badinstr_registers(CPUMIPSState *env) { if (env->insn_flags & ISA_NANOMIPS32) { if (env->CP0_Config3 & (1 << CP0C3_BI)) { - uint32_t instr =3D (cpu_lduw_code(env, env->active_tc.PC)) << = 16; + uint32_t instr =3D (lduw_code(env, env->active_tc.PC)) << 16; if ((instr & 0x10000000) =3D=3D 0) { - instr |=3D cpu_lduw_code(env, env->active_tc.PC + 2); + instr |=3D lduw_code(env, env->active_tc.PC + 2); } env->CP0_BadInstr =3D instr; =20 if ((instr & 0xFC000000) =3D=3D 0x60000000) { - instr =3D cpu_lduw_code(env, env->active_tc.PC + 4) << 16; + instr =3D lduw_code(env, env->active_tc.PC + 4) << 16; env->CP0_BadInstrX =3D instr; } } @@ -1020,11 +1032,11 @@ static inline void set_badinstr_registers(CPUMIPSSt= ate *env) return; } if (env->CP0_Config3 & (1 << CP0C3_BI)) { - env->CP0_BadInstr =3D cpu_ldl_code(env, env->active_tc.PC); + env->CP0_BadInstr =3D ldl_code(env, env->active_tc.PC); } if ((env->CP0_Config3 & (1 << CP0C3_BP)) && (env->hflags & MIPS_HFLAG_BMASK)) { - env->CP0_BadInstrP =3D cpu_ldl_code(env, env->active_tc.PC - 4); + env->CP0_BadInstrP =3D ldl_code(env, env->active_tc.PC - 4); } } =20 --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763782094; cv=none; d=zohomail.com; s=zohoarc; b=ndBwCeOllXjRootYwleTolvYwKU9JsCqPlnaxjsFKlb2dWV4nNYZQmDiGc5u/HIodm45ATey28M7sOIFCQybKhxh6vjCTv6W76bsmx1Xy7QkltSFNid5PRVccRYIGy5C/rcPTEwxVq5W7UGs1DKyPF1Sm9X1gSCpki8yGq4tlXc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763782094; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uhfSYXVJhQzgILc5n4xlE7EXEuT5rMWIJU0DyKOMRY4=; b=nAqM8WRCmrOtsfGuWrylbBtZwXA2/qR5NDe2s1tQIvvdMEI79YVf0AgnqDeNHO6mXCKnkcEQZQ5iY9vY2VtuCj1PFmsZVG5SYEa/3lJED1G7OB30mVa6lgwJmyGs9JlGSh2IwHs7LJ3zRKVYH8xb9xG1QR0u7CDnKEGyr/wTixQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763782094595931.4929682109224; Fri, 21 Nov 2025 19:28:14 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMcyW-0003oP-LW; Fri, 21 Nov 2025 21:03:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMcEj-0000hp-AE for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:16:25 -0500 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMcCg-0005Od-Pv for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:16:22 -0500 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-5957753e0efso2719032e87.1 for ; Fri, 21 Nov 2025 17:14:02 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f363b0sm11300121f8f.13.2025.11.21.05.46.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763774038; x=1764378838; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uhfSYXVJhQzgILc5n4xlE7EXEuT5rMWIJU0DyKOMRY4=; b=NNVHAkhjeb0h/OkeoYwLM13Kids/cCBIwTY/9Cp4VNyEGXSBqNfV8QmJa4bS5LkV0T PHEVCYk+q7whWTA4+ZLNkblmzidj+bGQnWxSeywK11utQHr39YVzX3GLtrfKpK+r1Jux PQe5/eAj75pNbt88s43psvnvEAJpZ2R5nnX3t5Fk2jhGkGdbFZKvIzMJIXxZQcMtq9z4 5ytm0Ox1zd9caoBMps0zjQSgV6VGbsvbMHR+kjFAUdKFQkNpmwoFZTgbS6+Yn3cGZyeT KNqNIKiA8VKPzie2zzMSdG+2DRCaVBZb+wBlmzBAfk46ebr1zYEgFAtl8CmyRnvg5hua X/nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763774038; x=1764378838; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uhfSYXVJhQzgILc5n4xlE7EXEuT5rMWIJU0DyKOMRY4=; b=V4QbBhTg6p6q48nNjcJIpS1VBrPXYhiCLrJlY9sHHTojX1yxQCYJ4p89PU2SvOAI8e 2RjTaU5cCI+R9UgvEsV0Gl09XbicsxP72241v9f4hEQaRWxmPdkWDLxeSlbCoXNEovRI asJPCtKLtlQsE2hmrE0+fG+YGCvx0DfcEcqT4gG2Agj0h6AERhJt0W+E4Pvahooq9vJK YPc+PImnUQP+gYmswQ/Mx9g0q0DHbg/+MCEn1FZcPkS83xeWnKmvPdoJNSxqp2+BEaYH jkolZoE4e53OizWdaQZzt8lO02EYOAvqIqtnN8AHRFP/D8s65vKP5yh1PfpstAhCOO1R U2gQ== X-Gm-Message-State: AOJu0Yyy0RAD6rhc8Di3MN6XEFSG9NQUCFcoRzdZkiOVqvyF4909eXdm 8QrYD23352Z3xkYVAUgxQzIOpmjNwbUe8PRuYocwt7ZintSpxvOmNMcFiRYVPljm8OLm4dV4JoP rcSzyNPlfWg== X-Gm-Gg: ASbGncsTCsdyKmBurNAurOF1aDczAYIgxVujBwNB4WRLvHSUBhk7tbzpIvR2Z1WB46x GCFMCRQIKokMcFPI84c7e+BEbrq3zZuEHE5XInfuebb5Ga5/Ar8uDk3kMsGwdXHQW0b+/2ILnSQ qrmmHzZKqvxz5kI4VdfsTTTq/STszUw0buLYtbtJBEKfJc7Q0+Dg2aBfPrKtftNilEkHAymIsLj ze7OhC/MPCH2xMKzDlGD80t4j9bW/o52lH4IpBo6go0Bw1sIfq5yq+UV4VRcvVd049BrFxK2KDz tAWuxhs+QzU9T5k2Xm187b516MyOGI3DS6gk1nJ5dTXKpgihAsrg3H6xA8V1MNmE+pTxf6IBeRI RBRyCe3bfJrIaJlLJxTAMX5f0s6aFeRt/dVCKr+mpBD3vG1BMWFbwFnVpyJV1MLg8CqBrNkF3w1 YEIuvNhRWtipAsYmYo4k+GqV0Na/6vtCDOGekUYSdfhK4bMUGusMvsYonnVuDC X-Google-Smtp-Source: AGHT+IG/b8TxL9CJ2yGrfcKCr8xr6tIWI9/kBLmY8vXlUe3LRE9WTL5vE8m0zohVGp43fgT2y8tBkg== X-Received: by 2002:a05:6000:240b:b0:42b:396e:27fd with SMTP id ffacd0b85a97d-42cc1d2d44emr2576757f8f.38.1763732765605; Fri, 21 Nov 2025 05:46:05 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 09/21] accel/tcg: Remove non-explicit endian cpu_ld*_code() helpers Date: Fri, 21 Nov 2025 14:44:51 +0100 Message-ID: <20251121134503.30914-10-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::12c; envelope-from=philmd@linaro.org; helo=mail-lf1-x12c.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763782095113018900 All uses were converted to the explicit cpu_ld*_{be,le}_code() helpers, no need for the non-explicit versions anymore. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/accel/tcg/cpu-ldst.h | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/include/accel/tcg/cpu-ldst.h b/include/accel/tcg/cpu-ldst.h index e4ec4e7d367..a3125fc9026 100644 --- a/include/accel/tcg/cpu-ldst.h +++ b/include/accel/tcg/cpu-ldst.h @@ -523,14 +523,4 @@ static inline uint64_t cpu_ldq_be_code(CPUArchState *e= nv, abi_ptr addr) return cpu_ldq_code_mmu(env, addr, oi, 0); } =20 -#if TARGET_BIG_ENDIAN -# define cpu_lduw_code cpu_lduw_be_code -# define cpu_ldl_code cpu_ldl_be_code -# define cpu_ldq_code cpu_ldq_be_code -#else -# define cpu_lduw_code cpu_lduw_le_code -# define cpu_ldl_code cpu_ldl_le_code -# define cpu_ldq_code cpu_ldq_le_code -#endif - #endif /* ACCEL_TCG_CPU_LDST_H */ --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763798143; cv=none; d=zohomail.com; s=zohoarc; b=KJa9bJ05VIpaWYEJNgUFNBNrTpfaEIz4O2uqPrJZ9vIil63TM7hypEnyiAkD4/W8FfQJx8fmXbxoHHgbzYcwkhGbMn/DJvdUhK9LWOxGrKG0//AdxscB3CPXFPuUfPQ+zukVyoFzfsp2yq6Lre7/k3DoqLyTp37gL0qjg7g4S1w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763798143; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vESko8GQ2ceP2oMkbBNKvzIYyYx9GKCYINNyOwGklUg=; b=PxTD/q2VQN+QV7coH9pcBO2C9I3K8llQtCzmxNvDINYR7IxIJqJcCXrQWSLmwwO+ZgLYkvEykZG/PhFKNxqlvdMtVx8UX/hewsM6Dqjra/5oUfGPy6AsyOMLISk7HYkTO+sXfq2UFJmqjfBhQz4TBt5e1z78rJt31sn9QA9tUMU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763798143583996.8299658318122; Fri, 21 Nov 2025 23:55:43 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMd18-0000kG-9A; Fri, 21 Nov 2025 21:06:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMcUc-0000ab-DA for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:32:50 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMcSZ-0001Ep-2H for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:32:45 -0500 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-6431b0a1948so4387126a12.3 for ; Fri, 21 Nov 2025 17:30:24 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf3af0e1sm42006415e9.10.2025.11.21.05.46.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:46:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763775018; x=1764379818; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vESko8GQ2ceP2oMkbBNKvzIYyYx9GKCYINNyOwGklUg=; b=yQLHSJ9VSbXQSo+w+5sEEmjcZ+oCtFAwyF8hSCdY9DmduJ3epsj1etdoVs6a9XZ19X 8F+yVtqm7B8M6wc9N5KMIVy3OoYI1pb+eHamSD2Um2Vu2UuT0vB/J6kOMFQ/aN00iZOd qI+s85vD07amoh4uMWJ4OJf1rX7TL4rpaOcq3154mFxE0UhmSS51DcX5ZNCfDryMfLhT CJrlUJpIEkc62C+QLRt0AsqMMS1MStr8et6ulVIOW/eUvH+dJ7lcCxb7zDQeMIMM5gZd S3hW4S5Snd+xDB1D/0qJ4argbQbLJaS5niyaF9pbA1C9Mb/p3oW4GHVjhCXDvshIU1di 48xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763775018; x=1764379818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vESko8GQ2ceP2oMkbBNKvzIYyYx9GKCYINNyOwGklUg=; b=Or3/zbum+A6ZMyENhpWVM9ht/46GBR4DZKcF2pYywuI9oAgDulVXnDrjpRDlWvd/a1 oUZ1yABzQNfo7d9+ESVagm3fDSgiTVp32OMjUzrLSa6m8zsOolKxU8zobaki4FPjdlNE CLxQuLBthnJhsGwfNHEaMk4kILVs7kpHIB+n5DQo2CjZ9tE7XKLNcjZru0vm7+wmKgaB 0f8FRFKq0jE3jdd8+RkSztNFka+cF6cHEFtnaPabGbovJaF6C7R1KvYNqIK4BiZcsPQx QjCoI5CQwzinLNFFP2yCNqD/+DuBerZ5zOmwbrWmToBsdL5q320nbEqQziwwardl4bS0 YDRw== X-Gm-Message-State: AOJu0Yxo7mCwB0XT2uAKLUQGDNA8vqeI5uvpN4nGWlGxLV5QZeL50zFx +YE5cDM8/B5G9MIS3rKZ2QgQfd/ydVtoEIiogUt/9ZexKfYycs3z03lelHKaK9FoFjcRN2OltsK mgJWoCQy2Bw== X-Gm-Gg: ASbGncsrc2iWrTcdr0YudGTBhmwRkjfn9sllW8lujpJnzcC2jJwkJIuecdyIu114vem p/GBZseFbGCRXuXe3v4VrG/XCZrEUA1u1d4JgYUv4tCEa57rqHAyrvx/tDzDRPj7Z51JCBErzxY r3NDbmPrQv4pwZEz9eUfL3tLPg0oW1scJ0Ek4j1oXA89tHj6vw1qgqVtJVrN6MgkXZMNl9tvud8 AOWKCyVbW9ovZeM5TD9SKBlmCzl4CJ1X+gRN7N20DJW87sPs+GkUm10LQcZJpR0a+N3wUESEBTE vh46CD4YJRaxkuEwffjs2gOrHhUjzxvRXJdfhg2w0HwYvB2+fvXysKMv9aMN6QbmzK6j6jb/Naj zO599V/gVXG4RA8hzDBbr76g6i5GIVtdjiSeIl/ngzLGNDzrvSmBA2VG3dVi1Eap46slQ5qC/8k xHfZhS3QROUCIH0NnZI83D9lkJATiO1HOw51k2Y0S7Sdt9WB5feTyXE4q0op0w X-Google-Smtp-Source: AGHT+IGHTqgyl1vrXL3wcw+ANlMLiuuycekcVyYOBzjuSrK6eO43371ZUi+5CO6J8ZKFoSmLyQgWag== X-Received: by 2002:a05:600c:4f83:b0:45d:e28c:875a with SMTP id 5b1f17b1804b1-477c01fb88cmr27959155e9.31.1763732772260; Fri, 21 Nov 2025 05:46:12 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 10/21] target/hexagon: Use little-endian variant of cpu_ld/st_data*() Date: Fri, 21 Nov 2025 14:44:52 +0100 Message-ID: <20251121134503.30914-11-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=philmd@linaro.org; helo=mail-ed1-x531.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763798145108018900 We only build the Hexagon target using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Dhexagon; \ end=3Dle; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Brian Cain --- target/hexagon/macros.h | 6 +++--- target/hexagon/op_helper.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h index 088e5961ab7..6c2862a2320 100644 --- a/target/hexagon/macros.h +++ b/target/hexagon/macros.h @@ -519,9 +519,9 @@ static inline TCGv gen_read_ireg(TCGv result, TCGv val,= int shift) #define fLOAD(NUM, SIZE, SIGN, EA, DST) MEM_LOAD##SIZE##SIGN(DST, EA) #else #define MEM_LOAD1 cpu_ldub_data_ra -#define MEM_LOAD2 cpu_lduw_data_ra -#define MEM_LOAD4 cpu_ldl_data_ra -#define MEM_LOAD8 cpu_ldq_data_ra +#define MEM_LOAD2 cpu_lduw_le_data_ra +#define MEM_LOAD4 cpu_ldl_le_data_ra +#define MEM_LOAD8 cpu_ldq_le_data_ra =20 #define fLOAD(NUM, SIZE, SIGN, EA, DST) \ do { \ diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index e2e80ca7efa..08db1e9c56b 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -77,13 +77,13 @@ static void commit_store(CPUHexagonState *env, int slot= _num, uintptr_t ra) cpu_stb_data_ra(env, va, env->mem_log_stores[slot_num].data32, ra); break; case 2: - cpu_stw_data_ra(env, va, env->mem_log_stores[slot_num].data32, ra); + cpu_stw_le_data_ra(env, va, env->mem_log_stores[slot_num].data32, = ra); break; case 4: - cpu_stl_data_ra(env, va, env->mem_log_stores[slot_num].data32, ra); + cpu_stl_le_data_ra(env, va, env->mem_log_stores[slot_num].data32, = ra); break; case 8: - cpu_stq_data_ra(env, va, env->mem_log_stores[slot_num].data64, ra); + cpu_stq_le_data_ra(env, va, env->mem_log_stores[slot_num].data64, = ra); break; default: g_assert_not_reached(); --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763784076; cv=none; d=zohomail.com; s=zohoarc; b=COURXqA4zLaCwHjx9epbs5xeS/Un/NEP16jK+VbdPis1OBv2i6/BsYC0/gfJWeSVoB7ORzd6adSoHRGfV1pp2rMamRYLFxFjnA+aBJ6OHmvG2bxvw87z0FV7pufpELy09IaSNAAz55w6mUAtbwaTJ5lFJv5fLuiAdKKWHHr3Rlk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763784076; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=g6GufoGaaceDifeP+Y5j1u2tXZkEGmQIoKK0KjlWQxI=; b=UL8e7Z/JLmQBJB4VtflD8kxrlin1NRHBTExmXW1eG3hkUyX+eRVk2rJQNd8coXQDg2O1D/geZB6DOnZ0LuZlrOf/2ti6+yXLiym0z8DeNptdGYMUsEnerclvbfIFLu5X/Io1/+Z8yci/JVFwfBLja8UZPWeOa2fWv20yJf+Qijk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763784076448842.3784027483408; Fri, 21 Nov 2025 20:01:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMcyk-0003tY-FZ; Fri, 21 Nov 2025 21:03:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMc82-0005Ri-L3 for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:09:30 -0500 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMc61-0003hS-2P for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:09:27 -0500 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-b736d883ac4so480458066b.2 for ; Fri, 21 Nov 2025 17:07:08 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf355af6sm44415315e9.3.2025.11.21.05.46.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763773622; x=1764378422; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g6GufoGaaceDifeP+Y5j1u2tXZkEGmQIoKK0KjlWQxI=; b=QcmHwVUSfUI66wGfvzfAFMbLbPs3CGFNwJjgh+MPerIur9TWHwkw5HD/iZxQrdL3vl daOciwc7diYwPFZFib0uJr8dtzv2O85o3aUS6EL+dx3X0TX20bXNXc0pn2TxLdoG2TW2 2447twYFJG5aH+aVc/CaITODW390koumctbgFEaljN7Orx4Pz2bsUkTSGPfVgqJgjAQv MLP17s6INdPoahbrh2oMtTHY61i9MFUXAIqdJahgx221VlVvkLKB9uV52yDPjDuGC7T9 DVusniGfhoqB+mhR25dYMGfspXXNRWngwzXQXT/mw5wsw2OxWiZiAOB3ga4mkT4Yo3dI qk0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763773622; x=1764378422; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=g6GufoGaaceDifeP+Y5j1u2tXZkEGmQIoKK0KjlWQxI=; b=ZXmQTnHgJG2wWedW45/Zu0ZissFcWBej+aAUZV50688ochUmSiEbz5fBm1fi2l7LMh AQeut6svz518EwnmVW4K4PonWGU5h/PdT7CU8WO4SglTVYGoIJnp9JrAFQX2rFqF3zq5 CFJuCtin5E4vQi/XK1n74PBYhqiaDAYeh1L+aaAEV1BX99fqcElx+pRECYUPHZB/MVoU ipRzVs/3qr7qZCwuJxLwCWKNnhwyGk+Gv+EGlE9DE8BpTUKs8XdpQBKLumc4u1bKTNV7 xqzeqh6EOGXMmuPyQDV7M789XSXwbjht/NO7Ys/1YGfRdxLZCE+dmf8kb1mF0mbH8z3/ uk/g== X-Gm-Message-State: AOJu0YyWSLnlBBhscNoCtyQivOLLRu8ZQ2XyiUKAIqgoASLaQ6NgYnHQ Z4vSdSeB3B2Ic4zqRwSb5DSkBqCnup4f4zkkKRnTB/4U3SvtPeHng5iLf2CBBYTVFKygaAjOwA/ UDXDsgE7IhA== X-Gm-Gg: ASbGncu5B+H2VR0SL1JmP3WRqxHn8B2MkvgUTDBYARo1Ox0zzvPydUQmiHenCrQnJt3 2ptcGzbGUZmZaQ7onfymTTXNCdhskMU7rhQIaPdvQxRPofbj/YW1NcX9JyWuuW9KAxSs6H8RCF0 MnWt83DJ1zp78s0FIshgaM3PsGF3VgTfNRrKu7qTbFVRMAQVFDuDwju8+/GUjhJ46lu9Tp/Gq4P VT+RpJBjThsOg9qhKiCxZZN+v+905W1g2FypWPEvDKCwS8E4Yr/tgp0SSRct1bhCZqmzFSsq/Ap o8YcksfI44wwSkfkst7pnYI8j9Oj7e7VWD6u3FxyBFRerwy8GB6JMHg+1HGbZV3aoyhOf0LAWCs k0u+/ALV1juZ+H7mSY5HRwyYDulogCq34X3p/e1vYZsmDOuD2b7uz6mUpEmB9J9amRbPnTAo6RK NKX2HQPblyvtAaOXOZwzlBehG9dEh7sJEJjZl7fPKnK8i8WmfMqEJQEwQ72rD/ X-Google-Smtp-Source: AGHT+IFEr1L37DDCfdrNIDzi/3UTfYU9WR/5linL3zRdS9ErRGrUqnsYjkIglEr/vK2vRoT+SqG2zQ== X-Received: by 2002:a05:600c:3590:b0:471:672:3486 with SMTP id 5b1f17b1804b1-477c0184a94mr35783445e9.15.1763732778819; Fri, 21 Nov 2025 05:46:18 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 11/21] target/tricore: Use little-endian variant of cpu_ld/st_data*() Date: Fri, 21 Nov 2025 14:44:53 +0100 Message-ID: <20251121134503.30914-12-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=philmd@linaro.org; helo=mail-ej1-x636.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763784077359018900 We only build the TriCore target using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Dtricore; \ end=3Dle; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/tricore/op_helper.c | 152 ++++++++++++++++++------------------- 1 file changed, 76 insertions(+), 76 deletions(-) diff --git a/target/tricore/op_helper.c b/target/tricore/op_helper.c index 2c8281a67e0..88b50bc1a9b 100644 --- a/target/tricore/op_helper.c +++ b/target/tricore/op_helper.c @@ -2451,84 +2451,84 @@ static bool cdc_zero(uint32_t *psw) =20 static void save_context_upper(CPUTriCoreState *env, uint32_t ea) { - cpu_stl_data(env, ea, env->PCXI); - cpu_stl_data(env, ea+4, psw_read(env)); - cpu_stl_data(env, ea+8, env->gpr_a[10]); - cpu_stl_data(env, ea+12, env->gpr_a[11]); - cpu_stl_data(env, ea+16, env->gpr_d[8]); - cpu_stl_data(env, ea+20, env->gpr_d[9]); - cpu_stl_data(env, ea+24, env->gpr_d[10]); - cpu_stl_data(env, ea+28, env->gpr_d[11]); - cpu_stl_data(env, ea+32, env->gpr_a[12]); - cpu_stl_data(env, ea+36, env->gpr_a[13]); - cpu_stl_data(env, ea+40, env->gpr_a[14]); - cpu_stl_data(env, ea+44, env->gpr_a[15]); - cpu_stl_data(env, ea+48, env->gpr_d[12]); - cpu_stl_data(env, ea+52, env->gpr_d[13]); - cpu_stl_data(env, ea+56, env->gpr_d[14]); - cpu_stl_data(env, ea+60, env->gpr_d[15]); + cpu_stl_le_data(env, ea, env->PCXI); + cpu_stl_le_data(env, ea+4, psw_read(env)); + cpu_stl_le_data(env, ea+8, env->gpr_a[10]); + cpu_stl_le_data(env, ea+12, env->gpr_a[11]); + cpu_stl_le_data(env, ea+16, env->gpr_d[8]); + cpu_stl_le_data(env, ea+20, env->gpr_d[9]); + cpu_stl_le_data(env, ea+24, env->gpr_d[10]); + cpu_stl_le_data(env, ea+28, env->gpr_d[11]); + cpu_stl_le_data(env, ea+32, env->gpr_a[12]); + cpu_stl_le_data(env, ea+36, env->gpr_a[13]); + cpu_stl_le_data(env, ea+40, env->gpr_a[14]); + cpu_stl_le_data(env, ea+44, env->gpr_a[15]); + cpu_stl_le_data(env, ea+48, env->gpr_d[12]); + cpu_stl_le_data(env, ea+52, env->gpr_d[13]); + cpu_stl_le_data(env, ea+56, env->gpr_d[14]); + cpu_stl_le_data(env, ea+60, env->gpr_d[15]); } =20 static void save_context_lower(CPUTriCoreState *env, uint32_t ea) { - cpu_stl_data(env, ea, env->PCXI); - cpu_stl_data(env, ea+4, env->gpr_a[11]); - cpu_stl_data(env, ea+8, env->gpr_a[2]); - cpu_stl_data(env, ea+12, env->gpr_a[3]); - cpu_stl_data(env, ea+16, env->gpr_d[0]); - cpu_stl_data(env, ea+20, env->gpr_d[1]); - cpu_stl_data(env, ea+24, env->gpr_d[2]); - cpu_stl_data(env, ea+28, env->gpr_d[3]); - cpu_stl_data(env, ea+32, env->gpr_a[4]); - cpu_stl_data(env, ea+36, env->gpr_a[5]); - cpu_stl_data(env, ea+40, env->gpr_a[6]); - cpu_stl_data(env, ea+44, env->gpr_a[7]); - cpu_stl_data(env, ea+48, env->gpr_d[4]); - cpu_stl_data(env, ea+52, env->gpr_d[5]); - cpu_stl_data(env, ea+56, env->gpr_d[6]); - cpu_stl_data(env, ea+60, env->gpr_d[7]); + cpu_stl_le_data(env, ea, env->PCXI); + cpu_stl_le_data(env, ea+4, env->gpr_a[11]); + cpu_stl_le_data(env, ea+8, env->gpr_a[2]); + cpu_stl_le_data(env, ea+12, env->gpr_a[3]); + cpu_stl_le_data(env, ea+16, env->gpr_d[0]); + cpu_stl_le_data(env, ea+20, env->gpr_d[1]); + cpu_stl_le_data(env, ea+24, env->gpr_d[2]); + cpu_stl_le_data(env, ea+28, env->gpr_d[3]); + cpu_stl_le_data(env, ea+32, env->gpr_a[4]); + cpu_stl_le_data(env, ea+36, env->gpr_a[5]); + cpu_stl_le_data(env, ea+40, env->gpr_a[6]); + cpu_stl_le_data(env, ea+44, env->gpr_a[7]); + cpu_stl_le_data(env, ea+48, env->gpr_d[4]); + cpu_stl_le_data(env, ea+52, env->gpr_d[5]); + cpu_stl_le_data(env, ea+56, env->gpr_d[6]); + cpu_stl_le_data(env, ea+60, env->gpr_d[7]); } =20 static void restore_context_upper(CPUTriCoreState *env, uint32_t ea, uint32_t *new_PCXI, uint32_t *new_PSW) { - *new_PCXI =3D cpu_ldl_data(env, ea); - *new_PSW =3D cpu_ldl_data(env, ea+4); - env->gpr_a[10] =3D cpu_ldl_data(env, ea+8); - env->gpr_a[11] =3D cpu_ldl_data(env, ea+12); - env->gpr_d[8] =3D cpu_ldl_data(env, ea+16); - env->gpr_d[9] =3D cpu_ldl_data(env, ea+20); - env->gpr_d[10] =3D cpu_ldl_data(env, ea+24); - env->gpr_d[11] =3D cpu_ldl_data(env, ea+28); - env->gpr_a[12] =3D cpu_ldl_data(env, ea+32); - env->gpr_a[13] =3D cpu_ldl_data(env, ea+36); - env->gpr_a[14] =3D cpu_ldl_data(env, ea+40); - env->gpr_a[15] =3D cpu_ldl_data(env, ea+44); - env->gpr_d[12] =3D cpu_ldl_data(env, ea+48); - env->gpr_d[13] =3D cpu_ldl_data(env, ea+52); - env->gpr_d[14] =3D cpu_ldl_data(env, ea+56); - env->gpr_d[15] =3D cpu_ldl_data(env, ea+60); + *new_PCXI =3D cpu_ldl_le_data(env, ea); + *new_PSW =3D cpu_ldl_le_data(env, ea+4); + env->gpr_a[10] =3D cpu_ldl_le_data(env, ea+8); + env->gpr_a[11] =3D cpu_ldl_le_data(env, ea+12); + env->gpr_d[8] =3D cpu_ldl_le_data(env, ea+16); + env->gpr_d[9] =3D cpu_ldl_le_data(env, ea+20); + env->gpr_d[10] =3D cpu_ldl_le_data(env, ea+24); + env->gpr_d[11] =3D cpu_ldl_le_data(env, ea+28); + env->gpr_a[12] =3D cpu_ldl_le_data(env, ea+32); + env->gpr_a[13] =3D cpu_ldl_le_data(env, ea+36); + env->gpr_a[14] =3D cpu_ldl_le_data(env, ea+40); + env->gpr_a[15] =3D cpu_ldl_le_data(env, ea+44); + env->gpr_d[12] =3D cpu_ldl_le_data(env, ea+48); + env->gpr_d[13] =3D cpu_ldl_le_data(env, ea+52); + env->gpr_d[14] =3D cpu_ldl_le_data(env, ea+56); + env->gpr_d[15] =3D cpu_ldl_le_data(env, ea+60); } =20 static void restore_context_lower(CPUTriCoreState *env, uint32_t ea, uint32_t *ra, uint32_t *pcxi) { - *pcxi =3D cpu_ldl_data(env, ea); - *ra =3D cpu_ldl_data(env, ea+4); - env->gpr_a[2] =3D cpu_ldl_data(env, ea+8); - env->gpr_a[3] =3D cpu_ldl_data(env, ea+12); - env->gpr_d[0] =3D cpu_ldl_data(env, ea+16); - env->gpr_d[1] =3D cpu_ldl_data(env, ea+20); - env->gpr_d[2] =3D cpu_ldl_data(env, ea+24); - env->gpr_d[3] =3D cpu_ldl_data(env, ea+28); - env->gpr_a[4] =3D cpu_ldl_data(env, ea+32); - env->gpr_a[5] =3D cpu_ldl_data(env, ea+36); - env->gpr_a[6] =3D cpu_ldl_data(env, ea+40); - env->gpr_a[7] =3D cpu_ldl_data(env, ea+44); - env->gpr_d[4] =3D cpu_ldl_data(env, ea+48); - env->gpr_d[5] =3D cpu_ldl_data(env, ea+52); - env->gpr_d[6] =3D cpu_ldl_data(env, ea+56); - env->gpr_d[7] =3D cpu_ldl_data(env, ea+60); + *pcxi =3D cpu_ldl_le_data(env, ea); + *ra =3D cpu_ldl_le_data(env, ea+4); + env->gpr_a[2] =3D cpu_ldl_le_data(env, ea+8); + env->gpr_a[3] =3D cpu_ldl_le_data(env, ea+12); + env->gpr_d[0] =3D cpu_ldl_le_data(env, ea+16); + env->gpr_d[1] =3D cpu_ldl_le_data(env, ea+20); + env->gpr_d[2] =3D cpu_ldl_le_data(env, ea+24); + env->gpr_d[3] =3D cpu_ldl_le_data(env, ea+28); + env->gpr_a[4] =3D cpu_ldl_le_data(env, ea+32); + env->gpr_a[5] =3D cpu_ldl_le_data(env, ea+36); + env->gpr_a[6] =3D cpu_ldl_le_data(env, ea+40); + env->gpr_a[7] =3D cpu_ldl_le_data(env, ea+44); + env->gpr_d[4] =3D cpu_ldl_le_data(env, ea+48); + env->gpr_d[5] =3D cpu_ldl_le_data(env, ea+52); + env->gpr_d[6] =3D cpu_ldl_le_data(env, ea+56); + env->gpr_d[7] =3D cpu_ldl_le_data(env, ea+60); } =20 void helper_call(CPUTriCoreState *env, uint32_t next_pc) @@ -2566,7 +2566,7 @@ void helper_call(CPUTriCoreState *env, uint32_t next_= pc) ea =3D ((env->FCX & MASK_FCX_FCXS) << 12) + ((env->FCX & MASK_FCX_FCXO) << 6); /* new_FCX =3D M(EA, word); */ - new_FCX =3D cpu_ldl_data(env, ea); + new_FCX =3D cpu_ldl_le_data(env, ea); /* M(EA, 16 * word) =3D {PCXI, PSW, A[10], A[11], D[8], D[9], D[10], D= [11], A[12], A[13], A[14], A[15], D[12], D[13], D[14], D[15]}; */ @@ -2632,7 +2632,7 @@ void helper_ret(CPUTriCoreState *env) A[13], A[14], A[15], D[12], D[13], D[14], D[15]} =3D M(EA, 16 * wo= rd); */ restore_context_upper(env, ea, &new_PCXI, &new_PSW); /* M(EA, word) =3D FCX; */ - cpu_stl_data(env, ea, env->FCX); + cpu_stl_le_data(env, ea, env->FCX); /* FCX[19: 0] =3D PCXI[19: 0]; */ env->FCX =3D (env->FCX & 0xfff00000) + (env->PCXI & 0x000fffff); /* PCXI =3D new_PCXI; */ @@ -2662,7 +2662,7 @@ void helper_bisr(CPUTriCoreState *env, uint32_t const= 9) ea =3D ((env->FCX & 0xf0000) << 12) + ((env->FCX & 0xffff) << 6); =20 /* new_FCX =3D M(EA, word); */ - new_FCX =3D cpu_ldl_data(env, ea); + new_FCX =3D cpu_ldl_le_data(env, ea); /* M(EA, 16 * word) =3D {PCXI, A[11], A[2], A[3], D[0], D[1], D[2], D[= 3], A[4] , A[5], A[6], A[7], D[4], D[5], D[6], D[7]}; */ save_context_lower(env, ea); @@ -2726,7 +2726,7 @@ void helper_rfe(CPUTriCoreState *env) A[13], A[14], A[15], D[12], D[13], D[14], D[15]} =3D M(EA, 16 * word= ); */ restore_context_upper(env, ea, &new_PCXI, &new_PSW); /* M(EA, word) =3D FCX;*/ - cpu_stl_data(env, ea, env->FCX); + cpu_stl_le_data(env, ea, env->FCX); /* FCX[19: 0] =3D PCXI[19: 0]; */ env->FCX =3D (env->FCX & 0xfff00000) + (env->PCXI & 0x000fffff); /* PCXI =3D new_PCXI; */ @@ -2744,10 +2744,10 @@ void helper_rfm(CPUTriCoreState *env) icr_set_ccpn(env, pcxi_get_pcpn(env)); =20 /* {PCXI, PSW, A[10], A[11]} =3D M(DCX, 4 * word); */ - env->PCXI =3D cpu_ldl_data(env, env->DCX); - psw_write(env, cpu_ldl_data(env, env->DCX+4)); - env->gpr_a[10] =3D cpu_ldl_data(env, env->DCX+8); - env->gpr_a[11] =3D cpu_ldl_data(env, env->DCX+12); + env->PCXI =3D cpu_ldl_le_data(env, env->DCX); + psw_write(env, cpu_ldl_le_data(env, env->DCX+4)); + env->gpr_a[10] =3D cpu_ldl_le_data(env, env->DCX+8); + env->gpr_a[11] =3D cpu_ldl_le_data(env, env->DCX+12); =20 if (tricore_has_feature(env, TRICORE_FEATURE_131)) { env->DBGTCR =3D 0; @@ -2794,7 +2794,7 @@ void helper_svlcx(CPUTriCoreState *env) ea =3D ((env->FCX & MASK_FCX_FCXS) << 12) + ((env->FCX & MASK_FCX_FCXO) << 6); /* new_FCX =3D M(EA, word); */ - new_FCX =3D cpu_ldl_data(env, ea); + new_FCX =3D cpu_ldl_le_data(env, ea); /* M(EA, 16 * word) =3D {PCXI, PSW, A[10], A[11], D[8], D[9], D[10], D= [11], A[12], A[13], A[14], A[15], D[12], D[13], D[14], D[15]}; */ @@ -2837,7 +2837,7 @@ void helper_svucx(CPUTriCoreState *env) ea =3D ((env->FCX & MASK_FCX_FCXS) << 12) + ((env->FCX & MASK_FCX_FCXO) << 6); /* new_FCX =3D M(EA, word); */ - new_FCX =3D cpu_ldl_data(env, ea); + new_FCX =3D cpu_ldl_le_data(env, ea); /* M(EA, 16 * word) =3D {PCXI, PSW, A[10], A[11], D[8], D[9], D[10], D= [11], A[12], A[13], A[14], A[15], D[12], D[13], D[14], D[15]}; */ @@ -2887,9 +2887,9 @@ void helper_rslcx(CPUTriCoreState *env) A[13], A[14], A[15], D[12], D[13], D[14], D[15]} =3D M(EA, 16 * wo= rd); */ restore_context_lower(env, ea, &env->gpr_a[11], &new_PCXI); /* M(EA, word) =3D FCX; */ - cpu_stl_data(env, ea, env->FCX); + cpu_stl_le_data(env, ea, env->FCX); /* M(EA, word) =3D FCX; */ - cpu_stl_data(env, ea, env->FCX); + cpu_stl_le_data(env, ea, env->FCX); /* FCX[19: 0] =3D PCXI[19: 0]; */ env->FCX =3D (env->FCX & 0xfff00000) + (env->PCXI & 0x000fffff); /* PCXI =3D new_PCXI; */ --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763785446; cv=none; d=zohomail.com; s=zohoarc; b=eUSfzuBAH6LDVeCs0lPsV0e2EIBonTC3PwtVAcvTcSnXAee2gl6ASVnX5YgnbMPPhci0BkGk1FhOzgsTZledaBFRMYNktIx86K8mUD7CBbntLC7IM6FbQ9aaBLsPd1TO69bJ3Ktucfisd3zNnLNCzP/70s6N+PviqF+sM9RJom8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763785446; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NVumjk0F6Tq93V240FNbMOnFtVOEoBWTLGnL0WT9/nA=; b=FGsMt2v3FcrelUZU+0CPoCQna2v8WidG+/YK7NPFBjbKrJovXZ1qDJhZKjh18YPQOpGVoCEHsuWFExAjGsgHgm8OF56gEFb3c1vFyFL0xiL7Xv38KJfEKLjp7BFXrwi9j0tKM8GdGTUXG1KGecAVxxDRPmVFQh3r3ArjeD97c54= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763785446470307.79448861595813; Fri, 21 Nov 2025 20:24:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMd3T-00027a-Hw; Fri, 21 Nov 2025 21:08:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMcMR-0004e0-B2 for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:24:24 -0500 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMcKQ-0007bV-Pw for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:24:21 -0500 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-5942bac322dso2342688e87.0 for ; Fri, 21 Nov 2025 17:22:02 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fa41d2sm10949079f8f.22.2025.11.21.05.46.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:46:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763774518; x=1764379318; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NVumjk0F6Tq93V240FNbMOnFtVOEoBWTLGnL0WT9/nA=; b=jMbb2yiSOdt2uILhfhJEmF5R8ApUdYzVxANuGv8G48jzAMXEnOInkRRmgPDXjEpGxk VpdFvQS230boWIfxp+Pdk0qSb0XKruowUxJ0Pab6MJm5TJv69QOayEVNO1mhbjzZr7lE nPngsht1BECUB4F/uFapd6VzgOmUxxBjj0I2lr86zqKUhonTpOkeHd6jy3Lw+revEIe4 vb21GmrQD3GzDp+Jk7fg+Uvr6MEEZyIOBigCzmLsV/LjHOX9HchLwmwfItxKlaYQdCN5 Gh3T04cR89mRKkW95YSZ0witGZyo1ZFV6Nma+HLlt7etOoqxkYRRac1vxSX1XkSOMKNp Y7Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763774518; x=1764379318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NVumjk0F6Tq93V240FNbMOnFtVOEoBWTLGnL0WT9/nA=; b=bsQU/XN+6CzTu9o6sxohaCQsemcCLoQmFlK6z8GQb5cVSeOritP/h2cUn9BJ0zSTHW 4dSEz13fdkDEwHfIAIn/UcjWX+Jn/K2OyQyMnEtjQUQxnuBSb1DPGLgSp6V1MeM2jhr1 Y231NYV7kCBImI2ckTj1i1Edc8HmLGzB2BK1RB8RVGYDI2/4Cayko+wmvXAI4WVdb/sg fmDYMtQ6n4QIZyjvJz1k+Rq+QGJx4NL5WVWF1n0n9FXMxsATG6AK5ikNFMzrTYvr2zkm y9kQh0TBL9fiZrfK10yphdn+nEgTs1Kl4NTGA9WeaPP4csmAPdNombixfmpsVVna0s0C 2XCA== X-Gm-Message-State: AOJu0YxqJkahTZl6KBR6Oz6K+EuvShsiMNpa9VZOLnOA6cnNyDFcLVe1 4VaPdM7H9mZBh767oF9XICAFwmSR1/oXRuL1oJoNsdyXTxt46hluT9FZQ4GJTC0Gaozxgq2S+0T zj3OOsmqTog== X-Gm-Gg: ASbGncvdVVQ3TJ6c+5d+h48/51ajgZsMTuMfWy0Lqx+kB96gS6b0gYqDzOxQt+4xgf/ 1+fCo8KKMC0GjJPnUePYjw2dNQeF16dmAYwkmyZhbVqbcYLlgtgBXFb9qKaSCIcRn8fC10OBNud 87yLWP09nQz1umCHythGqXNaFZQD0+sVi3ST/JKkyEN3u8SpyBxnFsUN5iq1+LuWVsSBncflds/ xMSoS9bcQ5rPG4gQdAwyZ2y9xigRGDjKtUZkzIqDLd0GXnVHxtu5Gy/6FziTP257JUUDVdlwCCt 78nIEC9RjRIZn62Tgwc3zGsLOAQHGECyDiFy2OFdT40fhC6aoJ7634V98dY520890pBVp5zAJsG 51olE5kLXkKcyAzOCpcRuB/tbCWcj2zlQifqY7bUjqR5hBh5r+GlQhFCc2ijJ+xLnl5b3qpVARN 06K+MFWJmAp+B8hOdin+LW3GU3bHuR45vNzf01J/P7N1Mmz04ibWbMTXa7KYMJhalXMNdvLj0= X-Google-Smtp-Source: AGHT+IGEW71gfF7lovLtWNbtIwcDPhHZqsiycXLmAUHc1Dw+R/7rWjyTPaOkB2voMZKJno5HXJvLtA== X-Received: by 2002:a5d:5f44:0:b0:42c:a4e7:3975 with SMTP id ffacd0b85a97d-42cc1cf3be2mr2438747f8f.30.1763732785412; Fri, 21 Nov 2025 05:46:25 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 12/21] target/rx: Use little-endian variant of cpu_ld/st_data*() Date: Fri, 21 Nov 2025 14:44:54 +0100 Message-ID: <20251121134503.30914-13-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::135; envelope-from=philmd@linaro.org; helo=mail-lf1-x135.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763785447952018900 We only build the RX target using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Drx; \ end=3Dle; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/rx/helper.c | 14 +++++++------- target/rx/op_helper.c | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/target/rx/helper.c b/target/rx/helper.c index e9a7aaf610d..83cd491eb4a 100644 --- a/target/rx/helper.c +++ b/target/rx/helper.c @@ -68,10 +68,10 @@ void rx_cpu_do_interrupt(CPUState *cs) qemu_log_mask(CPU_LOG_INT, "fast interrupt raised\n"); } else if (cpu_test_interrupt(cs, CPU_INTERRUPT_HARD)) { env->isp -=3D 4; - cpu_stl_data(env, env->isp, save_psw); + cpu_stl_le_data(env, env->isp, save_psw); env->isp -=3D 4; - cpu_stl_data(env, env->isp, env->pc); - env->pc =3D cpu_ldl_data(env, env->intb + env->ack_irq * 4); + cpu_stl_le_data(env, env->isp, env->pc); + env->pc =3D cpu_ldl_le_data(env, env->intb + env->ack_irq * 4); env->psw_ipl =3D env->ack_ipl; cpu_reset_interrupt(cs, CPU_INTERRUPT_HARD); qemu_set_irq(env->ack, env->ack_irq); @@ -82,14 +82,14 @@ void rx_cpu_do_interrupt(CPUState *cs) const char *expname =3D "unknown exception"; =20 env->isp -=3D 4; - cpu_stl_data(env, env->isp, save_psw); + cpu_stl_le_data(env, env->isp, save_psw); env->isp -=3D 4; - cpu_stl_data(env, env->isp, env->pc); + cpu_stl_le_data(env, env->isp, env->pc); =20 if (vec < 0x100) { - env->pc =3D cpu_ldl_data(env, 0xffffff80 + vec * 4); + env->pc =3D cpu_ldl_le_data(env, 0xffffff80 + vec * 4); } else { - env->pc =3D cpu_ldl_data(env, env->intb + (vec & 0xff) * 4); + env->pc =3D cpu_ldl_le_data(env, env->intb + (vec & 0xff) * 4); } =20 if (vec =3D=3D 30) { diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c index 2b190a4b2cf..ca3e9e85fc7 100644 --- a/target/rx/op_helper.c +++ b/target/rx/op_helper.c @@ -217,20 +217,20 @@ void helper_scmpu(CPURXState *env) static uint32_t (* const cpu_ldufn[])(CPUArchState *env, abi_ptr ptr, uintptr_t retaddr) =3D { - cpu_ldub_data_ra, cpu_lduw_data_ra, cpu_ldl_data_ra, + cpu_ldub_data_ra, cpu_lduw_le_data_ra, cpu_ldl_le_data_ra, }; =20 static uint32_t (* const cpu_ldfn[])(CPUArchState *env, abi_ptr ptr, uintptr_t retaddr) =3D { - cpu_ldub_data_ra, cpu_lduw_data_ra, cpu_ldl_data_ra, + cpu_ldub_data_ra, cpu_lduw_le_data_ra, cpu_ldl_le_data_ra, }; =20 static void (* const cpu_stfn[])(CPUArchState *env, abi_ptr ptr, uint32_t val, uintptr_t retaddr) =3D { - cpu_stb_data_ra, cpu_stw_data_ra, cpu_stl_data_ra, + cpu_stb_data_ra, cpu_stw_le_data_ra, cpu_stl_le_data_ra, }; =20 void helper_sstr(CPURXState *env, uint32_t sz) --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763780480; cv=none; d=zohomail.com; s=zohoarc; b=VMoYnRXQGOUuNjM4rojTjZq4bpKo1hlyNIvRAUXtYBQd2riHXf8dSY3TcS8S8KxEXOnq0HHBV1/KucZxscZJjbifi/6FdKpBF2GocO53AN3e3Np0o1f7pouCywQfFXZsQTaDAphI2y1RgQ2oqZsFFcOUBAY0+Glfx/UbKHd71oU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763780480; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=27Oww4qQxdixc+Id3IXgq5AJQ19OjMu/GDoS0nr9Vqw=; b=nxQe2bpi+VDGbx5q25/an+4eNJ4UD6leT+Ft7niWUY8Rkb3fbutpRsnr21AT5BUL8LVi0cqu1srDoEt2IoZBpb3Ig/E2iSpwsmAenVUnERZ8u7evQOfUXoi6lo1VbYSKsfhew6torv4fDqoI9/fUYotvv2DSGchFrxx3qomU2so= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763780480088223.61812370609948; Fri, 21 Nov 2025 19:01:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMd8H-0005vO-2z; Fri, 21 Nov 2025 21:13:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMcsV-0007Rs-H0 for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:57:32 -0500 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMcr9-0007LP-3T for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:57:27 -0500 Received: by mail-ed1-x544.google.com with SMTP id 4fb4d7f45d1cf-64074f01a6eso4595098a12.2 for ; Fri, 21 Nov 2025 17:55:50 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f2e581sm10502617f8f.8.2025.11.21.05.46.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:46:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763776545; x=1764381345; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=27Oww4qQxdixc+Id3IXgq5AJQ19OjMu/GDoS0nr9Vqw=; b=bIqH7OhjKFwCntB6Adpm6Z2i8YRCsQn/W1RlSF8SHSlv+5G+YOjwHp68Z7EVo9b2q6 aDbg8sTwVehpxzO4SDMt6Ak00/7kbyk/LdOyUkwKqfwEYbfZ8BOjftJ5R5ugFBecWggU QfzdMplX57+ZDCg8ubMgR0/eASirSZz0o5Gkyd0df0kv79waD1U/5DjsQnOYI9SkBWwP G2OEu4zOBcVaDPo1i7/EVYNwLtE8mD36eNk6Cds3tmi7yIlnCq2vV2glnogWBPSQZCNE m0VKAIuxRhKGdV5bOJrKbcyHblqb1YUq4rZQoY4+cJAp6XbGn8hRNrYemWsYMLLO+FUQ Z/TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763776545; x=1764381345; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=27Oww4qQxdixc+Id3IXgq5AJQ19OjMu/GDoS0nr9Vqw=; b=naOvUFYcvGsLbY7JZiKFma11I8ZPCx5aFgITWD/Jsr87+Gp4ch/mBEtrqYxDkDPNfy HzKSLVcfpzxZti7oKqm223QhhDmTbHouDCzZeHilKnSrvTO2tqvV4PVzwbJ5NLhIwkQo L+YrYvXak9mtEyC16Ees9fZuGSHOT0JTGzyXNT9TE9+wOPQ13JYsBi8TmXDFjCH7CwYI 5eb0cuNhEghpSKeyA77aPVQBZPq7HSKmg2PnsNujtTNIaWh0SsGwYypS4vPrRKAXTvsQ tHMFKt2ps8k6k16WQMA6efoWwiYW2RbKcgGgYQxiV7KrGUJYd9NET95XVIvw6edaYPOK +lfw== X-Gm-Message-State: AOJu0YxnQLZrq1sl/aRVU5gGvVC6r799RJbJt3ahzIJBrzsaJxasKP5x x197JHl8SuMQqt8/7b89iEo4CwJIR3J9B1Je4vRno1Myt37zAYbokV1vpH8m3XEJX4gCxyeWkz9 CI3eLM5UXyzE5 X-Gm-Gg: ASbGncs82ACwVzCufxNgIzY8HBctIKhpH8dFRF7ZAyKf7U2A9G6DQBLwLxYQ79LDbs8 2v1b/eygGM2Xtc05UHEn3T/N/IeQKN4d/Ub7jzGS2GftGnUaX31EILfp7JjR0xbQttsxsXU5bzv qbSHSjefm4gtRC5t21hDkrpVBXODHem7DJAzVGtSiFCq1CdnZysRYBFT2QuDliHPZ8ym4+sryip ZcvHhU5WpKqfKDY+cj56cyK3Jx0xPxTd+mP0EB24orOSatU2IVsXp7HEgVq3b0/GAD1sYwoCw1j /kMIOqOFav4XsIWWezPk0qHVvzfFYTUJu54oQuY51zNsAjJDREtkX2x723bXZkNs7cc4km1nvSg 94oerBNEIr/BIwYHx+C87j5iCOAEjg5nCWufTqpKb9z4hmKtaAzHRQSM3XmzsQQnwFqsrsarmIg gXwlq4cGldPsbCc09NpNMp9/LcAiLNLoLcqg7U0DlG95Kk8lGM7uALG9od5B7B X-Google-Smtp-Source: AGHT+IEPLHBqw5ofq+6kz8Qjha8zhtu5Le9chojoHOl92BeqzuOOGh31Z+6+FW5BL3Z7UYtmDPrGIg== X-Received: by 2002:a05:6000:1787:b0:42b:3023:66a9 with SMTP id ffacd0b85a97d-42cc1cbd4d0mr2509791f8f.22.1763732792090; Fri, 21 Nov 2025 05:46:32 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 13/21] target/m68k: Use little-endian variant of cpu_ld/st_data*() Date: Fri, 21 Nov 2025 14:44:55 +0100 Message-ID: <20251121134503.30914-14-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::544; envelope-from=philmd@linaro.org; helo=mail-ed1-x544.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, T_SPF_HELO_TEMPERROR=0.01, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763780481761018900 We only build the M68k target using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Dm68k; \ end=3Dbe; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/m68k/fpu_helper.c | 12 +++--- target/m68k/op_helper.c | 88 ++++++++++++++++++++-------------------- 2 files changed, 50 insertions(+), 50 deletions(-) diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.c index 56012863c85..f49f841d489 100644 --- a/target/m68k/fpu_helper.c +++ b/target/m68k/fpu_helper.c @@ -510,8 +510,8 @@ static int cpu_ld_floatx80_ra(CPUM68KState *env, uint32= _t addr, FPReg *fp, uint32_t high; uint64_t low; =20 - high =3D cpu_ldl_data_ra(env, addr, ra); - low =3D cpu_ldq_data_ra(env, addr + 4, ra); + high =3D cpu_ldl_be_data_ra(env, addr, ra); + low =3D cpu_ldq_be_data_ra(env, addr + 4, ra); =20 fp->l.upper =3D high >> 16; fp->l.lower =3D low; @@ -522,8 +522,8 @@ static int cpu_ld_floatx80_ra(CPUM68KState *env, uint32= _t addr, FPReg *fp, static int cpu_st_floatx80_ra(CPUM68KState *env, uint32_t addr, FPReg *fp, uintptr_t ra) { - cpu_stl_data_ra(env, addr, fp->l.upper << 16, ra); - cpu_stq_data_ra(env, addr + 4, fp->l.lower, ra); + cpu_stl_be_data_ra(env, addr, fp->l.upper << 16, ra); + cpu_stq_be_data_ra(env, addr + 4, fp->l.lower, ra); =20 return 12; } @@ -533,7 +533,7 @@ static int cpu_ld_float64_ra(CPUM68KState *env, uint32_= t addr, FPReg *fp, { uint64_t val; =20 - val =3D cpu_ldq_data_ra(env, addr, ra); + val =3D cpu_ldq_be_data_ra(env, addr, ra); fp->d =3D float64_to_floatx80(*(float64 *)&val, &env->fp_status); =20 return 8; @@ -545,7 +545,7 @@ static int cpu_st_float64_ra(CPUM68KState *env, uint32_= t addr, FPReg *fp, float64 val; =20 val =3D floatx80_to_float64(fp->d, &env->fp_status); - cpu_stq_data_ra(env, addr, *(uint64_t *)&val, ra); + cpu_stq_be_data_ra(env, addr, *(uint64_t *)&val, ra); =20 return 8; } diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c index e9c20a8e032..eac45669ce7 100644 --- a/target/m68k/op_helper.c +++ b/target/m68k/op_helper.c @@ -32,8 +32,8 @@ static void cf_rte(CPUM68KState *env) uint32_t fmt; =20 sp =3D env->aregs[7]; - fmt =3D cpu_ldl_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); - env->pc =3D cpu_ldl_mmuidx_ra(env, sp + 4, MMU_KERNEL_IDX, 0); + fmt =3D cpu_ldl_be_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); + env->pc =3D cpu_ldl_be_mmuidx_ra(env, sp + 4, MMU_KERNEL_IDX, 0); sp |=3D (fmt >> 28) & 3; env->aregs[7] =3D sp + 8; =20 @@ -48,13 +48,13 @@ static void m68k_rte(CPUM68KState *env) =20 sp =3D env->aregs[7]; throwaway: - sr =3D cpu_lduw_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); + sr =3D cpu_lduw_be_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); sp +=3D 2; - env->pc =3D cpu_ldl_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); + env->pc =3D cpu_ldl_be_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); sp +=3D 4; if (m68k_feature(env, M68K_FEATURE_EXCEPTION_FORMAT_VEC)) { /* all except 68000 */ - fmt =3D cpu_lduw_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); + fmt =3D cpu_lduw_be_mmuidx_ra(env, sp, MMU_KERNEL_IDX, 0); sp +=3D 2; switch (fmt >> 12) { case 0: @@ -250,12 +250,12 @@ static void cf_interrupt_all(CPUM68KState *env, int i= s_hw) /* ??? This could cause MMU faults. */ sp &=3D ~3; sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, retaddr, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, retaddr, MMU_KERNEL_IDX, 0); sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, fmt, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, fmt, MMU_KERNEL_IDX, 0); env->aregs[7] =3D sp; /* Jump to vector. */ - env->pc =3D cpu_ldl_mmuidx_ra(env, env->vbr + vector, MMU_KERNEL_IDX, = 0); + env->pc =3D cpu_ldl_be_mmuidx_ra(env, env->vbr + vector, MMU_KERNEL_ID= X, 0); =20 do_plugin_vcpu_interrupt_cb(cs, retaddr); } @@ -270,24 +270,24 @@ static inline void do_stack_frame(CPUM68KState *env, = uint32_t *sp, switch (format) { case 4: *sp -=3D 4; - cpu_stl_mmuidx_ra(env, *sp, env->pc, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, *sp, env->pc, MMU_KERNEL_IDX, 0); *sp -=3D 4; - cpu_stl_mmuidx_ra(env, *sp, addr, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, *sp, addr, MMU_KERNEL_IDX, 0); break; case 3: case 2: *sp -=3D 4; - cpu_stl_mmuidx_ra(env, *sp, addr, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, *sp, addr, MMU_KERNEL_IDX, 0); break; } *sp -=3D 2; - cpu_stw_mmuidx_ra(env, *sp, (format << 12) + (cs->exception_index = << 2), + cpu_stw_be_mmuidx_ra(env, *sp, (format << 12) + (cs->exception_ind= ex << 2), MMU_KERNEL_IDX, 0); } *sp -=3D 4; - cpu_stl_mmuidx_ra(env, *sp, retaddr, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, *sp, retaddr, MMU_KERNEL_IDX, 0); *sp -=3D 2; - cpu_stw_mmuidx_ra(env, *sp, sr, MMU_KERNEL_IDX, 0); + cpu_stw_be_mmuidx_ra(env, *sp, sr, MMU_KERNEL_IDX, 0); } =20 static void m68k_interrupt_all(CPUM68KState *env, int is_hw) @@ -346,49 +346,49 @@ static void m68k_interrupt_all(CPUM68KState *env, int= is_hw) env->mmu.fault =3D true; /* push data 3 */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* push data 2 */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* push data 1 */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 1 / push data 0 */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 1 address */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 2 data */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 2 address */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 3 data */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 3 address */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, env->mmu.ar, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, env->mmu.ar, MMU_KERNEL_IDX, 0); /* fault address */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, env->mmu.ar, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, env->mmu.ar, MMU_KERNEL_IDX, 0); /* write back 1 status */ sp -=3D 2; - cpu_stw_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stw_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 2 status */ sp -=3D 2; - cpu_stw_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stw_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* write back 3 status */ sp -=3D 2; - cpu_stw_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); + cpu_stw_be_mmuidx_ra(env, sp, 0, MMU_KERNEL_IDX, 0); /* special status word */ sp -=3D 2; - cpu_stw_mmuidx_ra(env, sp, env->mmu.ssw, MMU_KERNEL_IDX, 0); + cpu_stw_be_mmuidx_ra(env, sp, env->mmu.ssw, MMU_KERNEL_IDX, 0); /* effective address */ sp -=3D 4; - cpu_stl_mmuidx_ra(env, sp, env->mmu.ar, MMU_KERNEL_IDX, 0); + cpu_stl_be_mmuidx_ra(env, sp, env->mmu.ar, MMU_KERNEL_IDX, 0); =20 do_stack_frame(env, &sp, 7, oldsr, 0, env->pc); env->mmu.fault =3D false; @@ -436,7 +436,7 @@ static void m68k_interrupt_all(CPUM68KState *env, int i= s_hw) =20 env->aregs[7] =3D sp; /* Jump to vector. */ - env->pc =3D cpu_ldl_mmuidx_ra(env, env->vbr + vector, MMU_KERNEL_IDX, = 0); + env->pc =3D cpu_ldl_be_mmuidx_ra(env, env->vbr + vector, MMU_KERNEL_ID= X, 0); =20 do_plugin_vcpu_interrupt_cb(cs, last_pc); } @@ -784,11 +784,11 @@ void HELPER(cas2w)(CPUM68KState *env, uint32_t regs, = uint32_t a1, uint32_t a2) int16_t l1, l2; uintptr_t ra =3D GETPC(); =20 - l1 =3D cpu_lduw_data_ra(env, a1, ra); - l2 =3D cpu_lduw_data_ra(env, a2, ra); + l1 =3D cpu_lduw_be_data_ra(env, a1, ra); + l2 =3D cpu_lduw_be_data_ra(env, a2, ra); if (l1 =3D=3D c1 && l2 =3D=3D c2) { - cpu_stw_data_ra(env, a1, u1, ra); - cpu_stw_data_ra(env, a2, u2, ra); + cpu_stw_be_data_ra(env, a1, u1, ra); + cpu_stw_be_data_ra(env, a2, u2, ra); } =20 if (c1 !=3D l1) { @@ -845,11 +845,11 @@ static void do_cas2l(CPUM68KState *env, uint32_t regs= , uint32_t a1, uint32_t a2, } } else { /* We're executing in a serial context -- no need to be atomic. */ - l1 =3D cpu_ldl_data_ra(env, a1, ra); - l2 =3D cpu_ldl_data_ra(env, a2, ra); + l1 =3D cpu_ldl_be_data_ra(env, a1, ra); + l2 =3D cpu_ldl_be_data_ra(env, a2, ra); if (l1 =3D=3D c1 && l2 =3D=3D c2) { - cpu_stl_data_ra(env, a1, u1, ra); - cpu_stl_data_ra(env, a2, u2, ra); + cpu_stl_be_data_ra(env, a1, u1, ra); + cpu_stl_be_data_ra(env, a2, u2, ra); } } =20 @@ -951,12 +951,12 @@ static uint64_t bf_load(CPUM68KState *env, uint32_t a= ddr, int blen, case 0: return cpu_ldub_data_ra(env, addr, ra); case 1: - return cpu_lduw_data_ra(env, addr, ra); + return cpu_lduw_be_data_ra(env, addr, ra); case 2: case 3: - return cpu_ldl_data_ra(env, addr, ra); + return cpu_ldl_be_data_ra(env, addr, ra); case 4: - return cpu_ldq_data_ra(env, addr, ra); + return cpu_ldq_be_data_ra(env, addr, ra); default: g_assert_not_reached(); } @@ -970,14 +970,14 @@ static void bf_store(CPUM68KState *env, uint32_t addr= , int blen, cpu_stb_data_ra(env, addr, data, ra); break; case 1: - cpu_stw_data_ra(env, addr, data, ra); + cpu_stw_be_data_ra(env, addr, data, ra); break; case 2: case 3: - cpu_stl_data_ra(env, addr, data, ra); + cpu_stl_be_data_ra(env, addr, data, ra); break; case 4: - cpu_stq_data_ra(env, addr, data, ra); + cpu_stq_be_data_ra(env, addr, data, ra); break; default: g_assert_not_reached(); --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763779722; cv=none; d=zohomail.com; s=zohoarc; b=L34ghAJaMXd0qo8woAgROO7h45ia1h1fY/89CtyiwOYKaUuabgvmUUlP+NaCjI7XDfpFP4WOZu5ttUc5iWh0tcSF/HBtV2rvppLjQtkyDC4978lRInhB1EimHIEwyuqaUVhKWu3wqi5+K0nygx3RyBdMjUFvfhb+f6JnAC3aSys= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763779722; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wiNGRX34bLVgr8we0q4WpsknHKY0sYA3cJv9gH8gG7k=; b=IWRbO0n/VSxkTTp1PJzdXT0mF/vhcvOWQvTkK0ira1BWRqlHKpGD9EaKkYYT82KNLloCTDKzKG41f5O3Wk72EodijYiVGIxqg/URJDg8h3kvfzt7huI/EuN89w5d4uz2leEPYisUk43qMWHGhvMZ5nFGcxIWkYC1qOok5pMK4LE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763779722259124.85214216734721; Fri, 21 Nov 2025 18:48:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMdUN-00082J-7g; Fri, 21 Nov 2025 21:36:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMcDv-0000Gk-7w for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:15:37 -0500 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMcBu-0005Bk-51 for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:15:32 -0500 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-b735ce67d1dso412736566b.3 for ; Fri, 21 Nov 2025 17:13:13 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf3b4eb2sm44593575e9.12.2025.11.21.05.46.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:46:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763773987; x=1764378787; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wiNGRX34bLVgr8we0q4WpsknHKY0sYA3cJv9gH8gG7k=; b=gWj0DasjPf3nYGpSViH7DO5PdYXwj8FJCjBwSqHnUafrv6MABlFlCtqz3UUowBd5QI Tn+XIEGvKbTTfdLa4hEZliqAZ56vqEjQsa/HrUC3j6K8tkluSdt6L2XecLfixDRqgPV0 8YwJolLZsgjNOvuhMDRaRtUmKKmFPomX04UquMJ/662qUA+ZzR6ulX3bV/2blofEA72x 5et8oYfqbR2FQQsgpQq+24I7jTqr/ASD8994cv9kKIE5cV3ewWfpn/Ne1Ru1nK7cLSbb Hrcu4rbx1fXIRyIrb/RuUh6RR8IUOBTpSt0XAFoRDkL10WlE0OnTZS2ULqEOs9gkyuqY XmCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763773987; x=1764378787; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wiNGRX34bLVgr8we0q4WpsknHKY0sYA3cJv9gH8gG7k=; b=dyIHNP6zZt00YuPYVni55gQM6r9zRXr5TLZimGVWqGdWIfT4pwaUdCxIUsy8JA9cbH b+cPsI9fKu0j7I0fSTN4s7ABISJXxVdBbH/8fJpzzebHbX4lcA7MHsQBG/zKRdA6I4rS JXPCuBjKaCXOnrd7eFtV1rKeYf/AMs05LCrf5yvxrb1g+yPqmV3RgaDY04URmMi43A7C 7TfAD4N5tlpAaweLAOBZlgCV8rA9OmgS7Y26ZL90rPE+jrlq1r/wmgJyMTw22cgo+Osp 2UVBiRKFz9fTjOHCXVSRNSwCJO1A46askh+msh3WIRABpGGshy5Jm19yj2SqJJOuDTYk CkyA== X-Gm-Message-State: AOJu0YwZb/WsrgDgRLoerecuS+CRPbZJ73rqC5AyPpS/1BHyR4vXrMjq UAfuDkKt/0Yf8uc6GU6QVh6Cj/uQ+w+GkcsP0ZlLo75/kU0ir/YRVYg7bWB8AMPNvH5mENIHfBF Jn89e2Xek+w== X-Gm-Gg: ASbGncuEr7bHlGzMwfD+ICVmxekVlIPNtmQ9W7b14UCCrssZ5a3JMCWYmOXZww9M7nH e76oidEMdsI1OP12er7D+GHUOMHoqKlvtz5NnKC1/u5W9spfY6hbYMLt3J+2RSWJR2RWIaHSr8W UsWSXAuP7B7265ASDqg+r92UFRTfHmbiKJQwPqVerDTuJhg77DAdnBl0uvj7hn5ljKIJ0SZ+NNm W6yba9GozkwMvpJopi6fd6FbeP7TnuhsMVgLEeTQXSm2J2xHnat+lAV/eH3pWw5OK4PCQ4ZFW3x 3L9fcrTJj/1+UmHdqk4MK1E4CFSkn5g+4n+FwN6vMWNPtzQvOwdh9Hse5VPOs+yibwRlWuwEOEd wlvLeh49C1IyXoT2ASviAlaqRrYUaaLJh+L4yoyyOhVdaftDD+Ca4PibRlrhlVpjMvdA/GoJz7y fh2u2FIruuUd+Du+rbpx3KqHu7yCpvzcWaneSvxFbMoHMHr8OHoJpWJAppDfI0 X-Google-Smtp-Source: AGHT+IGCkg+uWGBlahBmkPgkgQoDmg3pMx2+5N7CNgh0GMGQreSiOwxIaOA51lhQPEmwFRlZ1n3jzA== X-Received: by 2002:a05:600c:470d:b0:477:89d5:fdac with SMTP id 5b1f17b1804b1-477c01f4f4emr29007215e9.31.1763732798704; Fri, 21 Nov 2025 05:46:38 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 14/21] target/s390x: Use little-endian variant of cpu_ld/st_data*() Date: Fri, 21 Nov 2025 14:44:56 +0100 Message-ID: <20251121134503.30914-15-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62f; envelope-from=philmd@linaro.org; helo=mail-ej1-x62f.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763779723006018900 We only build the S390x target using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Ds390x; \ end=3Dbe; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/s390x/tcg/mem_helper.c | 48 +++++++++++++++++------------------ target/s390x/tcg/vec_helper.c | 8 +++--- 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c index 84d901c2008..cb990c0c983 100644 --- a/target/s390x/tcg/mem_helper.c +++ b/target/s390x/tcg/mem_helper.c @@ -101,7 +101,7 @@ static inline uint64_t cpu_ldusize_data_ra(CPUS390XStat= e *env, uint64_t addr, case 1: return cpu_ldub_data_ra(env, addr, ra); case 2: - return cpu_lduw_data_ra(env, addr, ra); + return cpu_lduw_be_data_ra(env, addr, ra); default: abort(); } @@ -117,7 +117,7 @@ static inline void cpu_stsize_data_ra(CPUS390XState *en= v, uint64_t addr, cpu_stb_data_ra(env, addr, value, ra); break; case 2: - cpu_stw_data_ra(env, addr, value, ra); + cpu_stw_be_data_ra(env, addr, value, ra); break; default: abort(); @@ -865,7 +865,7 @@ void HELPER(srstu)(CPUS390XState *env, uint32_t r1, uin= t32_t r2) env->cc_op =3D 2; return; } - v =3D cpu_lduw_data_ra(env, str + len, ra); + v =3D cpu_lduw_be_data_ra(env, str + len, ra); if (v =3D=3D c) { /* Character found. Set R1 to the location; R2 is unmodified.= */ env->cc_op =3D 1; @@ -1022,7 +1022,7 @@ void HELPER(lam)(CPUS390XState *env, uint32_t r1, uin= t64_t a2, uint32_t r3) } =20 for (i =3D r1;; i =3D (i + 1) % 16) { - env->aregs[i] =3D cpu_ldl_data_ra(env, a2, ra); + env->aregs[i] =3D cpu_ldl_be_data_ra(env, a2, ra); a2 +=3D 4; =20 if (i =3D=3D r3) { @@ -1042,7 +1042,7 @@ void HELPER(stam)(CPUS390XState *env, uint32_t r1, ui= nt64_t a2, uint32_t r3) } =20 for (i =3D r1;; i =3D (i + 1) % 16) { - cpu_stl_data_ra(env, a2, env->aregs[i], ra); + cpu_stl_be_data_ra(env, a2, env->aregs[i], ra); a2 +=3D 4; =20 if (i =3D=3D r3) { @@ -1363,7 +1363,7 @@ Int128 HELPER(cksm)(CPUS390XState *env, uint64_t r1, =20 /* Process full words as available. */ for (len =3D 0; len + 4 <=3D max_len; len +=3D 4, src +=3D 4) { - cksm +=3D (uint32_t)cpu_ldl_data_ra(env, src, ra); + cksm +=3D (uint32_t)cpu_ldl_be_data_ra(env, src, ra); } =20 switch (max_len - len) { @@ -1372,11 +1372,11 @@ Int128 HELPER(cksm)(CPUS390XState *env, uint64_t r1, len +=3D 1; break; case 2: - cksm +=3D cpu_lduw_data_ra(env, src, ra) << 16; + cksm +=3D cpu_lduw_be_data_ra(env, src, ra) << 16; len +=3D 2; break; case 3: - cksm +=3D cpu_lduw_data_ra(env, src, ra) << 16; + cksm +=3D cpu_lduw_be_data_ra(env, src, ra) << 16; cksm +=3D cpu_ldub_data_ra(env, src + 2, ra) << 8; len +=3D 3; break; @@ -1955,7 +1955,7 @@ void HELPER(lctlg)(CPUS390XState *env, uint32_t r1, u= int64_t a2, uint32_t r3) } =20 for (i =3D r1;; i =3D (i + 1) % 16) { - uint64_t val =3D cpu_ldq_data_ra(env, src, ra); + uint64_t val =3D cpu_ldq_be_data_ra(env, src, ra); if (env->cregs[i] !=3D val && i >=3D 9 && i <=3D 11) { PERchanged =3D true; } @@ -1992,7 +1992,7 @@ void HELPER(lctl)(CPUS390XState *env, uint32_t r1, ui= nt64_t a2, uint32_t r3) } =20 for (i =3D r1;; i =3D (i + 1) % 16) { - uint32_t val =3D cpu_ldl_data_ra(env, src, ra); + uint32_t val =3D cpu_ldl_be_data_ra(env, src, ra); uint64_t val64 =3D deposit64(env->cregs[i], 0, 32, val); if ((uint32_t)env->cregs[i] !=3D val && i >=3D 9 && i <=3D 11) { PERchanged =3D true; @@ -2028,7 +2028,7 @@ void HELPER(stctg)(CPUS390XState *env, uint32_t r1, u= int64_t a2, uint32_t r3) } =20 for (i =3D r1;; i =3D (i + 1) % 16) { - cpu_stq_data_ra(env, dest, env->cregs[i], ra); + cpu_stq_be_data_ra(env, dest, env->cregs[i], ra); dest +=3D sizeof(uint64_t); =20 if (i =3D=3D r3) { @@ -2048,7 +2048,7 @@ void HELPER(stctl)(CPUS390XState *env, uint32_t r1, u= int64_t a2, uint32_t r3) } =20 for (i =3D r1;; i =3D (i + 1) % 16) { - cpu_stl_data_ra(env, dest, env->cregs[i], ra); + cpu_stl_be_data_ra(env, dest, env->cregs[i], ra); dest +=3D sizeof(uint32_t); =20 if (i =3D=3D r3) { @@ -2065,7 +2065,7 @@ uint32_t HELPER(testblock)(CPUS390XState *env, uint64= _t real_addr) real_addr =3D wrap_address(env, real_addr) & TARGET_PAGE_MASK; =20 for (i =3D 0; i < TARGET_PAGE_SIZE; i +=3D 8) { - cpu_stq_mmuidx_ra(env, real_addr + i, 0, MMU_REAL_IDX, ra); + cpu_stq_be_mmuidx_ra(env, real_addr + i, 0, MMU_REAL_IDX, ra); } =20 return 0; @@ -2324,11 +2324,11 @@ void HELPER(idte)(CPUS390XState *env, uint64_t r1, = uint64_t r2, uint32_t m4) for (i =3D 0; i < entries; i++) { /* addresses are not wrapped in 24/31bit mode but table index = is */ raddr =3D table + ((index + i) & 0x7ff) * sizeof(entry); - entry =3D cpu_ldq_mmuidx_ra(env, raddr, MMU_REAL_IDX, ra); + entry =3D cpu_ldq_be_mmuidx_ra(env, raddr, MMU_REAL_IDX, ra); if (!(entry & REGION_ENTRY_I)) { /* we are allowed to not store if already invalid */ entry |=3D REGION_ENTRY_I; - cpu_stq_mmuidx_ra(env, raddr, entry, MMU_REAL_IDX, ra); + cpu_stq_be_mmuidx_ra(env, raddr, entry, MMU_REAL_IDX, ra); } } } @@ -2355,9 +2355,9 @@ void HELPER(ipte)(CPUS390XState *env, uint64_t pto, u= int64_t vaddr, pte_addr +=3D VADDR_PAGE_TX(vaddr) * 8; =20 /* Mark the page table entry as invalid */ - pte =3D cpu_ldq_mmuidx_ra(env, pte_addr, MMU_REAL_IDX, ra); + pte =3D cpu_ldq_be_mmuidx_ra(env, pte_addr, MMU_REAL_IDX, ra); pte |=3D PAGE_ENTRY_I; - cpu_stq_mmuidx_ra(env, pte_addr, pte, MMU_REAL_IDX, ra); + cpu_stq_be_mmuidx_ra(env, pte_addr, pte, MMU_REAL_IDX, ra); =20 /* XXX we exploit the fact that Linux passes the exact virtual address here - it's not obliged to! */ @@ -2695,7 +2695,7 @@ static int decode_utf16(CPUS390XState *env, uint64_t = addr, uint64_t ilen, if (ilen < 2) { return 0; } - s0 =3D cpu_lduw_data_ra(env, addr, ra); + s0 =3D cpu_lduw_be_data_ra(env, addr, ra); if ((s0 & 0xfc00) !=3D 0xd800) { /* one word character */ l =3D 2; @@ -2706,7 +2706,7 @@ static int decode_utf16(CPUS390XState *env, uint64_t = addr, uint64_t ilen, if (ilen < 4) { return 0; } - s1 =3D cpu_lduw_data_ra(env, addr + 2, ra); + s1 =3D cpu_lduw_be_data_ra(env, addr + 2, ra); c =3D extract32(s0, 6, 4) + 1; c =3D (c << 6) | (s0 & 0x3f); c =3D (c << 10) | (s1 & 0x3ff); @@ -2730,7 +2730,7 @@ static int decode_utf32(CPUS390XState *env, uint64_t = addr, uint64_t ilen, if (ilen < 4) { return 0; } - c =3D cpu_ldl_data_ra(env, addr, ra); + c =3D cpu_ldl_be_data_ra(env, addr, ra); if ((c >=3D 0xd800 && c <=3D 0xdbff) || c > 0x10ffff) { /* invalid unicode character */ return 2; @@ -2792,7 +2792,7 @@ static int encode_utf16(CPUS390XState *env, uint64_t = addr, uint64_t ilen, if (ilen < 2) { return 1; } - cpu_stw_data_ra(env, addr, c, ra); + cpu_stw_be_data_ra(env, addr, c, ra); *olen =3D 2; } else { /* two word character */ @@ -2802,8 +2802,8 @@ static int encode_utf16(CPUS390XState *env, uint64_t = addr, uint64_t ilen, d1 =3D 0xdc00 | extract32(c, 0, 10); d0 =3D 0xd800 | extract32(c, 10, 6); d0 =3D deposit32(d0, 6, 4, extract32(c, 16, 5) - 1); - cpu_stw_data_ra(env, addr + 0, d0, ra); - cpu_stw_data_ra(env, addr + 2, d1, ra); + cpu_stw_be_data_ra(env, addr + 0, d0, ra); + cpu_stw_be_data_ra(env, addr + 2, d1, ra); *olen =3D 4; } =20 @@ -2816,7 +2816,7 @@ static int encode_utf32(CPUS390XState *env, uint64_t = addr, uint64_t ilen, if (ilen < 4) { return 1; } - cpu_stl_data_ra(env, addr, c, ra); + cpu_stl_be_data_ra(env, addr, c, ra); *olen =3D 4; return -1; } diff --git a/target/s390x/tcg/vec_helper.c b/target/s390x/tcg/vec_helper.c index 46ec4a947dd..304745c971b 100644 --- a/target/s390x/tcg/vec_helper.c +++ b/target/s390x/tcg/vec_helper.c @@ -45,9 +45,9 @@ void HELPER(vll)(CPUS390XState *env, void *v1, uint64_t a= ddr, uint64_t bytes) if (likely(bytes >=3D 16)) { uint64_t t0, t1; =20 - t0 =3D cpu_ldq_data_ra(env, addr, GETPC()); + t0 =3D cpu_ldq_be_data_ra(env, addr, GETPC()); addr =3D wrap_address(env, addr + 8); - t1 =3D cpu_ldq_data_ra(env, addr, GETPC()); + t1 =3D cpu_ldq_be_data_ra(env, addr, GETPC()); s390_vec_write_element64(v1, 0, t0); s390_vec_write_element64(v1, 1, t1); } else { @@ -195,9 +195,9 @@ void HELPER(vstl)(CPUS390XState *env, const void *v1, u= int64_t addr, probe_write_access(env, addr, MIN(bytes, 16), GETPC()); =20 if (likely(bytes >=3D 16)) { - cpu_stq_data_ra(env, addr, s390_vec_read_element64(v1, 0), GETPC()= ); + cpu_stq_be_data_ra(env, addr, s390_vec_read_element64(v1, 0), GETP= C()); addr =3D wrap_address(env, addr + 8); - cpu_stq_data_ra(env, addr, s390_vec_read_element64(v1, 1), GETPC()= ); + cpu_stq_be_data_ra(env, addr, s390_vec_read_element64(v1, 1), GETP= C()); } else { int i; =20 --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763785362; cv=none; d=zohomail.com; s=zohoarc; b=HAbm43Edk6uqJl1mVKBSE+lGxMiuW12Khz0c9sfpwB5K8ddSYbC9HGZXrV10hbr0fKZH3khoFI8gsxVNuBoMknBLQM17iT6tak7S+hazTX892QaSSqFQj0jhd+axN63yimcGqBMK1sd74sf0eYCc5jp/bUBtGX38CPA79Ne6EME= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763785362; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lJnvThjS80O1Eon7AqXWBK1cOL1m23OMM4urIwDftzk=; b=lDFPs3YMpiokK/c/BwRa3VAlb6irjT0nlZZwHjSblt8nvwm62NzH9MvsJ2/8ya8ktCAqoDm66SpRPO3McIwVRJS0SfFxbc7GMXu8dNgxcGintIJguaTply+bEKGJWgTd4NDuCoC62iN6H768QmthvQU2DOV/bw39Hqo0NOyn4gM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17637853629138.646040912750891; Fri, 21 Nov 2025 20:22:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMdJ0-0002W0-Ep; Fri, 21 Nov 2025 21:24:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMdIx-0002Ru-2o for qemu-devel@nongnu.org; Fri, 21 Nov 2025 21:24:51 -0500 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMdI3-0005Ny-Bh for qemu-devel@nongnu.org; Fri, 21 Nov 2025 21:24:47 -0500 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-5957e017378so2718486e87.3 for ; Fri, 21 Nov 2025 18:23:38 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fb9190sm11433070f8f.33.2025.11.21.05.46.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:46:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763778213; x=1764383013; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lJnvThjS80O1Eon7AqXWBK1cOL1m23OMM4urIwDftzk=; b=EXfv9c8RAV69L2BEi3Mjdcab2MA4LBn2TJ3Uhd6sZF8a4mci/TSRTi5Lg3qBg9S5ia 5SDvVnPcSZrmFetkM7n9sALnS5/0LC+cW3VNsojAkjHRTj2gWZM6/wWvDFO1YLd52JvR 4VEAWPSZs33s4uHQQKCs35wMGr+bjrwWoIDwWUA2KYWe/7KpczjjCcrVoqvZxz+XpxAi +up7vB9hXlb+xxg33zEh6u4ayAWwLA0DKpyNtMSnbxp+ezRPGTTFVZgt4gQke+Z1WRv8 VAu2F3iYlv0JVyj/048GJJedB4QmnrFQJvPc0ymoZvGMAaUO71s0PZS4+IEehWu/s7b6 0wDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763778213; x=1764383013; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lJnvThjS80O1Eon7AqXWBK1cOL1m23OMM4urIwDftzk=; b=RkV3lwVTmy02mZuMQwLz3GREwDIyelcrk1R2d+IP9Ny1O3v8qvAlVG4M32XQZgLHtZ J6EHb3jDLC9M8SJMHfSw+3QG6fCq/htAe8vTrQu+2xPhlUa8NvsteXJ8h8/VO5sSqM0t 6l4Vce2bQVge+UpfCQiZzf5TNuw0RT75I6eob5GniwTolf+a5IN5LlDhSLuhWQzidGhr L829fFdz4w+GGpTHqkeWssYpaKrr1vecVaK7mNKQqaSInOS5/llC4jmx2/uTfcmBT6ji 4qkfj21in2Q3mjh/QVIB7Umm98rw9ZIzhz+gWdpCLtrsYk1psVROZTgIAxAYsGyX9m61 sDFA== X-Gm-Message-State: AOJu0YyoRl+uFipUbwO7JNmTrY1Zsere3P/kSZfdtPNknsBCJeziDdXF IK2v2Qtg/tWhMtllU7HC5CqAXZIdBaqLpj/ubWSxqd8WreoMuRIOSkDFDjvKyICGbr3qEzr7L3N pifWfRjJfiA== X-Gm-Gg: ASbGncuggRTD1vrEpICP/9gjIrSb054MVmA+rt+0NQEJNyNd3zsjGEut3ZdedFKuSHz F9QgaYhUXd4TIsru9vETUuy7AgjGlhayWu3mUliZx+kdXhAdGt1SAWpnD+JNGXsz/2PEiCEO9lc R994jG8322c5n/z+h+wH+7VE7CLyWncnfi9pJSxxoRRhXPxUCNY8+lE08eWEAtTdemaO5nldQWw LRj4VzeALoy25AB4kN4qRLxBhjHkjIWph+xqm+CKOj3WK+BxY4CO9FtFNmmtOdFHNiE6uKG4ML0 H+/Fmtps+V/sVnvyLO4urHfIPcDdYSvo1KAGkgZDS8L99YwU1GprwXyx7HitQGEUYLYanWPhmiJ r3VAHlUubbT/a05Zl2Gskxl0tCDTzUEmjDBWbxUbfxn1bMJpr9jIH4yG1B5f1BAhXC8k1o07iQd 7yvw/0aUz3LCfN0KZUOtnn56IZC5gMhlzwilk5VgkkjuL5ju1tDReZy8xD89BL X-Google-Smtp-Source: AGHT+IFqYpf7OzTRpcxxvO5Bao2UxERjKsBecu9gO/aVZFFnry2vwOoVXaYFKsCpYeCfbQtJbrWpIA== X-Received: by 2002:a05:6000:1447:b0:42b:3131:5434 with SMTP id ffacd0b85a97d-42cc1d0cfefmr2555882f8f.38.1763732805378; Fri, 21 Nov 2025 05:46:45 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 15/21] target/sparc: Use little-endian variant of cpu_ld/st_data*() Date: Fri, 21 Nov 2025 14:44:57 +0100 Message-ID: <20251121134503.30914-16-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::132; envelope-from=philmd@linaro.org; helo=mail-lf1-x132.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, T_SPF_HELO_TEMPERROR=0.01, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763785363617018900 We only build the SPARC targets using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Dsparc; \ end=3Dbe; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/ldst_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 2c63eb9e036..bd0257d313a 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -1228,13 +1228,13 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_u= long addr, ret =3D cpu_ldub_data(env, addr); break; case 2: - ret =3D cpu_lduw_data(env, addr); + ret =3D cpu_lduw_be_data(env, addr); break; case 4: - ret =3D cpu_ldl_data(env, addr); + ret =3D cpu_ldl_be_data(env, addr); break; case 8: - ret =3D cpu_ldq_data(env, addr); + ret =3D cpu_ldq_be_data(env, addr); break; default: g_assert_not_reached(); --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763777966; cv=none; d=zohomail.com; s=zohoarc; b=DdVGKluA6wCD30mDlBEocH0lfNUpFY5t5s96ZNsV6itJ9IKRL0fdtHQKVhFKO+gKcvb30qyHXpBjxflLmR/c7Vl4l+UIzCUV/N/c1Lkeo/kulSmJcSzItWsezFIZL0eqV3OkY+2T6t5H+7JC3A+rtDPDjHqkfU0RFty6mFzC93M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763777966; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qMl6uBUlgo9JdhQNBfwj9i8lTSS6pUDwuRBmc4GAuEM=; b=DluT5XDkjztUEy7JH2q8ul0Y/k0AGy2v1LAUOvvCGT7QQGhw+qUxNsIbxKF7hzpFbqHz0hwvMDhoef3dBpRTikoFKdzVDpyUEKn7FfRO+a9FFzWUZW2GltjVA3P+P4jI+5jq+vE7iSg8yf8mwfJo5LeNarM30YlMeshsPtP1UgA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763777966091564.1897160130504; Fri, 21 Nov 2025 18:19:26 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMcrv-0006i4-JI; Fri, 21 Nov 2025 20:56:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMbri-0004VP-1o for qemu-devel@nongnu.org; Fri, 21 Nov 2025 19:52:38 -0500 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMbpf-0000NE-AO for qemu-devel@nongnu.org; Fri, 21 Nov 2025 19:52:34 -0500 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-b727f452fffso609382166b.1 for ; Fri, 21 Nov 2025 16:50:14 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf3b4fafsm46415845e9.14.2025.11.21.05.46.51 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:46:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763772610; x=1764377410; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qMl6uBUlgo9JdhQNBfwj9i8lTSS6pUDwuRBmc4GAuEM=; b=WyziVGoIh7aeIoruX659gBhBXvWPD6dH0Quw8apsI7hjSfkN3x1GJuJtUFVYgMdznE 8/5SowpUO3Nx2rYKwQoN6uDbB06FtaJ/IpoAevPXes6wearh4a2BIOBYatL91vmVLEI/ pl0+hLc6f3wiyzmkfWRoYC3MZOPaXxPXI+tD0j5X9T5UDLir8kwD7aPWlFyTMWQNzmPM veMw02ISwap6+IbdOTviscw9LlAQgqc64tzSvc1U2bLGmtCXyZj56I3maU1Mbcy9kOcn 69YOwvbR26sFtcb0zBwKzOzpOtMsBArzRisyYy9ZkqVuvTVb+9P47kJ9IdAbe/jxsTcx tRhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763772610; x=1764377410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qMl6uBUlgo9JdhQNBfwj9i8lTSS6pUDwuRBmc4GAuEM=; b=kYBZyQO5U008x4xkeLoefYXi69bBTt7JZGLvVoeGo2P9zWkgY6Pf+78//6N9/9zZjx ZlCc1CqX+07AdDlDElSJwLaVALgOfizPFENjkpm7VBl1ZnX5awFt8tUMag45t3wJ45mX XYKyZkJDoEna4aUpXXW68BhmGy76fa6Fby7V5PyaqU75Xjh/FiWHGOMCe8fxnwHqywz3 RKpdUEbkgmCBBzvdl9yf6240TF8sSIrE8XodMqsudBAvIjkrzhqaXAOF7Ena3geS050/ 5RLJe+lU0M7FNHMmFX9/Qg3QmpNVdRrvQedysygvhHijVyPgD35r7hGeQlth25umuR5S bFGw== X-Gm-Message-State: AOJu0Yw/Bz2eigVOHmpZrdPFvUs3M1hFRjaemm57adf5sUFP6waI4TUE l1XSjwD76RFquFZotw8T9XvhC5yJIPksOmCFfOeOClv/DN80Aax8bh/91+cBVeEYErw3i+Gjb2w G1JNu/2tEyA== X-Gm-Gg: ASbGncsWN44Lc5OF/8ERBrO8tkcY5lIEX/Z6AfW10qNgwCaWlYT7RL3cgIMTFuK4Ufp HA+9sSNoqybZktlJWsjRFlVmUXI0NManY30WFCRvupyjRcfy7x9jXji3vT83C0HxS5dT09IR8PA vBXaO6AHjp4NXORPegA2mPTrktNIBlWg0mL4705uHUJsSbyiIX0fOEUPR2Muqys3YaysuaogBbd i6RIl2V1qgE6hUIRDEpthEwSY7LjnBmpjsHA4XQNSJZunnsvr914QdocCGb1cmT1PkY1QJO4QJT i3r8dyHzq0bzZNq/2dYn1Kqqpzarz6FvVl7tsqIqI1IvSXDbWLH8iIqTuiyS/p8doVG6S5oU4kv GYTfqOFbi7SiIy+0k/OhqC12fBQOOI2xw+e3rHiIg3HTqohVVMpNCG9TldVKEDsjCEazqgLzPkM 5DdJETfBRheFTSihT7A2zS2RrSjxLfFfyDrVYOOO7EUdUCtnQqbbIpv1JBJApX X-Google-Smtp-Source: AGHT+IGdBhi5O0ZpmCvVNgX2xQkFZj6h0tAjEJe04i7iw/upiBSzEXiAQhejyxoLyWb1PPzbjTVGuw== X-Received: by 2002:a05:600c:3044:b0:477:5639:ff66 with SMTP id 5b1f17b1804b1-477b9ef4949mr43035245e9.13.1763732812063; Fri, 21 Nov 2025 05:46:52 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 16/21] target/i386: Use little-endian variant of cpu_ld/st_data*() Date: Fri, 21 Nov 2025 14:44:58 +0100 Message-ID: <20251121134503.30914-17-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=philmd@linaro.org; helo=mail-ej1-x633.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763777968699018900 We only build the X86 targets using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Di386; \ end=3Dle; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/ops_sse.h | 12 +++---- target/i386/tcg/seg_helper.h | 12 +++---- linux-user/vm86.c | 4 +-- target/i386/tcg/mem_helper.c | 8 ++--- target/i386/tcg/mpx_helper.c | 28 ++++++++-------- target/i386/tcg/seg_helper.c | 16 +++++----- target/i386/tcg/system/excp_helper.c | 8 ++--- target/i386/tcg/system/svm_helper.c | 48 ++++++++++++++-------------- 8 files changed, 68 insertions(+), 68 deletions(-) diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h index a2e4d480399..213db53382c 100644 --- a/target/i386/ops_sse.h +++ b/target/i386/ops_sse.h @@ -2326,7 +2326,7 @@ void glue(helper_vpmaskmovd_st, SUFFIX)(CPUX86State *= env, =20 for (i =3D 0; i < (2 << SHIFT); i++) { if (v->L(i) >> 31) { - cpu_stl_data_ra(env, a0 + i * 4, s->L(i), GETPC()); + cpu_stl_le_data_ra(env, a0 + i * 4, s->L(i), GETPC()); } } } @@ -2338,7 +2338,7 @@ void glue(helper_vpmaskmovq_st, SUFFIX)(CPUX86State *= env, =20 for (i =3D 0; i < (1 << SHIFT); i++) { if (v->Q(i) >> 63) { - cpu_stq_data_ra(env, a0 + i * 8, s->Q(i), GETPC()); + cpu_stq_le_data_ra(env, a0 + i * 8, s->Q(i), GETPC()); } } } @@ -2369,7 +2369,7 @@ void glue(helper_vpgatherdd, SUFFIX)(CPUX86State *env, if (v->L(i) >> 31) { target_ulong addr =3D a0 + ((target_ulong)(int32_t)s->L(i) << scale); - d->L(i) =3D cpu_ldl_data_ra(env, addr, GETPC()); + d->L(i) =3D cpu_ldl_le_data_ra(env, addr, GETPC()); } v->L(i) =3D 0; } @@ -2383,7 +2383,7 @@ void glue(helper_vpgatherdq, SUFFIX)(CPUX86State *env, if (v->Q(i) >> 63) { target_ulong addr =3D a0 + ((target_ulong)(int32_t)s->L(i) << scale); - d->Q(i) =3D cpu_ldq_data_ra(env, addr, GETPC()); + d->Q(i) =3D cpu_ldq_le_data_ra(env, addr, GETPC()); } v->Q(i) =3D 0; } @@ -2397,7 +2397,7 @@ void glue(helper_vpgatherqd, SUFFIX)(CPUX86State *env, if (v->L(i) >> 31) { target_ulong addr =3D a0 + ((target_ulong)(int64_t)s->Q(i) << scale); - d->L(i) =3D cpu_ldl_data_ra(env, addr, GETPC()); + d->L(i) =3D cpu_ldl_le_data_ra(env, addr, GETPC()); } v->L(i) =3D 0; } @@ -2415,7 +2415,7 @@ void glue(helper_vpgatherqq, SUFFIX)(CPUX86State *env, if (v->Q(i) >> 63) { target_ulong addr =3D a0 + ((target_ulong)(int64_t)s->Q(i) << scale); - d->Q(i) =3D cpu_ldq_data_ra(env, addr, GETPC()); + d->Q(i) =3D cpu_ldq_le_data_ra(env, addr, GETPC()); } v->Q(i) =3D 0; } diff --git a/target/i386/tcg/seg_helper.h b/target/i386/tcg/seg_helper.h index ea98e1a98ed..20ce47d62d9 100644 --- a/target/i386/tcg/seg_helper.h +++ b/target/i386/tcg/seg_helper.h @@ -40,18 +40,18 @@ int cpu_mmu_index_kernel(CPUX86State *env); * and use *_mmuidx_ra directly. */ #define cpu_lduw_kernel_ra(e, p, r) \ - cpu_lduw_mmuidx_ra(e, p, cpu_mmu_index_kernel(e), r) + cpu_lduw_le_mmuidx_ra(e, p, cpu_mmu_index_kernel(e), r) #define cpu_ldl_kernel_ra(e, p, r) \ - cpu_ldl_mmuidx_ra(e, p, cpu_mmu_index_kernel(e), r) + cpu_ldl_le_mmuidx_ra(e, p, cpu_mmu_index_kernel(e), r) #define cpu_ldq_kernel_ra(e, p, r) \ - cpu_ldq_mmuidx_ra(e, p, cpu_mmu_index_kernel(e), r) + cpu_ldq_le_mmuidx_ra(e, p, cpu_mmu_index_kernel(e), r) =20 #define cpu_stw_kernel_ra(e, p, v, r) \ - cpu_stw_mmuidx_ra(e, p, v, cpu_mmu_index_kernel(e), r) + cpu_stw_le_mmuidx_ra(e, p, v, cpu_mmu_index_kernel(e), r) #define cpu_stl_kernel_ra(e, p, v, r) \ - cpu_stl_mmuidx_ra(e, p, v, cpu_mmu_index_kernel(e), r) + cpu_stl_le_mmuidx_ra(e, p, v, cpu_mmu_index_kernel(e), r) #define cpu_stq_kernel_ra(e, p, v, r) \ - cpu_stq_mmuidx_ra(e, p, v, cpu_mmu_index_kernel(e), r) + cpu_stq_le_mmuidx_ra(e, p, v, cpu_mmu_index_kernel(e), r) =20 #define cpu_lduw_kernel(e, p) cpu_lduw_kernel_ra(e, p, 0) #define cpu_ldl_kernel(e, p) cpu_ldl_kernel_ra(e, p, 0) diff --git a/linux-user/vm86.c b/linux-user/vm86.c index 5091d53fb84..4e120875a06 100644 --- a/linux-user/vm86.c +++ b/linux-user/vm86.c @@ -44,7 +44,7 @@ static inline int is_revectored(int nr, struct target_rev= ectored_struct *bitmap) static inline void vm_putw(CPUX86State *env, uint32_t segptr, unsigned int reg16, unsigned int val) { - cpu_stw_data(env, segptr + (reg16 & 0xffff), val); + cpu_stw_le_data(env, segptr + (reg16 & 0xffff), val); } =20 void save_v86_state(CPUX86State *env) @@ -157,7 +157,7 @@ static void do_int(CPUX86State *env, int intno) &ts->vm86plus.int21_revectored)) goto cannot_handle; int_addr =3D (intno << 2); - segoffs =3D cpu_ldl_data(env, int_addr); + segoffs =3D cpu_ldl_le_data(env, int_addr); if ((segoffs >> 16) =3D=3D TARGET_BIOSSEG) goto cannot_handle; LOG_VM86("VM86: emulating int 0x%x. CS:IP=3D%04x:%04x\n", diff --git a/target/i386/tcg/mem_helper.c b/target/i386/tcg/mem_helper.c index 9e7c2d80293..c15a32d60ad 100644 --- a/target/i386/tcg/mem_helper.c +++ b/target/i386/tcg/mem_helper.c @@ -30,8 +30,8 @@ void helper_boundw(CPUX86State *env, target_ulong a0, int= v) { int low, high; =20 - low =3D cpu_ldsw_data_ra(env, a0, GETPC()); - high =3D cpu_ldsw_data_ra(env, a0 + 2, GETPC()); + low =3D cpu_ldsw_le_data_ra(env, a0, GETPC()); + high =3D cpu_ldsw_le_data_ra(env, a0 + 2, GETPC()); v =3D (int16_t)v; if (v < low || v > high) { if (env->hflags & HF_MPX_EN_MASK) { @@ -45,8 +45,8 @@ void helper_boundl(CPUX86State *env, target_ulong a0, int= v) { int low, high; =20 - low =3D cpu_ldl_data_ra(env, a0, GETPC()); - high =3D cpu_ldl_data_ra(env, a0 + 4, GETPC()); + low =3D cpu_ldl_le_data_ra(env, a0, GETPC()); + high =3D cpu_ldl_le_data_ra(env, a0 + 4, GETPC()); if (v < low || v > high) { if (env->hflags & HF_MPX_EN_MASK) { env->bndcs_regs.sts =3D 0; diff --git a/target/i386/tcg/mpx_helper.c b/target/i386/tcg/mpx_helper.c index fa8abcc4820..73d33bf5e4a 100644 --- a/target/i386/tcg/mpx_helper.c +++ b/target/i386/tcg/mpx_helper.c @@ -44,7 +44,7 @@ static uint64_t lookup_bte64(CPUX86State *env, uint64_t b= ase, uintptr_t ra) } =20 bde =3D (extract64(base, 20, 28) << 3) + (extract64(bndcsr, 20, 44) <<= 12); - bt =3D cpu_ldq_data_ra(env, bde, ra); + bt =3D cpu_ldq_le_data_ra(env, bde, ra); if ((bt & 1) =3D=3D 0) { env->bndcs_regs.sts =3D bde | 2; raise_exception_ra(env, EXCP05_BOUND, ra); @@ -64,7 +64,7 @@ static uint32_t lookup_bte32(CPUX86State *env, uint32_t b= ase, uintptr_t ra) } =20 bde =3D (extract32(base, 12, 20) << 2) + (bndcsr & TARGET_PAGE_MASK); - bt =3D cpu_ldl_data_ra(env, bde, ra); + bt =3D cpu_ldl_le_data_ra(env, bde, ra); if ((bt & 1) =3D=3D 0) { env->bndcs_regs.sts =3D bde | 2; raise_exception_ra(env, EXCP05_BOUND, ra); @@ -79,9 +79,9 @@ uint64_t helper_bndldx64(CPUX86State *env, target_ulong b= ase, target_ulong ptr) uint64_t bte, lb, ub, pt; =20 bte =3D lookup_bte64(env, base, ra); - lb =3D cpu_ldq_data_ra(env, bte, ra); - ub =3D cpu_ldq_data_ra(env, bte + 8, ra); - pt =3D cpu_ldq_data_ra(env, bte + 16, ra); + lb =3D cpu_ldq_le_data_ra(env, bte, ra); + ub =3D cpu_ldq_le_data_ra(env, bte + 8, ra); + pt =3D cpu_ldq_le_data_ra(env, bte + 16, ra); =20 if (pt !=3D ptr) { lb =3D ub =3D 0; @@ -96,9 +96,9 @@ uint64_t helper_bndldx32(CPUX86State *env, target_ulong b= ase, target_ulong ptr) uint32_t bte, lb, ub, pt; =20 bte =3D lookup_bte32(env, base, ra); - lb =3D cpu_ldl_data_ra(env, bte, ra); - ub =3D cpu_ldl_data_ra(env, bte + 4, ra); - pt =3D cpu_ldl_data_ra(env, bte + 8, ra); + lb =3D cpu_ldl_le_data_ra(env, bte, ra); + ub =3D cpu_ldl_le_data_ra(env, bte + 4, ra); + pt =3D cpu_ldl_le_data_ra(env, bte + 8, ra); =20 if (pt !=3D ptr) { lb =3D ub =3D 0; @@ -113,9 +113,9 @@ void helper_bndstx64(CPUX86State *env, target_ulong bas= e, target_ulong ptr, uint64_t bte; =20 bte =3D lookup_bte64(env, base, ra); - cpu_stq_data_ra(env, bte, lb, ra); - cpu_stq_data_ra(env, bte + 8, ub, ra); - cpu_stq_data_ra(env, bte + 16, ptr, ra); + cpu_stq_le_data_ra(env, bte, lb, ra); + cpu_stq_le_data_ra(env, bte + 8, ub, ra); + cpu_stq_le_data_ra(env, bte + 16, ptr, ra); } =20 void helper_bndstx32(CPUX86State *env, target_ulong base, target_ulong ptr, @@ -125,9 +125,9 @@ void helper_bndstx32(CPUX86State *env, target_ulong bas= e, target_ulong ptr, uint32_t bte; =20 bte =3D lookup_bte32(env, base, ra); - cpu_stl_data_ra(env, bte, lb, ra); - cpu_stl_data_ra(env, bte + 4, ub, ra); - cpu_stl_data_ra(env, bte + 8, ptr, ra); + cpu_stl_le_data_ra(env, bte, lb, ra); + cpu_stl_le_data_ra(env, bte + 4, ub, ra); + cpu_stl_le_data_ra(env, bte + 8, ptr, ra); } =20 void helper_bnd_jmp(CPUX86State *env) diff --git a/target/i386/tcg/seg_helper.c b/target/i386/tcg/seg_helper.c index 667b1c38696..abce4331dfb 100644 --- a/target/i386/tcg/seg_helper.c +++ b/target/i386/tcg/seg_helper.c @@ -65,20 +65,20 @@ typedef struct StackAccess static void pushw(StackAccess *sa, uint16_t val) { sa->sp -=3D 2; - cpu_stw_mmuidx_ra(sa->env, sa->ss_base + (sa->sp & sa->sp_mask), + cpu_stw_le_mmuidx_ra(sa->env, sa->ss_base + (sa->sp & sa->sp_mask), val, sa->mmu_index, sa->ra); } =20 static void pushl(StackAccess *sa, uint32_t val) { sa->sp -=3D 4; - cpu_stl_mmuidx_ra(sa->env, sa->ss_base + (sa->sp & sa->sp_mask), + cpu_stl_le_mmuidx_ra(sa->env, sa->ss_base + (sa->sp & sa->sp_mask), val, sa->mmu_index, sa->ra); } =20 static uint16_t popw(StackAccess *sa) { - uint16_t ret =3D cpu_lduw_mmuidx_ra(sa->env, + uint16_t ret =3D cpu_lduw_le_mmuidx_ra(sa->env, sa->ss_base + (sa->sp & sa->sp_mask), sa->mmu_index, sa->ra); sa->sp +=3D 2; @@ -87,7 +87,7 @@ static uint16_t popw(StackAccess *sa) =20 static uint32_t popl(StackAccess *sa) { - uint32_t ret =3D cpu_ldl_mmuidx_ra(sa->env, + uint32_t ret =3D cpu_ldl_le_mmuidx_ra(sa->env, sa->ss_base + (sa->sp & sa->sp_mask), sa->mmu_index, sa->ra); sa->sp +=3D 4; @@ -905,12 +905,12 @@ static void do_interrupt_protected(CPUX86State *env, = int intno, int is_int, static void pushq(StackAccess *sa, uint64_t val) { sa->sp -=3D 8; - cpu_stq_mmuidx_ra(sa->env, sa->sp, val, sa->mmu_index, sa->ra); + cpu_stq_le_mmuidx_ra(sa->env, sa->sp, val, sa->mmu_index, sa->ra); } =20 static uint64_t popq(StackAccess *sa) { - uint64_t ret =3D cpu_ldq_mmuidx_ra(sa->env, sa->sp, sa->mmu_index, sa-= >ra); + uint64_t ret =3D cpu_ldq_le_mmuidx_ra(sa->env, sa->sp, sa->mmu_index, = sa->ra); sa->sp +=3D 8; return ret; } @@ -1887,7 +1887,7 @@ void helper_lcall_protected(CPUX86State *env, int new= _cs, target_ulong new_eip, pushl(&sa, env->segs[R_SS].selector); pushl(&sa, env->regs[R_ESP]); for (i =3D param_count - 1; i >=3D 0; i--) { - val =3D cpu_ldl_data_ra(env, + val =3D cpu_ldl_le_data_ra(env, old_ssp + ((env->regs[R_ESP] + i= * 4) & old_sp_mask), GETPC()); pushl(&sa, val); @@ -1896,7 +1896,7 @@ void helper_lcall_protected(CPUX86State *env, int new= _cs, target_ulong new_eip, pushw(&sa, env->segs[R_SS].selector); pushw(&sa, env->regs[R_ESP]); for (i =3D param_count - 1; i >=3D 0; i--) { - val =3D cpu_lduw_data_ra(env, + val =3D cpu_lduw_le_data_ra(env, old_ssp + ((env->regs[R_ESP] + = i * 2) & old_sp_mask), GETPC()); pushw(&sa, val); diff --git a/target/i386/tcg/system/excp_helper.c b/target/i386/tcg/system/= excp_helper.c index f622b5d588e..d7ea77c8558 100644 --- a/target/i386/tcg/system/excp_helper.c +++ b/target/i386/tcg/system/excp_helper.c @@ -90,7 +90,7 @@ static inline uint32_t ptw_ldl(const PTETranslate *in, ui= nt64_t ra) if (likely(in->haddr)) { return ldl_p(in->haddr); } - return cpu_ldl_mmuidx_ra(in->env, in->gaddr, in->ptw_idx, ra); + return cpu_ldl_le_mmuidx_ra(in->env, in->gaddr, in->ptw_idx, ra); } =20 static inline uint64_t ptw_ldq(const PTETranslate *in, uint64_t ra) @@ -98,7 +98,7 @@ static inline uint64_t ptw_ldq(const PTETranslate *in, ui= nt64_t ra) if (likely(in->haddr)) { return ldq_p(in->haddr); } - return cpu_ldq_mmuidx_ra(in->env, in->gaddr, in->ptw_idx, ra); + return cpu_ldq_le_mmuidx_ra(in->env, in->gaddr, in->ptw_idx, ra); } =20 /* @@ -116,9 +116,9 @@ static bool ptw_setl_slow(const PTETranslate *in, uint3= 2_t old, uint32_t new) cpu_exec_end(cpu); /* Does x86 really perform a rmw cycle on mmio for ptw? */ start_exclusive(); - cmp =3D cpu_ldl_mmuidx_ra(in->env, in->gaddr, in->ptw_idx, 0); + cmp =3D cpu_ldl_le_mmuidx_ra(in->env, in->gaddr, in->ptw_idx, 0); if (cmp =3D=3D old) { - cpu_stl_mmuidx_ra(in->env, in->gaddr, new, in->ptw_idx, 0); + cpu_stl_le_mmuidx_ra(in->env, in->gaddr, new, in->ptw_idx, 0); } end_exclusive(); cpu_exec_start(cpu); diff --git a/target/i386/tcg/system/svm_helper.c b/target/i386/tcg/system/s= vm_helper.c index 505788b0e26..811c0be2023 100644 --- a/target/i386/tcg/system/svm_helper.c +++ b/target/i386/tcg/system/svm_helper.c @@ -30,13 +30,13 @@ static void svm_save_seg(CPUX86State *env, int mmu_idx, hwaddr addr, const SegmentCache *sc) { - cpu_stw_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, selector), + cpu_stw_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, selector), sc->selector, mmu_idx, 0); - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, base), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, base), sc->base, mmu_idx, 0); - cpu_stl_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, limit), + cpu_stl_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, limit), sc->limit, mmu_idx, 0); - cpu_stw_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, attrib), + cpu_stw_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, attrib), ((sc->flags >> 8) & 0xff) | ((sc->flags >> 12) & 0x0f00), mmu_idx, 0); @@ -58,16 +58,16 @@ static void svm_load_seg(CPUX86State *env, int mmu_idx,= hwaddr addr, unsigned int flags; =20 sc->selector =3D - cpu_lduw_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, selector), + cpu_lduw_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, select= or), mmu_idx, 0); sc->base =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, base), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, base), mmu_idx, 0); sc->limit =3D - cpu_ldl_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, limit), + cpu_ldl_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, limit), mmu_idx, 0); flags =3D - cpu_lduw_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, attrib), + cpu_lduw_le_mmuidx_ra(env, addr + offsetof(struct vmcb_seg, attrib= ), mmu_idx, 0); sc->flags =3D ((flags & 0xff) << 8) | ((flags & 0x0f00) << 12); =20 @@ -507,31 +507,31 @@ void helper_vmload(CPUX86State *env, int aflag) =20 #ifdef TARGET_X86_64 env->kernelgsbase =3D - cpu_ldq_mmuidx_ra(env, + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.kernel_gs_base= ), mmu_idx, 0); env->lstar =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.lstar), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.lstar), mmu_idx, 0); env->cstar =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.cstar), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.cstar), mmu_idx, 0); env->fmask =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sfmask), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sfmask= ), mmu_idx, 0); svm_canonicalization(env, &env->kernelgsbase); #endif env->star =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.star), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.star), mmu_idx, 0); env->sysenter_cs =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_= cs), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysent= er_cs), mmu_idx, 0); env->sysenter_esp =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_= esp), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysent= er_esp), mmu_idx, 0); env->sysenter_eip =3D - cpu_ldq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_= eip), + cpu_ldq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysent= er_eip), mmu_idx, 0); } =20 @@ -567,22 +567,22 @@ void helper_vmsave(CPUX86State *env, int aflag) &env->ldt); =20 #ifdef TARGET_X86_64 - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.kernel_gs_bas= e), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.kernel_gs_= base), env->kernelgsbase, mmu_idx, 0); - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.lstar), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.lstar), env->lstar, mmu_idx, 0); - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.cstar), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.cstar), env->cstar, mmu_idx, 0); - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sfmask), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sfmask), env->fmask, mmu_idx, 0); #endif - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.star), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.star), env->star, mmu_idx, 0); - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_cs), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_c= s), env->sysenter_cs, mmu_idx, 0); - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_esp), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_e= sp), env->sysenter_esp, mmu_idx, 0); - cpu_stq_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_eip), + cpu_stq_le_mmuidx_ra(env, addr + offsetof(struct vmcb, save.sysenter_e= ip), env->sysenter_eip, mmu_idx, 0); } =20 --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763783789; cv=none; d=zohomail.com; s=zohoarc; b=h1mKNltBV2yeK1w3bEzePmQiP2a0LAZERPuCBLz1XgR988EslRPjm2z9hkJjVGPNqhp/x9SNZeYY+sDEUyrSRboBVSoa2l1+XvSNd8bv1hAnkwpwCZCj73MzAUC4AAuU37GYEtV7tbbfXXgVAa1WbviZjgJQ2gT/+pMg3KSHI1s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763783789; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=idPfVbwdmuwP3E4rOS4isKmneb6eqTi31QSmeF+nOd0=; b=ezEwnDbbO/iQlCXzYOy5KI5cWBgUUHtcBiYoWkGEm0jckNfdymQ7uk5ILs+RqtmKzEUdPeAMxtqxTFrbUquYi4EKTRSVs4Fm0EL/YNxIGODwwUXUh0FUXTwgqmwE9fWrS3Tu/2HyecRL92WMDqpFvCRnFjWK7oK8vwbmZlxxO5I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763783789834540.1646383835566; Fri, 21 Nov 2025 19:56:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMcyz-00040e-5r; Fri, 21 Nov 2025 21:04:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMc96-00067H-Oj for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:10:36 -0500 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMc8v-0004O2-7Z for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:10:33 -0500 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-640c6577120so4506686a12.1 for ; Fri, 21 Nov 2025 17:10:07 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477a9d198a0sm89777255e9.1.2025.11.21.05.46.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:46:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763773803; x=1764378603; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=idPfVbwdmuwP3E4rOS4isKmneb6eqTi31QSmeF+nOd0=; b=bGNkdO0uXS3PeVL8/SDei1gP1ERmThgkM7k2ADs5AzY1nfkHfIq76pXunWq8US09vb l142eDQyX4qvlWzv/yZtZ1d/hd48qbrBaE7a51AoNS74ae0+BMpNDGeLpYN0LrIqu3vm JAVTXz+ijitAvLwYEtRODIxlrYNVx2VDA2nBhCh85xV/SJIC1j+nsfGuVGujDDGZVkPb PLrFQLg6qlmP2w8F9TMkXmjzIeRvyb9bRkjwsWHfAjcOA5h9YWPliEAYEUgKAEkrsJeP 4s/K2PeNkuUNd692Mx9yHCgJ6vzPSGJDIQv+il1HAoyLBsYDoS/sSKR/SrPktfE1/vFT ZFpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763773803; x=1764378603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=idPfVbwdmuwP3E4rOS4isKmneb6eqTi31QSmeF+nOd0=; b=cY69+NbS2zyr5Kpe4M4LdJIyNzzj7/Utu6UglfaDuu1jfW2pHcSsGnNTJWv7LAMh/G ZijmvfmHKVikPmvw130JvIgM0reDMn1CptlnlxbJmPoCcXPUtOPexIDjzlpIIOkwvG0S pL/Pu1bXI6jKwdnm6zVA4/pAqgoWi02TgNme4J4Jum56DBL9qqfl0J/5qtCZo5eKGzCy u9vsuhIRYoc5WHEzpxsDnwY0n5r6IMukrsAp4zqLaY4dbOz7UgmNyYNyq/F66cYDEM8s 9q7oBrGS2Gqipi2aeSXvMFrXEl7sySgTRW1agLLGgI8PoRqD6beF/gzYQQ85Tme5lVAM akRA== X-Gm-Message-State: AOJu0YzlQ/jXacF5MpQQhHDJI07S5ELzJ2CZsdHHCCJde9UjXo8X1zMV oipOmTRy+blkokV2LjM88pGXOUsPqylMvcHxOSTB1Zg4lKD9AT6ErhNY/oETS589KekJ6/doQSQ D6SkwAibNmA== X-Gm-Gg: ASbGncuBolYqjWk7H3p1hq5c2kWY197NGzPS4JaPZzX9ZRQA/maYES4luy/IwNJpBiK VHmBMetXiMQQXwROcph6YpaTua/mC4ItDUQvSJZ7/Ll/BTb6+m+5t9l2XoGTU6mkgG8T1zHFJVG /9rXUzFvkkBj12jCejjBABPM664PPd/0OkNWdXDMFqFfDD3ieQfKUsBYDR8alEidIPMY1m9mMYm LJ/esFI06VeCk3fA0ik9+AoyG4lNnLbcJVW7sl/IV6V6m5SueL1LGjupWMKBPv7Df6sXYJncMTw 8eBXLuD7MsU32qs2lHgPBS77SOFzgW0aHpIJe0daegkOywP97p6pjFwcVKA2f3s3r4Ynl0anUbo zFJ1gbYaRMvUeXdenRqFXNb0/VQOdX4jvsQnWur/wgACRBWSaCLTpF31qe541Yv+nkerXu3ip8Y 2YV+AenNcWFV2Zl0qpAxmnqExRbvdbMpMCnnzIY9UC5Ga7YMRxNKGCb9paZkMK X-Google-Smtp-Source: AGHT+IH+uEE+/4R1zJ5ztiI6Pff08c5Gs3ZGj74tnpiLS+8MRfOsoHT0hEwp923OtZbxPABO7cZTFA== X-Received: by 2002:a05:600c:3baa:b0:475:de12:d3b5 with SMTP id 5b1f17b1804b1-477c01ecc7cmr24811975e9.34.1763732818671; Fri, 21 Nov 2025 05:46:58 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 17/21] target/hppa: Use little-endian variant of cpu_ld/st_data*() Date: Fri, 21 Nov 2025 14:44:59 +0100 Message-ID: <20251121134503.30914-18-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=philmd@linaro.org; helo=mail-ed1-x536.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763783791261018900 We only build the HPPA target using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=3Dhppa; \ end=3Dbe; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/hppa/op_helper.c | 44 ++++++++++++++++++++--------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c index 0458378abb2..65faf03cd0a 100644 --- a/target/hppa/op_helper.c +++ b/target/hppa/op_helper.c @@ -107,7 +107,7 @@ static void do_stby_b(CPUHPPAState *env, target_ulong a= ddr, target_ulong val, cpu_stb_data_ra(env, addr, val, ra); break; case 2: - cpu_stw_data_ra(env, addr, val, ra); + cpu_stw_be_data_ra(env, addr, val, ra); break; case 1: /* The 3 byte store must appear atomic. */ @@ -115,11 +115,11 @@ static void do_stby_b(CPUHPPAState *env, target_ulong= addr, target_ulong val, atomic_store_mask32(env, addr, val, 0x00ffffffu, ra); } else { cpu_stb_data_ra(env, addr, val >> 16, ra); - cpu_stw_data_ra(env, addr + 1, val, ra); + cpu_stw_be_data_ra(env, addr + 1, val, ra); } break; default: - cpu_stl_data_ra(env, addr, val, ra); + cpu_stl_be_data_ra(env, addr, val, ra); break; } } @@ -132,7 +132,7 @@ static void do_stdby_b(CPUHPPAState *env, target_ulong = addr, uint64_t val, cpu_stb_data_ra(env, addr, val, ra); break; case 6: - cpu_stw_data_ra(env, addr, val, ra); + cpu_stw_be_data_ra(env, addr, val, ra); break; case 5: /* The 3 byte store must appear atomic. */ @@ -140,11 +140,11 @@ static void do_stdby_b(CPUHPPAState *env, target_ulon= g addr, uint64_t val, atomic_store_mask32(env, addr, val, 0x00ffffffu, ra); } else { cpu_stb_data_ra(env, addr, val >> 16, ra); - cpu_stw_data_ra(env, addr + 1, val, ra); + cpu_stw_be_data_ra(env, addr + 1, val, ra); } break; case 4: - cpu_stl_data_ra(env, addr, val, ra); + cpu_stl_be_data_ra(env, addr, val, ra); break; case 3: /* The 5 byte store must appear atomic. */ @@ -152,7 +152,7 @@ static void do_stdby_b(CPUHPPAState *env, target_ulong = addr, uint64_t val, atomic_store_mask64(env, addr, val, 0x000000ffffffffffull, 5, = ra); } else { cpu_stb_data_ra(env, addr, val >> 32, ra); - cpu_stl_data_ra(env, addr + 1, val, ra); + cpu_stl_be_data_ra(env, addr + 1, val, ra); } break; case 2: @@ -160,8 +160,8 @@ static void do_stdby_b(CPUHPPAState *env, target_ulong = addr, uint64_t val, if (parallel) { atomic_store_mask64(env, addr, val, 0x0000ffffffffffffull, 6, = ra); } else { - cpu_stw_data_ra(env, addr, val >> 32, ra); - cpu_stl_data_ra(env, addr + 2, val, ra); + cpu_stw_be_data_ra(env, addr, val >> 32, ra); + cpu_stl_be_data_ra(env, addr + 2, val, ra); } break; case 1: @@ -170,12 +170,12 @@ static void do_stdby_b(CPUHPPAState *env, target_ulon= g addr, uint64_t val, atomic_store_mask64(env, addr, val, 0x00ffffffffffffffull, 7, = ra); } else { cpu_stb_data_ra(env, addr, val >> 48, ra); - cpu_stw_data_ra(env, addr + 1, val >> 32, ra); - cpu_stl_data_ra(env, addr + 3, val, ra); + cpu_stw_be_data_ra(env, addr + 1, val >> 32, ra); + cpu_stl_be_data_ra(env, addr + 3, val, ra); } break; default: - cpu_stq_data_ra(env, addr, val, ra); + cpu_stq_be_data_ra(env, addr, val, ra); break; } } @@ -211,12 +211,12 @@ static void do_stby_e(CPUHPPAState *env, target_ulong= addr, target_ulong val, if (parallel) { atomic_store_mask32(env, addr - 3, val, 0xffffff00u, ra); } else { - cpu_stw_data_ra(env, addr - 3, val >> 16, ra); + cpu_stw_be_data_ra(env, addr - 3, val >> 16, ra); cpu_stb_data_ra(env, addr - 1, val >> 8, ra); } break; case 2: - cpu_stw_data_ra(env, addr - 2, val >> 16, ra); + cpu_stw_be_data_ra(env, addr - 2, val >> 16, ra); break; case 1: cpu_stb_data_ra(env, addr - 1, val >> 24, ra); @@ -239,8 +239,8 @@ static void do_stdby_e(CPUHPPAState *env, target_ulong = addr, uint64_t val, atomic_store_mask64(env, addr - 7, val, 0xffffffffffffff00ull, 7, ra); } else { - cpu_stl_data_ra(env, addr - 7, val >> 32, ra); - cpu_stw_data_ra(env, addr - 3, val >> 16, ra); + cpu_stl_be_data_ra(env, addr - 7, val >> 32, ra); + cpu_stw_be_data_ra(env, addr - 3, val >> 16, ra); cpu_stb_data_ra(env, addr - 1, val >> 8, ra); } break; @@ -250,8 +250,8 @@ static void do_stdby_e(CPUHPPAState *env, target_ulong = addr, uint64_t val, atomic_store_mask64(env, addr - 6, val, 0xffffffffffff0000ull, 6, ra); } else { - cpu_stl_data_ra(env, addr - 6, val >> 32, ra); - cpu_stw_data_ra(env, addr - 2, val >> 16, ra); + cpu_stl_be_data_ra(env, addr - 6, val >> 32, ra); + cpu_stw_be_data_ra(env, addr - 2, val >> 16, ra); } break; case 5: @@ -260,24 +260,24 @@ static void do_stdby_e(CPUHPPAState *env, target_ulon= g addr, uint64_t val, atomic_store_mask64(env, addr - 5, val, 0xffffffffff000000ull, 5, ra); } else { - cpu_stl_data_ra(env, addr - 5, val >> 32, ra); + cpu_stl_be_data_ra(env, addr - 5, val >> 32, ra); cpu_stb_data_ra(env, addr - 1, val >> 24, ra); } break; case 4: - cpu_stl_data_ra(env, addr - 4, val >> 32, ra); + cpu_stl_be_data_ra(env, addr - 4, val >> 32, ra); break; case 3: /* The 3 byte store must appear atomic. */ if (parallel) { atomic_store_mask32(env, addr - 3, val >> 32, 0xffffff00u, ra); } else { - cpu_stw_data_ra(env, addr - 3, val >> 48, ra); + cpu_stw_be_data_ra(env, addr - 3, val >> 48, ra); cpu_stb_data_ra(env, addr - 1, val >> 40, ra); } break; case 2: - cpu_stw_data_ra(env, addr - 2, val >> 48, ra); + cpu_stw_be_data_ra(env, addr - 2, val >> 48, ra); break; case 1: cpu_stb_data_ra(env, addr - 1, val >> 56, ra); --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763783003; cv=none; d=zohomail.com; s=zohoarc; b=n8wnj40NeFplNxTN6R/RU/dJICSER71KTKCTTQciLPgf0tmhPAQacp44tE8na87JEs824cFdwx9nlTQmZJt7eqjm0NrN1odo3eD7SuxU0C7gFbhOvKtk6MgqadzyJmV96AqDAQrRMHBRsYV5VRvlcwNx811xoEfxjRpcMx/FONk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763783003; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1/moKxyhhhNUAAssiCB4z5/4yHLvVf9L6ospDexZsZ8=; b=h87qAICf97/8EahvO9ad5YyZN/BW/2HiUNoe8cxu3pAutAjpbnXe/8vJN2DcrmxcivqZGakhYzw3S97tscxdjv3VnTU3nLidVKaBnbROoXoXYikaB6MiD7fs4k/0QZAcdw7bgzBK6M5IRHMbziwgHhxJ9dj/e4RP6WFRN5+bDMo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17637830035661023.0552401917843; Fri, 21 Nov 2025 19:43:23 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMd4Z-0002qa-1n; Fri, 21 Nov 2025 21:10:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMcQD-0006kF-RQ for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:28:17 -0500 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMcOB-00009Y-AQ for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:28:14 -0500 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-5957d7e0bf3so3410769e87.0 for ; Fri, 21 Nov 2025 17:25:54 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd9b45sm10967945f8f.43.2025.11.21.05.47.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:47:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763774751; x=1764379551; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1/moKxyhhhNUAAssiCB4z5/4yHLvVf9L6ospDexZsZ8=; b=PG13HG37yyVlU69B01i5+DpTCK4cumYnGbejPOA2eKkLGYymoloWK3GjPcVQUAmAvv 2A6HT4M1YLiQqbhHt7augbZHQOX/HmzAmBGFqxUiQNPpXxV7I6vztkCKTM1cDXzTwH4h aTvUGm5lKQ/qrmQ0sNlwVA3pNjBzb1fgvVyV1UKGMeGOb7VkzKHGig+N1Op4cpBKB7ih +45+C9ek614rXQ6CjYSY6prEjmuyVHvxKzEjonciAcUvYQEr242dCorNAH4VxTNRU/mc UPdvuG3+m61kuValvMTIHqbGCgk9/6naZw/JPAM1j1EX4nmFI4KzMELTiDUWG2kZVirC MEgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763774751; x=1764379551; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1/moKxyhhhNUAAssiCB4z5/4yHLvVf9L6ospDexZsZ8=; b=NX1A6XUmwQJdgVcr5Qz9jjQKOeITr8SU3ZkeAdbjP4RJsMLQsDlhoMdjhHGbp2UHri 5oZZcradTAh/g14z5/mJ0pQeE3dSNfgkmVl0IkZWgzcUgqHElt1pIqfB6GifsPo57y/i 3mi4VIp5jmZB2wPIHN/gyLo6ct3H3pqcfbDJ5FBi0wRWzWAPyruyy0L1ufHZmTU+/Pqy d9u7PiXB5X2AbhCYFiwFGiMYXeNap1U954BX8NikasvrFW9my3RypUeDve+ZOE2i4vmw JmFe4RIYt8l3nthb9mTsYGGx24nfFoF1QzxwB4Mdd1nxW27AL3eTAwkLMHADUaL8Q147 pX8Q== X-Gm-Message-State: AOJu0YytBSCXv9mq2CZN/hymOMU8bzQ/tI321W/ZrVRnJv9Nsgx7SJtH pz5fdByazOTdkOM2yZSrzKl7Y7suUSJBd2xT5H0edF1Okeswffz+pk859QWs7nabebJtJQteLLk mZ7U5rkdiPA== X-Gm-Gg: ASbGncureaCQhgsFm2QfcH6Msgtl/fSdyHsLW5cxngZ+ipsXG6CzQ/Fxn0JKG+r/Mt7 uJWZzR1qb8FpEyWlWXbE9Ybw+qhWGumLNxs+J5awpVeCtAUfvAvdqWBVCFXcX5cch2kivDpfLtc xuhB2WYtdADZZK0fGkjA8EPpmelczV8tAeyFYLN0biTy2Hfx2pOYpjY8rCkTKRfKkAkcPw8VhFU lbcWCXPae8ebox5rp18OcfNxktXoDCHyeaPIskBhDMoXm8zD7ERWzx8g4PvKWc6CMArqplT+kBx dUMTkfo12+hLcdNR44JKBvKjWW1+GKpsWHoRJswncay5EKnPo2JLd3Ux2huG0Bbogxu1bOvCcZE B0KpGiFGM7TRcvBRPix7yp7mJaLaiUfNT2jTNz2bLsUca2VwfxN/VfjCnIuMsHyVKPyReEEAkDm JpJO2J8/Eg7Gv6Op6kjH4KRM5CW9U87cwqKc9f+1/ZDEiF+Hxl5tmEHCatSKPm X-Google-Smtp-Source: AGHT+IFbzcN20DaScomzYsmHRjV5CSt4lWO3KEMLbuCDkYs27Zm60r6STNqOz8jmbV2tgt6MpEztDw== X-Received: by 2002:a5d:5850:0:b0:429:c719:e0aa with SMTP id ffacd0b85a97d-42cba63a6f8mr7604810f8f.6.1763732825240; Fri, 21 Nov 2025 05:47:05 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 18/21] target/riscv: Use little-endian variant of cpu_ld/st_data*() for vector Date: Fri, 21 Nov 2025 14:45:00 +0100 Message-ID: <20251121134503.30914-19-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::135; envelope-from=philmd@linaro.org; helo=mail-lf1-x135.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763783004401018900 RISC-V vector "elements are simply packed in order from the least-signicant to most-signicant bits of the vector register" [*] which is little endianness, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. [*] RISC-V "V" Vector Extension v1.0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/riscv/vector_helper.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 2de3358ee86..caa8dd9c125 100644 --- a/target/riscv/vector_helper.c +++ b/target/riscv/vector_helper.c @@ -193,9 +193,9 @@ void NAME##_host(void *vd, uint32_t idx, void *host) = \ } =20 GEN_VEXT_LD_ELEM(lde_b, uint8_t, H1, ldub) -GEN_VEXT_LD_ELEM(lde_h, uint16_t, H2, lduw) -GEN_VEXT_LD_ELEM(lde_w, uint32_t, H4, ldl) -GEN_VEXT_LD_ELEM(lde_d, uint64_t, H8, ldq) +GEN_VEXT_LD_ELEM(lde_h, uint16_t, H2, lduw_le) +GEN_VEXT_LD_ELEM(lde_w, uint32_t, H4, ldl_le) +GEN_VEXT_LD_ELEM(lde_d, uint64_t, H8, ldq_le) =20 #define GEN_VEXT_ST_ELEM(NAME, ETYPE, H, STSUF) \ static inline QEMU_ALWAYS_INLINE \ @@ -214,9 +214,9 @@ void NAME##_host(void *vd, uint32_t idx, void *host) = \ } =20 GEN_VEXT_ST_ELEM(ste_b, uint8_t, H1, stb) -GEN_VEXT_ST_ELEM(ste_h, uint16_t, H2, stw) -GEN_VEXT_ST_ELEM(ste_w, uint32_t, H4, stl) -GEN_VEXT_ST_ELEM(ste_d, uint64_t, H8, stq) +GEN_VEXT_ST_ELEM(ste_h, uint16_t, H2, stw_le) +GEN_VEXT_ST_ELEM(ste_w, uint32_t, H4, stl_le) +GEN_VEXT_ST_ELEM(ste_d, uint64_t, H8, stq_le) =20 static inline QEMU_ALWAYS_INLINE void vext_continuous_ldst_tlb(CPURISCVState *env, vext_ldst_elem_fn_tlb *ldst_t= lb, --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763808481; cv=none; d=zohomail.com; s=zohoarc; b=lZiH9EV/hG9hZbKtq3/wH+H7iIna4ujMq+CfHpd8dZGFGgfQ6Qu9mHenGEz288v/UxjVPnzX3Y6nqWVSxl3d2ZHILgQVsqBB7j7NzAUwwLaWHB1tIxOvq4lvkNqdXm+0SMhCGuIq3sNL/1N1iQtfA7qFRt81y7GLblz2A04yChc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763808481; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yQ3G/f5z9MwEGa9QMBSOfQ0OhqIrmAfETxxhBlriST8=; b=XF4RirzsezGq9HVKBPsdrTuiYDqStM9wvuOC9/qIWRma2qtQxZFZWrSHJbKgoHPVFFisF/J8M5YiexF9IOXz+qCr0UlM42blPzX2qh+gG1QJTQgygKg1/eIFZv8w7MluAhMSQ/ryoPwciVz3FjyMMPdbE+Xeo7/YVia7uWjskg4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763808481227373.146029938581; Sat, 22 Nov 2025 02:48:01 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMclN-0001Va-JF; Fri, 21 Nov 2025 20:50:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMbRo-0005jG-P5 for qemu-devel@nongnu.org; Fri, 21 Nov 2025 19:25:55 -0500 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMbPl-0002fW-N4 for qemu-devel@nongnu.org; Fri, 21 Nov 2025 19:25:49 -0500 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-37b9d8122fdso20479331fa.3 for ; Fri, 21 Nov 2025 16:23:28 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf1e872esm45046375e9.5.2025.11.21.05.47.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:47:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763771004; x=1764375804; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yQ3G/f5z9MwEGa9QMBSOfQ0OhqIrmAfETxxhBlriST8=; b=Z73HXqDlrfLyQu+y4dXSyjNBdJjh6a4ZU0dwzunro+MOhY3lg32AQQ0CncnlwoCbxW 2d54fLQLDl69gM/7MVvS2IP7/qGVP31tYshd+66nJnuMx3PI5io78OBqAmDN9/Rj4AP3 H+3NQSjoH0daHiHu+T9ROQviRiWc2AppvGFD3g8NJXU+mWDatF2EcKwMqBAeePtc7oNr 1LA15+slrKTBRjOb4BFkzuhryzAHpU8Yd96nsljRd/uesSyAN5yh2A9kxu0dAEgyhDRP qvtKWliTy5QOJAWc3VAK2ExyyKQ9ft+EUeuk3MiHDXQfHmuqX2nopYc+JOSiFlYdZEFS HrdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763771004; x=1764375804; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yQ3G/f5z9MwEGa9QMBSOfQ0OhqIrmAfETxxhBlriST8=; b=iY5X0IgsrYUvFO8vy2+PkZa1a+BA74PgSOYTLxPPkP/lkjsxBVL5sbO4M9ety3cUr8 63qNqc7g3EKfUt6QeTmcAjBfHIhOUFZ6zEwU28GaTWXV2N9WT1cxawMebJV/oCmeE553 ejtsPAnqEdfY0qbWxq7WTUX3x7sSLnFI6fUEbSaPJsAF7CQ+yi7cLXB9b0f0jQi9OABs gm+whHtcDaI/MP8k60ko35w2Lyyr3PGDakTLIa+Av8DApg/n5ySCmFDXi6V2dMClHekX xswjnnu1JsAtsIBN0XuwzqalpONjfHam5LXDQdNBUpFuCBQOu9hg7m51SsqgQhjapP1N LwKQ== X-Gm-Message-State: AOJu0YwwUR4BfMYMXB4XKVnB5X4X96mdKGnfPU7oPLwQUS/8z+WGwAdk C3fj44Ea+HTjZ02NJ2p5g3BL0Bk77Z1intzs0Z/tsGK0qF9UlC+KglKbazlYRt5dCZ1hoXNdB5k EfPMOphkS6w== X-Gm-Gg: ASbGnctu/NVVVK3F4Bb2Mi+f+StWsSR+KNQj7dQENRnidxHImEBowLc8zeNb9+TBLcW peABlqSlikQrMgAhaQ/L/QrivUMdBrPxWKZ7vvLVaeUWW5Wn0aBkss+mDO436lxRZH8WT1UtSqW /qOT3X6/GV9EDKViwkd+QujEGHk4Aooh537KF4zeCMBR1Pr3vYyzpMzYcjxz6GqgCKvs6pGSpvG +LPF2URVQXNz7Wu5o7klTTZNmScDWZ+AMkqjbhRJVPBawdG9aNe6laR3QvdqkydAnaMHJojFE39 kB9YKZ6ZsmfEu6w4Q8Tyh0oD4COewNwLB7ca0vo3e0pDCRxXQIUNOGJC+Bbn2UxfUnUAMq/xDj0 XdtVAxdQwML9g9gbgxg3W2KzMZN7piTZnSx0wgZCjrl60uq6nG5YODF6doemdcr/BP3cQhMn7cH 3x7jUB6tWrbDGB9EgHe8HBEpX7J3wL67NLcdsH1xPnc7mPYm1Y//8k3rOtzugY X-Google-Smtp-Source: AGHT+IFbF4f4MylMWtflv3T7K6D1FOB2iY1tVyDtTNkEg2MW4/BeMV+80VdGErsxIt8RwoWpfU+jzg== X-Received: by 2002:a05:600c:4684:b0:477:9c73:2680 with SMTP id 5b1f17b1804b1-477c01bf658mr25170915e9.23.1763732831887; Fri, 21 Nov 2025 05:47:11 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 19/21] target/sh4: Replace cpu_stl_data() by explicit endianness variants Date: Fri, 21 Nov 2025 14:45:01 +0100 Message-ID: <20251121134503.30914-20-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::22a; envelope-from=philmd@linaro.org; helo=mail-lj1-x22a.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763808483193018900 See commit 852d481faf7 ("SH: Improve movca.l/ocbi emulation") for more context on this code. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sh4/op_helper.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/sh4/op_helper.c b/target/sh4/op_helper.c index 557b1bf4972..63515cc5e6c 100644 --- a/target/sh4/op_helper.c +++ b/target/sh4/op_helper.c @@ -143,7 +143,11 @@ void helper_ocbi(CPUSH4State *env, uint32_t address) if ((a & ~0x1F) =3D=3D (address & ~0x1F)) { memory_content *next =3D (*current)->next; - cpu_stl_data(env, a, (*current)->value); + if (TARGET_BIG_ENDIAN) { + cpu_stl_be_data(env, a, (*current)->value); + } else { + cpu_stl_le_data(env, a, (*current)->value); + } =20 if (next =3D=3D NULL) { --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763781200; cv=none; d=zohomail.com; s=zohoarc; b=adjyoBZq1PLJV4KgXzszMmkBC3QIVPuXcIHKUFQz3lclB5YyWx6oiQ7rUZAp/TZppCDCwKh9G+HOAX3ueyNrQWxJv//JLbEu6bnu47vZM7e/HP4lZmO8yeXaOkPSbwGak8+RXOQUqG0B6t2xUs+Hg3xp3f4K/AQPvgDru9ezwnw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763781200; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HDoRFtIf4DtlaKu8FqeCDNwKdTIWIuyOpEl6R55IExI=; b=bYtNO1QWVCyX6TaKvjspkw4SSDRg7cJFM1kwRm+HSJwyPsmD0vd1qWqgelaa0DfFIhY+g6IWl82qsg4wptlZnWn3mUt045cG8D1mlVJSKppA1DcTiOiARYXRQRaNMV1GHY96aRoVhjKrOUeFiby0/BA08dVkix+d+ELirPUJT/Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763781200513792.0368005343819; Fri, 21 Nov 2025 19:13:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMd7W-00052q-DT; Fri, 21 Nov 2025 21:13:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMd1g-0000yn-Hx for qemu-devel@nongnu.org; Fri, 21 Nov 2025 21:07:00 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMd0G-0001xw-OW for qemu-devel@nongnu.org; Fri, 21 Nov 2025 21:06:10 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-477a1c28778so29139155e9.3 for ; Fri, 21 Nov 2025 18:05:16 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f2e432sm10714737f8f.9.2025.11.21.05.47.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:47:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763777111; x=1764381911; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HDoRFtIf4DtlaKu8FqeCDNwKdTIWIuyOpEl6R55IExI=; b=wpAT4l8/ZVZ2A4tH+Tt5s5Ff5LzJw/VgGr2G4/R2YIcGyomJDXsiTr9yt7utLF28Ls m+JTRCPZUFsAa8IydxSue+e5+PGxG07+ed9PC1NJflFtsd3qIWTPIjKiChEombYvE4Ni 3Ox8DxKNCIP9HiiYZ1w/ifZdNXCVwouh5RnEGFPd1SaU/hSMdgdZkzxbNeXtb2Fs93zN WehPT9rluiKADANxDYUirksYQU5x0P9kSFn3sVOVOB9X3DyayoiSh31u/NTakHwszWGD lCuaiTJweDRUylCcsMf2BM2m84Sg8Zqd3D3MxCNFw6S48QCvGrU2FP1JIcGJR5ePjX/R +Nhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763777111; x=1764381911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HDoRFtIf4DtlaKu8FqeCDNwKdTIWIuyOpEl6R55IExI=; b=dbNSzcIBS4mWLQ2jE2qg94Y3nZ8WXpW0THzK7HGKj+zABjBzVjgUZsDx+2MLTpb9+n Frp3b4hfDrHd+pkXeOiyTo8sI/X9gW1IDN4kQXb3K01QYXxuNDOKqege2EAze3Jal/AI TT6GQ6mLrtertgb97mTAfVRc4+Dc3mKI2nwLWglPjyQgNqCer9b3hdJV4+dV1V3migtK DIpTxFHJpWbk6+P/FpqKMJPqJE2ZcnfOJfxvko2ylE1TV7tZVN/OEugz2qV1ZRyxEf/b xX7zEA0a1bfG1qhRV4AwHIyTdjCz4YMZUKeL6+6Fct7nIqPuZoLYOTcwFE4JwDniiQxn Z0zQ== X-Gm-Message-State: AOJu0YzHRhW7O+gv96nj1rcUccq9MRQaagUNCCQkU5Ak+nZ76Ca4k1gG TU8A2V3J/y3r5GgYeMOH24ULbe+Shr9E07ONH4vUNOT9/71c9SjDTtD5blTBW8lbL/8ncscvGvO tLCOZ3pyHvg== X-Gm-Gg: ASbGncsnNUYWfmVzThPPQ7+yk8bmumgAEmvQr1Ln4bqFb2sHLsmW6TFt7h6EoyrJZiC lE+9UyAiGJZvDNlJqgs/vgTGIQGobvX3TWTEVksZ6kzs/s3VGFef8bAX0qjmTMHIScE/0QZjNYj kfCZT2puxbOnnggjlG4wiwIt94K/mIx5WD5W/xnMeaZ5gSjJWMsC176teznSG+qk+WA8/OFg8U/ 31Ebs5XYslbnTxf5DrCpum4dWSulWFF0CsE/liANfbABGDnb71XRXpscQ4rVIyiah1d9ILWKXrF aRiAXWWhPvnRmpXWaFscD6aP7/mgZAElKFbPhgQZ7CeFmUMIkLQO9HMwoE7aVkopc9OiuZaKZ17 JVOkwHoCNBqN80Szp2/t9yRsyz6kDnv3PzqXTIdIs1TUfHFQlOssF0oqh/9OqnzgWEFyJr1F2DA iZ9Lx2Rvlbt/y7MsKX5vRXqdX5Rk25b7P5WM6jkVJ2zWtw7bmNF+fuZ5k//6OY X-Google-Smtp-Source: AGHT+IFD0J886aRuJCwxM+lr3oZToXhoQkCPQeMIBZKljBTRmVX89ASa5Vj5hoAeAA3cyx7j/j2/6Q== X-Received: by 2002:a05:6000:40c9:b0:42b:394a:9b1 with SMTP id ffacd0b85a97d-42cc1d27a2fmr2597184f8f.37.1763732838510; Fri, 21 Nov 2025 05:47:18 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 20/21] target/mips: Use big-endian variant of cpu_ld/st_data*() for MSA Date: Fri, 21 Nov 2025 14:45:02 +0100 Message-ID: <20251121134503.30914-21-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, T_SPF_HELO_TEMPERROR=0.01, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763781202402018900 MSA vectors are accessed in big endianness. Per the "MIPS=C2=AE SIMD Architecture" (MD00926 rev 1.03): 3.1 Registers Layout MSA vectors are stored in memory starting from the 0th element at the lowest byte address. The byte order of each element follows the big- or little-endian convention of the system configuration. Use the explicit big-endian variants of cpu_ld/st_data*(). Running files in tests/tcg/mips/user/ase/msa shows: NLOC.B | PASS: 80 | FAIL: 0 | elapsed time: 0.21 ms | NLOC.H | PASS: 80 | FAIL: 0 | elapsed time: 0.22 ms | NLOC.W | PASS: 80 | FAIL: 0 | elapsed time: 0.18 ms | NLOC.D | PASS: 80 | FAIL: 0 | elapsed time: 0.18 ms | NLZC.B | PASS: 80 | FAIL: 0 | elapsed time: 0.19 ms | NLZC.H | PASS: 80 | FAIL: 0 | elapsed time: 0.18 ms | NLZC.W | PASS: 80 | FAIL: 0 | elapsed time: 0.21 ms | NLZC.D | PASS: 80 | FAIL: 0 | elapsed time: 0.18 ms | PCNT.B | PASS: 80 | FAIL: 0 | elapsed time: 0.17 ms | PCNT.H | PASS: 80 | FAIL: 0 | elapsed time: 0.19 ms | PCNT.W | PASS: 80 | FAIL: 0 | elapsed time: 0.18 ms | PCNT.D | PASS: 80 | FAIL: 0 | elapsed time: 0.19 ms | BINSL.B | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | BINSL.H | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | BINSL.W | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | BINSL.D | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | BINSR.B | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | BINSR.H | PASS: 112 | FAIL: 0 | elapsed time: 0.58 ms | BINSR.W | PASS: 112 | FAIL: 0 | elapsed time: 0.58 ms | BINSR.D | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | BMNZ.V | PASS: 112 | FAIL: 0 | elapsed time: 0.65 ms | BMZ.V | PASS: 112 | FAIL: 0 | elapsed time: 0.59 ms | BSEL.V | PASS: 112 | FAIL: 0 | elapsed time: 0.60 ms | BCLR.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BCLR.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BCLR.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BCLR.D | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | BNEG.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BNEG.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | BNEG.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BNEG.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BSET.B | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | BSET.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BSET.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | BSET.D | PASS: 80 | FAIL: 0 | elapsed time: 0.33 ms | MADD_Q.H | PASS: 112 | FAIL: 0 | elapsed time: 0.60 ms | MADD_Q.W | PASS: 112 | FAIL: 0 | elapsed time: 0.83 ms | MADDR_Q.H | PASS: 112 | FAIL: 0 | elapsed time: 0.62 ms | MADDR_Q.W | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | MSUB_Q.H | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | MSUB_Q.W | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | MSUBR_Q.H | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | MSUBR_Q.W | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | MUL_Q.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MUL_Q.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MULR_Q.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MULR_Q.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | FMAX_A.W | PASS: 80 | FAIL: 0 | elapsed time: 0.36 ms | FMAX_A.D | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | FMAX.W | PASS: 80 | FAIL: 0 | elapsed time: 0.33 ms | FMAX.D | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | FMIN_A.W | PASS: 80 | FAIL: 0 | elapsed time: 0.36 ms | FMIN_A.D | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | FMIN.W | PASS: 80 | FAIL: 0 | elapsed time: 0.35 ms | FMIN.D | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | ADD_A.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADD_A.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADD_A.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADD_A.D | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | ADDS_A.B | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | ADDS_A.H | PASS: 80 | FAIL: 0 | elapsed time: 0.33 ms | ADDS_A.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDS_A.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDS_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDS_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDS_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.80 ms | ADDS_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | ADDS_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDS_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDS_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDS_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDV.B | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | ADDV.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ADDV.W | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | ADDV.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HADD_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HADD_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HADD_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HADD_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HADD_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.33 ms | HADD_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVE_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVE_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVE_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVE_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVE_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVE_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVE_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | AVE_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVER_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVER_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | AVER_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVER_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVER_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | AVER_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVER_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AVER_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CEQ.B | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | CEQ.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CEQ.W | PASS: 80 | FAIL: 0 | elapsed time: 0.38 ms | CEQ.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLE_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLE_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLE_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLE_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | CLE_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | CLE_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | CLE_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | CLE_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | CLT_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | CLT_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | CLT_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLT_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLT_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLT_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | CLT_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | CLT_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | DIV_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | DIV_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | DIV_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DIV_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DIV_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.39 ms | DIV_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | DIV_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DIV_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DOTP_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DOTP_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.35 ms | DOTP_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DOTP_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DOTP_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | DOTP_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | DPADD_S.H | PASS: 112 | FAIL: 0 | elapsed time: 0.59 ms | DPADD_S.W | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | DPADD_S.D | PASS: 112 | FAIL: 0 | elapsed time: 0.58 ms | DPADD_U.H | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | DPADD_U.W | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | DPADD_U.D | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | DPSUB_S.H | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | DPSUB_S.W | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | DPSUB_S.D | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | DPSUB_U.H | PASS: 112 | FAIL: 0 | elapsed time: 0.58 ms | DPSUB_U.W | PASS: 112 | FAIL: 0 | elapsed time: 0.59 ms | DPSUB_U.D | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | MAX_A.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MAX_A.H | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | MAX_A.W | PASS: 80 | FAIL: 0 | elapsed time: 0.33 ms | MAX_A.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MAX_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MAX_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MAX_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MAX_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.35 ms | MAX_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.35 ms | MAX_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MAX_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | MAX_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_A.B | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | MIN_A.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_A.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_A.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.33 ms | MIN_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | MIN_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MIN_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | MOD_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | MOD_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | MOD_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MOD_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MOD_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.37 ms | MOD_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | MOD_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MOD_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MADDV.B | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | MADDV.H | PASS: 112 | FAIL: 0 | elapsed time: 0.63 ms | MADDV.W | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | MADDV.D | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | MSUBV.B | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | MSUBV.H | PASS: 112 | FAIL: 0 | elapsed time: 0.65 ms | MSUBV.W | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | MSUBV.D | PASS: 112 | FAIL: 0 | elapsed time: 0.65 ms | MULV.B | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | MULV.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MULV.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | MULV.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ASUB_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ASUB_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ASUB_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ASUB_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ASUB_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.44 ms | ASUB_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | ASUB_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ASUB_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HSUB_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HSUB_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | HSUB_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | HSUB_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HSUB_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | HSUB_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | SUBS_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | SUBS_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.38 ms | SUBS_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | SUBS_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBS_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBS_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | SUBS_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | SUBS_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBSUS_U.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBSUS_U.H | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | SUBSUS_U.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBSUS_U.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBSUU_S.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBSUU_S.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | SUBSUU_S.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBSUU_S.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBV.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBV.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBV.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SUBV.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVEV.B | PASS: 80 | FAIL: 0 | elapsed time: 0.35 ms | ILVEV.H | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | ILVEV.W | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | ILVEV.D | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | ILVOD.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVOD.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVOD.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVOD.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVL.B | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | ILVL.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVL.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVL.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVR.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVR.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | ILVR.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | ILVR.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | AND.V | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | NOR.V | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | OR.V | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | XOR.V | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | MOVE.V | PASS: 80 | FAIL: 0 | elapsed time: 0.18 ms | PCKEV.B | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | PCKEV.H | PASS: 112 | FAIL: 0 | elapsed time: 0.56 ms | PCKEV.W | PASS: 112 | FAIL: 0 | elapsed time: 0.68 ms | PCKEV.D | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | PCKOD.B | PASS: 112 | FAIL: 0 | elapsed time: 0.61 ms | PCKOD.H | PASS: 112 | FAIL: 0 | elapsed time: 0.62 ms | PCKOD.W | PASS: 112 | FAIL: 0 | elapsed time: 0.58 ms | PCKOD.D | PASS: 112 | FAIL: 0 | elapsed time: 0.58 ms | VSHF.B | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | VSHF.H | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | VSHF.W | PASS: 112 | FAIL: 0 | elapsed time: 0.62 ms | VSHF.D | PASS: 112 | FAIL: 0 | elapsed time: 0.57 ms | SLL.B | PASS: 80 | FAIL: 0 | elapsed time: 0.34 ms | SLL.H | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SLL.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SLL.D | PASS: 80 | FAIL: 0 | elapsed time: 0.38 ms | SRA.B | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | SRA.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | SRA.W | PASS: 80 | FAIL: 0 | elapsed time: 0.37 ms | SRA.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SRAR.B | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | SRAR.H | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | SRAR.W | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | SRAR.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SRL.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SRL.H | PASS: 80 | FAIL: 0 | elapsed time: 0.32 ms | SRL.W | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SRL.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SRLR.B | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | SRLR.H | PASS: 80 | FAIL: 0 | elapsed time: 0.29 ms | SRLR.W | PASS: 80 | FAIL: 0 | elapsed time: 0.31 ms | SRLR.D | PASS: 80 | FAIL: 0 | elapsed time: 0.30 ms | Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/msa_helper.c | 51 ++++++++++++++++++++++-------------- 1 file changed, 31 insertions(+), 20 deletions(-) diff --git a/target/mips/tcg/msa_helper.c b/target/mips/tcg/msa_helper.c index f554b3d10ee..d6ce17abf9a 100644 --- a/target/mips/tcg/msa_helper.c +++ b/target/mips/tcg/msa_helper.c @@ -8231,8 +8231,8 @@ void helper_msa_ld_b(CPUMIPSState *env, uint32_t wd, uint64_t d0, d1; =20 /* Load 8 bytes at a time. Vector element ordering makes this LE. */ - d0 =3D cpu_ldq_le_data_ra(env, addr + 0, ra); - d1 =3D cpu_ldq_le_data_ra(env, addr + 8, ra); + d0 =3D cpu_ldq_be_data_ra(env, addr + 0, ra); + d1 =3D cpu_ldq_be_data_ra(env, addr + 8, ra); pwd->d[0] =3D d0; pwd->d[1] =3D d1; } @@ -8248,9 +8248,9 @@ void helper_msa_ld_h(CPUMIPSState *env, uint32_t wd, * Load 8 bytes at a time. Use little-endian load, then for * big-endian target, we must then swap the four halfwords. */ - d0 =3D cpu_ldq_le_data_ra(env, addr + 0, ra); - d1 =3D cpu_ldq_le_data_ra(env, addr + 8, ra); - if (mips_env_is_bigendian(env)) { + d0 =3D cpu_ldq_be_data_ra(env, addr + 0, ra); + d1 =3D cpu_ldq_be_data_ra(env, addr + 8, ra); + if (!mips_env_is_bigendian(env)) { d0 =3D bswap16x4(d0); d1 =3D bswap16x4(d1); } @@ -8269,9 +8269,9 @@ void helper_msa_ld_w(CPUMIPSState *env, uint32_t wd, * Load 8 bytes at a time. Use little-endian load, then for * big-endian target, we must then bswap the two words. */ - d0 =3D cpu_ldq_le_data_ra(env, addr + 0, ra); - d1 =3D cpu_ldq_le_data_ra(env, addr + 8, ra); - if (mips_env_is_bigendian(env)) { + d0 =3D cpu_ldq_be_data_ra(env, addr + 0, ra); + d1 =3D cpu_ldq_be_data_ra(env, addr + 8, ra); + if (!mips_env_is_bigendian(env)) { d0 =3D bswap32x2(d0); d1 =3D bswap32x2(d1); } @@ -8286,8 +8286,12 @@ void helper_msa_ld_d(CPUMIPSState *env, uint32_t wd, uintptr_t ra =3D GETPC(); uint64_t d0, d1; =20 - d0 =3D cpu_ldq_data_ra(env, addr + 0, ra); - d1 =3D cpu_ldq_data_ra(env, addr + 8, ra); + d0 =3D cpu_ldq_be_data_ra(env, addr + 0, ra); + d1 =3D cpu_ldq_be_data_ra(env, addr + 8, ra); + if (!mips_env_is_bigendian(env)) { + d0 =3D bswap64(d0); + d1 =3D bswap64(d1); + } pwd->d[0] =3D d0; pwd->d[1] =3D d1; } @@ -8320,8 +8324,8 @@ void helper_msa_st_b(CPUMIPSState *env, uint32_t wd, ensure_writable_pages(env, addr, mmu_idx, ra); =20 /* Store 8 bytes at a time. Vector element ordering makes this LE. */ - cpu_stq_le_data_ra(env, addr + 0, pwd->d[0], ra); - cpu_stq_le_data_ra(env, addr + 8, pwd->d[1], ra); + cpu_stq_be_data_ra(env, addr + 0, pwd->d[0], ra); + cpu_stq_be_data_ra(env, addr + 8, pwd->d[1], ra); } =20 void helper_msa_st_h(CPUMIPSState *env, uint32_t wd, @@ -8337,12 +8341,12 @@ void helper_msa_st_h(CPUMIPSState *env, uint32_t wd, /* Store 8 bytes at a time. See helper_msa_ld_h. */ d0 =3D pwd->d[0]; d1 =3D pwd->d[1]; - if (mips_env_is_bigendian(env)) { + if (!mips_env_is_bigendian(env)) { d0 =3D bswap16x4(d0); d1 =3D bswap16x4(d1); } - cpu_stq_le_data_ra(env, addr + 0, d0, ra); - cpu_stq_le_data_ra(env, addr + 8, d1, ra); + cpu_stq_be_data_ra(env, addr + 0, d0, ra); + cpu_stq_be_data_ra(env, addr + 8, d1, ra); } =20 void helper_msa_st_w(CPUMIPSState *env, uint32_t wd, @@ -8358,12 +8362,12 @@ void helper_msa_st_w(CPUMIPSState *env, uint32_t wd, /* Store 8 bytes at a time. See helper_msa_ld_w. */ d0 =3D pwd->d[0]; d1 =3D pwd->d[1]; - if (mips_env_is_bigendian(env)) { + if (!mips_env_is_bigendian(env)) { d0 =3D bswap32x2(d0); d1 =3D bswap32x2(d1); } - cpu_stq_le_data_ra(env, addr + 0, d0, ra); - cpu_stq_le_data_ra(env, addr + 8, d1, ra); + cpu_stq_be_data_ra(env, addr + 0, d0, ra); + cpu_stq_be_data_ra(env, addr + 8, d1, ra); } =20 void helper_msa_st_d(CPUMIPSState *env, uint32_t wd, @@ -8372,9 +8376,16 @@ void helper_msa_st_d(CPUMIPSState *env, uint32_t wd, wr_t *pwd =3D &(env->active_fpu.fpr[wd].wr); int mmu_idx =3D mips_env_mmu_index(env); uintptr_t ra =3D GETPC(); + uint64_t d0, d1; =20 ensure_writable_pages(env, addr, mmu_idx, GETPC()); =20 - cpu_stq_data_ra(env, addr + 0, pwd->d[0], ra); - cpu_stq_data_ra(env, addr + 8, pwd->d[1], ra); + d0 =3D pwd->d[0]; + d1 =3D pwd->d[1]; + if (!mips_env_is_bigendian(env)) { + d0 =3D bswap64(d0); + d1 =3D bswap64(d1); + } + cpu_stq_be_data_ra(env, addr + 0, d0, ra); + cpu_stq_be_data_ra(env, addr + 8, d1, ra); } --=20 2.51.0 From nobody Mon Feb 9 08:20:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763785121; cv=none; d=zohomail.com; s=zohoarc; b=dTf9q8mHdpmo0loB+mW8eNDzNh17JQ8Qjtx//3B5stApx+k3I5kaj0xQ9EWzzB0n2bZShfKzxinF+yaYQvqcHg9LFnT1VrvgI0cAvzzXQHXICjbJpxe3pj9MBbEkJfkF2rHhBwyHVMWTS1T+jl73woR3mbaFGu0QLTlri76KmXQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763785121; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CBepVKYV1tqDt+M6yeXJGPjMchvP/4Ty5uCcKnUn5wM=; b=G1CNAMrn/MpkXuqao/19J46yN0iNpU2HC4w5GbMeqoV32JPnqMlIGPvkW8/yN30RZY65GybUWnMxs+Nok8PAXTNK4c0dhJvlKqSqVGgWcVjWoBzBC2jS3uxFlBoVyygQAIXNMC50bl1o8kaMU5SuqyPssFb9CAn/4l4CFmWwDQI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176378512136592.15041155582014; Fri, 21 Nov 2025 20:18:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMd2T-0001Rx-12; Fri, 21 Nov 2025 21:07:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMcIg-0002mv-Gw for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:20:30 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vMcIR-0006zU-DO for qemu-devel@nongnu.org; Fri, 21 Nov 2025 20:20:27 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-477a2ab455fso28022665e9.3 for ; Fri, 21 Nov 2025 17:19:58 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f2e574sm11223189f8f.3.2025.11.21.05.47.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Nov 2025 05:47:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763774394; x=1764379194; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CBepVKYV1tqDt+M6yeXJGPjMchvP/4Ty5uCcKnUn5wM=; b=tBJ4hpsNVK8zT3Fhlg/w+EA+QeGeqWqhVNrpzXBtUvKTpqUcmyEh9MNoXRkBoT81rI fnkoNSTBt/LiZzjy5V/GPWVDgZ70ysGGQSIIv9D5XPFzvLDoKPJJGRXPI2hGhWneZmRI 4g3dHhlM+n39+lNgqkA3A4WosWpT28M4J/jX+XOUSrPOjTg+JQa2F9k7jlluFA50CHQB gQjMofPbF5BRb8lJO8bG48JDsksBtqmr2A3NW7x8nV7Y002yO1eiu14tkwERx3C2BHEI e93PJQvPs0mNWnCGY9HsasTpGKe/4Sb6uyiNvKL1CHXX8o2TYNzhOUthnr4DBJmnqdLq PmZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763774394; x=1764379194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CBepVKYV1tqDt+M6yeXJGPjMchvP/4Ty5uCcKnUn5wM=; b=uAKtoCCA4lDV+KYJ5SrlgSZXRUq44S1Sn5lMJ0a692skpyq+4qwK55/bIzOmA6IUDS ezdZ5d2PvkwvvV9O3hZ9cNcKG3RNJzF91xF/n7Hjq5LjuE0TlI0xBVXZpXizgFPMcBUR DyBd04+SWtE6cYZiC3+I/KYrD0pmkzHfKNJ1NIrJL9Egx9Z8mD1e8e9mltnm1Jcpufmj 5+KpF4emuxOww80+63bFCNXvCEQ/5KngoKyEHrUBFheVM1rDISZWFm0lna/l7G3EKWqM vaDduvCaJOjnqNiY3sYRVbnyQ42qx9y+OET56YzvzhBWkl7DxJgsBeXs8MXkwPPA5C2u SURQ== X-Gm-Message-State: AOJu0YwbaJmKq6gkqlMrteOeXhpA8NJjkCyHJa/fqCjelXYSyCPMWRmT fagbMO2G5Hob1yuKcqspFH1NN0+Nl5ygqLDIH8R20dpebGut8nbH+iQFgGkmxhLMeOG5HGfC2Pr GMyPjr64Y3A== X-Gm-Gg: ASbGnct+aHX4JOhjhybDDiNfi8xxAaXW8D2u5PUDLui5sBSa/wTMNbuWjBcVR4bnITD dK0KPmuW+gxfZ2zAL1siVheqADOelQHRSnOjiOTxzBgUCaTfLmM5BEEK8+5MxxJxWoNvfXnk1qQ qfwazz1URyjVTquAET9f//DIEqvc9JtF39DSk/P7ug1CZRz37phDj3kigArjJmURlw3flW+jmaW uLeV2+V6epROU/0a3oLSM0cLnqOdWMxMNOhakFUN9w5PMshZomeBTf74hXvkI89GidMiu12OgLu oCtK5jeUiO9eb2jG9x3w/NOYEtMVSV7Of897X3HC1j9AqFmxSSrUxo39QFR4CGMWnA/bKEyz6XY E3mdlq+LU6DGHWevu2gXCF9yi1g5WIyqZTsstxLJ4ev6SbTEhQaoBbOBmLPSBVGt4olEQ5v7dJ4 thjiyBY1T9ZHdxWW0NJ8FWObVjRctHfv77/d1YO0/HGBYGPXV6mwBfES5ALER2KfmeN+kSh5g= X-Google-Smtp-Source: AGHT+IGNrQmrpxmF7PoFIbUzaaLYwg9orSTcPtVnBOTCdObQ9Ayepn30kjIe9MJIUdIx5/S1YODG/g== X-Received: by 2002:a05:6000:2681:b0:42b:41a6:a670 with SMTP id ffacd0b85a97d-42cc1d51b98mr2460147f8f.54.1763732845183; Fri, 21 Nov 2025 05:47:25 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anton Johansson Subject: [RFC-PATCH-for-11.0 v3 21/21] accel/tcg: Remove non-explicit endian cpu_ld/st*_data*() helpers Date: Fri, 21 Nov 2025 14:45:03 +0100 Message-ID: <20251121134503.30914-22-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121134503.30914-1-philmd@linaro.org> References: <20251121134503.30914-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763785122710018900 All uses were converted to the explicit cpu_ld/st*_{be,le}_data*() helpers, no need for the non-explicit versions anymore. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- FIXME: Still some PPC/MIPS uses --- include/accel/tcg/cpu-ldst.h | 46 ------------------------------------ 1 file changed, 46 deletions(-) diff --git a/include/accel/tcg/cpu-ldst.h b/include/accel/tcg/cpu-ldst.h index a3125fc9026..70442bd08af 100644 --- a/include/accel/tcg/cpu-ldst.h +++ b/include/accel/tcg/cpu-ldst.h @@ -428,52 +428,6 @@ cpu_stq_le_data(CPUArchState *env, abi_ptr addr, uint6= 4_t val) cpu_stq_le_data_ra(env, addr, val, 0); } =20 -#if TARGET_BIG_ENDIAN -# define cpu_lduw_data cpu_lduw_be_data -# define cpu_ldsw_data cpu_ldsw_be_data -# define cpu_ldl_data cpu_ldl_be_data -# define cpu_ldq_data cpu_ldq_be_data -# define cpu_lduw_data_ra cpu_lduw_be_data_ra -# define cpu_ldsw_data_ra cpu_ldsw_be_data_ra -# define cpu_ldl_data_ra cpu_ldl_be_data_ra -# define cpu_ldq_data_ra cpu_ldq_be_data_ra -# define cpu_lduw_mmuidx_ra cpu_lduw_be_mmuidx_ra -# define cpu_ldsw_mmuidx_ra cpu_ldsw_be_mmuidx_ra -# define cpu_ldl_mmuidx_ra cpu_ldl_be_mmuidx_ra -# define cpu_ldq_mmuidx_ra cpu_ldq_be_mmuidx_ra -# define cpu_stw_data cpu_stw_be_data -# define cpu_stl_data cpu_stl_be_data -# define cpu_stq_data cpu_stq_be_data -# define cpu_stw_data_ra cpu_stw_be_data_ra -# define cpu_stl_data_ra cpu_stl_be_data_ra -# define cpu_stq_data_ra cpu_stq_be_data_ra -# define cpu_stw_mmuidx_ra cpu_stw_be_mmuidx_ra -# define cpu_stl_mmuidx_ra cpu_stl_be_mmuidx_ra -# define cpu_stq_mmuidx_ra cpu_stq_be_mmuidx_ra -#else -# define cpu_lduw_data cpu_lduw_le_data -# define cpu_ldsw_data cpu_ldsw_le_data -# define cpu_ldl_data cpu_ldl_le_data -# define cpu_ldq_data cpu_ldq_le_data -# define cpu_lduw_data_ra cpu_lduw_le_data_ra -# define cpu_ldsw_data_ra cpu_ldsw_le_data_ra -# define cpu_ldl_data_ra cpu_ldl_le_data_ra -# define cpu_ldq_data_ra cpu_ldq_le_data_ra -# define cpu_lduw_mmuidx_ra cpu_lduw_le_mmuidx_ra -# define cpu_ldsw_mmuidx_ra cpu_ldsw_le_mmuidx_ra -# define cpu_ldl_mmuidx_ra cpu_ldl_le_mmuidx_ra -# define cpu_ldq_mmuidx_ra cpu_ldq_le_mmuidx_ra -# define cpu_stw_data cpu_stw_le_data -# define cpu_stl_data cpu_stl_le_data -# define cpu_stq_data cpu_stq_le_data -# define cpu_stw_data_ra cpu_stw_le_data_ra -# define cpu_stl_data_ra cpu_stl_le_data_ra -# define cpu_stq_data_ra cpu_stq_le_data_ra -# define cpu_stw_mmuidx_ra cpu_stw_le_mmuidx_ra -# define cpu_stl_mmuidx_ra cpu_stl_le_mmuidx_ra -# define cpu_stq_mmuidx_ra cpu_stq_le_mmuidx_ra -#endif - static inline uint32_t cpu_ldub_code(CPUArchState *env, abi_ptr addr) { CPUState *cs =3D env_cpu(env); --=20 2.51.0