From nobody Sun Feb 8 17:51:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1763693307; cv=pass; d=zohomail.com; s=zohoarc; b=XZQgiotyad7Qq7Ov9DKnls0brHggsK72edQ3DcOPJAqDIY/etaxIuQJCeLnE6gKUhoyuWlrXZRkJR+u8jhgIpPbEmRY8nqWnUewFATO68Ryd+awI5lqYUMpzXFLZw45simmiT3U8Z8shcrvJKnVAxKQwU8PwKBpBWg6CpyFg+uo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763693307; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5PvWLbkGhF4b3pCvDcCFf4px+MW6AQfawLN7JWaGFlM=; b=D0VviKZhqjNUvFPjzf11NjRrDhIzby/h43zjUuDbCLYLDrF38/YeYBrsQtGUyAR9sNMB3QRUDnx2j4SAF0O4bQDWlNgRrNrS6XCpKaBN7s0LFAQtg8YIkWipEei0uD1oTvfeyuGPw3qNj5LGzIfcXoHXL4/6QjFoH1BATVksNp4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763693307007338.7144805540223; Thu, 20 Nov 2025 18:48:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMHBX-0003N4-5B; Thu, 20 Nov 2025 21:47:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMHBU-0003Ll-0l for qemu-devel@nongnu.org; Thu, 20 Nov 2025 21:47:40 -0500 Received: from mail-eastusazlp17011000f.outbound.protection.outlook.com ([2a01:111:f403:c100::f] helo=BL2PR02CU003.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMHBS-0006IZ-7C for qemu-devel@nongnu.org; Thu, 20 Nov 2025 21:47:39 -0500 Received: from BLAPR03CA0007.namprd03.prod.outlook.com (2603:10b6:208:32b::12) by LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.11; Fri, 21 Nov 2025 02:47:33 +0000 Received: from BL02EPF0002992C.namprd02.prod.outlook.com (2603:10b6:208:32b:cafe::25) by BLAPR03CA0007.outlook.office365.com (2603:10b6:208:32b::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Fri, 21 Nov 2025 02:47:33 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by BL02EPF0002992C.mail.protection.outlook.com (10.167.249.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Fri, 21 Nov 2025 02:47:33 +0000 Received: from honglei-remote.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 20 Nov 2025 18:47:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=omhLHXIiMQe5bMFQtjCoSVzhZ2X3KtbNXRS9c38CgPJw3iotYHY43icDL7NA34CsIV2fI3H5qmpN2tNWEbvUMyz95GcikUpLwNcSSLjfLDOqv35snXzV8rP/wqNRG6D0SZKrKQcYgIDjMNUD7O6ykwh+bh38qiol/G5idE0kwdgvxmGmCqEIoHp1Qc6zHpGQHDcVKlsWbmngQqBHNYN8F9UIa8xNxFtNVEXsD6bmXmL71cqcid3ug6KA6pZEpA39NwnseA4sMgDvKbRs2TiPrQ2FGspPvH45H50NyaQuc9kg1LmCeOgl/QcUP1M+9wf7eWy1mkuxy/D74SqRUrlemQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5PvWLbkGhF4b3pCvDcCFf4px+MW6AQfawLN7JWaGFlM=; b=T5jjkmGe/CdeOjlwxTJKvP84mYbD+rvJVZ8xawIgNr62lptRwLJ//sBXeYje76TGuYjMvs1TmJfVblTZjFuE7criactCEtf0X7VOyXXo7x6NLqC2hrkbDA2vmnb6FmDHCYRkKEZclt6OrC7VNcBFJro9Xu04hhMwB0MgQ6yy1XVEeL5Niplin+j3erWBb6P2GYTRoBumc42spCWlr9jh88EA/fQRI40qZ+oCZB3GoeDRTIWc9TvZu0pVMScBcJJR0IO2AaBdGLsCOG3xD8DmYcVBIhy6LBx94mpFwBlh3Qo/JVcZi68TAHrU5zmFcOYfrtGbpcvur3lhFaQLa16HCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5PvWLbkGhF4b3pCvDcCFf4px+MW6AQfawLN7JWaGFlM=; b=aJpBniXMj0MkyVpDqiFODAa3lSyv/rGsoDzxQXrzYyY8aFaIs/M0ZPHVzSpemdYXcAAis1sPRzrGl3YDVsm99HTmsY27BF+hC/yoJSM5gfPIsB81GnY08REw3CtIq7B/G7BFwM5mFyMcF8U+dqvSZs68/Sw/9HX/wRK/m3C56Ss= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Honglei Huang To: , , CC: , , , , , Honglei Huang Subject: [v2 1/3] virtio-gpu: Add support for VIRTIO_GPU_BLOB_FLAG_USE_USERPTR flag Date: Fri, 21 Nov 2025 10:47:03 +0800 Message-ID: <20251121024705.1403042-2-honghuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251121024705.1403042-1-honghuan@amd.com> References: <20251121024705.1403042-1-honghuan@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0002992C:EE_|LV2PR12MB5968:EE_ X-MS-Office365-Filtering-Correlation-Id: ab290739-7476-443d-ea30-08de28a8528f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?2lBNGhxrD2y6g/vhtrWYWsEQ47zvDvW+YWUxdNPU6Eb0aTHOdt/N3sZHor3j?= =?us-ascii?Q?sygD9EK14se+u9Y5tfHl68/RXImptIS/H/SANUbv85mgJJoia3wCjBCc6Ylb?= =?us-ascii?Q?K2bvtgkGnl1UIbWoHFRxV9xUgPZ4vr6+SyBA5wDwdmXYcQmBWoK180rKFvDR?= =?us-ascii?Q?hqFghfjfTfpz1dBlcGeKm8XzLxTSoGOzP7Vo2KSmmQh+lnpiiZqaB3Mdyv9y?= =?us-ascii?Q?phUrIxaO6kISjmFHNRK+9StpuWHsebbjp9mk6Ps9KMXdxQ5xORSQOJWjgIog?= =?us-ascii?Q?c+c/gxdzd0/zOqCfQdL3TXLccmY9MBJXcs808Uf+YFt4lth0MOZLqPz+hufT?= =?us-ascii?Q?IQ4Q/kYNCqtxw5cH1nr1acWgUtu2P0Haaedr76VygIEbW4UL9D0eBSjQO4Np?= =?us-ascii?Q?qG2XOonSO9/J/9XdN01KeANRSjZSqFWx63pbcgkdBu/FoyrfuscWGu/LuqdO?= =?us-ascii?Q?vDYX0qJsFHHWiHGuxwt36CoZW1x9N4+FDDybVsj6TV/oSyw+r/bKK3l+0mD5?= =?us-ascii?Q?zW+6bcxvDQRvy611SzckGL3hbG6AcXpBt4T+ZHTCKcHhLMD0IoevpVYw9PTW?= =?us-ascii?Q?ajHDA6lrA9Uavl0Mb3mk9gmmaiWo2u74B4HNISz+P/Y7WTz9DVV4YmACLXGi?= =?us-ascii?Q?sbFsIsVIV72s+fZKoQKiuLbBgz1CklY1ZZMyAn3YxqQmEJL7dtHnLsKiQyBE?= =?us-ascii?Q?Zn1p3oECj2wW1WBoExHvMcMU5Bx8JWMGuLZValPzXl3DZUHGtLPQr9r08ZMr?= =?us-ascii?Q?R/sRXE4Nw5VngNgSMvEmoI04nACdArNRK4hHc+ey9XD+O4p9ZOBDFKPgLlwG?= =?us-ascii?Q?+t7QfZ6/FJzU1FjbwZdE+P17gLZIQEnlN8mE43ZcUvokbIq7uqiQxQz302pQ?= =?us-ascii?Q?7Aer848p7xtxZxKG9fHBJ0NYVoTcqzeLkxXkFmohf2Lj5ArZjMHNUjqSNi69?= =?us-ascii?Q?LxuDu84cj8Qmdm8Z4H2+7kqWDLp0jq39kLqXqmjmaPpZ8vln4aAdTDZ4DTWc?= =?us-ascii?Q?1R1k/0qZyGmQ64w1YtnH8ljXeu/zvFOHI9n6wAEHb6ScHrtGyw2oflTqVZR0?= =?us-ascii?Q?0XFT0oKnutnibNTKePgr+ISZ5h9NV2FSPxO0KVYNBlhoXNjaq2wNL1oHHqCU?= =?us-ascii?Q?HHEOHi0HP+YaxUyIXdLPnSu202ixJeCFQvqSC4XP86fqRFveZtfgcXRQI+ry?= =?us-ascii?Q?wRf96bIu7Qw3wH9X57OlEid/Mx8jU7Xi2mwq6cqkL/gEs403e+HO8KMeMT2F?= =?us-ascii?Q?PvZTBoQqe1997DhCVUF6pfNjeWuNWN6GfuW2AVd4QqW/g5mKUU6MIeuSddhE?= =?us-ascii?Q?9mwOLZr0lcQChxb0I79pnN7RJ32bxAj1F3kPmM/UUvF+3Jp8vOjcpiCEpJ0N?= =?us-ascii?Q?2umrmRd0GqjH9RZ46LzPcpZwz6/NZnD30QYt32tzk5JBDcHS1NJjKymkoWNF?= =?us-ascii?Q?/VUeuHk0vRBrlOQNug2xl9X6SLx/yrdwAsrbEy5T4QiuPPCeOfNzUbanjvCU?= =?us-ascii?Q?CjRHbpGOkw4OXMf+bF5k3UY46fQI2k1swB7fkFXpMhRMTaYB1XMNK2DwdxVE?= =?us-ascii?Q?bD4Xsyi2zKRA2yBL8qE=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2025 02:47:33.7548 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ab290739-7476-443d-ea30-08de28a8528f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0002992C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5968 Received-SPF: permerror client-ip=2a01:111:f403:c100::f; envelope-from=Honglei1.Huang@amd.com; helo=BL2PR02CU003.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1763693308089018900 Content-Type: text/plain; charset="utf-8" Add support for the USE_USERPTR blob flag in virtio-gpu to enable user pointer mapping for blob resources. This allows guest applications to use user-allocated memory for GPU resources more efficiently. Changes include: - Add VIRTIO_GPU_BLOB_FLAG_USE_USERPTR flag definition - Enhance blob resource creation to handle userptr flag properly - Remove arbitrary nr_entries limit (16384) in mapping creation - Add conditional handling for userptr vs regular blob mapping - Support guest_blob_mapped parameter for virgl renderer - Fix value check issue in virtio-gpu This enables more flexible memory management between guest and host for GPU virtualization scenarios. Signed-off-by: Honglei Huang --- hw/display/virtio-gpu-virgl.c | 2 +- hw/display/virtio-gpu.c | 7 ------- include/standard-headers/linux/virtio_gpu.h | 1 + 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 07f6355ad6..c927275c79 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -705,7 +705,7 @@ static void virgl_cmd_resource_create_blob(VirtIOGPU *g, ret =3D virtio_gpu_create_mapping_iov(g, cblob.nr_entries, sizeof(= cblob), cmd, &res->base.addrs, &res->base.iov, &res->base.iov= _cnt); - if (!ret) { + if (ret !=3D 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 43e88a4daf..956dc811fa 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -808,13 +808,6 @@ int virtio_gpu_create_mapping_iov(VirtIOGPU *g, size_t esize, s; int e, v; =20 - if (nr_entries > 16384) { - qemu_log_mask(LOG_GUEST_ERROR, - "%s: nr_entries is too big (%d > 16384)\n", - __func__, nr_entries); - return -1; - } - esize =3D sizeof(*ents) * nr_entries; ents =3D g_malloc(esize); s =3D iov_to_buf(cmd->elem.out_sg, cmd->elem.out_num, diff --git a/include/standard-headers/linux/virtio_gpu.h b/include/standard= -headers/linux/virtio_gpu.h index 00cd3f04af..b85e781a2d 100644 --- a/include/standard-headers/linux/virtio_gpu.h +++ b/include/standard-headers/linux/virtio_gpu.h @@ -405,6 +405,7 @@ struct virtio_gpu_resource_create_blob { #define VIRTIO_GPU_BLOB_FLAG_USE_MAPPABLE 0x0001 #define VIRTIO_GPU_BLOB_FLAG_USE_SHAREABLE 0x0002 #define VIRTIO_GPU_BLOB_FLAG_USE_CROSS_DEVICE 0x0004 +#define VIRTIO_GPU_BLOB_FLAG_USE_USERPTR 0x0008 /* zero is invalid blob mem */ uint32_t blob_mem; uint32_t blob_flags; --=20 2.34.1 From nobody Sun Feb 8 17:51:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1763693307; cv=pass; d=zohomail.com; s=zohoarc; b=N4g6wMsrbdFQZVjAPxfUTAilLny5ljTlkT/9ozMUtEg3kQHvrcdR/cQMV2bUwM1uV5Q13DoRWyaq3QGtAMIZPgWXPEi6q9rjCgbRU10MFse5Kv3nDFPxmDLmj3mKjfKRfEWbuvb2xI0J+IbjJzHQfjqqVENGGQweLCL5xqt7XAM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763693307; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=B6eNI828ogGk5DgEt/LD1ODPehtpxXO9IG+PQCUJrNo=; b=W3QPsD02FMthl2PciJVjGekpJV64ycamFv3lFrLboQ79a1XPAYaYHsKEkt9oIhyPS90TrXkz61cLWZSpRnttfyr/q/lyg4GG1FmaZtKyK/oevB8WtOmBRdeE41VIIcDbbxWNREEA6KGPjVPrNQmD3gVGYToCgqwZqcvLA/n/63U= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176369330700079.46873326071795; Thu, 20 Nov 2025 18:48:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMHBj-0003Qc-7X; Thu, 20 Nov 2025 21:47:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMHBb-0003Ot-5g for qemu-devel@nongnu.org; Thu, 20 Nov 2025 21:47:47 -0500 Received: from mail-southcentralusazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c10d::3] helo=SN4PR0501CU005.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMHBX-0006Il-Bz for qemu-devel@nongnu.org; Thu, 20 Nov 2025 21:47:45 -0500 Received: from BL1PR13CA0300.namprd13.prod.outlook.com (2603:10b6:208:2bc::35) by CH1PR12MB9600.namprd12.prod.outlook.com (2603:10b6:610:2ae::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Fri, 21 Nov 2025 02:47:34 +0000 Received: from BL02EPF0002992B.namprd02.prod.outlook.com (2603:10b6:208:2bc:cafe::1c) by BL1PR13CA0300.outlook.office365.com (2603:10b6:208:2bc::35) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Fri, 21 Nov 2025 02:47:34 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by BL02EPF0002992B.mail.protection.outlook.com (10.167.249.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Fri, 21 Nov 2025 02:47:34 +0000 Received: from honglei-remote.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 20 Nov 2025 18:47:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GhFqQBvf1tLSMn6t1tH4US0vx5jHgJklnIedOThbLH7cXvmyWESSCVQV5Ia8RqhCQGoCrsSEK8ZQ1YiE7ZfX6ndLajRepDzP80v/jqWKp99P16aSbpfBxh35CTlRnERonLCvn05i/u5XAD9G9TGv8PrlbVLaiVFFfSJjbTZv7MJyNw0DxIEQO80OcAQ9bTsOs8t0losFIXvT3/raYjnG4HnEXetWciWWi1xaZ37cETqIffkyLOnkV6qVs6prIhPNffrQAkFFiaTUhjpR5S2L1BS/WmOv/C/ZCN7um7ZYbpX6hVUt1Zckxn+Z3ZZ3LAH+4DgPVkY9aHRHY3DugmWBrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B6eNI828ogGk5DgEt/LD1ODPehtpxXO9IG+PQCUJrNo=; b=qjyvpGDO7mCJ5iUiOCGsIvjG0cO01xptwMmFKPKPAnf8llTIm5xdU+CGvUFFbsbwLojX7BRt/KMrsZ/TI2X3pKHiMJTnL6K5QWCAnmEd4ZA/p4etTPiC0kBH6QSCkP1kVoYBPAtidUlGPAqpopEqsKWGNZtl/m/CO49KPabhXUi7c9WZSwX9q5evlBT+tAFspqDY4IEc+XFUvdKyEAwj6+YXKz4qYReX+V0e/teK4T43Lzkjr2H7UqyCHrbhLwTSkE6SRM5RatJQVJvayPf+myjEhIFn2UdorLUCkDwgwRk9MRB/cAg0z+ABiizrYXGj8QRHpBjuxsxIitxX1+ZIcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B6eNI828ogGk5DgEt/LD1ODPehtpxXO9IG+PQCUJrNo=; b=hL/AMpj/xVjOnNDn0TbJUJlON0PeVCSG87X7DS5rRGJ/qI5EtUGpPuxi1ai9qOmM/zR8xeZ0AgguehfKiRjxHnnnb+w2paUzqOMw+HrrprvKmTVWNyFgt2n8w34+ML4Z4H9s3wuXpMt0CtcOBit/LWCMgwaqzQWmypFkHzusvXQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Honglei Huang To: , , CC: , , , , , Honglei Huang Subject: [v2 2/3] virtio-gpu: add configurable HSAKMT capset support Date: Fri, 21 Nov 2025 10:47:04 +0800 Message-ID: <20251121024705.1403042-3-honghuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251121024705.1403042-1-honghuan@amd.com> References: <20251121024705.1403042-1-honghuan@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0002992B:EE_|CH1PR12MB9600:EE_ X-MS-Office365-Filtering-Correlation-Id: 90a5f83d-a172-4e24-775f-08de28a852ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?XE/oZl/imyjst63Qsy++RnC5cBCrnmgfzSVj/iKupj6Qlvg+A0ZTuY6dqBeg?= =?us-ascii?Q?BAO3nc9Fr08dc0gALaRbZbCkdjnGuLZV+avIq4+/1YsIzRkCCGiFg58MbiNB?= =?us-ascii?Q?n7m4zS7LL4ieu/H6bel4uQ+YaBA7yNF8bLJN+4xiT4xhsUGoM46DrNK/2lag?= =?us-ascii?Q?mK3pWxwEYvGagwxrEoLR5XUfV9VBOkyVQyU6dabtMGIC4jqaO5Qi3ngrpqi4?= =?us-ascii?Q?maTKn4xDHnB0fMByRYna3HZvlD/IxdO2kxqvvPjt5D43jhqfBiCoxXzjRnhZ?= =?us-ascii?Q?fWdzTe/ZkzuOsUwExfOns4pJujdvNhDvGgnWoqaqtur5+bfVIl1AS10H4zEA?= =?us-ascii?Q?LAlaND2iPSxljPok+ZizQKTOORgCS8sRhk1828mZPI+UyfKepN67GGfbUaa8?= =?us-ascii?Q?xjKwajFAYQFKaVWQAEliamWF9HyIA0guGI4PseHIEEtvDmRxVMU2fzMFU2VX?= =?us-ascii?Q?8+vg0yVXyGx/jeFR5I0Bvd3a0HEF5cWQ/G5e5O0brLJ5Etil7asN3HCzmcwM?= =?us-ascii?Q?6dhOn4yE6cXKHnZJpjy3/4LgXIrX4RVUeyrqrAJJcTsMVXAND7V3qiE9ZhHO?= =?us-ascii?Q?Ht4BhVfOIoLenainPMLcntWc0l0dVEv4cUNW6g7uqSVfOs03V38BjNlVWMtl?= =?us-ascii?Q?LrR/jQ+jOd+JrJHalX12yh+b4G2mdidv9oAy+JehDCGWaBdX6lhV//SMpB9C?= =?us-ascii?Q?VddoSdf04aweBG72fVpI9WN3roucLh8sjvEcCCSfwlq/B2NKjF8vHmBRls2U?= =?us-ascii?Q?2RlxIdqMlgGiLKcRRDNl4uRE68txJnXUjmnMevSgdCo0cuOEGsI3v0WkYLhx?= =?us-ascii?Q?MZ8YnfGiodoKWMNAxUIF3S8rsmKsTmjbaE9iAdpw2j3jiQQQTcDKcu1v65r5?= =?us-ascii?Q?3h4d2SYwsCobMSOTszGl2Sh5imH5TGqo97z1uNgtJnD1Tb2MPb2kTAWDeq/z?= =?us-ascii?Q?TwB/Oeljj8rai1KmJhHtXQMOQzwxpxl8y70fhWHcHctTwpIpJ0xcephdBCPo?= =?us-ascii?Q?nIqZWRfPZawkolNo+Es7i2fNuYHoVpo5OdMvUYTM7dnj76gkINNpBNz+9bPZ?= =?us-ascii?Q?KT5cRSo46ALyEU0kMaKsuSlJJiJE/YlM4q/v4cxdMegei4NXasVQaNrFXY9A?= =?us-ascii?Q?d7FUng4Rq7TLA+w+LFRgR7zL+lqgBzgHcFHyvuBQeZOy71TwAQLRZTX4CoA/?= =?us-ascii?Q?GR0JHmEkC51TAv4HmBddR9KzIYI/3LZSHJa9Le5m0NVQuhHfyOJaMa0cQh+T?= =?us-ascii?Q?TyLegVxtuUxNKgC0MxI4C3NNsyo8PczrIhCJvOabeVsn8kyzBSbi6yYTNHyv?= =?us-ascii?Q?tWEpRPXO+DKhhmAGJrSUjhXCIRdR60aWUnesbX9mmmFevfpDSyyv1lxSIY6v?= =?us-ascii?Q?erFgrgNu80Atvde34YWQ+CHu61TQQlpdGpAwd87eNIr2hIny6rqyMtCtcG/p?= =?us-ascii?Q?LCmBq8KSBHJM4wJjKDvJN9OqfX0A5ltlYbj56V4gc/YK8Z14IlEgmFEh8CI+?= =?us-ascii?Q?mL5ZBUF3wSOj0bIkYYDthug/mK8ekZqWjr53bylxAM2RrmOvE5MhMdK6r2Vw?= =?us-ascii?Q?Rj2UntikJgDNrhSftTY=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(376014)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2025 02:47:34.3733 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90a5f83d-a172-4e24-775f-08de28a852ee X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0002992B.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH1PR12MB9600 Received-SPF: permerror client-ip=2a01:111:f403:c10d::3; envelope-from=Honglei1.Huang@amd.com; helo=SN4PR0501CU005.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1763693308177018900 Content-Type: text/plain; charset="utf-8" Changes include: - Add VIRTIO_GPU_FLAG_HSAKMT_ENABLED flag to virtio_gpu_base_conf_flags - Add virtio_gpu_hsakmt_enabled() macro for configuration checking - Add "hsakmt" device property to virtio-gpu-gl device - Modify virtio_gpu_virgl_get_capsets() to conditionally enable HSAKMT capset based on configuration flag and runtime capability check The HSAKMT capset is now only enabled when: 1. The "hsakmt=3Don" device property is set (defaults to false) 2. virgl_renderer_get_cap_set() reports capset_max_size > 0 Usage: -device virtio-gpu-gl,hsakmt=3Don This provides better control over HSAKMT functionality and avoids exposing unsupported capabilities to guests. Signed-off-by: Honglei Huang --- hw/display/virtio-gpu-gl.c | 2 ++ hw/display/virtio-gpu-virgl.c | 12 ++++++++++++ include/hw/virtio/virtio-gpu.h | 3 +++ include/standard-headers/linux/virtio_gpu.h | 1 + 4 files changed, 18 insertions(+) diff --git a/hw/display/virtio-gpu-gl.c b/hw/display/virtio-gpu-gl.c index c06a078fb3..4ed2f53e4e 100644 --- a/hw/display/virtio-gpu-gl.c +++ b/hw/display/virtio-gpu-gl.c @@ -159,6 +159,8 @@ static const Property virtio_gpu_gl_properties[] =3D { VIRTIO_GPU_FLAG_STATS_ENABLED, false), DEFINE_PROP_BIT("venus", VirtIOGPU, parent_obj.conf.flags, VIRTIO_GPU_FLAG_VENUS_ENABLED, false), + DEFINE_PROP_BIT("hsakmt", VirtIOGPU, parent_obj.conf.flags, + VIRTIO_GPU_FLAG_HSAKMT_ENABLED, false), }; =20 static void virtio_gpu_gl_device_unrealize(DeviceState *qdev) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index c927275c79..d907cc75e2 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -1160,6 +1160,9 @@ int virtio_gpu_virgl_init(VirtIOGPU *g) if (virtio_gpu_venus_enabled(g->parent_obj.conf)) { flags |=3D VIRGL_RENDERER_VENUS | VIRGL_RENDERER_RENDER_SERVER; } + if (virtio_gpu_hsakmt_enabled(g->parent_obj.conf)) { + flags |=3D VIRGL_RENDER_USE_HSAKMT; + } #endif =20 ret =3D virgl_renderer_init(g, flags, &virtio_gpu_3d_cbs); @@ -1218,5 +1221,14 @@ GArray *virtio_gpu_virgl_get_capsets(VirtIOGPU *g) } } =20 + if (virtio_gpu_hsakmt_enabled(g->parent_obj.conf)) { + virgl_renderer_get_cap_set(VIRTIO_GPU_CAPSET_HSAKMT, + &capset_max_ver, + &capset_max_size); + if (capset_max_size) { + virtio_gpu_virgl_add_capset(capset_ids, VIRTIO_GPU_CAPSET_HSAK= MT); + } + } + return capset_ids; } diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h index 58e0f91fda..c820247db8 100644 --- a/include/hw/virtio/virtio-gpu.h +++ b/include/hw/virtio/virtio-gpu.h @@ -100,6 +100,7 @@ enum virtio_gpu_base_conf_flags { VIRTIO_GPU_FLAG_RUTABAGA_ENABLED, VIRTIO_GPU_FLAG_VENUS_ENABLED, VIRTIO_GPU_FLAG_RESOURCE_UUID_ENABLED, + VIRTIO_GPU_FLAG_HSAKMT_ENABLED, }; =20 #define virtio_gpu_virgl_enabled(_cfg) \ @@ -122,6 +123,8 @@ enum virtio_gpu_base_conf_flags { (_cfg.hostmem > 0) #define virtio_gpu_venus_enabled(_cfg) \ (_cfg.flags & (1 << VIRTIO_GPU_FLAG_VENUS_ENABLED)) +#define virtio_gpu_hsakmt_enabled(_cfg) \ + (_cfg.flags & (1 << VIRTIO_GPU_FLAG_HSAKMT_ENABLED)) =20 struct virtio_gpu_base_conf { uint32_t max_outputs; diff --git a/include/standard-headers/linux/virtio_gpu.h b/include/standard= -headers/linux/virtio_gpu.h index b85e781a2d..6c54cb745f 100644 --- a/include/standard-headers/linux/virtio_gpu.h +++ b/include/standard-headers/linux/virtio_gpu.h @@ -313,6 +313,7 @@ struct virtio_gpu_cmd_submit { #define VIRTIO_GPU_CAPSET_VENUS 4 #define VIRTIO_GPU_CAPSET_CROSS_DOMAIN 5 #define VIRTIO_GPU_CAPSET_DRM 6 +#define VIRTIO_GPU_CAPSET_HSAKMT 8 =20 /* VIRTIO_GPU_CMD_GET_CAPSET_INFO */ struct virtio_gpu_get_capset_info { --=20 2.34.1 From nobody Sun Feb 8 17:51:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1763693334; cv=pass; d=zohomail.com; s=zohoarc; b=nlaSalTgwwmrhxJUYBEH5IzDHEHvanSH/XBFDW2wf8n0Nyu9VKZSYXHqRDr1tedCpglTQywb6K2sQAK3/bVi455bgXvluQLtZdBry7RDEx3Nx0conHDmEypRt7L1ZIOhDb42tRpEut86aTfZtPpdwPLgqUZj+ODJ/o8Y/5ZY6ec= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763693334; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iFu4503ISJFeKGv67QIVk9I8pXGL+xv1E4okLu5nYIY=; b=J+y2KlCOlhLcXzDZSUSf5Wf4X0vtbC6iTU0Cjj/zOccMwlXP34HWzv0vSikKsf6NSLkFG0XU5mcbUWnaW6H6k3UPTnL3fLWyUcOA11U4IVz0OZDaEAtoUORamjgDvLMn9iVtBH/eMNTmsa0W5cPG2XGOJ5cFfUxQ0n9FVNBFlR4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763693334025688.3630000146568; Thu, 20 Nov 2025 18:48:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vMHBd-0003P2-L5; Thu, 20 Nov 2025 21:47:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMHBY-0003O1-1T for qemu-devel@nongnu.org; Thu, 20 Nov 2025 21:47:44 -0500 Received: from mail-eastusazlp170120007.outbound.protection.outlook.com ([2a01:111:f403:c101::7] helo=BL0PR03CU003.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vMHBW-0006Io-7h for qemu-devel@nongnu.org; Thu, 20 Nov 2025 21:47:43 -0500 Received: from BL1PR13CA0394.namprd13.prod.outlook.com (2603:10b6:208:2c2::9) by BY5PR12MB4049.namprd12.prod.outlook.com (2603:10b6:a03:201::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.11; Fri, 21 Nov 2025 02:47:37 +0000 Received: from BL02EPF00029928.namprd02.prod.outlook.com (2603:10b6:208:2c2:cafe::82) by BL1PR13CA0394.outlook.office365.com (2603:10b6:208:2c2::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Fri, 21 Nov 2025 02:47:37 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by BL02EPF00029928.mail.protection.outlook.com (10.167.249.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Fri, 21 Nov 2025 02:47:36 +0000 Received: from honglei-remote.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 20 Nov 2025 18:47:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GBKMBpDRYjSD+g6ZExwJoR/l6Q8BPDCAnNB8NzNIeTz8eUf3yhKQj3n3i8gesjlgJvAqtPuc9T72zmWTdPH4oPFjMiX+Bo7AURR6DHVHOLGxrGp8WxXJYKAOBXVtLrWbcK0blpQufUpsE5yDeZH62zm+P3sZbP7baonkMngr9tdbMxPy5g23C04ISu3LmLUkZLk85KOnW9V9CnSaeY/4FZKTvOsdjICAMAkksKT1S/Q/MAKOV50JaC5K6Hw1/1Wi+qVg0Ihv54pyKHXzNHAXsKi8RtnJye0tafdLapR4FVtNoEMbVeLA2Fi1u2hHF69yz39hUjUJyPyU+y3NuZUdnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iFu4503ISJFeKGv67QIVk9I8pXGL+xv1E4okLu5nYIY=; b=Blqg45/Hi7slBlJFVV2AJS8EPSHxF60klN8m8j0QpaZSL8FNFQG29uhFoBKOPnuTOEL81f+AcULbTcGHByGKU7cgNpKACc9YTYV6xNGULOnLSKVbJDMzGEtR2Xou4XjMsmVhsxDOjDqJvjJ1xgHTMM4sOrbejkgXbUuqaiNbyc8bfulxV/zVnwKMzH8/vjXesH35PmjUsxHjR5Hip8p02NFD67m3efLs95/UG0bnCMn1fJgN5Bj/G7Uy25A4eZApB+1uKGKvaAmYcBvcemw3qRBxFuF+espckgyM81abFlOE9xzoXaJKBigmnN3u96laHwhmjdVasG5FMvGqnfWAiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iFu4503ISJFeKGv67QIVk9I8pXGL+xv1E4okLu5nYIY=; b=NGE1bhwppjpUkkmPuu/vt/pfqeJGy65cRtd+Gv1TjgBeK/ZPu6Tz62ZqOSEa7PrJv+VurFLolX51vSFAFyKrdfr94IM//get4GqEUkN01VKYW0L8cTqoXUEtyaTA+rNXgb+q75SA3OD+Tnw5OZFoQV4q8d0OdppBab2L5Ina+ME= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Honglei Huang To: , , CC: , , , , , Honglei Huang Subject: [v2 3/3] virtio-gpu: Add VIRTIO_GPU_F_RESOURCE_USERPTR feature support Date: Fri, 21 Nov 2025 10:47:05 +0800 Message-ID: <20251121024705.1403042-4-honghuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251121024705.1403042-1-honghuan@amd.com> References: <20251121024705.1403042-1-honghuan@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00029928:EE_|BY5PR12MB4049:EE_ X-MS-Office365-Filtering-Correlation-Id: ebe950dd-46d5-4bf7-5240-08de28a85475 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?iWHCfng6jwckwWjUpr9dwvM4ktQ5m0TmldziXZEl/WFRjP9boKAmT7co4tvL?= =?us-ascii?Q?YsGg8AgqTCmbgywnaSs+QycucbfGS/HpHnubUQkBtkv+JakfZksxjrz0yyzZ?= =?us-ascii?Q?1rj/5mrJ+MJUlD9ctiB4OetC1TyAULlUIx4KIZ5FvPEfWn/kKcPrruzShvc1?= =?us-ascii?Q?/J+fUwaC9Yx5y4LkKK0KiMAMvKyHMx6m847TEUoSwGsxsEoZkdtixpfUDmrd?= =?us-ascii?Q?CfFLm3HnSxFXOZoPcK5PLlQUTsgxsOWjsIPB5dfa06UwByYbcvAv+BgswR8i?= =?us-ascii?Q?+KrIcBx0lkxJayLMTbcYtrZ8CyJhKw/FjAPVodS0rpev+MWrRdnqXdKOCQMh?= =?us-ascii?Q?BUhGiu6IdbjUlICEwfuJLuy2YVn9wnDRA/V6G6JAtU+t6RL0bp2nULZKQBnl?= =?us-ascii?Q?uakH6MLFlyA1UUIPViL+A1IgxI9v19Se73xNvOfzOe+IvBncEy9weIwFbIp+?= =?us-ascii?Q?gSNXHV+T4thncdBaHEH1NQQdydx2b1NisTBezLXrFV3kKZFfbrmcKaAc4TTd?= =?us-ascii?Q?Z1LeSkKIxXIuffTBOTLhs+Yk0CRhKHyB1STpgMOVPbxireVSvDEkJCOJ7/Ag?= =?us-ascii?Q?A3J+pqHYLklegwj/YUMXm3/swZELBg9LtOxwUyUcFyCblnhiJ+Qg+4A9hBN+?= =?us-ascii?Q?g9KljgUYq3kFu6uqu4YGlpM7BLZdptmNkk45eUMvRnUp8iedbCLSSjvV26C1?= =?us-ascii?Q?IWIDmDb3wOtACYQtUP/VsJYRAX1mY+4cEOyPhRew8smAtghMoCpG6OtphIWH?= =?us-ascii?Q?RAWZ08gEIaAGDetC5yGkdG1xsvOT06e38ehw7jml33JZ+vz4HK8jQ+Q3gz+p?= =?us-ascii?Q?06W/qwhUvaC+7BegNRV/VRqVBvgsOhWGkMRDCOXTNyeFBhX/iJqX2wcmqp4X?= =?us-ascii?Q?cMoPkmLkiKAYavFma3zGAJ649toEsBWp1xGTp5FBDNdA1Ui41ekZ4a+oCSWF?= =?us-ascii?Q?OxWnJSEvN1rHnqJZSelZwBDOeiKFKwdPh7kd949E5CKLypVbeYdvIiQNoMJj?= =?us-ascii?Q?pm+GWsxMs9/6ex7EzGgk7cfpYz3GyI/uZy/OV4ZQzUxmKOkZjHTZwxliu1tC?= =?us-ascii?Q?Xl0H9IcALQw1rLFlc83fLEaQ84jhaYmIbH8a4yaoz7XihgVRKUAYTl7c6gfj?= =?us-ascii?Q?AKvmNNKCl/0a9c9Y8uiuwbB6G3SRpIuF0QtiEwQKtnhWWrj52MqS488iSRkq?= =?us-ascii?Q?uj5u6i17xOgENQHOWTqWBp3zaZFmuHD9RImKCEY6HuYF2u2Gp5sbj+87/2Nu?= =?us-ascii?Q?1/ya9vnRetFgORyDA60y5pkhAX+F/XvpAivmza+4MjI6xsdSwM77XTagNMp2?= =?us-ascii?Q?uKBP5gTli5TKfMALTTQPLObTmOjsnSjcxSxfduTMBPqiTRNGebSA31nhVo/E?= =?us-ascii?Q?OAtO+V5exg4jtI/QnKmCyzvCFURYsf/gMGNS6XyWW2fP/gat0LyZ7RdqRdZO?= =?us-ascii?Q?5ifZ8rr/JTUf73AiViHY4OohKf+ajfEKx1O9msFdkhJmWeNB3+G06phSOE3b?= =?us-ascii?Q?aXV8iJXCPW4K3ulpj9O05q1y9pVXnv3eKcgoTVqEzrxgATby3GU+aSu1e0vs?= =?us-ascii?Q?dqhtLgX1tcai/ijW5Rc=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(376014)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2025 02:47:36.9361 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ebe950dd-46d5-4bf7-5240-08de28a85475 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00029928.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4049 Received-SPF: permerror client-ip=2a01:111:f403:c101::7; envelope-from=Honglei1.Huang@amd.com; helo=BL0PR03CU003.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1763693336897018900 Content-Type: text/plain; charset="utf-8" This patch introduces support for the VIRTIO_GPU_F_RESOURCE_USERPTR feature in virtio-gpu implementation: - Add VIRTIO_GPU_F_RESOURCE_USERPTR feature flag definition - Implement resource_userptr property as a configurable option - Add VIRTIO_GPU_FLAG_RESOURCE_USERPTR_ENABLED configuration flag - Enable feature negotiation when resource_userptr is enabled Usage: -device virtio-gpu-gl,userptr=3Don This feature allows virtio-gpu to support user pointer resources, enhancing memory management capabilities for GPU virtualization scenarios. Signed-off-by: Honglei Huang --- hw/display/virtio-gpu-base.c | 3 +++ hw/display/virtio-gpu.c | 2 ++ include/hw/virtio/virtio-gpu.h | 3 +++ include/standard-headers/linux/virtio_gpu.h | 2 ++ 4 files changed, 10 insertions(+) diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c index 7269477a1c..f013a4ece6 100644 --- a/hw/display/virtio-gpu-base.c +++ b/hw/display/virtio-gpu-base.c @@ -264,6 +264,9 @@ virtio_gpu_base_get_features(VirtIODevice *vdev, uint64= _t features, if (virtio_gpu_resource_uuid_enabled(g->conf)) { features |=3D (1 << VIRTIO_GPU_F_RESOURCE_UUID); } + if (virtio_gpu_resource_userptr_enabled(g->conf)) { + features |=3D (1 << VIRTIO_GPU_F_RESOURCE_USERPTR); + } =20 return features; } diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 956dc811fa..5f1dc80060 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -1685,6 +1685,8 @@ static const Property virtio_gpu_properties[] =3D { 256 * MiB), DEFINE_PROP_BIT("blob", VirtIOGPU, parent_obj.conf.flags, VIRTIO_GPU_FLAG_BLOB_ENABLED, false), + DEFINE_PROP_BIT("userptr", VirtIOGPU, parent_obj.conf.flags, + VIRTIO_GPU_FLAG_RESOURCE_USERPTR_ENABLED, false), DEFINE_PROP_SIZE("hostmem", VirtIOGPU, parent_obj.conf.hostmem, 0), DEFINE_PROP_UINT8("x-scanout-vmstate-version", VirtIOGPU, scanout_vmst= ate_version, 2), }; diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h index c820247db8..ff68f3c451 100644 --- a/include/hw/virtio/virtio-gpu.h +++ b/include/hw/virtio/virtio-gpu.h @@ -101,6 +101,7 @@ enum virtio_gpu_base_conf_flags { VIRTIO_GPU_FLAG_VENUS_ENABLED, VIRTIO_GPU_FLAG_RESOURCE_UUID_ENABLED, VIRTIO_GPU_FLAG_HSAKMT_ENABLED, + VIRTIO_GPU_FLAG_RESOURCE_USERPTR_ENABLED, }; =20 #define virtio_gpu_virgl_enabled(_cfg) \ @@ -125,6 +126,8 @@ enum virtio_gpu_base_conf_flags { (_cfg.flags & (1 << VIRTIO_GPU_FLAG_VENUS_ENABLED)) #define virtio_gpu_hsakmt_enabled(_cfg) \ (_cfg.flags & (1 << VIRTIO_GPU_FLAG_HSAKMT_ENABLED)) +#define virtio_gpu_resource_userptr_enabled(_cfg) \ + (_cfg.flags & (1 << VIRTIO_GPU_FLAG_RESOURCE_USERPTR_ENABLED)) =20 struct virtio_gpu_base_conf { uint32_t max_outputs; diff --git a/include/standard-headers/linux/virtio_gpu.h b/include/standard= -headers/linux/virtio_gpu.h index 6c54cb745f..321477598e 100644 --- a/include/standard-headers/linux/virtio_gpu.h +++ b/include/standard-headers/linux/virtio_gpu.h @@ -65,6 +65,8 @@ */ #define VIRTIO_GPU_F_CONTEXT_INIT 4 =20 +#define VIRTIO_GPU_F_RESOURCE_USERPTR 5 + enum virtio_gpu_ctrl_type { VIRTIO_GPU_UNDEFINED =3D 0, =20 --=20 2.34.1