From nobody Mon Feb 9 20:35:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763666046; cv=none; d=zohomail.com; s=zohoarc; b=DZpByX7cGG+2PK575LeUV5D6EYxbZAwinkdZ3CQx/vjZdaJnRnXex9oqUCEwKDqoN7InSuYCVPjEufuOSQ/yYFp+RK7BTtePTB0J5AKl+XqGY040u1Nm9xAz+JDFmpwWIIEeXTIKzVCLQS0r59BhqS92PK4t1QytyhECzBO/AdE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763666046; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=umeOgmRBAWLAHxdfid+WkX0aqDhcSVhY+M4Sagb57i8=; b=BwqSHwi7m0VO7+paAj2pgIrjp8uUtVpGPff4pjP42J33qlJIMD6Gm66nAWobdfVQO6/MSKHUmqnj2YcGhdOap6whqnHdPvwiUBQTgnONg3+S9wLEjMtfxVAXTEeIN0XC3xfJlwMS24GlJgT3Rlwolf3NYgMVRctjiKAzVDuH25k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763666046184121.91935698917632; Thu, 20 Nov 2025 11:14:06 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1167736.1493957 (Exim 4.92) (envelope-from ) id 1vMA6N-0007Jf-H8; Thu, 20 Nov 2025 19:13:55 +0000 Received: by outflank-mailman (output) from mailman id 1167736.1493957; Thu, 20 Nov 2025 19:13:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vMA6N-0007JY-Du; Thu, 20 Nov 2025 19:13:55 +0000 Received: by outflank-mailman (input) for mailman id 1167736; Thu, 20 Nov 2025 19:13:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vMA6L-000753-MP for xen-devel@lists.xenproject.org; Thu, 20 Nov 2025 19:13:53 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0c239c3e-c645-11f0-980a-7dc792cee155; Thu, 20 Nov 2025 20:13:51 +0100 (CET) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-2sTwlhUGNZObweGKQdVHUQ-1; Thu, 20 Nov 2025 14:13:48 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9C6C319560A1; Thu, 20 Nov 2025 19:13:43 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.18]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7CAC730044DB; Thu, 20 Nov 2025 19:13:41 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 50C8F21E66EF; Thu, 20 Nov 2025 20:13:39 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c239c3e-c645-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763666030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=umeOgmRBAWLAHxdfid+WkX0aqDhcSVhY+M4Sagb57i8=; b=H/hfm1I2bU/CqiYpSSkYO+fJDOTaKOWCp+ZVq7JwR2RMu91S2IiowOOuQdnfq3GomfQyg2 PHrRXipbhbtaLFF/1jnTQaHXZIMXEqqnfwl4XZY6YNakBZKn4l5IKRWcyiZ32MTJrfPSkj HVTAIcuG89RfMPFBs+bhX5vwRHBwz9c= X-MC-Unique: 2sTwlhUGNZObweGKQdVHUQ-1 X-Mimecast-MFC-AGG-ID: 2sTwlhUGNZObweGKQdVHUQ_1763666024 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: arei.gonglei@huawei.com, pizhenwei@bytedance.com, alistair.francis@wdc.com, stefanb@linux.vnet.ibm.com, kwolf@redhat.com, hreitz@redhat.com, sw@weilnetz.de, qemu_oss@crudebyte.com, groug@kaod.org, mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, kraxel@redhat.com, shentey@gmail.com, npiggin@gmail.com, harshpb@linux.ibm.com, sstabellini@kernel.org, anthony@xenproject.org, paul@xen.org, edgar.iglesias@gmail.com, elena.ufimtseva@oracle.com, jag.raman@oracle.com, sgarzare@redhat.com, pbonzini@redhat.com, fam@euphon.net, philmd@linaro.org, alex@shazbot.org, clg@redhat.com, peterx@redhat.com, farosas@suse.de, lizhijian@fujitsu.com, dave@treblig.org, jasowang@redhat.com, samuel.thibault@ens-lyon.org, michael.roth@amd.com, kkostiuk@redhat.com, zhao1.liu@intel.com, mtosatti@redhat.com, rathc@linux.ibm.com, palmer@dabbelt.com, liwei1518@gmail.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, marcandre.lureau@redhat.com, qemu-block@nongnu.org, qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, qemu-riscv@nongnu.org Subject: [PATCH 03/14] tap-solaris: Use error_setg_file_open() for better error messages Date: Thu, 20 Nov 2025 20:13:28 +0100 Message-ID: <20251120191339.756429-4-armbru@redhat.com> In-Reply-To: <20251120191339.756429-1-armbru@redhat.com> References: <20251120191339.756429-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763666048297018900 Content-Type: text/plain; charset="utf-8" Error messages change from Can't open /dev/ip (actually /dev/udp) Can't open /dev/tap Can't open /dev/tap (2) to Could not open '/dev/udp': REASON Could not open '/dev/tap': REASON where REASON is the value of strerror(errno). Signed-off-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- net/tap-solaris.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/tap-solaris.c b/net/tap-solaris.c index 75397e6c54..faf7922ea8 100644 --- a/net/tap-solaris.c +++ b/net/tap-solaris.c @@ -87,13 +87,13 @@ static int tap_alloc(char *dev, size_t dev_size, Error = **errp) =20 ip_fd =3D RETRY_ON_EINTR(open("/dev/udp", O_RDWR, 0)); if (ip_fd < 0) { - error_setg(errp, "Can't open /dev/ip (actually /dev/udp)"); + error_setg_file_open(errp, errno, "/dev/udp"); return -1; } =20 tap_fd =3D RETRY_ON_EINTR(open("/dev/tap", O_RDWR, 0)); if (tap_fd < 0) { - error_setg(errp, "Can't open /dev/tap"); + error_setg_file_open(errp, errno, "/dev/tap"); return -1; } =20 @@ -107,7 +107,7 @@ static int tap_alloc(char *dev, size_t dev_size, Error = **errp) =20 if_fd =3D RETRY_ON_EINTR(open("/dev/tap", O_RDWR, 0)); if (if_fd < 0) { - error_setg(errp, "Can't open /dev/tap (2)"); + error_setg_file_open(errp, errno, "/dev/tap"); return -1; } if(ioctl(if_fd, I_PUSH, "ip") < 0){ --=20 2.49.0