From nobody Mon Feb 9 15:46:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nvidia.com); dmarc=pass(p=reject dis=none) header.from=nvidia.com ARC-Seal: i=2; a=rsa-sha256; t=1763645128; cv=pass; d=zohomail.com; s=zohoarc; b=fytOLCLkZiGidasKWcALR3J4hcjf4yUPKXE1mApcQTw26QwCYFNpK9+Cmw9reOJHG1YwW9/OCcGSyG7sFPK5KsTidUQXjdVa9YXRPlEy6w1PX6PkYkQfrOBCePAfmI1e658w/qnwjkhR9NRzk7R72qK4ZohuT4lJ956lABBSV8c= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763645128; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=N4R84anKneIvg4GJsB3I0hhRoO4dEMc0+mAYtJX5EH4=; b=XpM+ASdKoeNEDbMfYGLnLt3h8qlElwG4GfaJuMr1/sZQdVlWFEg6n3uDqeYbCPlcmuyaCgWlRlcu7ECo295Q5idk1DmhXuyMmzw4UthYy3SnNbFEe9VpjaBeW1u6npFft2GLurCdkhwGnZGQ8ZQdt4Q7edVfDD0EXm7ELiGBNSg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nvidia.com); dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763645128248435.3674626946997; Thu, 20 Nov 2025 05:25:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vM4en-0007TR-Ea; Thu, 20 Nov 2025 08:25:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vM4ek-0007N0-Dm; Thu, 20 Nov 2025 08:25:02 -0500 Received: from mail-westus3azlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c107::3] helo=PH0PR06CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vM4ei-0002NN-Sr; Thu, 20 Nov 2025 08:25:02 -0500 Received: from CH3P220CA0008.NAMP220.PROD.OUTLOOK.COM (2603:10b6:610:1e8::19) by IA0PR12MB7626.namprd12.prod.outlook.com (2603:10b6:208:438::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.11; Thu, 20 Nov 2025 13:24:52 +0000 Received: from CH1PEPF0000A345.namprd04.prod.outlook.com (2603:10b6:610:1e8:cafe::38) by CH3P220CA0008.outlook.office365.com (2603:10b6:610:1e8::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.11 via Frontend Transport; Thu, 20 Nov 2025 13:24:52 +0000 Received: from mail.nvidia.com (216.228.117.161) by CH1PEPF0000A345.mail.protection.outlook.com (10.167.244.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 13:24:52 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 05:24:40 -0800 Received: from NV-2Y5XW94.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 05:24:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XlqaTevlh3knepBbKgoUiCbaWa3tj9l/a75tZ/x7frU+F0S/R0hcudHALT1cOsuyu3Qo1ZrG9tI00oJEAg35uIXQsjZdBhIQddijdaKhFYJbC3GMPA0TGhmtiPhxpKL3sdGhtrOGsyOnzDvfsarHgSs87wexwFOF0ydcgsrnrlcFgNRSlpCMUEDZIPMgK8ys1evBkCApZuZDAHttG8zS7r/ytS6BBo68xK5GN1Dvi2RX1zuIHl5OkRh9akCEo7A1niPsCWsULLbtj/qmGt5FTAotwJePIWwHj8yOX54J+3KKlrM1uVsXhuKNOqSrk7BnHUaRvp78yiFQBxXxBmRQJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N4R84anKneIvg4GJsB3I0hhRoO4dEMc0+mAYtJX5EH4=; b=j7fak4ESret3WBjwVNlwAAfegEi5TmqeImnfCAHbexhS4PygF4x1jLxrk4DLkb5SMQkSHysRdz83D/hVHg3rIEezC7TFrTDTrUauhI4U6fPvJPpHGdk/7TxvPyTIx6dXEYPFhM+K3qUwXQdMiUvhJP3WlPdJaDrKZqu98NF/j6XGxRAztD+TbxzVBCrtjUDjYdoha4s16C9CAiBcPAbWAJvZYLXBoj491S9Or5qieZ6je6xh6+v5xdkdR3sKUjazR53DBQmtle3yS6xwc0GeFYBd0ZHuJk2Cf5jZnKEs1zV/nz0EwhHH/u21dvaFR0s44AaVie2U0TxlgCPLPuUofw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=nongnu.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N4R84anKneIvg4GJsB3I0hhRoO4dEMc0+mAYtJX5EH4=; b=DNn9iJAWxGk2RscUBX8fTeHWdRGqhTAwhZ32zw7vYwTERyxeB89pXyDUt+BVF4VJwoux1M+7nAsBIGBIMtsR9nCUg4EwQGU1o5MgdE7yTCfin6ft3X4Y9pdgEhKIiw+Drxfp0YHpjNNKPFIafX0yh9rrVPO/pWM9+Emi+cVoOIAUMU9CMeO2uCcArd7QbgtELPY/VCw1EvgxkBQurd1Sk58hCa+RJYk8XT5TYrUH/YGOGGyHJsjnZ6BLSapaz9nnAvTV4XTa/Xg9n6KcVSE8uGeqEakfr/rrbioNZgxD5rESf1ULqmMcPap4CIcRIBXxWx5YyUYTZ/IkTHs+Q6QHzA== X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C From: Shameer Kolothum To: , CC: , , , , , , , , , , , , , , , Subject: [PATCH v6 19/33] hw/arm/smmuv3: Initialize ID registers early during realize() Date: Thu, 20 Nov 2025 13:21:59 +0000 Message-ID: <20251120132213.56581-20-skolothumtho@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251120132213.56581-1-skolothumtho@nvidia.com> References: <20251120132213.56581-1-skolothumtho@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A345:EE_|IA0PR12MB7626:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d5f4c18-e934-4344-2213-08de2838304a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|376014|36860700013|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?knNwwZX3MiI75sE9EY/SO3o7kPbu/isZJfTs2nhl9zgXhaPv+TulYOsxy7Sq?= =?us-ascii?Q?8NKuLEAmzRVZaL2iEvn2K8b/i6VMGtzXbBGU5kZaOZ33mAUR2JM/GtP7/1Z/?= =?us-ascii?Q?hdY0X5jsqDRrdV9+l1jYx/NFu4c7Bge/K+CdybfhwCocmECfrO8SrWZYXrlH?= =?us-ascii?Q?TbyKPCN6y+mARB9QEfG2MM8TPYZ57Jd+xqx3DEyyRSFbweGeom5vvW9agCPt?= =?us-ascii?Q?/eQRvEMoLJEOccJJ6zpLp8gMzWKLQ2kD4lcVubrasX+NLhIWKTmDDyNf8J7w?= =?us-ascii?Q?btYS8drEeReCypG5iuXtyzoIQvFEz5gdr/x0Kt4HdNbH0abpIu6KGGq17hM8?= =?us-ascii?Q?8B8VlemYfpT/vId0zjM10Hdi8JncimIQx4YRdFsaQ7CyF33z1ve8V5YPCkSK?= =?us-ascii?Q?sAHBNvt133UGdYSIemFKZWlGMlCiV73ggEjbzq+42Pv/H2gkGRxQB+Gf3b/x?= =?us-ascii?Q?FiMAMRLBwKmxqw1ySbTAdJ9qFKWdB05vDasR9/ks1D2AAEyDVJtUJ+Vz3IFU?= =?us-ascii?Q?7omN2uYOtOsVkOm0+WosNDsjgTgbzcEkSC68qUjvDLH/G7uLSTokGuCAqomx?= =?us-ascii?Q?AWfSjcq2gxzVNx3W+AE7AaFPNMcxtLZ+T+pYoeJu2NuxYJrcV3MFRfPHhYBT?= =?us-ascii?Q?Z+PnCbl9io6qziAryZbNeLvZQwyVhxgIM3mTSrCLuYQ5/7+Lmzr0ZaIU0rOM?= =?us-ascii?Q?4Wkc8Zpq6ouu5RXcOqXYch9YWPvTgeLE2WAJEQgww6ZbRh3CDZREffa4H0Z4?= =?us-ascii?Q?4l+KaYuMbQxBEufKjp7J+reBgvOY8fQxfueI5k3s3rsKWNjFnDwflCLyLEpA?= =?us-ascii?Q?V+ZkpSW6dFAmg6GmSCJWee9fxT4tufRGgxAtpmRdMjII1Ru2Pp9ISR7D+cuW?= =?us-ascii?Q?BQGrRufjpwRdrd5lmv+RIdsLT7v5//Ry2hPD+yzBXqqc1YSTUnRXG26vFF9I?= =?us-ascii?Q?QEmqksLhHc1LqguBfcxd70EluUl8oNW/7tzSbSKoV5HsV+hlW6HG1UvpQFy8?= =?us-ascii?Q?Z59DoSyiqq/UBtDiHxDHpmr8wQ+XD4ie08qFVtsDUTaGFAd2IqKwNA5E/a3a?= =?us-ascii?Q?cw7eUGSIk8CdgclHEJX6z6/6xgnky2Re5MM5Ee8MCT2DeeZ+t9A/rm1/jbH0?= =?us-ascii?Q?Gy2CQ7kqdYLWD8ThvZcTKw9h56J9G6n7CPxUBTm87+SOQxLTGFzKN1DxJ3R1?= =?us-ascii?Q?RsFG0eCZ41Lw2rjqcJjvNRvaRvaFPAK3FNWrzhpccFnMj9VlWwOUlQS5MrKZ?= =?us-ascii?Q?amQ8+0/j+y4UNFoRlZqaZ6kdyZsoZiA2uelzfFHldpSiDn/o0F09+Jdd+1u2?= =?us-ascii?Q?PG3dM3CtlNc8D4JPBNiwKXBJroBJqZocaqB4XRogE+7hHIPodf8qeiDKH4jB?= =?us-ascii?Q?GOSSDvotp6DQD9LtxwxfJphGA2OdFO45sYZ/1skNl7aA75ZCR0tImzFuqm6t?= =?us-ascii?Q?FXPPhrpgGpkLEzVLEtjsp6e3GAnO3jDFvSVrwR8Qn5X2dj4huCRcjSP4VZTD?= =?us-ascii?Q?8aeuzN7VVpcfeoUlzAYzDPCH3nRtbuWK6WIsnmY0ymg4wmW5rQdOOxfpXl5n?= =?us-ascii?Q?OQVIZrR4QUQ+WXqaRgg=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(7416014)(376014)(36860700013)(1800799024)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 13:24:52.5032 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2d5f4c18-e934-4344-2213-08de2838304a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A345.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7626 Received-SPF: permerror client-ip=2a01:111:f403:c107::3; envelope-from=skolothumtho@nvidia.com; helo=PH0PR06CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @Nvidia.com) X-ZM-MESSAGEID: 1763645129495018900 Content-Type: text/plain; charset="utf-8" Factor out ID register init into smmuv3_init_id_regs() and call it from realize(). This ensures ID registers are initialized early for use in the accelerated SMMUv3 path and will be utilized in subsequent patch. Other registers remain initialized in smmuv3_reset(). Reviewed-by: Nicolin Chen Reviewed-by: Jonathan Cameron Reviewed-by: Eric Auger Signed-off-by: Shameer Kolothum --- hw/arm/smmuv3.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index 513da966a4..dba5abc8d3 100644 --- a/hw/arm/smmuv3.c +++ b/hw/arm/smmuv3.c @@ -258,7 +258,12 @@ void smmuv3_record_event(SMMUv3State *s, SMMUEventInfo= *info) info->recorded =3D true; } =20 -static void smmuv3_init_regs(SMMUv3State *s) +/* + * Called during realize(), as the ID registers will be accessed early in = the + * SMMUv3 accel path for feature compatibility checks. The remaining regis= ters + * are initialized later in smmuv3_reset(). + */ +static void smmuv3_init_id_regs(SMMUv3State *s) { /* Based on sys property, the stages supported in smmu will be adverti= sed.*/ if (s->stage && !strcmp("2", s->stage)) { @@ -298,7 +303,11 @@ static void smmuv3_init_regs(SMMUv3State *s) s->idr[5] =3D FIELD_DP32(s->idr[5], IDR5, GRAN4K, 1); s->idr[5] =3D FIELD_DP32(s->idr[5], IDR5, GRAN16K, 1); s->idr[5] =3D FIELD_DP32(s->idr[5], IDR5, GRAN64K, 1); + s->aidr =3D 0x1; +} =20 +static void smmuv3_reset(SMMUv3State *s) +{ s->cmdq.base =3D deposit64(s->cmdq.base, 0, 5, SMMU_CMDQS); s->cmdq.prod =3D 0; s->cmdq.cons =3D 0; @@ -310,7 +319,6 @@ static void smmuv3_init_regs(SMMUv3State *s) =20 s->features =3D 0; s->sid_split =3D 0; - s->aidr =3D 0x1; s->cr[0] =3D 0; s->cr0ack =3D 0; s->irq_ctrl =3D 0; @@ -1903,7 +1911,7 @@ static void smmu_reset_exit(Object *obj, ResetType ty= pe) c->parent_phases.exit(obj, type); } =20 - smmuv3_init_regs(s); + smmuv3_reset(s); smmuv3_accel_reset(s); } =20 @@ -1935,6 +1943,7 @@ static void smmu_realize(DeviceState *d, Error **errp) sysbus_init_mmio(dev, &sys->iomem); =20 smmu_init_irq(s, dev); + smmuv3_init_id_regs(s); } =20 static const VMStateDescription vmstate_smmuv3_queue =3D { --=20 2.43.0