From nobody Thu Nov 20 14:02:24 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass(p=none dis=none) header.from=collabora.com ARC-Seal: i=2; a=rsa-sha256; t=1763611745; cv=pass; d=zohomail.com; s=zohoarc; b=krWpRQ515Vq9hhitzXACcFORsc+oRSn9pKMKc7OAfh2jSGXP2SwYA8YkIpL/cvDnLM17dLuI/DOxu/oFdYSIJLcC1uhNVUfXXM89kEJMq+CtnW6TVsVBDCN6EE6HtR7Y/2uvCtVWxLQV1vVpC86Tjanqw9kQnQh7t5yUj7Oz/8s= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763611745; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7C8gRUa8Zzst2hT4+buIpUk9rJ1iYU0M/DjnShh2d/Y=; b=bOvG5Rx4VUKqgzjeNEiCZuFiCP9rle/FU4MurxbB/plULiz6YhEynDX0OmWXVcHDQrny9cc4Ji89hZCWS4IxJxN3Yj3Ucwpovb4pVcZd9uhDRVkRfCLmmk5g3TDkbhyNCF5SZ8uKn39/z4L8LiMqAhxpQi7hwqnGeacOq/iML04= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763611745906195.43042021125393; Wed, 19 Nov 2025 20:09:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLvy2-00016X-Oq; Wed, 19 Nov 2025 23:08:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLvy0-00016G-G8 for qemu-devel@nongnu.org; Wed, 19 Nov 2025 23:08:20 -0500 Received: from sender3-pp-f112.zoho.com ([136.143.184.112]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLvxy-0000Zg-70 for qemu-devel@nongnu.org; Wed, 19 Nov 2025 23:08:19 -0500 Received: by mx.zohomail.com with SMTPS id 1763611680130558.3001669036181; Wed, 19 Nov 2025 20:08:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1763611681; cv=none; d=zohomail.com; s=zohoarc; b=NItcsnjtu9U6/+0fF75VJTVj8qjzjkMYjk8tAdsjnEGYjg7yIt/rnTX9q3uxgtcHAbKYJr0mEWUQ8OBhKom5vGjQwL5SXgpYSAGgW4Mha6b9EtLtubrL9wH8BUzXVDVhIByxHlQu8EYW+9vd0HxA+LPYrLJOMVeCIy6K1nUbiWo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763611681; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=7C8gRUa8Zzst2hT4+buIpUk9rJ1iYU0M/DjnShh2d/Y=; b=NedcQK/4/A2YqmXRAlAQ8X9s4Y6K0cGa6Gibd2iS12PgfS484kBWoYcvuwnLzLGum76HIYYOFG3Vgfz9yT0/tgOC0LpAnT8CWrUC/w48hfRMuoSyNM3nhuFUwxk5OXGRe/g/enKIX6RFFDJDsFT+w2U+2m4ooFWiuvgJ8JOA13I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1763611681; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=7C8gRUa8Zzst2hT4+buIpUk9rJ1iYU0M/DjnShh2d/Y=; b=P1w+mmfSrNSemd3SRd0/NUIOxyfflzXs17ie3DfUqYGOP3OSOKrDIIFYD3wRILnu ERIwasxzZPWi7RzaUEQ7E2bcChBqhI1/y+u3wmv1gWnX/mVdJgWowLP5CKXFuFSDypS eczbJQfTLKKquUyt0KwCdc8P8+dq6QPSXbqIGrsU= From: Dmitry Osipenko To: Akihiko Odaki , Huang Rui , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierre-Eric Pelloux-Prayer , "Michael S . Tsirkin" , Paolo Bonzini , Yiwei Zhang , Sergio Lopez Pascual Cc: Gert Wollny , qemu-devel@nongnu.org, Gurchetan Singh , Alyssa Ross , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xenia Ragiadakou , Honglei Huang , Julia Zhang , Chen Jiqian , Rob Clark , Robert Beckett Subject: [RFC PATCH v3 3/7] virtio-gpu: Make virtio_gpu_virgl_unmap_resource_blob() return -1 on error Date: Thu, 20 Nov 2025 07:06:28 +0300 Message-ID: <20251120040632.4036204-4-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251120040632.4036204-1-dmitry.osipenko@collabora.com> References: <20251120040632.4036204-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=136.143.184.112; envelope-from=dmitry.osipenko@collabora.com; helo=sender3-pp-f112.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com) X-ZM-MESSAGEID: 1763611747666018900 Content-Type: text/plain; charset="utf-8" Make virtio_gpu_virgl_unmap_resource_blob() return -1 for more consistency of error propagation style in the code, adhering to QEMU's devel/style recommendations and preparing code for further code changes utilizing this function. Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index cf1da4b79626..bc22763cc931 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -199,7 +199,7 @@ virtio_gpu_virgl_unmap_resource_blob(VirtIOGPU *g, qemu_log_mask(LOG_GUEST_ERROR, "%s: failed to unmap virgl resource: %s\n", __func__, strerror(-ret)); - return ret; + return -1; } } else { *cmd_suspended =3D true; @@ -333,7 +333,7 @@ static void virgl_cmd_resource_unref(VirtIOGPU *g, } =20 #if VIRGL_VERSION_MAJOR >=3D 1 - if (virtio_gpu_virgl_unmap_resource_blob(g, res, cmd_suspended)) { + if (virtio_gpu_virgl_unmap_resource_blob(g, res, cmd_suspended) < 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } @@ -820,7 +820,7 @@ static void virgl_cmd_resource_unmap_blob(VirtIOGPU *g, } =20 ret =3D virtio_gpu_virgl_unmap_resource_blob(g, res, cmd_suspended); - if (ret) { + if (ret < 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } --=20 2.51.1