From nobody Thu Nov 20 14:02:24 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass(p=none dis=none) header.from=collabora.com ARC-Seal: i=2; a=rsa-sha256; t=1763611792; cv=pass; d=zohomail.com; s=zohoarc; b=AyeURyeGUBLuKEsb7kKh5OCOXNHIzYEeClnkGsf60zPjDn4lEJzbv6RxrxN4ItYAetek+zhAWP9sLXSsoTB+bAF7QCui8fQEPybbm5JNPTQCrkzd3zhXEldZfB1V8tLqf0pDl6RazNDGalSVW7ZBc9aJZ4B9/5h8B54ZRawFYwc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763611792; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MsCw4pL/I4VrkMKJmIf5a0YTUSIlnwbBwzBmQLBozHY=; b=crLRQA42JZ29tecyDlJ3+Aigs9GwEpapF8Q0xyYJQub0WpV7TVETuB4IZ5Mi+2vX3WnKnflo3Z82BS2/N34GhWCW4H1MzKmrYC72l9G294deSYjGeVCdHBYt4Ag45DqsBLWYgVk3UCb2f4wEyQq+09hCXJFpFI00j3dReeCiNfs= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763611792936842.9809252684908; Wed, 19 Nov 2025 20:09:52 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLvxy-00016B-Sd; Wed, 19 Nov 2025 23:08:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLvxu-00014t-5H for qemu-devel@nongnu.org; Wed, 19 Nov 2025 23:08:14 -0500 Received: from sender3-pp-f112.zoho.com ([136.143.184.112]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLvxs-0000ZE-HO for qemu-devel@nongnu.org; Wed, 19 Nov 2025 23:08:13 -0500 Received: by mx.zohomail.com with SMTPS id 1763611674595891.8933152133826; Wed, 19 Nov 2025 20:07:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1763611677; cv=none; d=zohomail.com; s=zohoarc; b=Knu0nXwXP6ucbwVjLhG3pbcVEJP83gMPayRfqq9DL4RlIMdRGeKhcT0FCGjZNYc4eRHH8H4yuq+bbOuoKsRlUy1l5T4rXrRqWG2VC8WZljhw1hrl7jHHDlJwCrTetIX3QbUY5kOlX+KfpMaKBMsmjg1HXcaPiZXFz2egs6ADOY4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763611677; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=MsCw4pL/I4VrkMKJmIf5a0YTUSIlnwbBwzBmQLBozHY=; b=TEPIEuVLIDKE7G6aqsBJFlgXB6iM0wfkicvjbA3hUEyeXX6lSoTb3zMqlEonSZz1RxN1ijVTE5RkZJ0kd4PX8zWvwyZfsZys2PdHPjlWTpNlILzAjapIZrlWrrLIpG3BVccxZEvc2CHI+0bObfryx/tV88RzWWEZDRvw89X+dMA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1763611677; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=MsCw4pL/I4VrkMKJmIf5a0YTUSIlnwbBwzBmQLBozHY=; b=GuNDRgWP6WB/TKRHZ7DJMt+ayCr+tvuteMEvzRjKAFc2xYv4eppOBylhiOYrb6P2 74m2IWCl0B6isdu6BsMK3EZgBaDb1pyVh6MOZRU7L2VGwpF1jRamM0yaGmIOietXHEr p4YS/DYnhwbBjJV2pKw5DB8P94a5ksJR845Olvz0= From: Dmitry Osipenko To: Akihiko Odaki , Huang Rui , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierre-Eric Pelloux-Prayer , "Michael S . Tsirkin" , Paolo Bonzini , Yiwei Zhang , Sergio Lopez Pascual Cc: Gert Wollny , qemu-devel@nongnu.org, Gurchetan Singh , Alyssa Ross , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xenia Ragiadakou , Honglei Huang , Julia Zhang , Chen Jiqian , Rob Clark , Robert Beckett Subject: [RFC PATCH v3 2/7] virtio-gpu: Validate hostmem mapping offset Date: Thu, 20 Nov 2025 07:06:27 +0300 Message-ID: <20251120040632.4036204-3-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251120040632.4036204-1-dmitry.osipenko@collabora.com> References: <20251120040632.4036204-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=136.143.184.112; envelope-from=dmitry.osipenko@collabora.com; helo=sender3-pp-f112.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com) X-ZM-MESSAGEID: 1763611795278019100 Content-Type: text/plain; charset="utf-8" Check hostmem mapping boundaries originated from guest. Suggested-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index a6860f63b563..cf1da4b79626 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -126,6 +126,14 @@ virtio_gpu_virgl_map_resource_blob(VirtIOGPU *g, return -EOPNOTSUPP; } =20 + if (offset + res->base.blob_size > b->conf.hostmem || + offset + res->base.blob_size < offset) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: failed to map virgl resource: invalid offset\n", + __func__); + return -1; + } + ret =3D virgl_renderer_resource_map(res->base.resource_id, &data, &siz= e); if (ret) { qemu_log_mask(LOG_GUEST_ERROR, "%s: failed to map virgl resource: = %s\n", --=20 2.51.1