From nobody Thu Nov 20 14:02:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763557777; cv=none; d=zohomail.com; s=zohoarc; b=b/uUKkXwrWcLtS91bRgu6y3iUUbkq14WnbN5V0Cn25eJj/39A7RmWYIc9n3vvJunULm9a12lqH8wIc2wamnNf7UkF/uMDu50wqG+mP8kMeoZMDCBNCvGCc+etTReLAe4ZwPXebpwYXUWOEpqVfIW2p/YJJLfs1R70Eb/GxIe4Qw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763557777; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Q2/KZiPL6jFf6ZEf6LuTfoZJ9VDQwSYmfYUw5h6FWj8=; b=EbNX+ci31cMGUN+OXwytHzYHVet96fIkUrL+sbdcWjg7vh1sf9aEX5TA1cF6RPWTr5yY0UU1jNly/UEjtqz+qbiIlKHnT4/JosY3xXEjpSEsa+Vhc60gru3qdSgTv1yA+S/FuaeXOylzCOsVUUXbvn5LtajWJK60yoo2QsWoUIU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1763557777799814.244061719636; Wed, 19 Nov 2025 05:09:37 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.1165961.1492639 (Exim 4.92) (envelope-from ) id 1vLhvt-0004Dj-4J; Wed, 19 Nov 2025 13:09:13 +0000 Received: by outflank-mailman (output) from mailman id 1165961.1492639; Wed, 19 Nov 2025 13:09:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLhvs-0004DX-Uu; Wed, 19 Nov 2025 13:09:12 +0000 Received: by outflank-mailman (input) for mailman id 1165961; Wed, 19 Nov 2025 13:09:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vLhvr-0003w5-KG for xen-devel@lists.xenproject.org; Wed, 19 Nov 2025 13:09:11 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ee9c0f27-c548-11f0-980a-7dc792cee155; Wed, 19 Nov 2025 14:09:08 +0100 (CET) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-151-AWehYKanNrqJKV5WNRli2g-1; Wed, 19 Nov 2025 08:09:04 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 664D91956096; Wed, 19 Nov 2025 13:09:00 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.18]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6C6D3195608E; Wed, 19 Nov 2025 13:08:58 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 84D1321E66EF; Wed, 19 Nov 2025 14:08:55 +0100 (CET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee9c0f27-c548-11f0-980a-7dc792cee155 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763557747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q2/KZiPL6jFf6ZEf6LuTfoZJ9VDQwSYmfYUw5h6FWj8=; b=d9jsWNs817ctZjQ2q7OG5AQdAQcwqVhcdYVpF+G+WzI+f42B55AFI6X2oaGbFLYKbxz7lg JywkaTCzc2VHpMhgAY0sPBoRW1BdCSgwXKcoF4HLkpBEk+hNhPKjEUMte4mcJ02mowrhlc lHWSxSZAVHBwM4b0uy1iGjjlX0CqO/U= X-MC-Unique: AWehYKanNrqJKV5WNRli2g-1 X-Mimecast-MFC-AGG-ID: AWehYKanNrqJKV5WNRli2g_1763557741 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, hreitz@redhat.com, mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, gengdongjiu1@gmail.com, peter.maydell@linaro.org, alistair@alistair23.me, edgar.iglesias@gmail.com, npiggin@gmail.com, harshpb@linux.ibm.com, palmer@dabbelt.com, liwei1518@gmail.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, sstabellini@kernel.org, anthony@xenproject.org, paul@xen.org, berrange@redhat.com, peterx@redhat.com, farosas@suse.de, eblake@redhat.com, vsementsov@yandex-team.ru, eduardo@habkost.net, marcel.apfelbaum@gmail.com, philmd@linaro.org, wangyanan55@huawei.com, zhao1.liu@intel.com, qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH 3/5] nbd/client-connection: Replace error_propagate() by assignment Date: Wed, 19 Nov 2025 14:08:53 +0100 Message-ID: <20251119130855.105479-4-armbru@redhat.com> In-Reply-To: <20251119130855.105479-1-armbru@redhat.com> References: <20251119130855.105479-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763557779729158500 Content-Type: text/plain; charset="utf-8" connect_thread_func() sets a variable to null, then error_propagate()s an Error * to it. This is a roundabout way to assign the Error * to it, so replace it by just that. Signed-off-by: Markus Armbruster Reviewed-by: Peter Xu Reviewed-by: Vladimir Sementsov-Ogievskiy --- nbd/client-connection.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/nbd/client-connection.c b/nbd/client-connection.c index 79ea97e4cc..6a4f080717 100644 --- a/nbd/client-connection.c +++ b/nbd/client-connection.c @@ -207,8 +207,7 @@ static void *connect_thread_func(void *opaque) qemu_mutex_lock(&conn->mutex); =20 error_free(conn->err); - conn->err =3D NULL; - error_propagate(&conn->err, local_err); + conn->err =3D local_err; =20 if (ret < 0) { object_unref(OBJECT(conn->sioc)); --=20 2.49.0