From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540841; cv=none; d=zohomail.com; s=zohoarc; b=Y45lODmmHz670bqxphdlKHhi0PeW8yuUNCTOsC28Rg/RM7QUeiR3WZ/5AzIewoZJzXH1oQ22YQY+2DEnr6Oti3BNDE/Eh2IoVO/2W9YsXExs2EZGumUSH8cMbnE0yENA2QuXsZ+wPuaZdZ9F7aJkq43OFx8Ppb5rVFxT5hwPVqA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540841; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V14S+HeYEvntey8lmk5iTwSHICFpzY1PWKL7Iwg6oUM=; b=bPXmqRrT9eiFNUsBD+9+u8QI1qwcCVNg0WaXKShREGHDkeM0/2trwaFEuYDWfiM3CG5Q8dLf53UiZKm9tno0qQlW3id/m6KlmC7U+UPLiS15ZcWt11gGYofxrLGP7FOixEiNDgeXZiaP8RGEGSPzdDH4rNfnwxHJp/1OV5MZ6Sw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540841217380.8977883371174; Wed, 19 Nov 2025 00:27:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdWo-0003BH-B8; Wed, 19 Nov 2025 03:27:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdWm-0003Az-I8 for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdWk-0000tD-Us for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:00 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-FidK8z33PSC3Ap8-oFgglQ-1; Wed, 19 Nov 2025 03:26:54 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E021119560A2; Wed, 19 Nov 2025 08:26:51 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 96A571800451; Wed, 19 Nov 2025 08:26:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V14S+HeYEvntey8lmk5iTwSHICFpzY1PWKL7Iwg6oUM=; b=izfB9IaOIh48hRwWaKkUqf5GEVofLShm6oyoQ1UJ0ohE2O8HhwPAtdkQwuYo6Q/uMmN2mq gHRwrnnNiUv2sSHqSjG4aKzHpyPnO803Rt8qJqrKqi7eK3p5+lsCsO3jiZwsW5QSoHSwDd WqJ8cWus06/l54JRupJiM/CM1Bnowpc= X-MC-Unique: FidK8z33PSC3Ap8-oFgglQ-1 X-Mimecast-MFC-AGG-ID: FidK8z33PSC3Ap8-oFgglQ_1763540812 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 01/15] tests/functional: Add a pylintrc file Date: Wed, 19 Nov 2025 09:26:22 +0100 Message-ID: <20251119082636.43286-2-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540842988158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Add a pylintrc file that can be used for checking the python code of the functional tests. For the beginning, we use some rather lax settings. We still can refine them later if we think that there's a need for it. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/functional/pylintrc | 80 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 81 insertions(+) create mode 100644 tests/functional/pylintrc diff --git a/MAINTAINERS b/MAINTAINERS index 38325e0617c..3d8725b1c9a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4430,6 +4430,7 @@ R: Daniel P. Berrange S: Maintained F: docs/devel/testing/functional.rst F: scripts/clean_functional_cache.py +F: tests/functional/pylintrc F: tests/functional/qemu_test/ =20 Windows Hosted Continuous Integration diff --git a/tests/functional/pylintrc b/tests/functional/pylintrc new file mode 100644 index 00000000000..a396a8ceebd --- /dev/null +++ b/tests/functional/pylintrc @@ -0,0 +1,80 @@ +[DESIGN] + +# Maximum number of arguments for function / method. +max-args=3D9 + +# Maximum number of attributes for a class (see R0902). +max-attributes=3D7 + +# Maximum number of boolean expressions in an if statement (see R0916). +max-bool-expr=3D5 + +# Maximum number of branch for function / method body. +max-branches=3D12 + +# Maximum number of locals for function / method body. +max-locals=3D15 + +# Maximum number of parents for a class (see R0901). +max-parents=3D7 + +# Maximum number of positional arguments for function / method. +max-positional-arguments=3D7 + +# Maximum number of public methods for a class (see R0904). +max-public-methods=3D20 + +# Maximum number of return / yield for function / method body. +max-returns=3D6 + +# Maximum number of statements in function / method body. +max-statements=3D50 + +# Minimum number of public methods for a class (see R0903). +min-public-methods=3D2 + + +[MESSAGES CONTROL] + +# Only show warnings with the listed confidence levels. Leave empty to show +# all. Valid levels: HIGH, CONTROL_FLOW, INFERENCE, INFERENCE_FAILURE, +# UNDEFINED. +confidence=3DHIGH, + CONTROL_FLOW, + INFERENCE, + INFERENCE_FAILURE + +# Disable the message, report, category or checker with the given id(s). Y= ou +# can either give multiple identifiers separated by comma (,) or put this +# option multiple times (only on the command line, not in the configuration +# file where it should appear only once). You can also use "--disable=3Dal= l" to +# disable everything first and then re-enable specific checks. For example= , if +# you want to run only the similarities checker, you can use "--disable=3D= all +# --enable=3Dsimilarities". If you want to run only the classes checker, b= ut have +# no Warning level messages displayed, use "--disable=3Dall --enable=3Dcla= sses +# --disable=3DW". +disable=3Dbad-inline-option, + consider-using-f-string, + file-ignored, + fixme, + import-outside-toplevel, + locally-disabled, + logging-fstring-interpolation, + logging-not-lazy, + missing-function-docstring, + missing-module-docstring, + missing-class-docstring, + raw-checker-failed, + suppressed-message, + too-many-locals, + too-many-statements, + use-implicit-booleaness-not-comparison-to-string, + use-implicit-booleaness-not-comparison-to-zero, + use-symbolic-message-instead, + useless-suppression, + + +[SIMILARITIES] + +# Minimum lines number of a similarity. +min-similarity-lines=3D20 --=20 2.51.1 From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540854; cv=none; d=zohomail.com; s=zohoarc; b=mFBDhPLaHU84IErLI7OcEHjXuGwJYnKiV6qeCv+X04lMangA3jsxTIgCLv+E/VjtfB8d0xeTb4TToNsXyG0EMLaFFtk6XBfb1aLrtMsDuUHFlNzpgnminnpprWTQyVFKPdCrAa5zsCNNDIDDxj30456XWav7o5SD8/ZCJo6dWJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540854; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NcWPRHNJR7mkRQc0F3NU0X0XA84DzFgFUXc+hlU79EA=; b=ZqfkgmHIkTWxbBcWcZ74eM6mbpxYoMQeQp4/y1LPtxCzTgLmD73LIYZP1gSqLQ46i4/ywfVFOp6vgul8HNCpkhrfbkQKJ9KXWUqFIS5y1EhgaBvt2E1Ux4e5IpzEBhC+MlD97CYb/1OvqRfXTIibq2qk8PXJPADAv5FEOisRnko= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540854886483.87263149862474; Wed, 19 Nov 2025 00:27:34 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdX8-0003Fy-K5; Wed, 19 Nov 2025 03:27:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdWx-0003C2-Ov for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdWw-0000tg-50 for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:11 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-j4CBrOiYP_io71NGBjZ02w-1; Wed, 19 Nov 2025 03:27:04 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 91F571956080; Wed, 19 Nov 2025 08:26:58 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 518F51800451; Wed, 19 Nov 2025 08:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NcWPRHNJR7mkRQc0F3NU0X0XA84DzFgFUXc+hlU79EA=; b=g8WU0+nhp+wyUE6/iSzyMtVujlGRBdA2T5hEc8oeqP5jn5PPnlHADQKh5RqAw+gu5PrAL/ dGX/PC29EcdoHovuvmuYyKyu+Udw6bdnF5RrtHX83vdXhqxNHa+7fT+B7tOI8Xn76ZN1mk baTiHTafdGRITNtpJE9sU3dYh3cb/b8= X-MC-Unique: j4CBrOiYP_io71NGBjZ02w-1 X-Mimecast-MFC-AGG-ID: j4CBrOiYP_io71NGBjZ02w_1763540819 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 02/15] tests/functional/riscv64/test_sifive_u: Remove unused import statement Date: Wed, 19 Nov 2025 09:26:23 +0100 Message-ID: <20251119082636.43286-3-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540856744158500 From: Thomas Huth skipIfMissingCommands is not used here, remove the import to silence a pylint warning for this file. Reviewed-by: Nutty Liu Reviewed-by: Daniel Henrique Barboza Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Thomas Huth Message-ID: <20251027112803.54564-1-thuth@redhat.com> --- tests/functional/riscv64/test_sifive_u.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/functional/riscv64/test_sifive_u.py b/tests/functional/r= iscv64/test_sifive_u.py index 358ff0d1f60..847f709da12 100755 --- a/tests/functional/riscv64/test_sifive_u.py +++ b/tests/functional/riscv64/test_sifive_u.py @@ -13,7 +13,6 @@ import os =20 from qemu_test import Asset, LinuxKernelTest -from qemu_test import skipIfMissingCommands =20 =20 class SifiveU(LinuxKernelTest): --=20 2.51.1 From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540883; cv=none; d=zohomail.com; s=zohoarc; b=jWNquECZM98rt8BBFlfjl3bAvAg7Ji78bR8gFIAG2KOBbIkuNliNxO88XZsfnIBcdy/Sf1DkX1ALnw1V0dMzbn8cKui0X5dLrI422AbJaj8ZRPx+78zpkFneSx9JG2eOxec93pPFwnjv+6koIcamEG/D+sIBGijeYrVAzcmFemQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540883; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ILJj5HtA0d+6QI4dslPgn4+dCqIwzHYnHyjqRqvseb0=; b=CoumC2whslegnl4pUcv3PbDxFAELebo5k1pbUxtWNMDk6/sbnloB8EDRzdcOC1Y3ji2OIeq6sDZHdm/HyygrDA1WPogw+MV7wHFJfU3Vr+3kytwGtdWocj9NFpSaAHUPi5hRsIooxVNIwPjyBE/LTkHfAhkplPZMuwWAp37hiZ8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540883073802.5884541004428; Wed, 19 Nov 2025 00:28:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdXA-0003Ib-4k; Wed, 19 Nov 2025 03:27:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdX2-0003CK-OS for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:16 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdX0-0000ts-TI for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:16 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-rY3a-B8nPle33QhQJp6qBQ-1; Wed, 19 Nov 2025 03:27:08 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 28CDC19560B3; Wed, 19 Nov 2025 08:27:05 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1BDD7180049F; Wed, 19 Nov 2025 08:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ILJj5HtA0d+6QI4dslPgn4+dCqIwzHYnHyjqRqvseb0=; b=b9sh7f+4YwqdMuMpyFGEEDyONwZip8FE1Bf4gzHWIOBgPtsagWJjUJG2d1fv2A1cNei1ce x0SLp6qW77INbPx37zYSe8M7c2nS/QSRHkvjNIN2k2ChCkJdng1CjcEJXY2DRypsarGUfR NL+Q4weuNcYD5zUsDE4conWBPqgGeeQ= X-MC-Unique: rY3a-B8nPle33QhQJp6qBQ-1 X-Mimecast-MFC-AGG-ID: rY3a-B8nPle33QhQJp6qBQ_1763540825 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 03/15] tests/functional/arm/test_aspeed_ast2600_buildroot: Fix pylint warnings Date: Wed, 19 Nov 2025 09:26:24 +0100 Message-ID: <20251119082636.43286-4-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540884947158500 From: Thomas Huth Pylint recommends to use a "with" context for tempfile.TemporaryDirectory() to make sure that the directory is deleted once it is not needed anymore, and it recommends to use the "check" parameter for subprocess.run(). For style reasons, the imports at the beginning of the file should be grouped by module. Message-Id: <20251113100601.476900-1-thuth@redhat.com> Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: Thomas Huth --- .../arm/test_aspeed_ast2600_buildroot.py | 21 +++++++++++-------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/tests/functional/arm/test_aspeed_ast2600_buildroot.py b/tests/= functional/arm/test_aspeed_ast2600_buildroot.py index 51f2676c906..575a5f64143 100755 --- a/tests/functional/arm/test_aspeed_ast2600_buildroot.py +++ b/tests/functional/arm/test_aspeed_ast2600_buildroot.py @@ -9,8 +9,8 @@ import tempfile import subprocess =20 -from qemu_test import Asset from aspeed import AspeedTest +from qemu_test import Asset from qemu_test import exec_command_and_wait_for_pattern, skipIfMissingComm= ands =20 =20 @@ -66,21 +66,18 @@ def test_arm_ast2600_evb_buildroot(self): 'images/ast2600-evb/buildroot-2023.02-tpm/flash.img'), 'a46009ae8a5403a0826d607215e731a8c68d27c14c41e55331706b8f9c7bd997') =20 - @skipIfMissingCommands('swtpm') - def test_arm_ast2600_evb_buildroot_tpm(self): - self.set_machine('ast2600-evb') - + def _test_arm_ast2600_evb_buildroot_tpm(self, tpmstate_dir): image_path =3D self.ASSET_BR2_202302_AST2600_TPM_FLASH.fetch() =20 - tpmstate_dir =3D tempfile.TemporaryDirectory(prefix=3D"qemu_") - socket =3D os.path.join(tpmstate_dir.name, 'swtpm-socket') + socket =3D os.path.join(tpmstate_dir, 'swtpm-socket') =20 # We must put the TPM state dir in /tmp/, not the build dir, # because some distros use AppArmor to lock down swtpm and # restrict the set of locations it can access files in. subprocess.run(['swtpm', 'socket', '-d', '--tpm2', - '--tpmstate', f'dir=3D{tpmstate_dir.name}', - '--ctrl', f'type=3Dunixio,path=3D{socket}']) + '--tpmstate', f'dir=3D{tpmstate_dir}', + '--ctrl', f'type=3Dunixio,path=3D{socket}'], + check=3DTrue) =20 self.vm.add_args('-chardev', f'socket,id=3Dchrtpm,path=3D{socket}') self.vm.add_args('-tpmdev', 'emulator,id=3Dtpm0,chardev=3Dchrtpm') @@ -97,6 +94,12 @@ def test_arm_ast2600_evb_buildroot_tpm(self): =20 self.do_test_arm_aspeed_buildroot_poweroff() =20 + @skipIfMissingCommands('swtpm') + def test_arm_ast2600_evb_buildroot_tpm(self): + self.set_machine('ast2600-evb') + with tempfile.TemporaryDirectory(prefix=3D"qemu_") as tpmstate_dir: + self._test_arm_ast2600_evb_buildroot_tpm(tpmstate_dir) + =20 if __name__ =3D=3D '__main__': AspeedTest.main() --=20 2.51.1 From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540880; cv=none; d=zohomail.com; s=zohoarc; b=UwARhWn5RdFUvc7LEeyV2Wcp/xaMBAfUgTgTMRle5SswjCCpsZ8QBYUV/TynROYzjelRF7ckvSCleID7c8cZK0RMNMfI6PkMoOzkZ2B5VgcJxpUoCnppF8+yRTcxqpsuF3vI0xDwKBuV5aSPhL4aGcsU7AlpHM0ACgEF8OwsR0A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540880; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+q3mVibePYLUik1mVn4Fz+mDEP/c6DtcHtf4f9LUDRw=; b=N7EpMZbDmgID6nDFw8UX7I9EKeNb9LmQxVBrjR0jI/rNMurSKH784/uqUXf0/YRo0HsEJofItxNJZKx9ZDnRHsyKIP7tfFDndkMtspM1WczUdQkT/p42wDPYNrCDZ8xR+Jl/c+820Cnl8nVrIIgwEofJfleE8ndro4HxsJTNI+M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540880944734.7921370262783; Wed, 19 Nov 2025 00:28:00 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdXB-0003JR-8c; Wed, 19 Nov 2025 03:27:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdX7-0003Ff-Fd for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdX5-0000uP-KP for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:21 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-2-bBmgug75OuKRzpzfjvhSaQ-1; Wed, 19 Nov 2025 03:27:14 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0FAEF18AB428; Wed, 19 Nov 2025 08:27:11 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8F313180047F; Wed, 19 Nov 2025 08:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+q3mVibePYLUik1mVn4Fz+mDEP/c6DtcHtf4f9LUDRw=; b=g9N8XNkszY2JeN/ijBBAzepyZUnewYQ1v7rcl5srFqUCHz6dJ9qL0SkwGctaHW8nYO1+2I ZkI+E4mYP38saMcvA6MPcU18dpL3tfTAAzlouLCpan2WOBpAZK97VLL2C1kO8DeP+SPz6+ 66/CWjmscoazoP+RmS1vtCXW//fGgLM= X-MC-Unique: bBmgug75OuKRzpzfjvhSaQ-1 X-Mimecast-MFC-AGG-ID: bBmgug75OuKRzpzfjvhSaQ_1763540831 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 04/15] tests/functional/x86_64/test_virtio_gpu: Fix various issues reported by pylint Date: Wed, 19 Nov 2025 09:26:25 +0100 Message-ID: <20251119082636.43286-5-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540882651153000 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Use the recommended order for import statements, specify the kind of exceptions that we try to catch, use f-strings where it makes sense, rewrite the vug_log_file part with a proper "with" statement and fix some FIXMEs by checking for the availability of the devices, etc. Message-Id: <20251113114015.490303-1-thuth@redhat.com> Reviewed-by: Akihiko Odaki Signed-off-by: Thomas Huth --- tests/functional/x86_64/test_virtio_gpu.py | 56 +++++++++++----------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/tests/functional/x86_64/test_virtio_gpu.py b/tests/functional/= x86_64/test_virtio_gpu.py index be96de24da2..58b0f72ba42 100755 --- a/tests/functional/x86_64/test_virtio_gpu.py +++ b/tests/functional/x86_64/test_virtio_gpu.py @@ -5,22 +5,23 @@ # This work is licensed under the terms of the GNU GPL, version 2 or # later. See the COPYING file in the top-level directory. =20 +import os +import socket +import subprocess =20 from qemu_test import QemuSystemTest, Asset from qemu_test import wait_for_console_pattern from qemu_test import exec_command_and_wait_for_pattern from qemu_test import is_readable_executable_file =20 - -import os -import socket -import subprocess +from qemu.machine.machine import VMLaunchFailure =20 =20 def pick_default_vug_bin(test): bld_dir_path =3D test.build_file("contrib", "vhost-user-gpu", "vhost-u= ser-gpu") if is_readable_executable_file(bld_dir_path): return bld_dir_path + return None =20 =20 class VirtioGPUx86(QemuSystemTest): @@ -46,8 +47,8 @@ def wait_for_console_pattern(self, success_message, vm=3D= None): ) =20 def test_virtio_vga_virgl(self): - # FIXME: should check presence of virtio, virgl etc self.require_accelerator('kvm') + self.require_device('virtio-vga-gl') =20 kernel_path =3D self.ASSET_KERNEL.fetch() initrd_path =3D self.ASSET_INITRD.fetch() @@ -68,7 +69,7 @@ def test_virtio_vga_virgl(self): ) try: self.vm.launch() - except: + except VMLaunchFailure: # TODO: probably fails because we are missing the VirGL featur= es self.skipTest("VirGL not enabled?") =20 @@ -78,8 +79,8 @@ def test_virtio_vga_virgl(self): ) =20 def test_vhost_user_vga_virgl(self): - # FIXME: should check presence of vhost-user-gpu, virgl, memfd etc self.require_accelerator('kvm') + self.require_device('vhost-user-vga') =20 vug =3D pick_default_vug_bin(self) if not vug: @@ -95,27 +96,29 @@ def test_vhost_user_vga_virgl(self): os.set_inheritable(qemu_sock.fileno(), True) os.set_inheritable(vug_sock.fileno(), True) =20 - self._vug_log_path =3D self.log_file("vhost-user-gpu.log") - self._vug_log_file =3D open(self._vug_log_path, "wb") - self.log.info('Complete vhost-user-gpu.log file can be ' - 'found at %s', self._vug_log_path) - - vugp =3D subprocess.Popen( - [vug, "--virgl", "--fd=3D%d" % vug_sock.fileno()], - stdin=3Dsubprocess.DEVNULL, - stdout=3Dself._vug_log_file, - stderr=3Dsubprocess.STDOUT, - shell=3DFalse, - close_fds=3DFalse, - ) - self._vug_log_file.close() - + vug_log_path =3D self.log_file("vhost-user-gpu.log") + self.log.info('Complete vhost-user-gpu.log file can be found at %s= ', + vug_log_path) + with open(vug_log_path, "wb") as vug_log_file: + with subprocess.Popen([vug, "--virgl", f"--fd=3D{vug_sock.file= no()}"], + stdin=3Dsubprocess.DEVNULL, + stdout=3Dvug_log_file, + stderr=3Dsubprocess.STDOUT, + shell=3DFalse, + close_fds=3DFalse) as vugp: + self._test_vhost_user_vga_virgl(qemu_sock, + kernel_path, initrd_path) + qemu_sock.close() + vug_sock.close() + vugp.terminate() + + def _test_vhost_user_vga_virgl(self, qemu_sock, kernel_path, initrd_pa= th): self.vm.set_console() self.vm.add_args("-cpu", "host") self.vm.add_args("-m", "2G") self.vm.add_args("-object", "memory-backend-memfd,id=3Dmem,size=3D= 2G") self.vm.add_args("-machine", "pc,memory-backend=3Dmem,accel=3Dkvm") - self.vm.add_args("-chardev", "socket,id=3Dvug,fd=3D%d" % qemu_sock= .fileno()) + self.vm.add_args("-chardev", f"socket,id=3Dvug,fd=3D{qemu_sock.fil= eno()}") self.vm.add_args("-device", "vhost-user-vga,chardev=3Dvug") self.vm.add_args("-display", "egl-headless") self.vm.add_args( @@ -128,17 +131,14 @@ def test_vhost_user_vga_virgl(self): ) try: self.vm.launch() - except: + except VMLaunchFailure: # TODO: probably fails because we are missing the VirGL featur= es self.skipTest("VirGL not enabled?") self.wait_for_console_pattern("as init process") exec_command_and_wait_for_pattern(self, "/usr/sbin/modprobe virtio= _gpu", "features: +virgl +edid") self.vm.shutdown() - qemu_sock.close() - vug_sock.close() - vugp.terminate() - vugp.wait() + =20 if __name__ =3D=3D '__main__': QemuSystemTest.main() --=20 2.51.1 From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540880; cv=none; d=zohomail.com; s=zohoarc; b=dv9GS6x48TqsIYkLO+FLQRpO/xwa2m3dvi8rcY6xK6i868p5Yfr/oQuQ+gmPfqu087baDR06aBZ+fv2ddteXedzY6RKBVIzGtXCZwzbUdyHNaHIqIsiEvKhOnaYJefS7hLcpSRUci79xJtRhowWHEde8GJT9xyr5exD8ahm2aBs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540880; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=t4GcUnoIyZ+LL6Ta/Y18RsAa9Jh6fIjMoXBZOp9WQbE=; b=akKZM9JYNSyRfztl2hwtH150XJOc3XCcuw46RzNAmSKDqs/yLMkAXdYFnXC/S6y3OH0eRxZYBQYCoyyjTfK0GRZ/rv8idcazaK5c50iA9TiuH5ZwDEaa2BaZbBYyH77vtxpZfES7OG2ejCrs+4hsVmmxBwDmzVogf9iv9ZxqiM0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540880978170.69781127568865; Wed, 19 Nov 2025 00:28:00 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdXT-0003Ko-Gd; Wed, 19 Nov 2025 03:27:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXC-0003KB-Nf for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXB-0000um-3T for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:26 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-E71NsKNdPTOyPs_RNj2iVg-1; Wed, 19 Nov 2025 03:27:20 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 499E31800473; Wed, 19 Nov 2025 08:27:17 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 757EA180049F; Wed, 19 Nov 2025 08:27:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t4GcUnoIyZ+LL6Ta/Y18RsAa9Jh6fIjMoXBZOp9WQbE=; b=Go+DTBXC6dVZNp19J2iDkPxZSb02wQiJSTgWoPsqdTWMsqqL7GZsnuEjkE1VX1o1dqzCUj q1qXEg/8J5HEEzcPq1t+LswUgUmCVtkssaqRQ75PfTPZkk6UdeyJvfGvzsn5pEfLjQx+TG d+2MsYOM1sqokMvIo+IHIvRFLpNXy1I= X-MC-Unique: E71NsKNdPTOyPs_RNj2iVg-1 X-Mimecast-MFC-AGG-ID: E71NsKNdPTOyPs_RNj2iVg_1763540838 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 05/15] tests/functional/mips/test_malta: Silence warnings reported by pylint Date: Wed, 19 Nov 2025 09:26:26 +0100 Message-ID: <20251119082636.43286-6-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540882616153000 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Pylint complains about too many positional arguments for the mips_check_wheezy() function. Add a "*" to enforce that the later ones are passed with an argument name (all calling sites are doing this already). Also turn some old-school format strings into proper f-strings now. Signed-off-by: Thomas Huth --- tests/functional/mips/test_malta.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/functional/mips/test_malta.py b/tests/functional/mips/te= st_malta.py index 7a734bc069b..e8f49f130be 100755 --- a/tests/functional/mips/test_malta.py +++ b/tests/functional/mips/test_malta.py @@ -50,7 +50,7 @@ def mips_run_common_commands(test, prompt=3D'#'): ' : ata_piix') wait_for_console_pattern(test, prompt) =20 -def mips_check_wheezy(test, kernel_path, image_path, kernel_command_line, +def mips_check_wheezy(test, kernel_path, image_path, kernel_command_line, = *, dl_file, hsum, nic=3D'pcnet', cpuinfo=3D'MIPS 24Kc'): test.require_netdev('user') test.require_device(nic) @@ -59,10 +59,10 @@ def mips_check_wheezy(test, kernel_path, image_path, ke= rnel_command_line, port=3D8080 test.vm.add_args('-kernel', kernel_path, '-append', kernel_command_line, - '-drive', 'file=3D%s,snapshot=3Don' % image_path, + '-drive', f'file=3D{image_path},snapshot=3Don', '-netdev', 'user,id=3Dn1' + ',tftp=3D' + os.path.basename(kernel_path)= + - ',hostfwd=3Dtcp:127.0.0.1:0-:%d' % port, + f',hostfwd=3Dtcp:127.0.0.1:0-:{port}', '-device', f'{nic},netdev=3Dn1', '-no-reboot') test.vm.set_console() @@ -111,7 +111,7 @@ def test_mips_malta(self): self.vm.add_args('-kernel', kernel_path, '-append', kernel_command_line) self.vm.launch() - console_pattern =3D 'Kernel command line: %s' % kernel_command_line + console_pattern =3D f'Kernel command line: {kernel_command_line}' self.wait_for_console_pattern(console_pattern) =20 ASSET_KERNEL_4_5_0 =3D Asset( --=20 2.51.1 From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540903; cv=none; d=zohomail.com; s=zohoarc; b=m5BdzwP+GqR+vNvtibG86Ix7fbXdQ/24er+CdlnH9BBtl0G0y9+tpzWUYrXN26FN/yIfj17JzVSOU9WcAAtxp+vLDKKCHl7cIFJroNrvrwxQB1SCbyJmP02qzaFfgnV5c5H1tgNVYM16po75JApoObCsqbeBjAibIBi8AU9nnYE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540903; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TKH8JzV0HsTyowkmfXKDxl1PvhzoYQBZm0t+mg6hM08=; b=RadhrKcmo/f7JlzRV4ReBJOENAStHmZsmlTapI/mN8x+ckSscy1XXHQ3Xt6pik1QTESaVkcyOZfFiV/MuyEOR9DGr/EbV/ml/zZ8nXbyOXgslFNldDV3yuqViq016GT7Gf8rKn6o6wd2/ZMAyfW5dTfBWR57EEiwvaYysG7BNdk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540903047708.7853395075357; Wed, 19 Nov 2025 00:28:23 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdXt-0003oh-OG; Wed, 19 Nov 2025 03:28:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXK-0003Lc-2Q for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:36 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXI-0000vG-3d for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:33 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-497-8hGYOz8GPAWMJpoHbfSn_g-1; Wed, 19 Nov 2025 03:27:26 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F09AF1956070; Wed, 19 Nov 2025 08:27:23 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DAF17180047F; Wed, 19 Nov 2025 08:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TKH8JzV0HsTyowkmfXKDxl1PvhzoYQBZm0t+mg6hM08=; b=Z3YBoEH76thgVJHIuAJaBGsLNf4wrJ+7Cwjtp537uqSsascmjDSm96UfRcc6BA74C19O/s GazjUk41MzzNXaORDZ1UAhZvs282wLVZODjC70exCTljYcQ47dMf6GaydVlCJe1aLIUFVc uqHpOEYOWWqdUWCm6SN4RJpDAYyF+Zk= X-MC-Unique: 8hGYOz8GPAWMJpoHbfSn_g-1 X-Mimecast-MFC-AGG-ID: 8hGYOz8GPAWMJpoHbfSn_g_1763540844 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 06/15] tests/functional/ppc64/test_hv: Silence warnings reported by pylint Date: Wed, 19 Nov 2025 09:26:27 +0100 Message-ID: <20251119082636.43286-7-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540905044158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth To make pylint happy here, remove unused variables, switch to f-string, use "check=3DTrue" when calling subprocess.run() and split a line that was too long. Signed-off-by: Thomas Huth --- tests/functional/ppc64/test_hv.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/functional/ppc64/test_hv.py b/tests/functional/ppc64/tes= t_hv.py index d87f440fa79..beec1dbbea3 100755 --- a/tests/functional/ppc64/test_hv.py +++ b/tests/functional/ppc64/test_hv.py @@ -29,8 +29,6 @@ @skipBigDataTest() class HypervisorTest(QemuSystemTest): =20 - timeout =3D 1000 - KERNEL_COMMON_COMMAND_LINE =3D 'printk.time=3D0 console=3Dhvc0 ' panic_message =3D 'Kernel panic - not syncing' good_message =3D 'VFS: Cannot open root device' =20 @@ -49,8 +47,8 @@ def extract_from_iso(self, iso, path): """ filename =3D self.scratch_file(os.path.basename(path)) =20 - cmd =3D "xorriso -osirrox on -indev %s -cpx %s %s" % (iso, path, f= ilename) - subprocess.run(cmd.split(), + cmd =3D f"xorriso -osirrox on -indev {iso} -cpx {path} {filename}" + subprocess.run(cmd.split(), check=3DTrue, stdout=3Dsubprocess.DEVNULL, stderr=3Dsubprocess.DE= VNULL) =20 os.chmod(filename, 0o600) @@ -66,7 +64,6 @@ def setUp(self): =20 def do_start_alpine(self): self.vm.set_console() - kernel_command_line =3D self.KERNEL_COMMON_COMMAND_LINE self.vm.add_args("-kernel", self.vmlinuz) self.vm.add_args("-initrd", self.initramfs) self.vm.add_args("-smp", "4", "-m", "2g") @@ -78,7 +75,8 @@ def do_start_alpine(self): wait_for_console_pattern(self, 'localhost login:') exec_command_and_wait_for_pattern(self, 'root', ps1) # If the time is wrong, SSL certificates can fail. - exec_command_and_wait_for_pattern(self, 'date -s "' + datetime.utc= now().strftime('%Y-%m-%d %H:%M:%S' + '"'), ps1) + cmd=3D'date -s "' + datetime.utcnow().strftime('%Y-%m-%d %H:%M:%S'= + '"') + exec_command_and_wait_for_pattern(self, cmd, ps1) ps1=3D'alpine:~#' exec_command_and_wait_for_pattern(self, 'setup-alpine -qe', ps1) exec_command_and_wait_for_pattern(self, 'setup-apkrepos -c1', ps1) --=20 2.51.1 From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540892; cv=none; d=zohomail.com; s=zohoarc; b=QT8Y9luRiAPLZmAr2jrylc7bi4Mw4tlY7E4KdE1GN8Z64aaROpvYBaHcwbH/Z28T3BW+p8QuhrR9JqCau3RLK1+ftffbMA+oST9zqB1jyejxBSLqUA2MTFhdZ8c8zd5xu82Ph5n95Yi+OxZY2UMzftZxeg1UdYQoPbqFSTqe0s8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540892; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tCEkus+h9lXfmQA4I51lHETlrtGDKqFBVzfzpVcYvUE=; b=bgGQotzx0zZGW2SJNS+2arC/B1V2G1YzGS9xBBsXQHXGYgYaQo91Fz6n7YrL+nbbdWstKWLyt2c2BUCmF9she9IOJZRD16kq2VdgvVdsyuykUI8zNxJfaCn+x5paTQW9/T1IBS98U1kVpQtGmINyZwW6/jpAzWLe+rqUdrsr0cc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540892975277.1805887206997; Wed, 19 Nov 2025 00:28:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdXs-0003nK-VU; Wed, 19 Nov 2025 03:28:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXO-0003NR-P4 for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXM-0000vS-G7 for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:37 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-401-eAgL-BilPTuYR60ETvWszw-1; Wed, 19 Nov 2025 03:27:32 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AA8CB18D95D1; Wed, 19 Nov 2025 08:27:29 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5EEE9180047F; Wed, 19 Nov 2025 08:27:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tCEkus+h9lXfmQA4I51lHETlrtGDKqFBVzfzpVcYvUE=; b=gzuT/yQCacFyQwpPUK0JtSaGQ08RYpEHtcb7Zsf7/Yux4mgKwfZVsaXkLQdLSL57/fRKv1 /jHkF/ZsnqvHMrwQ/HAhxeGMvd7L3pQ3Z/ZMb1AZFLorGcgQc7Fumy7NmTblJyPkFpd+Tx h0iehDlomAEwloeJgCTx1MQDoVD2ies= X-MC-Unique: eAgL-BilPTuYR60ETvWszw-1 X-Mimecast-MFC-AGG-ID: eAgL-BilPTuYR60ETvWszw_1763540850 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 07/15] tests/functional/x86_64/test_reverse_debug: Silence pylint warning Date: Wed, 19 Nov 2025 09:26:28 +0100 Message-ID: <20251119082636.43286-8-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540894671153000 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Pylint does not like the underscores in the class name here, so rename the class accordingly to make pylint happy here. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/functional/x86_64/test_reverse_debug.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/x86_64/test_reverse_debug.py b/tests/function= al/x86_64/test_reverse_debug.py index 2b31ae87243..ab5dac98386 100755 --- a/tests/functional/x86_64/test_reverse_debug.py +++ b/tests/functional/x86_64/test_reverse_debug.py @@ -18,7 +18,7 @@ from reverse_debugging import ReverseDebugging =20 =20 -class ReverseDebugging_X86_64(ReverseDebugging): +class ReverseDebuggingX86(ReverseDebugging): =20 @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/2922") def test_x86_64_pc(self): --=20 2.51.1 From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540931; cv=none; d=zohomail.com; s=zohoarc; b=Usm7VbUqCYJ/vQMtBf5SMKnKn4/K+Mdi5FhT0Wks2+fAz+mo6o3QFw6P2rgJAekH74v7ibgGGJhsnktkbv2dsyZ47pLwd+TMPy5FSQ4np2X4KJMAg1cG/WUDgCKTIrWT2BIU+mkIf8eqUEO2hdZFW5T4wl24snSORxXMgypVDbw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540931; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VClsjSE/lJj44/MxOnS27ywXz1EbQ0juDDgmS3m/32I=; b=dcqgQcEO0vx3a087su3HmDzIPDqWtZq0ioKXubHpTmvP+gttQ7tc1LTT8e+1gc2V2mPZ70tlYoJUfMlhhsvXFLuDhOI0kRo65rxYagiu3JfK0voeS67g0uiv2940e1fSK1IuPJhCsS9X2KkjWwG6Mdd77zE+5p/NLJHZQmXizLM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540931985162.33459191238694; Wed, 19 Nov 2025 00:28:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdXv-0003wm-5s; Wed, 19 Nov 2025 03:28:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXX-0003XT-Hm for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXV-0000vu-7L for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:47 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-Hw4_cOfwMQyYAlofR4P9Gg-1; Wed, 19 Nov 2025 03:27:37 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7491B18AB400; Wed, 19 Nov 2025 08:27:35 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1D050180047F; Wed, 19 Nov 2025 08:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VClsjSE/lJj44/MxOnS27ywXz1EbQ0juDDgmS3m/32I=; b=ifI+/bUQKH2CDRggVeg+QIaAQH82bKIX19ayMRHIeWITsOPPDF/dpPgsg0LqIsxUglAGmt DmFxh82AwclDDHtNlLArVlTtaWvKZxuCq8xehOmvtB7G8DYYWX/j6+WMJZu1HmXaOOcwvE p73OmWtSxIh0qsrx9zPamtSToDt2CIM= X-MC-Unique: Hw4_cOfwMQyYAlofR4P9Gg-1 X-Mimecast-MFC-AGG-ID: Hw4_cOfwMQyYAlofR4P9Gg_1763540855 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 08/15] tests/functional/x86_64/test_memlock: Silence pylint warnings Date: Wed, 19 Nov 2025 09:26:29 +0100 Message-ID: <20251119082636.43286-9-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540932954158501 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Pylint complains about a missing "encoding" parameter for the open() function here, and about a missing return statement in the "except" block (which cannot happen since skipTest() never returns). Rework the code a little bit to silence the warnings. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/functional/x86_64/test_memlock.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/functional/x86_64/test_memlock.py b/tests/functional/x86= _64/test_memlock.py index 81bce80b0c4..f970a2c3095 100755 --- a/tests/functional/x86_64/test_memlock.py +++ b/tests/functional/x86_64/test_memlock.py @@ -69,11 +69,13 @@ def get_process_status_values(self, pid: int) -> Dict[s= tr, int]: return result =20 def _get_raw_process_status(self, pid: int) -> str: + status =3D None try: - with open(f'/proc/{pid}/status', 'r') as f: - return f.read() + with open(f'/proc/{pid}/status', 'r', encoding=3D"ascii") as f: + status =3D f.read() except FileNotFoundError: self.skipTest("Can't open status file of the process") + return status =20 =20 if __name__ =3D=3D '__main__': --=20 2.51.1 From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540925; cv=none; d=zohomail.com; s=zohoarc; b=N0XYxugyteA7uMtUIf0C9aIEaopiK3q4pJ/WCR8rBqPCfVtazm9cGZnXkJi6A6oV+PyvygMQqF9/IeLEimfKQmTQ9AOMtdKBNB7vGiZKCPu4jaLQ4meqM2AE7cf+GD8sebGHg5+x7glGHTDe59DDsNCxtVwMtddiHqXPZUIZ1eM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540925; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9eYpbHkbboeqGDjLjd0tKacdsmgmhRfnYu1bcQyCJsY=; b=i5aAa+hI93z9BuhS3E8hfkHQI22h5nWMQpfvCL3O6qnDZSlOaT6MGi9eYG9SUaqV231Ml3T8tvZbNwHvDvj7XhyVUwo87hN6JL7QWYv2Tdtb08ZbX4sPr/1I/6S8gL//zjy7/jcaZ5jBtHia/lGvYIeQU3hsQG0Ve35E3UCkP0E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540925370747.3728937104906; Wed, 19 Nov 2025 00:28:45 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdXz-00049E-73; Wed, 19 Nov 2025 03:28:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXa-0003ap-Bm for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXY-0000wA-8h for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:49 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-110-CZmYnqPzOJSR-8pE5FiUqg-1; Wed, 19 Nov 2025 03:27:44 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 514CA18AB410; Wed, 19 Nov 2025 08:27:41 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DBF79180049F; Wed, 19 Nov 2025 08:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9eYpbHkbboeqGDjLjd0tKacdsmgmhRfnYu1bcQyCJsY=; b=WOc+B7DktWw50eLNIQI9x+8tGgWhWtna6X1MQUYp6An4jmR8AOzrMtcEYSJHqvXjUkRUYf m/k6wGnm4tNOnEnsRwfTbLW9RPzdXUUu5k2Tt8uFjJYc5+U4HnMq33x/OnuCQJtEkkxQX4 5q+B2bbrn02bvEa3gWrQdhnjd9Po9HI= X-MC-Unique: CZmYnqPzOJSR-8pE5FiUqg-1 X-Mimecast-MFC-AGG-ID: CZmYnqPzOJSR-8pE5FiUqg_1763540861 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 09/15] tests/functional/ppc/test_amiga: Fix issues reported by pylint and flake8 Date: Wed, 19 Nov 2025 09:26:30 +0100 Message-ID: <20251119082636.43286-10-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540926871158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Pylint complains about unused variable "tar_name" and a missing "check" for subprocess.run(), and flake8 suggest a second empty line after the class. While we're at it, also remove the unused "timeout" class variable (that was only necessary for the avocado framework which we don't use anymore). Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/functional/ppc/test_amiga.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/functional/ppc/test_amiga.py b/tests/functional/ppc/test= _amiga.py index 8600e2e9633..36378fb6972 100755 --- a/tests/functional/ppc/test_amiga.py +++ b/tests/functional/ppc/test_amiga.py @@ -15,8 +15,6 @@ =20 class AmigaOneMachine(QemuSystemTest): =20 - timeout =3D 90 - ASSET_IMAGE =3D Asset( ('https://www.hyperion-entertainment.com/index.php/' 'downloads?view=3Ddownload&format=3Draw&file=3D25'), @@ -25,19 +23,19 @@ class AmigaOneMachine(QemuSystemTest): def test_ppc_amigaone(self): self.require_accelerator("tcg") self.set_machine('amigaone') - tar_name =3D 'A1Firmware_Floppy_05-Mar-2005.zip' self.archive_extract(self.ASSET_IMAGE, format=3D"zip") bios =3D self.scratch_file("u-boot-amigaone.bin") with open(bios, "wb") as bios_fh: subprocess.run(['tail', '-c', '524288', self.scratch_file("floppy_edition", "updater.image")], - stdout=3Dbios_fh) + stdout=3Dbios_fh, check=3DTrue) =20 self.vm.set_console() self.vm.add_args('-bios', bios) self.vm.launch() wait_for_console_pattern(self, 'FLASH:') =20 + if __name__ =3D=3D '__main__': QemuSystemTest.main() --=20 2.51.1 From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540908; cv=none; d=zohomail.com; s=zohoarc; b=kcqEVHqcmOm7uEk9y9rs+bcM7XsDDqKmwr4PSP9zfOi1Lbh9aErBx6xUzP5ptw6xIRkER2ObzcutQ2WoM7ohXhDPo2hxrpfonFikIZUPMJbjL99+AaY8VvBCrO7Hcq9sFEvJpRybLZboPDB+ngritjx0sb694tGkgiOgiyJ2D10= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540908; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Re4yiaiH5D2dM2qpTganIASvqSQt9Utb2xjF3Jrx0cc=; b=Xiv1JcnyChIyC6nctB6sb72vV9EEfDhkEmwsOWXkPXXX500pGr2/E7O7zAZIUtsVQUTY0yf37Os3g6ehaN6gTGjl9S22YqzDv8M+VgZ++rPlv8zUrbu0zth1FWsdr8+CfOeWFadeeRw1dNpnw8MLVEfA7KAO4gJqQssWmTzrlmk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540908714910.1041984669561; Wed, 19 Nov 2025 00:28:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdY2-0004Km-SS; Wed, 19 Nov 2025 03:28:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXh-0003iF-DX for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:28:01 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXe-0000wU-0N for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:27:55 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-T46KxYwGMHiStBHaAyuDGw-1; Wed, 19 Nov 2025 03:27:49 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 29CBD1956080; Wed, 19 Nov 2025 08:27:47 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B95A3180049F; Wed, 19 Nov 2025 08:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Re4yiaiH5D2dM2qpTganIASvqSQt9Utb2xjF3Jrx0cc=; b=ipiOzE2noFeKSTqRaVcDTWK3T88NeYOtqQGn27JIpqdMs1TpIT5+1zx7p5WN7IcgcWnq5r SmhE35Oly9C33QPmh9UZdrzhJmuuzObIB4THuTD/DnAy7mCMY22qICdKaSFGxPkWFrBGG7 k6wNJ2KFODwQJME2yQAa/e4nqoovpws= X-MC-Unique: T46KxYwGMHiStBHaAyuDGw-1 X-Mimecast-MFC-AGG-ID: T46KxYwGMHiStBHaAyuDGw_1763540867 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 10/15] tests/functional/ppc/test_ppe42: Fix style issues reported by pylint Date: Wed, 19 Nov 2025 09:26:31 +0100 Message-ID: <20251119082636.43286-11-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540910852158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Pylint suggests to write some parts of the code in a slightly different way ... thus rework the code to make the linter happy. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/functional/ppc/test_ppe42.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/functional/ppc/test_ppe42.py b/tests/functional/ppc/test= _ppe42.py index 26bbe11b2d3..7b360a40a54 100644 --- a/tests/functional/ppc/test_ppe42.py +++ b/tests/functional/ppc/test_ppe42.py @@ -6,8 +6,9 @@ # # SPDX-License-Identifier: GPL-2.0-or-later =20 -from qemu_test import QemuSystemTest, Asset import asyncio +from qemu_test import QemuSystemTest, Asset + =20 class Ppe42Machine(QemuSystemTest): =20 @@ -30,13 +31,13 @@ def _test_completed(self): raise =20 self.log.info(output) - if "NIP fff80200" in output: - self.log.info("") - return True - else: + if "NIP fff80200" not in output: self.log.info("") return False =20 + self.log.info("") + return True + def _wait_pass_fail(self, timeout): while not self._test_completed(): if timeout >=3D self.poll_period: @@ -49,14 +50,13 @@ def _wait_pass_fail(self, timeout): =20 except asyncio.TimeoutError: self.log.info("Poll period ended.") - pass =20 except Exception as err: self.log.debug(f"event_wait() failed due to {err=3D}," " {type(err)=3D}") raise =20 - if e !=3D None: + if e is not None: self.log.debug(f"Execution stopped: {e}") self.log.debug("Exiting due to test failure") self.fail("Failure detected!") --=20 2.51.1 From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540946; cv=none; d=zohomail.com; s=zohoarc; b=mPbOpD2KhCkq9Jcj250AZSbo6n+cxi1ZSwhHHW1fRg4roHDdi6xupgNWSMfb49sCKKitZFi6SvbZnU3RuF4jpyMMJat96cnZSaPVvdpKiSh6yKoM42EeT+CpzbeeQbD0XxCUd7fFSBxAMSaQHLnc6QWSs+/tcSFx2toGPTmW594= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540946; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5GgSYuz7W+zTsurBR74ACOTCdfc+7nF80rcsqhxkObw=; b=AUXx3bCn8I6o0dWtML9L+ROWVGH/tWOu6fwk5Al8ie+sige5h/CLHDN+tMakMrElRdi9HLDVKWI2V8mvrw3flJCIQhckjP3QFm7TeiEeWdaVbj92ion9mB/k0PhNTmml8BZ1Xje504HZPxP8FbkroZXlUTMgkNMiw9INJ2Uz4z0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540946762263.11610860994836; Wed, 19 Nov 2025 00:29:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdY6-0004VI-8g; Wed, 19 Nov 2025 03:28:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXm-0003nT-Dt for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:28:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXk-0000wj-8X for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:28:02 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-s6XwD0YBO4uz9SQRcVJiqw-1; Wed, 19 Nov 2025 03:27:55 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A02E118D95D1; Wed, 19 Nov 2025 08:27:52 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 71271180047F; Wed, 19 Nov 2025 08:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5GgSYuz7W+zTsurBR74ACOTCdfc+7nF80rcsqhxkObw=; b=Q84LDj6tAVjmd9cwxHgUEEPth5L59JNioGNBSsKJ4sPR+Kp6y9bepLd9KDTpdFZkyxHxLo 9gAOB0Qwm+pP0L5xmO+FpSAuex24B1FA9Qks5ApozRp4Pt2lzFp8r55fAXnMsdtJGWQdfP sD31xMHLl5GSjAY7weT9QOfHWQX2PpY= X-MC-Unique: s6XwD0YBO4uz9SQRcVJiqw-1 X-Mimecast-MFC-AGG-ID: s6XwD0YBO4uz9SQRcVJiqw_1763540873 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 11/15] tests/functional/aarch64/test_virt_gpu: Fix style issues Date: Wed, 19 Nov 2025 09:26:32 +0100 Message-ID: <20251119082636.43286-12-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540948981158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Reshuffle the import statements according to the suggestions from pylint, use lowercase letters for variable names, and drop some spaces that flake8 did not like. Signed-off-by: Thomas Huth --- tests/functional/aarch64/test_virt_gpu.py | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/functional/aarch64/test_virt_gpu.py b/tests/functional/a= arch64/test_virt_gpu.py index c26a1f20c65..6ed0e0fc1a9 100755 --- a/tests/functional/aarch64/test_virt_gpu.py +++ b/tests/functional/aarch64/test_virt_gpu.py @@ -9,16 +9,16 @@ # # SPDX-License-Identifier: GPL-2.0-or-later =20 -from qemu.machine.machine import VMLaunchFailure +from re import search +from subprocess import check_output, CalledProcessError =20 -from qemu_test import Asset +from qemu_test import Asset, skipIfMissingCommands from qemu_test import exec_command_and_wait_for_pattern as ec_and_wait -from qemu_test import skipIfMissingCommands =20 from qemu_test.linuxkernel import LinuxKernelTest =20 -from re import search -from subprocess import check_output, CalledProcessError +from qemu.machine.machine import VMLaunchFailure + =20 class Aarch64VirtGPUMachine(LinuxKernelTest): =20 @@ -81,16 +81,16 @@ def _launch_virt_gpu(self, gpu_device): self.wait_for_console_pattern('buildroot login:') ec_and_wait(self, 'root', '#') =20 - def _run_virt_weston_test(self, cmd, fail =3D None): + def _run_virt_weston_test(self, cmd, fail=3DNone): =20 # make it easier to detect successful return to shell - PS1 =3D 'RES=3D[$?] # ' - OK_CMD =3D 'RES=3D[0] # ' + ps1 =3D 'RES=3D[$?] # ' + ok_cmd =3D 'RES=3D[0] # ' =20 ec_and_wait(self, 'export XDG_RUNTIME_DIR=3D/tmp', '#') - ec_and_wait(self, f"export PS1=3D'{PS1}'", OK_CMD) + ec_and_wait(self, f"export PS1=3D'{ps1}'", ok_cmd) full_cmd =3D f"weston -B headless --renderer gl --shell kiosk -- {= cmd}" - ec_and_wait(self, full_cmd, OK_CMD, fail) + ec_and_wait(self, full_cmd, ok_cmd, fail) =20 @skipIfMissingCommands('zstd') def test_aarch64_virt_with_virgl_gpu(self): --=20 2.51.1 From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540935; cv=none; d=zohomail.com; s=zohoarc; b=kWh3sCqwVSZlKQZZKUzJit9Kpm8eqVIQVTQsfSj2SEE/TNMkXZj65BZP5SZwHYhViAxqQwhpqgyloELzti/0Cl+bF8PqlknBedafgXC1xVpIu4B2uFsmq997bWhDG8cafnIs1tuAprObrxIZsfHEeAgphFukTwX5oKexBKV8j0Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540935; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wsHhofRo5lqiIbmcS1Yb8xhqpSUPxrcCY93dg6TkMlQ=; b=ia2BrKQu6lnl/TjMp7MH19uRVfzxNIffwMKn1RfEiU8pKoSnwREDB0Z7EVsJt77KPKXYvriBPw37FmyFxsqCVgJ/zlysl56pNmEFPcoX9i0icYcsPUfCSfaRfwuvGNmziY6BzqRwPUOl7vV1eTEOVlDj4Yr7k+fTEcKe1TH318Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540935480619.8078196615223; Wed, 19 Nov 2025 00:28:55 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdY5-0004QU-AO; Wed, 19 Nov 2025 03:28:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXp-0003oE-2Z for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:28:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXn-0000x0-6R for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:28:04 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-6uun3e_RPfm5BtoNxbPj-A-1; Wed, 19 Nov 2025 03:28:01 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 80BB51956080; Wed, 19 Nov 2025 08:27:58 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 12A46180047F; Wed, 19 Nov 2025 08:27:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wsHhofRo5lqiIbmcS1Yb8xhqpSUPxrcCY93dg6TkMlQ=; b=Hg7c0JSIehsYmSgv9+SsHkIZctxYoAnm/sMzTws17remCaP17hKVjq0ttye7oGeXHpPEbG O9Rceec2cZVmi0czTeWf35yLVvE/ZcaaloDr84DDny+pHPOViZiO9VRLMnubM7DDGm77eR kEPt5Y7f/kBi0lrZg3mmNyTdGi2OI50= X-MC-Unique: 6uun3e_RPfm5BtoNxbPj-A-1 X-Mimecast-MFC-AGG-ID: 6uun3e_RPfm5BtoNxbPj-A_1763540878 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 12/15] tests/functional/aarch64/test_reverse_debug: Fix issues reported by pylint Date: Wed, 19 Nov 2025 09:26:33 +0100 Message-ID: <20251119082636.43286-13-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540936868158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Don't use underscores in CamelCase names and drop an unused import. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/functional/aarch64/test_reverse_debug.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/functional/aarch64/test_reverse_debug.py b/tests/functio= nal/aarch64/test_reverse_debug.py index ec3348c96d8..e9fa4479d73 100755 --- a/tests/functional/aarch64/test_reverse_debug.py +++ b/tests/functional/aarch64/test_reverse_debug.py @@ -14,11 +14,11 @@ # This work is licensed under the terms of the GNU GPL, version 2 or # later. See the COPYING file in the top-level directory. =20 -from qemu_test import Asset, skipFlakyTest +from qemu_test import Asset from reverse_debugging import ReverseDebugging =20 =20 -class ReverseDebugging_AArch64(ReverseDebugging): +class ReverseDebuggingAArch64(ReverseDebugging): =20 ASSET_KERNEL =3D Asset( ('https://archives.fedoraproject.org/pub/archive/fedora/linux/' --=20 2.51.1 From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540944; cv=none; d=zohomail.com; s=zohoarc; b=GLo5c+O6QzfNSa/mVqVXWNdyyMbOBK1GEX528tAcbDLbZDKKHRgKlo9A4Drh915kpaHCf2o/+WzTikzWAZjsCmTFCxhglISwIVxcYGa/a1+sIJW55Mo8p8EUdtwUToz4V6cdKlz9gT6UefQjanNehFYXyWnpj9AVh4RQVdXRBYw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540944; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KwIIRsBmWqp60XO214jB8NQR0t9Y7pwVTZBxhyearJo=; b=DdYsAuvrBccMQIuRMtmS8o0zyZOO1kCmXAk/mG3OIb+pSA/DdNLShEO3U5c7onjxeBL5bRpgz4+FQgayRlUJVhVf1q2wTLv8tM4IskYo8Dmhzwi9oki0PmOP9QL8d6QlW4gtFCBurO4O7jMb1axk7+3ftTPo9t0L5pfoXrOZOBk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540944037619.5474057691425; Wed, 19 Nov 2025 00:29:04 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdY8-0004ep-81; Wed, 19 Nov 2025 03:28:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXw-00044U-Qu for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:28:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdXv-0000xT-4T for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:28:12 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-201-y96cg4MWPpqSBt5S5wO0Rw-1; Wed, 19 Nov 2025 03:28:06 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7CC071956089; Wed, 19 Nov 2025 08:28:04 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E6FA1180049F; Wed, 19 Nov 2025 08:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KwIIRsBmWqp60XO214jB8NQR0t9Y7pwVTZBxhyearJo=; b=ByTVizPQ1O9LsvQs0h5WKVWh1VemFwVUeyjDOzvHJi+AvB4fhe9Fo7iyj5XsALSt8g+Htw vbqFgI32x4cvtcbH7qZhLLrK9vLn8imi5SdC9B/cGscX+bc9c6mRTkzUT2ujnT3uWTtTGA 2TGpJR37yRFjUHEDYp4S4Z1l6aLy4VU= X-MC-Unique: y96cg4MWPpqSBt5S5wO0Rw-1 X-Mimecast-MFC-AGG-ID: y96cg4MWPpqSBt5S5wO0Rw_1763540884 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 13/15] tests/functional/aarch64/test_smmu: Silence warning from pylint Date: Wed, 19 Nov 2025 09:26:34 +0100 Message-ID: <20251119082636.43286-14-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540945297153000 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Pylint thinks that the accel variable might be used here without being set first, since it does not know that skipTest() never returns. Thus initialize "accel =3D None" here to make it happy. Signed-off-by: Thomas Huth --- tests/functional/aarch64/test_smmu.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/functional/aarch64/test_smmu.py b/tests/functional/aarch= 64/test_smmu.py index e0f4a922176..87b9b14e7a5 100755 --- a/tests/functional/aarch64/test_smmu.py +++ b/tests/functional/aarch64/test_smmu.py @@ -50,6 +50,7 @@ def common_vm_setup(self, kernel, initrd, disk): elif kvm_available(self.qemu_bin): accel =3D "kvm" else: + accel =3D None # for keeping pylint happy self.skipTest("Neither HVF nor KVM accelerator is available") self.require_accelerator(accel) self.require_netdev('user') --=20 2.51.1 From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540917; cv=none; d=zohomail.com; s=zohoarc; b=dR8PS4rQ8MtuzvxMlRGSpmI1c1+EZE31+Dw1RHE54wKTImpqj9xkbsMfyPPJtobQ7Il8v5HrFMT8FlrP3erAl5lXexbJSLal8tK8loUIBo0AH0uMZbxIDdZpB290WGbTrku0U33v8GdHVkCS4gWwaneIgY1FIGtq4QvNJTuJNuY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540917; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6nu5LuitdGviKiN9aEDUZqaxz6ZXF3o7GGL7eBgYZgc=; b=EM9B7uc9y4aHos72KIReSzzcI6yKh68sKptI1c4hYuCU6of33iKg3sSLWPBZJ1iRXzUWUnwz3ILzRsPhPdAN3sde12FxEFea1TsXEshtK54sBH40nKyCj2qEppIMVDkqYx63J/YMwnHffqfs/5+rw3H7Knmnq48p/CHVMB2n420= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540917454999.799735679658; Wed, 19 Nov 2025 00:28:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdY9-0004k9-RD; Wed, 19 Nov 2025 03:28:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdY4-0004R7-Jr for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:28:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdY2-0000xn-SZ for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:28:20 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-252-IRgxfoeDO1SNBNEXo0Karw-1; Wed, 19 Nov 2025 03:28:12 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ED4DB1956080; Wed, 19 Nov 2025 08:28:09 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BC2DF180049F; Wed, 19 Nov 2025 08:28:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6nu5LuitdGviKiN9aEDUZqaxz6ZXF3o7GGL7eBgYZgc=; b=EN885+1hGMAkYcWQWFlHws5vKHKOKSPkuvcRPp2qbqaGnDnKWp+JM/Yjv7jotzIuPp20JG q3te2NyRFMw7TquJg7P9vERXJNilCgin5xGhgd4TG6StJfWVukJ6Sw9DDf4c0NRkwPy1s2 V8HTecRMn67XNBeoOdqkP5M15RWBG2I= X-MC-Unique: IRgxfoeDO1SNBNEXo0Karw-1 X-Mimecast-MFC-AGG-ID: IRgxfoeDO1SNBNEXo0Karw_1763540890 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 14/15] tests/functional/aarch64/test_rme_sbsaref: Silence issues reported by pylint Date: Wed, 19 Nov 2025 09:26:35 +0100 Message-ID: <20251119082636.43286-15-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540918877158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Drop unused import and use an encoding for open(). Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/functional/aarch64/test_rme_sbsaref.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/functional/aarch64/test_rme_sbsaref.py b/tests/functiona= l/aarch64/test_rme_sbsaref.py index 6f92858397a..4845c824960 100755 --- a/tests/functional/aarch64/test_rme_sbsaref.py +++ b/tests/functional/aarch64/test_rme_sbsaref.py @@ -14,7 +14,6 @@ import shutil =20 from qemu_test import QemuSystemTest, Asset, wait_for_console_pattern -from qemu_test import exec_command_and_wait_for_pattern =20 =20 class Aarch64RMESbsaRefMachine(QemuSystemTest): @@ -48,7 +47,7 @@ def test_aarch64_rme_sbsaref(self): efi =3D join(rme_stack, 'out', 'EFI') os.makedirs(efi, exist_ok=3DTrue) shutil.copyfile(join(rme_stack, 'out', 'Image'), join(efi, 'Image'= )) - with open(join(efi, 'startup.nsh'), 'w') as startup: + with open(join(efi, 'startup.nsh'), 'w', encoding=3D'ascii') as st= artup: startup.write('fs0:Image nokaslr root=3D/dev/vda rw init=3D/in= it --' ' /host/out/lkvm run --realm' ' -m 256m' --=20 2.51.1 From nobody Thu Nov 20 12:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763540928; cv=none; d=zohomail.com; s=zohoarc; b=Yzn2DU7U5vAdw2crxoAr9+ZEtbFo9iO9XZwtS5KMREnTJZFRA9vKQ2S92L1XVZz05J69IS7whym+CQ5dnVjsiVdn/NKU/Atf6UeVWwz8zTEslVu1dWQllCND7wPvIt9FFmFm4fYgK966jvBQtO7/dwXyTkrr4cBuf6qVOwBQVMM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763540928; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1JjP04p/a3qVWmVtwDi217sBbPAhwIDdHPY9477Xyuo=; b=LmYepDjYa68SU17AkonlzHJhlFKp/K7CcHgq8PuUGu415rKJ1HBoNd+WnozWq2Hr6PsJtpI2c9HmX9EX+L27lAJ0fDW1orb9PM4Erv71FZ2WoBqu14VOamRuyC1wBLFcKQcPg1uDFhn80rKhmRVI9/oodgno0GAVd9kQkRDlZR4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763540928093122.53956338452338; Wed, 19 Nov 2025 00:28:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLdYB-0004xb-Sn; Wed, 19 Nov 2025 03:28:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdY9-0004lG-I9 for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:28:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLdY7-0000y5-N3 for qemu-devel@nongnu.org; Wed, 19 Nov 2025 03:28:25 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-1xzJYJwJOI-uOCWtNJXETw-1; Wed, 19 Nov 2025 03:28:18 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C941C1801237; Wed, 19 Nov 2025 08:28:15 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5E295180047F; Wed, 19 Nov 2025 08:28:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763540903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1JjP04p/a3qVWmVtwDi217sBbPAhwIDdHPY9477Xyuo=; b=NWo4YXAk6Ilwo81cJP8316deWjeNhe/uOAG3tQn+ADvc8FepBA4+JnRK9GcYgQp0JZS5nS D2FbDv3jgflT7nB9CUFPrgQyys7C9jij3YsatATKpvFLjiXhLjyuVdbk9ov5XSJVYImEVl lUzCKZ8+cSXC4rV2Gwt7ROsDaF/uocM= X-MC-Unique: 1xzJYJwJOI-uOCWtNJXETw-1 X-Mimecast-MFC-AGG-ID: 1xzJYJwJOI-uOCWtNJXETw_1763540895 From: Thomas Huth To: qemu-devel@nongnu.org, John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Radoslaw Biernacki , Peter Maydell , Leif Lindholm , Eric Auger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , BALATON Zoltan , Glenn Miles , Nicholas Piggin , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Zhao Liu , Jiaxun Yang Subject: [PATCH for-11.0 15/15] tests/functional: Add a generic test that checks the files with pylint Date: Wed, 19 Nov 2025 09:26:36 +0100 Message-ID: <20251119082636.43286-16-thuth@redhat.com> In-Reply-To: <20251119082636.43286-1-thuth@redhat.com> References: <20251119082636.43286-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763540928873158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth To avoid that new pylint-related warnings get committed, let's check the files with pylint during each run (similar to what we are doing for the iotests already). Signed-off-by: Thomas Huth --- tests/functional/generic/meson.build | 1 + tests/functional/generic/test_linters.py | 41 ++++++++++++++++++++++++ 2 files changed, 42 insertions(+) create mode 100755 tests/functional/generic/test_linters.py diff --git a/tests/functional/generic/meson.build b/tests/functional/generi= c/meson.build index 013cc96fbf8..09763c5d229 100644 --- a/tests/functional/generic/meson.build +++ b/tests/functional/generic/meson.build @@ -3,6 +3,7 @@ tests_generic_system =3D [ 'empty_cpu_model', 'info_usernet', + 'linters', 'version', 'vnc', ] diff --git a/tests/functional/generic/test_linters.py b/tests/functional/ge= neric/test_linters.py new file mode 100755 index 00000000000..b5b90fcf7a3 --- /dev/null +++ b/tests/functional/generic/test_linters.py @@ -0,0 +1,41 @@ +#!/usr/bin/env python3 +# +# SPDX-License-Identifier: GPL-2.0-or-later +# +'''Python linter tests''' + +import os + +from pathlib import Path +from qemu_test import QemuBaseTest, skipIfMissingImports + + +class LinterTest(QemuBaseTest): + ''' + Run python linters on the test *.py files + ''' + + @skipIfMissingImports("pylint") + def test_pylint(self): + '''Check source files with pylint''' + from pylint.lint import Run as pylint_run + from pylint.reporters.collecting_reporter import CollectingReporter + srcdir =3D os.path.join(Path(__file__).parent.parent, self.arch) + rcfile =3D os.path.join(Path(__file__).parent.parent, "pylintrc") + self.log.info('Checking files in %s with pylint', srcdir) + reporter =3D CollectingReporter() + pylint_run(["--rcfile", rcfile, srcdir], reporter=3Dreporter, exit= =3DFalse) + if reporter.messages: + fmt =3D '"{path}:{line}: {msg_id}: {msg} ({symbol})"' + for msg in reporter.messages: + if msg.category =3D=3D "error": + self.log.error(msg.format(fmt)) + elif msg.category =3D=3D "warning": + self.log.warning(msg.format(fmt)) + else: + self.log.info(msg.format(fmt)) + self.fail("Pylint failed, see base.log for details.") + + +if __name__ =3D=3D '__main__': + QemuBaseTest.main() --=20 2.51.1