From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492515; cv=none; d=zohomail.com; s=zohoarc; b=KdCv3UAKOCo58njiOb7rVMTsTVkED4sti54x/SO3PRZz1mq3knNQJuVh4NSk6yUlcnbt6XktwVqSdaQsa5iLBuvjcYvMpMM6ALuhO34Tbh9itnVUihGvaYtXvhbs4M1fK0ysIQKAPJY4EBt4ZMuTqEmIKqr3CH+w5tSd6N96DWU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492515; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=QC8WE8eYMgcfS9sjroA8zBJbr2zc7zfo/2xABclw2L0=; b=n8E9Qa4f4ca4ApXiYNWIrwrcmx9rdieAIdK9pgpZtEguQzPeF4uJusuTCGyh+NqRm5od2i+V2mkcbE7XwGm8EKvNy6en3+eQ1VTveNsrbfC6DNWPH6/l87wyDJ9Q7DEIeIyCOi4YsJpc3MmL98WTH2qltH1p26AhErUv/HqrKwI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492515071698.8521638769358; Tue, 18 Nov 2025 11:01:55 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQx8-0008CY-2b; Tue, 18 Nov 2025 14:01:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQwx-00087J-5e for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:01:11 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQwt-0005zf-Cs for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:01:10 -0500 Received: by mail-wm1-x343.google.com with SMTP id 5b1f17b1804b1-4779ce2a624so28781475e9.2 for ; Tue, 18 Nov 2025 11:01:05 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b106b10asm5154785e9.10.2025.11.18.11.01.02 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:01:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492463; x=1764097263; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=QC8WE8eYMgcfS9sjroA8zBJbr2zc7zfo/2xABclw2L0=; b=X5gXXUVCpFjDd7i/5R+WA8RUzDCYaqs1Mvl+F5NmUucci+is+9dSF7CKvzDhN4azfJ W6VU9wnHVMrEmrciCE+7N1dYOHkvhFV84eDuxFt/OGMFLzwlsSsVwQOhKiX3Y6OfWHdq 7t0d/3mMF2+qBzKd8ZqXRA8+FzBSAfdIoyhMZZNX3e/BjVQE+JNh/fvKhqrBv5MCN3oc cA05LOGcJJAvLt1eAq4GW2YJ7UXSiD1jfB12Aw86GQKMCDrnDQICXRoaICGlW3a5M/kX obUTXs8O3/E8fWc4wOzTar99/J6SV7U5nAZT27WcXDf8OSIYifNutThfQRrVAn7zQKpt retA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492463; x=1764097263; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=QC8WE8eYMgcfS9sjroA8zBJbr2zc7zfo/2xABclw2L0=; b=BJnbuHJ7LYZ3yGl7stFDk9zJ6GqCbOAxlu0s/GyZzWMOST/42w9XOP7I2hV67x6pYc UImYC4c9bdBRMNqPgHwdBUXeKRyL4rMutW7OCPocehWksV9vKY6SteNWa0aOCJg5QsEd x9K6ib/jLh3mxjOGva5ZWtA9MmKOYNNIr68DyIkSid5MyDvK7u3bC4tiT+tn36JU+m5w xinB2le+3RJXs0YKbGpXhJdWj5BAGXp7+GdejsGYGmh4dTIogblXhUXFCvUNIIY44MmB H0U0mj24AtpMvNy/u1sRUnK8u5B4uoH/hu4jCmOSHkV/N0/8TAJoY+V+47T1V4oUOVVt 43ww== X-Gm-Message-State: AOJu0YxTHn4KiM3qhwVRntnk1rsrMkCWESREHXKzX7zBbJVpOBT7OZfx g/RvhgfP80sQnEy6TA68/rVfiLn3Vn2qdwUxl+65Z9ZMxhyphryhpkLGhdd1KKuWgrZ36W0M0Rf s9e54D9qAYxTg X-Gm-Gg: ASbGncuDvdmEJlCSijZhO8f9CojgThCkNchLYUVxz6wR+1/ae0h8EV+pgm1vLl7xe11 zokN5WV5RqgEmV55Qw1G6CK8zec3OXlmkmM0WYbM3TxQy1qKMyJGNmPL/i65xJM1GnuinDLiKBC 9orH3Z0rVNtOBDWKETaS5ZBJn1PmZRmu9bp4nsVRTnIct6K2YraCXyBH96nWDjySqi9OVkYqnYJ HsiZfku5oqDd/p+nSaTnydv+MijqpKUbgcguzBZNP6delwUgRlttvtYvS9+07BGdIQ4biooAkCs HjGz7mDkXKwdeBqeaag46dwzqU81B5xiAoqjtKJZG6zi3GFB+Qliu8YyTx3ZebDxY1Vv7oeiAVy XAaYeN09hpN3VQ1RFjotbCk8nLwGwsqLEs6ur1vxYEYjWYS8WhfxfyyMoF/090cWKU+SaBNVQdx 25Ke/Spy5dsA2+R9rYe8+i+Lped3nkhXqJYVgaww5kwFVcWYh+8Lro/HEZ/WZk X-Google-Smtp-Source: AGHT+IH0I+9C+HeUrCvYPESlnc6sMV0sq5hDciSWKvU1EkBjarEwsjIZiewdGkhRXo7qK2Ur2BbDUg== X-Received: by 2002:a05:600c:5246:b0:477:a977:b8c2 with SMTP id 5b1f17b1804b1-477a977b995mr32655345e9.13.1763492463530; Tue, 18 Nov 2025 11:01:03 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 01/18] MAINTAINERS: Update David Hildenbrand's email address Date: Tue, 18 Nov 2025 20:00:36 +0100 Message-ID: <20251118190053.39015-2-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=philmd@linaro.org; helo=mail-wm1-x343.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492517969153000 From: "David Hildenbrand (Red Hat)" Switch to kernel.org email address as I will be leaving Red Hat. The old address will remain active until end of January 2026, so performing the change now should make sure that most mails will reach me. Signed-off-by: David Hildenbrand Signed-off-by: David Hildenbrand (Red Hat) Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251103103947.384401-1-david@kernel.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- MAINTAINERS | 18 +++++++++--------- .mailmap | 1 + 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 38325e0617c..d1c5080e505 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -364,7 +364,7 @@ F: target/rx/ =20 S390 TCG CPUs M: Richard Henderson -M: David Hildenbrand +M: David Hildenbrand R: Ilya Leoshkevich S: Maintained F: target/s390x/ @@ -1862,7 +1862,7 @@ F: target/s390x/ioinst.c L: qemu-s390x@nongnu.org =20 S390 CPU models -M: David Hildenbrand +M: David Hildenbrand S: Maintained F: target/s390x/cpu_features*.[ch] F: target/s390x/cpu_models.[ch] @@ -2384,7 +2384,7 @@ F: tests/functional/x86_64/test_virtio_version.py =20 virtio-balloon M: Michael S. Tsirkin -M: David Hildenbrand +M: David Hildenbrand S: Maintained F: docs/interop/virtio-balloon-stats.rst F: hw/virtio/virtio-balloon*.c @@ -2532,7 +2532,7 @@ F: hw/virtio/virtio-crypto-pci.c F: include/hw/virtio/virtio-crypto.h =20 virtio based memory device -M: David Hildenbrand +M: David Hildenbrand S: Supported F: hw/s390x/virtio-ccw-md.c F: hw/s390x/virtio-ccw-md.h @@ -2541,7 +2541,7 @@ F: hw/virtio/virtio-md-*.c F: include/hw/virtio/virtio-md-pci.h =20 virtio-mem -M: David Hildenbrand +M: David Hildenbrand S: Supported W: https://virtio-mem.gitlab.io/ F: hw/virtio/virtio-mem.c @@ -2919,7 +2919,7 @@ L: qemu-s390x@nongnu.org S390 floating interrupt controller M: Halil Pasic M: Christian Borntraeger -M: David Hildenbrand +M: David Hildenbrand R: Jason Herne S: Supported F: hw/intc/s390_flic*.c @@ -3248,7 +3248,7 @@ T: git https://gitlab.com/stsquad/qemu gdbstub/next Memory API M: Paolo Bonzini M: Peter Xu -M: David Hildenbrand +M: David Hildenbrand R: Philippe Mathieu-Daud=C3=A9 S: Supported F: include/system/ioport.h @@ -3268,7 +3268,7 @@ F: system/ram-block-attributes.c F: scripts/coccinelle/memory-region-housekeeping.cocci =20 Memory devices -M: David Hildenbrand +M: David Hildenbrand M: Igor Mammedov R: Xiao Guangrong S: Supported @@ -3371,7 +3371,7 @@ R: Ilya Maximets F: net/af-xdp.c =20 Host Memory Backends -M: David Hildenbrand +M: David Hildenbrand M: Igor Mammedov S: Maintained F: backends/hostmem*.c diff --git a/.mailmap b/.mailmap index 7f817d9f425..0690f7be34b 100644 --- a/.mailmap +++ b/.mailmap @@ -82,6 +82,7 @@ Brian Cain Brian Cain Christian Borntraeger Damien Hedde +David Hildenbrand Filip Bozuta Frederic Konrad Frederic Konrad --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492517; cv=none; d=zohomail.com; s=zohoarc; b=UJV/g5Wpiyf4UMUDD+xoabsQXx8cs3TDVzuzVt5SVLh2pQ5gWhrIEzrF6Gf0ITjA2nOBXIuMnaC7nG0OHUaHJePlQ/ksE1BrcoEjoLDHlIj+EAWE7IgEmAbspgqnFB2nGM3ypXrmMB/jJ8frQS0lCV3Nr+GmN2NLx381hmsqphw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492517; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=15FuB0x0LbOCNKczxF9rqixWt/dxqH7hptCfHdg0sEo=; b=eCc2mLk+wCI49mQTHlWwo5gwbiePIzgD8i1pzd6MTvpgj+3LawqMrzRprtpmyykI7R+okHak7FMjofZFnTJgER6qLl3tbBHVNs0XlvrM3A47rmM/UcDZMX+bwaHV0GLB82fnE3/dHm+f4sIhTP5t7aDnVGAcD+33a7poxwB3FG8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492517180465.94188201823533; Tue, 18 Nov 2025 11:01:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQx9-0008G4-Ok; Tue, 18 Nov 2025 14:01:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQx1-00087h-2Z for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:01:15 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQwz-00060G-AX for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:01:14 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4779d47be12so26327085e9.2 for ; Tue, 18 Nov 2025 11:01:12 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e7b14bsm33284633f8f.9.2025.11.18.11.01.09 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:01:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492471; x=1764097271; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=15FuB0x0LbOCNKczxF9rqixWt/dxqH7hptCfHdg0sEo=; b=P9UPb1mHMBgueIiDm5Vr2FlAOIfWHwGDWC8mzqv95vGOxdPgKRJyS6SX3N+eOHkJFh oplWrje/oqdNlzm5PH7U1mhcMjqndui3wDgctoS+WGM/HlqPSWKqQY/QOEpv5oyejMLs mJ4lrPo0EwLLf2fOIQM+ow8ClGiqnSfyYBSUZ4jw6NA27WK2aiABVy3oAm5KmaLfzxrG J6UMOOLFXWElrE25eq1jPRScPSsfDif5nfp0Jg0o+o6YY/mEytiT+Y85su9y56Y8iDvm M6qb5GLl0V5pV5zxyXEz3+DPhSk218JewHbzlRcnYncpu5VtA6AdgLQ9J1OTeey7OzEF IdUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492471; x=1764097271; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=15FuB0x0LbOCNKczxF9rqixWt/dxqH7hptCfHdg0sEo=; b=GkKDcaiQ1FC5fEBv5Bcy4Qz0RQG1RII2us4TEMXdhYUVT2IhblJtG12b0Bnkrouj2A DyuyGz6BgKTylmLYi2Qs6l74RmiSaD7e9TCcV9+1LhTKFMQUeEiJaSb2L1bIqbG+PWmE nui+Oq6eAk/RfEEnIgO5hnP0HlRn8LZk86XOqqmmSRB434UmUQG9Xd+3FS32zuzPv04V OjVbti4EFKuq4iKiqLnaky+VVcYgCw0rESkCDIfJ/rCg5iquf8vaPl7DW98Spo53bA+B LQ+3S67dK01h7GKUwmlmHhAlR3sHk2qGLp+GDx8vNqpAeXsWK9jhPO0cz1hpcFf5vPFQ pyRQ== X-Gm-Message-State: AOJu0YxCv1ssiPu2ITFHVOpR+m8tcMM4qMqNGgMzgZW8n52W1OvCCcpP X072dxocbogcIbDSyTZmDHNg+E0c704j/gGWwHB78gqI/Y2bilHY2QVq9aq931YYn4Rb7i3mkSe BnQzC4xeqpw== X-Gm-Gg: ASbGncvYsqE2kWIJHJM8REXLa8KEYl10gxwscSSuU6Kg6iKTXSdytp5rAjFmrP+JB/r 1xRX8Dc7WrCeBanevvrpHf0CODrIMMs7dHY1HpFzfvNfP1m5w1nKSny9Q7NtD4d1tn8gz3cwACk Y0v/EQPtf55kBSVdCKhprppJXZkC3wq1rHaOFut+ya4cd7hu3K8jVr1nfpCipjni1nZJWKsnscM 9XR5Q+qkp79yLqtDKfik8jsCWwDjKSXhkXDWQJtCZ7KVqGtfQTghzx1+zHnAbOEAmMjRkYuwCJ7 ZI9RY5IO0cAPSZE24PKA7QmRcVlR5tcYimZgLpL4ksjBrxiEFfXceZB2zEqdioc1/uo33Rq0sJ9 49TkkiOt+7j1qE3ZPL33jNvmD6hjIqimHyNX+0+QIaivCPZPFgl4yhLR7DLLAPlkJDQj+28TKbW 9GQnoadRy2xH/Xl1RZVQxIswJSWTE0LXUlde1IF16Salbjqh9gJ+D54kxALSML X-Google-Smtp-Source: AGHT+IGnbFcSanW9e8GF9c4LoQKYxUiPuW3JCwcGPuarszhlxpTQd+buN56D7ZXkIz0XXhcSeIBMxA== X-Received: by 2002:a05:600c:4505:b0:477:7a87:48d1 with SMTP id 5b1f17b1804b1-4778fea8810mr185910905e9.30.1763492471100; Tue, 18 Nov 2025 11:01:11 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 02/18] hw/intc/ioapic: Fix ACCEL_KERNEL_GSI_IRQFD_POSSIBLE typo Date: Tue, 18 Nov 2025 20:00:37 +0100 Message-ID: <20251118190053.39015-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492518644158500 From: C=C3=A9dric Le Goater Commit 638ac1c78457 introduced a regression in interrupt remapping when running a VM configured with an intel-iommu device and an assigned PCI VF. During boot, Linux reports repeated messages : [ 15.416794] __common_interrupt: 2.37 No irq handler for vector [ 15.417266] __common_interrupt: 2.37 No irq handler for vector [ 15.417733] __common_interrupt: 2.37 No irq handler for vector [ 15.418202] __common_interrupt: 2.37 No irq handler for vector [ 15.418670] __common_interrupt: 2.37 No irq handler for vector and may eventually hang. The issue is caused by the incorrect use of the macro ACCEL_KERNEL_GSI_IRQFD_POSSIBLE, which should instead be ACCEL_GSI_IRQFD_POSSIBLE. Fixes: 638ac1c78457 ("hw/intc: Generalize APIC helper names from kvm_* to a= ccel_*") Cc: Magnus Kulke Signed-off-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251106105148.737093-1-clg@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/intc/ioapic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c index e431d003117..38e43846486 100644 --- a/hw/intc/ioapic.c +++ b/hw/intc/ioapic.c @@ -216,7 +216,7 @@ static void ioapic_update_kvm_routes(IOAPICCommonState = *s) #endif } =20 -#ifdef ACCEL_KERNEL_GSI_IRQFD_POSSIBLE +#ifdef ACCEL_GSI_IRQFD_POSSIBLE static void ioapic_iec_notifier(void *private, bool global, uint32_t index, uint32_t mask) { @@ -434,7 +434,7 @@ static const MemoryRegionOps ioapic_io_ops =3D { =20 static void ioapic_machine_done_notify(Notifier *notifier, void *data) { -#ifdef ACCEL_KERNEL_GSI_IRQFD_POSSIBLE +#ifdef ACCEL_GSI_IRQFD_POSSIBLE IOAPICCommonState *s =3D container_of(notifier, IOAPICCommonState, machine_done); =20 --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492515; cv=none; d=zohomail.com; s=zohoarc; b=QLtlJoYg3ZRO1bQQsfhguEWUMTZ4AvCt6TD8rTucvCpS6sr3BUkCYyYNm7T34+lDdgcO7CrVEjyTcKcxKU8vbrR/GjFGOLrQ0fCIk6L6sEU7ycQMdB/z8xQhrNqQWd7kfBEBKARP9BS+lUp9U+/HLCdQe6VuXPucE3USM2JUb/Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492515; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=DvqP0yYSnga49L7kwxAU3PVeYVK1Qd/VcAbwUPzRRds=; b=m0SSqaBWCi3BbRPEDeFK/6wMSrHCLMvKhjmYVeoxQjt0ihomDKIN2fDHTs0Cnc8iT0nQVukkVAKIsW9T3CO85WVIrM0UfpfaGiA2ixBEgTKkro8RdaC/tV5sDFrQqroJEsb4sGD4UvXZiw17K2Fj+S+IvW9ODsJIHX1GQGWW6GI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176349251510066.2864616839837; Tue, 18 Nov 2025 11:01:55 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQxB-0008IN-8W; Tue, 18 Nov 2025 14:01:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQx9-0008F4-IE for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:01:23 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQx8-00060n-2w for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:01:23 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-47778b23f64so40001565e9.0 for ; Tue, 18 Nov 2025 11:01:21 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477a972141bsm24016645e9.2.2025.11.18.11.01.18 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:01:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492480; x=1764097280; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=DvqP0yYSnga49L7kwxAU3PVeYVK1Qd/VcAbwUPzRRds=; b=OLDcwJ9CFR4GQ0pBpE69GHeByVL5nTrrVtOXcYS+myoYRAyb2PNRTWEkfkH2Tzb67h TQbnonAN1fjGOmDQ4dOsokftMmeVbPJgvAs5bFb9Z56/S/mBhFWcKP74M7bPFP1kXJc0 r9lep29Qf4zhI/ERJj2YFDt0m8QTbRJB/rZ5uOmsg5U0TcuklsFKVqKW9xf4zotDMDw+ Xqy05R6T63yz5vSCvVg168hhW56Of2xDdDMzvMNNVXDN8MstasdzV2lKhcgfeO3VqIN6 Vp8CHqPzUlaM47rjbOxQch8+/gx2C9EaMJjjpnrP4JobtZnjvIH8wsNAI5CZVHrU0iRy buDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492480; x=1764097280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DvqP0yYSnga49L7kwxAU3PVeYVK1Qd/VcAbwUPzRRds=; b=VCCyZpX6WrwVI5V1s1wyo8d9RT1XxzIi5JUtbQLRPJ6O9dUycnWyfQtfaQQtlc6d5V HJF34nTUZbFmHPSLunP0XUItQqGssZviW1sdyNB2sB67isPFxtUtgUwE8ynCi5/c0Fbd zghT6JprjGQF/6/HvgHHTFGJOVAWcbVqTjvjTdgb1r4EYaaLvhiSZeFY9Mg0LQcKPmut o/f9n/ILbHIqvdEgC4DLbAU9EX1XPiBoPG3LjlZF4HzPCQFAzYsfjIZQEbxNSA8aDXGa 1EfwQ3GtJGAlWxYWJ4Wd6tUoqhGqSC1UKip8yG2gqy4WZOGeIxntV2rXSFMIrn6rQYUa oY8Q== X-Gm-Message-State: AOJu0YwuKWv6/+6sptw1WkMXpjqjEtwYh8m5SuUjwgiQez6xMJ1Zu2Fe hueekjBmFE5wdmN0kRQXVcVxwCa/TWqCFJEX2g0XijTdGfrLBZkwgasEe5MACaM5IS3T+wgeIIl 1ZioSpLYTIQ== X-Gm-Gg: ASbGncvTKzAKGxCzthIMSWELXAhxO5hTJLo+30HEt77QF3kSjtl3Kyw0Z1qXCmgSOkh Pu8slU7fUy5TdH2bkSHLaWfvyuPkdEkpefgf07ge/RvUwRjqAhl75XncaInsFU/lo0HwLPJx3gi pZyD6+oTwGPLYLZWHzAlfbkjrQNfbR5xC8RDe/TuWB8zUTSQhFYQ0Qzw0Y3KIUNJpllyZIHRf2O sUowT/hp7s51vWSsfCSINP+DAPOfsKHhp6SmhhfHxQw2dXMniSpWyTHGyLLJr7wMFZz1d0/nTBx 1Qlh2oEn5UK1j+26HIaf2lCdCd42EviwSPZCo+YiqQ7+Ijl33p5+7bsg1Vxoin4qhuvoVJvLs0K ijd18lpMCRYgxmEmpE25jWJ0jTJa7zNKv2VKpL3xqRzo/yzRvUwmbEX+vVWzs5coth5PWCBiA5g 2S1+HhKh4AJO3PNyxi5oILnVeMoq3FmRjHzWMM9GK6kNC/ES3RLcyul/XCRy1BAoZM4KKIA4Y= X-Google-Smtp-Source: AGHT+IFwf4FrvFejTsS/5cKXe7xHqIlpmVM2ovW+om+PstlGID1pH/dC+rvOw6kZZW9cb24b81WuFQ== X-Received: by 2002:a05:600c:4744:b0:46e:48fd:a1a9 with SMTP id 5b1f17b1804b1-4778fea8ab2mr178062855e9.33.1763492480099; Tue, 18 Nov 2025 11:01:20 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 03/18] system/qtest.c: Allow for multiple CHR_EVENT_CLOSED events Date: Tue, 18 Nov 2025 20:00:38 +0100 Message-ID: <20251118190053.39015-4-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492517902153000 From: Peter Maydell In the qtest_event() QEMUChrEvent handler, we create a timer and log OPENED on CHR_EVENT_OPENED, and we destroy the timer and log CLOSED on CHR_EVENT_CLOSED. However, the chardev subsystem can send us more than one CHR_EVENT_CLOSED if we're reading from a file chardev: * the first one happens when we read the last data from the file * the second one happens when the user hits ^C to exit QEMU and the chardev is finalized: char_fd_finalize() This causes us to call g_timer_elapsed() with a NULL timer (which glib complains about) and print an extra CLOSED log line with a zero timestamp: [I +0.063829] CLOSED qemu-system-aarch64: GLib: g_timer_elapsed: assertion 'timer !=3D NULL' fai= led [I +0.000000] CLOSED Avoid this by ignoring a CHR_EVENT_CLOSED if we have already processed one. Signed-off-by: Peter Maydell Reviewed-by: Laurent Vivier Reviewed-by: Fabiano Rosas Message-ID: <20251107174306.1408139-1-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- system/qtest.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/system/qtest.c b/system/qtest.c index e4d1cd75daa..cbeb7f37728 100644 --- a/system/qtest.c +++ b/system/qtest.c @@ -808,6 +808,10 @@ static void qtest_event(void *opaque, QEMUChrEvent eve= nt) } break; case CHR_EVENT_CLOSED: + if (!qtest_opened) { + /* Ignore CLOSED events if we have already closed the log */ + break; + } qtest_opened =3D false; if (qtest_log_fp) { fprintf(qtest_log_fp, "[I +" FMT_timeval "] CLOSED\n", g_timer= _elapsed(timer, NULL)); --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492544; cv=none; d=zohomail.com; s=zohoarc; b=HNMvwtJrRaRYl+Di4v6ERc77vE/sC+Pa8BX0gVoES5tZeEBC0NGTNPT9aqwdY08LqJLJuQ6d36GVUA3l65Zy9unxjmCqTsR4RaPWzuV33IXA6NhKlRf0I9ELf/qY3Tb/9VgmayZxdnOD/VNul7qSFHSzwBcLQoMgI0/t1eCbXIU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492544; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ok/ItGqyIFjLquLTm5tPFckGPKjD2Kp3ocnHaYbZ5ZY=; b=V/YeYZfPX7rgojFvLLABMuZcRrITQnbAqckt6fCw5Bqyw0iDAIeUTAd4RpWxAPrGTaAZy3oAoEeVD4MYomkW+VYBxXehrCwVJVuvnuU9xYNyqRZIK0XJRaw0tFM8uhS9jjgC6kYp4a8VqY1FnsUI0gPpTAf4Nqib8e7W9TEn9es= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17634925449181007.777853265291; Tue, 18 Nov 2025 11:02:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQxa-0008LJ-42; Tue, 18 Nov 2025 14:01:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQxW-0008Kc-Ay for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:01:47 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQxF-00061H-FH for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:01:46 -0500 Received: by mail-wm1-x343.google.com with SMTP id 5b1f17b1804b1-4777771ed1aso41149475e9.2 for ; Tue, 18 Nov 2025 11:01:28 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b1035c78sm4971755e9.11.2025.11.18.11.01.26 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:01:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492487; x=1764097287; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ok/ItGqyIFjLquLTm5tPFckGPKjD2Kp3ocnHaYbZ5ZY=; b=gi+zZfrdRRyVWU8m412vixUlxqZ4GOPwFdkySo1NOHPXRXaIDFn1P4R9R6B+4PRLLB N2wsg4TIodQNrnzcwMWQTHEV8i0Hv3g8fpghGMF75mXtwvBiTYr1g6qwMI6z7QSH0w4w YcWL++NfmLrQuZYNaMoBnDm8FjiWRVyNjhL7/8bYoWJUyban2tbFjPUcbqUNV+uUpBNo 2ES5GMgujtKVuT+XT7acnGTK6ktS95dumOmrBVo/D41yJt6qZIDvUB7Oxh2v5qC3SGuL 5qvBuZtW632MVCNauyT7pCsOtvImXx+COQAsonMXwuNLoIh6op3Bp8tfHDKjP2k2LLA6 I1+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492487; x=1764097287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ok/ItGqyIFjLquLTm5tPFckGPKjD2Kp3ocnHaYbZ5ZY=; b=fXIBX38WXuO95dVtN1X3cS47y91pYV3YEOGhFYhC+JF8tT61xfYA/yPWD0EpL701zv CZK+3uGzqBo1NKhDcdeUtrlUF6bYOfoVYtAOow7JRt7ZQpSFRLv3zQtHaBYidKOlLNtx WjLTYSn1hFJAnVgnCGdTePvdChc8B6ntEzwICwESKThMOM5NnESDa7ScswmhGpAdToHf YOm2eS323RJe1p3tyCTJ/OYqjhGUrfsUsK/A3+yQmnX1NOXuHpyVV26UWxYf0WfCUxWN hiZV0x6Z4UGqR4XPbrTOmOlvyLOpB6ut6qAiyJ02KRRmXtKyLDPsPCXnQngxSlWGQpxi mXOg== X-Gm-Message-State: AOJu0YwTnjpIpUdrzV/UQRHwNovCYo9jkgv5fb1CayhSn3qhxL51W4g5 b70BbM5xONcm/pmnc5SzZ+RzcTbvELL88hh4H27iO1QaM1+ROKfL2ISr71OErCdLhizBLatE1B+ SoYZlErwsKT50 X-Gm-Gg: ASbGncuoDrqIdC0F/bCPDKFaQx2HBeKlB+jINywmjIrwjAwf1E1rUhWSuIlkJIxfTiJ VS1fxflgLr7JfGIVZpGDsQou1lkorOLCooAdOs+of93kQjOxOX/5ba43h3MwoBZuOyPK/G6ItLg Lr0UJh+2/vLNkY4I2WG7fIeA6xCtZYD1uUy4CbvWvDZ/lhwr4zMD6ClOsmnV+ebVd55QRIAkOJA 8UKx4fuJqca9oqoCyqCINYt7AuCKe7rfQbzyt9ORIkz5qDcplzoMsZ5APzQMzSrED/+D54Sr47n CIM8iGHQNThH5agAh+XTUTltKFESHMf3GVt49PQNU+HDCxRo4HvXMBqUIcKkC2OHGXGHOuVZtUp /bN4Ovqddc9HCU2DagNkxamAlEyeIsCZEGlnaVKUUSocTmBnAQvT/h55vdCT2s8U+15lO9IrPEH nRALuPWhuurrlEIgzA8YTOICDBiLocnK4mygV2JpJpdkf9aOer+PW/saZ6OIFTYKVcJq8DJPLIx GOq8IcJLw== X-Google-Smtp-Source: AGHT+IGw6Xu8KrZbLXHP2Jy49Df/Reg4BZcu0hQhzVtNZyQaOqrakiKTO8YzP7/uooSfalDKHyb70A== X-Received: by 2002:a05:600c:4714:b0:477:8ba7:fe0a with SMTP id 5b1f17b1804b1-4778feaa8ffmr161157095e9.24.1763492487134; Tue, 18 Nov 2025 11:01:27 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 04/18] hw/sd: Fix incorrect idle state reporting in R1 response for SPI mode Date: Tue, 18 Nov 2025 20:00:39 +0100 Message-ID: <20251118190053.39015-5-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=philmd@linaro.org; helo=mail-wm1-x343.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492546877158501 From: Bin Meng Since commit b66f73a0 ("hw/sd: Add SDHC support for SD card SPI-mode"), the CARD_POWER_UP bit in the OCR register has been set after reset. Therefore, checking this bit against zero in sd_response_r1_make() to determine the card=E2=80=99s idle state is incorrect in SPI mode. As a resu= lt, QEMU makes the U-Boot mmc-spi driver believe the card never leaves the reset state. Fixes: 1585ab9f ("hw/sd/sdcard: Fill SPI response bits in card code") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2945 Reported-by: Tom Rini Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251110110507.1641042-2-bmeng.cn@gmail.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/sd/sd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 9c86c016cc9..5aae5413636 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -789,8 +789,7 @@ static size_t sd_response_size(SDState *sd, sd_rsp_type= _t rtype) static void sd_response_r1_make(SDState *sd, uint8_t *response) { if (sd_is_spi(sd)) { - response[0] =3D sd->state =3D=3D sd_idle_state - && !FIELD_EX32(sd->ocr, OCR, CARD_POWER_UP); + response[0] =3D sd->state =3D=3D sd_idle_state; response[0] |=3D FIELD_EX32(sd->card_status, CSR, ERASE_RESET) << = 1; response[0] |=3D FIELD_EX32(sd->card_status, CSR, ILLEGAL_COMMAND)= << 2; response[0] |=3D FIELD_EX32(sd->card_status, CSR, COM_CRC_ERROR) <= < 3; --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492529; cv=none; d=zohomail.com; s=zohoarc; b=Gu0Xj14Q77k6HDyw5U3TX3CNN/HeslAIckwWudB99gkPOJAo0zELUCVfCNG7ncBtOosd0ssbtIiZigUec37ZFveKvEBLj2q5SuN9pAl5ojkNaK5Cstlf8S2nvtVXskinseOvdvGwzqalvoGCmenpcKLJVA50ZnmmZUm+ngg3GLM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492529; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=4jRE2E0E1RV6lKHnV+cCA8THnOd68pefsVHATt1ZwL8=; b=JcE9PLIPRNZP7sLZ+Ahm+NVefe4nTkZmDmmZeGg64UUSdiJSD8i8nyYFi7JDj4AsWRRGwuw9l8J67F5qIMxR4lb7DmwRx2yx7KQq4RvySWuyx1BYSqssu1fLrJhnEGNL1++4qDjThLcwFKE48isleS/QxTOFjkhrwHoZ/uhHxMQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492529204700.10842220894; Tue, 18 Nov 2025 11:02:09 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQxi-0000F7-2T; Tue, 18 Nov 2025 14:01:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQxX-0008Kq-HS for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:01:47 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQxU-00061S-Oj for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:01:47 -0500 Received: by mail-wm1-x341.google.com with SMTP id 5b1f17b1804b1-4779cb0a33fso38932245e9.0 for ; Tue, 18 Nov 2025 11:01:36 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b10260adsm5156005e9.7.2025.11.18.11.01.33 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:01:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492494; x=1764097294; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=4jRE2E0E1RV6lKHnV+cCA8THnOd68pefsVHATt1ZwL8=; b=MU6Z2XB3BD+v6dibdIk4OBE3PHcoQ0ykFmhP9vQGnoxlu2YC0jsM+q4fN//d1ng+MP KMKg9bmMnW2z3XVe9N5MV1chY+ZVMNNKh0lVrAvaszrCdqnmhWN+T7tPu+X/N24Cup3F ulvOvymH5g/sXLqjtv+oZ/ijtuSJ3K7BkVo0N8oY/tpBV+NRrZiwOiNykA5eHEuJO0/t iNyKZdpOz0ePrSQlHnOYabqbnI/VBzjMc35opr2Om7r9F2UHKDPZ7OKIXZ8qqlA0KxAZ gsNKs0UbuDzTPGGCNDnqds0ofMPZeeVkGTLmMZ/ifJxIuSr9omBK6JW4rKYpzcRbloFZ pBnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492494; x=1764097294; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4jRE2E0E1RV6lKHnV+cCA8THnOd68pefsVHATt1ZwL8=; b=KuT2ZlN1QY0IscgWtrVKkskvfREtJbIa4x5fhT6DumUWwymesHCBRS0kAmjjec1c/4 Qcr4ovUXV6E+x88DIDzLIufG2AyrAOXQvvryGPMz/WoW9BOkV0QrcosjTXvWj+fFzSmK RH7UgGnVwGW+30EAl5fj1Yoe17Y/fTZ+3nk8tiRg/Lu4dy8kkcxbDEW9wLL0ZEUeD4aG jm9KO/lL46mpkVleFWaIxw8a533kd4fy7MfmCFxov8fynR/qyNeuiJM3WM/OGLjmhUin BOjfBmfsBy69zp1igPSZYGJj+28WPGLGiZgGYp5N85ft9yRe6EXqdiDUsUflMTF5AaY/ /a7A== X-Gm-Message-State: AOJu0YzprrrCuGC0OQfO7FnoUGK1bdcgLBPfrM9e6vxma+ZlW26UjmXc 0DZrOI85IDxBR4p4NS08zbwmVYXzpTlzPomgcxXvG/nMJ/4+uc8AxId17wBU4iSp1WXhdwI684j EtlXM+xZiX55h X-Gm-Gg: ASbGncvSCT6s+tgQTlNqur6DDjOdKGzo0G6FwDDTLSKhYPwelbskcs8dpoy3HAVWHHT O187vzHzMLdvk7dokNLFnVc/9+Qy2536KhgymgRYsiwfKFGA9/tH0+Av0B8v52XXpQnRFD6qodV qITi2e4ubDb+kk/vcojecT+V4SUbXax6lGNqkpWg39jHuR7y9UdpTkyD4XjevhK2u/g+vQEQ+zH 7Q29EmwR47Yda6jwzm9qai7MKx6l1NVHLPMO7KSLiJ+01PJQRfWSrPACprVEyeXFa33WIzih3DH utobJiwpQATxFgbTD2dBTv3C7RSaB/TSSzYSm23F4vkrzmJ6LTvGQsQfCQTxZAy+L4qUfjQIMEL qv77pQN/m8i8hNBpFTcN9DtMCdkmelPTJ+fhBSMEXgxxphpQ85JbShZr/RfJRpnTswFkeX1GxlE kz3xrteDBaljUnSE8CKrZtGMYIEyhBv4eZKAWbMb/v771c0ZaJvzQ1bvyDaV3O X-Google-Smtp-Source: AGHT+IHAdgsCMibwmO1vsPIlksPhc3WPrh4OnVpMy5zg6aXppbIJXnQX/rI77A9h4PzmXnAvSX27JA== X-Received: by 2002:a05:600c:1f12:b0:471:c72:c7f8 with SMTP id 5b1f17b1804b1-4778fe9b44dmr175047615e9.21.1763492494437; Tue, 18 Nov 2025 11:01:34 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 05/18] hw/sd: Fix ACMD41 state machine in SPI mode Date: Tue, 18 Nov 2025 20:00:40 +0100 Message-ID: <20251118190053.39015-6-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=philmd@linaro.org; helo=mail-wm1-x341.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492531977153000 From: Bin Meng In SPI mode, the ACMD41 argument only defines bit 30 (HCS); all other bits are reserved. The current implementation incorrectly checks the voltage window bits even in SPI mode, preventing the state machine from transitioning to the READY state. As a result, the U-Boot mmc-spi driver falls into an endless CMD55/ACMD41 loop. Fixes: 3241a61a ("hw/sd/sdcard: Use complete SEND_OP_COND implementation in= SPI mode") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2945 Reported-by: Tom Rini Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251110110507.1641042-3-bmeng.cn@gmail.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/sd/sd.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 5aae5413636..df5a36fad9d 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -2289,20 +2289,21 @@ static sd_rsp_type_t sd_cmd_SEND_OP_COND(SDState *s= d, SDRequest req) } } =20 - if (FIELD_EX32(sd->ocr & req.arg, OCR, VDD_VOLTAGE_WINDOW)) { - /* - * We accept any voltage. 10000 V is nothing. - * - * Once we're powered up, we advance straight to ready state - * unless it's an enquiry ACMD41 (bits 23:0 =3D=3D 0). - */ - sd->state =3D sd_ready_state; - } - if (sd_is_spi(sd)) { + sd->state =3D sd_ready_state; return sd_r1; + } else { + if (FIELD_EX32(sd->ocr & req.arg, OCR, VDD_VOLTAGE_WINDOW)) { + /* + * We accept any voltage. 10000 V is nothing. + * + * Once we're powered up, we advance straight to ready state + * unless it's an enquiry ACMD41 (bits 23:0 =3D=3D 0). + */ + sd->state =3D sd_ready_state; + } + return sd_r3; } - return sd_r3; } =20 /* ACMD42 */ --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492546; cv=none; d=zohomail.com; s=zohoarc; b=LjE0eKpXAcJcgiD7uzONpMajeeTu33uvSVw/2dIcmHkmm3uEDLiTFSSGchpK3xg39JheSSM6NqHHn2FT6ZAkKTZeC7Nfy8vKTi5gaypUF2ERsr2TdQ2NqyVaEICMJ0otLxv4IL2+h9MT2wXdLw4naWxmtnowyA/zE4sVTXgukqw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492546; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=x8Y+NEj6VKJAI0u4Zr/Y3281FFvefQs1CGtjQUIOGQo=; b=Jrcqh/IxNd7HoSmXXGrkbrxgJ8EHnOO1QsYTSt78gJnwvMxyNCF+I5gVTFv9/1tgP+vgsqz4ymh1KWWg2ReKDKI7cvPNr76d0KQEuV+y7xNBLywc/FtzPEjhOMmz5GYCwPod+2lgL9qTLQ0SscQA/qL4kgncXV8VFkPEmZ2DJ2Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492546942884.137840702194; Tue, 18 Nov 2025 11:02:26 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQxf-0008LX-B2; Tue, 18 Nov 2025 14:01:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQxX-0008Ko-Ga for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:01:47 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQxU-00061f-PD for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:01:46 -0500 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-42b39d51dcfso3301508f8f.2 for ; Tue, 18 Nov 2025 11:01:42 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f19aa0sm34186556f8f.37.2025.11.18.11.01.40 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492501; x=1764097301; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=x8Y+NEj6VKJAI0u4Zr/Y3281FFvefQs1CGtjQUIOGQo=; b=ZdqBrKn5yvGW/UuHcE/v6gkitSZ2KuCQUO413I80qH3EZoD67bSegC5t8N61FIufFp K0F/IGYFUZqJcngVJGwzCKJh6MS0MCRT75YaOrxDm29ADHSRBPzL1mcMd2gyycz9RbYy 80y/pRtR8C6JKwaJUl/UV5MfSTgMkYFWaAy1Pci1mmkj8jurjXQHlYwbQHiWmBzxqoLs k+WE+yuaDumLeg3LMFDVRSTFpQid1kESipZR/Hxsmlu/WhzmEpOKAZgDoMRnqAEkRq5I sZH9l5HiLUZ7rIyvhDOi1XwdkXozsiz8SOftg2H6Rm8fdQn8V+QjvF05FgAWP+9HV9HR heIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492501; x=1764097301; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=x8Y+NEj6VKJAI0u4Zr/Y3281FFvefQs1CGtjQUIOGQo=; b=KNKy1KRBTr196haHY5Q34b//TGC0DXEMyeoRwVxfl69/EikvU1zVB9okY9krVcjqEd 1txI9EwXD49Z9HNQZXfW1QnVVm9HZc1iOhA/i0EqdZnbv1rN+NEOt7z9airD3EFEdMib EBgLPS+76N5lxzUuxP7GWcok9vtjgXyx4kd6N/uWRnzOpXe9Dm0i/Vg8twX7a+5umc94 SOKFIynqX37I7A1/d5cgF27Q1DBtjBLpV3amY7VKAWeaDbw5u/pFKGXDpIyyktzD46Zk iM7ZLv9bKvj3FY5qcmqhGFQUc7eLFHQHzDQvTMHIKKIi0AQHEcUCvuRbihgAwzvXG7CT 8KbQ== X-Gm-Message-State: AOJu0YzcgOPwUA+F9SimW9gc2GOz/oNeD0stKvinB5zKkVOFxXTJ/Hfr /W4MKiIVo36gxbTZ60x02m8HoPu2b8FMEc2l4Y45r5r6E/XOHaIDxXNj1avBSNoniKJkwgSHfmp fD1rHrt2ApA== X-Gm-Gg: ASbGncsas/wPLrC5ye1f+5pNKYcMEzMq9g+Ji2q2naWpZpPRlQzaSTQyF0nPHJNevdR KxYwoSWDLSbpjCLuT26aa95+Sk8d4Ay9ZQZmQnS+mkjro+kD+eTeXpi7UxeEQh9SwO9PbqiBuPC 3lA5aR+odiy+t4to7Kj4qqCJixPzxNPrJwRBRlgfAOK2ICttvpAhGmhRrxcHXCWsF9nThRdK0wl iVdbsnwkTF81zE0GJfxgIxjzplvzpYkoxGYhgbDP8EcjNFA2MJ5O2zjJOGvHh6fkFQM90giLdoZ JicBYRDcmnVrFIfypwXfkHuRiWmr6pPGPOcq9J0/Lat0R+CWZK25AZf8Cd9GF9lCaYSrUT5Au97 I+4kjlk4bmx6EM7vRGiwsL5UZ5fwM4kvl4S7Z+I4yZ8Tsrc2766XB66Y9LgWiXgzSFAhWjSpFsF Fv9+4+h+R4Ffam+TTwxIkR7h/N3PxnqxZgu+2EA8Y5BYvd2bPsBW6q9i+cx3DT3h4v15IzFxs= X-Google-Smtp-Source: AGHT+IE6EJVQp8Ym48GIZjuBQ9IeQMu0Q7kn5wH6v6j9sQS8ImFdUdWo2cR1FDrZrOAikzr2aK3OpA== X-Received: by 2002:a05:6000:1449:b0:42b:3298:4690 with SMTP id ffacd0b85a97d-42b593741dbmr16379094f8f.33.1763492501353; Tue, 18 Nov 2025 11:01:41 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 06/18] hw/dma/zynq-devcfg: Fix register memory Date: Tue, 18 Nov 2025 20:00:41 +0100 Message-ID: <20251118190053.39015-7-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492548740158500 From: Yannick Vo=C3=9Fen Registers are always 32 bit aligned. R_MAX is not the maximum register address, it is the maximum register number. The memory size can be determined by 4 * R_MAX. Currently every register with an offset bigger than 0x40 will be ignored, because the memory size is set wrong. This effects the MCTRL register and makes it useless. This commit restores the correct behaviour. Cc: qemu-stable@nongnu.org Fixes: 034c2e69023 ("dma: Add Xilinx Zynq devcfg device model") Signed-off-by: YannickV Reviewed-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251111102836.212535-9-corvin.koehne@gmail.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/dma/xlnx-zynq-devcfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/dma/xlnx-zynq-devcfg.c b/hw/dma/xlnx-zynq-devcfg.c index 26845713ee5..8141d460338 100644 --- a/hw/dma/xlnx-zynq-devcfg.c +++ b/hw/dma/xlnx-zynq-devcfg.c @@ -372,7 +372,7 @@ static void xlnx_zynq_devcfg_init(Object *obj) s->regs_info, s->regs, &xlnx_zynq_devcfg_reg_ops, XLNX_ZYNQ_DEVCFG_ERR_DEBUG, - XLNX_ZYNQ_DEVCFG_R_MAX); + XLNX_ZYNQ_DEVCFG_R_MAX * 4); memory_region_add_subregion(&s->iomem, A_CTRL, ®_array->mem); --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492545; cv=none; d=zohomail.com; s=zohoarc; b=CnMBBC4efe/j3i8h2hjbGgElOR79KG+57J0FbYNU6fDP8RA5Mzrpl6r9kfyQG6OklFF8xJ36GhmRFLQoouMmR3cw+c2u0vTfOkatAsRGceyhhzX9vYre1EzuN28ty5c+gPvJrT7qwatDYNQ/Nf0x2a85jZ95+dsFH00nPP2p9DY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492545; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=+Cgq1nPDbrgVNM6eBtgyf6KBbF6NBZzhdBWfVQaqrO0=; b=BEy+Q2Xp2KZ1QL10Blhgdy5hEPcXaHToytycQs9iozjIaPedWiaXBGC9CnYhdV/7cHXbgtQhgeRZI0a016tZuayaiDIt64MJAUjYn/nXG+7A8ANFHb3sW8DRduDzAl48lCdx9T5ShNmjHenqMJVD49nwS3+7hjswmG976cVpryU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492545168178.5348379499186; Tue, 18 Nov 2025 11:02:25 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQxo-0000RA-Ep; Tue, 18 Nov 2025 14:02:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQxc-0008LZ-6e for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:01:55 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQxa-00062g-MX for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:01:51 -0500 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-42b3d7c1321so4228874f8f.3 for ; Tue, 18 Nov 2025 11:01:50 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f17291sm33724503f8f.32.2025.11.18.11.01.47 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:01:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492509; x=1764097309; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=+Cgq1nPDbrgVNM6eBtgyf6KBbF6NBZzhdBWfVQaqrO0=; b=v6JbdAVx05NbQK4yB8I5ATYktV0IbtzxBZcKjgRQNQC2DNOuXG0bs6JHOhBa7PvyWZ EDwMi+p4lxbnHzvcQ2Do34G83VIF5dTnXNOwyibIGMQP27YDN7j9U+6rkZMfWQOO0VY2 WRei/kD5FCtslrNT3Ld6rjgNEZZMYNagu1C932u2JW1vpyJQEsOOdbqvo3Ps3LosTfHU WXG2LOOIFTh8HkEKXC3XISLeSl+nj59AZBQXtSi03i6IiPAnhTc/ZUhSqcyUtRUGCEo3 0fdp2vbFQCb+8aO5JpTTTaZy22Xt67LNav5pJsUPDW5P22/iSrcXk5A554PY/1GakjJN h3/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492509; x=1764097309; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+Cgq1nPDbrgVNM6eBtgyf6KBbF6NBZzhdBWfVQaqrO0=; b=FF339jH36A9H69n2RTKKaDnj2B+gIUMRlHeQCbgy02Ayzet4miQyIgK2wfA1nrZ9Pv DrX+gTwJm1ZQN6u0c1OLZc/yH2SklOm+G09HTGvAG0zpY3kM2i8Ei3yxXJ5dn0OCOrF4 G9gZu3mT6QSEafuGFAhp2neTGvt+y/DLtAAXNTgt9GNxtCIJ5OfHBtureabPLZBcKBlZ 8zqF7CqChg5b8Xd7570Qfjl0VYwrzwL/KIOuM/LccGRCUwZmJM3IBNnRPIyVNneWmJv0 hr1ebitT6au1xFFG9y362w/m3mpYetco3ailVJ3tgimqwXAqF2QralGC5oRmk9QZD5nT 1v7w== X-Gm-Message-State: AOJu0YxASqE8Io2TEie3xRfEf+qw6UXY/DFVpNcKmYG+Tc9+6DBzFjW5 ImqxS/TN8EtVK0mytDM4XYWixWcJVLu1JXlubw9HIObKf27Ayk6RtbWBf9ce39y+z+Csy3M+1Ed Iygy33UOKqA== X-Gm-Gg: ASbGncupnjxZsoOTX5CwBA/yF9dA6B3jG2dqhMDRiw6FS4OKmvkNjhimcvP4gOeeW1z X92SFpxhKpI35j6qwZqp5/IBUEplJnn917LRTAIZoj0hYBGM6g9wAwCZ3JaZ+UzRUxTLYsUBHbz 6BFSF0ZmSXfNzc9+cnda0b67zqvSTYPXitOWj4NsnyEobfLOQZByO/4E3fEB2+r5WZ2kKOS5qIi p0ezrMvD77qlbaLOZdbUZT9Q+M7rR9xxKVY24dmRlvS98l/wvuUi0AoemYruPGPSp5Zy8uXmMWX 5f9dghzbIjJfbwKboZ6ih03hAVktK2bCQuYpNmhsCg4iMagKS0VAeNmoX0yPwhNf73z09O+r8f1 rHxqbZzdpm15jXD4SHulJsw9GnHE6DjR3vW7ScmSiOS0XCIws3XLDPgBEaaFnHb45Yg7pQgUV7V +BPlOjh+Ps7e0r/alqzNKGMEnBgbx+tBLWLfZ6QwkngORC4lPGbCmQXhT1r+nNKO3H4yIEMz4= X-Google-Smtp-Source: AGHT+IH18rYxk/+S9TGaATYnDltnQ9XBBZ+6uQG7n/MKLwdelr0BsNhSZG6QhmqksyeP3dqmI/lIFQ== X-Received: by 2002:a05:6000:4020:b0:42b:3302:f7d4 with SMTP id ffacd0b85a97d-42b5934e25bmr18741385f8f.22.1763492508813; Tue, 18 Nov 2025 11:01:48 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 07/18] hw/arm: Re-enable xenpvh machine in qemu-system-arm/aarch64 binaries Date: Tue, 18 Nov 2025 20:00:42 +0100 Message-ID: <20251118190053.39015-8-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492546877158500 While registering the ARM/Aarch64 machine interfaces in commit 38c5ab40031 ("hw/arm: Filter machine types for qemu-system-arm/aarch64 binaries"), we missed the XenPV machine. Correct that. Reported-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Edgar E. Iglesias Reviewed-by: Edgar E. Iglesias Message-Id: <20251117091253.56009-1-philmd@linaro.org> --- hw/arm/xen-pvh.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/xen-pvh.c b/hw/arm/xen-pvh.c index 1a9eeb01c8e..86a02966161 100644 --- a/hw/arm/xen-pvh.c +++ b/hw/arm/xen-pvh.c @@ -10,6 +10,7 @@ #include "hw/boards.h" #include "system/system.h" #include "hw/xen/xen-pvh-common.h" +#include "hw/arm/machines-qom.h" =20 #define TYPE_XEN_ARM MACHINE_TYPE_NAME("xenpvh") =20 @@ -95,6 +96,7 @@ static const TypeInfo xen_arm_machine_type =3D { .class_init =3D xen_arm_machine_class_init, .instance_size =3D sizeof(XenPVHMachineState), .instance_init =3D xen_arm_instance_init, + .interfaces =3D arm_aarch64_machine_interfaces, }; =20 static void xen_arm_machine_register_types(void) --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492570; cv=none; d=zohomail.com; s=zohoarc; b=YDxZJVBhVBhP4EOe2USxtsySqY2kRNxagUwYupytOtn98pMIlTJDVGxeYquk3atqw3QAsa+Cubrjt1OrgRMz2Lsfo+sIRFrti1sWaDQaonaHVlLeea44kYsBxBZMF/WH3hUEUolJ+DYxDCk6AZaO5MpCJK1gdKA9m6LetGxjJyA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492570; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=gXiO5nPfAcYV2Wewa5o/aax8KoL/hNVg9xCYOqbljoU=; b=Vd/k9Lsb0TsudFvdcTdbqvw+9aGu3qqK5Y+U/3HS3k24RHJ29T7icbMRppV0JfOLTLLrQSEHpGqJ1OIQrS+6KlBM+eHuqYmQjfEkxIpB1YnKuuEkecVsmOmo8Ifo9kS3RoGckg+H6YLDwLbtlnTH4K/F3SkTGKlNNEIyJ2eYbmE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492570788342.44075496675; Tue, 18 Nov 2025 11:02:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQy3-0000z5-KB; Tue, 18 Nov 2025 14:02:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQy0-0000r7-6T for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:17 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQxj-00063e-Qw for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:15 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-47775fb6cb4so42379235e9.0 for ; Tue, 18 Nov 2025 11:01:59 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b106a9b0sm4924475e9.11.2025.11.18.11.01.54 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:01:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492518; x=1764097318; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=gXiO5nPfAcYV2Wewa5o/aax8KoL/hNVg9xCYOqbljoU=; b=RcecxDpOPCNAAH7VMq0PyOOW5DnyJAU43FojxmrIgeszSn0KfVWQJlxZraoWlgTMfn POe/nkWtUC5VAELtCBWDGzNHQRXv8qCghpTmeGPlaS6hRPthbb8UujPswnUXcJQ5S9NG kOOJSnCaKUxEMhoUYDG7FC+rAFBiOhQMQdClq5OX7SEySx4Me92k9H+NU3zM/ImmQ0Cb XEefFIq1wAxVTL7dTT8TeHhrcKhE/5sY1ccif3dxDzbr2vOBRoDDaW2EvPPBB1jwmHMo /1zMObPIPhSz/AUXpJJmXLDq+XrfDMvbUNGtNZZMBiJBI36lYN+XNhUEbN99j9GQt44Z nZ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492518; x=1764097318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gXiO5nPfAcYV2Wewa5o/aax8KoL/hNVg9xCYOqbljoU=; b=abw0qZjI6leJZaaSmqYqQ0Gah5bBwgmj8CGyt+JpFSfZ/tQDfKMZfQd+C1TcyCoOkn mDVKZztfijIyIWRMTEaYv5wKHMpoyPDDA14/ADP4HT/tsnhfcvMGEppGnMD2I3A/k+ML 1iIf+V1C6Z8u6yaYPzsjuvIT0A0a44FpzKEV0lRJTKqjMuXNOHf/NT9e4PWXIfaRV3VO X60fsyUPLDd/XfmSC1LXpqJRV3dMcljTHwIZDbuZwB53QJH1W37cJHaPeVU8fxCOsN3a CgZCjwAY8/7fgShKXQl+NrewbmSBpc/fIcSRHN9XOLxdanRWoq06A2WMSx7o1SI2KopL kSeA== X-Gm-Message-State: AOJu0YyyiysT2j1AGziWOQchYbIV1PC0N5BkNrwsLpxjkESFKFFn9AW0 0mViirXPbeKBthqPIzV3K7mQhNROVgx8+xvHwpXlSSUy+Khk2P88EuG/ndD/hW7hv+87xKjZe2e cBT0ilKgZVQ== X-Gm-Gg: ASbGncukdp0GRSKDoieNZBl8WosFBKXl12C5G5F0hQqOQzTATgYkN4NZ+bmamHTlghE W/rdPXqPrAUZqMhxXouAOLQBeXjSbC1aaUxmYMjgEb3zdP0BB7Fi6W31ly1MV4pfHs7H4XTbFV+ szR8SCmGbH01GPIGn7BIZUHnU1S2IF4UHMlmXQa601g+D3hkqY56jXvLbfFyNkAeP2Zlz7h69wF AB342QzMWc/AOY+Qjl+pv4umsrk78XEY8Alrit/FsRK2Y4/sbjm8K+sKiQHWJC46bpspS0SrA2W s4vI2grCMo5yVmMWx4zCtCYg8WStrYi6GVOozaaPUA62BtRLQTOBICoPP31WDBSUNDcu3CbJJMh X47dayj/A0bj5gVeagVlCO82QXo62bQZmFHT574u1ojop0RGplcShRli/evgKzNJCSfEp9d6I7j S8EHS7tSXGs60PL1+xjPiGV7GWILzHufbiD4DqtdqrbicGITHjoT2qXI1/sW1uKkOYb7XUx2w78 enwGFKXIw== X-Google-Smtp-Source: AGHT+IFmW7hb3No794ZGBnkpEBuGFkQvoaUG214AuAgxt+Ks2pwKrZwSd1O0dUDExG7EAzEO8GmONw== X-Received: by 2002:a05:600c:4585:b0:477:54cd:202e with SMTP id 5b1f17b1804b1-4778fe59a0bmr167414665e9.2.1763492517763; Tue, 18 Nov 2025 11:01:57 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 08/18] hw/sd/sdcard: Avoid confusing address calculation in rpmb_calc_hmac Date: Tue, 18 Nov 2025 20:00:43 +0100 Message-ID: <20251118190053.39015-9-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492572776158501 From: Jan Kiszka From the source frame, we initially need to copy out all fields after data, thus starting from nonce on. Avoid expressing this indirectly by pointing to the end of the data field - which also raised the attention of Coverity (out-of-bound read /wrt data). Resolves: CID 1642869 Reported-by: GuoHan Zhao Signed-off-by: Jan Kiszka Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <4f7e1952-ecbd-4484-b128-9d02de3a7935@siemens.com> [PMD: Add comment before the memcpy() call] Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/sd/sd.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index df5a36fad9d..40a75a43ffb 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1160,8 +1160,13 @@ static bool rpmb_calc_hmac(SDState *sd, const RPMBDa= taFrame *frame, =20 assert(RPMB_HASH_LEN <=3D sizeof(sd->data)); =20 - memcpy((uint8_t *)buf + RPMB_DATA_LEN, &frame->data[RPMB_DATA_LEN], + /* + * We will hash everything from data field to the end of RPMBDataF= rame. + */ + memcpy((uint8_t *)buf + RPMB_DATA_LEN, + (uint8_t *)frame + offsetof(RPMBDataFrame, nonce), RPMB_HASH_LEN - RPMB_DATA_LEN); + offset =3D lduw_be_p(&frame->address) * RPMB_DATA_LEN + sd_part_of= fset(sd); do { if (blk_pread(sd->blk, offset, RPMB_DATA_LEN, buf, 0) < 0) { --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492582; cv=none; d=zohomail.com; s=zohoarc; b=icKlmei8iZNTTwqreG5/QPc1T48YR+SYT++MdnesnKfe6zc97TGhnRsWNllDKL5IQwJe/oQrrRW55CXbLK+EQuR9082zIDyMWsX35uVaIESiKa29WXev0NNbLW4Cd5U8/4KXsQGf4RsXlWzOgltOg2fIqxPLO4ptOALU0PM612k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492582; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=+qt8vwVa1HZgU3pdePfudr37pK0aeUekWhl0ULV6H2k=; b=TFMXSbo156F6n7dxwnQ6UTgPvSKhrqvS80ctJAKRB4aBMDE2PUyCl7XfQw/eYJCdXFJE8hQb2AQVG2qyxTwLlY6qj87ZMpTf8IVNjunQbhToSiaeqZkliKQzD+Djvol4wBs1l09BJxIUQE02GCCEnIcRIKAWrUQVaEz+EnrkPoQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492582480194.58770270794332; Tue, 18 Nov 2025 11:03:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQy7-00019i-Oa; Tue, 18 Nov 2025 14:02:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQy4-00013T-Ev for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:20 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQy0-000648-0f for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:19 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4777771ed1aso41154235e9.2 for ; Tue, 18 Nov 2025 11:02:06 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f19664sm34722822f8f.36.2025.11.18.11.02.03 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:02:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492525; x=1764097325; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=+qt8vwVa1HZgU3pdePfudr37pK0aeUekWhl0ULV6H2k=; b=oQcndevZam6h3O8c4XqxYl7suZlVmIsOO8tQ29dt/VHB2kygr4Q5PrNs5D6N1IJ+jF POAVeZmO8WGkPCrTQNa2QpaeqRtHx7eQD4RukmQMKMoOrfLbHYnNsC5Cw5QxK7Rwx9M5 0V9nm2w9eF28DfAHqA46FWt9qv2sbWktIwIYu4huuVkbFvd061jPZZuePfFflOjezW7K JYzIY+6jMKF89ueKtpmMQh0ZSw8DA3kAES7LEMHVr1PJZDBmMb9HJIcFMs0XomDURd8U sN0pxq45R+hwggKFGEqUYjo8xvq2KnWySbhPSAel0WmNHaKRXix8pdvubqvtJvTf+e6I GzgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492525; x=1764097325; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+qt8vwVa1HZgU3pdePfudr37pK0aeUekWhl0ULV6H2k=; b=is0AqQYHbM8tDnOC1qGHeM1seGRQVTidIn48z3TZ2NMn+Du8yBFqGVKbT/tkAqlSKl 3ZFnkO5TtgQTWTkYnAJ6Rf69Q9XnyT15zJ1nQgX44NGCnBA7Hqqrkd2EgBahkUzJ11oc NI5NAZLAMqgUn25Lv+BkieQxPUpvj6sBvVsAyt/Z/3zsi8bcewoO5Lko1llkmfWwNhDt QJhbFhy06Xvaid0DMjwTeSR5/1vuhkVdySTxCcOmNXtR5rC37RKjnmH700yBh3ifcIJr 7wFk3bk+xo+AEXjO1CR2KOsTIvwe1mUL5z5XiLu9YpX27ULXUODSgMboO2WM5IdiXVvy XGHg== X-Gm-Message-State: AOJu0YwpE6dQYisRy52F1NqfunycpARKyLXX1rUU0IITTfCVblO+dRul BvH2cX3t/0rt5ulwo6Nup9Id7Rz3YTLqJb7cOOnHRsa3u1MWqvt9DNiv8So6vio76ReLpDykP3T /SO9mpouzaw== X-Gm-Gg: ASbGncvp8oQyUZo1bLKvegTc9g2/XQQOHel5qKtaVKsT2z9Lwhwmqra7MTXGVsgWGV5 tDx+NlfVZIAWBlCsgtO8wRMtIpkoVfWdLezks65N2FfPQrzkHPYQZs8Jk0onUHmGgwIQTJkjpzP FyAxf7SCjZQFXWcMFwVZ8ZFHLHa/jeuM0deKOLrsRvg7m43VXnyemyLfHKW7tLcJaOYySl62wEE vTAOBM/FQMvj0eXs4hp3Z6Hla0dDwI0FEI3Hq1PeihJZg4AHzBDxbYu2+Eqv3foZ1vf+CQZ9L7s ouRdaFeyvdo+oj54rthDyKnj0S8Nz8sd3RUlJiEjpS60zoSknogDYHifBZnisaKDR5QceHyIUKL V8uxRv+81QPbFFYIAfSsyyEP2HfLqOAlQw3ei3wVYTiLbgYBwci+kfC+mKu/5oEnKUk41D2cRAh MqSOSGSD/4dk79IocdZx+OZGbstAq29W2eND5tzxbw8OFI6ZVV1GwkaYFX740o8/k4EbucKkY= X-Google-Smtp-Source: AGHT+IEaq365Tu8QIb33dokgmONZs2Px9DMjMP4er9cLNKpsYcyhpmBiolKNGRzkDkSt7fEv4UR8Wg== X-Received: by 2002:a05:600c:45d4:b0:477:df7:b020 with SMTP id 5b1f17b1804b1-4778fe7f6d4mr169725905e9.18.1763492524783; Tue, 18 Nov 2025 11:02:04 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 09/18] qga/commands: Include proper Solaris header for getloadavg() Date: Tue, 18 Nov 2025 20:00:44 +0100 Message-ID: <20251118190053.39015-10-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492611315153000 Solaris declares getloadavg() in : getloadavg(3C) Standard C Library Functions getloadavg(3C) NAME getloadavg - get system load averages SYNOPSIS #include int getloadavg(double loadavg[], int nelem); [...] Oracle Solaris 11.4 23 Jul 2020 getloadavg(3C) Include it in order to avoid: ../qga/commands-posix.c: In function 'qmp_guest_get_load': ../qga/commands-posix.c:1408:9: error: implicit declaration of function '= getloadavg' [-Wimplicit-function-declaration] 1408 | if (getloadavg(loadavg, G_N_ELEMENTS(loadavg)) < 0) { | ^~~~~~~~~~ ../qga/commands-posix.c:1408:9: warning: nested extern declaration of 'ge= tloadavg' [-Wnested-externs] ../configure relevant output: C compiler for the host machine: gcc (gcc 14.2.0 "gcc (GCC) 14.2.0") C linker for the host machine: gcc ld.solaris 5.11-1.3315 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Kostiantyn Kostiuk Acked-by: Richard Henderson Message-Id: <20251117203834.83713-2-philmd@linaro.org> --- qga/commands-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index c7059857e44..66f3e6f6733 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -43,6 +43,9 @@ #include #endif #ifdef CONFIG_SOLARIS +#ifdef CONFIG_GETLOADAVG +#include +#endif #include #endif #endif --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492558; cv=none; d=zohomail.com; s=zohoarc; b=IILKQYQA4MOJqa1RbECY05onkvMdCFz1OGhFmhByImn5Bo1E29r9z8l0Df1t8D8tuRBOkYp7Gf8x1hBK2dx3dLCY5nwfVYMGmRQ4fqw6pO6pyRpSgkWfdOiR/H6sL6yAhX1/2jjGuuEuYZxNs94ipXDDalzxGBc8sWhlLoXp9Ec= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492558; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=52zBhewqcn4T3m8Xjjm8OprozUFhcDO1Jmsc89Lvm6Y=; b=XTZyOE9bkOAeZi3ZkSeSjRyapHJCurUuBbueURVrpZMiIW0rqUkpZaN6vJb7986ZxNLOw+dGdaEM9KGk3PbRbv5OQmvXJaGbLlT1EEYVwt0kpUDSY38u5I3lgn7RjN9aiBs252hld6uZQQeSRUF2mxdSjG+DAmk7RIX5boamLVI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492558982295.6073560466235; Tue, 18 Nov 2025 11:02:38 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQy6-00016m-UJ; Tue, 18 Nov 2025 14:02:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQy3-0000zR-8H for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:19 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQxz-00064d-W9 for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:18 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4775ae77516so64141095e9.1 for ; Tue, 18 Nov 2025 11:02:14 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477a9e19875sm22161035e9.16.2025.11.18.11.02.10 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:02:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492532; x=1764097332; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=52zBhewqcn4T3m8Xjjm8OprozUFhcDO1Jmsc89Lvm6Y=; b=PPvK335PKMTbuBRmjFfWwxTWoK3lhwrHYr8p2t0K4dNBFHqLLBoCbMzy+uSl841EqS sOfK4viBWelw4LzxEAiH5dQtzaJxGHlEuh4CKC8J8WuUgLkp/wipNolhGXHUglNaQAKc FXeOCNL5W/dMRiabwgo6K2Ke4yL/tqCIa5DI0ML7zaUhwppF7W5pSNkJsicj6Jot/PzH i6CKCONnnCPl0YDCORypIN4l/P6LwTVTegYeQygGnoz0sJXSkZnBglwz0//jvQGSAbGh K4j/VGGXllLmimnNMAAlELf1ODMm2+f0TqQWd0bGMD6NnjXpGLP9rF/NEAA7TtfK0al7 nMvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492532; x=1764097332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=52zBhewqcn4T3m8Xjjm8OprozUFhcDO1Jmsc89Lvm6Y=; b=ai8OJwLINUPHlF8x/8H2H8zZ0ao/gnr7+XhDm5a32JiqLTg/Xs3kBcyKxyX72AOdli bP3vyCj7AKuUm00GgF3M8f52zaszlbzUSI/CFebiFZB//W++bkjJbKm/lAaKlUNPw0JS 9URccOCwHRDT0kqci8/1nx0k6+3bYWjy+QIEQjKZ602ZRLwk7bKSfkQfc9KWj5Mbz8Vb VQvLETYst0rsC7IryYm9lTdjy4bBnUa4ywjfgdnb+qKj3DxYHaKrsyKafc/djFB3l5Hd MAyoOqke2mPW+LkmVHCw/XA7gB8ahJ3hOSCoKPCFtqESdIhxrD9nAZcODzedOW3vD/kL p0bw== X-Gm-Message-State: AOJu0YzQeLHLN6ETA3kbE1rLak9PHr8ymx3U5f+9S4V9pLUEer0t0TGK w1nmFs7YwV6lpnsCrIll7wq45KIgG/7RnodhBsiXq+nXxowlAal4mBi4sHc+DZx4iZ/1pom3PrO f3IcHR4/XSQ== X-Gm-Gg: ASbGncvMnZTrfPG8pCr8ZhP0AZmLk80vBWHwLNeq7kkwXQMQ69P+TxnzVK8LcyDPvgN VbXTOyayq5pVlm+fuKAeO+7TVHUd/O+7/3NdLz1s+yxgqvH6o+4uiLcxBwR2rCaw0g7CTY/0F25 tPjcqGtTqahlHVNFTvxkmdI13hcSM6j2Q+qeQYqXf5cycI6y7iTNDh6/8a+pkH16YGTrUxRWTxd snElASvHB7miEjEib7CBYOQsXAx4rKEIdFrsQSrDxWWrJqDuU9AwyEJyMKRsxETGYlzBlkimgFW TMsl2FILtaoMWQZv0A4qqIqHegGmKFIduhkuQuPCWyaJSLtdA+zYxKmQj1PTz7SZ5eTxXTAdiSi EUUw+Mz9oYW0f2+ZQm0SRSUhqLf/J5HIa1Knizb2mHcX3bGoKTrk8lT85nQfT0vKL+dbxjQvE+9 eau+MD/S8TF2usXorFtlkzuu4lp1bdC1rOa5U7x8eMCKbdzA2xDSZlgA1u2dD2 X-Google-Smtp-Source: AGHT+IF+Ak4ucZXHxVvcZEbcdLb1WpTyub83hwVD/+i3PwI2AZb9aRcTDtVhHYhbDgBu160Z6nACxQ== X-Received: by 2002:a05:600c:a05:b0:475:dc5c:3a89 with SMTP id 5b1f17b1804b1-4778fea881fmr169331455e9.34.1763492532588; Tue, 18 Nov 2025 11:02:12 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 10/18] hw/southbridge/lasi: Correct LasiState parent Date: Tue, 18 Nov 2025 20:00:45 +0100 Message-ID: <20251118190053.39015-11-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492562291153000 TYPE_LASI_CHIP inherits from TYPE_SYS_BUS_DEVICE, not TYPE_PCI_HOST_BRIDGE, so its parent structure is of SysBusDevice type. Cc: qemu-stable@nongnu.org Fixes: 376b851909d ("hppa: Add support for LASI chip with i82596 NIC") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Gustavo Romero Reviewed-by: Thomas Huth Message-Id: <20251117091804.56529-1-philmd@linaro.org> --- include/hw/misc/lasi.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/misc/lasi.h b/include/hw/misc/lasi.h index 04312d0b589..0e95be1c32a 100644 --- a/include/hw/misc/lasi.h +++ b/include/hw/misc/lasi.h @@ -13,8 +13,8 @@ #define LASI_H =20 #include "system/address-spaces.h" -#include "hw/pci/pci_host.h" #include "hw/boards.h" +#include "hw/sysbus.h" =20 #define TYPE_LASI_CHIP "lasi-chip" OBJECT_DECLARE_SIMPLE_TYPE(LasiState, LASI_CHIP) @@ -63,7 +63,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(LasiState, LASI_CHIP) #define LASI_IRQ_PS2MOU_HPA 26 =20 struct LasiState { - PCIHostState parent_obj; + SysBusDevice parent_obj; =20 uint32_t irr; uint32_t imr; --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492557; cv=none; d=zohomail.com; s=zohoarc; b=Pjpr1QTC74F68zya1LAlkbI5eSZWvj70akUj/lK2ttLxXM+mmTQS0dybCx2xDsgMcV88ziQtwOJzQC+2AX06NRODVDZthKOvOz84GsqYopHpCTHUt43XrI0cmB2oRHSm/tyGg+mmNq7PPeKedQBWOrMHycGwfZjMHL3XlQqWBSk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492557; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ZNZo9fJs9S4N7ZWdwKkpgdguDs68+sTGv97Y8m+r5SM=; b=kOlslDlVN7qgbLKS15e5fgVW5YfhyjSfIY40tQpZNA8HQPC+Ln1+4zOR6/D6Imb32+p/57w7k4vDbc3ceVUbJQmkmioUdMTm/Kv98lyERRvE73ODOpCmgb8XV4tUIs9zOqgkOsxHKK5o35XqDt201IlI385PYO6UyFDf9ZFtvlY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492557493559.8798849186144; Tue, 18 Nov 2025 11:02:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQy9-0001M3-TC; Tue, 18 Nov 2025 14:02:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQy6-00018I-Pg for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:22 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQy5-00066D-AS for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:22 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-47774d3536dso1215705e9.0 for ; Tue, 18 Nov 2025 11:02:20 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477a974cdc8sm25469535e9.2.2025.11.18.11.02.18 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:02:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492539; x=1764097339; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ZNZo9fJs9S4N7ZWdwKkpgdguDs68+sTGv97Y8m+r5SM=; b=H9ocuRRexKyu1ObiQMg764kiVTkGQR2kkDuuGdQuSnkDpxF0EhE8bTJEiMGimwnfgt tVODPcn6fgFWvXwI9EXQEbfADZKa9IifHq8HSkME/2T7qd1VaYcFHn8QC/XAexQVvmDp fimfe3uvkpOqL6yPqlqGA6Jblx9jwwfPLT3XXwPAQvzJT8ptxCUhSmHrHKiJIB2tMGO4 BlN1aYg9zuai0lMJc2KUu7CU1RdEnZqOPJYuoygx37rOwwaB3oh4cMf5iSLtDOjlE8em JDxJXFGM3daqe33UviPKALqREP0mp7vucKEQlNf9NRzRBSMTlSl9mDEwYlaM/IB2ARLL mI8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492539; x=1764097339; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ZNZo9fJs9S4N7ZWdwKkpgdguDs68+sTGv97Y8m+r5SM=; b=dTDk8y4DUO5AMthODS8YFbpHxmETbmyoQvAjQEJBhunEIIx8WhKzCvZBXAQmBGu70U iNANRFZlZFX0FW7LQ+55zDv+/avEuMpqWGqcge0sBvHN5e1wAcLk0hf9p0pYHXMNiLqU oYb1r/+C5NWuie6tj1DNKVI+K68i6CK24rtaM4+q+E4I5N+OOpBPBE5lZSvhqQ44fSxO PEI8ioccbiqhyyO5A+tTVgTpzxZnSBsglrvvClgRboeWplPQFo63W4f9dHFkoCGl7o2G 5C0Cgj9hnS7zTt3nI2yG+Xs2hczvzYTeziQcgMkMt0JVRJ/mh0aOlGHaaS0SuQ8OE6nO 8eZw== X-Gm-Message-State: AOJu0Yzqj8zLMdAnPnwo8CGhspEsbYm6gZ/LFBYr/tQ+Mk4VTrdqMqE2 lnOp3cn4qE5T1d3QVJMq4Sj85EkENw80q1rnNjJovaJECMc1Y2C8nGExZUWzSIThdTkI7JXtCEV l+Y0wq8ZNGA== X-Gm-Gg: ASbGncv/5svorsdMe9U09NP/2vDpefuDJrQ2wQZwVCOexUGnQOvme8RA8sxGIPJoiFC TbDRxOP8XlMfT8bqs9Rog0Sjuy64sJ1G19UIhEJRYTWd9n6As0Lrxnk3FztXBBWwhv37vXlRSay lfu7FJu0dIEWQ0sm1YyPxEClfHbmael6T2bAcPiuuUWuqOZ4JLb+Basc+zKq4x9MaZA1cYcivoT 1scJcEpGmprraMJd0jbZPVbUoXCxAIC0NPKLwfrnYEEo5iP1sO89fDdp7pLsnPA0Ox1tntErYy4 cRFlUB3YwTk3nAXsdiE3vnY2/Vrlp4TZUX8AWVrZMt5nAO924d9TEaz7FvvjbavI7Jfe0JrClB5 hisUfmEp9Qf+irQtv3RUMgLiuzmWqficIH6mESgoU1PjBy7ieOHInzB2GTjzX1VFDRmanQ6ScOk UU+JcHbuZxzY1Mg2eXem5XGGp7ecf3M650E9crtNScukYYTF0HOYyyeA/2YRs5 X-Google-Smtp-Source: AGHT+IEZAer+RrGb5oFdpSd8pizypiZh5wZsdTI+CrKcXmDg3IUEpc3Isp81xs4i2QWJx0rEldj1Zw== X-Received: by 2002:a05:600c:314b:b0:477:a219:cdc3 with SMTP id 5b1f17b1804b1-477b0cbe7d1mr5926305e9.12.1763492539522; Tue, 18 Nov 2025 11:02:19 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 11/18] buildsys: Remove dead 'mips' entry in supported_cpus[] array Date: Tue, 18 Nov 2025 20:00:46 +0100 Message-ID: <20251118190053.39015-12-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492558786158500 Remove 'mips' from supported_cpus[], forgotten in commit 269ffaabc84 ("buildsys: Remove support for 32-bit MIPS hosts"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Message-Id: <20251117114200.60917-1-philmd@linaro.org> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index df4460035c3..5ddec8afd7b 100644 --- a/meson.build +++ b/meson.build @@ -52,7 +52,7 @@ qapi_trace_events =3D [] bsd_oses =3D ['gnu/kfreebsd', 'freebsd', 'netbsd', 'openbsd', 'dragonfly',= 'darwin'] supported_oses =3D ['windows', 'freebsd', 'netbsd', 'openbsd', 'darwin', '= sunos', 'linux', 'emscripten'] supported_cpus =3D ['ppc', 'ppc64', 's390x', 'riscv32', 'riscv64', 'x86', = 'x86_64', - 'arm', 'aarch64', 'loongarch64', 'mips', 'mips64', 'sparc64', 'wasm32'] + 'arm', 'aarch64', 'loongarch64', 'mips64', 'sparc64', 'wasm32'] =20 cpu =3D host_machine.cpu_family() =20 --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492575; cv=none; d=zohomail.com; s=zohoarc; b=NhHrLUq8abI2+1RHN+UwRCfxskIYRHACYawXAE9pfQeyxHU4uM7koW/bqgnNB9Ooq0HjxvtT/eiWlslh/PFeCdxx2tJSluKD0KoHHaQU3RlqX6Nhs7QICXrRibZ4AeL8YAR2q8xcVNbu/+w5rt96JNv4MJvvdZwDhWwlhRCElQM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492575; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=GYPvgDJyKQPbQRcUEUxfDE0G1cAgbiOOD5h9fXN0ghI=; b=d1cljI7HFad3Z0pXJ29Ic8OA/fVzOW2mEDZL18J+pYFYkEFh3LYrn9UiQFW0qu5mHhFbwbGzoQyEFMfYE+qztj7ip6rBY8ZZJZxaMk8dIub2Zgs9p/lWSAQpwBxVLx8mN802OalEhXhEdVPmUVZaQsIZGnpJFA9zrIo3X1t+WQ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492575957436.53258963464475; Tue, 18 Nov 2025 11:02:55 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQyI-00026z-6H; Tue, 18 Nov 2025 14:02:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQyF-0001uI-RR for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:31 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQyC-00066u-Jp for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:31 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-477aa218f20so7669725e9.0 for ; Tue, 18 Nov 2025 11:02:28 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b0ffc90fsm5899565e9.2.2025.11.18.11.02.25 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492546; x=1764097346; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=GYPvgDJyKQPbQRcUEUxfDE0G1cAgbiOOD5h9fXN0ghI=; b=zkpa8MH+m8JGsatrBNIKOizSH27JToQ0X+usNabgsSPZDR8iI/68MQ5wUs1G83v3kR 0IXoRXDVqpURmbfHvU4mnDKjPfMHfsD2BZuVfYZqVjFO7GgjEn7UsdQVmrw0gfakNO7F r/Pc+mAI33E36yrKl9Q1uVMF9aMT4H3A8CmhBvgrJAQ0brftLWtoOxph3OxvK+maFh5e qzcBa9Yn0O2jWhIUUWO9k+Z2ACtik59bO8CUwgBGYMT4d15yr0BSRK01WGZ/xPMErklW IJIOOepKu0xvsE4e7lbnwMEjdxtXSCRT0IgR7oaggUQYC4w3mjVnagl9RuULbmsLo5aU zejQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492546; x=1764097346; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GYPvgDJyKQPbQRcUEUxfDE0G1cAgbiOOD5h9fXN0ghI=; b=p4eOuvdvuxtVnDF8w7Muy/vkZ4GGHlacu5eGz2LQBOk6KRRv4fg/jvb4WBgSIxca2+ FKmEGoOt2rjTL/PCsy1NuMWe1NDwvHB8WR07GQBBhBhdAtzQppE/ieBYz3LEVVtORBb3 HdKENMQt8W09SVUmdp9idpPMOfP0NFQrCutPZgEGAwKyaEr3r1so/41Gsuow+rZKJb70 0b+IR3KFFDouE0RjIfaP9oNjxHvBMF/HA/2xs8U8vL7jH1ZGRHxj5Zqtli8NHDCXHELv NjZJiiDZgb7lm67NvghGFa5QY7hyJCHOhBoYZOSwanHsrhcYMDAK6Brh5hO0q2c9xY26 Sr/A== X-Gm-Message-State: AOJu0YzQv/1PUOk+iKaX0eBZtzB2lsZbtloy1uQ4QlxN6gs8KCYmvUfe e1gZJz0v86r1GNJJ80UkuYz9NzCvOMk5L9jwbMtCXX3y4qKCllj5dFtUaBT9eYLHDeoNQt9wepV JutgqRDnsqw== X-Gm-Gg: ASbGncsP5lSMHBNwlGJ3JaAUbqEd6y6j0ENjJKGEu7MQhur3DI53vAud964cRDVWxQK AWZhUeYtNJyoCteeVC4I1flkvGYp0jBlC6hqXmyCx1dBEs6VaaNDnJ31xNzAuzzgx6Y7qbCs6BO Sy+6uxK51bWaXhNhXnYscbQrNE42EX/3/6WLwM+BK5b9+NWaO7ZO3wac4tSOvy5XyLS3dkhV10h A+6PL/V/srB//Lwq7X3gOzsbx6/T+sqXiJ+KChAyzxcF9gxYoHgikTyT52Jr/5S17wmStXNcUw/ Jt4ot3o2PxFsEYVXXT4n0dHOuD9hr0gzAQ98D24KAmc0gmdQe5YqdV7Oi9gHnkecqNnCDFV4zOP PaXsnYderEESlsc4pS2hzdAZ3FGmuzY8758kZkEIujhsBxGi4VKrv+g04ISvpwlI0iYoF+KAsiL HzCCSwxSeyk+BAgbp0arzAuqZe+TZkG/75njH1h6PPYqpOIUhFOXIMpv0EGpKuOkz7jAKIw/4= X-Google-Smtp-Source: AGHT+IE4iRrHKXb8LZro41254zMjXM6ISaRTNY3io3+a7Q4K75k8s2QDnLfYms9aeicA7HXSzWS5Iw== X-Received: by 2002:a05:600c:1f92:b0:46e:32d4:46a1 with SMTP id 5b1f17b1804b1-4778fe96324mr162456745e9.22.1763492546422; Tue, 18 Nov 2025 11:02:26 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 12/18] migration/rdma: Check ntohll() availability with meson Date: Tue, 18 Nov 2025 20:00:47 +0100 Message-ID: <20251118190053.39015-13-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492578474153000 Commit 44ce1b5d2fc ("migration/rdma: define htonll/ntohll only if not predefined") tried to only include htonll/ntohll replacements when their symbol is *defined*, but this doesn't work, as they aren't: ../migration/rdma.c:242:17: error: static declaration of 'htonll' follows= non-static declaration 242 | static uint64_t htonll(uint64_t v) | ^~~~~~ In file included from /usr/include/netinet/in.h:73, from /usr/include/sys/socket.h:32, from /home/f4bug/qemu/include/system/os-posix.h:30, from /home/f4bug/qemu/include/qemu/osdep.h:176, from ../migration/rdma.c:17: /usr/include/sys/byteorder.h:75:18: note: previous declaration of 'htonll= ' with type 'uint64_t(uint64_t)' {aka 'long unsigned int(long unsigned int)= '} 75 | extern uint64_t htonll(uint64_t); | ^~~~~~ ../migration/rdma.c:252:17: error: static declaration of 'ntohll' follows= non-static declaration 252 | static uint64_t ntohll(uint64_t v) | ^~~~~~ /usr/include/sys/byteorder.h:76:18: note: previous declaration of 'ntohll= ' with type 'uint64_t(uint64_t)' {aka 'long unsigned int(long unsigned int)= '} 76 | extern uint64_t ntohll(uint64_t); | ^~~~~~ Better to check the symbol availability with meson. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Peter Xu Reviewed-by: Richard Henderson Message-Id: <20251117203834.83713-3-philmd@linaro.org> --- meson.build | 1 + migration/rdma.c | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 5ddec8afd7b..81f9f7b3287 100644 --- a/meson.build +++ b/meson.build @@ -2663,6 +2663,7 @@ config_host_data.set('CONFIG_SYNCFS', cc.has_function= ('syncfs')) config_host_data.set('CONFIG_SYNC_FILE_RANGE', cc.has_function('sync_file_= range')) config_host_data.set('CONFIG_TIMERFD', cc.has_function('timerfd_create')) config_host_data.set('CONFIG_GETLOADAVG', cc.has_function('getloadavg')) +config_host_data.set('CONFIG_ARPA_INET_64', cc.has_function('htonll')) config_host_data.set('HAVE_COPY_FILE_RANGE', cc.has_function('copy_file_ra= nge')) config_host_data.set('HAVE_GETIFADDRS', cc.has_function('getifaddrs')) config_host_data.set('HAVE_GLIB_WITH_SLICE_ALLOCATOR', glib_has_gslice) diff --git a/migration/rdma.c b/migration/rdma.c index 2d839fce6c4..337b4158899 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -238,7 +238,7 @@ static const char *control_desc(unsigned int rdma_contr= ol) return strs[rdma_control]; } =20 -#if !defined(htonll) +#if !defined(CONFIG_ARPA_INET_64) static uint64_t htonll(uint64_t v) { union { uint32_t lv[2]; uint64_t llv; } u; @@ -246,9 +246,7 @@ static uint64_t htonll(uint64_t v) u.lv[1] =3D htonl(v & 0xFFFFFFFFULL); return u.llv; } -#endif =20 -#if !defined(ntohll) static uint64_t ntohll(uint64_t v) { union { uint32_t lv[2]; uint64_t llv; } u; --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492581; cv=none; d=zohomail.com; s=zohoarc; b=Ypv/6dyLQMHLEuYd23aZIoqI4C+y1kCjnlKUZSFJbrLUjE1jWg5bMdIIRHuN7mLDKXQYXtHplbmtwqiVzHJ7/IxrcpsZ7kg2VlEM4pDkB8iqQ9CfODRkKvvlY4zuWFfNHYfdxnpG29kI9VjzSc6+cfxCWFlPUGlYPQkxe0A6lug= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492581; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=NSqRQ4ojfQt+N4Y7QwQa/NNLGa5GocKkvTSMNpgIAEg=; b=nEJO7FzbxxDSnYUgfx2AygL4I59U0cuqMBOmVK0icRgH8/qk/Wvb5AIZ4uRnJKoIKMI+zxEHvsmmoR4Vo59jGgJzlcxPYVv1s/Py0GM7BjSPhxgCBgc18fmB9MexDR7m9eOZHwf9gtzcxXYLYdJBkwoFEg+b342PPpRAjtuiTBg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17634925816071018.5638622611696; Tue, 18 Nov 2025 11:03:01 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQyU-0002V6-IB; Tue, 18 Nov 2025 14:02:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQyL-0002LY-7h for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:37 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQyJ-00067z-Bs for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:36 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4775ae77516so64145935e9.1 for ; Tue, 18 Nov 2025 11:02:34 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b0faed71sm6469205e9.0.2025.11.18.11.02.32 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:02:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492553; x=1764097353; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=NSqRQ4ojfQt+N4Y7QwQa/NNLGa5GocKkvTSMNpgIAEg=; b=tcYI2NqCv9S3CXy2z9Kr0WswMSw2RzlRDho4z7uosYqcefyu6VS8S/X+WfwUySoHOh 6bYVIdbfoij4Cgl7seuSphos3J6WH7h/ZRuMkjcaiplsISqXsrPD4mHoTwZvcZByWAdQ 88UjJZLyAEYUT8HI87HUqqS79VB/Arv/jsiWs/LUCdhY6WslxiieL6mG815wfM/LyjhH 7uVAMaH9BlhDTdiExzTAU7Boz/RVdRyZmX3alkl8gbyCbUNQydpWxckgukLKVjKjCQTP pX4Qn522JyMxrcJk5Hyww7ZGMoopC9PyTrE9SknU+j9fP4E4BEQZQ2Ox0RmuZY9QRkXB GkyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492553; x=1764097353; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NSqRQ4ojfQt+N4Y7QwQa/NNLGa5GocKkvTSMNpgIAEg=; b=Te0kFXp5eafJFydOZIGwNUCJHg2ez3spzPahBp4ZLUzhymuoNS6W0YpteM8jLljgkL qD9PVyNW+bg/xLE+wL9ziFAIjmHf9JrJCgwCQSzguTWc8BlfaS0mDUrcSnIKkUmOF/Qi rVwQRSBREbhw+Ym7Rmb8B+DnDm8ma1fTU5Y6dTNEJ/sPIvcrwevegE1BDqekkG0O9jhU 2yHMzBq3RwWbbBSD+8qv2ViZvdCr3TXLpRMGRs8QXZQAeQVQhqaTiliUJQ9LpAG327O9 MgMrObViAP+XXgWlxqctSBPRE+++4qFCiAqLM9ASLDH24lm5bKSCWCa6W61XeQ7OELs2 Cfqw== X-Gm-Message-State: AOJu0YyhQ4UbKcJO66pNBDti70i7uke86g25vRf3rcEXyxijuLrPkZ6b LwKRstz+lyOKYtujGks+xGBcKFcZEsfPETNM8fEJqO28wYOh9cs5PJelRU2bZ000obHFeU4D5U4 UfU6Uc5QRbg== X-Gm-Gg: ASbGncspiDPITkOKRKMu/PbGjBg5sDU7gHRfxmIQc9EZGCaZ+l3Vb/deVzN4sL/xqte D8HJfwmFSFqqTv9j30pqkuUHQpSFCmMvUhqAONhOgcbnMPEWryH/4S0s0ILpvluTVW83jydELut dFsU63oZKM/zZNqTj3lHPOrCUOCAKKMpLfh4SPeMm7vd7aK5o2erDa8C4SemA7uw4H44Gf5p81q FYqNXvOCim5sXigb/TkhE8A4WW8VkWnqx3rZSmJ04fBL9iMWTYgXaTNfo085U1tRMDmp2eBzLiE pc4Wd2m1xYQd49Ni3WWOlwISkutZU92rnFFCp1JjTupZadwYX4nnuIqvm5zixv0S7bE/lvAnT7M L1Ymgo49YdSrN2SWH1r1wcpafKzQlZzvvqH52R+PDCLMSvd6dbeb+OLUM82+0jG9zd3SwhC54ZZ UHi4406HC8fmt6JBALJbLF1f11b5eJ/LMh2IeWd3fVSQHxbl1EDaDHGSAeKh/I X-Google-Smtp-Source: AGHT+IGWe7Ks7mMbrLQ4HbZGe+IrW2Tk2me8upDgDQnkO9I7cxQxhrLjALUbgHRlg/QEBLn5JI8fag== X-Received: by 2002:a05:600c:3b13:b0:477:7b72:bf9a with SMTP id 5b1f17b1804b1-4778fea6797mr164520805e9.28.1763492553400; Tue, 18 Nov 2025 11:02:33 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 13/18] docs: Correct release of MIPS deprecations / removals Date: Tue, 18 Nov 2025 20:00:48 +0100 Message-ID: <20251118190053.39015-14-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492582844158500 We are going to release 10.2, not 11.0 :) Reported-by: Daniel P. Berrang=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20251117171236.80472-2-philmd@linaro.org> --- docs/about/deprecated.rst | 2 +- docs/about/removed-features.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 03e29915f0a..30ab72b2a4c 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -192,7 +192,7 @@ The ``info capture`` command is deprecated and will be = removed in a future relea Host Architectures ------------------ =20 -MIPS (since 11.0) +MIPS (since 10.2) ''''''''''''''''' =20 MIPS is not supported by Debian 13 ("Trixie") and newer, making it hard to diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.= rst index 88ea0dc4edc..a72df26dd24 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -896,7 +896,7 @@ work around the atomicity issues in system mode by runn= ing all vCPUs in a single thread context; in user mode atomicity was simply broken. From 10.0, QEMU has disabled configuration of 64-bit guests on 32-bit host= s. =20 -32-bit MIPS (since 11.0) +32-bit MIPS (since 10.2) '''''''''''''''''''''''' =20 Debian 12 "Bookworm" removed support for 32-bit MIPS, making it hard to --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492588; cv=none; d=zohomail.com; s=zohoarc; b=dsYVk9cvvtBW15TeJlJur8SPrKyVLtVLuEG2TTN18FZLcykA2Sjfa252kBoBMP9zBmlWLDL08PmwnFVU/ZnVmJkdovQfxmG/kcQXPA2ZtSFRVcOBCjqIx0CDvYIVmKIohBmzp4MOUlmOLxIRHObDTveDcSEXG7NYlxctMB9hAw4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492588; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=YIawoGnZ3yGM9VFzmHJj1+WDGKpqR5JZoplCF0M4Vjs=; b=nM4DHTuYguXor4fRhFDud5UPs7zFjc7jBmvwOOrgbcn6pvooKFfO6+q+mNFqu40kVBtbPEhpCbJYbSy/nSrvjcHooBZI8sa1848DxzN1XIXXBunTvmVXmkmubbigMgoWYRSIvnDLg7dzuSvJArqRbs98esg0f/d/PkXDPx2iCao= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492588100319.86092822572857; Tue, 18 Nov 2025 11:03:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQyc-0002kL-69; Tue, 18 Nov 2025 14:02:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQyS-0002V7-48 for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:45 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQyQ-00068k-H2 for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:43 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-47774d3536dso1218975e9.0 for ; Tue, 18 Nov 2025 11:02:42 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b0faf295sm6170185e9.0.2025.11.18.11.02.39 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:02:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492560; x=1764097360; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=YIawoGnZ3yGM9VFzmHJj1+WDGKpqR5JZoplCF0M4Vjs=; b=zVLUNJogoheJGK/6SqmfbfcdQCumwdhx6g/b4xMQQaoD+PptSSxUv8ulJp84f0fMtw BC0H5tgCJj8aKqiNkq/wtVV3wsrCHrSnrw0EUwShCmTAJm/7yR+9kEt2IPFCr1sRxKug 8bX/XGZwq8V2uX0/ydlLlqsMFIyz1z7wAnGy0Rp1N6qSNU+rNseSlizCRm8AXEjTfb27 dqztVcBubUA8RNfgddoyOlAxFPwIMmYHz6U23R2isYJjtIORba+upo/rYd12f9i0aqvY wW3r0lnrTXTLpT19AhwO8+/awZnFo6BoRCaozQa8UPOC4ZElyHbNkISQCW1ielztH8cJ AdrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492560; x=1764097360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YIawoGnZ3yGM9VFzmHJj1+WDGKpqR5JZoplCF0M4Vjs=; b=GJ4DMsPPNUiKB8DmOc2OIoC7mcolME9V+LyfMhJ1asqIKA7tNvvDOkL+iiBTh0Be9K FvaiAtB/NNWaMavCRykUARuBi/iTvhGFwrsLfPMECHVZ3BvcmYQ1IG5B6535iYDpuXQ1 EXBCPKws8cc9clKvmrqjpVzC0sScsUoRXFP74CF+UhmjGILuqvUtdKX3v4YeKQdZI3Je GksJA7p5RNyUHOVgOzgLzdFouszi/57MbZB+vOsDPAXRDHekTRDsxojWQcdlGBZX23yc CJPkssQDcJ6aaVVMyFdbHMF3LvdHzdUPKNvJPFiDLgJLXiHgZA/+Hzp01aHYDB1+xeBP PQgw== X-Gm-Message-State: AOJu0Yy0/CvNtvrwE0kH0i+G0yqQeMve47IGg2DdM/FZLOhuM+PP0FcR o0ZKyfLmR1i6DIOR8t1hrzy4GrQ9xXWDxI4VpBsVLllgeMCja/uuOYip37/vhe/bJQfTIO2Jcx+ CWzjbzCc0ww== X-Gm-Gg: ASbGnctYp7yH1wMY//ma5K58o1c15cHy0bVdtUFE8rqUUIAJax0S40HmMJJPR/8O+aW laUCSrMLufp5BgO5cP789bsxkSKvhO9nrL7VQarQoLNt5ADgQGSbvaeR6Gljw0mRhqTzYWbkpmq ewJUHAamTspOEjktZzFTMtwg9CjsZg7HGd4JoUMudG1FN9culN23R4RxNdqiz9s1+wJOZlZ3rvj CXaao3Vy4ZbWkFMqrQn7NtWZkbccVdGRFsLDgYblf4Z0rdoEsiIt+1ZVjEBH+HC8iMC7/pK7eyT Iop3XI6BOzo+i631kubUOXyE2fQvIEqsyTRnwNm3E2i/vw6m9Lli9dnhf2+YwC07Yno3KLy6/ZD X0xNLhzuycGzK5J6TFY5zcnOvqTWBtntv0TH3owz+7it5r3uj9+zEC+HuFAsNVnq0w1T11bbvZq B8dSkesZxV5/xCD8fkWGQPkSIzI0krTBbFwZrQ1Y5/9eAOc336kzNvYwM9gDCuCgNHk/9le3c= X-Google-Smtp-Source: AGHT+IEO3fBH4p9plNxTUbrpE3OkU2/Dy8bpuJqhldmc/e0dNydoPJO5JfBGCl3QqVpsScHwurEO2g== X-Received: by 2002:a05:600c:2e0c:b0:477:a53c:8ca1 with SMTP id 5b1f17b1804b1-477b0cd1130mr3593295e9.14.1763492560485; Tue, 18 Nov 2025 11:02:40 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 14/18] docs: Mention 32-bit PPC host as removed Date: Tue, 18 Nov 2025 20:00:49 +0100 Message-ID: <20251118190053.39015-15-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492588812158500 We removed support for 32-bit PPC hosts in commit 5c1ec5a1ee0 ("tcg/ppc: Remove support for 32-bit hosts"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Harsh Prateek Bora Reviewed-by: Richard Henderson Message-Id: <20251117171236.80472-3-philmd@linaro.org> --- docs/about/removed-features.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.= rst index a72df26dd24..422b9c98d35 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -902,6 +902,11 @@ From 10.0, QEMU has disabled configuration of 64-bit g= uests on 32-bit hosts. Debian 12 "Bookworm" removed support for 32-bit MIPS, making it hard to maintain our cross-compilation CI tests of the architecture. =20 +32-bit PPC (since 10.2) +''''''''''''''''''''''' + +The QEMU project no longer supports 32-bit host builds. + Guest Emulator ISAs ------------------- =20 --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492595; cv=none; d=zohomail.com; s=zohoarc; b=gen92r2F1W89W3wyp9j6lgqSVn/Bi3kCFxZgW1wS5BXB6HLmECDQcptc4XyUBCsWfw6yCtbuPYx2xXvuiMUMzMJLlAB3qpvd7Y51Hbg/9IUfL0jemuQcL4LUe1piFydpgqxWv9umP3yQrNSFXGbTp/L4EJ6lI2eB5P9hZzv6nqk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492595; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=SfS43SeyUePcyfLiF8UaeuQZGAk9CfbaaaGpJCmi7Ug=; b=KDP2zpfu7eBm5ZcrdISLEEfioPZQtizvGclVbRHhZsIkOuA1fCfQ3uZTqEAwANtL8ioAzRP16Vg4wD7IfBwFac9QRmc+mfMPhoLrF8zNqwUkB7CmgIWuGa1yXIpjObYS9croFjH1+iwOzD7X6uDYy2WX8aLU/XqVvfZbTr3PHRA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492595646314.4984873038811; Tue, 18 Nov 2025 11:03:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQyf-0003Ae-63; Tue, 18 Nov 2025 14:02:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQyZ-0002mR-O6 for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:54 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQyX-00069E-KF for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:51 -0500 Received: by mail-wm1-x343.google.com with SMTP id 5b1f17b1804b1-47796a837c7so23217125e9.0 for ; Tue, 18 Nov 2025 11:02:49 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b0faf295sm6175365e9.0.2025.11.18.11.02.46 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:02:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492568; x=1764097368; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=SfS43SeyUePcyfLiF8UaeuQZGAk9CfbaaaGpJCmi7Ug=; b=LWFLGQRXIsq3bhUbduBzbzlxzF9P8wxx22NzpyqI+9kLjnsiAUXAi+EvfxIFb4fo9/ 9Xl+W/sEqwpnfiFbBKJwO/RpQe3aYvJAs4SsYB7o6vxVtH1iGyxlGKCMOXSu9rGv9Cm1 Xdd2w8lrs5OMma9eTrtQxhk0FBpcxC8TL5u7vgZj4cAd/ZebMxNptSc7ayuvaKguA5Xy wv9jYzymZ8FhoqVKd0h+X1TQl3c6MxPCL1GrwhxPy+P8ISKid19QvBKUoDIXZf0fq38l s/Uyj2jglgzyVzbmGGMorTLb1x1OLo5jUy05WF3i+mCtb4oc7M1dPezOmyhU8XTfoy17 +iIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492568; x=1764097368; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SfS43SeyUePcyfLiF8UaeuQZGAk9CfbaaaGpJCmi7Ug=; b=CB9d/uv8QCYKHpyHx4Bi08BUhMuLuwJqB9t0sirTJDf6JMPRe1LcxE3KOMpKnky08C TSomacY2xgufNnBOpzNV5ktTvYXTEv/aMC45D/SQliP3Q71JUbiGQPo9Feqyek/iHmoK tm+RwUmU17i0aME81PcR7FOwEsJv0v1msPmlemziVDCwFie4z0iSHN74A+8lodcChaZV OEi1I3nt8uPAfLOlCmulLz8zPCcOl2KlpOrxE+bOXKqQz/ko+2w2GgjqVeg/6el9V5Yr m7opvsCW4xZb1XHzxtXcwRBbtJUwfaFkpnrzouBf9t1Qdxvk6Ota6H+aOBXbUqnEOGN7 TeKw== X-Gm-Message-State: AOJu0Yyc473jzE1UqWGZFGxlpgmAdKkNsKWHFEzAIPCGuVUFYyCJ6yOq Oh/eJE3Q73oR66Q00h9olquMAyS9OuaoVFlib2UFFBm9s4JkMe96c3ieBgtJnlymW2JvsX3HaE/ U59TJxv/Y63NN X-Gm-Gg: ASbGncug0yADIkdNRWFOrPWpVoxmuDvhcdOG0JKdffKj/Rcw5t31eGH7gILPyYg8vPw BEnH5zEhkfOZMWNO98f2GPO88G1z8OudX5nWR9LEXkJjBunoQxeON0hYlFiDCY+6rBcVRTZGmby XnmpXdcJc0KFHFq8/fAeK9/CeZuMR0tHKWFae9PQtXhJJwQ36Pk7xt4m2hCZah6lRzNYV6wKDSb haMaPLc6YjQwZ5CohpgNKYrxQDmfb7Zn+yZsVIQ1g1SSBXFo2AYA/7XR9owTHpRx49+U2eMDv8d M7CorBPbfb+OVjSf62qSACK7wO4qBLkJmAj1wsy/uuHl6t7QRYf8DI5vPdkkfPjfllCk5SUo9Db o1/P5BCRLkaFCsR8/SDiL/Dlsjn2wdcgjgGsGJnV9TPrF99P6N8XZFTWi1euy1N2/hJU71Sxpqp HrZopN/1mjMDKZor6aFcvJhB1AL5KKH5iAyEFFtrGZ/2SvTYwHMmumVCd6VjnpGB9JzzwYvzk= X-Google-Smtp-Source: AGHT+IGstbezbsirOy85ASs1DerzzvzIkTRVlysYfMN355uy25DpNWjDxr4hLQ/cgbl5biyBcVMcsg== X-Received: by 2002:a05:600c:1993:b0:46e:206a:78cc with SMTP id 5b1f17b1804b1-4778feb52b3mr154224175e9.28.1763492567889; Tue, 18 Nov 2025 11:02:47 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 15/18] scripts/checkpatch: Check DEVICE_NATIVE_ENDIAN Date: Tue, 18 Nov 2025 20:00:50 +0100 Message-ID: <20251118190053.39015-16-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=philmd@linaro.org; helo=mail-wm1-x343.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492596803158500 From: Djordje Todorovic Developers should specify endianess explicitly. Signed-off-by: Djordje Todorovic Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251118085758.3996513-15-djordje.todorovic@htecgroup.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- scripts/checkpatch.pl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d0f4537f25e..3a9557417f7 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3200,6 +3200,10 @@ sub process { if ($realfile =3D~ /.*\/hw\/.*/ && $line =3D~ /\baio_bh_new\s*\(/)= { ERROR("use aio_bh_new_guarded() instead of aio_bh_new() to avoid reentr= ancy problems\n" . $herecurr); } +# check for DEVICE_NATIVE_ENDIAN, use explicit endianness instead + if ($line =3D~ /\bDEVICE_NATIVE_ENDIAN\b/) { + ERROR("DEVICE_NATIVE_ENDIAN is not allowed, use DEVICE_LITTLE_ENDIAN or= DEVICE_BIG_ENDIAN instead\n" . $herecurr); + } # check for module_init(), use category-specific init macros explicitly pl= ease if ($line =3D~ /^module_init\s*\(/) { ERROR("please use block_init(), type_init() etc. instead of module_init= ()\n" . $herecurr); --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492612; cv=none; d=zohomail.com; s=zohoarc; b=CZ5USgIIdwZGMZq8erceDPnC8MjK0oFAZ4BZbUjWcQGykyr7ZIYtrX3OGRFPzzaeWcarh9hb7yBh/xZXKZjqrXOPNX+0woT9abssomrvLPifrYO49tCIrKaCBUAg0nAl8BebFxaXukQkcCln5xvZIqJf452zxiDHp7Q852SFk7Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492612; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=I5qCoWr7FI/cVd08v4vpwzDG2Q6hw19wH2p+V9v+2xU=; b=W3oLSLbPqdNR+pFd/tizv4qEtU3qOBCxkbjkZgewtuUOWuDlyQ/2KggLRfdfm8SOXnZJ6Z/jtgcIXXgMI/9w+1RJe3/3w3+LyYlAN+br08mub+I00V0uRguNcVjzhyGqy5txhKCu2zmW6UC5pvt4Wu6nmDWNYM6JDoNwSC0g53A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492612267114.17828651343041; Tue, 18 Nov 2025 11:03:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQz3-0003sg-8F; Tue, 18 Nov 2025 14:03:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQyh-0003RG-71 for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:03:00 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQyf-00069W-Fk for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:02:58 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-477770019e4so62382535e9.3 for ; Tue, 18 Nov 2025 11:02:56 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b102bc9csm5254775e9.8.2025.11.18.11.02.53 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:02:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492575; x=1764097375; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=I5qCoWr7FI/cVd08v4vpwzDG2Q6hw19wH2p+V9v+2xU=; b=OiCJhpAX1Ko6lM00GWG104eArKIqtcbfXM0WAvc7A0iGgd07955fstY2+JajyhOADn RnEVpy1w4dVQYi06p2CXaGhgnfRqxmBQwDnMnvOzeW7X5ZREZvjd6op7Zk7YUOT5UycZ iwgmwJ2oTWVBXEBYkTJWqoWfZXLizaaWzEc8d9qvdV0WzO3ayk8ZJxM9bCM3XI8/El8K 5AhTBdVp/SaQ636W70mKluY3SMSJzll1B+FuMy1ASPW2JPQZJiCKTEkkv3AfQ0NCfKMA CBv9rpvVe7901QmTdA0Boy1DYQ2XNed20fN/UmPRSoS2pQaZb2iPM1WQxtybxCLryOVI dp4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492575; x=1764097375; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=I5qCoWr7FI/cVd08v4vpwzDG2Q6hw19wH2p+V9v+2xU=; b=h84KF5yjUaNbw5vxLzVbfJe2+DUeSSnLQwl/4aIPDBRrar45QRYBxWEjLIRJ9y/D/8 vG2k56gChGcwtDuE5844hzN336VXrTUH71VFuCG8qnRiDuRavmp0dyJ90WhB1B5PI7i5 tvnXqcsrW/QgC6EKf6sAJfau4wLEXcz4uPWssv/uWYkyB+bp3JGz3iVCUwgdiC+zL3sX Rt3CLNE/lWKdeJlhEqMYcB+OX7E88Y3Pe/uK5Us5nCgTCTVYLVLFpvH+fGoFSFNSjCgk 5NfAQe44c+QaE4lekOXNKP1AS5piI6QhWjDfKAfHj0DeEOfxrhYUpw/P3GS1NEAWosCr EWPA== X-Gm-Message-State: AOJu0Yw1MhErJgMyo6HqudRrAHG5QAe9j+2yyAXBPKWVEXl2MbWhmKAK PsbjPKFsBZ9M6liePGpn9DgmIoHcNKI3bc8+GRm6/e2Fgn02HBomuXGUCDYIcAny6MbnnG+JQ3R UNL8lF/pI2Q== X-Gm-Gg: ASbGnctonD5HeCprK5I/T3yNL1f9x9fMwU4BsrEOoj+BsBK4g787W/2okOknDhIZcqd EUQi1bCijPnsXegD2AcbkZTEH/oEC8LlsWcP2/z/S1jY778guPgvPOJaxFDHydlx+WVEI0bIx8S UutmlyF+HFBn2NfJekPREWiAb74rAWHOPCuxAoEs3VIBt5ULWYzDhF7C/0YbeNqmx+BkkX9G2uL E0zzplnl+1al1lVoYe9ZtwfIRV13hqg12j3vqoUIEQfyzSm524cxV0CCtUb/li+jBl3KAJmuhzh Lq8P5lVcazc6Ox2yFNAJ4aCetCYM2Zcr7M+oSMVl1F72HLbjMD118rIJCrVhX2nD7i4zKBQynIv zVRSv/3YwmuV6d7cx/UQfhzjvDI4fJnQdpP+2lCVikOQ4JGFP1eidscCxu4zxmOwcKbiSLTCbOa GxVwDHi3TMxsjItyR9bFMJQZEXEABkk2L8Yyj4Mj3sG8uULosmcp/Pw1RRVS/blA6XpZz1KwLI2 8TaxcmuCw== X-Google-Smtp-Source: AGHT+IGybPjcgI1apLrf657Vds3uivmjeqYq6FjRfyheTFAM24+Z/Z1YVl44IWD9CH9c896dTjY+SA== X-Received: by 2002:a05:600c:12d2:b0:477:9cdb:e32e with SMTP id 5b1f17b1804b1-4779cdbe632mr70607795e9.9.1763492574919; Tue, 18 Nov 2025 11:02:54 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 16/18] ebpf: Fix stubs to set an error when they return failure Date: Tue, 18 Nov 2025 20:00:51 +0100 Message-ID: <20251118190053.39015-17-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492614936153001 From: Markus Armbruster Stubs in ebpf_rss-stub.c return false for failure without setting an Error. This is wrong. Callers may assume that the functions set an error when they fail, and crash when they try to examine or report the error. Callers may also check the error instead of the return value, and misinterpret the failure as success. ebpf_rss_load() and ebpf_rss_load() are reachable via virtio_net_load_ebpf(). Fix them to set an error. ebpf_rss_set_all() is unreachable: it can only be called when the context has an eBPF program loaded, which is impossible with eBPF support compiled out. Call abort() there to make that clear, and to get rid of the latent bug. Fixes: 00b69f1d867d (ebpf: add formal error reporting to all APIs) Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251118154718.3969982-2-armbru@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- ebpf/ebpf_rss-stub.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ebpf/ebpf_rss-stub.c b/ebpf/ebpf_rss-stub.c index d0e7f99fb91..11729f3d8fb 100644 --- a/ebpf/ebpf_rss-stub.c +++ b/ebpf/ebpf_rss-stub.c @@ -25,6 +25,7 @@ bool ebpf_rss_is_loaded(struct EBPFRSSContext *ctx) =20 bool ebpf_rss_load(struct EBPFRSSContext *ctx, Error **errp) { + error_setg(errp, "eBPF support is not compiled in"); return false; } =20 @@ -32,6 +33,7 @@ bool ebpf_rss_load_fds(struct EBPFRSSContext *ctx, int pr= ogram_fd, int config_fd, int toeplitz_fd, int table_fd, Error **errp) { + error_setg(errp, "eBPF support is not compiled in"); return false; } =20 @@ -39,7 +41,7 @@ bool ebpf_rss_set_all(struct EBPFRSSContext *ctx, struct = EBPFRSSConfig *config, uint16_t *indirections_table, uint8_t *toeplitz_key, Error **errp) { - return false; + abort(); } =20 void ebpf_rss_unload(struct EBPFRSSContext *ctx) --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492618; cv=none; d=zohomail.com; s=zohoarc; b=IBkUgkcP38ASrdJrrmtJjfZuSL/+bcF/uULN9PtjEm4HrQ2y8KlxYRuqEeFn6tREsujMjY3Fk6ijIFCx3UhQ7uhlDu6nl0Qo50wlTiuA7w68VSs9+x34dG4xSRNG04ZQhSKRrNGi7zoYvM6cNA6lborYup42UvP9Kk04PvFY1yM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492618; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=lL+h3l3mjGOMeapjYq15c/DanDIPYgu6VsVdxlpUb9Y=; b=ixGinycGJ1fhZw0YQIDB2G0mdETHEAcLAqAuGH65W0OLrp/s0p43WxrLU7AliJMiFvO1ceaHTI1k/oRVpmr2T3hXOoYZjWiW7ruISLr2UnftlQo2xalzh9ZPeVqcx6WnHQ38v0uIljFJ+fYsoUgZcUVskql6TAlrNE6GYZady9o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492618040685.9199329394839; Tue, 18 Nov 2025 11:03:38 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQzB-0004As-0X; Tue, 18 Nov 2025 14:03:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQyq-0003fh-Of for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:03:15 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQyo-0006AI-57 for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:03:07 -0500 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-47775fb6c56so59652815e9.1 for ; Tue, 18 Nov 2025 11:03:03 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f0b617sm33199614f8f.31.2025.11.18.11.03.00 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:03:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492582; x=1764097382; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=lL+h3l3mjGOMeapjYq15c/DanDIPYgu6VsVdxlpUb9Y=; b=LmyiGsKoYpmWwLDlx++jmC2tHBBn1HOD7TVHGYAagQWgnhItc2QBO9AIP4EwTT3vDH FYJxnTScHwKb9YNcZhbC60r+1yI8c3s5gMoc8r1rL5sZWZilMLSXiqSB40yq4h0sQvOP bI2HT1IcGoVGqN/hBvHBMqFh0q7EvZfD+VML9OFEdOFlFpWXFFC5uJWWXdzCGK9x4RdS 0+FSVeNxyMnNomSrWToZ68SykVyyAl3rfrbGG+ZMP/KRCfbewXIo3ole8sAt1bU8vl89 MSX4FXZMnbqRXgXUrAY2Mrg/ElmltKsZxJrfAxK0icK49RnimuaMKgiH2yQ6LxDPz+8k KyuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492582; x=1764097382; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lL+h3l3mjGOMeapjYq15c/DanDIPYgu6VsVdxlpUb9Y=; b=UlKWhW35JCo4ny2MutpoUK1oCFuYT7d7/+RqELDZvj0oUC47YOv0lb2i3urqNVfu7r Lqq41hIjzf7v3I9qdFgPK+5C8+/hSxSYak17qNiYxsk/OVV5sOpwhha5/v5Q0HGZ1Q0/ Dz5AFCS1nG5qcvB+3v2wIc/qKshE8lZpLFvudv2fnHDm1wj4smJHI2u5qfx4aQ+3H8Re +kM8H+qwGzjTpSxGx86abloHC+UiUrQnSKCzE49F+NtiC6xo/UbmtRcDThIGnjcoXqcI Ma+Fdput2+eJSOlmLYoWTumal2EVKY4PvJjSYxlYHXfNcXWgMcJJ6eV3MXhhcyJIgsCR cwlg== X-Gm-Message-State: AOJu0YwDor82svYERB5NsopsDsoTSaPn60MrBazxaI1ajZ9fzhCn0o6F U5cs0kZ4vo1faYSPDLmSZEYyew5EB5SUTCcanmMoQNJ/X518AHt+OvnVai7PQrU7RSrQT7hD1EG DY6NxvkWiTA== X-Gm-Gg: ASbGncstXolkrEE85PL6d4UW8emDsNQ5ZB9F4nE8HOL323PzFKhcwPUkpS8A41yLkNz 5MHxBGi/fWmDNgWvCxdbOrh0nubLQbMV3qIJbYn6uz0ft5XNXeB2WXOHDcCGCPMp+PKON8Z1jS/ 4KMZZWk+dJp7vkxq2q/1bzksDaR7UJqrlSltza9+brRC8PqGioThooXa8K8yVwhV+yM0TAdw8x9 WBmZq6YAiyQapRXIrKnPnQOHLeNBCmB/wb9s9puJZ+0b+iIx9BmJ27aZr4giiQXMUdHVNOWB6p8 O2vQJjjh/Rkk/gcha+XavhNncIELSJrODlHHZXOo1HbisNYpKIA+Hhqv9XQkpQ/c91ajRRgfbOx xl0XS+oLAwpM+K4Qs3mfckxzwQUd09KzdKO+hy9kmak8sm1mRH5N7pbq6CogTuALXdoaU3i5eo3 UWmEe2sZiToBa4SQ25s+wFwH4u1ac7q8oqOrGUDA8RZJGdVLPJDMAktn6h10Us X-Google-Smtp-Source: AGHT+IHxE9sYfA0A3CoSxqBnMHMtZFahP0+P9O8fDzNZiXUq4B1MBWSVST9R5XeHI9nggngL+ZDz2g== X-Received: by 2002:a05:6000:2f83:b0:42b:3c8d:1936 with SMTP id ffacd0b85a97d-42b5935241dmr16941084f8f.26.1763492581826; Tue, 18 Nov 2025 11:03:01 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 17/18] ebpf: Clean up useless error check in ebpf_rss_set_all() Date: Tue, 18 Nov 2025 20:00:52 +0100 Message-ID: <20251118190053.39015-18-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492618954158500 From: Markus Armbruster ebpf_rss_set_all() is only called when the context has an eBPF program loaded. Replace the dead error check with an assertion. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251118154718.3969982-3-armbru@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- ebpf/ebpf_rss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ebpf/ebpf_rss.c b/ebpf/ebpf_rss.c index e793786c172..b64e9da3e36 100644 --- a/ebpf/ebpf_rss.c +++ b/ebpf/ebpf_rss.c @@ -247,10 +247,8 @@ bool ebpf_rss_set_all(struct EBPFRSSContext *ctx, stru= ct EBPFRSSConfig *config, uint16_t *indirections_table, uint8_t *toeplitz_key, Error **errp) { - if (!ebpf_rss_is_loaded(ctx)) { - error_setg(errp, "eBPF program is not loaded"); - return false; - } + g_assert(ebpf_rss_is_loaded(ctx)); + if (config =3D=3D NULL) { error_setg(errp, "eBPF config table is NULL"); return false; --=20 2.51.0 From nobody Thu Nov 20 12:28:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1763492642; cv=none; d=zohomail.com; s=zohoarc; b=LDqLW7RMC8kZhJEVUQrXlpO1kdOBFwFjJuwpgJpHeCwS6X10O3KtoNrEqixnJBammHBmAZVstgHsAkjhlK6U336R23t3pXmuEyMXLVosGAwLosSLhpjJLB+wGN66dTYDvoD7uZg65PQh0Ey2F4Nf7b60mAW33EuyV1D3GuDsD54= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763492642; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=iA9seQt2cQMQ2VDPWWBkJdl2tQJiku0pCkEk7TgvXdI=; b=T736h0hax/0AwEoLVYmw0ZhhlprI8xP7LWjryo7dv7s5JVbpMLs2IsSYnEFmVFk4XWiyqoM8A8XP8ucmvLz4PYciocVjpverSrZrzYPrZeq+/M8F4K8MKhqJRVULIp9rXsgPbGAiQWniNmuqRktZzN2rnmzY8fUzEWny0HRKj3w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763492642757188.8677840716665; Tue, 18 Nov 2025 11:04:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLQzL-0004aq-58; Tue, 18 Nov 2025 14:03:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLQyv-0003ln-3B for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:03:15 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLQyt-0006An-9K for qemu-devel@nongnu.org; Tue, 18 Nov 2025 14:03:12 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4779a4fc95aso745855e9.1 for ; Tue, 18 Nov 2025 11:03:10 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b0ffc90fsm5931525e9.2.2025.11.18.11.03.07 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Nov 2025 11:03:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763492589; x=1764097389; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=iA9seQt2cQMQ2VDPWWBkJdl2tQJiku0pCkEk7TgvXdI=; b=XD1bRm3miottRcyQTfT4aUQpV7bDwhKEuuG3JIQMfeTWAOM7/d9WCRw8e2V2WAdLxU qLhdTZM1PrNpIQfanbh7nWK945sh8WPOTVN0ROUbHl6G9jtReTP9PkvO7pBLXkwPk7MF nBv5fZDEReJ4WTpb2eTmKxnIalCsUO2noFo3+pSmhw8i4pAXbsyPEi23KNrYZ11tDYeG /dEw/2OYUkdIj0Aj34fm6JvGY2qBG2aqrD+zMR7BwGirkLvRRPGpmi1XLWdmM8iUP6B/ JHyv/njdgCJWYGYfemCi15No8a6wzCfcEB3lefnEqzRM53NS9XSrvWtgJcR5KGnH+eNZ nVOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763492589; x=1764097389; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=iA9seQt2cQMQ2VDPWWBkJdl2tQJiku0pCkEk7TgvXdI=; b=K/EoZV7C2w2L5K7cDcDOsty4j/9yTV6oBS0RPcbvMTwAEAKWLZyM1wZc7mpKaCaVUA 0IMNNLPYryHYO66hlaSbfNx76V2BR6xPZdOAuDJ0VueO9jtpT+PgFf4xbHx6TmJN9N2Y a3m+x3TTocjenWneXpxr+r4K2k3aI1UfRYfur9DULaR9Cx+PrVenzlorAyHR2ji+FfF1 cJR+ocjKpNEVC/OUyi4ZJmTAcdHgiRoSuxRvXceG2THmJIVO5g7W512POh/oH2mFO+r7 HFbzFrvWAmDUq+eOO29XbfDpbgcLn8hO6+gJS86JIvcVbktO22A5Ul3p4dfZDDLyhNso NbMQ== X-Gm-Message-State: AOJu0Yy29oK1hUwFdjcXkhowYU+R8Jxelz5te2OqAGLJkzF+RF0J6fgh wxD0g2CsP4rkLbGSs8Y8CQUwoOvhRMkBRrxQUskGMka6srx8l0WeBQw0FrUeqBH2UOliOfJIABO corwv3IULsg== X-Gm-Gg: ASbGnctkjvI8+z3oFNosN2f9FOZvl6Hyd9ysew9VqYteUF6NracJLgpy8mbgi4v5Tgg DJP0jk0armOk5AeWAlwbkwsAQXvUoz7hJLZNzO5wfd5TBZzqZKgoWBt9hOlBLA1fQGTIzhPTKVK iUf/XzSZyJJa2jCRXqjGy1lw3GQqDYkS2vP9mLsbIhuMU5xZ967XxlYo/nh7A/jOprpUtHD8noG 9Gve+qssRkz3GpU2fm7VWOIJ0FY0EGoMWScTrIAN5sUqFqViJmeVUE21ArAmd/KgF8n4lglU4x5 /3RBFzDqJjAz8RlZlpLJcH3kvm/Q90I2agegQMTRwG9jhRUILk/CHeyqcc0a7MaHN0ix2i9YICo t3LVjEeAmJNwyXybkbZX8SA22Z3dcqp3C5vDGAeSecs5E6N+BUiCPExIGCwPMFxfuN1iQx7t/Gu kkv+8mI1ExqftDjgP4PRoDRBLSDiXlzYJVXWcBStg/muhZ7elA0OdabSR7F3OT X-Google-Smtp-Source: AGHT+IF4RIjl8tIpbJtHVzhHCMWkru0g+jiYz0ES9SwkfdWcGTdfoeleklz2s7oRrGAL/TWZ7YOjig== X-Received: by 2002:a05:600c:c8a:b0:477:9e0c:f59 with SMTP id 5b1f17b1804b1-477b0c9f337mr6400845e9.2.1763492588751; Tue, 18 Nov 2025 11:03:08 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 18/18] ebpf: Make ebpf_rss_load() return value consistent with @errp Date: Tue, 18 Nov 2025 20:00:53 +0100 Message-ID: <20251118190053.39015-19-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118190053.39015-1-philmd@linaro.org> References: <20251118190053.39015-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1763492642966158500 From: Markus Armbruster ebpf_rss_load() returns false for failure without setting an Error when its @ctx argument already has an eBPF program loaded. This is wrong. Fortunately, it is only called @ctx has a program. Replace the incorrect error check by an assertion. The return value is now obviously reliable. Change the caller to use it, because it's more concise. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251118154718.3969982-4-armbru@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- ebpf/ebpf_rss.c | 4 +--- hw/net/virtio-net.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/ebpf/ebpf_rss.c b/ebpf/ebpf_rss.c index b64e9da3e36..926392b3c58 100644 --- a/ebpf/ebpf_rss.c +++ b/ebpf/ebpf_rss.c @@ -106,9 +106,7 @@ bool ebpf_rss_load(struct EBPFRSSContext *ctx, Error **= errp) { struct rss_bpf *rss_bpf_ctx; =20 - if (ebpf_rss_is_loaded(ctx)) { - return false; - } + g_assert(!ebpf_rss_is_loaded(ctx)); =20 rss_bpf_ctx =3D rss_bpf__open(); if (rss_bpf_ctx =3D=3D NULL) { diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 3b85560f6f4..f5d93eb4005 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -1363,9 +1363,7 @@ static bool virtio_net_load_ebpf(VirtIONet *n, Error = **errp) return virtio_net_load_ebpf_fds(n, errp); } =20 - ebpf_rss_load(&n->ebpf_rss, &err); - /* Beware, ebpf_rss_load() can return false with @err unset */ - if (err) { + if (!ebpf_rss_load(&n->ebpf_rss, &err)) { warn_report_err(err); } return true; --=20 2.51.0