From nobody Sat Apr 4 14:22:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1763485644; cv=none; d=zohomail.com; s=zohoarc; b=RjaJLw7bWkBglLYJAElMM9rf7mGPdZeAPaHi8B9yeFcPcFSbfNl48N2VVaypka3iloB9fX5IXbjbgjJs8SSBhms8XoK+iexxg7ghr97JEjmI89bOfEsddWKXJlFNjgSlMtd0jx7tKTd2OlEqZxreY50SFvaMVmANLxbn9BOD14o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763485644; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6Nc2oEL9Mw1ggXqiNLuOpI5nlP8ISfwmioSj0M8b6ko=; b=GPE3uwlFUCXlV7rZ3jFXaIdM0KNI8JM/V8BwFbfnavKVq+uLtddf3fQAcwMlZ3j5ydo+Z9mTf0HR2t8W5IZAoOEF8x2tIYWTtxD/DKOZiyko4HSzDM1YaCKE/m8Ub2UxdT5MYNpGxfthBoLCHmFvAYT2v9pLfLA374J7kMqIMMw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1763485644793530.4340700250835; Tue, 18 Nov 2025 09:07:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLP7K-0000hL-7v; Tue, 18 Nov 2025 12:03:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLP7I-0000c6-Rp for qemu-devel@nongnu.org; Tue, 18 Nov 2025 12:03:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLP7H-0004qM-FO for qemu-devel@nongnu.org; Tue, 18 Nov 2025 12:03:44 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-100-RHvGxxutMxOLDBtNxiH34w-1; Tue, 18 Nov 2025 12:03:34 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3F69C180123A; Tue, 18 Nov 2025 17:03:32 +0000 (UTC) Received: from merkur.fritz.box (unknown [10.44.32.26]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8631E300ABAF; Tue, 18 Nov 2025 17:03:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763485422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Nc2oEL9Mw1ggXqiNLuOpI5nlP8ISfwmioSj0M8b6ko=; b=E9jsEmeMWLuelh1+1wWabod93YG2rXuPfW/oUQv8kUKj6kRoUcfPfZu1WZ9gX7LReRQHqn 0pvr7bfFpHxPu22aRxZrRD62KlUL9JoU23K1RkE4Vu0I8YUD28AOKiYlP7Pru+YzqDfTdk 33meSHCz+RLtn6qUb/ppPVc80TQiWsU= X-MC-Unique: RHvGxxutMxOLDBtNxiH34w-1 X-Mimecast-MFC-AGG-ID: RHvGxxutMxOLDBtNxiH34w_1763485412 From: Kevin Wolf To: qemu-block@nongnu.org Cc: kwolf@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org Subject: [PULL 13/19] qcow2: Schedule cache-clean-timer in realtime Date: Tue, 18 Nov 2025 18:02:50 +0100 Message-ID: <20251118170256.272087-14-kwolf@redhat.com> In-Reply-To: <20251118170256.272087-1-kwolf@redhat.com> References: <20251118170256.272087-1-kwolf@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1763485646967158500 Content-Type: text/plain; charset="utf-8" From: Hanna Czenczek There is no reason why the cache cleaning timer should run in virtual time, run it in realtime instead. Suggested-by: Kevin Wolf Signed-off-by: Hanna Czenczek Message-ID: <20251110154854.151484-14-hreitz@redhat.com> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/qcow2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index 05da589729..e29810d86a 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -846,7 +846,7 @@ static void coroutine_fn cache_clean_timer(void *opaque) =20 while (wait_ns > 0) { qemu_co_sleep_ns_wakeable(&s->cache_clean_timer_wake, - QEMU_CLOCK_VIRTUAL, wait_ns); + QEMU_CLOCK_REALTIME, wait_ns); =20 WITH_QEMU_LOCK_GUARD(&s->lock) { if (s->cache_clean_interval > 0) { --=20 2.51.1