From nobody Sun Dec 14 06:36:31 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1762957243; cv=pass; d=zohomail.com; s=zohoarc; b=X/OtSrqMC6+yjpw2DYdPQ3HALUUlH4v1VJOVTBuYJDu8GtEcUJWR0Cc0jKH0PbzjM/zcEJHTmg7jd4M5Ib2vLofdL9jsKR3NNDxzwS5MAVnPJMgkQM7NVwNRuzpYB7BcFwsJ+/s6TtfOr1RT23GbfK6fqCs5g9NyEANAar1srE4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762957243; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=17490A6VpKqSws1LjN+IUxHnh17ABgR5GhjKkbHNVaI=; b=dbPITA6Sqgy1TaYZ13T+zyV6Uj1ULHlifWqoz5K9WQbvgRo1FNlhW/AHh2XvOg9qH40zfHjjjeFH94rNuv/mfck9g81WbUZfa7vwGcSXTcwL8ts8RncSqD3ZDkF68gK0+sTS52zyhMzOulUDAOH1NKK4CKASIP6lo9mpWbhEKXk= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762957243478611.6830062017386; Wed, 12 Nov 2025 06:20:43 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vJBgm-0003sV-IA; Wed, 12 Nov 2025 09:19:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vJ5gl-0000WH-BA for qemu-devel@nongnu.org; Wed, 12 Nov 2025 02:54:48 -0500 Received: from mail-southcentralusazlp170120001.outbound.protection.outlook.com ([2a01:111:f403:c10d::1] helo=SN4PR2101CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vJ5gi-00036Z-Ew for qemu-devel@nongnu.org; Wed, 12 Nov 2025 02:54:47 -0500 Received: from BYAPR02CA0028.namprd02.prod.outlook.com (2603:10b6:a02:ee::41) by DM4PR12MB6352.namprd12.prod.outlook.com (2603:10b6:8:a0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.15; Wed, 12 Nov 2025 07:54:36 +0000 Received: from MWH0EPF000A6730.namprd04.prod.outlook.com (2603:10b6:a02:ee:cafe::df) by BYAPR02CA0028.outlook.office365.com (2603:10b6:a02:ee::41) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9320.15 via Frontend Transport; Wed, 12 Nov 2025 07:54:37 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by MWH0EPF000A6730.mail.protection.outlook.com (10.167.249.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.13 via Frontend Transport; Wed, 12 Nov 2025 07:54:36 +0000 Received: from honglei-remote.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Tue, 11 Nov 2025 23:54:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FIscrzcURn+gp5tlIIeUQKbR6neVtBSKgghnAV3nk7jGzSvNK0u4vjsR1H4uY7lge64Ee9ejmTLLHYKAtwUogArAY22AVEvdveSrrJ3UwTUQP5k5qwJ9mv2LJW7ZdhzNTlO8rT//WI9OJH5nFZKgzGcm/IJh7Qe9c0pIHMYx/NrutaRhgtyFkWJZnmmXBg7H8or5DoTldaCE3DctfBN/siBZmhu/NwCtmA+7NdDPcGEeRV6dgNLaBEVvxW0UqPJueC+xjcwq+cNrsCabWLWQbV5osZvFcGKZvpx7mSIkKSvEuKUD9MplVfVr6+dxSv158MQZtD2kh1y/bJFPFWQ8pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=17490A6VpKqSws1LjN+IUxHnh17ABgR5GhjKkbHNVaI=; b=hKjHcoFsTTH504iYsMCST/kZOYGZPYdPTOkePgU6X5qCeDviGl0oK77B3e1wrBwYOnK4NYkWDdgTB47Tw7FnfQXC4CVQBY2LJt/73S+VtJD582Usl/3neAkwimqwqhGJFdtDeaOyevv6z6owveUDOXQ6wSw2u8O7nsnHytUdRqd/goIVkztU/mjmJQ7L65XgWRCGEhwNt9aEJrbx2EhyOOa75NM6x9LwH3bzX8UOfndUYE61cp8QDPOG22bJKtYe2B88GYZXoJ8ZYXvYCzJwfVyJwr0sTVkr6czDAC5DPBQgRqLZON9CNzu1oFkskYwZlWq/ZROrGAOwbMSz83JKtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=17490A6VpKqSws1LjN+IUxHnh17ABgR5GhjKkbHNVaI=; b=M9m1T9rLkXlqy1pbPB3T4hv9T17p79TL4/AqsKPSdDTHHXmzmp+/xPQdDD5ecLYZhjVj107DEu7S6homo8ZzrMV3ZD/MHQGifdIHRHURdEFVVVg79n0Apsfmho848YOfLNN0g5TpkkejMAwgG5iSrr5HFtL20HK3qGYGZNPZ0G4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Honglei Huang To: , , CC: , , , , , Honglei Huang Subject: [PATCH 1/3] virtio-gpu: Add support for VIRTIO_GPU_BLOB_FLAG_USE_USERPTR flag Date: Wed, 12 Nov 2025 15:54:12 +0800 Message-ID: <20251112075414.3719917-2-honghuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251112075414.3719917-1-honghuan@amd.com> References: <20251112075414.3719917-1-honghuan@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A6730:EE_|DM4PR12MB6352:EE_ X-MS-Office365-Filtering-Correlation-Id: ddf6215d-c530-44ca-ec45-08de21c0b98a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FXPCmgaSuK43P0QAPtYk+bLw64nJG1Xaw10ZPWM8suddCBLq4SGOFJl/MAVi?= =?us-ascii?Q?IjkI53b+iTqOHw5+bVO9nIwSeoB77RYTlWe4N44aSC1JEQJiadskYTfDELH7?= =?us-ascii?Q?LGxAyxLevCsPtdU+DQKrQFjz3LEMzZqzR0iAxkw4wiU2SinJTrJ780KgzuI8?= =?us-ascii?Q?wXId3sNwgEf7MmBf96u/eWXWIZGe4XBMeuCibtjWTzprtHE2jLRWHEp5w/yA?= =?us-ascii?Q?pffHhfa8zrajSwP+Hw0l9X6ex57cYf+unsRunpEM7cRdjtCHAK4xn9lyjtPj?= =?us-ascii?Q?e5dWxSNSRx9/oC2R1Janz4DSDaGfgVgTdfQfJS1yPcxE4dAswjFxEwUz9Sbx?= =?us-ascii?Q?WChdAcn/j2Xj/BXH2qvBLO9zLhSkoIUnuHgr/FjR2598L3QxyAaiP3MJvzoI?= =?us-ascii?Q?5NrccG/aAw1x+FZ+r6P4CqziilKDMWc+y3fhKni/G7Djp6NZQt0V/0Q68FOT?= =?us-ascii?Q?olIbLtOPhq1+H+YMpLUm07OykaWr1v7j+zrgN9MpvwXCvNcB/Kl3PH3zETdf?= =?us-ascii?Q?hPRRRZNFEyu9NdgPHp9jxtw08hW/Ue4OWT8jz4Hz7Dmdie2mA3nApBsgoKpg?= =?us-ascii?Q?vwIcXFEc4o/WpmbxeyQtBxddj2IqXITrvcoEUNWD7uaMzsyw1qv82GSTTBGp?= =?us-ascii?Q?phjVwQ+X6Ewd9gc27MU63BhmudcWrxi7alWPhxf8vxe6cEMZkqvji/EHt0wd?= =?us-ascii?Q?oZWI7xjIKhq71qPTXKrJGYyRbjx5ESNVs3uZPte5PYJhfSTJiSmnIqdULFCN?= =?us-ascii?Q?IMHAwYv6f+9f7z3oCHUBGZockgRmkJscpgOMfZs0L+eSJJqBPCdQSzqQ8Rpq?= =?us-ascii?Q?7pgPOCBOtIClkpLKKUY85nYBKUdChfwkq79UpYJSAiDFp35LJt5OtCXfqxHM?= =?us-ascii?Q?l94jJooiEdgZ6aMkdNSXi3BxcaLErbUIY9oLhiZScG+t5e5Wz6frY4680blJ?= =?us-ascii?Q?KMFCF1VbzbYIEbcMlYB3gWfamivWYkpS7uQ3ZsBy8mtJ4CaU7r2YAObavQ7r?= =?us-ascii?Q?na0g3J8NCnE+3hhEoYxegsgIS2Guhfxnfyx21rMO7P3mUQguRTxeHXwQgCvo?= =?us-ascii?Q?xeUeJHTZpavS4/ZW7x9yIE9u5Sz1udI4vxNncNq4axJ2Y5SkTaciiuCCODXG?= =?us-ascii?Q?syZ0+vlXn4oRw04rKSeMHPDkuh9wY0Y5BdNTGdNL/sIH/H1a4TibAp+V4IFk?= =?us-ascii?Q?xVPCPVFQj1wcNHEQfwzKoxrgmrc/RP5pwuB5n91Hz13ocjjFyQw4o7qE7COo?= =?us-ascii?Q?+dHG2/KKa4UQdLY291whr0g8xhk4hdTDenCJxQ+GfNaHR52n0SW+OBv14uU2?= =?us-ascii?Q?0jJUiHRBswKVdGhVc9/Jxq5K23mxdoSojZIY+F0h/7V+qugqfB91UpB7FwCq?= =?us-ascii?Q?gPOvF7C1HeBs27m8KMSH0B/Taxwr3pKugv04EtdZ9kEVyviWvPnxN9iSh++z?= =?us-ascii?Q?7p3byoIw1AtkDxld24UqR1L/QpG5/fYY7EeKG31j4ti31Vm97UaCzfOW5dSZ?= =?us-ascii?Q?QA76NmqgQk9PuUVa3viDVZamCXtWzCaUlQt8mdIz32TU0zqplPQXatIwy/K1?= =?us-ascii?Q?CwaavBcVmwsRkiEEYMs=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2025 07:54:36.2173 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ddf6215d-c530-44ca-ec45-08de21c0b98a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A6730.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6352 Received-SPF: permerror client-ip=2a01:111:f403:c10d::1; envelope-from=Honglei1.Huang@amd.com; helo=SN4PR2101CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 12 Nov 2025 09:19:03 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1762957245255153000 Content-Type: text/plain; charset="utf-8" Add support for the USE_USERPTR blob flag in virtio-gpu to enable user pointer mapping for blob resources. This allows guest applications to use user-allocated memory for GPU resources more efficiently. Changes include: - Add VIRTIO_GPU_BLOB_FLAG_USE_USERPTR flag definition - Enhance blob resource creation to handle userptr flag properly - Remove arbitrary nr_entries limit (16384) in mapping creation - Add conditional handling for userptr vs regular blob mapping - Support guest_blob_mapped parameter for virgl renderer This enables more flexible memory management between guest and host for GPU virtualization scenarios. Signed-off-by: Honglei Huang --- hw/display/virtio-gpu-virgl.c | 21 +++++++++++++++------ hw/display/virtio-gpu.c | 7 ------- include/standard-headers/linux/virtio_gpu.h | 1 + 3 files changed, 16 insertions(+), 13 deletions(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 07f6355ad6..9da64bf16f 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -702,12 +702,21 @@ static void virgl_cmd_resource_create_blob(VirtIOGPU = *g, res->base.dmabuf_fd =3D -1; =20 if (cblob.blob_mem !=3D VIRTIO_GPU_BLOB_MEM_HOST3D) { - ret =3D virtio_gpu_create_mapping_iov(g, cblob.nr_entries, sizeof(= cblob), - cmd, &res->base.addrs, - &res->base.iov, &res->base.iov= _cnt); - if (!ret) { - cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; - return; + if (cblob.blob_flags & VIRTIO_GPU_BLOB_FLAG_USE_USERPTR) { + ret =3D virtio_gpu_create_mapping_iov(g, cblob.nr_entries, siz= eof(cblob), cmd, &res->base.addrs, + &res->base.iov, &res->base= .iov_cnt); + if (ret !=3D 0) { + cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; + return; + } + } else { + ret =3D virtio_gpu_create_mapping_iov(g, cblob.nr_entries, siz= eof(cblob), + cmd, &res->base.addrs, + &res->base.iov, &res->base= .iov_cnt); + if (!ret) { + cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; + return; + } } } =20 diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 43e88a4daf..956dc811fa 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -808,13 +808,6 @@ int virtio_gpu_create_mapping_iov(VirtIOGPU *g, size_t esize, s; int e, v; =20 - if (nr_entries > 16384) { - qemu_log_mask(LOG_GUEST_ERROR, - "%s: nr_entries is too big (%d > 16384)\n", - __func__, nr_entries); - return -1; - } - esize =3D sizeof(*ents) * nr_entries; ents =3D g_malloc(esize); s =3D iov_to_buf(cmd->elem.out_sg, cmd->elem.out_num, diff --git a/include/standard-headers/linux/virtio_gpu.h b/include/standard= -headers/linux/virtio_gpu.h index 00cd3f04af..b85e781a2d 100644 --- a/include/standard-headers/linux/virtio_gpu.h +++ b/include/standard-headers/linux/virtio_gpu.h @@ -405,6 +405,7 @@ struct virtio_gpu_resource_create_blob { #define VIRTIO_GPU_BLOB_FLAG_USE_MAPPABLE 0x0001 #define VIRTIO_GPU_BLOB_FLAG_USE_SHAREABLE 0x0002 #define VIRTIO_GPU_BLOB_FLAG_USE_CROSS_DEVICE 0x0004 +#define VIRTIO_GPU_BLOB_FLAG_USE_USERPTR 0x0008 /* zero is invalid blob mem */ uint32_t blob_mem; uint32_t blob_flags; --=20 2.34.1 From nobody Sun Dec 14 06:36:31 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1762957220; cv=pass; d=zohomail.com; s=zohoarc; b=bzz7wyZeRe5iriUsbSTsolWaYCUqT6UhVl6dEuS+EIs29B8GKzf5rlCmA2lud2P8EQmJuGJsk99IZNYpJxXgzoWHldBSljwjUiwHGcETS5Mvq1dzgkknhl4UdEpeOpWCUtAaCO6355eDLRKBFWxmrlS8j9ddwhQBUajObQ87f00= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762957220; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AZfkjAqHwQvF5b4CyD4zYNAlJRRnoe2uIYAfUTn62gc=; b=bGBMPXnvzvWnKSL0BY0Z/cOKXvEXhHjbibsPmzXu+OX13reV58m7+9emcZy37WGIDc71E5vErcjjYaMc/Bi6qooxqPaU1ZxpftLhcmeN3r2xqcZ1q+s9+gz4omk4rtc7YecoBjL19iZ+X/ur5Ei66pfv9SpzO8D30tWDzsAigSY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176295722009257.228275460130135; Wed, 12 Nov 2025 06:20:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vJBgl-0003rB-PW; Wed, 12 Nov 2025 09:19:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vJ5gk-0000VM-AL for qemu-devel@nongnu.org; Wed, 12 Nov 2025 02:54:46 -0500 Received: from mail-northcentralusazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c105::7] helo=CH4PR04CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vJ5gh-00036x-RD for qemu-devel@nongnu.org; Wed, 12 Nov 2025 02:54:45 -0500 Received: from BYAPR02CA0006.namprd02.prod.outlook.com (2603:10b6:a02:ee::19) by SA5PPFC3F406448.namprd12.prod.outlook.com (2603:10b6:80f:fc04::8e0) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Wed, 12 Nov 2025 07:54:38 +0000 Received: from MWH0EPF000A6730.namprd04.prod.outlook.com (2603:10b6:a02:ee:cafe::6) by BYAPR02CA0006.outlook.office365.com (2603:10b6:a02:ee::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9320.15 via Frontend Transport; Wed, 12 Nov 2025 07:54:37 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by MWH0EPF000A6730.mail.protection.outlook.com (10.167.249.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.13 via Frontend Transport; Wed, 12 Nov 2025 07:54:37 +0000 Received: from honglei-remote.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Tue, 11 Nov 2025 23:54:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QjSnriKggDsrvWj6s7mw8pDnwCQ5pPtwHwegHL35OTdaT71x/YRnJomSw+/rd9NxkhKbJsUnJs+JVaZbAKQE9wvXsjCY2zw1xlEExk/eoq5v/CiWyZ2+dwWRwqoFLeQsZVg56BsJ/ENpg2gjxb++DqeH0od7k4/H+2CNaiEW4BvjA+Zjz/ynlnBHf6m8leEYStVK+DdW5a0jI6Ux8CugWqxRnsHZR0K0srCZDr39bwDR4kmnP/+gv2jSyXhpABY6rhkHKBMuWDCYOPy7MgCagoJR3GWmPfpKgaqeNGWbi6qFrQCDVBvW4C1clPn6w8mBgR6xu9YF/TrD3D5yweqZ+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AZfkjAqHwQvF5b4CyD4zYNAlJRRnoe2uIYAfUTn62gc=; b=WK4Z7uQkubVTmeHjEp/ETZneYGia6qXn8ou4e6pVxMJZr0gt7FgDU6z3VnqT8TR0jfJWh6e0H091rU0ywEEc6+ZpWbcGgjTyzRVvuPeDsy3K4/GlGsvbqddRLmqbl8h1qtXsHEfdKL+Y2g1wravi+s6/cZ3bStQcBg59cDnjwfS34QndWDzASAwuOtEWRiiK0Fo2ga6Hg0OLejJFLQry0rfIevBpzPmgAcSg8px205mG0hNhd214fwmqysQd5mX2Uy6K3iZOBLJ4ieiwdZrXYuyKLRAWvsLeDd+Eg51PFgggpkReR/Te1ApF5VyIB3rs0TM9jzdU1bSCHx21OQzNgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AZfkjAqHwQvF5b4CyD4zYNAlJRRnoe2uIYAfUTn62gc=; b=nKJL5q/s13xE9KOAWT/XDlqZjpmpnzjQXCDmBP1WEZc3X/Tfm46Jm04nQdEk38qSIvTx6hgvS6mJukAxgvsfvIYYkt6L03S/x8AM/4RZE0kXwt/dYEjwB5UrgONe86QE7dxWTWA5NRhh/7ToQsHQsp7fSvX2Up3GUNt8nGnnMZ0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Honglei Huang To: , , CC: , , , , , Honglei Huang Subject: [PATCH 2/3] virtio-gpu: add configurable HSAKMT capset support Date: Wed, 12 Nov 2025 15:54:13 +0800 Message-ID: <20251112075414.3719917-3-honghuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251112075414.3719917-1-honghuan@amd.com> References: <20251112075414.3719917-1-honghuan@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A6730:EE_|SA5PPFC3F406448:EE_ X-MS-Office365-Filtering-Correlation-Id: ad3beda2-7721-407d-bed9-08de21c0ba86 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?GzpUMKcbkDAOqAuhXY3yDIx90+/v3CfmQejL0BpN8TfftywvN/daPTGdthDt?= =?us-ascii?Q?l0vFDBv3mRHghiQKnVE+aTGxX8eZPYmNgVpJP5DzzNntE3HyIsHPf5OE2FHC?= =?us-ascii?Q?PTJrc3FT3b3eov983CSdWBkHQvkQDh7au0sTghUtkwz3lqknDHJeGGkbLqDW?= =?us-ascii?Q?GkHcjpWmA0NRynH8QFWt1Ml6IS2mw9OC9qhyvhqJcpi6RaXdDM928KXt+ouQ?= =?us-ascii?Q?VhCtSLeU2geQDT7JaWnKJtXcs5wgm19sIVD4s+xI8txKUxVMiyeWchxcSgI4?= =?us-ascii?Q?v9aTmcLGyMX3LApCwJHNaYa4L4OJmUScMH0PWYaIQpOOXQD5NKsxQluXnGsV?= =?us-ascii?Q?rQyvdy73x4LrjSIdsojB4/I3xoGK8RHTPk9XwojmZxRlpUFKSO3HjdK7LgRg?= =?us-ascii?Q?KfSxssWby4WPNqdrnCSu/s9b6Ecyv2Nxbg6jy+ogm/+I3KUxHcwXqHUD5L4K?= =?us-ascii?Q?3BJMWuXIKA4cUtPoBu77QspStty9nU20Uxyf/ssVNTGlVdy6bcT4e+CDEyXg?= =?us-ascii?Q?/kA8EEQMXxKzDx7RA7aAq2CM27pLaH2U26sQh8EZEe04Vqp/B8a5Pz77JLrG?= =?us-ascii?Q?89JbyutPAgqlbkwm1Q2eu1Nah37BBBs4+xfBKscsVpkPnvVya1XqESEaKX5a?= =?us-ascii?Q?U3fwBPqujP9CJj3w+w7UxdHQIiuRoGyD7cTyaFl3/821Ck0luU0EhxEl+V9t?= =?us-ascii?Q?+E0w7/Hj1dDdWSbZDYo/PrHtdAFxFEQbVAaXfHIBzQBpetQCH81j3ffDmulQ?= =?us-ascii?Q?wzfqJP5TmBGUEZjyThN6NI9NHLVUlnbjzNhZSADHWN6iaMQgQn8r3jd1ASlH?= =?us-ascii?Q?5zev5e8yhkcjcqXmmrmLVCiiBvPrVi6km3nJJ6lj6IKrBIfmsJwLbW9vWGhe?= =?us-ascii?Q?deiVCSy5l91X5HDDTe3pFOacFGG1TsbjA5xZnGP4cX/NQERpZ2o26cUWyEAG?= =?us-ascii?Q?vd8A/nryi519WwFLAlPY9B8UuH4BUblmiwEA9mgOvtcNEjhPkCgMWiDrqvSP?= =?us-ascii?Q?rpYlUwN7bh4W3BzptyuOU/VxyrP5mNXRUaHWnUJGqUb4z5NDf9VtPGRESZaz?= =?us-ascii?Q?n+DkIqVDJrIqnYrgdI+i2DhwlWRORyPl04FldMtsA4zeY9uFW1rZMqJ0mB63?= =?us-ascii?Q?8d9n0mV8meqDoNlbpQehmoemG+4LMZNtDDwzvD++Ln3JhWczJmIkXKKdvOBe?= =?us-ascii?Q?kZdM31Z9GDv+y0uShwES9xk0sQVXvOvWMkjj3OwRqWhsKUlpUusRC+Z36cZr?= =?us-ascii?Q?kco3Ilww+ADt0RpIipMBsd0rW8agNDmHIQhR3s6gJO0QOmMcsqfkUKR0FMml?= =?us-ascii?Q?51z3ZIQowRwSievjLfCbDwGnnRyjJIe4KwNY9r11sbVS/AOYd0SfyVjUeac1?= =?us-ascii?Q?SQtPeWHs/yAVYl933zertLfTaQYvHu+f39FoM6eT2P3p8lnwxLbnRHIQ16ZZ?= =?us-ascii?Q?aC8qGkUwNiYBZhdvWVHbcIRBIjqw9nb5zj9xWBXHAGQ+PZsQiml6wHq+LiXI?= =?us-ascii?Q?E6WtcA+L3G4uGacDwPN2/cG/igdlOlZ+rMsCCe5ddf0In7NWPvTxEDAUC6QU?= =?us-ascii?Q?E3lYDEtQi240cckb3ME=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2025 07:54:37.8675 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad3beda2-7721-407d-bed9-08de21c0ba86 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A6730.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA5PPFC3F406448 Received-SPF: permerror client-ip=2a01:111:f403:c105::7; envelope-from=Honglei1.Huang@amd.com; helo=CH4PR04CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 12 Nov 2025 09:19:00 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1762957222992153000 Content-Type: text/plain; charset="utf-8" Changes include: - Add VIRTIO_GPU_FLAG_HSAKMT_ENABLED flag to virtio_gpu_base_conf_flags - Add virtio_gpu_hsakmt_enabled() macro for configuration checking - Add "hsakmt" device property to virtio-gpu-gl device - Modify virtio_gpu_virgl_get_capsets() to conditionally enable HSAKMT capset based on configuration flag and runtime capability check The HSAKMT capset is now only enabled when: 1. The "hsakmt=3Don" device property is set (defaults to false) 2. virgl_renderer_get_cap_set() reports capset_max_size > 0 Usage: -device virtio-gpu-gl,hsakmt=3Don This provides better control over HSAKMT functionality and avoids exposing unsupported capabilities to guests. Signed-off-by: Honglei Huang --- hw/display/virtio-gpu-gl.c | 2 ++ hw/display/virtio-gpu-virgl.c | 9 +++++++++ include/hw/virtio/virtio-gpu.h | 3 +++ include/standard-headers/linux/virtio_gpu.h | 1 + 4 files changed, 15 insertions(+) diff --git a/hw/display/virtio-gpu-gl.c b/hw/display/virtio-gpu-gl.c index c06a078fb3..4ed2f53e4e 100644 --- a/hw/display/virtio-gpu-gl.c +++ b/hw/display/virtio-gpu-gl.c @@ -159,6 +159,8 @@ static const Property virtio_gpu_gl_properties[] =3D { VIRTIO_GPU_FLAG_STATS_ENABLED, false), DEFINE_PROP_BIT("venus", VirtIOGPU, parent_obj.conf.flags, VIRTIO_GPU_FLAG_VENUS_ENABLED, false), + DEFINE_PROP_BIT("hsakmt", VirtIOGPU, parent_obj.conf.flags, + VIRTIO_GPU_FLAG_HSAKMT_ENABLED, false), }; =20 static void virtio_gpu_gl_device_unrealize(DeviceState *qdev) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 9da64bf16f..7162c4bfee 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -1227,5 +1227,14 @@ GArray *virtio_gpu_virgl_get_capsets(VirtIOGPU *g) } } =20 + if (virtio_gpu_hsakmt_enabled(g->parent_obj.conf)) { + virgl_renderer_get_cap_set(VIRTIO_GPU_CAPSET_HSAKMT, + &capset_max_ver, + &capset_max_size); + if (capset_max_size) { + virtio_gpu_virgl_add_capset(capset_ids, VIRTIO_GPU_CAPSET_HSAK= MT); + } + } + return capset_ids; } diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h index 58e0f91fda..c820247db8 100644 --- a/include/hw/virtio/virtio-gpu.h +++ b/include/hw/virtio/virtio-gpu.h @@ -100,6 +100,7 @@ enum virtio_gpu_base_conf_flags { VIRTIO_GPU_FLAG_RUTABAGA_ENABLED, VIRTIO_GPU_FLAG_VENUS_ENABLED, VIRTIO_GPU_FLAG_RESOURCE_UUID_ENABLED, + VIRTIO_GPU_FLAG_HSAKMT_ENABLED, }; =20 #define virtio_gpu_virgl_enabled(_cfg) \ @@ -122,6 +123,8 @@ enum virtio_gpu_base_conf_flags { (_cfg.hostmem > 0) #define virtio_gpu_venus_enabled(_cfg) \ (_cfg.flags & (1 << VIRTIO_GPU_FLAG_VENUS_ENABLED)) +#define virtio_gpu_hsakmt_enabled(_cfg) \ + (_cfg.flags & (1 << VIRTIO_GPU_FLAG_HSAKMT_ENABLED)) =20 struct virtio_gpu_base_conf { uint32_t max_outputs; diff --git a/include/standard-headers/linux/virtio_gpu.h b/include/standard= -headers/linux/virtio_gpu.h index b85e781a2d..6c54cb745f 100644 --- a/include/standard-headers/linux/virtio_gpu.h +++ b/include/standard-headers/linux/virtio_gpu.h @@ -313,6 +313,7 @@ struct virtio_gpu_cmd_submit { #define VIRTIO_GPU_CAPSET_VENUS 4 #define VIRTIO_GPU_CAPSET_CROSS_DOMAIN 5 #define VIRTIO_GPU_CAPSET_DRM 6 +#define VIRTIO_GPU_CAPSET_HSAKMT 8 =20 /* VIRTIO_GPU_CMD_GET_CAPSET_INFO */ struct virtio_gpu_get_capset_info { --=20 2.34.1 From nobody Sun Dec 14 06:36:31 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1762957249; cv=pass; d=zohomail.com; s=zohoarc; b=EoHPoHxcgoT8UfOH+xb0wrk+ANxgZYah1t2+KHvjSZPQmIXHzrr/vuXiTnxwVSVcLp6eCZYzLQX2wNBu7TNqiiYgwYZu2mTvNtiilMEEqHKvRMye2U2SW+xls3GJp9Mi0vRpL/UHcTvPkcFAyJE2IDbvt9oi+viO/ZGpe0u5lOk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762957249; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iFu4503ISJFeKGv67QIVk9I8pXGL+xv1E4okLu5nYIY=; b=QCFMNGmEIoKOjE0OGA4vcrsnH/bIguLNewOq6ldXCLR3UxG2GzdYNNQb3gG2f1ofqG+kk8URfLd593OKH3emr5JTWGNtWHS36/+laNnMtPVH8BSvFGCunR21tsSWMrFnii0TDStj7+if6lXLERenE224OWFR7ccpI7yHIYAjPYM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762957248960829.5108236173239; Wed, 12 Nov 2025 06:20:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vJBgp-0003v1-FH; Wed, 12 Nov 2025 09:19:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vJ5gm-0000Wj-G4 for qemu-devel@nongnu.org; Wed, 12 Nov 2025 02:54:48 -0500 Received: from mail-northcentralusazlp170100001.outbound.protection.outlook.com ([2a01:111:f403:c105::1] helo=CH1PR05CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vJ5gk-00037O-Ih for qemu-devel@nongnu.org; Wed, 12 Nov 2025 02:54:48 -0500 Received: from BYAPR02CA0021.namprd02.prod.outlook.com (2603:10b6:a02:ee::34) by DS2PR12MB9637.namprd12.prod.outlook.com (2603:10b6:8:27b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.16; Wed, 12 Nov 2025 07:54:41 +0000 Received: from MWH0EPF000A6731.namprd04.prod.outlook.com (2603:10b6:a02:ee:cafe::bc) by BYAPR02CA0021.outlook.office365.com (2603:10b6:a02:ee::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9320.15 via Frontend Transport; Wed, 12 Nov 2025 07:54:41 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by MWH0EPF000A6731.mail.protection.outlook.com (10.167.249.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.13 via Frontend Transport; Wed, 12 Nov 2025 07:54:40 +0000 Received: from honglei-remote.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Tue, 11 Nov 2025 23:54:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qJG/sJHVZ7TUr7tps1ykxRZ8nRJEmXVM2ODA8eDtLC8lZSR6cksM8mXXj3IDV1zUd+WK/bLMhmXyuC1ObPeREAdfVKZP4PPerX/JvHy9gKAIul7ZXNNjbkk0TfM1LHC+QLDE1mIADoiftOu9bjXHR1vWB9vw6ycgqOJmpJFSzjIcxQC9brl98pOY8kERMjXm7YOzlzXhkoBCTESNumNlZ5YDTnaRhXAIvdQ1o+BdejBvnzpOESEKGXTy+2DF2ICV+3qaNXPfBXKJTERG1xIaNr4J75YvZpgdFMOe3NKlNERnOGcqSCFERY3DXxqC5ww6SojwzzjcTmXa/Aqy4s7hdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iFu4503ISJFeKGv67QIVk9I8pXGL+xv1E4okLu5nYIY=; b=EPeVg68VAP+QteUdrsItoKZyMGbGAhY8XE5pelzZ/nqHAMFTv3XJ+2QB10igZ3Jx1P58szcuDCLCcnKQ+Q99k37rgNAoW0PcNZAk0ZTPERropT7IwxpRNcU/ZXXlzf/edy/uFQedhoiE+UH3fSa99OKi3yFmZtNdzUyBPiPKr50hF8rrSMSGpHnjhvSgASgamojBTzt3tBrbm/lw3oodqi06wms52OvepHLsQhUUhpoNA3J3CRDs5O7w/qtoKfcoeo9dRQUpODCR4t1RWzW9GpqJKWhZEVgMm4MRokOnoLyNTHR7hVy/NjZFOdgRlmMtwnNIT7txpmbcZ4gVWwa3Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iFu4503ISJFeKGv67QIVk9I8pXGL+xv1E4okLu5nYIY=; b=g2c3I+Mu6i4T5oP/mGYKhREbJYMpN9LrOJ4X8cYIOTJxwZnqm5F+1Zp7a4YzTA+dH/FamDbxQoue4s1djSBwKVrrbaW0DygxgfEfkrXEAduRhQVrkhGQYzCNJHWYIWONYb7ic4YJogYreHy62pVey70Rlv7D/lCKm6p6a3/b31c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Honglei Huang To: , , CC: , , , , , Honglei Huang Subject: [PATCH 3/3] virtio-gpu: Add VIRTIO_GPU_F_RESOURCE_USERPTR feature support Date: Wed, 12 Nov 2025 15:54:14 +0800 Message-ID: <20251112075414.3719917-4-honghuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251112075414.3719917-1-honghuan@amd.com> References: <20251112075414.3719917-1-honghuan@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A6731:EE_|DS2PR12MB9637:EE_ X-MS-Office365-Filtering-Correlation-Id: d5d295cb-f665-4dc7-2da7-08de21c0bc3f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?UZlY0Sr8LxjtwD6rLyg6NHjxTW0gBron0H856hivB7XIXtvL4i3ycWa9QCG+?= =?us-ascii?Q?EXhlWsc6ymN40PMjN7P+4TgbccuxPYPR5j3sk/saro+nxH1lu08RD+SQrzKP?= =?us-ascii?Q?2GR4fHkEcHKNh3IbRLL6XWjc0msHZrZ+3XiBhLtqE/fCgOeLpeiWueqS2GX7?= =?us-ascii?Q?8f+viqoqJyrx+UaXxNL9P8fg3XJWnwQZ8eFicFUFMN8fzeoRC52uH5iSSc22?= =?us-ascii?Q?ep/MaNvmwubWzcc4C2qLV/enzRNd3EC1BFRhwKR7bsXqhFK7YqdV1IdYZkw3?= =?us-ascii?Q?nPzdhwyA/Xzsk89903S/WFMUFG3zLUTunJ9rFjaU8elqzT/miLI0UrGxIuH9?= =?us-ascii?Q?v5B5ZR2CZfUWU0Qy2daRXCTO7HurNnL6G+OZ6JYcHIHknes6mpDWw1BBo5dN?= =?us-ascii?Q?lw+xmQ902tRFL8/H9gzcS91wDH52+rDLiw8rHd7Q4xL+YWPtmo6f0Aw0a/Z5?= =?us-ascii?Q?4rzMru5FNfAfpF1F7qNrjfeDcHDPT800W0KJ9NSeJwPRCdbYHjv7OuN025hI?= =?us-ascii?Q?HyKalMTKk+n4+9uVHOIpYMnCeN9ZCqzf8M/Eju5wchVDaYJJT707tRqVZrIZ?= =?us-ascii?Q?JTOvdvHlHX25Yxdck0bB872lyLrNwn9ruh2ZqCEBTPjtQCrEEpVHCfv9mZjH?= =?us-ascii?Q?Q1/fjk+WpxldzOXftOVhK+GjvakPBNq/1t392wa81bUgt+z5Nas2IRxsW8gF?= =?us-ascii?Q?zvk4xIuvlrLyl6uDOPSq7Hk849oRFJFoq4hy1HZcHUNPMthfPOr+QUzCqBwW?= =?us-ascii?Q?iDP6U0dxMKXjZ89ynYPxiWGiiOXlT7MSYaiGj+NMngl/xTShRo8qkKnOM3qK?= =?us-ascii?Q?PxYtf2p0K9BQXezdbPDm6NwpBZjKJrdc7nlQugsWRVB8Wmzk9OM8HPuzlqiF?= =?us-ascii?Q?ZDkargKeUcJwpg24//Fu1E1BOowm7HfuM98jZiiLH3l2SfAI2qvNFELtV6Oe?= =?us-ascii?Q?zwt5c2MCr391i2Iwi6GagS5l2B77auAAf17ph8lXKtuUIgs2m2MJgJCAjncI?= =?us-ascii?Q?j9LuIW6DzQnc+GFdyAteg807Slwr6LAVZzvRLkvZkSIgiURhrd5k9jJ6/aEj?= =?us-ascii?Q?ZI30fUXl8G6TaEW7UmBbdKAnZ7jUfIcBl7NiNrQiBsHV95F4hlbZaFXBLc91?= =?us-ascii?Q?BIdPGWRTiEKzeJHQBDIKOOFVLV+NnUd3By74cXz73XL1mcfyBO630g9gArGQ?= =?us-ascii?Q?ryrI1h/SS79HanJR/v8McOvSqwV1zpph2SQGZ2KwshkzyiqnjBFpssOZ9XOH?= =?us-ascii?Q?ew5kiPEK3lp+8zNxr1Rr6yDAM264KPpIzWjggfoOsY5AWVpYWoDgmrE5MhV4?= =?us-ascii?Q?lDLKPm3iZQFNlmS6tEobHnCyaWUvsTko+TfkrJJBs0eIwDjXvYJ1smJVPmnF?= =?us-ascii?Q?E19Vt82DtYQ1HIDAaJL+4PWsCL3y2UUrJYRgSlHFW7hI1zllBhw2ZfrWWaV0?= =?us-ascii?Q?XJ5j2BXYlzhGoZaBlNTNxgVZzlC/nZLfm2Re9D3sG2s4CLkuwjfS4RphgQuL?= =?us-ascii?Q?ch1Y7YUStp1V2HN0iBEfmcZq/YH3sm7G+uyYfEAVDBXbX90F9AzShoTBIiT6?= =?us-ascii?Q?CpZP0eyBlMVAquNe7tc=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2025 07:54:40.7544 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d5d295cb-f665-4dc7-2da7-08de21c0bc3f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A6731.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS2PR12MB9637 Received-SPF: permerror client-ip=2a01:111:f403:c105::1; envelope-from=Honglei1.Huang@amd.com; helo=CH1PR05CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 12 Nov 2025 09:19:05 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1762957250027158500 Content-Type: text/plain; charset="utf-8" This patch introduces support for the VIRTIO_GPU_F_RESOURCE_USERPTR feature in virtio-gpu implementation: - Add VIRTIO_GPU_F_RESOURCE_USERPTR feature flag definition - Implement resource_userptr property as a configurable option - Add VIRTIO_GPU_FLAG_RESOURCE_USERPTR_ENABLED configuration flag - Enable feature negotiation when resource_userptr is enabled Usage: -device virtio-gpu-gl,userptr=3Don This feature allows virtio-gpu to support user pointer resources, enhancing memory management capabilities for GPU virtualization scenarios. Signed-off-by: Honglei Huang --- hw/display/virtio-gpu-base.c | 3 +++ hw/display/virtio-gpu.c | 2 ++ include/hw/virtio/virtio-gpu.h | 3 +++ include/standard-headers/linux/virtio_gpu.h | 2 ++ 4 files changed, 10 insertions(+) diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c index 7269477a1c..f013a4ece6 100644 --- a/hw/display/virtio-gpu-base.c +++ b/hw/display/virtio-gpu-base.c @@ -264,6 +264,9 @@ virtio_gpu_base_get_features(VirtIODevice *vdev, uint64= _t features, if (virtio_gpu_resource_uuid_enabled(g->conf)) { features |=3D (1 << VIRTIO_GPU_F_RESOURCE_UUID); } + if (virtio_gpu_resource_userptr_enabled(g->conf)) { + features |=3D (1 << VIRTIO_GPU_F_RESOURCE_USERPTR); + } =20 return features; } diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 956dc811fa..5f1dc80060 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -1685,6 +1685,8 @@ static const Property virtio_gpu_properties[] =3D { 256 * MiB), DEFINE_PROP_BIT("blob", VirtIOGPU, parent_obj.conf.flags, VIRTIO_GPU_FLAG_BLOB_ENABLED, false), + DEFINE_PROP_BIT("userptr", VirtIOGPU, parent_obj.conf.flags, + VIRTIO_GPU_FLAG_RESOURCE_USERPTR_ENABLED, false), DEFINE_PROP_SIZE("hostmem", VirtIOGPU, parent_obj.conf.hostmem, 0), DEFINE_PROP_UINT8("x-scanout-vmstate-version", VirtIOGPU, scanout_vmst= ate_version, 2), }; diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h index c820247db8..ff68f3c451 100644 --- a/include/hw/virtio/virtio-gpu.h +++ b/include/hw/virtio/virtio-gpu.h @@ -101,6 +101,7 @@ enum virtio_gpu_base_conf_flags { VIRTIO_GPU_FLAG_VENUS_ENABLED, VIRTIO_GPU_FLAG_RESOURCE_UUID_ENABLED, VIRTIO_GPU_FLAG_HSAKMT_ENABLED, + VIRTIO_GPU_FLAG_RESOURCE_USERPTR_ENABLED, }; =20 #define virtio_gpu_virgl_enabled(_cfg) \ @@ -125,6 +126,8 @@ enum virtio_gpu_base_conf_flags { (_cfg.flags & (1 << VIRTIO_GPU_FLAG_VENUS_ENABLED)) #define virtio_gpu_hsakmt_enabled(_cfg) \ (_cfg.flags & (1 << VIRTIO_GPU_FLAG_HSAKMT_ENABLED)) +#define virtio_gpu_resource_userptr_enabled(_cfg) \ + (_cfg.flags & (1 << VIRTIO_GPU_FLAG_RESOURCE_USERPTR_ENABLED)) =20 struct virtio_gpu_base_conf { uint32_t max_outputs; diff --git a/include/standard-headers/linux/virtio_gpu.h b/include/standard= -headers/linux/virtio_gpu.h index 6c54cb745f..321477598e 100644 --- a/include/standard-headers/linux/virtio_gpu.h +++ b/include/standard-headers/linux/virtio_gpu.h @@ -65,6 +65,8 @@ */ #define VIRTIO_GPU_F_CONTEXT_INIT 4 =20 +#define VIRTIO_GPU_F_RESOURCE_USERPTR 5 + enum virtio_gpu_ctrl_type { VIRTIO_GPU_UNDEFINED =3D 0, =20 --=20 2.34.1